Commit Graph

5327 Commits

Author SHA1 Message Date
Mikhail Filimonov
3f5e5eb15a
Handle not implemented cases properly 2020-12-14 15:31:05 +01:00
Mikhail Filimonov
f6097cf818
Adding DETACH TABLE PERMANENTLY 2020-12-14 15:28:59 +01:00
tavplubix
dd2ae6926d
Merge pull request #14849 from ClickHouse/allow_atomic_database_inside_materialize_mysql
Allow Atomic database inside MaterializeMySQL
2020-12-14 16:27:13 +03:00
Maksim Kita
14dedae9f1 Updated sql test file 2020-12-14 15:50:11 +03:00
Maksim Kita
55f991adde Updated test 2020-12-14 15:23:53 +03:00
alexey-milovidov
0bc2603b1d
Update 01081_PartialSortingTransform_full_column.sql 2020-12-14 14:14:59 +03:00
alexey-milovidov
ab17927c85
Merge pull request #18032 from kitaisreal/array-aggregation-functions
Array aggregation functions
2020-12-14 14:11:09 +03:00
alexey-milovidov
d55c5bec94
Merge pull request #18053 from azat/librdkafka-snappy-UB-fix
Fix possible corruption in librdkafka snappy decompression
2020-12-14 13:59:11 +03:00
Maksim Kita
d8534ae1af CreateQuery create as select with columns specification 2020-12-14 12:30:08 +03:00
Vitaly Baranov
a98e2311f8
Merge pull request #17908 from vitlibar/fix-checking-introspection-grants
Fix checking introspection grants
2020-12-14 12:10:17 +03:00
Pavel Kovalenko
346c241c20 Merge remote-tracking branch 'origin/master' into s3-adaptive-single-part-upload
# Conflicts:
#	src/Disks/S3/DiskS3.cpp
2020-12-14 11:00:30 +03:00
Azat Khuzhin
bf23bc6f0c Fix 01600_remerge_sort_lowered_memory_bytes_ratio flap 2020-12-14 10:52:04 +03:00
jianmei zhang
f829fbb928 Merge remote-tracking branch 'upstream/master' 2020-12-14 11:21:42 +08:00
jianmei zhang
2169e8f7f4 Fix issue #17160 by adding show settings like '...' 2020-12-14 10:33:51 +08:00
Azat Khuzhin
2e569899d1 Add a test for kafka with snappy compression method (regression for UB in snappy)
I've checked it manually and it works with clang build and does not with
gcc (there are NULL bytes in the middle of value).
2020-12-14 00:38:07 +03:00
Vitaly Baranov
9310437920 Fix access rights required for the merge() table function. 2020-12-13 23:34:53 +03:00
Maksim Kita
0be51cbabd Updated tests 2020-12-13 21:27:48 +03:00
alexey-milovidov
d8484d9c31
Merge pull request #18033 from ClickHouse/encode-xml-rename-files
encodeXMLComponent: rename files after #17659
2020-12-13 18:28:52 +03:00
Alexander Tokmakov
7f7eed4031 fix test 2020-12-13 17:57:15 +03:00
Alexander Tokmakov
0c80fce7f0 Merge branch 'master' into allow_atomic_database_inside_materialize_mysql 2020-12-13 17:56:50 +03:00
Maksim Kita
5d6036e9c8 Fixed style issues 2020-12-13 14:38:56 +03:00
alexey-milovidov
bce02de691
Merge pull request #17539 from azat/remerge_sort_lowered_memory_bytes_ratio
Add remerge_sort_lowered_memory_bytes_ratio setting
2020-12-13 04:38:50 +03:00
alexey-milovidov
8df4789113
Merge pull request #17845 from kitaisreal/space-saving-remove-last-element-from-map-fix
SpaceSaving remove last element from map fix
2020-12-13 04:09:51 +03:00
alexey-milovidov
04e222f6f3
Merge pull request #17986 from azat/fwd-decl
More forward declaration for generic headers
2020-12-13 01:12:05 +03:00
alexey-milovidov
4887d59b06
Merge pull request #18027 from Jokser/fix-flappy-log-family-s3
Fix flappy test_log_family_s3
2020-12-13 00:39:41 +03:00
Maksim Kita
0dcbcec19a Added tests 2020-12-13 00:29:09 +03:00
Alexey Milovidov
ef064696e7 Add perf test 2020-12-13 00:17:37 +03:00
alexey-milovidov
2eabd41749
Merge pull request #17659 from nautaa/master
add function to escape charaters for XML
2020-12-12 23:43:41 +03:00
Azat Khuzhin
41bc43325b Make 01290_max_execution_speed_distributed less flaky 2020-12-12 17:43:10 +03:00
Pavel Kovalenko
c2c497e290 Use s3 disk explicitly for log tables in test_log_family_s3. 2020-12-12 16:44:19 +03:00
Maksim Kita
07c8293043 Added tests 2020-12-12 15:08:46 +03:00
Amos Bird
a0f4dfd948
get back tests 2020-12-12 13:59:33 +08:00
alexey-milovidov
0d6fe7121d
Merge pull request #17887 from sundy-li/trivial_count-fix
disable optimize_trivial_count in query with array join
2020-12-12 02:44:07 +03:00
alexey-milovidov
adbe8e1ebb
Merge pull request #17903 from ClickHouse/attach_table_from_path
Implement ATTACH TABLE name FROM 'path/to/data/'
2020-12-12 02:42:53 +03:00
alexey-milovidov
656a9222ac
Merge pull request #18000 from ClickHouse/filimonov-kafka-flaky-test
kafka test_premature_flush_on_eof flap
2020-12-12 02:29:26 +03:00
Pavel Kovalenko
59a5e63417 Merge remote-tracking branch 'origin/master' into s3-adaptive-single-part-upload
# Conflicts:
#	src/Disks/S3/DiskS3.cpp
#	src/Disks/S3/DiskS3.h
#	src/Disks/S3/registerDiskS3.cpp
#	src/IO/WriteBufferFromS3.cpp
#	src/IO/WriteBufferFromS3.h
2020-12-11 18:28:41 +03:00
Kruglov Pavel
a8c1d17f83
Merge pull request #16935 from ucasFL/agg-func-setting-null-for-empty
`aggregate_functions_null_for_empty` move OrNull ahead
2020-12-11 17:11:39 +03:00
Kruglov Pavel
6300cd285f
Merge pull request #17909 from Jokser/disk-s3-send-metadata
Ability to set metadata when put S3 object
2020-12-11 17:01:14 +03:00
Maksim Kita
4ae5619714 Optimized erase in HashTable 2020-12-11 16:54:08 +03:00
Maksim Kita
bf5d75853c Added erase into HashTable 2020-12-11 16:54:08 +03:00
Maksim Kita
bfceb06659 Fixed test 2020-12-11 16:54:08 +03:00
Maksim Kita
d8b78682e1 SpaceSaving remove last element from map fix 2020-12-11 16:54:08 +03:00
Alexander Tokmakov
ed355f8663 fix 2020-12-11 16:50:45 +03:00
Vitaly Baranov
1b3893bcab User with allow_ddl=0 cannot do DDL but can grant DDL. 2020-12-11 16:38:49 +03:00
Vitaly Baranov
648be453a4 User with allow_introspection_functions=0 cannot call introspection functions but can grant INTROSPECTION. 2020-12-11 16:38:49 +03:00
Alexander Tokmakov
58a31e4882 Merge branch 'master' into allow_atomic_database_inside_materialize_mysql 2020-12-11 16:14:03 +03:00
Alexander Tokmakov
f9f7da5f97 fix 2020-12-11 15:06:19 +03:00
Alexander Kuzmenkov
fb1221148d
Merge pull request #17748 from azat/custom-TLD
Add ability to use custom TLD list
2020-12-11 12:42:19 +03:00
filimonov
8e2ca9518b
Update test.py
adjusting timeouts a bit, in the good hope that it will prevent flakiness of the test.
2020-12-11 10:13:03 +01:00
nauta
00dc104025 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse 2020-12-11 16:15:40 +08:00
Amos Bird
5b1e5679b4
Add -SimpleState combinator 2020-12-11 11:43:56 +08:00
alexey-milovidov
2fb7ce8340
Revert "Date vs DateTime64 comparison" 2020-12-11 01:09:01 +03:00
alexey-milovidov
c35c52be87
Merge pull request #17867 from ucasFL/mergetree-setting
Add settings `min_compress_block_size` and `max_compress_block_size` to MergeTreeSettings
2020-12-10 22:54:05 +03:00
Kruglov Pavel
9a785dbbf5
Merge branch 'master' into disk-s3-send-metadata 2020-12-10 20:17:41 +03:00
Vladimir Chebotarev
39d867e56d
Added proper authentication for S3 client (#16856) 2020-12-10 12:19:42 +03:00
alesapin
dd9f4bfc8a
Merge pull request #16877 from ClickHouse/complete_zk_api
Fake in-memory ZooKeeper server inside ClickHouse
2020-12-10 10:47:54 +03:00
Azat Khuzhin
f68a231a46 Fix installing top_level_domains for tests 2020-12-10 10:19:51 +03:00
Nikita Mikhaylov
80d4af9a73
Merge pull request #17874 from nikitamikhaylov/calendar-date
Merging #17750
2020-12-10 00:19:04 +03:00
Azat Khuzhin
0f1d9f3a6f Put top_level_domains into the docker/test/performance-comparison/config
Since in docker/test/performance-comparison there is Dockerfile that is
runned from that directory, so it cannot COPY anything outside of it.
2020-12-09 21:08:31 +03:00
Azat Khuzhin
352a1eea34 Use new top_level_domains_path 2020-12-09 21:08:31 +03:00
Azat Khuzhin
9b6b2b175f perf: merge custom_tld.xml/first_significant_subdomain.xml into url_hits.xml
v2: smaller table for *firstSignificantSubdomain* (max_threads=1)
2020-12-09 21:08:30 +03:00
Azat Khuzhin
8b6256dc4b Add performance test for custom TLD
And seems works with the same speed as default (that uses gperf):

- cutToFirstSignificantSubdomain

    SELECT cutToFirstSignificantSubdomain(URL)
    FROM datasets.hits
    SETTINGS max_threads = 1
    FORMAT Null
    SETTINGS max_threads = 1

    0 rows in set. Elapsed: 0.904 sec. Processed 8.87 million rows, 762.68 MB (9.82 million rows/s., 843.61 MB/s.)

- cutToFirstSignificantSubdomainCustom

    SELECT cutToFirstSignificantSubdomainCustom(URL, 'public_suffix_list')
    FROM datasets.hits
    SETTINGS max_threads = 1
    FORMAT Null
    SETTINGS max_threads = 1

    0 rows in set. Elapsed: 0.909 sec. Processed 8.87 million rows, 762.68 MB (9.76 million rows/s., 838.83 MB/s.)
2020-12-09 21:08:30 +03:00
Azat Khuzhin
8875767b87 Add a test for custom TLD 2020-12-09 21:08:30 +03:00
alesapin
850f903d40 Merge branch 'master' into complete_zk_api 2020-12-09 18:18:38 +03:00
Vasily Nemkov
a2f85a03f3 Enforcing all sorting keys to be present in DEDUPLICATE BY columns
Updated test and minor cleanup
2020-12-09 18:08:37 +03:00
Nikolai Kochetov
32b38f389e Merge branch 'master' into async-read-from-socket 2020-12-09 17:15:36 +03:00
Nikolai Kochetov
effc94daaf Added perftest. 2020-12-09 17:11:20 +03:00
Pavel Kovalenko
db7a87089b Adaptive choose of single/multi part upload in WriteBufferFromS3. 2020-12-09 17:09:04 +03:00
alesapin
4d1f528806
Merge pull request #17918 from ClickHouse/revert-17120-fix_granularity_on_block_borders
Revert "Fix index granularity calculation on block borders"
2020-12-09 14:46:56 +03:00
Nikolai Kochetov
6a9e1ce436
Merge pull request #17895 from Enmk/DateTime64_DateTime_comparison
Date vs DateTime64 comparison
2020-12-09 14:22:26 +03:00
alesapin
7783ddb3af
Revert "Fix index granularity calculation on block borders" 2020-12-09 14:05:48 +03:00
feng lv
91c3de9664 fix
fix

fix
2020-12-09 09:13:51 +00:00
feng lv
7546c611fb add test 2020-12-09 08:11:14 +00:00
feng lv
e95e443246 fix
fix
2020-12-09 04:32:28 +00:00
feng lv
9b2bb1820a Merge branch 'master' of github.com:ClickHouse/ClickHouse into agg-func-setting-null-for-empty 2020-12-09 02:28:49 +00:00
alexey-milovidov
8ff30b87a6
Merge pull request #15930 from kitaisreal/clickhouse-client-and-local-added-queries-file-parameter
Clickhouse client and clickhouse local added queries-file parameter
2020-12-08 21:44:19 +03:00
Pavel Kovalenko
dfbb31174e Ability to set metadata when put S3 object 2020-12-08 21:31:57 +03:00
Vitaly Baranov
f6f336ac78
Merge pull request #17888 from vitlibar/retrieve-logs-from-grpc
Retrieve logs from grpc
2020-12-08 20:54:02 +03:00
Vasily Nemkov
59fc301344 Fixed test to be less flaky
Also logging expanded list of columns passed from `DEDUPLICATE BY` to actual deduplication routines.
2020-12-08 19:44:34 +03:00
alesapin
8b0fe1404a Tiny sleeps 2020-12-08 17:50:10 +03:00
alesapin
3d0dbbe411 Fix build 2020-12-08 17:49:18 +03:00
alesapin
91e3162e09 More correct session close 2020-12-08 17:28:51 +03:00
Vasily Nemkov
0c2d73adcb Fixed comparing Date and DateTime64 2020-12-08 17:17:02 +03:00
Alexander Tokmakov
04ceaa66f2 implement ATTACH TABLE name FROM 'path/to/data/ 2020-12-08 17:15:23 +03:00
Ivan
0ba712a2d3
Merge branch 'master' into allow_atomic_database_inside_materialize_mysql 2020-12-08 16:45:51 +03:00
alesapin
f4231d552e Banch of fixes 2020-12-08 16:28:39 +03:00
nauta
ab5f397022 add encodeXMLComponent function 2020-12-08 21:02:09 +08:00
Kruglov Pavel
e19eb6f17a
Merge branch 'master' into optimize-data-on-insert 2020-12-08 15:57:46 +03:00
alexey-milovidov
d9b52f94f7
Merge pull request #17637 from amosbird/buildid
reload symbols and fix build-id
2020-12-08 14:55:35 +03:00
alexey-milovidov
ab10cb4bf9
Merge pull request #17707 from ClickHouse/quota-by-x-forwarded-for
Allow quotas to be keyed by proxy-forwarded IP address; add support for PROXY protocol
2020-12-08 14:48:05 +03:00
sundy-li
d4d913edb0 update tests 2020-12-08 19:18:43 +08:00
Vasily Nemkov
5556c48298 Added test for DateTime vs DateTime64 comparison 2020-12-08 13:51:50 +03:00
Nikolai Kochetov
7d77a7ba24
Merge pull request #16952 from Enmk/DateTime64_fixes_comparison
Fixed comparison of DateTime64 with different scales
2020-12-08 12:40:41 +03:00
sundy-li
d9176263aa disable optimize_trivial_count in query with array join 2020-12-08 16:00:12 +08:00
Alexey Milovidov
fa08c59d14 Fix bad test 2020-12-08 02:09:47 +03:00
Vitaly Baranov
ad01e877be Mark grpc protocol's tests as non-flaky. 2020-12-07 23:40:02 +03:00
Vitaly Baranov
559afe028f Retrieve logs from grpc library and pass them to our logging system. 2020-12-07 23:39:55 +03:00
Alexey Milovidov
a5f43ada94 Add missing config link 2020-12-07 23:36:47 +03:00
Vitaly Baranov
b8faa1663f Fix configs in tests. 2020-12-07 22:02:18 +03:00
Alexey Milovidov
af55793e69 Better test 2020-12-07 19:57:08 +03:00
Alexey Milovidov
b762398616 Better test 2020-12-07 19:43:32 +03:00
Maksim Kita
ae56223611 Added queries-file parameter. Updated tests. 2020-12-07 19:29:17 +03:00
Maksim Kita
963ee5211b Added queries-file parameter. Fixed code review issues 2020-12-07 19:29:17 +03:00
Maksim Kita
f5d1a9e59a Clickhouse client and local added queries-file parameter 2020-12-07 19:29:17 +03:00
alexey-milovidov
584fb97ed2
Merge pull request #17832 from kitaisreal/clickhouse-benchmark-added-query-parameter
Clickhouse-benchmark added query parameter
2020-12-07 19:26:16 +03:00
alesapin
b5d2559626
Merge pull request #17709 from kssenii/better-startup
rabbitmq: fix startup with no connection
2020-12-07 19:08:18 +03:00
alesapin
5f35279c09
Merge pull request #17856 from ClickHouse/fix_test_log_s3
Kill network container with retries in integration tests
2020-12-07 19:07:02 +03:00
nikitamikhaylov
a8616ea262 better 2020-12-07 18:47:57 +03:00
Alexey Milovidov
1ed329017b Merge branch 'master' into quota-by-x-forwarded-for 2020-12-07 18:22:19 +03:00
Vasily Nemkov
168155eeec Minor: cleanup 2020-12-07 18:07:40 +03:00
Vasily Nemkov
f01a566646 Updated tests 2020-12-07 17:42:49 +03:00
PHO
3c90065158 Add functions toMJD and fromMJD
These functions convert between Proleptic Gregorian calendar date and Modified Julian Day number.
2020-12-07 16:00:32 +03:00
alesapin
371cb23946 Merge branch 'master' into run_func_tests_in_parallel 2020-12-07 13:30:41 +03:00
alesapin
57f40e4260
Merge pull request #17458 from ClickHouse/merge-expressions
Merge expressions
2020-12-07 12:34:19 +03:00
alesapin
710550f8e5 Kill container with retries 2020-12-07 12:25:27 +03:00
Maksim Kita
ee33323d1e Added tests 2020-12-07 11:35:44 +03:00
alesapin
0c43246216 Merge branch 'master' into complete_zk_api 2020-12-07 10:24:55 +03:00
Vasily Nemkov
70ea507dae OPTIMIZE DEDUPLICATE BY columns
Extended OPTIMIZE ... DEDUPLICATE syntax to allow explicit (or implicit with asterisk/column transformers) list of columns to check for duplicates on.

Following syntax variants are now supported:

OPTIMIZE TABLE table DEDUPLICATE; -- the old one
OPTIMIZE TABLE table DEDUPLICATE BY *;
OPTIMIZE TABLE table DEDUPLICATE BY * EXCEPT colX;
OPTIMIZE TABLE table DEDUPLICATE BY * EXCEPT (colX, colY);
OPTIMIZE TABLE table DEDUPLICATE BY col1,col2,col3;
OPTIMIZE TABLE table DEDUPLICATE BY COLUMNS('column-matched-by-regex');
OPTIMIZE TABLE table DEDUPLICATE BY COLUMNS('column-matched-by-regex') EXCEPT colX;
OPTIMIZE TABLE table DEDUPLICATE BY COLUMNS('column-matched-by-regex') EXCEPT (colX, colY);

Note that * behaves just like in SELECT: MATERIALIZED, and ALIAS columns are not used for expansion.
Also, it is an error to specify empty list of columns, or write an expression that results in an empty list of columns, or deduplicate by an ALIAS column.
Column transformers other than EXCEPT are not supported.
2020-12-07 09:44:07 +03:00
alexey-milovidov
dd8362a5eb
Merge pull request #17570 from vdimir/typo_01018_ip_dictionary
Fix mixed statements in 01018_ip_dictionary.sql
2020-12-07 02:22:55 +03:00
alexey-milovidov
4df1983d64
Merge pull request #17571 from vdimir/ip-dict-accept-alias
IP dictionary works with aliased types `IPv4` and `IPv6` (close #6804)
2020-12-07 02:19:32 +03:00
Alexey Milovidov
a63d4f0db3 Merge branch 'master' into amosbird-buildid 2020-12-07 02:17:29 +03:00
Azat Khuzhin
c3a4e5e7b7 Fix max_distributed_connections (one more time)
With prefer_localhost_replica=1 max_distributed_connections uses
max_threads before this patch.

Fixes: #14936
Previous fix: #9673
2020-12-07 01:19:53 +03:00
Anton Popov
7aaa2c052f
Merge branch 'master' into merging-map 2020-12-05 22:41:46 +03:00
Vitaliy Zakaznikov
c0d529c49d Small fix to the test/testflows/README.md 2020-12-04 19:27:41 -05:00
Vitaliy Zakaznikov
4cd6ee04d8 Updating TestFlows README.md to include "How To Debug Why Test Failed" section. 2020-12-04 19:11:11 -05:00
Anton Popov
60b0cbb1c1
Merge pull request #15939 from Avogar/optimize_final_optimization
Optimize final optimization
2020-12-05 02:26:27 +03:00
alexey-milovidov
37accc3d2c
Merge pull request #17804 from MyroTk/tfs_pr_access_management
Testflows RBAC ACCESS MANAGEMENT tests.
2020-12-05 01:56:56 +03:00
alexey-milovidov
61a53f38fd
Merge pull request #17805 from azat/fix-test_ttl_move-flaky
Fix flaky test_ttl_move
2020-12-05 01:53:24 +03:00
Alexander Kuzmenkov
b54d50fa7f
Merge pull request #17459 from azat/countMatches-pull
Add countMatches function
2020-12-05 00:01:47 +03:00
Azat Khuzhin
ea64ec390f Fix flaky test_ttl_move
- replace sleep() with waiting for the message in log
- due to previous paragaph, use unique table names
- increase sleep timeout in some places
2020-12-04 21:27:50 +03:00
MyroTk
e2c6430a6e Testflows RBAC ACCESS MANAGEMENT tests. 2020-12-04 18:36:32 +01:00
Pavel Kruglov
905ba78adc Merge branch 'master' of github.com:ClickHouse/ClickHouse into optimize-data-on-insert 2020-12-04 18:56:46 +03:00
alesapin
278bbf6d51 Merge branch 'master' into complete_zk_api 2020-12-04 16:48:19 +03:00
alesapin
7c2a04d77d
Merge pull request #17671 from ClickHouse/update_integration_tests_image
Update docker image in integration tests runner
2020-12-04 15:51:08 +03:00
Azat Khuzhin
68c4da1203 Use max_threads=2 for countMatches to keep it under 2 seconds
Although I don't like this idea.
2020-12-04 07:54:34 +03:00
Ivan
315ff4f0d9
ANTLR4 Grammar for ClickHouse and new parser (#11298) 2020-12-04 05:15:44 +03:00
Alexey Milovidov
d92606d362 Better test 2020-12-03 23:23:09 +03:00
alesapin
b68aa1c76d Merge branch 'master' into run_func_tests_in_parallel 2020-12-03 17:22:09 +03:00
Anton Popov
cd1917c7a6
Merge branch 'master' into optimize_final_optimization 2020-12-03 16:52:51 +03:00
Alexey Milovidov
00dc21b0b9 Better tests 2020-12-03 13:02:20 +03:00
tavplubix
b25546ea50
Merge pull request #17614 from TCeason/add_mysql_killed_test_for_materializemysql
add integration test: MySQL killed while insert for MaterializeMySQL ENGINE
2020-12-03 12:55:43 +03:00
Alexey Milovidov
3e2447391b Support for PROXY protocol 2020-12-03 00:05:51 +03:00
Ivan
278cde366c
Update arcadia_skip_list.txt 2020-12-02 22:55:48 +03:00
alexey-milovidov
85f4045160
Merge pull request #17144 from fibersel/issue-16791
introduce zstd compression (for data import/export)
2020-12-02 22:41:07 +03:00
Alexey Milovidov
a25baebc5a Added a test 2020-12-02 22:20:11 +03:00
kssenii
ebab21178e Fix, add test 2020-12-02 18:45:30 +00:00
Azat Khuzhin
5365718f01
Fix optimize_distributed_group_by_sharding_key for query with OFFSET only (#16996)
* Fix optimize_distributed_group_by_sharding_key for query with OFFSET only

* Fix 01244_optimize_distributed_group_by_sharding_key flakiness
2020-12-02 20:11:39 +03:00
Alexander Tokmakov
a0ef3a113a Merge branch 'master' into allow_atomic_database_inside_materialize_mysql 2020-12-02 18:29:02 +03:00
tavplubix
7e2f7ba623
trigger CI 2020-12-02 18:03:15 +03:00
alesapin
5065d9c64b Merge branch 'master' into update_integration_tests_image 2020-12-02 13:58:24 +03:00
alesapin
93ea2f5b1f Merge branch 'master' into complete_zk_api 2020-12-02 11:30:09 +03:00
TCeason
08d36f862d
Merge branch 'master' into add_mysql_killed_test_for_materializemysql 2020-12-02 13:25:07 +08:00
alesapin
51f49e3d47 Check output of cluster start cmd 2020-12-01 23:23:32 +03:00
Azat Khuzhin
cb68d5b5e7 Add performance test for countMatches() function 2020-12-01 22:26:07 +03:00
Azat Khuzhin
cbd4434a33 Add a test for countMatches()/countMatchesCaseInsensitive() 2020-12-01 22:25:28 +03:00
alexey-milovidov
de77715cb6
Merge pull request #17662 from vitlibar/mark-grpc-protocol-tests-as-flaky
Mark grpc protocol's tests as flaky.
2020-12-01 22:05:17 +03:00
alexey-milovidov
1cdf5012c9
Merge pull request #17657 from MyroTk/master
RBAC testflows tests for SHOW, TRUNCATE, KILL, and OPTIMIZE.
2020-12-01 20:57:31 +03:00
Nikita Mikhaylov
519b886641
Merge pull request #17634 from nikitamikhaylov/scipy-arcadia
Try to fix Yandex Synchronization check
2020-12-01 17:59:49 +03:00
Alexander Kuzmenkov
5ad15e2018
Merge pull request #17109 from azat/perf-AggregatingMergeTree-INSERT
Improve performance of AggregatingMergeTree w/ SimpleAggregateFunction(String) in PK
2020-12-01 16:27:36 +03:00
Anton Popov
12604ce0e6 Merge branch 'dev_map2' of git://github.com/hexiaoting/ClickHouse into merging-map 2020-12-01 14:52:30 +03:00
tavplubix
0b5261b1af
Merge pull request #17622 from TCeason/add_clickhouse_killed_test_for_materializemysql
add integration test: ClickHouse killed while insert for MaterializeMySQL ENGINE
2020-12-01 12:52:52 +03:00
Vitaly Baranov
7f093c4f9a Mark grpc protocol's tests as flaky. 2020-12-01 12:38:51 +03:00
alexey-milovidov
0739ed8f97
Merge pull request #17597 from ClickHouse/fix-grpc-tests
Fix GRPC tests
2020-12-01 10:27:11 +03:00
alexey-milovidov
2644f446ab
Merge pull request #17453 from azat/memory-tracking-exception-locking
Do not allow to throw MEMORY_LIMIT_EXCEEDED if there is uncaught exception
2020-12-01 10:25:17 +03:00
MyroTk
2cbf2d8f7b New RBAC testflows tests for SHOW, TRUNCATE, KILL, and OPTIMIZE.
Updates to old tests.
2020-12-01 05:58:45 +01:00
Amos Bird
7e1d71305a
fix test 2020-12-01 10:15:38 +08:00
Vasily Nemkov
87945fb68b Merge branch 'master' into HEAD 2020-11-30 23:25:57 +03:00
nikitamikhaylov
1037a994a8 done 2020-11-30 15:53:37 +03:00
taichong
5b9d9376c3 add integration test: ClickHouse killed while insert for MaterializeMySQL ENGINE 2020-11-30 17:33:31 +08:00
Alexander Kuzmenkov
8fd0810142
Update aggregating_merge_tree_simple_aggregate_function_string.xml
`system stop merges` w/o table name has global effect, so the rest of the tests is affected. Also `optimize` is more suitable here so that the end result is the same every time.
2020-11-30 12:31:30 +03:00
Alexander Kuzmenkov
d9dd9341ce Fix the OpenTelemetry test 2020-11-30 12:11:17 +03:00
taichong
6d8cf30f5d add integration test: MySQL killed while insert for MaterializeMySQL ENGINE 2020-11-30 16:31:09 +08:00
alesapin
6d2a007b79 Merge branch 'master' into complete_zk_api 2020-11-30 10:58:25 +03:00
alesapin
25f40db2fb
Merge pull request #17499 from ClickHouse/concurrent_mutation_and_random_kill
Fix kill mutation on concurrent alter queries
2020-11-30 10:51:50 +03:00
alexey-milovidov
46e685e1b8
Merge pull request #17565 from ClickHouse/fix-multiline-queries-with-comments
Fix multiline queries with comments in interactive mode
2020-11-30 09:38:41 +03:00
alexey-milovidov
df90cbd7d3
Merge pull request #17563 from ClickHouse/parser-alter-missing-code
Allow query parameters in UPDATE statement.
2020-11-30 09:38:14 +03:00
Alexey Milovidov
1711d428eb Fix GRPC tests 2020-11-30 09:34:46 +03:00
Alexey Milovidov
7f1a8b15fd Fix bad test 2020-11-29 21:21:59 +03:00
alexey-milovidov
484f7601d3
Merge pull request #17562 from ClickHouse/test-memory-accounting-zeros
Add a test for #11803
2020-11-29 21:17:25 +03:00
Azat Khuzhin
ccd794a676 Add remerge_sort_lowered_memory_bytes_ratio setting
Sometimes default ratio is not good enough (2), since it depends on lots
of factors:
- size of LIMIT
- max_memory_usage
- ...

So add a separate setting for it.

But note that it make sense to set
remerge_sort_lowered_memory_bytes_ratio only in range (1, 2]

Since <= 1 will just use more CPU, and > 2 will use more RAM and will
unlikely be faster.
2020-11-29 21:16:42 +03:00
alexey-milovidov
b682539d4a
Merge pull request #17561 from ClickHouse/test-9490
Add a test for #9490
2020-11-29 21:16:39 +03:00
alexey-milovidov
b03aaf2b8a
Merge pull request #17557 from ClickHouse/test-chertus
Add a test for #12297
2020-11-29 21:16:03 +03:00
alexey-milovidov
5a1ebb5722
Merge pull request #17541 from ClickHouse/add-test-engine-join-uuid
Add a test for StorageJoin and UUID
2020-11-29 21:15:40 +03:00
alexey-milovidov
038a56d243
Merge pull request #16951 from CurtizJ/fix-groupby-optimization
Fix optimization with 'optimize_aggregators_of_group_by_keys' and joins
2020-11-29 20:47:16 +03:00
alexey-milovidov
1c7844b91e
Merge pull request #16956 from CurtizJ/fix-order-by
Fix order by optimization with monotonous functions
2020-11-29 20:45:47 +03:00
vdimir
cb2259cfb3
Fix mixed statements and typos in 0_stateless/01018_ip_dictionary.sql 2020-11-29 19:49:04 +03:00
Alexey Milovidov
f46eb6f2be Update tests 2020-11-29 18:16:47 +03:00
alexey-milovidov
ced739f231
Merge branch 'master' into test-distributed_buffer_cannot_find_column 2020-11-29 17:54:16 +03:00
Alexey Milovidov
98f9670f69 Add a test 2020-11-29 17:50:50 +03:00
alexey-milovidov
a965dba0b9
Update 01599_mutation_query_params.sh 2020-11-29 16:45:08 +03:00
Alexey Milovidov
4f47545bc8 Add a test for #10976 2020-11-29 16:42:56 +03:00
Alexey Milovidov
5edda3c6bd Add a test for #11803 2020-11-29 16:04:57 +03:00
Alexey Milovidov
3ccc4d66a1 Add a test for #9490 2020-11-29 16:02:35 +03:00
FawnD2
26488467f8 Merge branch 'master' into switch-upstream-for-arrow-submodule 2020-11-29 15:53:28 +03:00
Alexey Milovidov
3bd9a7d3bd Add a test for #12297 2020-11-29 15:23:16 +03:00
a.palagashvili
502355922d added errors checking, removed redundant variables 2020-11-29 15:14:42 +03:00
alexey-milovidov
00da5148a1
Merge pull request #17347 from azat/substringCount
Implement countSubstrings()
2020-11-29 14:32:33 +03:00
alexey-milovidov
fabceebbce
Merge pull request #17145 from amosbird/cddt
Fix unmatched type comparison in KeyCondition
2020-11-29 14:29:35 +03:00
alexey-milovidov
43aa7740fb
Merge pull request #17526 from ClickHouse/obfuscator-remove-some-words
Query obfuscator: remove some words
2020-11-29 14:25:09 +03:00
Alexey Milovidov
4c3466dcf4 Merge branch 'master' into zhang2014-ISSUES-17244 2020-11-29 14:20:36 +03:00
Alexey Milovidov
d4721fea69 Added a test just in case 2020-11-29 13:56:14 +03:00
Alexey Milovidov
33b38a9f7b Update tests 2020-11-29 13:52:32 +03:00
Alexey Milovidov
e635b47299 Add a test for StorageJoin and UUID 2020-11-29 10:43:34 +03:00
vdimir
5f330a9366
IP dictionary works with aliased types IPv4 and IPv6 (close #6804) 2020-11-28 23:12:19 +03:00
alexey-milovidov
19bb345440
Merge pull request #17506 from ClickHouse/fix-bad-test
Fix bad test 01317_no_password_in_command_line.sh
2020-11-28 15:38:22 +03:00
Azat Khuzhin
6803e563a5 Add a test for INSERT SELECT with very small memory limits
I found one query, using which, pretty easy to abnormal terminate the
server, for example executing the following query:

    insert into placeholder_table_name select * from numbers_mt(65535) settings max_memory_usage=1, max_untracked_memory=1 ; -- { serverError 60 }

Will lead to abnormal server termination:

    22:51:36.377873 [ 1853495 ] {edae87ee-05b3-4bfa-be51-3f81d25bca2e} <Debug> executeQuery: (from [::1]:48852) insert into placeholder_table_name select * from numbers_mt(65535) format Null settings max_memory_usage=1, max_untracked_memory=1
    22:51:36.390607 [ 1853446 ] {} <Trace> BaseDaemon: Received signal -1
    22:51:36.390644 [ 1853446 ] {} <Fatal> BaseDaemon: (version 20.12.1.5205 (official build), build id: B23CB64BD60D7F4C) (from thread 1853495) Terminate called for uncaught exception:
    e.displayText() = DB::Exception: Memory limit (for query) exceeded: would use 2.01 MiB (attempt to allocate chunk of 48 bytes), maximum: 1.00 B, Stack trace (when copying this message, always include the lines below):

    uild_docker/../contrib/poco/Foundation/src/Exception.cpp:27: Poco::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x107323d0 in /src/ch/tmp/upstream/clickhouse
    uild_docker/../src/Common/Exception.cpp:39: DB::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x74f5085 in /src/ch/tmp/upstream/clickhouse
    uild_docker/../contrib/libcxx/include/string:2134: DB::Exception::Exception<char const*, char const*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, long&, std::__1::basic_string<char, std::__1::char_traits<char>,
    22:51:36.390667 [ 1853446 ] {} <Trace> BaseDaemon: Received signal 6
    22:51:36.390801 [ 1854585 ] {} <Fatal> BaseDaemon: ########################################
    22:51:36.390827 [ 1854585 ] {} <Fatal> BaseDaemon: (version 20.12.1.5205 (official build), build id: B23CB64BD60D7F4C) (from thread 1853495) (query_id: edae87ee-05b3-4bfa-be51-3f81d25bca2e) Received signal Aborted (6)
    22:51:36.390842 [ 1854585 ] {} <Fatal> BaseDaemon:
    22:51:36.390859 [ 1854585 ] {} <Fatal> BaseDaemon: Stack trace: 0x7ffff7dde615 0x7ffff7dc7862 0x768a37d 0x11aea23c 0x11ad6df1 0x11ad72bc 0x11ad7806 0x11af6657 0x11ae99ea 0x74df512 0x74de86c 0x74dd02c 0x11acf19c 0xd692953 0xd7bf172 0xd7bc031 0xd7b8c11 0xdf37cf9 0xdf38e9e 0x1067a1cb 0x1067a660 0x107bec66 0x107ba3d0 0x7ffff7f843e9 0x7ffff7ea1293
    22:51:36.390888 [ 1854585 ] {} <Fatal> BaseDaemon: 3. raise @ 0x3d615 in /usr/lib/libc-2.32.so
    22:51:36.390900 [ 1854585 ] {} <Fatal> BaseDaemon: 4. __GI_abort @ 0x26862 in /usr/lib/libc-2.32.so
    22:51:36.391618 [ 1854585 ] {} <Fatal> BaseDaemon: 5. /build/build_docker/../src/IO/WriteBuffer.h:46: terminate_handler() (.cold) @ 0x768a37d in /src/ch/tmp/upstream/clickhouse
    22:51:36.392363 [ 1854585 ] {} <Fatal> BaseDaemon: 6. /build/build_docker/../contrib/libcxxabi/src/cxa_handlers.cpp:61: std::__terminate(void (*)()) @ 0x11aea23c in /src/ch/tmp/upstream/clickhouse
    22:51:36.393103 [ 1854585 ] {} <Fatal> BaseDaemon: 7. /build/build_docker/../contrib/libcxxabi/src/cxa_personality.cpp:325: call_terminate @ 0x11ad6df1 in /src/ch/tmp/upstream/clickhouse
    22:51:36.393812 [ 1854585 ] {} <Fatal> BaseDaemon: 8. /build/build_docker/../contrib/libcxxabi/src/cxa_personality.cpp:887: scan_eh_tab @ 0x11ad72bc in /src/ch/tmp/upstream/clickhouse
    22:51:36.394541 [ 1854585 ] {} <Fatal> BaseDaemon: 9. /build/build_docker/../contrib/libcxxabi/src/cxa_personality.cpp:970: __gxx_personality_v0 @ 0x11ad7806 in /src/ch/tmp/upstream/clickhouse
    22:51:36.395265 [ 1854585 ] {} <Fatal> BaseDaemon: 10. /build/obj-x86_64-linux-gnu/../contrib/libunwind/src/UnwindLevel1.c:101: _Unwind_RaiseException @ 0x11af6657 in /src/ch/tmp/upstream/clickhouse
    22:51:36.395979 [ 1854585 ] {} <Fatal> BaseDaemon: 11. /build/build_docker/../contrib/libcxxabi/src/cxa_exception.cpp:151: __cxa_throw @ 0x11ae99ea in /src/ch/tmp/upstream/clickhouse
    22:51:36.396038 [ 1854585 ] {} <Fatal> BaseDaemon: 12. /build/build_docker/../src/Common/MemoryTracker.cpp:171: MemoryTracker::alloc(long) (.cold) @ 0x74df512 in /src/ch/tmp/upstream/clickhouse
    22:51:36.396212 [ 1854585 ] {} <Fatal> BaseDaemon: 13. /build/build_docker/../src/Common/MemoryTracker.cpp:177: MemoryTracker::alloc(long) @ 0x74de86c in /src/ch/tmp/upstream/clickhouse
    22:51:36.396225 [ 1854585 ] {} <Fatal> BaseDaemon: 14. /build/build_docker/../base/common/../common/memory.h:20: operator new(unsigned long) @ 0x74dd02c in /src/ch/tmp/upstream/clickhouse
    22:51:36.396948 [ 1854585 ] {} <Fatal> BaseDaemon: 15. /build/build_docker/../contrib/libcxx/include/string:1495: std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::basic_string(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) @ 0x11acf19c in /src/ch/tmp/upstream/clickhouse
    22:51:36.397683 [ 1854585 ] {} <Fatal> BaseDaemon: 16. /build/build_docker/../contrib/libcxx/include/list:361: DB::ProcessListEntry::~ProcessListEntry() @ 0xd692953 in /src/ch/tmp/upstream/clickhouse
    22:51:36.399234 [ 1854585 ] {} <Fatal> BaseDaemon: 17. /build/build_docker/../contrib/libcxx/include/memory:3483: std::__1::shared_ptr<DB::ProcessListEntry>::~shared_ptr() @ 0xd7bf172 in /src/ch/tmp/upstream/clickhouse
    22:51:36.400472 [ 1854585 ] {} <Fatal> BaseDaemon: 18. /build/build_docker/../src/Interpreters/executeQuery.cpp:428: DB::executeQueryImpl(char const*, char const*, DB::Context&, bool, DB::QueryProcessingStage::Enum, bool, DB::ReadBuffer*) (.cold) @ 0xd7bc031 in /src/ch/tmp/upstream/clickhouse
    22:51:36.401525 [ 1854585 ] {} <Fatal> BaseDaemon: 19. /build/build_docker/../src/Interpreters/executeQuery.cpp:814: DB::executeQuery(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, DB::Context&, bool, DB::QueryProcessingStage::Enum, bool) @ 0xd7b8c11 in /src/ch/tmp/upstream/clickhouse
    22:51:36.402887 [ 1854585 ] {} <Fatal> BaseDaemon: 20. /build/build_docker/../src/Server/TCPHandler.cpp:254: DB::TCPHandler::runImpl() @ 0xdf37cf9 in /src/ch/tmp/upstream/clickhouse
    22:51:36.404453 [ 1854585 ] {} <Fatal> BaseDaemon: 21. /build/build_docker/../src/Server/TCPHandler.cpp:1336: DB::TCPHandler::run() @ 0xdf38e9e in /src/ch/tmp/upstream/clickhouse
    22:51:36.405158 [ 1854585 ] {} <Fatal> BaseDaemon: 22. /build/build_docker/../contrib/poco/Net/src/TCPServerConnection.cpp:57: Poco::Net::TCPServerConnection::start() @ 0x1067a1cb in /src/ch/tmp/upstream/clickhouse
    22:51:36.405918 [ 1854585 ] {} <Fatal> BaseDaemon: 23. /build/build_docker/../contrib/libcxx/include/atomic:856: Poco::Net::TCPServerDispatcher::run() @ 0x1067a660 in /src/ch/tmp/upstream/clickhouse
    22:51:36.406690 [ 1854585 ] {} <Fatal> BaseDaemon: 24. /build/build_docker/../contrib/poco/Foundation/include/Poco/Mutex_POSIX.h:59: Poco::PooledThread::run() @ 0x107bec66 in /src/ch/tmp/upstream/clickhouse
    22:51:36.407413 [ 1854585 ] {} <Fatal> BaseDaemon: 25. /build/build_docker/../contrib/poco/Foundation/include/Poco/AutoPtr.h:215: Poco::ThreadImpl::runnableEntry(void*) @ 0x107ba3d0 in /src/ch/tmp/upstream/clickhouse
    22:51:36.407428 [ 1854585 ] {} <Fatal> BaseDaemon: 26. start_thread @ 0x93e9 in /usr/lib/libpthread-2.32.so
    22:51:36.407436 [ 1854585 ] {} <Fatal> BaseDaemon: 27. clone @ 0x100293 in /usr/lib/libc-2.32.so

But after other patches in this series it wont.
2020-11-28 11:15:26 +03:00
Alexey Milovidov
7c0138542b Query obfuscator: remove some words 2020-11-28 10:55:15 +03:00
alesapin
1d179dac22
Merge pull request #17486 from ClickHouse/fix_more_flaky_tests
Fix more flaky integration tests
2020-11-28 10:43:29 +03:00
alexey-milovidov
c189f6405f
Merge pull request #16767 from azat/optimize_trivial_count_query-fix
Fix optimize_trivial_count_query with partition predicate
2020-11-28 08:43:12 +03:00
alexey-milovidov
62a45e8ff7
Merge pull request #17414 from azat/fix-INSERT-SETTINGS-parsing
Fix parsing of SETTINGS clause of the INSERT ... SELECT ... SETTINGS query
2020-11-28 08:38:42 +03:00
alexey-milovidov
61a8406c1e
Merge pull request #17485 from ClickHouse/aku/perf-thresholds
Adjust perf test thresholds
2020-11-28 08:34:44 +03:00
alexey-milovidov
7a6c72ce88
Merge pull request #17471 from CurtizJ/fix-order-by-functions
Fix 'optimize_redundant_functions_in_order_by'
2020-11-28 08:34:26 +03:00
Alexey Milovidov
44b059c681 Fix bad test 01317_no_password_in_command_line.sh 2020-11-28 08:27:59 +03:00
Nikita Mikhaylov
6f3db7ff50
Merge pull request #17330 from CurtizJ/move-to-prewhere
Allow to move conditions to prewhere with compact parts
2020-11-28 02:02:42 +03:00
tavplubix
aaaa7ad59f
Merge pull request #16806 from TCeason/add_test_for_materialize_mysql
add network partition integration test for MaterializeMySQL
2020-11-27 20:39:06 +03:00
alesapin
6567796014 Fix kill mutation on concurrent alter queries 2020-11-27 18:46:52 +03:00
Anton Popov
458395dcaf fix test 2020-11-27 17:31:30 +03:00
Nikita Mikhaylov
0b6f5c75b9
Merge pull request #17435 from vitlibar/grpc-protocol-2
Implement GRPC protocol (corrections)
2020-11-27 15:19:50 +03:00
Alexander Kuzmenkov
a3277b183d Adjust perf test thresholds 2020-11-27 15:08:42 +03:00
alesapin
d199a2bf76 Merge branch 'master' into complete_zk_api 2020-11-27 14:55:55 +03:00
alesapin
17fa29f44f Less pulls of network image 2020-11-27 14:38:04 +03:00
Anton Popov
601d633690 fix optimize_redundant_functions_in_order_by 2020-11-27 14:29:39 +03:00
alesapin
f12ba9f2c1 Fix test 2020-11-27 14:26:42 +03:00
Alexander Kuzmenkov
19bdb34b19
Merge pull request #16183 from hexiaoting/dev_replace
Fix: throw error when column transformer use non-exist column
2020-11-27 14:09:58 +03:00
alesapin
50cf7fda39 Less flaky test_realod_zookeeper 2020-11-27 14:05:59 +03:00
Nikolai Kochetov
f3bea2210c Update tests. 2020-11-27 13:55:45 +03:00
Nikolai Kochetov
85283b3944
Merge pull request #17397 from ClickHouse/fix-types-for-read-from-join
Fix crash while reading from JOIN table with LowCardinality types
2020-11-27 13:37:05 +03:00
Nikolai Kochetov
60af8219ee
Merge pull request #17439 from ClickHouse/chengxianglibra-dist-agg-issue
Fix incorrect optimization of distinct
2020-11-27 13:26:19 +03:00
Nikolai Kochetov
c206b2506b Update tests. 2020-11-27 13:10:09 +03:00
alexey-milovidov
dfae1efbbd
Merge pull request #17070 from fastio/master
Support multiple ZooKeeper clusters
2020-11-27 10:38:01 +03:00
taichong
c8f7a56a25 fix CI timeout err 2020-11-27 11:34:49 +08:00
hexiaoting
2523f8f0c6 Merge remote-tracking branch 'origin/master' into dev_replace 2020-11-27 10:51:04 +08:00
alexey-milovidov
572bdb4090
Merge pull request #17423 from ClickHouse/remove-time-series-group-sum
Remove timeSeriesGroupSum
2020-11-26 23:07:46 +03:00
Azat Khuzhin
838596c7a4 Implement countSubstrings()
Function to count number of substring occurrences in the string:
- in case of needle is multi char - counts non-intersecting substrings
- the code is based on position helpers.

The following new functions is available:
- countSubstrings()
- countSubstringsCaseInsensitive()
- countSubstringsCaseInsensitiveUTF8()

v0: substringCount()

v2:
- add substringCountCaseInsensitiveUTF8
- improve tests
- fix coding style issues
- fix multichar needle

v3: rename to countSubstrings (by analogy with countEqual())
2020-11-26 22:58:16 +03:00
alexey-milovidov
1cd09fa367
Merge pull request #15127 from ucasFL/add-mutation-for-storagememory
Add mutation support for StorageMemory
2020-11-26 22:22:59 +03:00
Nikolai Kochetov
9291bbb04b
Merge pull request #16804 from vdimir/ip-dict-no-trie
sorted-array based ip_dict
2020-11-26 19:26:06 +03:00
Alexander Kuzmenkov
15a0f14445
Merge pull request #15419 from myrrc/improvement/diff-types-in-avg-weighted
Allow different types in avgWeighted. Allow avg and avgWeighed to operate on extended integral types.
2020-11-26 17:16:48 +03:00
alesapin
90bddce5ed
Merge pull request #17410 from ClickHouse/test_mutation_for_empty_partitions
Add test for mutation with empty partition
2020-11-26 16:42:43 +03:00
Nikita Mikhaylov
084c75fa6e
Merge pull request #17309 from nikitamikhaylov/merging-sequential-consistency
Merging #16309
2020-11-26 15:26:05 +03:00
Nikita Mikhaylov
adb82649c4
Merge pull request #16883 from nikitamikhaylov/refactor-rank-corr
mannWhitneyUTest + studentTTest + welchTTest + small rankCorr refactor
2020-11-26 15:17:18 +03:00
Nikolai Kochetov
83f2fc3d9c Update test. 2020-11-26 12:51:55 +03:00
hexiaoting
5b3a7f5c98 Merge remote-tracking branch 'origin/master' into dev_map2 2020-11-26 16:43:27 +08:00
Nikolai Kochetov
42399e8866 Merge branch 'dist-agg-issue' of https://github.com/chengxianglibra/ClickHouse into chengxianglibra-dist-agg-issue 2020-11-26 11:35:47 +03:00
Amos Bird
022ba2b0a9
Fix unmatched type comparison in KeyCondition 2020-11-26 16:15:50 +08:00
alexey-milovidov
ee3a0b790b
Merge pull request #17376 from azat/toUnixTimestamp-Date-fix
Prohibit toUnixTimestamp(Date())
2020-11-26 10:50:00 +03:00
Vitaly Baranov
1fc43b3c93 Remove trailing whitespaces in config.xml 2020-11-26 10:27:04 +03:00
Vitaly Baranov
49cf980761 Use port 9100 for grpc by default. 2020-11-26 10:14:27 +03:00
hexiaoting
74d875c837 Merge remote-tracking branch 'origin/master' into dev_map2 2020-11-26 15:13:52 +08:00
alexey-milovidov
747453b008
Merge pull request #17051 from hexiaoting/bugfix_fuzzbits
Bug fix for funciton fuzzBits
2020-11-26 06:41:20 +03:00
Alexey Milovidov
85d3e62275 Remove timeSeriesGroupSum 2020-11-26 05:46:28 +03:00
alexey-milovidov
fb3a69b298
Merge pull request #17254 from azat/fix-dist-query-cancelation
Fix "Unexpected packet Data received from client"  for Distributed queries
2020-11-26 03:46:27 +03:00
alexey-milovidov
c438b43892
Merge pull request #17375 from ClickHouse/always-working-test
Added a test for what was always working
2020-11-26 03:29:14 +03:00
Nikita Mikhaylov
ede023a237
rerun tests to be sure 2020-11-26 01:24:42 +03:00
Alexander Kuzmenkov
394b81ac46 Merge remote-tracking branch 'origin/master' into HEAD 2020-11-25 23:38:55 +03:00
Azat Khuzhin
0b47f4a9e9 Fix optimize_trivial_count_query with partition predicate
Consider the following example:

    CREATE TABLE test(p DateTime, k int) ENGINE MergeTree PARTITION BY toDate(p) ORDER BY k;
    INSERT INTO test VALUES ('2020-09-01 00:01:02', 1), ('2020-09-01 20:01:03', 2), ('2020-09-02 00:01:03', 3);

- SELECT count() FROM test WHERE toDate(p) >= '2020-09-01' AND p <= '2020-09-01 00:00:00'
  In this case rpn will be (FUNCTION_IN_RANGE, FUNCTION_UNKNOWN (due to strict), FUNCTION_AND)
  and for optimize_trivial_count_query we cannot use index if there is at least one FUNCTION_UNKNOWN.
  since there is no post processing and return count() based on only the first predicate is wrong.

  Before this patch FUNCTION_UNKNOWN was allowed for optimize_trivial_count_query, and the result was wrong.

And two examples above just to show the difference, the behaviour hadn't been changed with this patch:

- SELECT * FROM test WHERE toDate(p) >= '2020-09-01' AND p <= '2020-09-01 00:00:00'
  In this case will be (FUNCTION_IN_RANGE, FUNCTION_IN_RANGE (due to non-strict), FUNCTION_AND)
  so it will prune everything out and nothing will be read.

- SELECT * FROM test WHERE toDate(p) >= '2020-09-01' AND toUnixTimestamp(p)%5==0
  In this case will be (FUNCTION_IN_RANGE, FUNCTION_UNKNOWN, FUNCTION_AND)
  and all, two, partitions will be scanned, but due to filtering later none of rows will be matched.
2020-11-25 23:09:17 +03:00
Azat Khuzhin
32f69dc76f Cleanup 01505_trivial_count_with_partition_predicate 2020-11-25 23:09:17 +03:00
Nikolai Kochetov
729272391f
Merge branch 'master' into ip-dict-no-trie 2020-11-25 23:07:19 +03:00
Nikolai Kochetov
99f1151236
Update arcadia_skip_list.txt 2020-11-25 23:06:37 +03:00
Azat Khuzhin
3f67e320dd Fix parsing of SETTINGS clause of the INSERT ... SELECT ... SETTINGS query
Before this patch the following query ignores the settings for INSERT:

   insert into test_parallel_insert select * from numbers_mt(65535*2) settings max_insert_threads=10

And the reason is that SETTINGS was parsed by the SELECT parser.
Fix this by push down the SETTINGS from the SELECT to INSERT.

Also note that since INSERT parser does not use ParserQueryWithOutput the
following works:

   insert into test_parallel_insert select * from numbers_mt(65535*2) format Null settings max_insert_threads=10
2020-11-25 22:53:58 +03:00
Azat Khuzhin
688cb6b4d9 Update date_time_short perf test for toUnixTimestamp(Date()) 2020-11-25 21:17:11 +03:00
nikitamikhaylov
44f4064e9b update test 2020-11-25 20:51:07 +03:00
nikitamikhaylov
02a80230f8 remove comments 2020-11-25 20:51:07 +03:00
nikitamikhaylov
71d6126c6b better 2020-11-25 20:51:07 +03:00
nikitamikhaylov
4246971961 fix tests 2020-11-25 20:51:07 +03:00
nikitamikhaylov
de9dc3a43f update copy pasted test 2020-11-25 20:51:06 +03:00
nikitamikhaylov
f764332070 better merge 2020-11-25 20:51:06 +03:00
nikitamikhaylov
3f874af323 new interface for the function
(cherry picked from commit 89547e77cf)
2020-11-25 20:51:06 +03:00
nikitamikhaylov
9177ba3c02 test added 2020-11-25 20:51:06 +03:00
nikitamikhaylov
13081370ba mann-whitney 2020-11-25 20:51:06 +03:00
nikitamikhaylov
9afe579225 small refactor 2020-11-25 20:51:06 +03:00
alesapin
68c8219edf Add test for mutation with empty partition 2020-11-25 18:13:27 +03:00
alesapin
dd4c5bdeb9
Merge pull request #17249 from amosbird/insub
Fix const column in set index.
2020-11-25 17:05:23 +03:00
Nikolai Kochetov
8e5f7acd07 Added test. 2020-11-25 16:34:07 +03:00
alesapin
fb86eaf6fc Better errors and better config 2020-11-25 16:19:09 +03:00
Nikita Mikhaylov
27acf6462f
Merge pull request #17248 from kaka11chen/15235
Fix #15235. When clickhouse-copier handle non-partitioned table, throws segfault error.
2020-11-25 14:31:59 +03:00
Alexander Kuzmenkov
edce1e636e
Merge pull request #16535 from ClickHouse/aku/opentelemetry
OpenTelemetry improvements
2020-11-25 14:10:17 +03:00
myrrc
1a9c313529 fix test reference 2020-11-25 12:19:19 +03:00
alesapin
4d40d9be3f Merge branch 'master' into complete_zk_api 2020-11-25 10:31:16 +03:00
alesapin
3e1b2f515b
Merge pull request #17311 from ClickHouse/fix_integration_tests
Fix some flaky tests
2020-11-25 10:09:27 +03:00
Vitaly Baranov
08b3707842
Merge pull request #15111 from vitlibar/grpc-protocol
Implement GRPC protocol.
2020-11-25 09:00:32 +03:00
Azat Khuzhin
9649b96bbb Update expectations for toUnixTimestamp(Date()) in 00921_datetime64_compatibility 2020-11-25 07:42:36 +03:00
chenqi
302cd55f45 Fix #15235. When clickhouse-copier handle non-partitioned table, throw segfault error. 2020-11-25 11:52:00 +08:00
Azat Khuzhin
17f6c82ffa Prohibit toUnixTimestamp(Date())
Making it implicitly cast to Date() does not looks correct, since before
it returns somewhat unexpected result:

    SELECT toUnixTimestamp(today())

    ┌─toUnixTimestamp(today())─┐
    │                    18591 │
    └──────────────────────────┘
2020-11-25 00:26:14 +03:00
Alexey Milovidov
99073c26ee Added a test for what was always working 2020-11-25 00:00:55 +03:00
Alexander Kuzmenkov
1d7dcef4a0 Merge remote-tracking branch 'origin/master' into HEAD 2020-11-24 21:45:10 +03:00
Alexander Kuzmenkov
1d6558f694 not sure what's going on 2020-11-24 21:45:01 +03:00
Anton Popov
f2106f9683 add test 2020-11-24 20:41:11 +03:00
Vitaly Baranov
65719da0d8
Merge pull request #16977 from MyroTk/rbac_attach_create_drop_detach_testflows
RBAC Testflows tests for ATTACH, CREATE, DROP, and DETACH
2020-11-24 18:31:44 +03:00
Vitaly Baranov
4b3488934c Disable running test test_odbc_interaction.test_bridge_dies_with_parent with asan. 2020-11-24 17:55:02 +03:00
Vitaly Baranov
3c85165e60 Redirect stderr, stdout for clickhouse-odbc-bridge to files. 2020-11-24 17:55:02 +03:00
Vitaly Baranov
950bccb130 Add test for authentication. 2020-11-24 17:55:02 +03:00
Vitaly Baranov
a0e384b0c0 Added support for external tables. 2020-11-24 17:55:02 +03:00
Vitaly Baranov
23842e7ac6 Added support for input() function. 2020-11-24 17:55:02 +03:00
Vitaly Baranov
0e3a8840b5 Support cancellation of executing query via gRPC. 2020-11-24 17:55:02 +03:00
Vitaly Baranov
88f1eeec2f Add tests for parallel executing of queries. 2020-11-24 17:55:02 +03:00
Vitaly Baranov
eab3006a4d Support SSL and compression when using gRPC protocol. 2020-11-24 17:55:02 +03:00
Vitaly Baranov
b0cb3eb306 Extend the protocol with streaming and nonstreaming functions. 2020-11-24 17:55:01 +03:00
Vitaly Baranov
b51e14253d Added support for sessions in gRPC protocol. 2020-11-24 17:55:01 +03:00
Vitaly Baranov
9285f7edc1 Send profile info to client. 2020-11-24 17:55:01 +03:00
Vitaly Baranov
98e2cc4117 Fix sending progress. 2020-11-24 17:55:01 +03:00
Vitaly Baranov
4f0405af93 Send logs via gRPC protocol too. 2020-11-24 17:55:01 +03:00
Vitaly Baranov
218d9ea3e8 Added input_data_delimiter to protocol. 2020-11-24 17:55:01 +03:00
Vitaly Baranov
797c84889f Use ReadBuffer to join input data from multiple query infos.
That fixes inserting of a row splitted between two query infos.
2020-11-24 17:55:01 +03:00
Vitaly Baranov
63c8d8124a Added test for inserting to columns with defaults. 2020-11-24 17:55:01 +03:00
Vitaly Baranov
de4586739a Fix using output format. 2020-11-24 17:55:01 +03:00
Vitaly Baranov
8146093794 Provide more information about errors. 2020-11-24 17:55:01 +03:00
Vitaly Baranov
a327f24e3c Refine the protocol. Code cleanup in tests. 2020-11-24 17:53:34 +03:00
Vitaly Baranov
db9f762e73 Fix tests. 2020-11-24 17:53:34 +03:00
Vitaly Baranov
13f2352c57 Move files to right places. 2020-11-24 17:53:34 +03:00
mnkonkova
6cd1557d67 Implement GRPC protocol. 2020-11-24 17:53:34 +03:00
Amos Bird
6b4512809c
Fix const column in set index. 2020-11-24 22:31:59 +08:00
Alexander Kuzmenkov
9b0368ffa5
Merge pull request #16338 from ucasFL/union-distinct
Add UNION DISTINCT and setting `union_default_mode`
2020-11-24 17:30:24 +03:00
myrrc
03139c2c1e Merge branch 'improvement/diff-types-in-avg-weighted' of github:myrrc/clickhouse into improvement/diff-types-in-avg-weighted 2020-11-24 17:08:38 +03:00
myrrc
420f2489a7 fixed decimal scales calc, updated the tests 2020-11-24 17:07:59 +03:00
Anton Popov
4e07681444 remove outdated test 2020-11-24 16:30:52 +03:00
myrrc
fbb0e6e6aa Merge remote-tracking branch 'upstream/master' into improvement/diff-types-in-avg-weighted 2020-11-24 16:04:17 +03:00
Alexander Tokmakov
e82c63e05c fixes 2020-11-24 15:28:54 +03:00
Alexander Tokmakov
dce0bf8efc Merge branch 'master' into allow_atomic_database_inside_materialize_mysql 2020-11-24 15:28:31 +03:00
Anton Popov
6e1a9240e1
Merge branch 'master' into fix-groupby-optimization 2020-11-24 15:24:07 +03:00
Anton Popov
ff36dee2ec move test to bugs 2020-11-24 15:22:13 +03:00
Nikita Mikhaylov
6787f98476
Merge pull request #14958 from nikitamikhaylov/refactor_cache_dictionary
Refactor cache dictionary
2020-11-24 14:55:02 +03:00
nikitamikhaylov
5be300ff22 Merge branch 'master' of github.com:ClickHouse/ClickHouse into merging-sequential-consistency 2020-11-24 14:46:57 +03:00
alesapin
c1a7e4f5fa Merge branch 'master' into complete_zk_api 2020-11-24 13:37:51 +03:00
alesapin
45f09fe293
Merge pull request #17220 from ianton-ru/s3_max_redirects
S3 max redirects
2020-11-24 12:13:10 +03:00
vdimir
52bc290616
Regenerate ya.make, add format null to ip_trie.xml 2020-11-24 11:20:11 +03:00
alesapin
b05385cec0 Remove code from test which copy-pasted from another test 2020-11-24 11:17:37 +03:00
alesapin
cb234e28ea Fix garbage test 2020-11-24 11:09:10 +03:00
alesapin
5477984856 Longer integration tests for rabbitMQ 2020-11-24 10:33:35 +03:00
taichong
b5440882cd remove kill server while insert 2020-11-24 10:11:04 +08:00
Anton Popov
2fb8717dfd
Merge pull request #17253 from amosbird/globalinfix
global in set index.
2020-11-24 03:06:00 +03:00
Denis Glazachev
a367abb88f Merge branch 'master' into ldap-cache-login
* master: (70 commits)
  Update documentation-issue.md
  Add an option to use existing tables to perf.py
  DOCSUP-4280: Update the SELECT query (#17231)
  DOCSUP-3584 edit and translate (#17176)
  Fixed flaky test_storage_s3::test_custom_auth_headers
  Update 01560_merge_distributed_join.sql
  Minor improvements
  Slightly more correct
  Auto version update to [20.13.1.1] [54444]
  Auto version update to [20.12.1.5236] [54443]
  Update roadmap
  Add favicon; add loading indicator
  Fix race condition; history and sharing capabilities
  Update bitmap-functions.md
  Fix exception message
  Use default value for read-only flag in metadata for Disk3.
  ISSUES-16605 try fix review comment
  trigger CI
  ISSUES-16605 try fix integration failure
  ISSUES-16605 try fix integration test failure
  ...
2020-11-24 02:55:20 +04:00
alesapin
db1aef8994 More retries 2020-11-23 23:44:46 +03:00
alesapin
3d177d414a Merge branch 'master' into fix_integration_tests 2020-11-23 23:27:46 +03:00
Tai White
c1662b6a4b Added line removed by mistake 2020-11-23 21:21:30 +01:00
Anton Popov
852a08eacb allow to move conditions to prewhere with compact parts 2020-11-23 21:27:59 +03:00
Alexander Kuzmenkov
234bd09044 debug an unreproducible test failure 2020-11-23 20:48:00 +03:00
alexey-milovidov
a2f947ddd5
Merge pull request #16993 from azat/merge-distributed-join-fix
Fix Merge(Distributed()) with JOIN
2020-11-23 20:40:21 +03:00
alexey-milovidov
ac710ff0b7
Merge pull request #17299 from Jokser/flaky-s3-test-custom-auth-headers
Fixed flaky test_storage_s3::test_custom_auth_headers
2020-11-23 20:33:48 +03:00
Alexander Kuzmenkov
412c2fe079 Merge remote-tracking branch 'origin/master' into HEAD 2020-11-23 19:51:18 +03:00
alesapin
1c5da1c178 Better timeouts 2020-11-23 19:39:57 +03:00
alesapin
eb9b3e6737 Less global queries in functional tests 2020-11-23 17:57:46 +03:00
alesapin
c9b382b4af Fix flaky integration tests 2020-11-23 17:40:32 +03:00
nikitamikhaylov
065cd00257 better 2020-11-23 17:24:32 +03:00
Amos Bird
172b7e9ed1
global in set index. 2020-11-23 22:05:08 +08:00
feng lv
005f345139 Merge branch 'master' of github.com:ClickHouse/ClickHouse into add-mutation-for-storagememory 2020-11-23 13:56:19 +00:00
nikitamikhaylov
68bef22fda Merge branch 'master' of github.com:ClickHouse/ClickHouse into merging-sequential-consistency 2020-11-23 16:28:35 +03:00
tavplubix
7af89cba8a
Merge pull request #16715 from zhang2014/fix/ISSUES-16605
ISSUES-16605 fix without returning affected rows when insert select query in MySQL handler
2020-11-23 15:54:43 +03:00
Anton Ivashkin
aa208a9d9f Use only 's3_max_redirect' in params instead of all settings 2020-11-23 14:02:17 +03:00
Pavel Kovalenko
5f98d38689 Fixed flaky test_storage_s3::test_custom_auth_headers 2020-11-23 13:19:43 +03:00
taichong
a6c2a90756 modify integration test materialize mysql database
1. fix asan test err

2. reset pymysql conn if ping err

3. finish mysql & ck killed test

4. modify check_query
2020-11-23 17:55:07 +08:00
alexey-milovidov
f38db2d421
Update 01560_merge_distributed_join.sql 2020-11-23 12:51:59 +03:00
Alexey Milovidov
9969a73d50 Merge branch 'master' into azat-merge-distributed-join-fix 2020-11-23 12:43:15 +03:00
Alexey Milovidov
ed679d8edb Better test 2020-11-23 12:38:03 +03:00
Alexey Milovidov
24710046c3 Arcadia does not support distributed tests 2020-11-23 12:34:23 +03:00
Alexey Milovidov
b10283f8d5 Add a test for #13990 2020-11-23 12:32:57 +03:00
lichengxiang
fdde2d1e8a fix #17294: Distinct on subquery with group by may return duplicate result 2020-11-23 17:06:59 +08:00
alesapin
b8fb44a7b9 Merge with master 2020-11-23 11:05:50 +03:00
taichong
f99d6ea799 add ck & mysql killed while insert 2020-11-23 15:47:44 +08:00
taichong
122740767f add integration test err 2020-11-23 15:47:44 +08:00
taichong
714767f491 make it normal 2020-11-23 15:47:44 +08:00
taichong
5a50535abc add mysql kill sync id test 2020-11-23 15:47:44 +08:00
taichong
81bdf50085 add some except error test 2020-11-23 15:47:44 +08:00
taichong
e691b4a0d4 add network partition integration test for MaterializeMySQL 2020-11-23 15:47:44 +08:00
taichong
e8628f61e0 add mysql kill sync id test 2020-11-23 15:47:44 +08:00
taichong
3287f691ee add some except error test 2020-11-23 15:47:44 +08:00
taichong
5c3d4b2245 add network partition integration test for MaterializeMySQL 2020-11-23 15:47:44 +08:00
feng lv
18491d8920 fix 2020-11-23 05:30:36 +00:00
Alexey Milovidov
fbbf439338 Merge branch 'master' into Enmk-DateTime64_fixes_comparison 2020-11-23 05:46:17 +03:00
alexey-milovidov
9ed0c3c85a
Merge pull request #17238 from azat/no-log-rotate-in-tests
Disable rotation of the logs in tests (on CI)
2020-11-23 05:40:58 +03:00
zhang2014
213c7639b7 ISSUES-17244 try fix deterministic functions with predicate optimizer 2020-11-22 22:17:09 +08:00
alesapin
9c8b0da382
Merge pull request #16033 from nvartolomei/nv/parts-uuid
Add unique identifiers IMergeTreeDataPart structure
2020-11-22 16:13:19 +03:00
zhang2014
e1e5eede86 ISSUES-16605 try fix integration failure 2020-11-22 20:13:56 +08:00
zhang2014
5b3154b298 ISSUES-16605 try fix integration test failure 2020-11-22 20:13:56 +08:00
zhang2014
a6dbba5932 ISSUES-16605 add integration test 2020-11-22 20:13:56 +08:00
alexey-milovidov
870a56b962
Merge pull request #17255 from azat/perf-tests-settings-cleanup
Cleanup settings handling in perf tests
2020-11-21 22:59:44 +03:00
alexey-milovidov
1663b13215
Merge pull request #17257 from ucasFL/fix
fix toUInt256 stack overflow
2020-11-21 22:54:06 +03:00
fenglv
268b15f221 fix toUInt256 stack overflow 2020-11-21 12:59:40 +00:00
Azat Khuzhin
8931d3eb6f Do not use SET via <full_query> in perf tests
Since if the connection will be closed (by some reason), then the
setting will not be applied after transparent reconnect (since only
native clickhouse-client can do this, since it parses the query, but
perf tests uses python driver).

Just use inplace SETTINGS clause or <settings>.
2020-11-21 14:02:21 +03:00
Azat Khuzhin
ee4267c1ba Rename 01247_optimize_distributed_group_by_sharding_key to distingiush it
Otherwise flaky tests will run then both, not a problem, but this is
just to trigger flaky check, since there is some tricky issue [1]:

    2020-11-20 00:35:51 01247_optimize_distributed_group_by_sharding_key:                       [ FAIL ] 0.67 sec. - return code 101
    2020-11-20 00:35:51 Received exception from server (version 20.12.1):
    2020-11-20 00:35:51 Code: 101. DB::Exception: Received from localhost:9000. DB::Exception: Received from 127.0.0.2:9000. DB::Exception: Unexpected packet Data received from client.

  [1]: https://clickhouse-test-reports.s3.yandex.net/16996/8d71564056925df1415880f382aaa169cbdf37b0/functional_stateless_tests_flaky_check_(address)/test_run.txt.out.log
2020-11-21 13:32:17 +03:00
Azat Khuzhin
a3116d5614 Tune aggregating_merge_tree_simple_aggregate_function_string to make it faster 2020-11-21 12:08:59 +03:00
Tai White
2bc32fe292 Added verification cooldown requirements and tests to the ldap/external_user_directory SRS and test files 2020-11-20 23:21:13 +01:00
Tai White
43fce34eec Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into ldap-cache-login 2020-11-20 20:56:36 +01:00
Nikolai Kochetov
bac1def5f9
Merge pull request #17134 from abyss7/tcp-port
Implement tcpPort() function for tests
2020-11-20 20:32:55 +03:00
Pavel Kruglov
ca3fe49a2a Make setting global 2020-11-20 17:29:13 +03:00
Nicolae Vartolomei
7c8bc1c04e Use JSON metadata in WAL 2020-11-20 13:49:17 +00:00
Nicolae Vartolomei
94293ca3ce Assign UUIDs to parts only when configured to do so
Avoid breaking backwards compatibility by default for now.
2020-11-20 13:49:17 +00:00
Pavel Kruglov
e5588b94aa Fix style and tests 2020-11-20 13:38:53 +03:00
tavplubix
3e335c1e95
Merge pull request #17091 from zhang2014/fix/binlog_checksum
Fix MaterializeMySQL SYNC failure when modify binlog_checksum
2020-11-20 13:25:14 +03:00
Alexander Kuzmenkov
b05ac888bd Merge remote-tracking branch 'origin/master' into HEAD 2020-11-20 12:50:08 +03:00
Alexander Kuzmenkov
bde805cb3e
Merge pull request #17175 from ClickHouse/aku/named-tuple
Allow formatting named tuples as JSON objects
2020-11-20 12:48:24 +03:00
Nikolai Kochetov
31886fdca6
Merge pull request #16811 from amosbird/pf2
Fix verbatim partition pruner.
2020-11-20 12:07:33 +03:00
alesapin
9920d77a93 Merge branch 'master' into complete_zk_api 2020-11-20 11:48:12 +03:00
Anton Ivashkin
a7d4f4be65 Add 's3_max_redirects' test 2020-11-20 11:18:44 +03:00
alesapin
bd5d2d89ad
Merge pull request #17201 from ClickHouse/fix_read_in_order_test
Trying to make read_in_order_many_parts more stable
2020-11-20 10:10:17 +03:00
Pavel Kruglov
608722b6ab Fix integration tests 2020-11-20 02:59:58 +03:00
Kruglov Pavel
51bcd286f2
Merge pull request #16845 from azat/cutToFirstSignificantSubdomainWithWWW
Add cutToFirstSignificantSubdomainWithWWW()
2020-11-20 01:44:57 +03:00
Pavel Kruglov
3ee4972586 Merge branch 'master' of github.com:ClickHouse/ClickHouse into optimize-data-on-insert 2020-11-20 01:23:51 +03:00
Azat Khuzhin
35231662b3 Improve performance of AggregatingMergeTree w/ SimpleAggregateFunction(String)
While reading from AggregatingMergeTree with
SimpleAggregateFunction(String) in primary key and
optimize_aggregation_in_order perf top shows:

    Samples: 1M of event 'cycles', 4000 Hz, Event count (approx.): 287759760270 lost: 0/0 drop: 0/0
      Children      Self  Shared Object         Symbol
    +   12.64%    11.39%  clickhouse            [.] memcpy
    +    9.08%     0.23%  [unknown]             [.] 0000000000000000
    +    8.45%     8.40%  clickhouse            [.] ProfileEvents::increment    # <-- this, and in debug it has not 0.08x overhead, but 5.8x overhead
    +    7.68%     7.67%  clickhouse            [.] LZ4_compress_fast_extState
    +    5.29%     5.22%  clickhouse            [.] DB::IAggregateFunctionHelper<DB::AggregateFunctionNullUnary<true, true> >::addFree

The reason is obvious, ProfileEvents is atomic counters (and also they
are nested):

<details>

```
    Samples: 7M of event 'cycles', 4000 Hz, Event count (approx.): 450726149337
    ProfileEvents::increment  /usr/bin/clickhouse [Percent: local period]
    Percent│
           │
           │
           │    Disassembly of section .text:
           │
           │    00000000078d8900 <ProfileEvents::increment(unsigned long, unsigned long)@@Base>:
           │    ProfileEvents::increment(unsigned long, unsigned long):
      0.17 │      push  %rbp
      0.00 │      mov   %rsi,%rbp
      0.04 │      push  %rbx
      0.20 │      mov   %rdi,%rbx
      0.17 │      sub   $0x8,%rsp
      0.26 │    → callq DB::CurrentThread::getProfileEvents
           │    ProfileEvents::Counters::increment(unsigned long, unsigned long):
      0.00 │      lea   0x0(,%rbx,8),%rdi
      0.05 │      nop
           │    unsigned long std::__1::__cxx_atomic_fetch_add<unsigned long, unsigned long>(std::__1::__cxx_atomic_base_impl<unsigned long>*, unsigned long, std::__1::memory_order):
      1.02 │      mov   (%rax),%rdx
     97.04 │      lock  add   %rbp,(%rdx,%rdi,1)
           │    ProfileEvents::Counters::increment(unsigned long, unsigned long):
      0.21 │      mov   0x10(%rax),%rax
      0.04 │      test  %rax,%rax
      0.00 │    → jne   78d8920 <ProfileEvents::increment(unsigned long, unsigned long)@@Base+0x20>
           │    ProfileEvents::increment(unsigned long, unsigned long):
      0.38 │      add   $0x8,%rsp
      0.00 │      pop   %rbx
      0.04 │      pop   %rbp
      0.38 │    ← retq
```

</details>

These ProfileEvents was ArenaAllocChunks (it shows ~1.5M events per
second), and the reason is that the table has
SimpleAggregateFunction(String) in PK, which requires Arena.
But most of the time there Arena wasn't even used, so avoid this cost by
re-creating Arena only if it was "used" (i.e. has new chunks).

Another possibility is to avoid populating Arena::head in ctor, but this
will make the Arena code more complex, so for now this was preferred.

Also as a long-term solution it worth looking at implementing them via
RCU (to move the extra overhead out from the write code path into read
side).
2020-11-19 23:06:12 +03:00
Alexander Kuzmenkov
87a306ed23 Enable OpenTelemetry tracing in functional tests 2020-11-19 18:58:33 +03:00
vdimir
36544a45b7
Merge remote-tracking branch 'upstream/master' into ip-dict-no-trie 2020-11-19 18:56:24 +03:00