Commit Graph

3963 Commits

Author SHA1 Message Date
alexey-milovidov
842c2c840c
Merge pull request #19773 from ClickHouse/tavplubix-patch-3
Fix stack overflow in FieldVisitorAccurateEquals
2021-01-31 11:09:41 +03:00
alexey-milovidov
dceb0be9ed
Merge pull request #19774 from ClickHouse/clickhouse-test-log-comment
Add log comment when running .sh tests
2021-01-31 10:14:21 +03:00
Alexey Milovidov
248540e58f Fix UBSan report in GatherUtils 2021-01-31 10:10:37 +03:00
Alexey Milovidov
e5736c4c8d Fix debug assertion in Hyperscan 2021-01-31 07:23:07 +03:00
Alexey Milovidov
ae65219525 More tests 2021-01-31 06:56:39 +03:00
Alexey Milovidov
0128d185ea Fix UBSan report in DateTimeAddInterval 2021-01-31 06:49:33 +03:00
Alexey Milovidov
921ee52ebc More tests 2021-01-31 05:47:59 +03:00
Alexey Milovidov
5c718c8754 Merge branch 'master' into unicode-asan 2021-01-31 02:40:24 +03:00
Alexey Milovidov
895be295a1 Fix test 2021-01-31 02:22:55 +03:00
alexey-milovidov
8ac39e7f56
Merge pull request #19791 from ClickHouse/format-readable-time-delta-ubsan
formatReadableTimeDelta: correctly output infinite values
2021-01-31 01:37:59 +03:00
Alexey Milovidov
30e1db7f47 Merge branch 'master' into azat-client-complete-error-codes 2021-01-31 00:01:47 +03:00
vdimir
5cb99ae699
Use offsets in FunctionIPv6StringToNum for copying ipv4 to buffer 2021-01-30 20:20:11 +03:00
Vitaly Baranov
7c8deae0e1 Fix starting the server with tables having columns' default expressions containing dictGet().
Allow getting return type of dictGet() without loading dictionary.
2021-01-30 19:06:48 +03:00
Vitaliy Zakaznikov
124bd1ea19 Fixing live view refresh test.
Adding live view refresh with dictionary test.
2021-01-30 10:56:02 -05:00
Vitaliy Zakaznikov
dc9c3c8514 Fixing styling errors.
Adding simple tests.
2021-01-30 09:00:42 -05:00
Azat Khuzhin
502d981ab4 Use BinaryArithmeticOverloadResolver::valid_on_float_arguments for lcm/gcd 2021-01-30 09:12:31 +03:00
Azat Khuzhin
7da4083237 Forbid bit functions for floats
This will fix the following UB report [1]:

  "../src/Functions/bitAnd.cpp:24:61: runtime error: nan is outside the
range of representable values of type 'long' Received signal -3 Received
signal Unknown signal (-3)"

  [1]: https://clickhouse-test-reports.s3.yandex.net/19824/89c4055202b9d08459f90ee5791d4e3017b82fbf/fuzzer_ubsan/report.html#fail1
2021-01-30 09:12:31 +03:00
Alexey Milovidov
d44ce00391 Merge branch 'master' into format-readable-time-delta-ubsan 2021-01-30 07:28:38 +03:00
Alexander Kuzmenkov
5519e4c134 unbounded following frame end 2021-01-30 04:16:44 +03:00
Pavel Kruglov
c53c414b99 Add test for incorrect data on insert into CollapsingMegeTree 2021-01-30 01:21:17 +03:00
Pavel Kruglov
2a3aaed562 Update test 2021-01-30 00:41:44 +03:00
Pavel Kruglov
d3fe53a44f Update reference 2021-01-29 23:17:10 +03:00
alexey-milovidov
276e972166
Merge pull request #19789 from ClickHouse/fix-great-circle-angle
Fix mistake in greatCircleAngle
2021-01-29 21:35:26 +03:00
alexey-milovidov
d19feb724b
Merge pull request #19799 from CurtizJ/fix-uint8-filtering
Fix filtering by Uint8 greater than 127
2021-01-29 21:34:42 +03:00
Pavel Kruglov
78371e15dc Update test, reduce num_threads_for_lonely_parts if data is small 2021-01-29 21:00:08 +03:00
Pavel Kruglov
71f4acd48b Use one pool for lonely parts, update tests 2021-01-29 17:30:14 +03:00
alexey-milovidov
4cfcc18a7f
Merge pull request #19786 from ClickHouse/int-round-ubsan
Fix UBSan report in "round"
2021-01-29 14:59:12 +03:00
Pavel Kruglov
a437ee4e31 Merge branch 'master' of github.com:ClickHouse/ClickHouse into select-final 2021-01-29 14:25:47 +03:00
Alexander Tokmakov
b1a02481db add test 2021-01-29 12:51:47 +03:00
alesapin
c4c9ab5d7d Fix bad test 2021-01-29 12:27:35 +03:00
Anton Popov
031132038b fix filtering by uint8 greater than 127 2021-01-29 10:39:18 +03:00
Azat Khuzhin
585874bf46 tests: add a test for clickhouse-client autocompletion
v2: Increase timeout for 01676_clickhouse_client_autocomplete
    https://github.com/ClickHouse/ClickHouse/pull/19584#discussion_r565727175

v3: Disable 01676_clickhouse_client_autocomplete in unbundled build (arcadia)

    autocomplete does not have to work fully unbundled build (since it lack
    of replxx).

    Similar to bd523a0aff

v4: set expect timeout back to 1 and increase total timeout to 20 sec
v4: set expect timeout back to 3 and increase total timeout to 22 (3*X+1) sec
2021-01-29 07:50:08 +03:00
Alexey Milovidov
b7f1a953d5 Fix test 2021-01-29 06:24:59 +03:00
Alexey Milovidov
f06bb78c5d Merge branch 'master' into unicode-asan 2021-01-29 05:18:29 +03:00
Alexey Milovidov
eee84eec79 formatReadableTimeDelta: correctly output infinite values 2021-01-29 05:14:15 +03:00
Alexey Milovidov
f4a05bd773 Fix mistake in greatCircleAngle 2021-01-29 05:05:46 +03:00
Alexey Milovidov
b3944006cb Fix trivial bug in arrayEnumerateUniq 2021-01-29 04:41:55 +03:00
alexey-milovidov
10160e5adf
Merge pull request #19767 from kitaisreal/low-cardinality-uuid-fix
LowCardinality UUID fix
2021-01-29 04:06:28 +03:00
Alexey Milovidov
eb0473c3f9 Fix UBSan report in "round" 2021-01-29 04:03:38 +03:00
alexey-milovidov
9dfe451c35
Merge pull request #19762 from kitaisreal/clickhouse-client-query-param-cte-test
Clickhouse client query param CTE added test
2021-01-29 03:39:37 +03:00
Alexander Kuzmenkov
1b891e042d fix a bug 2021-01-28 21:18:16 +03:00
alexey-milovidov
8dbafc90ca
Merge pull request #19763 from ClickHouse/fix-crash-with-array-filter
Fix crash when nested column name was used in `WHERE` or `PREWHERE`
2021-01-28 20:19:04 +03:00
Alexander Kuzmenkov
3ace39fbf7 simplify a loop and make RANGE frame the default 2021-01-28 20:05:01 +03:00
alexey-milovidov
386bcb07da
Merge pull request #19736 from ClickHouse/stack-overflow-coroutine
Fix stack overflow in coroutine
2021-01-28 18:20:44 +03:00
Anton Popov
7db0766192 fix flaky checks 2021-01-28 17:40:50 +03:00
Maksim Kita
105ecef628 LowCardinality UUID fix 2021-01-28 14:11:34 +03:00
Nikolai Kochetov
3d0f878535 Added test. 2021-01-28 12:44:12 +03:00
Maksim Kita
b5d2611aea Clickhouse client query param CTE added test 2021-01-28 12:36:17 +03:00
alexey-milovidov
6c5302969b
Merge pull request #19704 from ClickHouse/fix-crash-after-actions-dag-merge
Fix crash after merging ActionsDAG.
2021-01-28 11:16:39 +03:00
Maksim Kita
03eec39719
Merge pull request #19712 from kitaisreal/added-functions-parse-date-time-best-effort-us-or-zero-or-null
Added functions parseDateTimeBestEffortUSOrZero, parseDateTimeBestEffortUSOrNull
2021-01-28 11:13:45 +03:00
Alexey Milovidov
d42afe703c Merge branch 'master' into unicode-asan 2021-01-28 10:45:46 +03:00
alexey-milovidov
342326978f
Merge branch 'master' into stack-overflow-coroutine 2021-01-28 10:45:20 +03:00
Alexey Milovidov
d37ca628df Arcadia does not have bitmaps 2021-01-28 10:44:29 +03:00
Alexey Milovidov
68c542aec6 Update test 2021-01-28 07:43:59 +03:00
Alexey Milovidov
2acff24aaf The test most likely would not work in Arcadia 2021-01-28 06:42:20 +03:00
Alexey Milovidov
708e68b983 Fix stack overflow in coroutine 2021-01-28 04:28:19 +03:00
Alexey Milovidov
b0b4ccbc6c Merge branch 'master' into unicode-asan 2021-01-28 03:37:17 +03:00
alexey-milovidov
fa48545b87
Merge pull request #19617 from ClickHouse/fix-lc-neighbour
Fix function neighbor for LowCardinality argument.
2021-01-28 03:06:56 +03:00
alexey-milovidov
a35c79f093
Merge pull request #19711 from ClickHouse/fix-flaky-test-14
Fix flaky test concat_nary_const_with_nonconst_segfault
2021-01-28 03:02:34 +03:00
alexey-milovidov
fa419cead2
Merge pull request #19713 from kitaisreal/roaring-bitmap-with-small-set-rbandnot-fix
RoaringBitmapWithSmallSet rb_andnot fix
2021-01-28 03:02:20 +03:00
Azat Khuzhin
a727fc4755 Fix 01115_join_with_dictionary flakiness 2021-01-27 21:15:18 +03:00
Alexey Milovidov
80dfa40feb Add a test 2021-01-27 20:42:04 +03:00
Maksim Kita
83b9677f1c Added test 2021-01-27 20:35:50 +03:00
Anton Popov
a8f3078ce9 Merge remote-tracking branch 'upstream/master' into HEAD 2021-01-27 19:48:55 +03:00
vdimir
36963e0eba
Minor fix 2021-01-27 18:17:42 +03:00
Alexander Kuzmenkov
331e8211db
Merge pull request #19675 from azat/tests-query_log-current_database
Require current_database filter for tests with query_log/query_thread_log
2021-01-27 18:00:33 +03:00
Maksim Kita
9db9ce11dc Added functions parseDateTimeBestEffortUSOrZero, parseDateTimeBestEffortUSOrNull 2021-01-27 17:10:06 +03:00
Alexey Milovidov
3b943cd00b Fix flaky test concat_nary_const_with_nonconst_segfault 2021-01-27 16:59:44 +03:00
Nikolai Kochetov
fc614d03c1
Update 01666_merge_tree_max_query_limit.reference 2021-01-27 14:37:13 +03:00
Nikolai Kochetov
99a0401c82
Update 01666_merge_tree_max_query_limit.sh 2021-01-27 14:36:55 +03:00
Nikolai Kochetov
2a626f63e6 Fix reference file 2021-01-27 14:24:46 +03:00
Nikolai Kochetov
2e2f4066b3 Update test. 2021-01-27 14:12:21 +03:00
Nikolai Kochetov
d13ec0d909 Fix crash after mergine ActionsDAG. 2021-01-27 14:10:09 +03:00
alexey-milovidov
5e54c9742f
Merge pull request #19683 from ClickHouse/mysql-compatibility
Merging #19387
2021-01-27 13:48:26 +03:00
Nikolai Kochetov
e3ac2639d2
Merge pull request #19648 from ClickHouse/fix-merge-join-constants
Fix merge join constants
2021-01-27 12:49:27 +03:00
Azat Khuzhin
0a1fd29ee6 Add current_database = currentDatabase() filter for tests with query_log/query_thread_log 2021-01-27 08:06:15 +03:00
Alexey Milovidov
fe2e38bf8c Skip two tests in Arcadia because it builds without base64 2021-01-27 05:09:30 +03:00
Alexey Milovidov
16b7a0e8ad Merge branch 'master' into mysql-compatibility 2021-01-27 05:07:30 +03:00
alexey-milovidov
2028228f4b
Merge pull request #18684 from amosbird/betterwith
better CTE and with global
2021-01-27 04:33:17 +03:00
Alexander Kuzmenkov
0d69249c56 typo 2021-01-27 03:27:40 +03:00
Alexander Kuzmenkov
83cfdde6d9 RANGE frame works in some cases 2021-01-27 03:08:15 +03:00
Maksim Kita
81548e051e
Merge pull request #19527 from ucasFL/sign
add sign math function
2021-01-26 23:57:31 +03:00
alexey-milovidov
e8dedbf210
Merge pull request #19532 from azat/UBsan-report-fixes-v2
Forbid lcm/gcd for floats (and few UBsan reports fixes)
2021-01-26 23:16:54 +03:00
Amos Bird
d6c0479cf9
add normalizeQueryKeepNames and normalizedQueryHashKeepNames (#18910) 2021-01-26 17:51:30 +03:00
alexey-milovidov
985805fd01
Merge pull request #19583 from ClickHouse/merge-log-comment
Merging #18549
2021-01-26 17:11:07 +03:00
Nikolai Kochetov
578f36e4f3 Update test.Fix ya.make. 2021-01-26 16:58:49 +03:00
vdimir
bcae07128a
Merge pull request #19530 from taiyang-li/length_for_map
enable length for map, which returns keys number in map
2021-01-26 16:21:21 +03:00
vdimir
a4643bcff2
Whitespace fixes 2021-01-26 16:19:13 +03:00
feng lv
cea8ae162f fix test 2021-01-26 12:37:44 +00:00
Nikolai Kochetov
87246ea91b Fix header for MergeJoin with constants. 2021-01-26 15:37:42 +03:00
Nikolai Kochetov
d821cf11f8 Fix function neighbor for LowCardinality argument. 2021-01-26 13:31:29 +03:00
tavplubix
b8d6655131
Merge pull request #19572 from ClickHouse/fix_19568
Fix DROP TABLE ON CLUSTER SYNC hang with Atomic database
2021-01-26 12:51:07 +03:00
Maksim Kita
463a48dfe3
Merge pull request #19533 from kitaisreal/multi-if-constant-result-support
Function multiIf constant result support
2021-01-26 12:44:23 +03:00
Maksim Kita
16eb7b01b6
Merge pull request #19571 from kitaisreal/create-simple-dictionary-id-expression-fix
Query CREATE DICTIONARY id expression fix
2021-01-26 12:43:49 +03:00
tavplubix
16561753e8
Update arcadia_skip_list.txt 2021-01-26 11:21:18 +03:00
Amos Bird
66fe97d8bd
Per MergeTree table query limit 2021-01-26 14:03:31 +08:00
Azat Khuzhin
27a5794795 Fix UBsan report in lcm()/gcd()
Changelog:
- Check against INT64_MIN/INT64_MAX
- Check against std::numeric_limits<>::min/max
- Move common code into separate header - GCDLCMImpl.h
- Forbid floats

UBsan report [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/19466/cb30a02540a0f223df6668c5f88ff84aa666ff54/fuzzer_ubsan/report.html#fail1
2021-01-26 08:33:49 +03:00
Amos Bird
3afcccaad2
Fix global with after union refactoring 2021-01-26 10:29:12 +08:00
Amos Bird
824aee4020
better cte and with global 2021-01-26 10:29:11 +08:00
bharatnc
a102c78328 tests for toIPv6 and IPv6StringToNum 2021-01-25 17:38:55 -08:00
Azat Khuzhin
f4a4d33c2d Suppress UBsan reports in addYears()
https://clickhouse-test-reports.s3.yandex.net/19528/1c364b6ee3a44487529954cf2792e615f7de0f82/fuzzer_ubsan/report.html#fail1
2021-01-26 01:12:40 +03:00
alexey-milovidov
8084e4d614
Merge pull request #19414 from ClickHouse/fix-15889-continuation
Continue fix for Block structure mismatch in PipelineExecuting stream
2021-01-26 00:05:35 +03:00
alexey-milovidov
7197552535
Merge pull request #19430 from ClickHouse/fix-14100
Fix error Extremes transform was already added to pipeline
2021-01-26 00:04:14 +03:00
Alexey Milovidov
a47b0190fd Add a test 2021-01-25 22:25:49 +03:00
Maksim Kita
ce9a6d32eb Updated tests with always false condition 2021-01-25 21:53:47 +03:00
Maksim Kita
f70a704e2c Added test 2021-01-25 21:22:27 +03:00
Anton Popov
658f24dcff
Merge pull request #19358 from CurtizJ/fix-subcolumns
Fix several cases, while reading subcolumns
2021-01-25 20:26:07 +03:00
Nikolai Kochetov
a6f787faea
Merge pull request #19253 from ClickHouse/split-actions-dag
Split actions dag
2021-01-25 18:13:42 +03:00
alesapin
7d4bf6d56c
Merge pull request #19551 from ClickHouse/fix_01459_test
Fix 01459_manual_write_to_replicas flaky test
2021-01-25 18:05:20 +03:00
Anton Popov
f203a33a8f
Merge pull request #19515 from hexiaoting/map_functions_fix
Bug fix : support const column processing in mapContains, mapKeys, mapValues functions
2021-01-25 17:30:59 +03:00
dankondr
fb268ec339 Add toMinute MySQL compatibility alias 2021-01-25 16:35:58 +03:00
dankondr
23e86a57d8 Add toSecond MySQL compatibility alias 2021-01-25 16:26:38 +03:00
dankondr
8ca52f9894 Add toQuarter MySQL compatibility alias 2021-01-25 16:24:06 +03:00
dankondr
f49c8779a8 Add repeat MySQL compatibility alias 2021-01-25 16:20:40 +03:00
dankondr
d7c5dd3767 Add toYear MySQL compatibility alias 2021-01-25 16:00:11 +03:00
dankondr
8f115f2923 Add toMonth MySQL compatibility alias 2021-01-25 15:59:49 +03:00
Alexander Tokmakov
769257acf4 fix drop table on cluster hang 2021-01-25 15:44:10 +03:00
taiyang-li
586def7fa3 enable empty/notEmpty for map data type 2021-01-25 18:31:39 +08:00
alesapin
94f6a5533e Fix 01459_manual_write_to_replicas flaky test 2021-01-25 10:43:20 +03:00
alesapin
fe133580ee
Merge pull request #19346 from azat/system.parts-_state-fix
Fix system.parts _state column
2021-01-25 10:11:19 +03:00
alexey-milovidov
ba3e064a63
Merge pull request #19371 from kssenii/test-coverage-with-factories
test coverage with factories
2021-01-25 07:11:09 +03:00
Maksim Kita
dac6cceac1 Function multiIf constant result support 2021-01-25 00:35:49 +03:00
alexey-milovidov
73501102f3
Merge pull request #19528 from azat/merge_tree_min_for_concurrent_read-SIGSEGV
Fix SIGSEGV with merge_tree_min_rows_for_concurrent_read/merge_tree_min_bytes_for_concurrent_read=0/UINT64_MAX
2021-01-25 00:18:42 +03:00
alexey-milovidov
77af612bc5
Merge pull request #19466 from azat/UBsan-report-fixes
UBsan report fixes (arraySlice, addMinutes/addHours/addWeeks/addDays, sumWithOverflow(Decimal))
2021-01-24 22:27:15 +03:00
dankondr
3746f6cbd7 Add tests 2021-01-24 15:16:34 +00:00
taiyang-li
f51c3ee9a3 enable length for map, which returns keys number in map 2021-01-24 22:54:08 +08:00
Azat Khuzhin
1c364b6ee3 Fix SIGSEGV with merge_tree_min_rows_for_concurrent_read/merge_tree_min_bytes_for_concurrent_read=0/UINT64_MAX
In case of 0 or too huge value it will try to read not existing marks
and got:

    Logical error: 'Trying to get non existing mark 11936128518282651045, while size is 2'.
2021-01-24 14:39:57 +03:00
Azat Khuzhin
cb30a02540 Fix UBsan report in addDays(INT64_MAX)
https://clickhouse-test-reports.s3.yandex.net/19466/df53438a66ee95de790b60d35f36eca986590027/fuzzer_ubsan/report.html#fail1
2021-01-24 13:51:05 +03:00
Azat Khuzhin
df53438a66 Fix UBsan report in sumWithOverflow(Decimal)
https://clickhouse-test-reports.s3.yandex.net/19450/3fffa16aab8f5342926b3a6b1e3c6a14208e3322/fuzzer_ubsan/report.html#fail1
2021-01-24 09:26:07 +03:00
feng lv
667119918e add sign math function 2021-01-24 05:18:59 +00:00
alexey-milovidov
ab6343ff1f
Merge pull request #19474 from ClickHouse/aes-fix-strange-code
Fix insufficient args check in AES functions
2021-01-23 22:05:01 +03:00
alexey-milovidov
9df296b55e
Merge pull request #19480 from ClickHouse/blns
Integrate with "Big List of Naughty Strings"
2021-01-23 21:52:41 +03:00
hexiaoting
0f05b0ac9a Add Const column test cases for mapContains/Keys/Values 2021-01-23 22:53:08 +08:00
hexiaoting
143b84240e Add const column test case for mapKeys and mapValues 2021-01-23 22:48:14 +08:00
Alexey Milovidov
2b85007af9 Update test 2021-01-23 15:15:03 +03:00
kssenii
0d940c6137 Add AggregateFunctionCombinatorFactory, better names 2021-01-23 12:07:37 +00:00
Alexey Milovidov
598952c243 Remove flawed variants of "encrypt" from tests 2021-01-23 12:32:30 +03:00
alexey-milovidov
c3fc1d83dc
Merge branch 'master' into aes-fix-strange-code 2021-01-23 12:14:17 +03:00
alexey-milovidov
1e42caa888
Merge pull request #19475 from ClickHouse/avg-weighted-ubsan
Fix UBSan report in avgWeighted
2021-01-23 12:13:28 +03:00
Alexey Milovidov
9983beed83 Remove Arcadia 2021-01-23 12:08:54 +03:00
Alexey Milovidov
d1bd4ef793 Merge branch 'master' of github.com:yandex/ClickHouse into blns 2021-01-23 12:08:38 +03:00
alexey-milovidov
7a10fbc9c3
Merge pull request #19479 from ClickHouse/columns-description-idiotic
Fix wrong serde of ColumnsDescription
2021-01-23 12:08:15 +03:00
Alexey Milovidov
ba7438a893 Remove Arcadia 2021-01-23 12:07:58 +03:00
alexey-milovidov
9baac1204e
Merge pull request #19472 from ClickHouse/date-lut-buffer-overflow
Fix buffer overflow in DateLUT
2021-01-23 12:05:10 +03:00
alexey-milovidov
40c9b0ae1b
Merge pull request #19461 from ClickHouse/great-circle-distance-ubsan
Avoid UBSan report in greatCircleDistance
2021-01-23 12:03:02 +03:00
alexey-milovidov
bbaa0786d9
Merge pull request #19460 from ClickHouse/running-difference-ubsan
Fix UBSan report in runningDifference
2021-01-23 12:02:48 +03:00
alexey-milovidov
474ff29ded
Merge pull request #19459 from ClickHouse/array-slice-ubsan
Fix UBSan report in arraySlice and substring
2021-01-23 12:02:34 +03:00
Maksim Kita
f5deb6d523
Merge pull request #19354 from kitaisreal/accurate-cast-or-null-fixed-unitialized-values
Function accurateCastOrNull fixed unitialized values for numeric cast
2021-01-23 10:58:52 +03:00
Azat Khuzhin
86ead0f0a9 Suppress UBsan for addMinutes/addHours/addWeeks with inf
https://clickhouse-test-reports.s3.yandex.net/19466/bb6f775b89da564cff9892a2443332a758e884c0/fuzzer_ubsan/report.html#fail1
2021-01-23 08:31:20 +03:00
alexey-milovidov
feebf64cb1
Merge pull request #19397 from ClickHouse/aes-msan
Fix MSan report in AES functions
2021-01-23 04:47:36 +03:00