Commit Graph

2294 Commits

Author SHA1 Message Date
Robert Schulze
e031783ae5
More CMake fixes 2023-04-04 15:39:16 +00:00
natasha
c3acaecce6 fix style - missed tab 2023-04-04 16:04:33 +01:00
natasha
647fb63b83 rm unneeded parentheses 2023-04-04 16:01:15 +01:00
natasha
a1d3ea92b9 Merge remote-tracking branch 'origin/master' into format-hiliting-fix 2023-04-04 15:55:40 +01:00
natasha
95d77193af add comment re excessive copying in are_equal_with_hilites_removed 2023-04-04 15:54:42 +01:00
natasha
46691ef705 add check that all strings end without any hilite 2023-04-04 15:51:12 +01:00
natasha
a1d718c601 update docstring for consume_hilites 2023-04-04 15:12:52 +01:00
natasha
cba124f99c fix while in consume_hilites 2023-04-04 15:04:50 +01:00
natasha
f6db4fa466 avoid explicit check if strings are_equal_without_hilites in are_equal_with_hilites
if anyone needs it, they can call it themselves
2023-04-04 15:00:14 +01:00
natasha
0a021d3378 refactor consume_hilites to assign last_hilite to an argument, rather than return it, to avoid code duplication in are_equal_with_hilites 2023-04-04 14:58:39 +01:00
natasha
f3560a295d accept the pointer by & in consume_hilites, rather than by a pointer to the pointer 2023-04-04 14:39:03 +01:00
natasha
2e9607f9c1 Fix style 2023-04-04 14:33:50 +01:00
natasha
86edd48096 HiliteComparator: add Hilite alias for const char * representing hilites 2023-04-04 14:29:02 +01:00
natasha
2ff5d60509 change compare argument order to be expected, query (=actual) 2023-04-04 14:20:13 +01:00
natasha
ebb8899a3d restructure format hiliting tests to avoid code duplication 2023-04-04 14:19:06 +01:00
natasha
3e11c06976 extract HiliteComparator tests into an own test suit 2023-04-04 12:41:08 +01:00
natasha
3452e1927e move const var definition in HiliteComparator 2023-04-04 12:36:41 +01:00
natasha
880e44132f fix hilite comparator tests 2023-04-04 12:36:22 +01:00
natasha
779bd3bf4d move hilite comparator tests as well 2023-04-04 11:27:02 +01:00
Alexey Milovidov
de8f7a5ad6
Merge pull request #48189 from vitlibar/backup-all
Support BACKUP ALL command
2023-04-04 01:57:23 +03:00
Robert Schulze
c8ef87f984
Fix build 2023-04-03 13:57:16 +00:00
natasha
14b4fde1b4 extract hilite comparator tests 2023-04-03 13:49:43 +01:00
natasha
61cfad1f6d extract hilite comparator into a utility 2023-04-03 13:39:17 +01:00
natasha
264c129a96 fix misplaced ( in ASTCreateQuery.cpp 2023-04-03 12:54:34 +01:00
Vitaly Baranov
b6adc25895
Merge pull request #48289 from murfel/fix-alter-formatting
Fix alter formatting (minor)
2023-04-03 12:35:58 +02:00
Alexander Tokmakov
e39498129c
Merge branch 'master' into sync_replica_lightweight 2023-03-31 18:17:08 +03:00
Robert Schulze
e1d299640b
Small follow-up to #48017 2023-03-31 14:11:37 +00:00
Alexander Tokmakov
75ffc8451b fix 2023-03-31 16:09:00 +02:00
Robert Schulze
5d64841276
Merge pull request #48017 from ClickHouse/rs/show_columns
MySQL compatibility: Implement `SHOW COLUMNS`
2023-03-31 15:50:23 +02:00
natasha
644d83653d only set the necessary FormatStateStacked settings 2023-03-31 14:10:16 +01:00
Alexander Tokmakov
caf00b5968 Merge branch 'master' into sync_replica_lightweight 2023-03-31 14:52:55 +02:00
natasha
6caacd41d4 fix the code, single line formatter was forgotten 2023-03-31 13:45:12 +01:00
Ilya Yatsishin
baabc49f33
Update ParserKQLSort.cpp
Style
2023-03-30 11:01:51 +02:00
Vitaly Baranov
42c2ccb7cc Support BACKUP ALL command. 2023-03-30 00:11:13 +02:00
Alexander Gololobov
98b3617ce2
Merge pull request #48150 from DimasKovas/fix_stdlib_compatibility
Fix stdlib compatibility issues
2023-03-29 21:29:33 +02:00
Dmitrii Kovalkov
71a6a02e88 fix stdlib compatibility issues 2023-03-29 12:20:27 +03:00
Robert Schulze
12559236ee
Another style fix 2023-03-28 21:01:59 +00:00
Robert Schulze
6c84eabb79
Fix stylecheck 2023-03-28 20:07:26 +00:00
Robert Schulze
202f52dc3a
Implement SHOW COLUMNS
Modeled after (*)

Fixes #46437

(*) https://dev.mysql.com/doc/refman/8.0/en/show-columns.html
2023-03-28 18:04:22 +00:00
natasha
e984e221ce get rid of std::stringstream 2023-03-28 17:21:55 +01:00
natasha
d7d008c44d fix typo in hilite_none 2023-03-28 17:21:55 +01:00
natasha
ba17db5365 fix ASTCreateQuery test 2023-03-28 17:21:55 +01:00
natasha
f36ad31751 add bug: second parenthesis ) not hilited in CREATE TABLE name AS (SELECT *) COMMENT 'hello' 2023-03-28 17:21:55 +01:00
natasha
5681f2c130 remove unused compare std::stringstream overload 2023-03-28 17:21:55 +01:00
natasha
df5824a2d2 contstruct string directly without std::stringstream in tests 2023-03-28 17:21:55 +01:00
natasha
a7614b844e rename const char * it into ptr 2023-03-28 17:21:54 +01:00
natasha
36ef622853 change compare signature to accept both args as String, for symmetry 2023-03-28 17:21:54 +01:00
natasha
e14675935a remove const& from std::string_view 2023-03-28 17:21:54 +01:00
natasha
a862973f14 amend comment on hilite equality 2023-03-28 17:21:54 +01:00
natasha
cf057013ed hilite view()'s parenthesis as function as well 2023-03-28 17:21:54 +01:00