Kruglov Pavel
c6e26f6128
Merge pull request #36434 from Avogar/fix-s3-cluster
...
Fix bug in s3Cluster schema inference
2022-05-05 13:08:49 +02:00
Kruglov Pavel
97a1a2d665
Fix style
2022-05-04 17:16:02 +02:00
Kruglov Pavel
050eed68e2
Fix bug after resolving conflicts
2022-05-03 14:47:24 +02:00
Kruglov Pavel
21bc5624cc
Fix
2022-05-02 14:16:29 +02:00
Kruglov Pavel
c3570b9f7e
Merge branch 'master' into fix-s3-cluster
2022-05-02 14:15:21 +02:00
Kruglov Pavel
b8ee22eb57
Update StorageS3.cpp
2022-05-02 14:09:54 +02:00
Robert Schulze
330212e0f4
Remove inherited create() method + disallow copying
...
The original motivation for this commit was that shared_ptr_helper used
std::shared_ptr<>() which does two heap allocations instead of
make_shared<>() which does a single allocation. Turned out that
1. the affected code (--> Storages/) is not on a hot path (rendering the
performance argument moot ...)
2. yet copying Storage objects is potentially dangerous and was
previously allowed.
Hence, this change
- removes shared_ptr_helper and as a result all inherited create() methods,
- instead, Storage objects are now created using make_shared<>() by the
caller (for that to work, many constructors had to be made public), and
- all Storage classes were marked as noncopyable using boost::noncopyable.
In sum, we are (likely) not making things faster but the code becomes
cleaner and harder to misuse.
2022-05-02 08:46:52 +02:00
Sergei Trifonov
c1a0165f7d
merge from master and fix conflicts
2022-04-26 12:39:16 +02:00
Kruglov Pavel
34c342fdd3
Merge pull request #36205 from Avogar/improve-globs
...
Some refactoring around schema inference with globs
2022-04-25 13:14:46 +02:00
Amos Bird
e73d7fea31
Rename narrowBlockInputStream to narrowPipe
2022-04-24 18:33:48 +08:00
Kruglov Pavel
7fb0f2284d
Merge branch 'master' into fix-s3-cluster
2022-04-21 13:39:52 +02:00
Sergei Trifonov
34842f209c
merge master and fix conflicts
2022-04-20 18:35:56 +02:00
Kruglov Pavel
813e228fcc
Merge branch 'master' into improve-globs
2022-04-20 16:31:47 +02:00
avogar
1f252cedfe
Make better
2022-04-19 19:16:47 +00:00
avogar
9a81b67ba5
Fix bug in s3Cluster schema inference
2022-04-19 18:23:04 +00:00
avogar
1c065f8c7a
Some refactoring around schema inference with globs
2022-04-13 17:02:48 +00:00
kssenii
ef2b238444
Fix
2022-04-08 12:30:24 +02:00
Sergei Trifonov
01425df758
fix build
2022-04-07 16:07:12 +02:00
Sergei Trifonov
755d5c55f9
resolve conflict
2022-04-07 11:57:45 +02:00
Sergei Trifonov
9c2804b924
merge from master + resolve conflicts
2022-04-07 11:22:01 +02:00
kssenii
cbd7f4acfb
Fix
2022-04-05 19:24:10 +02:00
kssenii
4e50da722b
Better s3 settings
2022-04-04 16:14:56 +02:00
Alexey Milovidov
5c6b84c398
Merge pull request #35586 from kssenii/fix-virtual-columns-s3
...
Fix s3 engine getting virtual columns
2022-04-01 04:43:32 +03:00
kssenii
099fa0e668
Merge master
2022-03-30 17:33:32 +02:00
Antonio Andelic
a3ad99be03
Create CallbackRunner in Storage
2022-03-30 11:24:50 +00:00
Antonio Andelic
1173eab15e
Use same IOThreadPool for URL and S3
2022-03-30 08:15:20 +00:00
kssenii
4374415bd7
Fix clang-tidy, style check
2022-03-29 14:20:21 +02:00
kssenii
a2013ebe2b
Better
2022-03-28 22:40:27 +02:00
Antonio Andelic
d9d826c813
Address PR review
2022-03-28 08:19:23 +00:00
kssenii
c6706b8bfa
Better
2022-03-25 19:30:13 +01:00
Antonio Andelic
394682b983
Merge branch 'master' into parallel-s3-downloading
2022-03-25 13:00:44 +00:00
kssenii
e91e30aaa4
Fix
2022-03-24 17:10:27 +01:00
Antonio Andelic
62a495a5fc
Small refactor
2022-03-24 09:45:30 +00:00
Sergei Trifonov
bf9c6be6c6
move threadPoolCallbackRunner from Common into Interpreters folder to fix split build issue
2022-03-23 17:57:19 +01:00
Antonio Andelic
1a5f5c32bb
Remove commented out code
2022-03-23 14:36:25 +00:00
Antonio Andelic
93ad209910
Attach memory tracker
2022-03-23 11:52:31 +00:00
Antonio Andelic
131b3a091c
Refactor StorageS3
2022-03-23 08:57:01 +00:00
Antonio Andelic
6785ad165a
Fix issue for mutliple download threads
2022-03-22 14:06:30 +00:00
Antonio Andelic
04e6e6ab5e
Add ParallelReadBuffer for S3
2022-03-21 14:52:26 +00:00
mergify[bot]
7ac606fa65
Merge branch 'master' into parallel-multipart-upload-for-s3storage
2022-03-20 18:25:28 +00:00
Sergei Trifonov
bbe657ba24
allow parallelization of multipart S3 storage upload fixes #34350
2022-03-16 19:41:41 +01:00
Anton Popov
0ba78c3c3a
Merge remote-tracking branch 'upstream/master' into HEAD
2022-03-16 15:28:09 +00:00
Saad Ur Rahman
679abaafdc
[Storages] bugfix
...
Extracting Version Id for S3::URI.
2022-03-14 22:25:40 -04:00
Saad Ur Rahman
fb450b7068
[Storages] bugfix
...
Corrected order of parameters by swapping bucket and versionId.
2022-03-14 22:20:02 -04:00
Saad Ur Rahman
171260f40b
[Storages] Added Version ID parameter for S3.
2022-03-14 22:03:58 -04:00
Maksim Kita
2fdcf53a76
Fix clang-tidy warnings in Server, Storages folders
2022-03-14 18:17:35 +00:00
Anton Popov
df3b07fe7c
Merge remote-tracking branch 'upstream/master' into HEAD
2022-03-03 22:25:28 +00:00
Anton Popov
fcdebea925
Merge remote-tracking branch 'upstream/master' into HEAD
2022-02-25 13:41:30 +03:00
kssenii
cfad79bf74
Remove redundant
2022-02-25 09:37:48 +01:00
kssenii
003b807b00
Fix
2022-02-23 20:33:05 +01:00