Commit Graph

23 Commits

Author SHA1 Message Date
Alexey Milovidov
a7430004b3 Fix real time query profiler on AArch64 2024-03-04 18:13:49 +01:00
Maksim Kita
2a327107b6 Updated implementation 2024-01-25 14:31:49 +03:00
Nikolai Kochetov
fa06056fa2 Merge branch 'master' into revert-44629-revert_flamegraph 2023-08-01 17:14:16 +00:00
Alexey Gerasimchuck
63b05da1f2 System logs improvements 2023-07-28 07:23:34 +00:00
Nikolai Kochetov
05e9fc6f2d Merge branch 'master' into revert-44629-revert_flamegraph 2023-06-27 17:26:25 +00:00
Yakov Olkhovskiy
815cc8de9b removed unnecessary check for thread's joinability 2023-05-09 19:43:39 +00:00
Yakov Olkhovskiy
70516f2f45 close pipe in run() if exception happens 2023-05-08 23:00:20 +00:00
Yakov Olkhovskiy
1e3cd4ed6d close pipe before join 2023-05-08 12:39:01 +00:00
Yakov Olkhovskiy
3aaea2b91d join thread even exception happened 2023-05-04 13:07:28 +00:00
Nikolai Kochetov
2081408c15
Revert "Revert "Merge pull request #38953 from ClickHouse/add-allocation-ptr-to-trace-log" 2023-01-16 15:10:31 +01:00
Robert Schulze
9ef7dac0b5
Fix exception fix in TraceCollector dtor
Cf. #44758

Function try blocks in ctors/dtors implicitly rethrow, making them
more or less useless.

https://www.onlinegdb.com/pCKQA0wTIN (click RUN)

https://stackoverflow.com/questions/5612486/when-is-a-function-try-block-useful/5612508#5612508

Fortunately, this seems the only place like that in the codebase.
2023-01-05 18:27:07 +00:00
Alexey Milovidov
969214ce9e
Merge pull request #44758 from ClickHouse/fix-crash-in-trace-collector-dtor
Do not throw exceptions in ~TraceCollector.
2022-12-31 16:48:39 +03:00
Nikolai Kochetov
72f071b2b9 Do not throw exceptions in ~TraceCollector. 2022-12-30 16:13:02 +00:00
Raúl Marín
948ce8db93 Revert "Merge pull request #38953 from ClickHouse/add-allocation-ptr-to-trace-log"
This reverts commit e99849d031, reversing
changes made to 7ad3ff8a9e.
2022-12-27 14:28:13 +01:00
Nikolai Kochetov
9a4b3493fd Merge branch 'master' into add-allocation-ptr-to-trace-log 2022-12-06 17:09:54 +01:00
Nikolai Kochetov
7649a3c4d7 Merge branch 'master' into add-allocation-ptr-to-trace-log 2022-12-01 12:12:23 +01:00
Anton Popov
312dd725b4 allow to send profile events to trace_log 2022-11-24 20:12:16 +00:00
Raúl Marín
54db7c6520 Enforce checking read output 2022-11-11 10:56:18 +01:00
Nikolai Kochetov
dcdf2e4527 Track allocation ptr in system.trace_log. Add aggregate function for flamegraph. 2022-07-07 11:54:41 +00:00
Amos Bird
4a5e4274f0
base should not depend on Common 2022-04-29 10:26:35 +08:00
Robert Schulze
b24ca8de52
Fix various clang-tidy warnings
When I tried to add cool new clang-tidy 14 warnings, I noticed that the
current clang-tidy settings already produce a ton of warnings. This
commit addresses many of these. Almost all of them were non-critical,
i.e. C vs. C++ style casts.
2022-04-20 10:29:05 +02:00
Azat Khuzhin
248b879fd5 Split TraceCollector between Common and Interpreters
This is required to leave TraceCollector::collect() inside main for
MemoryTrackier.
2022-01-11 22:30:55 +03:00
Azat Khuzhin
c1dea66907 Move TraceCollector into Interpreters
Since now it relies on SystemLog that is in Interpreters, and it cannot
be moved into Common, since it has lots of dependencies.
2022-01-10 22:35:42 +03:00