Commit Graph

6019 Commits

Author SHA1 Message Date
alesapin
44370467f0 More comments 2019-12-29 14:25:26 +03:00
alesapin
247906a4d7 Move check alter to alter interpreter 2019-12-29 14:09:10 +03:00
alesapin
9ee7807f45 Remove redundant file 2019-12-29 14:04:42 +03:00
alexey-milovidov
15c67f0a0e
Merge branch 'master' into refactor_databases 2019-12-29 03:52:07 +03:00
alexey-milovidov
6830d7fa2d
Merge pull request #8440 from excitoon-favorites/bettercheckforpartsonanotherdisks
Improved check for parts on different disks
2019-12-29 00:10:47 +03:00
Amos Bird
bbc736f2d9
c++20! 2019-12-29 03:08:25 +08:00
alesapin
9c42801c94 Fix stupid bug 2019-12-28 12:21:09 +03:00
Vladimir Chebotarev
1ad0c92873 Fixed logic error introduced in previous commit. 2019-12-28 10:30:12 +03:00
alesapin
c48f892e13 Merge with master 2019-12-27 23:12:54 +03:00
alesapin
fef681acfe Fix style 2019-12-27 23:10:30 +03:00
Alexander Tokmakov
94931f059d minor improvements 2019-12-27 22:30:22 +03:00
alesapin
5334103690 More usage of StorageInMemoryMetadata 2019-12-27 22:04:30 +03:00
Vladimir Chebotarev
3c2ddc5a81 Improved check for parts on different disks. 2019-12-27 21:58:59 +03:00
Alexey Milovidov
cb3a5b26f7 Merge branch 'master' into enable-experimental-indices-and-make-settings-obsolete 2019-12-27 21:12:30 +03:00
alesapin
2d40b33120 More usage of metadata 2019-12-27 19:34:50 +03:00
alesapin
fcf3552750 Better changes 2019-12-27 18:07:53 +03:00
alesapin
d610bb215a Remove cerr 2019-12-27 18:05:23 +03:00
alesapin
166c1da6c9 Removed redundat changes 2019-12-27 18:03:49 +03:00
alesapin
7ad59edf8f Slightly more comments 2019-12-27 18:01:41 +03:00
alesapin
6916ac08c2 Rename fields 2019-12-27 17:46:11 +03:00
alesapin
716648bfa4 Something working 2019-12-27 17:36:59 +03:00
Ivan Lezhankin
bf22e12e4e Initial replacement readline → replxx 2019-12-27 16:17:36 +03:00
Alexander Tokmakov
a2a155dcbd Merge branch 'master' into table_name_in_istorage 2019-12-27 15:47:29 +03:00
chertus
3e13157994 better engine Join tests 2019-12-27 15:41:55 +03:00
Alexander Tokmakov
8987b027ba fixes 2019-12-27 15:18:49 +03:00
Alexander Burmak
9df9983641 Added fileName and parentPath utility functions 2019-12-27 13:42:30 +03:00
alesapin
ccb4ad450c Merge branch 'master' into refactor_alter 2019-12-27 12:07:20 +03:00
Alexander Burmak
170bcf041a Merge remote-tracking branch 'refs/remotes/upstream/master' into vfs_log 2019-12-27 09:55:54 +03:00
Vitaly Baranov
b75771be61
Merge pull request #7808 from vitlibar/RBAC-3
RBAC-3
2019-12-27 09:44:24 +07:00
alexey-milovidov
d021d5e0ec
Merge pull request #8419 from apbodrov/url_fix
[ISSUE-8157] incorrect parsing of file extension in URL
2019-12-27 02:25:39 +03:00
alexey-milovidov
d2e5827307
Merge pull request #8410 from excitoon-favorites/ttlcheckvaliddeestination
Added check for valid destination in a move TTL rule
2019-12-27 00:29:55 +03:00
alexey-milovidov
89eeaa50e9
Merge branch 'master' into enable-experimental-indices-and-make-settings-obsolete 2019-12-26 22:16:50 +03:00
alexey-milovidov
1adc3cfb88
Merge pull request #8118 from excitoon-favorites/scan_all_disks
Check extra parts of `MergeTree` at different disks, in order to not allow to miss data parts at undefined disks
2019-12-26 22:10:53 +03:00
alexey-milovidov
938100dbe2
Update MergeTreeData.cpp 2019-12-26 22:10:04 +03:00
alesapin
d341b648d2 Better alter 2019-12-26 21:17:05 +03:00
Alexander Tokmakov
42296cc80a remove separate getTableName() and getDatabaseName() 2019-12-26 21:11:49 +03:00
Alexander Tokmakov
ef129b4b7c use StorageID in views 2019-12-26 20:59:47 +03:00
Alexander Tokmakov
9319863a59 refactor table dependencies 2019-12-26 20:23:24 +03:00
Alexander Tokmakov
2e5d61cd81 better constructors of storages 2019-12-26 20:04:08 +03:00
Andrei Bodrov
1516a252ee one line 2019-12-26 19:51:17 +03:00
Alexander Burmak
682b72551f Fixed merge issues 2019-12-26 19:38:10 +03:00
Alexander Tokmakov
cf5c998b30 refactor storage name 2019-12-26 19:23:38 +03:00
Artem Zuikov
b282cbcc91
Merge pull request #8400 from 4ertus2/joins
New ANY JOIN + SEMI, ANTI JOIN for StorageJoin
2019-12-26 18:35:50 +03:00
Vladimir Chebotarev
64b2b18d5b Added a check for bad disk/volume as a destination of move TTL expression. 2019-12-26 18:04:55 +03:00
Alexander Burmak
3f1832355f Added WriteMode enumeration 2019-12-26 17:28:22 +03:00
Alexander Burmak
764b506fd5 Merge remote-tracking branch 'refs/remotes/upstream/master' into vfs_log 2019-12-26 17:03:32 +03:00
Alexander Tokmakov
50200e245b Merge branch 'master' into refactor_databases 2019-12-26 15:00:07 +03:00
alesapin
6f28e69e97
Merge pull request #8345 from azat/fix-flaky-test--Buffer_and_max_memory_usage
Fix buffer overcommit and 01019_Buffer_and_max_memory_usage flakiness
2019-12-26 13:21:47 +03:00
alesapin
093d56f474
Merge pull request #8382 from ClickHouse/relative_paths_in_storages
Use relative paths in Storages
2019-12-26 13:05:37 +03:00
Vladimir Chebotarev
c4e9784464 Fixed skipping parts algorithm while checking parts on other disks. 2019-12-26 01:12:17 +03:00
Vladimir Chebotarev
ab5171f403 Fixed tests. 2019-12-25 23:32:15 +03:00
Vladimir Chebotarev
29068663ea Fixed build. 2019-12-25 23:32:15 +03:00
Vladimir Chebotarev
80056551ce Check extra parts of MergeTree at different disks, in order to not allow to miss data parts at undefined disks. 2019-12-25 23:32:15 +03:00
chertus
4fd7340416 New ANY JOIN for StorageJoin + SEMI, ANTI 2019-12-25 20:32:55 +03:00
Alexander Tokmakov
7c48396689 refactor databases: inherit from DatabaseOnDisk 2019-12-25 16:23:38 +03:00
alesapin
3b6e3db0c2 Remove redundant alter_lock, because parts cannot be altered concurrently. 2019-12-25 15:34:04 +03:00
alesapin
d4987f86d3 Merge branch 'master' into immutable_parts 2019-12-25 11:44:47 +03:00
Alexander Burmak
544bfd105b Corrected naming based on review feedback 2019-12-25 11:24:13 +03:00
alesapin
34d2afa354 Fix obvious bug 2019-12-24 23:03:33 +03:00
Nikolai Kochetov
6a1dccd27c Change initialization order for StorageDistributedDirectoryMonitor members. 2019-12-24 21:25:00 +03:00
alesapin
05b933b1d3 Better 2019-12-24 21:07:51 +03:00
Alexander Tokmakov
6325f8507c fixes 2019-12-24 20:41:24 +03:00
Alexander Tokmakov
60a47c3453 Merge branch 'master' into relative_paths_in_storages 2019-12-24 19:58:34 +03:00
tavplubix
7c1a6c726d
Merge pull request #8359 from ClickHouse/more_readable_interpreter_create
Refactor table creation
2019-12-24 18:07:43 +03:00
Alexander Tokmakov
514868cebc use relative paths in IStorage::rename(...) 2019-12-24 16:35:50 +03:00
Alexander Burmak
97f03ab064 Fixed CI errors 2019-12-24 13:25:14 +03:00
alexey-milovidov
28c7e78d36
Merge pull request #8344 from ClickHouse/system-stack-trace
Added system.stack_trace table.
2019-12-24 12:15:48 +03:00
Alexander Tokmakov
ac3f53f300 refactor StorageFile construction 2019-12-23 23:07:31 +03:00
Alexey Milovidov
3b7f3b07cd Better handling of signals 2019-12-23 22:23:54 +03:00
Alexey Milovidov
e907ce103e Fixed warning 2019-12-23 21:58:42 +03:00
Alexey Milovidov
9da4b63fe9 Fixed Darwin build 2019-12-23 21:56:57 +03:00
Alexey Milovidov
56870c6b3b Fixed -Wshadow 2019-12-23 19:49:06 +03:00
alesapin
25ecc38615 More correct separation between metadata and data alters for non replicated MergeTree. 2019-12-23 19:44:50 +03:00
Alexander Tokmakov
5fab732408 use arbitrary relative path in *MergeTree 2019-12-23 18:37:55 +03:00
Alexander Tokmakov
4f58d662f7 make data path relative 2019-12-23 18:20:08 +03:00
alesapin
73c9f0e71c Remove redundant code 2019-12-23 17:46:00 +03:00
alesapin
f168977b9a Merge branch 'master' into synchronous_mutations 2019-12-23 16:24:50 +03:00
Alexander Burmak
0894ed9f33 Integration of log storages with IDisk interface 2019-12-23 16:11:56 +03:00
Azat Khuzhin
58055e6a94 Do not overcommit Buffer memory usage
During INSERT the check against existing rows and rows from the INSERT
block is performed and if they exceeded threshold the Buffer should be
flushed to avoid overcommit, while before this patch the second check
(in flushBuffer()) will ignore rows from INSERT block.
2019-12-23 01:39:37 +03:00
Alexey Milovidov
4d349e9ed0 Added TODO 2019-12-23 00:01:12 +03:00
Alexey Milovidov
ca25e2f30f Added query_id to "system.stack_trace" 2019-12-22 23:37:29 +03:00
Alexey Milovidov
9c868c910a Simplification 2019-12-22 23:17:16 +03:00
Alexey Milovidov
e0000bef98 Added "system.stack_trace" table (development) 2019-12-22 20:20:33 +03:00
alexey-milovidov
fee9fda34c
Merge pull request #8130 from CurtizJ/optimize-storage-merge
Implement ORDER BY optimization for Storage Merge.
2019-12-22 12:43:18 +03:00
alexey-milovidov
980cf16873
Merge pull request #8323 from ClickHouse/minor-improvements-backquote
Added quoting of db and table names where appropriate
2019-12-20 22:14:35 +03:00
alexey-milovidov
0d119a40eb
Merge pull request #8240 from vitlibar/sync-system-reload-dictionary
Synchronous system reload dictionary
2019-12-20 20:00:03 +03:00
Alexey Milovidov
41ed1ed471 Added quoting of db and table names where appropriate 2019-12-20 19:53:37 +03:00
proller
521e2e709e Build fixes. Arm, minimal build 2019-12-20 17:46:00 +03:00
CurtizJ
75c5e02ec2 improve input order analyzing and turn on order by optimization with left/inner joins 2019-12-20 16:15:17 +03:00
Alexander Tokmakov
10ad22faea refactor InterpreterCreateQuery::createTable(...) 2019-12-20 15:51:51 +03:00
alexey-milovidov
7f10630873
Merge pull request #8308 from ClickHouse/deprecate-merge_tree_uniform_read_distribution
Deprecate "merge_tree_uniform_read_distribution" setting
2019-12-20 15:28:34 +03:00
Javi santana bot
dd5435501a check for active replicas when waiting for commands 2019-12-20 11:04:16 +01:00
alexey-milovidov
de01dd12b5
Merge pull request #8306 from ClickHouse/fix_rename_distributed
Fix rename distributed
2019-12-20 04:38:21 +03:00
Alexey Milovidov
0ac868ed48 Deprecate "merge_tree_uniform_read_distribution" setting 2019-12-20 04:11:37 +03:00
Alexey Milovidov
371aef532c Deprecate "merge_tree_uniform_read_distribution" setting 2019-12-20 02:49:41 +03:00
Alexey Milovidov
9ce8d5fe54 Deprecate "merge_tree_uniform_read_distribution" setting 2019-12-20 01:38:05 +03:00
chertus
b5658ef1a3 remove qualification in StorageJoin JOIN case 2019-12-19 23:37:10 +03:00
Alexander Tokmakov
d1568c1614 fix rename distributed 2019-12-19 22:51:12 +03:00
chertus
c72b0d4e2a fix engine join crash [wip] 2019-12-19 18:50:28 +03:00
Vitaly Baranov
6baccb963d Add functions currentRowPolicies() and system table 'system.row_policies'. 2019-12-19 18:40:15 +03:00
alesapin
0cc7ccfc2e Remove unintended diff 2019-12-19 18:30:52 +03:00
alesapin
9fea941009 Make wait endless 2019-12-19 18:27:56 +03:00
alesapin
88033a4333 Merge branch 'master' into synchronous_mutations 2019-12-19 15:44:02 +03:00
alexey-milovidov
f5a16b1229
Update KeyCondition.cpp 2019-12-18 22:04:33 +03:00
alexey-milovidov
b5cab7c721
Update KeyCondition.cpp 2019-12-18 22:03:57 +03:00
Alexey Milovidov
90795b7d4b Added asserts to KeyCondition while evaluating RPN 2019-12-18 22:00:09 +03:00
alesapin
f110b70ad8 Merge branch 'master' into synchronous_mutations 2019-12-18 12:00:14 +03:00
alexey-milovidov
a7384b4d07
Merge branch 'master' into MoreGCCWarnings 2019-12-18 02:01:39 +03:00
alesapin
9a005d27ea Merge branch 'master' into synchronous_mutations 2019-12-17 15:27:36 +03:00
alesapin
b2979546c3 Fix mutation number by default 2019-12-17 15:23:17 +03:00
Vitaly Baranov
d0d5c72e4d Reloading of a dictionary now waits for results and shows errors.
Clearer names for load and reload functions in ExternalLoader.
2019-12-17 13:45:47 +03:00
Guillaume Tassery
bdcee8b382 Merge branch 'master' of github.com:ClickHouse/ClickHouse into move_partition 2019-12-17 11:18:11 +01:00
Olga Khvostikova
b47863a0c6
Fix segfault in table function file while inserting into it (#8177)
* Fix segfault in table function file while inserting into it
2019-12-17 11:06:39 +03:00
Guillaume Tassery
de9ab66935 fix merge conflict 2019-12-17 08:20:54 +01:00
Guillaume Tassery
595815bdf5 Add table as part destination type 2019-12-17 07:51:40 +01:00
Guillaume Tassery
dca0c83809
Merge branch 'master' into move_partition 2019-12-17 13:49:18 +07:00
Vxider
f564d524e5 parallel insert support for ReplicatedMergeTree 2019-12-17 12:22:58 +08:00
Vxider
2a94832ef6 parallel INSERT in INSERT SELECT query 2019-12-17 12:22:58 +08:00
kreuzerkrieg
9612bb0e79 More GCC warnings 2019-12-16 23:19:50 +02:00
alesapin
2695aa13c4 Add ability to execute mutations asynchronously 2019-12-16 18:51:15 +03:00
alexey-milovidov
d0ef4b6b96
Merge branch 'master' into more-accurate-using-load-reload 2019-12-16 02:42:45 +03:00
Vitaliy Zakaznikov
cf22cde702 Merge branch 'master' of https://github.com/vzakaznikov/ClickHouse into live_view_support_for_subquery 2019-12-14 19:21:44 +01:00
Vitaliy Zakaznikov
0f9450433f * Reverting back to the old logic.
* Removing redundant catch clauses.
* Updating createStorage function signature in StorageBlocks.h.
2019-12-14 18:29:34 +01:00
Nikolai Kochetov
28fcc6902f Try to simplify code in StorageLiveView 2019-12-13 20:08:21 +03:00
Mikhail Filimonov
f3fa71c707 Init query context for Kafka to make subqueries work 2019-12-13 02:21:40 +01:00
alexey-milovidov
399995d60b
Merge pull request #7812 from infinivision/fix_part_mutation
fix part mutation
2019-12-13 03:45:59 +03:00
alexey-milovidov
d0cf282204
Merge pull request #8179 from ClickHouse/parts_to_do_names
Add parts_to_do_names column to system.mutations.
2019-12-13 02:30:03 +03:00
alexey-milovidov
69535078fd
Merge pull request #8192 from excitoon-favorites/better-logging-disks
Better logging in background move task.
2019-12-13 02:27:38 +03:00
alexey-milovidov
32f42c4e92
Merge pull request #8194 from excitoon-favorites/fixed-move-pool
Fixed metrics in `BackgroundProcessingPool`
2019-12-13 02:26:52 +03:00
Artem Zuikov
5783142f39
Merge pull request #8178 from 4ertus2/some
Refactoring: extract getTableExpressions() variants into own file
2019-12-13 01:09:47 +03:00
Vladimir Chebotarev
e413cd6e6c Fixed metrics in BackgroundProcessingPool. 2019-12-13 01:08:54 +03:00
Vladimir Chebotarev
9882c7c5ad Minor fix in logging. 2019-12-13 00:38:05 +03:00
Vladimir Chebotarev
9393bb0f12 Better logging in background move task. 2019-12-13 00:34:57 +03:00
Vitaly Baranov
4c157007f5 Refactoring of using ExternalLoader in dictionary DDL:
Instead of using ExternalLoader::reload() now it's used reloadConfig() which reloads only what necessary.
Functions attachDictionary() and detachDictionary() are simplified and have lesser number of parameters.
Instead of injecting into LoadablesConfigReader's internals for creating dictionary a temp repository is used.
2019-12-12 21:45:58 +03:00
alexey-milovidov
51ed10ed78
Merge pull request #8011 from Jokser/aws-s3-sdk-integration
AWS SDK S3 integration
2019-12-12 20:43:16 +03:00
alesapin
b7622c8fd9 Add parts_to_do_names column to system.mutations 2019-12-12 19:24:03 +03:00
chertus
68a33863ab extract getTableExpressions variants into own file 2019-12-12 19:06:18 +03:00
Alexander Burmak
1f69a7a015 Fixed merge issues 2019-12-12 14:10:18 +03:00
Alexander Burmak
2ce6136de5 Merge remote-tracking branch 'refs/remotes/upstream/master' into vfs 2019-12-12 12:10:50 +03:00
CurtizJ
890bfeb4eb fix order description analyzing 2019-12-11 21:52:59 +03:00
Pavel Kovalenko
c7f016fc4e AWS SDK integration - code cleanup. 2019-12-11 17:21:48 +03:00
CurtizJ
6834fbf03d implement ORDER BY optimization for some other meta-storages 2019-12-11 16:09:46 +03:00
alesapin
2940aeff23 Fix style 2019-12-11 13:24:20 +03:00
alesapin
fd9483efbe Just trigger CI 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
0ff0a52249 Missed review fixes. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
f2aee64072 Minor style fix. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
e41deb5848 Added comment to MergeTreePartsMover::selectPartsForMove(). 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
7fd1668fde Review fixes. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
e3ed311273 Fixed Clang build. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
67aa268bbb Finally fixed tests and logic for extended TTL syntax. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
f83b28a1c1 Fixed a typo in MergeTreeData::selectMoveDestination(). 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
618a39cc8c Don't move anything if part already belongs their destination. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
f72da4ab0c Removing expired rows shall not be triggered on move TTL expiration. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
8ed37801ca Finally fixed selection of destination of move TTL. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
15fb64f54b Fixed move TTL expiration logic. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
df002f20b1 Fixed move TTL metadata. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
14cf530542 Added move TTL rules to metadata of ReplicatedMergeTree. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
7407f7c39d Placed move TTL rules to a vector. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
108e2b33eb Fixed a bug with erasing columns with same name. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
0da7234d99 Added few FIXMEs to not forget. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
ce851fc782 Fixed MergeTreeData::hasTableTTL() method according to extended TTLs. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
cb777f6c50 Removed redundant template from updateTTL() method. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
62016feab0 Renamed TTLDestinationType to PartDestinationType. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
cc0c21604f Fixed Clang build one more time. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
ce066d3bb0 Style fixes. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
88c7220256 Fixed Clang build. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
3e3e9ac56f Moved settings for BackgroundProcessingPool to configuration. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
e519c04bbe Minor fix of JSON handling in MergeTreeDataPartTTLInfo. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
342ea5c30a Removed TODO comments. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
58e824b6a1 Refactored, added move enforcement on merges, fixed a bug with wrong disk selection in ReplicatedMergeTree. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
dfe0edc03f Style fix. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
76c4ac9f60 Fixed ttl move logic in background move task and added ttl enforcement on inserts. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
575de5ada6 Attempt to add background moves by TTL expressions. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
893e0de37a Minor fix. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
33ded274a3 First attempt to store min/max for move ttl expressions. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
3e984609fb Fixed ClickHouse after changing syntax. 2019-12-11 13:24:20 +03:00
Vladimir Chebotarev
7a37c4f6a9 Parser for extended TTL expressions. 2019-12-11 13:24:20 +03:00
Alexey Milovidov
4f9cd8a3c8 Update contributors 2019-12-11 06:13:33 +03:00
CurtizJ
fd5b23730e implement order by optimization for storage Merge 2019-12-11 04:35:47 +03:00
CurtizJ
45a9751c31 refactoring of order by optimization 2019-12-11 04:34:39 +03:00
Zhichang Yu
ff1b8d46e2 fixed part mutation, added test_backup_restore integration test case 2019-12-11 09:31:37 +08:00
CurtizJ
9e75892516 refactoring of order by optimization 2019-12-11 02:18:24 +03:00
Vladimir Chebotarev
269a0246aa Added explicit check for existence of part and pair of log messages. 2019-12-10 12:47:23 +03:00
Vladimir Chebotarev
6afd8d7805 Added test_multiple_disk::test_kill_while_insert, reworked log message and fixed logic of treating stale copies. 2019-12-09 23:29:44 +03:00
Vladimir Chebotarev
a2f238d8da Added more logging and switched to detaching stale part instead of removing. 2019-12-09 23:29:44 +03:00
Vladimir Chebotarev
9cf7ef03af Fixed handling of MergeTreeData::DataPartPtr's in MergeTreeData::swapActivePart(). 2019-12-09 23:29:44 +03:00
Vladimir Chebotarev
374e0f7bb5 Finally fixed tests. 2019-12-09 23:29:44 +03:00
Vladimir Chebotarev
c283776e84 Really fixed tests. 2019-12-09 23:29:44 +03:00
Vladimir Chebotarev
89659a9129 Fixed a typo. 2019-12-09 23:29:44 +03:00
Vladimir Chebotarev
fe3e89fb38 Fixed tests. 2019-12-09 23:29:44 +03:00
filimonov
f545da40e6 style 2019-12-09 23:29:44 +03:00
filimonov
0ab67c7b1f Log when part is removed after move 2019-12-09 23:29:44 +03:00
Vladimir Chebotarev
efa73608b8 Separated constant path to DeleteOnDestroy marker. 2019-12-09 23:29:44 +03:00
Vladimir Chebotarev
13c5c621c1 Attempt to ignore redundant copies of parts after move and restart. 2019-12-09 23:29:44 +03:00
Alexander Burmak
5a93441445 Merge remote-tracking branch 'refs/remotes/upstream/master' into vfs 2019-12-09 17:18:47 +03:00
Pavel Kovalenko
ba59991912 AWS SDK integration - added new lines at the end of files. 2019-12-09 15:36:06 +03:00
Pavel Kovalenko
94e9638006 AWS SDK integration added url checking. 2019-12-09 13:58:57 +03:00
alexey-milovidov
cf194edfaf
Merge pull request #8016 from filimonov/kafka_fixes
Kafka fixes
2019-12-09 00:03:36 +03:00
alexey-milovidov
ee7d675f86
Update KafkaBlockInputStream.cpp 2019-12-09 00:03:09 +03:00
alexey-milovidov
16754bfff5
Merge pull request #8043 from excitoon-favorites/systemmergespaths
Added information about paths to `system.merges`.
2019-12-08 23:30:39 +03:00
Alexander Burmak
edd11abad1 Addressed code review comments 2019-12-08 19:47:51 +03:00
Alexander Burmak
8104395dd2 Merge remote-tracking branch 'refs/remotes/upstream/master' into vfs 2019-12-08 11:45:18 +03:00
alesapin
af7b8f9274
Merge pull request #8051 from ClickHouse/fix_collations_behaviour
Fix several bugs with collations.
2019-12-08 11:10:23 +03:00
Vladimir Chebotarev
984e81876a Fixed Clang build. 2019-12-07 22:30:37 +03:00
Vladimir Chebotarev
1fbfb50fba Fixed updating result_part_path while merging and mutating. 2019-12-07 12:54:05 +03:00
Vladimir Chebotarev
05a05b5fb6 Fixed result_part_part of a mutation. 2019-12-07 11:10:08 +03:00
alesapin
3881a85c39 Review fixes 2019-12-07 01:22:12 +03:00
Pavel Kovalenko
c840fdefc0 Merge branch 'master' into aws-s3-sdk-integration
# Conflicts:
#	dbms/src/Common/ErrorCodes.cpp
#	dbms/src/IO/ReadBufferFromS3.cpp
#	dbms/src/IO/ReadBufferFromS3.h
#	dbms/src/IO/WriteBufferFromS3.cpp
#	dbms/src/IO/WriteBufferFromS3.h
#	dbms/src/Storages/StorageS3.cpp
2019-12-06 17:52:29 +03:00
alexey-milovidov
3d279499d0
Merge pull request #7632 from hczhcz/patch-2
Allow relative user_files_path
2019-12-06 17:44:18 +03:00
Pavel Kovalenko
a9dfefd37f AWS SDK integration rework. 2019-12-06 17:37:21 +03:00
robot-clickhouse
6d56509109 Auto version update to [19.19.1.1] [54430] 2019-12-06 17:22:00 +03:00
Vitaly Baranov
8bd9709d1d
Merge pull request #8044 from vitlibar/simplify-format-of-header-of-distributed-send
Simplify format of the header of data sent to a shard in a distributed query.
2019-12-06 15:46:00 +03:00
Vitaliy Zakaznikov
435ce84939 Setting table alias when replacing subquery with a table.
Adding extra tests that use table aliases.
2019-12-06 13:31:08 +01:00
Mikhail Filimonov
4e4957e052 returning allowNext() to the proper position 2019-12-06 12:22:36 +01:00
Vitaly Baranov
2133492598
Merge pull request #7257 from vitlibar/RBAC-2
RBAC-2
2019-12-06 03:19:39 +03:00
Vitaliy Zakaznikov
ae3749d764 Fixing clang error in dbms/src/Storages/LiveView/StorageBlocks.h 2019-12-05 19:08:40 -05:00
Vitaliy Zakaznikov
2d6645cc1b Fixing clang error. 2019-12-05 17:04:55 -05:00
Vitaliy Zakaznikov
613c343c09 Fixing styling issues. 2019-12-05 16:48:25 -05:00
Vitaliy Zakaznikov
32fe9ea9d5 Fixing issue with support for nested subqueries.
Adding additional live view with subquery tests.
2019-12-05 22:42:00 +01:00
Mikhail Filimonov
7d760a964d Fix for timestamp & style 2019-12-05 22:21:15 +01:00
alesapin
6afafef86c
Merge pull request #8047 from ClickHouse/fix_check_query_again
Fix bug in checkDataPart
2019-12-05 21:31:36 +03:00
Vitaly Baranov
d9b1a733fc Add table system.quotas. 2019-12-05 21:03:57 +03:00
alesapin
772bb0b70b Fix collation locales 2019-12-05 18:35:09 +03:00
Vitaliy Zakaznikov
28db10fd7d Fixing styling errors. 2019-12-05 14:26:47 +01:00
alesapin
ee46a73d25 Fix bug in checkDataPart when last granule has same number of rows as in .mrk file 2019-12-05 15:01:36 +03:00
Vitaliy Zakaznikov
e20793b2dc Merge remote-tracking branch 'origin/master' into live_view_support_for_subquery 2019-12-05 06:54:04 -05:00
Vitaliy Zakaznikov
1e0e00b7e4 Small fixes to empty lines and style. 2019-12-05 06:53:36 -05:00
Nikolai Kochetov
26e415736a
Merge pull request #7665 from 4ertus2/joins
New ANY, SEMI, ANTI JOIN (HashJoin only)
2019-12-05 14:38:20 +03:00
Vitaly Baranov
133675a86a Simplify format of the header of data sending to a shard in a distributed query. 2019-12-05 13:34:25 +03:00
Vladimir Chebotarev
7c7562987d Removed is_move from system.merges. 2019-12-05 12:31:45 +03:00
Vitaliy Zakaznikov
7f92e6a21f Draft of proper support for subquries in live view tables. 2019-12-05 00:29:37 +01:00
Azat Khuzhin
3a72e1c12a Add checksum for extra info/query in distributed sends
This extras includes:
- server revision
- query settings
- query

Otherwise the code can try to interpret data, and got for instance
std::length_error exception, which is not catched (to mark the part as
broken). Also this will protect from the corruptions on disk.

And add a simple test, since dbms/tests/integration/test_insert_into_distributed too complex.

Also simplify the code by using readStringBinary() over
readVarUInt()+b.readStrict() (this also gains additional checks that
string is not bigger then 1GB).

Refs: #4852 (8ef7f3589a)
v2: avoid ABI breakage (suggested by @vitlibar)
v3: minor code fixes (suggested by @vitlibar) and as a consequence clang-8 build fix
v4: drop DBMS_MIN_REVISION_WITH_EXTRAS_CHECKSUM_IN_DIST_BATCH and also
    revert some renames to make the patch cleaner
2019-12-04 22:54:38 +03:00
Mikhail Filimonov
34275626de Fix for https://github.com/ClickHouse/ClickHouse/issues/8003 : old producers do not write timestamp, but column still should have enough rows 2019-12-03 23:03:43 +01:00
Mikhail Filimonov
3de3ba336a Fix Native format in Kafka 2019-12-03 22:12:47 +01:00
Mikhail Filimonov
6e426592a7 Make the formats like RowBinaryWithNamesAndTypes work in Kafka & do not try to parse buffer when it at eof 2019-12-03 22:03:22 +01:00
alesapin
fa4728d44f Fix style 2019-12-03 20:57:00 +03:00
alesapin
2a43daec5c Buildable code 2019-12-03 20:15:16 +03:00
alesapin
20e4e92c49 Fix some conflicts 2019-12-03 19:32:41 +03:00
Pavel Kovalenko
a9e2327ec0 AWS S3 SDK integration. 2019-12-03 19:23:24 +03:00
Alexander Burmak
21623c3308 Merge remote-tracking branch 'refs/remotes/upstream/master' into vfs 2019-12-03 18:16:19 +03:00
alexey-milovidov
f09c29a2b6
Merge pull request #7992 from ClickHouse/excitoon-favorites-s3auth
Merging #7623
2019-12-03 15:21:12 +03:00
Alexey Milovidov
0da80b3c7b Merge branch 'master' of github.com:yandex/ClickHouse into enable-experimental-indices-and-make-settings-obsolete 2019-12-03 04:35:42 +03:00
Alexey Milovidov
eef44d3fc5 Merge branch 'master' into enable-experimental-indices-and-make-settings-obsolete 2019-12-03 04:31:08 +03:00
alexey-milovidov
87adf355e8
Merge pull request #7935 from filimonov/kafka_perf
[wip] attempt to improve kafka parsing performance
2019-12-03 03:52:40 +03:00
alexey-milovidov
b6edda194f
Update KafkaBlockInputStream.cpp 2019-12-03 03:52:02 +03:00
Alexey Milovidov
d70b73f033 Merge branch 's3auth' of https://github.com/excitoon-favorites/ClickHouse into excitoon-favorites-s3auth 2019-12-03 03:06:01 +03:00
alexey-milovidov
fe05565cec
Update StorageS3.cpp 2019-12-03 03:03:44 +03:00
Alexey Milovidov
fc174dce6e More simple 2019-12-03 02:50:53 +03:00
Alexey Milovidov
9d099bde8e Merge branch 'master' into fix_check_table_with_empty_pk 2019-12-03 02:36:21 +03:00
alexey-milovidov
e44dc0a6c8
Merge pull request #7981 from ClickHouse/fix_number_of_streams_for_storages_with_globs
Limit number of streams for read from StorageFile and StorageHDFS
2019-12-03 02:23:10 +03:00
Alexey Milovidov
060e4db596 Fixed build 2019-12-03 01:37:24 +03:00
Alexey Milovidov
034ef665f1 Merge branch 'master' of github.com:yandex/ClickHouse into enable-experimental-indices-and-make-settings-obsolete 2019-12-03 00:36:31 +03:00
chertus
a179c5025f Merge branch 'master' into joins 2019-12-02 21:08:39 +03:00
chertus
5ce65546e9 semi & anti join 2019-12-02 21:08:04 +03:00
Vitaly Baranov
b2685a3710
Merge pull request #7727 from kekekekule/master
Added lifetime to system.dictionaries #6820
2019-12-02 15:15:44 +03:00
alesapin
08dfd1d1c4 Limit number of streams for read from StorageFile and StorageHDFS 2019-12-02 14:25:41 +03:00
alesapin
a4ca30b5fd Fix bug in check table for tables without primary key 2019-12-02 13:30:04 +03:00
Vladimir Chebotarev
8dbfcdb3c3 Fixed failing tests. 2019-12-01 20:41:35 +03:00
Vladimir Chebotarev
ef5c4fb5a4 Remake of result_part_path. 2019-12-01 20:41:35 +03:00
Vladimir Chebotarev
b23d411f84 Filling result_part_path column of system.merges during the merge. 2019-12-01 20:41:35 +03:00
Vladimir Chebotarev
41c965e4ba Attempt to add is_move, source_part_paths, result_part_path columns to system.merges. 2019-12-01 20:41:35 +03:00
Vladimir Chebotarev
94684c07bf Added syntax for access_key_id and secret_access_key in S3 table function and storage. 2019-12-01 10:56:11 +03:00
Артем Стрельцов
25aa2114b2 Deleted redundant empty lines 2019-12-01 03:49:11 +03:00
Alexey Milovidov
8916b8f2e6 Make data skipping indices non-experimental. Make settings about data skipping indices, multiple JOINs and CROSS to INNER JOIN conversion obsolete, 2019-11-30 23:41:02 +03:00
Alexander Burmak
e5ffdc0224 Merge remote-tracking branch 'refs/remotes/upstream/master' into vfs 2019-11-29 18:27:56 +03:00
Nikolay Degterinsky
6b39253b71 Fixed naming 2019-11-29 17:15:12 +03:00
Nikolay Degterinsky
59002ddb91 Merge branch 'master' of https://github.com/kekekekule/ClickHouse into dict_lifetime 2019-11-29 17:06:38 +03:00
Mikhail Filimonov
ad136ec62d get rid of cloneWithColumns in internal loop and some other trash 2019-11-29 11:46:25 +01:00
Nikolai Kochetov
7a32ca057d
Merge pull request #7670 from excitoon-favorites/move_pool
Separated pool for background moves
2019-11-29 11:08:51 +03:00
hcz
dd7051bd98 Merge remote-tracking branch 'origin/master' into patch-2 2019-11-29 15:07:53 +08:00
Mikhail Filimonov
4cc0d0ca5d make virtual_columns local 2019-11-29 07:21:31 +01:00
Mikhail Filimonov
07722dfa93 more progress - cleanup internal cycles 2019-11-29 00:06:03 +01:00
alexey-milovidov
2e34f02a36
Merge pull request #7936 from ClickHouse/branch-for-slightly-improvement-of-usability-of-exception-messages
The rest of PR #7897 about improvement of exception message
2019-11-28 22:07:29 +03:00
Mikhail Filimonov
6217cb51f6 Get rid of InputStream layer for Kafka, use InputStream directly. Reopening port during reset. 2019-11-28 17:43:06 +01:00
stavrolia
295633b7ef Another try 2019-11-28 17:31:35 +03:00
Anton Popov
9fe987c8e1
Merge pull request #7920 from excitoon-favorites/datetimettl
Removed check for using `Date` or `DateTime` column from TTL expressions
2019-11-27 19:55:57 +03:00
stavrolia
f23273fa80 Fix 2019-11-27 17:29:00 +03:00
Nikolai Kochetov
bd40c9cd13
Merge pull request #7933 from azat/dist-mon-codec-errors-mark-broken
DirectoryMonitor: mark batch as broken on UNKNOWN_CODEC/CANNOT_DECOMPRESS errors
2019-11-27 16:03:44 +03:00
Alexander Burmak
3e5ef56644 Filesystem abstraction layer 2019-11-27 14:33:27 +03:00
Vladimir Chebotarev
ecaa98e4e4 Allowed to use constant TTL expressions, updated tests. 2019-11-27 13:11:17 +03:00
Vladimir Chebotarev
c396af7c40 Removed check for using Date or DateTime column from TTL expressions. 2019-11-27 13:11:17 +03:00
stavrolia
f1e5e58480 Some rest of PR about improvement of exception message 2019-11-27 04:18:26 +03:00
Mikhail Filimonov
deec48a3e0 attempt to fix kafka parsing performance regression https://github.com/ClickHouse/ClickHouse/issues/7261 2019-11-27 00:46:19 +01:00
Azat Khuzhin
362505b129 DirectoryMonitor: mark batch as broken on UNKNOWN_CODEC/CANNOT_DECOMPRESS errors
There is no point in retrying batch after those errors (for the same
reasons as CHECKSUM_DOESNT_MATCH is there).
2019-11-26 20:21:05 +03:00
Vladimir Chebotarev
37bc15779d Better logging of BackgroundMovePool. 2019-11-26 16:09:57 +03:00
Vladimir Chebotarev
37bebd1370 Improved BackgroundProcessingPool to use with background moves task. 2019-11-26 16:09:57 +03:00
Vladimir Chebotarev
e96c24786b Separated pool for background moves. 2019-11-26 16:08:59 +03:00
Olga Khvostikova
47e499d71b
Merge pull request #7833 from excitoon-favorites/detachedparts
Added disk info to `system.detached_parts`
2019-11-26 11:56:50 +03:00
Nikolai Kochetov
c97212d132 Remove unused variable. 2019-11-25 16:35:28 +03:00
Nikolai Kochetov
d3118f0a76 Support SAMPLE and FINAL together in MergeTree. 2019-11-25 15:57:14 +03:00
Nikolai Kochetov
9b42e9341d Support SAMPLE and FINAL together in MergeTree. 2019-11-25 15:49:05 +03:00
Nikolai Kochetov
f770934e60 Support SAMPLE and FINAL together in MergeTree. 2019-11-25 15:05:29 +03:00
Nikita Mikhaylov
728ede25f9
Merge pull request #7840 from apbodrov/read_write_gzip
Gzip read/write to file/s3/url/hdfs
2019-11-22 11:48:58 +03:00
tavplubix
b75b6c294d
Merge pull request #7762 from ClickHouse/possible_segfaults_in_table_functions
Fix Storage lifetime in table functions
2019-11-22 02:29:06 +03:00
Nikita Mikhaylov
762d295ab0
Merge pull request #7780 from ClickHouse/aku/parallel-parsing
Merging parallel format parsing
2019-11-22 01:54:47 +03:00
Vladimir Chebotarev
2b4f6af736 Fixed errors with space reservation introduced in #7558 and #7602. 2019-11-21 12:09:43 +03:00
Guillaume Tassery
ebee0ab09a release lock 2019-11-21 09:04:22 +01:00
Andrei Bodrov
decdd7d476 fix typos 2019-11-20 18:40:42 +03:00
Andrei Bodrov
c2849d0864 move to helpers 2019-11-20 17:48:01 +03:00
Guillaume Tassery
8239873605 git push origin move_partitionMerge branch 'master' of github.com:ClickHouse/ClickHouse into move_partition 2019-11-20 05:05:23 +01:00
Alexander Kuzmenkov
7e5731d64e Merge remote-tracking branch 'origin/master' into HEAD 2019-11-19 16:15:47 +03:00
Andrei Bodrov
8cbc52e711 add gzip read/write to file/s3/url/hdfs 2019-11-19 15:46:07 +03:00
Vladimir Chebotarev
5cbbcd9cdb Added disk info to system.detached_parts. 2019-11-19 09:44:10 +03:00
Amos Bird
9af0c00053
Optimize PREWHERE
So that it's never worse than WHERE.
2019-11-18 22:59:03 +08:00
Alexander Tokmakov
2173bf5f4a Merge branch 'master' into possible_segfaults_in_table_functions 2019-11-17 16:48:13 +03:00
Vitaly Baranov
e40c140982 Add the ignorable flag for the settings. 2019-11-17 03:56:18 +03:00
Vitaly Baranov
f3d72b9ec1 Skip unknown settings with warnings. 2019-11-17 03:51:58 +03:00
Vitaly Baranov
ff6cba192b Replace pointer with reference in SettingsCollection<T>::MemberInfos::findStrict().
Rename SettingsCommon.h -> SettingsCollection.h for consistency.
2019-11-17 03:51:51 +03:00
Alexander Tokmakov
55f60a6bad hold shared pointers to table function Storage and Context from InterpreterSelectQuery 2019-11-15 21:42:32 +03:00
Alexander Kuzmenkov
723e02fef7
Merge pull request #7759 from CurtizJ/fix-order-by
Fix order by in case of sorting by primary key prefix and non primary key suffix.
2019-11-15 20:52:31 +03:00
Nikolai Kochetov
431968d69b Processors and dydtem.numbers 2019-11-15 19:23:48 +03:00
Vitaliy Zakaznikov
dbf605c7a4 Attempt to add support for subqueries for the LV. 2019-11-15 15:24:28 +01:00
CurtizJ
475356f2b7 more clarifying names to avoid mistakes 2019-11-15 17:03:42 +03:00
Артем Стрельцов
2a65b4818a Fixed bugs of last non-fictive commit 2019-11-15 11:33:27 +03:00
Артем Стрельцов
5c46a8a7a8 Empty commit to restart tests 2019-11-14 22:36:31 +03:00
Alexander Kuzmenkov
7f34c0089c Merge remote-tracking branch 'origin/master' into HEAD 2019-11-14 18:53:36 +03:00
chertus
8286bbf913 Merge branch 'master' into joins 2019-11-14 16:16:52 +03:00
Guillaume Tassery
5f66a03511 Merge branch 'master' of https://github.com/yandex/ClickHouse into move_partition 2019-11-14 08:07:41 +01:00
Nikolai Kochetov
caad7e636e Use shared_ptr for storage in StorageFileBlockInputStream. 2019-11-13 15:28:14 +03:00
Nikolai Kochetov
943dd12a96 Use shared_ptr for storage in StorageFileBlockInputStream. 2019-11-13 15:17:31 +03:00
Guillaume Tassery
d97034fe4e Merge branch 'master' of https://github.com/yandex/ClickHouse into move_partition 2019-11-12 06:54:50 +01:00
Guillaume Tassery
9da8cbbb77 fix build 2019-11-12 04:34:34 +01:00
Артем Стрельцов
ec636e95cd Added lifetime to system.dictionaries 2019-11-12 00:34:28 +03:00
chertus
8321deefac Merge branch 'master' into joins 2019-11-11 20:54:45 +03:00
alesapin
c74538153f Fix use of destroyed variable captured in lambda 2019-11-11 11:40:00 +03:00
Mikhail Korotov
37a6ccfa49 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into url_engine_problem 2019-11-08 18:29:06 +03:00
robot-clickhouse
94c7719c73 Auto version update to [19.18.1.1] [54429] 2019-11-08 11:36:41 +03:00
millb
7a2dcf451a Merge branch 'master' into url_engine_problem 2019-11-08 02:19:09 +03:00
alexey-milovidov
7f01fd13b3
Merge pull request #7624 from azat/_shard_num
[RFC] Add _shard_num virtual column for the Distributed engine
2019-11-08 00:55:41 +03:00
alexey-milovidov
a2e79cc427
Merge pull request #7574 from ClickHouse/processors-4
Fix tests for processors
2019-11-08 00:46:30 +03:00
chertus
b8d464aa03 new consistent ANY JOIN (LEFT, INNER, RIGHT) 2019-11-08 00:32:44 +03:00
alesapin
18e59f2771 Remove some functions from mutations interpreter 2019-11-07 11:40:36 +03:00
Guillaume Tassery
5994d551a6 rebase from master 2019-11-07 08:38:55 +01:00
Azat Khuzhin
0677ae048c Wrap _shard_num with toUInt32 for simpler JOIN with system.clusters.shard_num 2019-11-06 21:02:42 +03:00
Azat Khuzhin
92bd96fc0d Simplify buildWhereExpression() by using makeASTFunction() helper 2019-11-06 20:37:30 +03:00
alesapin
8c7deaa70d More safier, but still ugly mutations interpreter 2019-11-06 20:28:03 +03:00
Azat Khuzhin
81aeff2d2a Add _shard_num virtual column for the Distributed engine
With JOIN from system.clusters one can figure out from which server data
came.

TODO:
- optimization to avoid communicating with unrelated shards (for queries
  like "AND _shard_num = n")
- fix aliases (see tests with serverError expected)

v0: AddingConstColumnBlockInputStream
v2: VirtualColumnUtils::rewriteEntityInAst
v3: fix remote(Distributed) by appending _shard_num only if has been requested
2019-11-06 15:26:12 +03:00
Alexander Kuzmenkov
233212ac68
Merge pull request #7531 from amosbird/getkeymapped
Unify hash tables interface (separated for review)
2019-11-06 13:49:39 +03:00
alexey-milovidov
687be5f7af
Merge pull request #7618 from excitoon-favorites/looks-like-wrong-copy-paste
Fixed exception in case of using 1 argument while defining S3, URL and HDFS storages
2019-11-06 02:11:38 +03:00
alexey-milovidov
56c89349d3
Merge pull request #7639 from CurtizJ/final_mark_without_primary_key
Fix final mark with empty primary key.
2019-11-05 22:53:52 +03:00
Alexey Milovidov
9ac4e4c7fb Little better #7600 2019-11-05 22:31:07 +03:00
alexey-milovidov
1bfade54c2
Merge pull request #7600 from azat/DirectoryMonitor-current_batch.txt-corruption
Write current batch for distributed send atomically (using .tmp + rename)
2019-11-05 22:24:15 +03:00
CurtizJ
3d968b0259 fix final mark with empty primary key 2019-11-05 20:42:35 +03:00
Nikolai Kochetov
055f21c9b7 Less wrappers for procesors pipeline. 2019-11-05 20:33:03 +03:00
Amos Bird
fbfbe161ec
Unify hash tables interface. 2019-11-06 00:08:04 +08:00
millb
a03f8145bb Created check for HDFS and S3 storages
:
2019-11-05 15:40:49 +03:00
millb
d62cd6efa8 Merge branch 'master' into url_engine_problem 2019-11-05 14:42:53 +03:00
hcz
e0e5e812a7
Allow relative user_files_path 2019-11-05 17:48:49 +08:00
Nikita Mikhaylov
817b52314e Merge branch 'master' of github.com:ClickHouse/ClickHouse into parallel_parsing 2019-11-05 12:32:26 +03:00
Azat Khuzhin
4dfffdd24a Write current batch for distributed send atomically (using .tmp + rename)
Otherwise the following can happen after reboot:

    2019.11.01 11:46:12.217143 [ 187 ] {} <Error> dist.Distributed.DirectoryMonitor: Code: 27, e.displayText() = DB::Exception: Cannot parse input: expected \n before: S\'^A\0^]\0\0<BE>4^A\0r<87>\0\0<A2><D7>^D^Y\0<F2>{^E<CD>\0\0Hy\0\0<F2>^_^C\0^_&\0\0<FF><D3>\0\0
    <8D><91>\0\0<C0>9\0\0<C0><B0>^A\0^G<AA>\0\0<B5><FE>^A\0<BF><A7>^A\0<9B><CB>^A\0I^R^A\0<B7><AB>^A\0<BC><8F>\0\0˲^B\0Zy\0\0<94><AA>\0\0<98>
    <8F>\0\0\f<A5>\0\0^QN\0\0<E3><C6>\0\0<B1>6^B\0ɳ\0\0W<99>\0\0<B9><A2>\0\0:<BB>\0\0)<B1>\0\0#<8B>\0\0aW\0\0<ED>#\0\0<F1>@\0\0ˀ^B\0<D7><FC>\0\0<DF>, Stack trace:

    0. 0x559e27222e60 StackTrace::StackTrace() /usr/bin/clickhouse
    1. 0x559e27222c45 DB::Exception::Exception(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int) /usr/bin/clickhouse
    2. 0x559e26de4473 ? /usr/bin/clickhouse
    3. 0x559e272494b5 DB::assertString(char const*, DB::ReadBuffer&) /usr/bin/clickhouse
    4. 0x559e2a5dab45 DB::StorageDistributedDirectoryMonitor::processFilesWithBatching(std::map<unsigned long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<unsigned long>, std::allocator<std::pair<unsigned long const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&) /usr/bin/clickhouse
    5. 0x559e2a5db5fa DB::StorageDistributedDirectoryMonitor::processFiles() /usr/bin/clickhouse
    6. 0x559e2a5dba78 DB::StorageDistributedDirectoryMonitor::run() /usr/bin/clickhouse
    7. 0x559e2a5ddbbc ThreadFromGlobalPool::ThreadFromGlobalPool<void (DB::StorageDistributedDirectoryMonitor::*)(), DB::StorageDistributedDirectoryMonitor*>(void (DB::StorageDistributedDirectoryMonitor::*&&)(), DB::StorageDistributedDirectoryMonitor*&&)::{lambda()#1}::operator()() const /usr/bin/clickhouse
    8. 0x559e2726b07c ThreadPoolImpl<std::thread>::worker(std::_List_iterator<std::thread>) /usr/bin/clickhouse
    9. 0x559e2bbc3640 ? /usr/bin/clickhouse
    10. 0x7fbd62b3cfb7 start_thread /lib/x86_64-linux-gnu/libpthread-2.29.so
    11. 0x7fbd62a692ef __clone /lib/x86_64-linux-gnu/libc-2.29.so
     (version 19.17.1.1)

v2: remove fsync, to avoid possible stalls (https://github.com/ClickHouse/ClickHouse/pull/7600#discussion_r342010874)
2019-11-05 00:24:38 +03:00
alexey-milovidov
5aceca9e17
Merge pull request #7615 from amosbird/fix21
Global context should be unique.
2019-11-05 00:16:37 +03:00
Vladimir Chebotarev
9869ee141c Fixed exception in case of using 1 argument while defining S3, URL and HDFS storages. 2019-11-04 20:11:50 +03:00
Amos Bird
e2cfc3ecab
Global context should be unique. 2019-11-04 23:43:13 +08:00
alexey-milovidov
b261e6033a
Merge pull request #7602 from excitoon-favorites/cloneAndLoadDataPartOnSameDisk
Made `MergeTreeData::cloneAndLoadDataPart` only work for the same disk.
2019-11-04 14:42:30 +03:00
zhang2014
08894484ee fix cluster system is_local 2019-11-04 10:56:12 +08:00
Vladimir Chebotarev
e76bbfc5ad Made MergeTreeData::cloneAndLoadDataPart only work for the same disk. 2019-11-04 01:27:05 +03:00
alexey-milovidov
15c4a19bb1
Merge pull request #7585 from ernestp/macos_catalina_2019_11_01
Fixed compile errors on macOS Catalina
2019-11-02 15:46:17 +03:00
alexey-milovidov
6e4d63e394
Merge pull request #7575 from Alex-Burmak/escaping_fix
Fixed missing file name escaping in FREEZE command
2019-11-02 13:20:28 +03:00
alexey-milovidov
ad01f7b1ac
Merge pull request #7552 from azat/do-not-account-memory-for-Buffer-in-max_memory_usage
[RFC] Do not account memory for Buffer engine in max_memory_usage limit
2019-11-02 00:57:24 +03:00
alexey-milovidov
dda93e2275
Merge pull request #7561 from ClickHouse/achimbab-master
Merge for #7363
2019-11-02 00:57:13 +03:00
Ernest Poletaev
de1e5d0e53 Fixed compile errors on macOS Catalina 2019-11-01 23:33:43 +07:00
Nikolai Kochetov
239d92a94c Code cleanup. 2019-11-01 18:31:02 +03:00
alexey-milovidov
4081b0be90
Merge pull request #7497 from amosbird/countopt
Early constant folding.
2019-11-01 16:54:02 +03:00
Alexander Burmak
9b8fc9a899 Fixed missing file name escaping in FREEZE command 2019-11-01 16:17:08 +03:00
Ivan
21db9157f7
Don't initialize some constant blocks in a loop (#7475) 2019-11-01 14:34:29 +03:00
Nikolai Kochetov
388bbb950b Add flag to set that set is created. 2019-11-01 14:03:35 +03:00
Nikolai Kochetov
1f7a798c97 Add flag to set that set is created. 2019-11-01 13:58:29 +03:00
alesapin
6ef0a92535
Merge pull request #7558 from excitoon/patch-1
Made mutation to choose the same disk in `ReplicatedMergeTree`.
2019-11-01 13:52:45 +03:00
Nikolai Kochetov
d31cac33b2 Small fixes. 2019-11-01 12:41:20 +03:00
Nikolai Kochetov
5bb47e2484
Merge pull request #7181 from ClickHouse/processors-and-storages
Processors and storages
2019-11-01 12:04:49 +03:00
Azat Khuzhin
dbe45800d9 Do not account memory for Buffer engine in max_memory_usage limit
Since background flush will not be accounted there, and it can be too
tricky to calclulate this limit, in case you have multiple materialized
views with Buffer engine.

v2: test adjustment
2019-10-31 22:26:50 +03:00
Nikolai Kochetov
9a5a0a2a3b Fix types for set elements. 2019-10-31 19:14:06 +03:00
Vitaly Baranov
56011d4649
Merge pull request #7553 from vitlibar/add-constraints-columns-to-table-system-settings
Add constraints columns to table system.settings
2019-10-31 19:06:46 +03:00
Amos Bird
e04cdd4ebb
Early constant folding. 2019-10-31 23:54:32 +08:00
Vladimir Chebotarev
faf1b070ac
Typo was fixed. 2019-10-31 16:26:11 +03:00
Vladimir Chebotarev
0dea6f5458
Added comment for selecting disk for mutation. 2019-10-31 16:19:38 +03:00
Nikolai Kochetov
be1ccaa890 Fix clang build. 2019-10-31 16:18:21 +03:00
Vladimir Chebotarev
f44cee623a
Made mutation to choose the same disk in ReplicatedMergeTree. 2019-10-31 15:22:25 +03:00
Nikolai Kochetov
18378417df Fix build. 2019-10-31 14:48:35 +03:00
Nikolai Kochetov
a80338e066 Merged with master 2019-10-31 14:41:29 +03:00
Nikolai Kochetov
a38124c68e Review fixes. 2019-10-31 14:32:24 +03:00
Vitaly Baranov
5601d6ae66 Add constraints columns to table system.settings 2019-10-31 01:45:57 +03:00
alexey-milovidov
88d43488e1
Merge pull request #7412 from 4ertus2/strange
merge_max_block_size in settings
2019-10-31 00:24:43 +03:00
alexey-milovidov
bb75c7469a
Merge pull request #7545 from ClickHouse/fix_only_tuple_columns
Fix only tuple columns in table.
2019-10-30 23:34:23 +03:00
alesapin
e2424bda4c Fix style 2019-10-30 19:00:40 +03:00
alesapin
2b5ef8bdef Fix bug when table contains only tuple columns 2019-10-30 17:50:59 +03:00
Amos Bird
2c75a51d4f
Instant count() for MergeTree
Use (Replicated)MergeTree's metadata to do trivial count()
2019-10-29 17:45:47 +08:00
Nikita Mikhaylov
756a10707d Merge branch 'master' of github.com:ClickHouse/ClickHouse into parallel_parsing 2019-10-28 13:51:52 +03:00
alesapin
04ca163518 Merge branch 'master' into dictionaries_ddl_loader 2019-10-25 10:58:04 +03:00
alesapin
5d8d1df802
Merge pull request #7434 from excitoon-favorites/fix-7424
Allowed to have some parts on destination disk or volume in MOVE PARTITION
2019-10-24 19:45:22 +03:00
Artem Zuikov
39b64dff87
Merge pull request #7454 from 4ertus2/refactoring
Refactoring: extract non aliases logic out of QueryNormalizer
2019-10-24 14:34:53 +03:00
Vladimir Chebotarev
64f158ff28 Fixed message for ALTER MOVE PART. 2019-10-24 13:56:32 +03:00
Alexander Kuzmenkov
29052b6a37
Merge pull request #7377 from azat/INSERT-Distributed-MATERIALIZED-cols
* Fix INSERT into Distributed non local node with MATERIALIZED columns

Previous patch e527def18a ("Fix INSERT
into Distributed() table with MATERIALIZED column") fixes it only for
cases when the node is local, i.e. direct insert.

This patch address the problem when the node is not local
(`is_local == false`), by erasing materialized columns on INSERT into
Distributed.

And this patch fixes two cases, depends on `insert_distributed_sync`
setting:

- `insert_distributed_sync=0`

    ```
    Not found column value in block. There are only columns: date. Stack trace:

    2. 0x7ffff7be92e0 DB::Exception::Exception() dbms/src/Common/Exception.h:27
    3. 0x7fffec5d6cf6 DB::Block::getByName(...) dbms/src/Core/Block.cpp:187
    4. 0x7fffec2fe067 DB::NativeBlockInputStream::readImpl() dbms/src/DataStreams/NativeBlockInputStream.cpp:159
    5. 0x7fffec2d223f DB::IBlockInputStream::read() dbms/src/DataStreams/IBlockInputStream.cpp:61
    6. 0x7ffff7c6d40d DB::TCPHandler::receiveData() dbms/programs/server/TCPHandler.cpp:971
    7. 0x7ffff7c6cc1d DB::TCPHandler::receivePacket() dbms/programs/server/TCPHandler.cpp:855
    8. 0x7ffff7c6a1ef DB::TCPHandler::readDataNext(unsigned long const&, int const&) dbms/programs/server/TCPHandler.cpp:406
    9. 0x7ffff7c6a41b DB::TCPHandler::readData(DB::Settings const&) dbms/programs/server/TCPHandler.cpp:437
    10. 0x7ffff7c6a5d9 DB::TCPHandler::processInsertQuery(DB::Settings const&) dbms/programs/server/TCPHandler.cpp:464
    11. 0x7ffff7c687b5 DB::TCPHandler::runImpl() dbms/programs/server/TCPHandler.cpp:257
    ```

- `insert_distributed_sync=1`

    ```
    2019.10.18 13:23:22.114578 [ 44 ] {a78f669f-0b08-4337-abf8-d31e958f6d12} <Error> executeQuery: Code: 171, e.displayText() = DB::Exception: Block structure mismatch in RemoteBlockOutputStream stream: different number of columns:
    date Date UInt16(size = 1), value Date UInt16(size = 1)
    date Date UInt16(size = 0): Insertion status:
    Wrote 1 blocks and 0 rows on shard 0 replica 0, 127.0.0.1:59000 (average 0 ms per block)
    Wrote 0 blocks and 0 rows on shard 1 replica 0, 127.0.0.2:59000 (average 2 ms per block)
     (version 19.16.1.1) (from [::1]:3624) (in query: INSERT INTO distributed_00952 VALUES ), Stack trace:

    2. 0x7ffff7be92e0 DB::Exception::Exception() dbms/src/Common/Exception.h:27
    3. 0x7fffec5da4e9 DB::checkBlockStructure<void>(...)::{...}::operator()(...) const dbms/src/Core/Block.cpp:460
    4. 0x7fffec5da671 void DB::checkBlockStructure<void>(...) dbms/src/Core/Block.cpp:467
    5. 0x7fffec5d8d58 DB::assertBlocksHaveEqualStructure(...) dbms/src/Core/Block.cpp:515
    6. 0x7fffec326630 DB::RemoteBlockOutputStream::write(DB::Block const&) dbms/src/DataStreams/RemoteBlockOutputStream.cpp:68
    7. 0x7fffe98bd154 DB::DistributedBlockOutputStream::runWritingJob(DB::DistributedBlockOutputStream::JobReplica&, DB::Block const&)::{lambda()#1}::operator()() const dbms/src/Storages/Distributed/DistributedBlockOutputStream.cpp:280
    <snip>
    ````

Fixes: #7365
Fixes: #5429
Refs: #6891

* Cover INSERT into Distributed with MATERIALIZED columns and !is_local node

I guess that adding new cluster into server-test.xml is not required,
but it won't harm.

* Update DistributedBlockOutputStream.cpp
2019-10-24 12:35:09 +03:00
Alexander Kuzmenkov
050de71ef4
Update DistributedBlockOutputStream.cpp 2019-10-24 12:33:45 +03:00
alesapin
a6199b7e69 Merge with master 2019-10-24 12:33:40 +03:00
Vladimir Chebotarev
255da8f5e0 Fixed style. 2019-10-24 12:11:06 +03:00
Vladimir Chebotarev
3debdc2119 Added integration tests for ALTER MOVE PARTITION and fixed minor things. 2019-10-24 11:52:33 +03:00
chertus
9818eada69 rename: merge_max_block_size 2019-10-24 02:18:21 +03:00
Azat Khuzhin
ab9d9f8997 Fix INSERT into Distributed non local node with MATERIALIZED columns
Previous patch e527def18a ("Fix INSERT
into Distributed() table with MATERIALIZED column") fixes it only for
cases when the node is local, i.e. direct insert.

This patch address the problem when the node is not local
(`is_local == false`), by erasing materialized columns on INSERT into
Distributed.

And this patch fixes two cases, depends on `insert_distributed_sync`
setting:

- `insert_distributed_sync=0`

    ```
    Not found column value in block. There are only columns: date. Stack trace:

    2. 0x7ffff7be92e0 DB::Exception::Exception() dbms/src/Common/Exception.h:27
    3. 0x7fffec5d6cf6 DB::Block::getByName(...) dbms/src/Core/Block.cpp:187
    4. 0x7fffec2fe067 DB::NativeBlockInputStream::readImpl() dbms/src/DataStreams/NativeBlockInputStream.cpp:159
    5. 0x7fffec2d223f DB::IBlockInputStream::read() dbms/src/DataStreams/IBlockInputStream.cpp:61
    6. 0x7ffff7c6d40d DB::TCPHandler::receiveData() dbms/programs/server/TCPHandler.cpp:971
    7. 0x7ffff7c6cc1d DB::TCPHandler::receivePacket() dbms/programs/server/TCPHandler.cpp:855
    8. 0x7ffff7c6a1ef DB::TCPHandler::readDataNext(unsigned long const&, int const&) dbms/programs/server/TCPHandler.cpp:406
    9. 0x7ffff7c6a41b DB::TCPHandler::readData(DB::Settings const&) dbms/programs/server/TCPHandler.cpp:437
    10. 0x7ffff7c6a5d9 DB::TCPHandler::processInsertQuery(DB::Settings const&) dbms/programs/server/TCPHandler.cpp:464
    11. 0x7ffff7c687b5 DB::TCPHandler::runImpl() dbms/programs/server/TCPHandler.cpp:257
    ```

- `insert_distributed_sync=1`

    ```
    2019.10.18 13:23:22.114578 [ 44 ] {a78f669f-0b08-4337-abf8-d31e958f6d12} <Error> executeQuery: Code: 171, e.displayText() = DB::Exception: Block structure mismatch in RemoteBlockOutputStream stream: different number of columns:
    date Date UInt16(size = 1), value Date UInt16(size = 1)
    date Date UInt16(size = 0): Insertion status:
    Wrote 1 blocks and 0 rows on shard 0 replica 0, 127.0.0.1:59000 (average 0 ms per block)
    Wrote 0 blocks and 0 rows on shard 1 replica 0, 127.0.0.2:59000 (average 2 ms per block)
     (version 19.16.1.1) (from [::1]:3624) (in query: INSERT INTO distributed_00952 VALUES ), Stack trace:

    2. 0x7ffff7be92e0 DB::Exception::Exception() dbms/src/Common/Exception.h:27
    3. 0x7fffec5da4e9 DB::checkBlockStructure<void>(...)::{...}::operator()(...) const dbms/src/Core/Block.cpp:460
    4. 0x7fffec5da671 void DB::checkBlockStructure<void>(...) dbms/src/Core/Block.cpp:467
    5. 0x7fffec5d8d58 DB::assertBlocksHaveEqualStructure(...) dbms/src/Core/Block.cpp:515
    6. 0x7fffec326630 DB::RemoteBlockOutputStream::write(DB::Block const&) dbms/src/DataStreams/RemoteBlockOutputStream.cpp:68
    7. 0x7fffe98bd154 DB::DistributedBlockOutputStream::runWritingJob(DB::DistributedBlockOutputStream::JobReplica&, DB::Block const&)::{lambda()#1}::operator()() const dbms/src/Storages/Distributed/DistributedBlockOutputStream.cpp:280
    <snip>
    ````

Fixes: #7365
Fixes: #5429
Refs: #6891
2019-10-23 21:54:27 +03:00
chertus
20093fa065 extract more logic out of QueryNormalizer 2019-10-23 16:59:03 +03:00