Commit Graph

112566 Commits

Author SHA1 Message Date
Yakov Olkhovskiy
e6d96c27f2 unnecessary include 2023-04-10 19:16:02 +00:00
Yakov Olkhovskiy
a6c99e8e84 add IPv4 to supertype calculation 2023-04-10 18:59:50 +00:00
Azat Khuzhin
7cd4009c3d Fix flakiness of test_store_cleanup in case of image rebuild
The log level will be substituted from "test" to "trace" in case of the
tag is not "latest", the assumption behind this I guess is that it
should not try to use "test" log level for older versions.

But, it could have per-PR image in case of changes in the Dockerfile, so
it is better to check for self.with_installed_binary, since actually any
parameters except this will use new clickhouse binary anyway.

CI: https://s3.amazonaws.com/clickhouse-test-reports/48596/a1272e8536265929255fdf5020836f057859e425/integration_tests__tsan__[1/6].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-10 20:31:06 +02:00
Alexey Milovidov
51688bb771
Merge pull request #48578 from ClickHouse/slightly-optimize-install
Slightly optimize Install
2023-04-10 21:17:27 +03:00
robot-ch-test-poll1
88516a4558
Merge pull request #48600 from ClickHouse/evillique-patch-3
Docs: Add SETTINGS to executable table function
2023-04-10 19:59:27 +02:00
Alexey Milovidov
438cd4af09
Merge pull request #48579 from ClickHouse/kerberos-fix-tsan
Fix TSan report in Kerberos
2023-04-10 20:58:50 +03:00
Azat Khuzhin
013a3ed269 Fix possible lock order inversion in Context::setTemporaryStorageInCache()
TSan report [1]:

    WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid=1)
      Cycle in lock order graph: M0 (0x7b9000000008) => M1 (0x7b90000000a8) => M0

      Mutex M1 acquired here while holding mutex M0 in main thread:
        0 pthread_mutex_lock <null> (clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        3 std::__1::lock_guard<std::__1::mutex>::lock_guard[abi:v15000](std::__1::mutex&) build_docker/./contrib/llvm-project/libcxx/include/__mutex_base:94:27 (clickhouse+0x1d0ccb3a) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        4 DB::Context::getDisk() const build_docker/./src/Interpreters/Context.cpp:3281:21 (clickhouse+0x1d0ccb3a)
        5 DB::Context::setTemporaryStorageInCache() build_docker/./src/Interpreters/Context.cpp:927:21 (clickhouse+0x1d0cc188) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        6 DB::Server::main() build_docker/./programs/server/Server.cpp:1055:25 (clickhouse+0x148504c2) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)

      Mutex M0 previously acquired by the same thread here:
        0 pthread_mutex_lock <null> (clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        3 std::__1::unique_lock<std::__1::recursive_mutex>::unique_lock[abi:v15000](std::__1::recursive_mutex&) build_docker/./contrib/llvm-project/libcxx/include/__mutex_base:122:61 (clickhouse+0x1d0cc148) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        4 DB::Context::getLock() const build_docker/./src/Interpreters/Context.cpp:690:12 (clickhouse+0x1d0cc148)
        5 DB::Context::setTemporaryStorageInCache() build_docker/./src/Interpreters/Context.cpp:922:17 (clickhouse+0x1d0cc148)
        6 DB::Server::main() build_docker/./programs/server/Server.cpp:1055:25 (clickhouse+0x148504c2) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)

      Muex M0 acquired here while holding mutex M1 in main thread:
        0 pthread_mutex_lock <null> (clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        3 std::__1::unique_lock<std::__1::recursive_mutex>::unique_lock[abi:v15000](std::__1::recursive_mutex&) build_docker/./contrib/llvm-project/libcxx/include/__mutex_base:122:61 (clickhouse+0x1d0c7ce1) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        4 DB::Context::getLock() const build_docker/./src/Interpreters/Context.cpp:690:12 (clickhouse+0x1d0c7ce1)
        5 DB::Context::getPath() const build_docker/./src/Interpreters/Context.cpp:713:17 (clickhouse+0x1d0c7ce1)
        6 DB::loadDiskLocalConfig() build_docker/./src/Disks/DiskLocal.cpp:75:30 (clickhouse+0x1ce7ed8a) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        7 DB::DiskLocal::applyNewSettings() build_docker/./src/Disks/DiskLocal.cpp:491:5 (clickhouse+0x1ce7e7ef) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        8 DB::DiskSelector::updateFromConfig() const build_docker/./src/Disks/DiskSelector.cpp:92:19 (clickhouse+0x1d14088e) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        9 DB::Context::updateStorageConfiguration() build_docker/./src/Interpreters/Context.cpp:3388:49 (clickhouse+0x1d0ec002) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        ..
        17 DB::ConfigReloader::reloadIfNewer() build_docker/./src/Common/Config/ConfigReloader.cpp:149:13 (clickhouse+0x1fff4250)

      Mutex M1 previously acquired by the same thread here:
        0 pthread_mutex_lock <null> (clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        3 std::__1::lock_guard<std::__1::mutex>::lock_guard[abi:v15000](std::__1::mutex&) build_docker/./contrib/llvm-project/libcxx/include/__mutex_base:94:27 (clickhouse+0x1d0ebf25) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280)
        4 DB::Context::updateStorageConfiguration() build_docker/./src/Interpreters/Context.cpp:3384:21 (clickhouse+0x1d0ebf25)
        ..
        12 DB::ConfigReloader::reloadIfNewer() build_docker/./src/Common/Config/ConfigReloader.cpp:149:13 (clickhouse+0x1fff4250)

    SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock) (/usr/bin/clickhouse+0xc66a8da) (BuildId: 174c9c4bf3606a5fc390211bdc2feff052246280) in pthread_mutex_lock
    ==================

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/48596/a1272e8536265929255fdf5020836f057859e425/integration_tests__tsan__[6/6].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-10 19:56:52 +02:00
Nikolai Kochetov
ba468eac45
Merge pull request #48485 from ClickHouse/read-step-for-system-zookeeper
Add reading step for system zookeeper. Analyze path from filter DAG.
2023-04-10 19:28:18 +02:00
Sergei Trifonov
cc5a4c3853
Merge pull request #48568 from ClickHouse/serxa-patch-3
Update formats.md
2023-04-10 19:07:08 +02:00
robot-ch-test-poll4
5776ce6110
Merge pull request #48608 from ClickHouse/thomoco-patch-3
Update formats.md
2023-04-10 18:58:05 +02:00
Kseniia Sumarokova
65259d964b
Merge pull request #48167 from lzydmxy/add_columns_for_system_storage_policies
Add columns for table `system.storage_policies`
2023-04-10 18:32:13 +02:00
Igor Nikonov
e3b5072eb8
Merge pull request #48525 from ClickHouse/parallel-reading-from-file
Parallel processing right after reading `FROM file()`
2023-04-10 18:30:05 +02:00
Thom O'Connor
8b0adf58e5
Update formats.md
Including an Avro example with DESCRIBE url in S3
2023-04-10 10:17:43 -06:00
Azat Khuzhin
79b83c4fd2 Remove superfluous includes of logger_userful.h from headers
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-10 17:59:30 +02:00
lzydmxy
6015c3be56 update Failed test 2023-04-10 23:53:32 +08:00
Dale Mcdiarmid
d50c6a9e1b update blog references 2023-04-10 15:23:00 +01:00
Nikolay Degterinsky
450e820728
Docs: Add SETTINGS to executable table function 2023-04-10 16:18:48 +02:00
Azat Khuzhin
a1272e8536 Pass existing TSAN_OPTIONS to integration tests and append new options
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-10 15:17:43 +02:00
FriendLey
2a0de4bc16
Update src/Functions/soundex.cpp
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
2023-04-10 21:14:49 +08:00
Azat Khuzhin
bbee1a36be Add a comment for use_sigaltstack=0 ASan option
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-10 15:06:40 +02:00
Azat Khuzhin
61bf70be12 Add second_deadlock_stack=1 for TSan on CI
To improve TSan reports.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-10 15:05:57 +02:00
FriendLey
a67ea35875 format code and replace std function with Common utils. 2023-04-10 19:12:17 +08:00
Nikolai Kochetov
d564fe4e64 Fixing build 2023-04-10 10:54:37 +00:00
Nikolai Kochetov
28484cd762
Merge pull request #48522 from ClickHouse/many-mutations-memory-limit
Reduce memory usage for multiple alter delete mutations.
2023-04-10 12:50:42 +02:00
Aleksei Filatov
e8bf96d126 Add unit tests 2023-04-10 13:02:43 +03:00
Aleksei Filatov
000c2b5b91 Correct FixupACL for auth scheme 2023-04-10 13:02:31 +03:00
FriendLey
9d5fc02c5e update code style. 2023-04-10 17:22:15 +08:00
FriendLey
890d4655a0 update code styl. 2023-04-10 17:06:31 +08:00
Raúl Marín
45ad555c39
Merge branch 'master' into zk_retry_timeout 2023-04-10 10:04:16 +02:00
Nikolay Degterinsky
8524f6958a
Update src/Interpreters/ReplaceQueryParameterVisitor.cpp
Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
2023-04-10 09:09:57 +02:00
Alexey Milovidov
c279516ac1
Merge branch 'master' into parallel-reading-from-file 2023-04-10 08:02:50 +03:00
Alexey Milovidov
a7db8d1d71
Merge pull request #48569 from awfeequdng/bugfix/wide_integer
bugfix: compare Bits and sizeof(Arithmetic) * 8
2023-04-10 07:25:51 +03:00
Alexey Milovidov
3678f7b4bd
Merge pull request #48572 from ClickHouse/update-cctz-4
Update CCTZ
2023-04-10 07:24:57 +03:00
Alexey Milovidov
dee2262183
Merge pull request #48574 from ClickHouse/fix-slow-test
Remove slow test from debug builds
2023-04-10 07:24:26 +03:00
Nikolay Degterinsky
9df64f0ca7
Merge branch 'master' into evillique-patch-1 2023-04-10 04:31:01 +02:00
Alexey Milovidov
6738ab6660 Fix TSan report in Kerberos 2023-04-10 04:22:17 +02:00
Alexey Milovidov
345b33dc1f Slightly optimize Install 2023-04-10 04:15:13 +02:00
Nikolay Degterinsky
e71c7fe744
Fix 2023-04-10 03:48:58 +02:00
Nikolay Degterinsky
6b1c86c6ec
Don't use type conversion with String query parameters 2023-04-10 03:39:13 +02:00
Alexey Milovidov
8e90b7d446 Fixup 2023-04-10 03:31:53 +02:00
Nikolay Degterinsky
8eaf20e129
Update syntax.md 2023-04-10 03:26:43 +02:00
Nikolay Degterinsky
a24cc9580c
Update syntax.md 2023-04-10 03:11:10 +02:00
Alexey Milovidov
dddca7d9a4
Merge pull request #48563 from ClickHouse/server-uuid-macro
Add support for `{server_uuid}` macro
2023-04-10 03:40:47 +03:00
Alexey Milovidov
1f6b9809dd Better exception messages for unparsed Bool 2023-04-10 02:32:04 +02:00
Alexey Milovidov
5cb00e13c3 Add a test 2023-04-10 02:31:49 +02:00
Igor Nikonov
e1fa279c98 Fix tests for flaky check 2023-04-09 23:40:32 +00:00
robot-ch-test-poll1
0de5ab140d
Merge pull request #48573 from den-crane/patch-64
Doc. Better translation of deltaSumTimestamp / more clear description
2023-04-10 01:29:42 +02:00
Alexey Milovidov
c06a5ab85f Remove slow test from debug builds 2023-04-10 01:04:23 +02:00
Denny Crane
36871fad34
Update deltasumtimestamp.md 2023-04-09 19:38:08 -03:00
Denny Crane
028a21658d
Update deltasumtimestamp.md 2023-04-09 19:34:10 -03:00