Commit Graph

2445 Commits

Author SHA1 Message Date
alexey-milovidov
5335b589f9 Revert "Generic constructor of ColumnVector from initializer list (#9393)"
This reverts commit 6691302e4f.
2020-02-28 22:14:13 +03:00
Alexey Milovidov
cf7b4a12f1 Chaos Sanitizer: experiment 2020-02-28 21:12:52 +03:00
Nikita Mikhaylov
56d3cd535d
Merge pull request #9413 from nikitamikhaylov/cache_dict_update_queue_size
CacheDictionaryUpdateQueueSize metric added
2020-02-28 20:29:11 +03:00
Vitaly Baranov
2408c8cf57 Implement persistent storage for access entities. 2020-02-28 16:34:19 +03:00
Vitaly Baranov
2846567bf1 Add function IAccessStorage::canInsert(): now access storage can decide if it can take a new entity. 2020-02-28 16:34:19 +03:00
alexey-milovidov
6691302e4f
Generic constructor of ColumnVector from initializer list (#9393)
* Generic constructor of ColumnVector from initializer list #9367

* Fixed build

* Fixed error
2020-02-28 15:57:04 +03:00
Nikita Mikhaylov
e06432af60
CacheDictionary datarace on exception_ptr (#9379)
* datarace on exceptionptr fixed

* better

* monkey test added

* comment to test added

* add new line to reference file

* bump tests

* q
2020-02-28 15:34:39 +03:00
Nikita Mikhaylov
aaffe31613 split metric 2020-02-28 13:53:59 +03:00
Nikita Mikhaylov
6d583ff66e first 2020-02-27 15:22:23 +03:00
alexey-milovidov
25e26f0029
Merge pull request #9370 from ClickHouse/errorcodes-style
Ensure style of ErrorCodes by style check.
2020-02-26 23:10:19 +03:00
alexey-milovidov
ab0bb7a48e
Merge pull request #9367 from huiwangcs/cow_sof
fix stack overflow issue when using initializer_list
2020-02-26 21:45:01 +03:00
Alexey Milovidov
8f90c6ec12 Fixed ErrorCodes, part 3 2020-02-25 21:20:08 +03:00
Alexey Milovidov
cb6cd2ffbb Added missing ErrorCodes, part 2 2020-02-25 21:10:48 +03:00
Alexey Milovidov
766ae8261a Added some missing ErrorCodes 2020-02-25 21:02:41 +03:00
Hui Wang
7be4e3c89a fix stack overflow issue when using initializer_list 2020-02-25 16:22:35 +01:00
Alexey Milovidov
3602126a1e Remove unused ErrorCodes 2020-02-25 17:35:37 +03:00
alesapin
451bace1d5 Merge with master 2020-02-25 11:53:14 +03:00
Alexey Milovidov
cdceae856f Fixed ASan report in extractAll function 2020-02-24 21:52:03 +03:00
Alexey Milovidov
16ae06c8dd Fixed ASan report in extractAll function 2020-02-24 21:49:38 +03:00
alexey-milovidov
d0fea62079
Merge pull request #8290 from CurtizJ/polymorphic-parts
Polymorphic parts (compact format).
2020-02-23 04:01:07 +03:00
Anton Popov
b736029828
Update ErrorCodes.cpp 2020-02-22 22:11:44 +03:00
alexey-milovidov
1950923433
Merge branch 'master' into polymorphic-parts 2020-02-22 20:56:27 +03:00
Amos Bird
693cf211fa
Build fix 2020-02-22 16:44:23 +08:00
Amos Bird
f5d6043a5d
Strict aliasing in c++20 2020-02-22 13:46:35 +08:00
Alexey Milovidov
c3e80485da
More strict aliasing 2020-02-22 10:19:39 +08:00
Alexey Milovidov
5cf3414b8a
More strict aliasing 2020-02-22 10:17:52 +08:00
Vitaly Baranov
c1e870d493
Merge pull request #9182 from vitlibar/RBAC-5.2
RBAC-5.2
2020-02-22 03:55:17 +03:00
Alexey Milovidov
396e9c57d0 Fixed OptimizedRegularExpression in case of empty regexp 2020-02-21 18:55:36 +03:00
alexey-milovidov
abe8315861
Merge pull request #9258 from Jokser/disk-s3-read-write-buffers-refactoring
Disk->writeFile() returns WriteBufferFromFileBase.
2020-02-21 17:28:49 +03:00
Vitaly Baranov
e017bacc48 Implement SQL queries for creating and controlling roles. 2020-02-21 06:03:09 +03:00
Vitaly Baranov
ae18d443c8 Introduce roles. 2020-02-21 06:03:03 +03:00
alexey-milovidov
0f72781b1e
Trigger CI 2020-02-21 02:02:52 +03:00
alexey-milovidov
d1e26f5b35
Merge pull request #9163 from ClickHouse/match-zero-byte-fix
Fixed `match` and `extract` when haystack has zero bytes.
2020-02-21 02:01:50 +03:00
alexey-milovidov
219f94ca97
Merge pull request #9082 from 4ertus2/joins
Switch JOIN algo on the fly
2020-02-21 02:01:23 +03:00
Alexey Milovidov
2c8a6a2885 Fixed bad code 2020-02-20 22:38:18 +03:00
alesapin
f06bcee7bc Merge with master 2020-02-20 22:36:36 +03:00
Alexey Milovidov
d87e25aeab Merge branch 'master' of github.com:yandex/ClickHouse into match-zero-byte-fix 2020-02-20 21:52:50 +03:00
alexey-milovidov
5c097f842f
Merge pull request #9247 from ClickHouse/aku/logical-error-message
Log error message before aborting on LOGICAL_ERROR.
2020-02-20 21:45:01 +03:00
Pavel Kovalenko
e5b81aefe3 WriteBufferFromFileBase interface refactoring.
Disk->writeFile() returns WriteBufferFromFileBase.
DiskMemory read/write buffers refactoring.
2020-02-20 19:39:32 +03:00
CurtizJ
3f7f13ce05 Merge remote-tracking branch 'upstream/master' into polymorphic-parts 2020-02-20 15:36:55 +03:00
Alexander Kuzmenkov
642e21e8e1 Log error message before aborting on LOGICAL_ERROR. 2020-02-20 15:29:53 +03:00
alexey-milovidov
eceabbfc3f
Merge pull request #9221 from nvartolomei/nv/advertise-a-stack-trace-will-follow
Improve stack trace formatting for Poco and std exceptions
2020-02-20 12:59:58 +03:00
Nicolae Vartolomei
811197558c Improve stack trace formatting for Poco and std exceptions
Before:

```
<Error> Application: Caught exception while loading metadata: Poco::Exception. Code: 1000, e.code() = 0, e.displayText() = Access to file denied: boo0. /home/nv/clickhouse-master-clion/contrib/poco/Foundation/src/Exception.cpp:27: Poco::FileAccessDeniedException::FileAccessDeniedException(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0xbb598cc in /state/home/nv/clickhouse-builds/clickhouse-master-clion-gcc/dbms/programs/clickhous
```

After:

```
<Error> Application: Caught exception while loading metadata: Poco::Exception. Code: 1000, e.code() = 0, e.displayText() = Access to file denied: boo, Stack trace (when copying this message, always include the lines below):

0. /home/nv/clickhouse-master-clion/contrib/poco/Foundation/src/Exception.cpp:27: Poco::FileAccessDeniedException::FileAccessDeniedException(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0xbb5987c in /state/home/nv/clickhouse-builds/clickhouse-master-clion-gcc/dbms/programs/clickhous
```
2020-02-19 13:33:31 +00:00
chertus
48ac7d35ae Merge branch 'master' into joins 2020-02-19 14:21:40 +03:00
alexey-milovidov
77f9a358ff
Update ProfileEvents.cpp 2020-02-19 11:55:29 +03:00
alexey-milovidov
e90124dc24
Update ProfileEvents.cpp 2020-02-19 11:54:23 +03:00
Mikhail f. Shiryaev
fdc00e3562
Add description for some profiling events 2020-02-19 09:50:58 +01:00
chertus
74a5227ac4 add join_algorithm setting 2020-02-18 20:31:22 +03:00
alesapin
b3fe0b51a1 Merge branch 'master' into alter_on_top_of_mutations 2020-02-18 14:32:12 +03:00
alexey-milovidov
b688fc5895
Merge pull request #9174 from azat/O_CLOEXEC
[RFC] Set O_CLOEXEC
2020-02-18 12:50:19 +03:00
Azat Khuzhin
aa252e48b8 Set O_CLOEXEC
Since clickhouse allows to execute user-specified command (i.e.
for dictionary loading), it is better not to expose them.

But there is something left for now:
- 10 -> socket:[14422712]
- 11 -> socket:[14422714]
- 12 -> anon_inode:[eventpoll]
- 13 -> anon_inode:[eventpoll]
- 14 -> anon_inode:[eventpoll]
- 15 -> socket:[14426310]
- 16 -> anon_inode:[eventpoll]
- 3 -> /proc/2739071/fd
- 6 -> socket:[14422708]
- 9 -> socket:[14422710]

And most of these (eventpoll) went from poco, for which O_CLOEXEC cannot
be passed.
2020-02-18 00:28:11 +03:00
Alexey Milovidov
a1ccd14032 Fixed error with zero bytes in haystack for constant case #9160 2020-02-17 21:53:59 +03:00
Ivan Lezhankin
102dad0ca0 Merge branch 'master' into arcadia 2020-02-17 17:37:10 +03:00
Ivan Lezhankin
39ea079034 More clean-up 2020-02-17 17:27:09 +03:00
alesapin
7d7fdb389d Remove redundant error code 2020-02-17 16:37:16 +03:00
Alexey Milovidov
07479236d7 Implement #9137 2020-02-15 03:11:09 +03:00
Alexander Kuzmenkov
51815044c5
Merge pull request #8943 from ClickHouse/aku/flush-perf
[wip] Improve flush performance in SystemLog
2020-02-14 22:41:44 +03:00
CurtizJ
ddb3a55f67 Merge remote-tracking branch 'upstream/master' into polymorphic-parts 2020-02-14 13:15:16 +03:00
alesapin
78d42142cf Better 2020-02-13 19:16:09 +03:00
alesapin
8c160c7905 Better 2020-02-13 17:48:38 +03:00
alexey-milovidov
dcc6fbb7a6
Fixed idiotic translation. 2020-02-13 17:25:17 +03:00
Ivan
bef233f450
Add simple memory profiler (#8765)
* Add new trace type to system.trace_log table

* [WIP]

* Add settings for soft limit raising.

* Remove unused diff

* Remove unused diff

* Some renames

* Fix client hanging on quit

* Remove obsolete pointer for trace collector in context.

* Use memory tracker on query level.

* Fix TSan tests

* Try to simplify TraceCollector initialization.

It allows to workaround first call inside signal handler

* Initialize TraceCollector before setting signal handlers

* Attempt to fix

* Fix Int64 → UInt64 for |size|

* Explicitly reset global TraceCollector instance.
2020-02-12 15:37:40 +03:00
Ivan Lezhankin
5644fa8c41 Explicitly reset global TraceCollector instance. 2020-02-11 18:16:53 +03:00
Ivan Lezhankin
cc63739837 Fix Int64 → UInt64 for |size| 2020-02-10 18:24:26 +03:00
Alexander Kuzmenkov
dae3811e25
Merge pull request #9015 from Slach/master
Track the number of MySQL connections
2020-02-09 17:01:01 +03:00
Alexander Kuzmenkov
ae0044efe8
Update ConfigProcessor.cpp 2020-02-07 22:37:24 +03:00
Alexander Kuzmenkov
b125e6b393 Log which configuration files we loaded. 2020-02-07 22:32:49 +03:00
Ivan Lezhankin
abb1220cb3 Merge branch 'master' into memory-profiler 2020-02-07 18:16:41 +03:00
alesapin
dcfe6524e5 Fix unit tests 2020-02-07 12:51:48 +03:00
Slach
8251695383 change system.metrics.MySQLConnection description after review
Signed-off-by: Slach <bloodjazman@gmail.com>
2020-02-07 08:12:00 +05:00
Slach
1bff5578b6 Merge branch 'master' of github.com:ClickHouse/ClickHouse 2020-02-07 08:03:45 +05:00
Vitaly Baranov
291b7c277a Move some part of the Authentication class to header to allow using in the parser. 2020-02-06 18:12:48 +03:00
Alexander Kuzmenkov
d9073f27b7 Revert "Merge pull request #9025 from ClickHouse/revert-8303-cache-dictionary"
This reverts commit 24bdad3768, reversing
changes made to dad4f03a8f.
2020-02-06 15:18:19 +03:00
Nikita Mikhaylov
c53053b103
Revert "Asynchronous updates in cache dictionaries " 2020-02-05 23:00:59 +03:00
Slach
23b787c0d6 actualize description of system.metrics.TCPConnection
add system.metrics.MySQLConnection

Signed-off-by: Slach <bloodjazman@gmail.com>
2020-02-05 19:06:46 +05:00
Ivan Lezhankin
88095b636e Merge remote-tracking branch 'upstream/master' into memory-profiler 2020-02-03 16:21:21 +03:00
Nikita Mikhaylov
11e3570be0 better 2020-02-03 14:58:33 +03:00
Nikita Mikhaylov
9c99498f2b Merge branch 'master' of github.com:ClickHouse/ClickHouse into cache-dictionary 2020-02-03 14:15:20 +03:00
CurtizJ
2d7ff400ed Merge remote-tracking branch 'upstream/master' into polymorphic-parts 2020-02-03 13:46:00 +03:00
Alexey Milovidov
d11f3cb78f Changed thread_id to UInt64 to support more OS 2020-02-02 23:01:13 +03:00
Alexey Milovidov
39b31907b5 Rename function #7477 2020-02-02 05:35:47 +03:00
Alexey Milovidov
f9eb4e79f6 Using OS tid everywhere #7477 2020-02-02 05:28:14 +03:00
Vitaly Baranov
9e910222da Add interfaces to check access rights. 2020-01-31 19:23:33 +03:00
alexey-milovidov
c2c5b81b70
Merge pull request #8851 from excitoon-favorites/globss3
Added globs/wildcards for s3
2020-01-31 18:56:06 +03:00
Nikita Mikhaylov
c5e664a072 Merge branch 'master' of github.com:ClickHouse/ClickHouse into cache-dictionary 2020-01-30 17:43:13 +03:00
Ivan Lezhankin
d36f082094 Merge remote-tracking branch 'upstream/master' into memory-profiler 2020-01-30 14:36:59 +03:00
Ivan Lezhankin
56f6199b11 Try to simplify TraceCollector initialization.
It allows to workaround first call inside signal handler
2020-01-29 19:34:55 +03:00
alexey-milovidov
f65b75ce5a
Merge pull request #8874 from abyss7/issue-6964
Initialize query profiler for all threads in a group
2020-01-29 15:41:59 +03:00
alexey-milovidov
2f9dd8e80f
Merge pull request #8877 from ClickHouse/aku/trace-readability
Reformat stack traces for readability.
2020-01-29 02:19:18 +03:00
alexey-milovidov
30c11474c8
Merge pull request #8834 from zlobober/comparable_nulls
Make NULLs comparable to everything.
2020-01-28 21:58:59 +03:00
Ivan Lezhankin
df0a3ce221 Merge remote-tracking branch 'upstream/master' into memory-profiler 2020-01-28 18:34:19 +03:00
Ivan Lezhankin
354ceeda80 Fix TSan tests 2020-01-28 18:30:49 +03:00
Alexander Kuzmenkov
37daed2830 Reformat stack traces for readability. 2020-01-28 17:42:58 +03:00
Ding Xiang Fei
55b81c97e6 Set signal before rethrowing exception (#8736)
* set signal before rethrowing exception
* Add comment
2020-01-28 16:47:47 +03:00
Maxim Akhmedov
65356ea893 And one more fix. 2020-01-28 15:33:25 +03:00
Maxim Akhmedov
ead37dc294 Fix comparison between decimal field and null. 2020-01-28 15:31:17 +03:00
Ivan Lezhankin
27986b6658 Revert "Merge pull request #8831 from ClickHouse/revert-8820-issue-6964"
This reverts commit a21d3712eb, reversing
changes made to 667e9ed6d4.
2020-01-28 15:01:45 +03:00
Vladimir Chebotarev
11a5cab7bd Added some tests. 2020-01-28 00:44:18 +03:00
Maxim Akhmedov
af7e66f0da Make NULLs comparable to everything. 2020-01-27 17:28:57 +03:00
Nikita Mikhaylov
83cdc50ede Merge branch 'master' of github.com:ClickHouse/ClickHouse into cache-dictionary 2020-01-27 14:19:38 +03:00
alexey-milovidov
056aba49ff
Update QueryProfiler.cpp 2020-01-26 14:27:12 +03:00
alexey-milovidov
9602e67050
Update QueryProfiler.cpp 2020-01-26 14:25:28 +03:00
Alexey Milovidov
2acb71337f Added workaround for Google Cloud Runner 2020-01-26 14:19:04 +03:00
alexey-milovidov
9814831c8f
Merge pull request #8827 from zlobober/disable_mmap
Allow disabling mmapping
2020-01-25 23:42:04 +03:00
alexey-milovidov
ab172eb0bd
Revert "Initialize query profiler for all threads in a group" 2020-01-25 23:34:22 +03:00
Maxim Akhmedov
2f12866bc2 Introduce macro for disabling allocator mmapping. 2020-01-25 22:17:18 +03:00
alexey-milovidov
1630e88c81
Merge pull request #8820 from abyss7/issue-6964
Initialize query profiler for all threads in a group
2020-01-25 21:33:46 +03:00
alexey-milovidov
df4f0c7379
Merge pull request #8805 from azat/force_optimize_skip_unused_shards
force_optimize_skip_unused_shards setting to throw if skipping is not possible
2020-01-25 17:37:59 +03:00
Alexey Milovidov
bf59e09901 Fixed style check 2020-01-25 16:18:17 +03:00
alexey-milovidov
2627e34ddf
Merge pull request #8808 from zlobober/weak_check_stack_size
Make checkStackSize symbol weak.
2020-01-25 03:10:41 +03:00
alexey-milovidov
8bde8e5e14
Update checkStackSize.cpp 2020-01-25 03:10:09 +03:00
alexey-milovidov
095f666677
Update checkStackSize.cpp 2020-01-25 03:06:13 +03:00
Azat Khuzhin
6939ffeabf force_optimize_skip_unused_shards setting to throw if skipping is not possible 2020-01-24 21:15:40 +03:00
Ivan Lezhankin
9d30f3c876 Initialize query profiler for all threads in a group 2020-01-24 17:47:38 +03:00
Alexey Milovidov
b1fcea78b8 Merge branch 'fix-paren' 2020-01-24 07:05:32 +03:00
Alexey Milovidov
3a5c7370b2 Addition to prev. revision #8811 2020-01-24 07:05:15 +03:00
alexey-milovidov
2105c02e85
Merge pull request #8811 from ClickHouse/fix-paren
Fixed bug with parentheses
2020-01-24 07:04:13 +03:00
Alexey Milovidov
12d980259e Fixed bug with parentheses 2020-01-24 05:38:03 +03:00
Maxim Akhmedov
af54c378ce Make checkStackSize symbol weak. 2020-01-23 23:30:40 +03:00
Ivan Lezhankin
a982309cff Fix client hanging on quit 2020-01-23 12:42:58 +03:00
Alexey Milovidov
2a6b9fbeb4 Merge branch 'master' into oandrew-avro 2020-01-22 22:37:07 +03:00
Ivan Lezhankin
7706e0a35c Some renames 2020-01-22 18:20:19 +03:00
Nikita Mikhaylov
97144cb645 Merge branch 'master' of github.com:ClickHouse/ClickHouse into cache-dictionary 2020-01-22 14:51:05 +03:00
Ivan Lezhankin
2899fbfb52 Remove unused diff 2020-01-21 19:43:42 +03:00
Ivan Lezhankin
d444bc7a11 Remove unused diff 2020-01-21 19:39:52 +03:00
Ivan Lezhankin
008faaa760 Add settings for soft limit raising. 2020-01-21 19:39:52 +03:00
Ivan Lezhankin
1934706ca9 [WIP] 2020-01-21 19:39:52 +03:00
Ivan Lezhankin
c566f406c5 Add new trace type to system.trace_log table 2020-01-21 19:39:52 +03:00
CurtizJ
9275225527 Merge remote-tracking branch 'upstream/master' into polymorphic-parts 2020-01-21 17:21:52 +03:00
Alexey Milovidov
ae7b9a652b Merge branch 'vfs-s3' of https://github.com/GrigoryPervakov/ClickHouse into GrigoryPervakov-vfs-s3 2020-01-19 01:12:05 +03:00
Alexey Milovidov
457c50c7d7 Code cleanups around 2020-01-18 23:19:10 +03:00
Alexey Milovidov
c0a5c664a9 Replace readline to replxx: docs and corrections 2020-01-18 18:44:08 +03:00
Pervakov Grigory
70e50ecf10 Base implementation of IDisk interafce for S3 2020-01-17 14:34:39 +03:00
CurtizJ
27750f0cd4 Merge remote-tracking branch 'upstream/master' into polymorphic-parts 2020-01-15 19:36:35 +03:00
alexey-milovidov
4dd5da353a
Merge pull request #8286 from amosbird/grouparraysample
groupArraySample
2020-01-13 20:57:27 +03:00
alexey-milovidov
303b146a93
Merge branch 'master' into vfs_log 2020-01-12 20:16:30 +03:00
Alexey Milovidov
797b1b9cd5 Fixed error code of test assertion in client 2020-01-12 16:47:56 +03:00
Alexey Milovidov
cc609143e9 Make one unit test more maintainable 2020-01-11 16:28:24 +03:00
Pradeep Chhetri
4941fdfe4b Fix some spelling mistakes 2020-01-11 17:51:33 +08:00
alexey-milovidov
bfda1ff807 Update FileChecker.cpp 2020-01-11 00:54:47 +03:00
Alexander Burmak
26511b7978 Added DiskMemory and tests 2020-01-11 00:43:42 +03:00
Alexander Kuzmenkov
3999675383 In debug builds, treat LOGICAL_ERROR as an assertion failure. 2020-01-09 19:58:32 +03:00
Alexander Burmak
c4f44bb06c Merge remote-tracking branch 'refs/remotes/upstream/master' into vfs_log 2020-01-09 16:29:03 +03:00
CurtizJ
33ae97894b Merge remote-tracking branch 'upstream/master' into polymorphic-parts 2020-01-09 15:54:37 +03:00
Alexey Milovidov
16f9628513 Fixed error 2020-01-06 09:19:12 +03:00
Alexey Milovidov
be90d33797 Avoid MSan report for data from libunwind 2020-01-06 05:15:31 +03:00
alexey-milovidov
42226b1a96
Added setting "min_bytes_to_use_mmap_io" (#8520)
* Added setting "min_bytes_to_use_mmap_io"

* Added setting "min_bytes_to_use_mmap_io"

* Added setting "min_bytes_to_use_mmap_io"

* Added setting "min_bytes_to_use_mmap_io"

* Added setting "min_bytes_to_use_mmap_io"

* Added setting "min_bytes_to_use_mmap_io"

* Added setting "min_bytes_to_use_mmap_io"

* Added setting "min_bytes_to_use_mmap_io"

* Added setting "min_bytes_to_use_mmap_io"

* Added setting "min_bytes_to_use_mmap_io"

* Added setting "min_bytes_to_use_mmap_io"

* Added setting "min_bytes_to_use_mmap_io": better error message

* Added setting "min_bytes_to_use_mmap_io": fixed error
2020-01-04 08:46:50 +03:00
Alexey Milovidov
ab001c5b3a Fixed build 2020-01-02 21:55:45 +03:00
Alexey Milovidov
9e78683c87 Fixed build 2020-01-02 19:32:17 +03:00
Alexander Burmak
70b3a1a0d8 Merge remote-tracking branch 'refs/remotes/upstream/master' into vfs_log 2020-01-02 18:01:41 +03:00