Commit Graph

1450 Commits

Author SHA1 Message Date
Vitaliy Zakaznikov
a80af666ad * Updates that incorporate comments from the review 2019-07-09 08:41:55 -04:00
Vitaliy Zakaznikov
24a3726235 Merge branch 'master' of https://github.com/vzakaznikov/ClickHouse into liveview 2019-07-07 20:03:14 -04:00
alexey-milovidov
d81ae49f2c
Merge pull request #5755 from 4ertus2/bugs
Fix wrong ColumnConst.isColumnNullable()
2019-07-03 02:06:07 +03:00
Vitaliy Zakaznikov
b5120931d5 Merge branch 'master' of https://github.com/yandex/ClickHouse into liveview 2019-07-01 18:12:31 -04:00
Vitaliy Zakaznikov
a363189dfc Merge branch 'master' of https://github.com/vzakaznikov/ClickHouse into liveview 2019-07-01 18:05:14 -04:00
alexey-milovidov
c43dfce041
Merge pull request #5382 from abyss7/issue-5286
Add virtual columns to Kafka Engine tables
2019-07-01 21:30:09 +03:00
alexey-milovidov
bf8c154d3d
Merge pull request #5819 from CurtizJ/fix-segfault-ttl
Fix segfault in TTL merge with non-physical columns in block.
2019-07-01 20:28:26 +03:00
CurtizJ
ecf9feab9c remove extra semicolon 2019-07-01 17:09:22 +03:00
CurtizJ
c0a63801fc fix segfault in ttl merge with non-physical columns in block 2019-07-01 15:50:50 +03:00
chertus
5df4ad0f28 Merge branch 'master' into bugs 2019-07-01 14:49:01 +03:00
alexey-milovidov
106a2d0c0f
Merge pull request #4930 from yandex/tsan-miscellaneous
Miscellaneous changes
2019-07-01 11:11:53 +03:00
alexey-milovidov
5fb7bf6854
Update ParallelInputsProcessor.h 2019-07-01 03:15:14 +03:00
chertus
f19dee706a move IColumn.isColumnConst() outside of interface 2019-06-27 22:28:52 +03:00
Danila Kutenin
e67431e455 Use mimalloc instead of lfallocator 2019-06-27 18:13:19 +03:00
Ivan Lezhankin
61750d09d2 Commit offsets for SELECTing from Kafka table too 2019-06-20 15:34:25 +03:00
Ivan Lezhankin
9fd048cdbd Allow to select virtual columns in materialized view 2019-06-18 19:32:37 +03:00
Ivan Lezhankin
436052c67b Merge branch 'master' into issue-5286 2019-06-18 16:03:29 +03:00
Vitaliy Zakaznikov
51bf8a1baa Merge branch 'master' of https://github.com/vzakaznikov/ClickHouse into liveview 2019-06-17 12:42:31 -04:00
Ivan Lezhankin
d907d8e8ca Commit offsets for SELECTing from Kafka table too 2019-06-17 19:27:18 +03:00
alesapin
e45d727e9d
Merge pull request #4558 from podshumok/distributred-timeout
Distributed and remote timeouts
2019-06-17 13:58:17 +03:00
Vitaliy Zakaznikov
ea83a4cafa * Removing 'hash' column from WATCH [db.live_view] EVENTS query result
as hash of the result are not usually provided in ClickHouse.
  This is also done to match the implementation of the SELECT query that only
  returns '_version' virtual column when using LIVE VIEW tables.
2019-06-16 07:09:43 -04:00
Vitaliy Zakaznikov
117f2d191e Merge branch 'master' of https://github.com/vzakaznikov/ClickHouse into liveview 2019-06-13 15:23:20 -04:00
Alexey Milovidov
8b87511e25 Namespace comments are unneeded according to the code style.
find dbms -name '*.h' -or -name '*.cpp' | xargs grep -l -P '}\s*//+\s*namespace\s*' | xargs sed -i -r -e 's/}\s*\/\/+\s*namespace\s*\w+/}/'
2019-06-13 13:37:13 +03:00
Vitaliy Zakaznikov
5983273694 Fixing bugs reported by sanitizers
* data race condition on storage is_dropped access
* invalid reference to storage after it is deleted
* invalid reference to mutex after storage is deleted
2019-06-12 09:11:44 -04:00
Vitaliy Zakaznikov
12060d8879 * Fixing errors that prevented clang build. 2019-06-11 08:27:47 -04:00
Vitaliy Zakaznikov
b6efd8599f * Trying again to fix style checks. Now running ./utils/check-style/check-style reports no errors. 2019-06-11 06:30:57 -04:00
Vitaliy Zakaznikov
a467e7c105 * Moving uexpect.py so that it can be found
* Trying to fix failed style checks
* Trying to fix clang build fail
2019-06-10 22:22:53 -04:00
Vitaliy Zakaznikov
fc4ea55b98 * Fixing bug in dbms/src/DataStreams/PushingToViewsBlockOutputStream.cpp
that was introduced when trying to fix a clang error.
2019-06-10 08:11:43 -04:00
Vitaliy Zakaznikov
a68980ab38 * Style check fixes 2019-06-10 07:41:33 -04:00
Vitaliy Zakaznikov
87b58e4150 * Fixing clang errors
* Fixing LIVE VIEW tests
2019-06-10 07:18:33 -04:00
Vitaliy Zakaznikov
b65ff910b6 Merge branch 'master' of https://github.com/vzakaznikov/ClickHouse into liveview 2019-06-07 08:02:59 -04:00
Vitaliy Zakaznikov
2930965938 * Renaming live_view_heartbeat_delay setting to live_view_heartbeat_interval
and making the setting to be in seconds instead of usec
* Updated LIVE VIEW table to keep version consistent as long as the server is up
* Removed calculation of hash in writeIntoLiveView method as it is recalculated
  in the LiveViewBlockOutputStream
* Changed to using values from the local context for live_view_heartbeat_interval and
  temporary_live_view_timeout instead of the global context
* Updated LIVE VIEW tests to match the changes
2019-06-06 21:10:56 -04:00
Vitaliy Zakaznikov
5f3be8134d * Disallowing writes into LIVE VIEW tables
* Adding support for watching live views via HTTPHandler
* Small fix to WriteBufferValidUTF8.cpp to propagate next() call
* Updated copyData.cpp to treat block with no rows as
  "flush block"
* Updated PushingToViewsBlockOutputStream.cpp to directly use
  LIVE VIEW output stream instead of calling its write method
2019-06-05 07:30:29 -04:00
Ivan Lezhankin
b311984879 Merge remote-tracking branch 'upstream/master' into issue-5286 2019-06-03 17:19:09 +03:00
Konstantin Podshumok
f993ea6127 add timeouts to remote streams 2019-06-02 12:43:20 +03:00
Vitaliy Zakaznikov
673d1a46a0 * Adding support for _version virtual column to LIVE VIEWs when using SELECT
* Adding support for _version column to LIVE VIEWS when using WATCH query
* Adding initial support for WATCH query on LIVE VIEWs
2019-05-29 17:52:13 -04:00
Vitaliy Zakaznikov
d112695c42 * Adding other changes to support LIVE VIEWs 2019-05-28 17:17:48 -04:00
Ivan Lezhankin
1eccbc39c5 Don't add virtual column to empty block 2019-05-28 00:01:24 +03:00
Vitaliy Zakaznikov
9dd07bcc23 * Work in progress to redo live view implementation to be less invasive 2019-05-26 18:03:30 -04:00
Yuriy
96e3574a06 Improvements of MySQL Wire Protocol 2019-05-26 09:52:29 +03:00
alexey-milovidov
461c4919d3
Merge pull request #5116 from PerformanceVision/send_header
Send a X-ClickHouse summary on the header for HTTP client with number of rows inserted
2019-05-25 20:20:35 +03:00
Alexey Milovidov
b94f2be154 Merge branch 'mysql' of https://github.com/yurriy/ClickHouse into yurriy-mysql 2019-05-25 17:14:57 +03:00
Ivan Lezhankin
646d6f3fb5 Fix order of destruction 2019-05-23 16:54:11 +03:00
Ivan Lezhankin
800854119e Add buffer callback to fill in virtual columns 2019-05-23 14:15:18 +03:00
Guillaume Tassery
77b7158cd8 Progress rename for total_rows and write_[rows|bytes] 2019-05-20 18:37:41 +07:00
alexey-milovidov
02937294ce
Merge pull request #5311 from azat-archive/SimpleAggregateFunction-Arena-fix
Fix SimpleAggregateFunction for String longer MAX_SMALL_STRING_SIZE
2019-05-19 13:12:38 +03:00
Azat Khuzhin
db274bf516
Allocates arena for SimpleAggregateFunction only if IAggregateFunction requires 2019-05-19 03:33:04 +03:00
Azat Khuzhin
4e8370b0b0
Fix SimpleAggregateFunction for String longer MAX_SMALL_STRING_SIZE
SimpleAggregateFunction do not pass arena to the
add_function -> getAddressOfAddFunction(), hence next crash happens:
  (gdb) bt
  #0  DB::Arena::alloc (size=64, this=0x0) at ../dbms/src/Common/Arena.h:124
  #1  DB::SingleValueDataString::changeImpl (this=0x7f97424a27d8, value=..., arena=0x0) at ../dbms/src/AggregateFunctions/AggregateFunctionMinMaxAny.h:274
  #2  0x0000000005ea5319 in DB::AggregateFunctionNullUnary<true>::add (arena=<optimized out>, row_num=<optimized out>, columns=<optimized out>, place=<optimized out>, this=<optimized out>) at ../dbms/src/AggregateFunctions/AggregateFunctionNull.h:43
  #3  DB::IAggregateFunctionHelper<DB::AggregateFunctionNullUnary<true> >::addFree (that=<optimized out>, place=<optimized out>, columns=<optimized out>, row_num=<optimized out>, arena=<optimized out>) at ../dbms/src/AggregateFunctions/IAggregateFunction.h:131
  #4  0x000000000679772f in DB::AggregatingSortedBlockInputStream::addRow (this=this@entry=0x7f982de19c00, cursor=...) at ../dbms/src/Common/AlignedBuffer.h:31
  #5  0x0000000006797faa in DB::AggregatingSortedBlockInputStream::merge (this=this@entry=0x7f982de19c00, merged_columns=..., queue=...) at ../dbms/src/DataStreams/AggregatingSortedBlockInputStream.cpp:140
  #6  0x0000000006798979 in DB::AggregatingSortedBlockInputStream::readImpl (this=0x7f982de19c00) at ../dbms/src/DataStreams/AggregatingSortedBlockInputStream.cpp:78
  #7  0x000000000622db55 in DB::IBlockInputStream::read (this=0x7f982de19c00) at ../dbms/src/DataStreams/IBlockInputStream.cpp:56
  #8  0x0000000006613bee in DB::MergeTreeDataMergerMutator::mergePartsToTemporaryPart (this=this@entry=0x7f97ec65e1a0, future_part=..., merge_entry=..., time_of_merge=<optimized out>, disk_reservation=<optimized out>, deduplicate=<optimized out>) at /usr/include/c++/8/bits/shared_ptr_base.h:1018
  #9  0x000000000658f7a4 in DB::StorageReplicatedMergeTree::tryExecuteMerge (this=0x7f97ec65b810, entry=...) at /usr/include/c++/8/bits/unique_ptr.h:342
  #10 0x00000000065940ab in DB::StorageReplicatedMergeTree::executeLogEntry (this=0x7f97ec65b810, entry=...) at ../dbms/src/Storages/StorageReplicatedMergeTree.cpp:910
  <snip>

  (gdb) f 1
  (gdb) p MAX_SMALL_STRING_SIZE
  $1 = 48
  (gdb) p capacity
  $2 = 64
  (gdb) p value
  $3 = {data = 0x7f97242fcbd0 "HHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH", size = 61}

v2: avoid leaking of allocated by Arena memory on the intermediate step

Fixes: 8f8d2c048e ("Merge pull request #4629 from bgranvea/simple_aggregate_function")
2019-05-19 03:32:55 +03:00
alexey-milovidov
fa4a7eb3d1
Merge branch 'master' into merge-itable-istorage 2019-05-18 00:37:12 +03:00
Ivan Lezhankin
dcff73c8d4 Fix build 2019-05-17 21:45:42 +03:00