Commit Graph

6549 Commits

Author SHA1 Message Date
Raúl Marín
8439135960 Try to make the test faster 2021-08-06 18:28:44 +02:00
Alexander Kuzmenkov
658ce5258f
Merge pull request #26663 from ildus/mappopulateseries_for_maps
Add Map type support in mapPopulateSeries function
2021-08-06 18:53:37 +03:00
Raúl Marín
28901ef55f Fix 01300_client_save_history_when_terminated_long
It was broken because of colored output
2021-08-06 17:25:24 +02:00
Azat Khuzhin
1f60cd735d Revert changes in 01710_projection_fetch 2021-08-06 17:52:23 +03:00
Nikolai Kochetov
48eb995461 Fix unknown column bug in sampling. 2021-08-06 17:23:50 +03:00
Raúl Marín
d33a634014 Improve 00738_lock_for_inner_table stability
A sufficiently fast machine would finish processing the MV before the drop
2021-08-06 16:12:59 +02:00
vdimir
3ca05653bb
Use template for 01049_join_low_card_bug_long.sql 2021-08-06 15:07:50 +03:00
vdimir
d53ade572e
Fix non joined stream structure 2021-08-06 14:54:04 +03:00
Raúl Marín
084e3da13f 01099_operators_date_and_timestamp: Use dates that work with all available timezones 2021-08-06 11:36:52 +02:00
tavplubix
14ef66e49b
Merge pull request #25895 from ClickHouse/improve_create_or_replace
Improve CREATE OR REPLACE query
2021-08-06 11:58:46 +03:00
Vladimir C
7f7bf9654b
Merge pull request #27235 from Algunenano/fix_lambda_aliases 2021-08-06 11:27:45 +03:00
Azat Khuzhin
6747b8a03b Mark more tests as long 2021-08-06 07:07:50 +03:00
Azat Khuzhin
c523904b74 Mark more tests as long 2021-08-06 14:00:07 +03:00
Azat Khuzhin
6567aeda6c Mark more tests as long 2021-08-06 07:56:23 +03:00
Azat Khuzhin
735b730a52 Mark more tests as long 2021-08-06 00:20:48 +03:00
Azat Khuzhin
1358a2db92 Fix WithMergeableStateAfterAggregationAndLimit with LIMIT BY and LIMIT OFFSET
In case of LIMIT BY, pre LIMIT cannot be applied (that is done on the
shard before), and hence shard applies regular LIMIT, but it goes with
applying OFFSET, and also the initiator will do apply OFFSET too.
2021-08-06 00:16:26 +03:00
Azat Khuzhin
c4e2342a06 Add verbose description for pre-LIMIT into EXPLAIN query 2021-08-06 00:16:26 +03:00
alexey-milovidov
1a3d8cebd2
Merge pull request #27197 from azat/nullable-index-fix
Fix on-disk format breakage for secondary indices over Nullable column
2021-08-05 21:52:18 +03:00
Azat Khuzhin
d5987b7a06 Fix 00754_alter_modify_order_by_replicated_zookeeper 2021-08-05 21:01:36 +03:00
Azat Khuzhin
fbcf0962ee Mark some tests as long 2021-08-05 21:01:35 +03:00
Raúl Marín
fd76966715 Test shadow lambda recovery
Be a good citizen and leave a test checking for the recovery
after the lambda function has been processed
2021-08-05 19:03:42 +02:00
Raúl Marín
8b9778ebb6 Shadow lambda arguments
In case of ambiguity, lambda functions should prefer its arguments to
other aliases or identifiers
2021-08-05 18:52:00 +02:00
vdimir
a427b19d3a
Check join_use_nulls changed in StorageView::read 2021-08-05 18:38:52 +03:00
Nikolai Kochetov
fc12310ee8 Revert #24095. User-level settings will affect queries from view. 2021-08-05 17:17:22 +03:00
Alexander Kuzmenkov
d852207b0e
Merge pull request #25721 from CurtizJ/read-in-order-perf-2
Reduce memory usage in queries with `ORDER BY primary_key
2021-08-05 16:13:48 +03:00
Maksim Kita
71e5cfe3ca
Merge pull request #27134 from FArthur-cmd/compress_output_3473
add compression for INTO OUTFILE
2021-08-05 14:20:08 +03:00
Alexander Kuzmenkov
4bc652699f
Merge pull request #27184 from ClickHouse/aku/window-functions
mark window functions as ready for general use
2021-08-05 14:18:28 +03:00
alexey-milovidov
975e0a4d47
Merge pull request #27182 from amosbird/logquerykind
Try our best to log query_kind
2021-08-05 12:43:13 +03:00
Azat Khuzhin
bc0af176fe tests/stateless: add {database} macro for ReplicatedMergeTree in *.sql 2021-08-05 10:24:23 +03:00
Amos Bird
665f735044
Add some test 2021-08-05 10:50:11 +08:00
Azat Khuzhin
dee27fcbb9 Fix on-disk format breakage for secondary indices over Nullable column
[1] breaks on disk format (and the relevant change in the:

  [1]: https://github.com/ClickHouse/ClickHouse/pull/12455#discussion_r682830812

Too bad that I checked this patchset only for compatibility after
reverting this patch [2] (use case: I've applied it manually, then
revert it, and data skipping indexes over Nullable column had been
broken)

  [2]: https://github.com/ClickHouse/ClickHouse/pull/12455#issuecomment-823423772

But this patchset actually breaks compatibility with older versions of
clickhouse for Nullable data skipping indexes after simple upgrade:

Here is a simple reproducer:

    --
    -- run this with 21.6 or similar (i.e. w/o this patch)
    --

    CREATE TABLE data
    (
        `key` Int,
        `value` Nullable(Int),
        INDEX value_index value TYPE minmax GRANULARITY 1
    )
    ENGINE = MergeTree
    ORDER BY key;

    INSERT INTO data SELECT
        number,
        number
    FROM numbers(10000);

    SELECT * FROM data WHERE value = 20000 SETTINGS force_data_skipping_indices = 'value_index' SETTINGS force_data_skipping_indices = 'value_index', max_rows_to_read=1;

Now upgrade and run the query again:

    SELECT * FROM data WHERE value = 20000 SETTINGS force_data_skipping_indices = 'value_index' SETTINGS force_data_skipping_indices = 'value_index', max_rows_to_read=1;

And it will fail because of on disk format changes:

    $ ll --time-style=+ data/*/data/all_1_1_0/skp*.idx
    -rw-r----- 1 azat azat 36  data/with_nullable_patch/data/all_1_1_0/skp_idx_value_index.idx
    -rw-r----- 1 azat azat 37  data/without_nullable_patch/data/all_1_1_0/skp_idx_value_index.idx

    $ md5sum data/*/data/all_1_1_0/skp*.idx
    a19c95c4a14506c65665a1e30ab404bf  data/with_nullable_patch/data/all_1_1_0/skp_idx_value_index.idx
    e50e2fcfa873b232196623d56ab26105  data/without_nullable_patch/data/all_1_1_0/skp_idx_value_index.idx

Note, that there is no stable release with this patch included yet, so
no need to backport.

Also note that you may create data skipping indexes over Nullable
column even before [3].

  [3]: https://github.com/ClickHouse/ClickHouse/pull/12455

v2: break cases when granulas has Null in values due to backward
compatibility
2021-08-05 00:19:38 +03:00
Azat Khuzhin
643c31d6f3 Save information about used functions/tables/... into query_log on error 2021-08-04 21:44:18 +03:00
Anton Popov
9a9aebc644 fix tests 2021-08-04 20:38:10 +03:00
Alexander Kuzmenkov
b190e499ee fixup 2021-08-04 17:46:25 +03:00
Alexander Kuzmenkov
0730e685b0 Mark window functions ready for general use. 2021-08-04 17:45:32 +03:00
Anton Ivashkin
61016da2b1 Set allow_remote_fs_zero_copy_replication to true by default 2021-08-04 17:08:09 +03:00
vdimir
b8558a1716
Fix uninitialized memory in functions multiSearch* with empty array 2021-08-04 16:44:39 +03:00
tavplubix
0dbcbc28ba
Merge pull request #27164 from nicelulu/fix_0_stateless_01034
Fix CURR_DATABASE empty for 01034_move_partition_from_table_zookeeper.sh
2021-08-04 13:50:06 +03:00
Artur Filatenkov
9b9982ee3d correct test with deleting files after usage 2021-08-04 12:53:41 +03:00
Vladimir C
d9c9422a44
Merge pull request #27078 from vdimir/pmj-empty-set 2021-08-04 11:15:46 +03:00
zhangxiao871
6a5925b6ce Fix CURR_DATABASE empty for 01034_move_partition_from_table_zookeeper.sh 2021-08-04 11:07:39 +08:00
alexey-milovidov
63b90bec6c
Merge pull request #27131 from kitaisreal/global-subqueries-visitor-external-storage-check-fix
GlobalSubqueriesVisitor external storage check fix
2021-08-04 03:11:56 +03:00
Anton Popov
699a3d9031 implement legacy_column_name_of_tuple_literal in less intrusive way 2021-08-03 21:03:24 +03:00
Ilya Yatsishin
30851aee23
Merge pull request #27093 from amosbird/hostnametest
Normalize hostname in stateless tests
2021-08-03 17:58:28 +03:00
Vladimir C
1ebde0278e
Merge pull request #26957 from vdimir/fix-unknown-name-join-rewrite 2021-08-03 17:10:08 +03:00
Artur
f4a59a6abf correct tests 2021-08-03 13:41:58 +00:00
Artur
5c6974736d add newline 2021-08-03 12:52:46 +00:00
Artur
f4275b952e add simple test 2021-08-03 12:31:38 +00:00
mergify[bot]
dc57254982
Merge branch 'master' into improve_create_or_replace 2021-08-03 11:39:07 +00:00
Maksim Kita
0dc7da92b4 Added test 2021-08-03 14:24:21 +03:00
Maksim Kita
d9383270f6
Merge pull request #27054 from MaxWk/feature/add-default-database-to-system-users
add column default_database to system.users
2021-08-03 13:37:15 +03:00
Azat Khuzhin
97851bde08 Fix Distributed over Distributed for WithMergeableStateAfterAggregation* stages
In case if one Distributed has multiple shards, and underlying
Distributed has only one, there can be the case when the query will be
tried to process from Complete to WithMergeableStateAfterAggregation,
which is obviously wrong.
2021-08-03 10:10:08 +03:00
Amos Bird
b541b5eca3
Normalize hostname in CI 2021-08-03 15:00:57 +08:00
tavplubix
58b50bad3a
Merge pull request #27033 from ClickHouse/database_replicated_fixes
Fix assertions in Replicated database
2021-08-02 23:33:18 +03:00
Nikita Mikhaylov
771bd6be11
Merge pull request #27092 from Algunenano/clear_dns_test
Stateless tests: Keep an DNS error free log
2021-08-02 21:44:15 +03:00
Azat Khuzhin
ff12f5102a Avoid running LIMIT BY/DISTINCT step on the initiator for optimize_distributed_group_by_sharding_key
Before the following queries was running LimitBy/Distinct step on the
initator:

  select distinct sharding_key from dist order by k

While this can be omitted.
2021-08-02 21:04:30 +03:00
Azat Khuzhin
c830964240 Cover distributed_push_down_limit for queries w/o sharding expr 2021-08-02 21:04:30 +03:00
Azat Khuzhin
2fb95d9ee0 Rework SELECT from Distributed query stages optimization
Before this patch it wasn't possible to optimize simple SELECT * FROM
dist ORDER BY (w/o GROUP BY and DISTINCT) to more optimal stage
(QueryProcessingStage::WithMergeableStateAfterAggregationAndLimit),
since that code was under
allow_nondeterministic_optimize_skip_unused_shards, rework it and make
it possible.

Also now distributed_push_down_limit is respected for
optimize_distributed_group_by_sharding_key.

Next step will be to enable distributed_push_down_limit by default.

v2: fix detection of aggregates
2021-08-02 21:04:29 +03:00
Nikolai Kochetov
d63a5e1c96
Merge pull request #26675 from Algunenano/kill_better
Handle KILL requests while running pipeline executors
2021-08-02 17:37:54 +03:00
Raúl Marín
d5a5ba8f0d Stateless tests: Keep an DNS error free log 2021-08-02 15:19:40 +02:00
Alexander Tokmakov
42a8bb6872 fix assertions in Replicated database 2021-08-02 16:19:11 +03:00
vdimir
5d2aec78c3
Add testcase for multiple joins and unknwon identifier in where section 2021-08-02 15:08:14 +03:00
vdimir
7364f35da6
Add alwaysReturnsEmptySet for Merge Join 2021-08-02 13:49:56 +03:00
Nikolai Kochetov
6951e8147d
Merge pull request #27020 from amosbird/shardlevelconstness
Shard-level const column
2021-08-02 13:45:20 +03:00
Alexander Kuzmenkov
44e3b76c3a
Merge branch 'master' into mappopulateseries_for_maps 2021-08-02 13:02:22 +03:00
alesapin
181f93c60a
Merge pull request #24997 from evillique/nlp
NLP functions
2021-08-02 10:50:40 +03:00
Anton Popov
cc3ed12ed6 Merge remote-tracking branch 'upstream/master' into HEAD 2021-08-02 02:56:00 +03:00
万康
80f33244d4 add column default_database 2021-08-01 08:12:37 +08:00
万康
66631ca680 add column default_database 2021-08-01 08:11:01 +08:00
Alexey Milovidov
7fa24539b8 Make test 01852_cast_operator independent of timezone 2021-07-31 21:24:23 +03:00
Amos Bird
c03b20d1a1
Fix 2021-07-31 17:02:33 +08:00
Amos Bird
479d4fa991
Add shardNum() and shardCount() functions 2021-07-31 15:45:39 +08:00
Vitaly Baranov
99929981ab
Merge pull request #25687 from MaxWk/profile-default-database
add setting profile_default_database
2021-07-31 08:37:02 +03:00
alexey-milovidov
d2b7e23899
Merge pull request #26961 from Enmk/fix/extractAllGroupsHorizontal_max_matches_per_row
Updated extractAllGroupsHorizontal - flexible limit on number of matches
2021-07-31 04:54:24 +03:00
alexey-milovidov
c74f5feaaf
Merge pull request #27028 from Algunenano/flaky_01006
Improve 01006_simpod_empty_part_single_column_write
2021-07-31 04:53:39 +03:00
Ildus Kurbangaliev
a4e9a56e8e Make changes by review on #26663 PR 2021-07-30 20:57:32 +02:00
alesapin
02176fb4c7 Add experimental flag 2021-07-30 18:25:51 +03:00
Raúl Marín
1f3c8387a3 01006_simpod_empty_part_single_column_write: Use sync mutation instead of waiting 2021-07-30 15:53:33 +02:00
Raúl Marín
be126cbbc5 Improve wait_for_mutation check
Fast return if there isn't any mutation (it's likely it has finished already)
2021-07-30 15:36:51 +02:00
Raúl Marín
f0ff9af332 Attempt to fix flaky 00705_drop_create_merge_tree 2021-07-30 13:40:49 +02:00
Alexander Kuzmenkov
4b9cf024f5
Merge pull request #26960 from ClickHouse/aku/window-partition-boundary
fix window function partition boundary search
2021-07-30 13:25:54 +03:00
alesapin
916594fe23 Merge branch 'master' into evillique-nlp 2021-07-30 13:03:10 +03:00
Maksim Kita
5666cf5fee
Merge pull request #27008 from Algunenano/adjust_00537_quarters
Adjust 00537_quarters to be timezone independent
2021-07-30 12:54:51 +03:00
Vasily Nemkov
a1fb16df52 setting regexp_max_matches_per_row instead of 3rd argument 2021-07-30 12:28:21 +03:00
Raúl Marín
4106d4bc21 Adjust 00537_quarters to be timezone independent 2021-07-30 11:14:07 +02:00
PHO
6425dd001a
Add a codec AES_128_GCM_SIV for encrypting columns on disk (#19896)
* Add a codec Encrypted() for encrypting columns on disk

While this is implemented as a compression codec, it does not actually compress data. It instead encrypts data on disk. The key is obtained by executing a user-specified command at the server startup, or if it's not specified the codec refuses to process any data. For now the only supported cipher is 'AES-128-GCM-SIV'.
2021-07-30 12:12:33 +03:00
alesapin
cae5502d51
Merge pull request #26963 from ClickHouse/fix_bad_partition_id
Add simple validation for partition id before drop partition
2021-07-30 11:21:28 +03:00
Raúl Marín
b4cd34b5fb Make the test parallelizable 2021-07-29 20:01:57 +02:00
Raúl Marín
ee4759ce86 Fix 01600_quota_by_forwarded_ip
The test was assuming clickhouse-local and curl would connect using the same address
2021-07-29 17:47:16 +02:00
tavplubix
c18c16855a
Merge pull request #26913 from PolyProgrammist/table-function-cluster-macros
Supported cluster macros inside table function 'cluster'
2021-07-29 18:43:36 +03:00
tavplubix
8aa5df7ceb
Update 01154_move_partition_long.sh 2021-07-29 16:40:33 +03:00
alesapin
21599ffefc Simple validation for partition id before drop partition 2021-07-29 16:11:05 +03:00
Alexander Kuzmenkov
55e1d1b592 the reference was correct after all, I just confused the sides of the
diff
2021-07-29 15:49:37 +03:00
Vasily Nemkov
ec77ba8bfc Updated extractAllGroupsHorizontal - flexible limit on number of matches per row.
If it is not set via third argument, it deafults to previously hardcoded
value 1000.
2021-07-29 15:36:55 +03:00
alesapin
bb77342606 Add test 2021-07-29 15:33:28 +03:00
Alexander Kuzmenkov
7c9467d7a7 fix window function partition boundary search
It was horribly broken and many test references were wrong. I'm
surprised I never noticed this.
2021-07-29 15:18:10 +03:00
Raúl Marín
0505e2e589 Add tests 2021-07-29 13:03:14 +02:00
tavplubix
4a3ade1aa5
Merge pull request #26814 from ClickHouse/fix_lost_aggregate_function_parameters
Fix lost parameters of aggregate functions
2021-07-29 13:43:05 +03:00
tavplubix
f8b6815ade
Merge pull request #26847 from ClickHouse/check_aggregate_function_parameters
Check aggregate function parameters in -Merge combinator
2021-07-29 13:42:52 +03:00
Vadim Volodin
918a4e8ab3 Supported cluster macros inside table function 'cluster' 2021-07-29 12:12:29 +03:00