Azat Khuzhin
a88903f276
Do not execute expressions inside chassert() in release builds (with sizeof() trick)
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 17:39:16 +01:00
Azat Khuzhin
ec171c1732
Improve abortOnFailedAssertion() usage from chassert()
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 13:03:47 +01:00
Azat Khuzhin
fc48f89b76
Improve chassert() macro to suppress warning in release builds
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-06 20:13:17 +01:00
serxa
b1407b1070
fix TSA support
2023-01-10 01:19:42 +00:00
serxa
d561f66419
more TSA support
2023-01-09 16:48:39 +00:00
Yakov Olkhovskiy
7a5a36cbed
Merge branch 'master' into refactoring-ip-types
2023-01-04 11:11:06 -05:00
Robert Schulze
27f5aad49e
What happens if I remove 156 lines of code?
2023-01-03 18:51:16 +00:00
Alexey Milovidov
e855d3519a
Merge branch 'master' into refactoring-ip-types
2023-01-02 21:58:53 +03:00
Nikita Mikhaylov
ffaff7167b
Fix flaky tests ( #44690 )
2022-12-29 14:32:10 +01:00
Azat Khuzhin
b7f92454bf
Move LineReader/ReplxxLineReader out from base
...
This will simplify linking dependencies, and anyway this classes are not
base in any sense.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 14:23:51 +01:00
Azat Khuzhin
83cad3625b
Remove unused setTerminalEcho()
...
It had been replaced with readpassphrase in #5092
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 14:23:51 +01:00
Azat Khuzhin
4d17510fca
Use already written part of the query for fuzzy search (pass to skim)
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-26 14:52:38 +01:00
Yakov Olkhovskiy
a8cb29da4b
Merge branch 'master' into refactoring-ip-types
2022-12-21 23:56:24 -05:00
Azat Khuzhin
cf0e0436be
skim: do not panic if terminal is not available
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-14 21:01:48 +01:00
Azat Khuzhin
082f57c40d
clickhouse-client: rebind original non-fuzzy search to C-T
...
I decided to bind fuzzy to a regular C-R, so that everyone will notice
it, and keep an old behaviour for expect tests, or if someone do not
need fuzzy search (or want blasignly fast search, since skim is slightly
slower).
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-14 21:01:48 +01:00
Azat Khuzhin
82aaad61aa
Integrate skim into the client/local
...
Note, that it can the fail the client if the skim itself will fail,
however I haven't seen it panicd, so let's try.
P.S. about adding USE_SKIM into configure header instead of just compile
option for target, it is better, because it allows not to recompile lots
of C++ headers, since we have to add skim library as PUBLIC. But anyway
this will be resolved in a different way, but separatelly.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-14 20:57:41 +01:00
Azat Khuzhin
67fa185611
Revert "Builtin skim"
2022-12-14 17:17:19 +03:00
Alexey Milovidov
df17d1b71b
Merge branch 'master' into builtin-skim
2022-12-13 03:33:42 +03:00
Azat Khuzhin
9ed6aa0be1
Fix -Wshorten-64-to-32 on FreeBSD
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-12 08:05:28 +01:00
Azat Khuzhin
de58e9c02d
Integrate skim into the client/local
...
Note, that it can the fail the client if the skim itself will fail,
however I haven't seen it panicd, so let's try.
P.S. about adding USE_SKIM into configure header instead of just compile
option for target, it is better, because it allows not to recompile lots
of C++ headers, since we have to add skim library as PUBLIC.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-11 15:52:00 +01:00
Boris Kuschel
592c73e2c3
Merge branch 'master' into openssl_support
2022-12-09 20:21:22 -05:00
Yakov Olkhovskiy
0641066183
Merge branch 'master' into refactoring-ip-types
2022-12-08 11:12:05 -05:00
Antonio Andelic
b068119d27
Merge pull request #43498 from azat/client/improve-fuzzy-search
...
Improve fuzzy search in clickhouse-client/clickhouse-local
2022-12-08 14:07:52 +01:00
Boris Kuschel
cc3314acbe
Merge branch 'master' into openssl_support
2022-12-08 07:40:43 -05:00
Boris Kuschel
623f23f55d
OpenSSL cmake changes
2022-12-07 13:22:46 -05:00
Robert Schulze
3c1a721da4
Merge branch 'master' into hlee-s390x-wide-int-order
2022-12-04 18:47:00 +01:00
Yakov Olkhovskiy
77266ea754
cleanup
2022-11-29 17:34:16 +00:00
Yakov Olkhovskiy
b47cb522b5
revert StrongTypedef and fix test instead
2022-11-28 23:33:47 +00:00
Yakov Olkhovskiy
770b520ded
Merge branch 'master' into refactoring-ip-types
2022-11-28 08:50:19 -05:00
Robert Schulze
a00a020cfb
Merge pull request #42847 from ClibMouse/s390x_bit_cast
...
s390x datetime64 conversion fix
2022-11-28 11:45:43 +01:00
Yakov Olkhovskiy
c47f13afd5
explicit conversion for StrongTypedef
2022-11-26 03:36:01 +00:00
Azat Khuzhin
7a9adbc285
Escape shell arguments for fzf/skim
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-22 20:15:04 +01:00
Azat Khuzhin
59e647077d
Improve fuzzy search in clickhouse-client/clickhouse-local
...
I found few difference in sk/fzf and after this patch I think that it
should behave better.
So the following commands will be used by default:
- fzf --read0 --tac --tiebreak=index --height=30%
- sk --read0 --tac --tiebreak=-score --height=30%
Those two more or less allows true fuzzy reserve search.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-22 19:44:07 +01:00
Azat Khuzhin
14d4980e26
Fix repainting of the client prompt after fuzzy search
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-22 19:42:39 +01:00
Yakov Olkhovskiy
ac4b050644
style fix
2022-11-22 13:10:33 +00:00
Yakov Olkhovskiy
988b030bfd
bug fix, refactoring IPv6 to struct with overridden comparison
2022-11-22 12:57:19 +00:00
Suzy Wang
60119a97f7
fix build error
2022-11-17 20:38:22 -08:00
HarryLeeIBM
0133444433
Fix byte order issue of wide integer for s390x
2022-11-14 10:47:32 -08:00
Yakov Olkhovskiy
9aeebf3bdf
Merge branch 'master' into refactoring-ip-types
2022-11-14 09:21:54 -05:00
Yakov Olkhovskiy
4d144be39c
replace domain IP types (IPv4, IPv6) with native
2022-11-14 14:17:17 +00:00
Suzy Wang
f624143532
fix typo
2022-11-10 12:42:38 -08:00
Suzy Wang
84a8c02d78
Update typo and rm whitespaces
2022-11-10 12:32:40 -08:00
Raúl Marín
aaf8cc6ca8
Revert "Add global flags to base/ libraries"
...
This reverts commit 43e065c18e
.
2022-11-10 11:32:27 +01:00
Suzy Wang
73e5cd91c8
rm unnecessary include
2022-11-09 13:59:34 -08:00
Raúl Marín
39f4120655
Fix broken build
2022-11-09 13:21:59 +01:00
Raúl Marín
43e065c18e
Add global flags to base/ libraries
2022-11-09 11:24:20 +01:00
Suzy Wang
ba868801fa
Update as suggested
2022-11-08 20:51:35 -08:00
Raúl Marín
050f3ca7cf
Fix msan warning
2022-11-08 17:25:03 +01:00
Alexander Tokmakov
fc77d53db1
Merge pull request #43009 from azat/fix-tsan
...
Fix TSan errors (correctly ignore _exit interception)
2022-11-07 22:20:53 +03:00
Alexander Tokmakov
b4ecbbf224
Update safeExit.cpp
2022-11-07 21:07:09 +03:00