Commit Graph

1433 Commits

Author SHA1 Message Date
alexey-milovidov
a8d8eb6b28
Merge pull request #5921 from yandex/pvs-studio-fixes-4
A few fixes for PVS-Studio
2019-07-09 01:10:05 +03:00
Alexey Milovidov
f40b70884f Two more fixes for PVS-Studio 2019-07-08 05:14:32 +03:00
Alexey Milovidov
ac20c515ab Better code in unit tests 2019-07-08 04:58:31 +03:00
alexey-milovidov
d81ae49f2c
Merge pull request #5755 from 4ertus2/bugs
Fix wrong ColumnConst.isColumnNullable()
2019-07-03 02:06:07 +03:00
alexey-milovidov
c43dfce041
Merge pull request #5382 from abyss7/issue-5286
Add virtual columns to Kafka Engine tables
2019-07-01 21:30:09 +03:00
alexey-milovidov
bf8c154d3d
Merge pull request #5819 from CurtizJ/fix-segfault-ttl
Fix segfault in TTL merge with non-physical columns in block.
2019-07-01 20:28:26 +03:00
CurtizJ
ecf9feab9c remove extra semicolon 2019-07-01 17:09:22 +03:00
CurtizJ
c0a63801fc fix segfault in ttl merge with non-physical columns in block 2019-07-01 15:50:50 +03:00
chertus
5df4ad0f28 Merge branch 'master' into bugs 2019-07-01 14:49:01 +03:00
alexey-milovidov
106a2d0c0f
Merge pull request #4930 from yandex/tsan-miscellaneous
Miscellaneous changes
2019-07-01 11:11:53 +03:00
alexey-milovidov
5fb7bf6854
Update ParallelInputsProcessor.h 2019-07-01 03:15:14 +03:00
chertus
f19dee706a move IColumn.isColumnConst() outside of interface 2019-06-27 22:28:52 +03:00
Danila Kutenin
e67431e455 Use mimalloc instead of lfallocator 2019-06-27 18:13:19 +03:00
Ivan Lezhankin
61750d09d2 Commit offsets for SELECTing from Kafka table too 2019-06-20 15:34:25 +03:00
Ivan Lezhankin
9fd048cdbd Allow to select virtual columns in materialized view 2019-06-18 19:32:37 +03:00
Ivan Lezhankin
436052c67b Merge branch 'master' into issue-5286 2019-06-18 16:03:29 +03:00
Ivan Lezhankin
d907d8e8ca Commit offsets for SELECTing from Kafka table too 2019-06-17 19:27:18 +03:00
alesapin
e45d727e9d
Merge pull request #4558 from podshumok/distributred-timeout
Distributed and remote timeouts
2019-06-17 13:58:17 +03:00
Alexey Milovidov
8b87511e25 Namespace comments are unneeded according to the code style.
find dbms -name '*.h' -or -name '*.cpp' | xargs grep -l -P '}\s*//+\s*namespace\s*' | xargs sed -i -r -e 's/}\s*\/\/+\s*namespace\s*\w+/}/'
2019-06-13 13:37:13 +03:00
Ivan Lezhankin
b311984879 Merge remote-tracking branch 'upstream/master' into issue-5286 2019-06-03 17:19:09 +03:00
Konstantin Podshumok
f993ea6127 add timeouts to remote streams 2019-06-02 12:43:20 +03:00
Ivan Lezhankin
1eccbc39c5 Don't add virtual column to empty block 2019-05-28 00:01:24 +03:00
Yuriy
96e3574a06 Improvements of MySQL Wire Protocol 2019-05-26 09:52:29 +03:00
alexey-milovidov
461c4919d3
Merge pull request #5116 from PerformanceVision/send_header
Send a X-ClickHouse summary on the header for HTTP client with number of rows inserted
2019-05-25 20:20:35 +03:00
Alexey Milovidov
b94f2be154 Merge branch 'mysql' of https://github.com/yurriy/ClickHouse into yurriy-mysql 2019-05-25 17:14:57 +03:00
Ivan Lezhankin
646d6f3fb5 Fix order of destruction 2019-05-23 16:54:11 +03:00
Ivan Lezhankin
800854119e Add buffer callback to fill in virtual columns 2019-05-23 14:15:18 +03:00
Guillaume Tassery
77b7158cd8 Progress rename for total_rows and write_[rows|bytes] 2019-05-20 18:37:41 +07:00
alexey-milovidov
02937294ce
Merge pull request #5311 from azat-archive/SimpleAggregateFunction-Arena-fix
Fix SimpleAggregateFunction for String longer MAX_SMALL_STRING_SIZE
2019-05-19 13:12:38 +03:00
Azat Khuzhin
db274bf516
Allocates arena for SimpleAggregateFunction only if IAggregateFunction requires 2019-05-19 03:33:04 +03:00
Azat Khuzhin
4e8370b0b0
Fix SimpleAggregateFunction for String longer MAX_SMALL_STRING_SIZE
SimpleAggregateFunction do not pass arena to the
add_function -> getAddressOfAddFunction(), hence next crash happens:
  (gdb) bt
  #0  DB::Arena::alloc (size=64, this=0x0) at ../dbms/src/Common/Arena.h:124
  #1  DB::SingleValueDataString::changeImpl (this=0x7f97424a27d8, value=..., arena=0x0) at ../dbms/src/AggregateFunctions/AggregateFunctionMinMaxAny.h:274
  #2  0x0000000005ea5319 in DB::AggregateFunctionNullUnary<true>::add (arena=<optimized out>, row_num=<optimized out>, columns=<optimized out>, place=<optimized out>, this=<optimized out>) at ../dbms/src/AggregateFunctions/AggregateFunctionNull.h:43
  #3  DB::IAggregateFunctionHelper<DB::AggregateFunctionNullUnary<true> >::addFree (that=<optimized out>, place=<optimized out>, columns=<optimized out>, row_num=<optimized out>, arena=<optimized out>) at ../dbms/src/AggregateFunctions/IAggregateFunction.h:131
  #4  0x000000000679772f in DB::AggregatingSortedBlockInputStream::addRow (this=this@entry=0x7f982de19c00, cursor=...) at ../dbms/src/Common/AlignedBuffer.h:31
  #5  0x0000000006797faa in DB::AggregatingSortedBlockInputStream::merge (this=this@entry=0x7f982de19c00, merged_columns=..., queue=...) at ../dbms/src/DataStreams/AggregatingSortedBlockInputStream.cpp:140
  #6  0x0000000006798979 in DB::AggregatingSortedBlockInputStream::readImpl (this=0x7f982de19c00) at ../dbms/src/DataStreams/AggregatingSortedBlockInputStream.cpp:78
  #7  0x000000000622db55 in DB::IBlockInputStream::read (this=0x7f982de19c00) at ../dbms/src/DataStreams/IBlockInputStream.cpp:56
  #8  0x0000000006613bee in DB::MergeTreeDataMergerMutator::mergePartsToTemporaryPart (this=this@entry=0x7f97ec65e1a0, future_part=..., merge_entry=..., time_of_merge=<optimized out>, disk_reservation=<optimized out>, deduplicate=<optimized out>) at /usr/include/c++/8/bits/shared_ptr_base.h:1018
  #9  0x000000000658f7a4 in DB::StorageReplicatedMergeTree::tryExecuteMerge (this=0x7f97ec65b810, entry=...) at /usr/include/c++/8/bits/unique_ptr.h:342
  #10 0x00000000065940ab in DB::StorageReplicatedMergeTree::executeLogEntry (this=0x7f97ec65b810, entry=...) at ../dbms/src/Storages/StorageReplicatedMergeTree.cpp:910
  <snip>

  (gdb) f 1
  (gdb) p MAX_SMALL_STRING_SIZE
  $1 = 48
  (gdb) p capacity
  $2 = 64
  (gdb) p value
  $3 = {data = 0x7f97242fcbd0 "HHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH", size = 61}

v2: avoid leaking of allocated by Arena memory on the intermediate step

Fixes: 8f8d2c048e ("Merge pull request #4629 from bgranvea/simple_aggregate_function")
2019-05-19 03:32:55 +03:00
alexey-milovidov
fa4a7eb3d1
Merge branch 'master' into merge-itable-istorage 2019-05-18 00:37:12 +03:00
Ivan Lezhankin
dcff73c8d4 Fix build 2019-05-17 21:45:42 +03:00
Ivan Lezhankin
0821d62516 Merge ITableDeclaration into IStorage.
Also a couple of massive include-refactorings with better forwarding
2019-05-17 17:34:25 +03:00
Artem Zuikov
4eee10d788
Merge pull request #5271 from 4ertus2/some
Cache ExpressionBlockInputStream header
2019-05-17 13:14:22 +03:00
chertus
927557b0f8 move caching to ctor 2019-05-16 20:16:25 +03:00
Yuriy
0cd3094240 fixed stack buffer overflow 2019-05-16 20:15:43 +03:00
Yuriy
a51c293ec6 merged 'origin/master' into mysql 2019-05-16 14:19:05 +03:00
Yuriy
4ee84810b0 including information about query execution in response 2019-05-16 08:36:08 +03:00
Yuriy
459ec05828 fixed style 2019-05-16 06:45:17 +03:00
Yuriy
ff4937859e added MySQL wire protocol presentational format 2019-05-16 06:34:04 +03:00
chertus
4a5e2dfd3c cache ExpressionBlockInputStream header 2019-05-14 21:26:19 +03:00
Ivan
4a5832b18a
Check the time limit every (flush_interval / poll_timeout) number of rows from Kafka (#5249) 2019-05-14 18:52:03 +03:00
alexey-milovidov
8f8d2c048e
Merge pull request #4629 from bgranvea/simple_aggregate_function
SimpleAggregateFunction data type
2019-05-09 18:45:59 +03:00
Alexey Milovidov
1be21e3cb6 Removed bad and useless code in ColumnsDescription 2019-05-02 00:43:05 +03:00
CurtizJ
7766f5c0c3 added offset for limit by 2019-04-29 16:12:39 +03:00
Alexey Milovidov
58d7d1e451 Resolved some of PVS-Studio warnings 2019-04-22 19:07:09 +03:00
alesapin
faeb95cfd7
Merge branch 'master' into adaptive_index_granularity 2019-04-15 19:36:36 +03:00
Anton Popov
7f93f9ad2f TTL for columns and tables (#4212)
Add TTL for columns and tables.
2019-04-15 12:30:45 +03:00
Danila Kutenin
622b2c8472 Enable LFAlloc for MarkCache and UncompressedCache 2019-04-13 15:07:43 +03:00