Commit Graph

41283 Commits

Author SHA1 Message Date
Azat Khuzhin
a96067987e Mark joinGet() as non deterministic (so as dictGet)
joinGet() should not be considered as deterministic function, since
shards could have different data in tables.

Also since now there is allow_nondeterministic_mutations, it could be
used as a workaround for this backward incompatible change.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-13 08:12:53 +02:00
Robert Schulze
b9c185af44
Merge pull request #49678 from azat/build/llvm-16
Switch to LLVM/clang 16 (16.0.3)
2023-05-12 13:47:36 +02:00
Antonio Andelic
e0a3ac41b0
Merge pull request #49776 from azat/settings-aliases
Fix settings aliases in native protocol
2023-05-12 13:30:16 +02:00
Anton Popov
3351ef7398
Merge pull request #49789 from CurtizJ/fix-array-map-tuple
Fix `arrayMap` with array of tuples with single argument
2023-05-12 13:27:40 +02:00
Igor Nikonov
5513c74c96
Merge pull request #49677 from ClickHouse/enable-distinct-in-order
Enable distinct in order after fix #49636
2023-05-12 13:21:09 +02:00
Sema Checherinda
a1ee7d52e1
Merge pull request #49432 from CheSema/lost-blobs
all s3-blobs removed when merge aborted, remove part from failed fetch without unlock keper
2023-05-12 13:19:27 +02:00
alesapin
d147cb105c
Merge pull request #49755 from CurtizJ/fix-unit-test
Fix unit test `ExceptionFromWait`
2023-05-12 13:08:48 +02:00
Sema Checherinda
5706e05757 adding more comments 2023-05-12 13:00:56 +02:00
vdimir
94bfb1171d
Merge pull request #49784 from ClickHouse/vdimir/analyzer_prewhere_and_sample 2023-05-12 12:25:36 +02:00
Alexander Gololobov
7c7565f094
Merge pull request #49737 from ClickHouse/fix_lwd_and_object
Ignore LWD column in checkPartDynamicColumns
2023-05-12 12:20:07 +02:00
Han Fei
07341a04fd
Merge pull request #49666 from hanfei1991/hanfei/regexp-dict-read
Support `dictionary` table function for `RegExpTreeDictionary`
2023-05-12 11:40:46 +02:00
Nikita Mikhaylov
66badcd59c
Merge pull request #49725 from vitlibar/incremental-backup-append-table-def
Fix writing appended files to incremental backups
2023-05-12 11:37:49 +02:00
Robert Schulze
922420420c
Merge pull request #49300 from ClickHouse/rs/functdocs
Introduce more fields for in-source function documentation
2023-05-12 11:36:04 +02:00
Robert Schulze
d15f19912f
Merge pull request #49198 from ClibMouse/s390x_reinterpretas_fix
Fix reinterpretAs*() on big endian machines
2023-05-12 10:33:50 +02:00
Azat Khuzhin
9c42f7f113 Fix settings aliases in native protocol
The initial test (tests/queries/0_stateless/02539_settings_alias.sh)
works only because of the clickhouse-client, while in native protocol
aliases does not work.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-12 05:56:32 +02:00
Alexey Milovidov
76f7f5750d
Merge pull request #49799 from rschu1ze/demange
Typo: demange.cpp --> demangle.cpp
2023-05-12 02:01:49 +03:00
Vitaly Baranov
c4036b8361
Merge pull request #49381 from ClickHouse/user-grants-from-config
Specify grants for users in `users.xml`
2023-05-12 00:15:52 +02:00
Kseniia Sumarokova
f5b959624d
Merge pull request #49733 from ClickHouse/nickitat-patch-11
Do not allocate own buffer in CachedOnDiskReadBufferFromFile when `use_external_buffer == true`
2023-05-12 00:05:25 +02:00
Kseniia Sumarokova
41fa0a54e8
Merge pull request #49729 from kssenii/minor-change-move-log
Move assertions after logging
2023-05-11 23:47:26 +02:00
Robert Schulze
8ca804d40e
Typo: demange.cpp --> demangle.cpp 2023-05-11 21:32:12 +00:00
Vitaly Baranov
478140f8b4 Fix LimitSeekableReadBuffer. 2023-05-11 22:58:05 +02:00
Alexey Milovidov
ea979b40a9
Merge pull request #49717 from ClickHouse/disable-mmap-for-server
Disable mmap for StorageFile in clickhouse-server
2023-05-11 23:53:01 +03:00
Han Fei
ef74e64336 address comments 2023-05-11 22:18:08 +02:00
Suzy Wang
70db49cdeb
Merge branch 'master' into s390x_reinterpretas_fix 2023-05-11 14:41:57 -04:00
Robert Schulze
8997c6ef95
Merge pull request #49750 from ClickHouse/rs/msan-randomStringUTF8
Fix msan issue in randomStringUTF8(<uneven number>)
2023-05-11 18:49:12 +02:00
Vitaly Baranov
ec011b9113
Merge branch 'master' into user-grants-from-config 2023-05-11 17:08:06 +02:00
Anton Popov
292cfe12af
Merge branch 'master' into fix-unit-test 2023-05-11 16:56:21 +02:00
Anton Popov
84aa97b738 fix arrayMap with array of tuples with single argument 2023-05-11 14:52:01 +00:00
Azat Khuzhin
e5c4eb35e8 Merge remote-tracking branch 'u/master' into build/llvm-16
* u/master:
  enable used flags's reinit only when the hash talbe rehash
  Fix build of libfiu on clang-16
  fix flaky test 02504_regexp_dictionary_ua_parser
  fix convertation
  Fix test that expected CH to apply a wrong optimization
  ActionsDAG: remove wrong optimization
2023-05-11 16:32:25 +02:00
Azat Khuzhin
00fdfa115f Suppress MSan warning in NgramDistanceImpl::unrollLowering()
NgramDistanceImpl::unrollLowering() relies on the fact that PODArray has
padding and it is OK to access more items.

Here is an MSan report:

    ==656==WARNING: MemorySanitizer: use-of-uninitialized-value
        0 0x557fd825485f in DB::NgramDistanceImpl<4ul, char8_t, false, true, false>::vectorConstant(DB::PODArray<char8_t, 4096ul, Allocator<false, false>, 63ul, 64ul> const&, DB::PODArray<unsigned long, 4096ul, Allocator<false, false>, 63ul, 64ul> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, DB::PODArray<float, 4096ul, Allocator<false, false>, 63ul, 64ul>&) (/usr/bin/clickhouse+0x124d885f) (BuildId: 76773125d8739591c75d4f4d263a2ffe7ca96855)
        1 0x557fd824eb83 in DB::FunctionsStringSimilarity<DB::NgramDistanceImpl<4ul, char8_t, false, true, false>, DB::NameNgramSearchCaseInsensitive>::executeImpl(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName>> const&, std::__1::shared_ptr<DB::IDataType const> const&, unsigned long) const (/usr/bin/clickhouse+0x124d2b83) (BuildId: 76773125d8739591c75d4f4d263a2ffe7ca96855)
        2 0x557fd50023b7 in DB::FunctionToExecutableFunctionAdaptor::executeImpl() const (/usr/bin/clickhouse+0xf2863b7) (BuildId: 76773125d8739591c75d4f4d263a2ffe7ca96855)

      Uninitialized value was stored to memory at
        0 0x557fd4f8da5a in __msan_memcpy (/usr/bin/clickhouse+0xf211a5a) (BuildId: 76773125d8739591c75d4f4d263a2ffe7ca96855)
        1 0x557fd8253803 in DB::NgramDistanceImpl<4ul, char8_t, false, true, false>::vectorConstant(DB::PODArray<char8_t, 4096ul, Allocator<false, false>, 63ul, 64ul> const&, DB::PODArray<unsigned long, 4096ul, Allocator<false, false>, 63ul, 64ul> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, DB::PODArray<float, 4096ul, Allocator<false, false>, 63ul, 64ul>&) (/usr/bin/clickhouse+0x124d7803) (BuildId: 76773125d8739591c75d4f4d263a2ffe7ca96855)
        2 0x557fd824eb83 in DB::FunctionsStringSimilarity<DB::NgramDistanceImpl<4ul, char8_t, false, true, false>, DB::NameNgramSearchCaseInsensitive>::executeImpl(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName>> const&, std::__1::shared_ptr<DB::IDataType const> const&, unsigned long) const (/usr/bin/clickhouse+0x124d2b83) (BuildId: 76773125d8739591c75d4f4d263a2ffe7ca96855)
        3 0x557fd50023b7 in DB::FunctionToExecutableFunctionAdaptor::executeImpl() const (/usr/bin/clickhouse+0xf2863b7) (BuildId: 76773125d8739591c75d4f4d263a2ffe7ca96855)

      Uninitialized value was stored to memory at
        0 0x557fd4f8da5a in __msan_memcpy (/usr/bin/clickhouse+0xf211a5a) (BuildId: 76773125d8739591c75d4f4d263a2ffe7ca96855)
        1 0x5580061699f5 in detail::memcpySmallAllowReadWriteOverflow15Impl(char*, char const*, long) build_docker/./src/Common/memcpySmall.h:42:13
        2 0x5580061699f5 in memcpySmallAllowReadWriteOverflow15(void*, void const*, unsigned long) build_docker/./src/Common/memcpySmall.h:57:5
        3 0x5580061699f5 in DB::ColumnString::replicate(DB::PODArray<unsigned long, 4096ul, Allocator<false, false>, 63ul, 64ul> const&) const build_docker/./src/Columns/ColumnString.cpp:462:13
        4 0x558005d3fae4 in DB::ColumnConst::convertToFullColumn() const build_docker/./src/Columns/ColumnConst.cpp:48:18

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-11 16:30:17 +02:00
vdimir
fd7374fbc5
Analyzer: fix column not found for optimized prewhere with sample by 2023-05-11 12:38:46 +00:00
SmitaRKulkarni
9bf6175919
Merge pull request #47584 from aiven-sal/aiven-sal/having_pr
ActionsDAG: fix wrong optimization
2023-05-11 14:03:46 +02:00
Kseniia Sumarokova
183b4be796
Merge branch 'master' into nickitat-patch-11 2023-05-11 13:57:33 +02:00
Igor Nikonov
9865d7c7ec
Merge branch 'master' into enable-distinct-in-order 2023-05-11 13:49:55 +02:00
Han Fei
6b3160f7ce trivial change 2023-05-11 13:49:02 +02:00
Sema Checherinda
98769bb433
Merge pull request #49749 from CheSema/convertations_to_timespan
fix convertation
2023-05-11 12:11:16 +02:00
Robert Schulze
9db78792d0
Fix MsgPackRowInputFormat.cpp build 2023-05-11 10:00:32 +00:00
Robert Schulze
c2a4d89b6f
Fix style 2023-05-11 09:29:05 +00:00
Robert Schulze
1f3b1c47af
Merge branch 'master' into rs/msan-randomStringUTF8 2023-05-11 10:34:00 +02:00
Alexander Gololobov
1a91b6293d
Merge branch 'master' into fix_lwd_and_object 2023-05-11 09:39:57 +02:00
Sema Checherinda
8470aa8fbb
Merge branch 'master' into convertations_to_timespan 2023-05-11 08:24:40 +02:00
Sema Checherinda
66e3712dca
Merge branch 'master' into lost-blobs 2023-05-11 08:23:25 +02:00
Sema Checherinda
9724688608 rename field, do not fetch PreActive 2023-05-11 08:22:37 +02:00
Alexey Milovidov
cfd3f76217
Merge branch 'master' into disable-mmap-for-server 2023-05-11 06:17:32 +03:00
lgbo-ustc
a07359fbe8 enable used flags's reinit only when the hash talbe rehash 2023-05-11 11:06:13 +08:00
Alexey Milovidov
91ffe8be73
Merge branch 'master' into build/llvm-16 2023-05-11 05:38:40 +03:00
Alexey Milovidov
3591eab432
Merge pull request #49762 from ClickHouse/fix-typo-10
Fix typo
2023-05-11 05:16:25 +03:00
Alexey Milovidov
aed031c3a3 Fix typo 2023-05-11 04:15:54 +02:00
Anton Popov
db52652337 fix unit test 2023-05-10 21:00:56 +00:00
Suzy Wang
d267c914c3
Merge branch 'master' into s390x_reinterpretas_fix 2023-05-10 16:08:50 -04:00