Commit Graph

27017 Commits

Author SHA1 Message Date
alexey-milovidov
7aefaf5ff1
Merge pull request #9845 from ClickHouse/fix_delta_test_unbundled
Fix delta test in unbundled mode
2020-03-24 21:58:28 +03:00
Azat Khuzhin
5039b6ab73 Fix Distributed engine with virtual columns of the underlying table in WHERE
Before storage has not been passed to the SyntaxAnalyzer and hence
it cannot check if there is such column and throw for virtual columns
like _part (MergeTree) and others.

Follow-up-for: #8846
2020-03-24 21:07:20 +03:00
Azat Khuzhin
dcf4d5198f Accept const IStorage in SyntaxAnalyzer 2020-03-24 21:06:55 +03:00
Azat Khuzhin
580a7c9f41 Use overload over default value for IStorage::getQueryProcessingStage()
Since clang-tidy complains about it [1]:

    2020-03-24 09:00:53 /build/obj-x86_64-linux-gnu/../dbms/src/Storages/StorageMerge.cpp:139:42: error: default arguments on virtual or override methods are prohibited [google-default-arguments,-warnings-as-errors]
    2020-03-24 09:00:53 QueryProcessingStage::Enum StorageMerge::getQueryProcessingStage(const Context & context, const ASTPtr & query_ptr) const

  [1]: https://clickhouse-builds.s3.yandex.net/9808/b8614de64af3e65c83ee35588082df373959a737/build_log_637307151_1585043194.txt

And indeed, this is a good idea!
2020-03-24 21:00:57 +03:00
Alexey Milovidov
0b4e601d81 Whitespace 2020-03-24 20:27:58 +03:00
Vasily Nemkov
d0e23a503e Fixed formatDateTime handling explicit timezone argument.
Updated reference of the 00921_datetime64_compatibility, issues caused
by Date implicitly using server's timezone (and I was not in GMT+3) at
the moment of updating tests.
2020-03-24 19:58:24 +03:00
alesapin
822fea0405 Fix delta test in unbundled mode 2020-03-24 19:53:12 +03:00
Anton Popov
b12bf5758e Merge remote-tracking branch 'upstream/master' into tuple-literal 2020-03-24 18:11:27 +03:00
Anton Popov
c1291e9348 tuple as literal 2020-03-24 15:55:35 +03:00
Nikolai Kochetov
778be3174a Fix pvs warnings. 2020-03-24 15:32:33 +03:00
Nikolai Kochetov
5400ffbf93 Update weak hash. 2020-03-24 14:38:41 +03:00
Nikolai Kochetov
08a9486cfc Update weak hash. 2020-03-24 14:38:05 +03:00
Nikolai Kochetov
07b29453cc Update weak hash. 2020-03-24 14:29:55 +03:00
Nikolai Kochetov
20d3e34fb0 Update weak hash. 2020-03-24 14:02:16 +03:00
Nikolai Kochetov
488b21cd82 Update weak hash. 2020-03-24 14:01:15 +03:00
Nikolai Kochetov
67ed4d4cc3 Update weak hash. 2020-03-24 13:02:09 +03:00
Azat Khuzhin
b8614de64a Fix DISTINCT for Distributed and optimize_skip_unused_shards
In case of optimize_skip_unused_shards the getQueryProcessingStage() can
return QueryProcessingStage::WithMergeableState because the whole
cluster has multiple nodes, but optimize_skip_unused_shards can trim it
to 1 and in this case we need final merge that won't be done with
QueryProcessingStage::WithMergeableState only with
QueryProcessingStage::Complete.
2020-03-24 11:07:09 +03:00
Azat Khuzhin
0e925ff7ad Cover DISTINCT for Distributed with one shard (test from #9046)
v2: cover case when getQueryProcessingStage() returns Complete when it
should not (pointed by @alexey-milovidov in
https://github.com/ClickHouse/ClickHouse/pull/9808#issuecomment-602291996)
2020-03-24 11:07:09 +03:00
Vitaly Baranov
4576cf198e Fix calculating grants for introspection functions from the setting 'allow_introspection_functions'. 2020-03-24 11:03:09 +03:00
Azat Khuzhin
4707dd827a StorageDistributed: cleanup skipping unused shards 2020-03-24 10:58:34 +03:00
Azat Khuzhin
66ccbf5d11 Pass query to the IStorage::getQueryProcessingStage()
Will be used to return correct stage with optimize_skip_unused_shards.
2020-03-24 10:58:16 +03:00
alexey-milovidov
df19d6aac1
Merge pull request #9622 from PerformanceVision/dictionary_status
Bring dictionary status on native prometheus exporter
2020-03-24 09:44:01 +03:00
alexey-milovidov
c762a42f4b
Merge pull request #9815 from ClickHouse/taiyang-li-pr_add_auc
Merging arrayAUC
2020-03-24 09:36:13 +03:00
alexey-milovidov
25cf827365
Merge pull request #9759 from Vxider/distributed_insert_select
Distributed INSERT SELECT
2020-03-24 09:34:44 +03:00
alexey-milovidov
9f72c28035
Update InterpreterInsertQuery.cpp 2020-03-24 09:34:01 +03:00
alexey-milovidov
9a2760d914
Merge pull request #9673 from azat/processors-max_distributed_connections
Fix max_distributed_connections
2020-03-24 08:32:15 +03:00
Alexey Milovidov
9a41113bf4 Renamed tests 2020-03-24 08:25:17 +03:00
Alexey Milovidov
691d98ff34 Added another test 2020-03-24 08:14:48 +03:00
Alexey Milovidov
5a89fd0abc Added performance test 2020-03-24 08:06:35 +03:00
Alexey Milovidov
ff59a06298 Remove memory allocation in inner loop 2020-03-24 07:57:50 +03:00
Alexey Milovidov
df3159d8a8 Fix comment 2020-03-24 07:52:45 +03:00
Alexey Milovidov
ed18a6f0bc A fix in appreciation of UBSan 2020-03-24 07:51:58 +03:00
Alexey Milovidov
27f0b93237 Finally I managed to understand the code 2020-03-24 07:48:44 +03:00
Alexey Milovidov
77e5eb2864 Attempt to understand the code 2020-03-24 07:18:39 +03:00
Alexey Milovidov
4d55952d2e Remove useless code 2020-03-24 03:18:08 +03:00
alexey-milovidov
10b4b05379
Merge pull request #9812 from azat/force_optimize_skip_unused_shards-nested
Add force_optimize_skip_unused_shards_no_nested
2020-03-24 03:11:33 +03:00
alexey-milovidov
83aaba7e36
Merge pull request #9834 from ClickHouse/better_traces_in_clickhouse_test
Collect stack traces from system.stack_trace table
2020-03-24 03:10:42 +03:00
alexey-milovidov
bae9db10f3
Merge pull request #9823 from ClickHouse/fix-expression-transform-for-empty-totals
Fix Expression transform for empty totals.
2020-03-24 03:10:20 +03:00
alexey-milovidov
43b5519101
Merge pull request #9829 from amosbird/ci
more aggregation methods
2020-03-24 03:09:51 +03:00
alexey-milovidov
ebddd4f0ba
Merge pull request #9832 from ClickHouse/fix-tsan-report-system-stack-trace
Fix tsan report in system.stack_trace
2020-03-24 03:08:09 +03:00
alexey-milovidov
db55ad5309
Merge pull request #9827 from ClickHouse/remove_redundant_code_merge_tree
Remove redundant code from merge tree
2020-03-24 03:07:59 +03:00
alexey-milovidov
28aa3119a4
Merge pull request #8846 from azat/distributed-const-expr-eval
Evaluate constant expressions for optimize_skip_unused_shards
2020-03-24 03:07:42 +03:00
Alexey Milovidov
0d5ed94398 Fixed style 2020-03-24 03:05:05 +03:00
Alexey Milovidov
c59c52d81a Merge branch 'master' into taiyang-li-pr_add_auc 2020-03-24 03:04:34 +03:00
Artem Zuikov
0b6fdde9fc
minor test fix (#9835) 2020-03-24 01:44:29 +03:00
Amos Bird
0744606fc3
DROP VIEW support. (#9831) 2020-03-24 01:28:30 +03:00
Artem Zuikov
38cbf3e6f7
Fix JOIN rewriters inconsistency (#9830)
* fix join rewrites: inconsistent visitors
2020-03-24 01:23:31 +03:00
Nikolai Kochetov
c4370886b0 Update weak hash. 2020-03-23 23:59:36 +03:00
Nikolai Kochetov
6d63d4bc88 Update weak hash. 2020-03-23 23:48:46 +03:00
Nikolai Kochetov
ee907da84d Update weak hash. 2020-03-23 23:45:12 +03:00
Nikolai Kochetov
ad56da8961 Added comments. 2020-03-23 23:03:52 +03:00
Nikolai Kochetov
4cfdef4403 Fix style and suppress pvs varnings.] 2020-03-23 22:38:53 +03:00
Nikolai Kochetov
c0dea7b1b3 Fix test. 2020-03-23 22:33:36 +03:00
Azat Khuzhin
d019c4e3b3 Add force_optimize_skip_unused_shards_no_nested
force_optimize_skip_unused_shards_no_nested will disable
force_optimize_skip_unused_shards for nested Distributed tables.

Can be useful for multi-layred/bi-level sharding.
2020-03-23 22:30:54 +03:00
Nikolai Kochetov
9e105b877c Update intHash. 2020-03-23 22:21:15 +03:00
Nikolai Kochetov
3c31139db8 More tests. 2020-03-23 22:18:35 +03:00
alesapin
9c9ce0aa37
Update clickhouse-test 2020-03-23 21:17:07 +03:00
Nikolai Kochetov
0bd502f2a6 Update unit test. 2020-03-23 20:42:26 +03:00
Nikolai Kochetov
2e2272785a Update unit test. 2020-03-23 20:39:34 +03:00
Nikolai Kochetov
7582f6628c Update unit test. 2020-03-23 20:32:08 +03:00
alesapin
ebf3e7b9e4 Collect stack traces from system.stack_trace table 2020-03-23 20:30:52 +03:00
alexey-milovidov
1ee26193f0
Update StorageDistributed.cpp 2020-03-23 20:28:38 +03:00
Nikolai Kochetov
9ab6f6a0ff Update unit test. 2020-03-23 20:20:09 +03:00
Nikolai Kochetov
05fb1760a7 Update unit test. 2020-03-23 20:17:34 +03:00
Nikolai Kochetov
7f6dda4994 Update unit test. 2020-03-23 20:15:32 +03:00
Alexey Milovidov
e06b9d4c2f Fix tsan report in system.stack_trace 2020-03-23 19:25:21 +03:00
Nikolai Kochetov
1d94b8bfbd Merge branch 'master' into weak-hash 2020-03-23 19:22:46 +03:00
alexey-milovidov
857c39fe48
Merge pull request #9825 from ClickHouse/remove-garbage-system-tables
Remove some garbage from code of system.tables
2020-03-23 19:00:24 +03:00
alesapin
772c210184 Better name 2020-03-23 18:43:20 +03:00
Pavel Kovalenko
5375683f24
DiskS3 hardlinks optimal implementation (#9760)
* Optimal DiskS3 hardlinks implementation and new tests.

* Code style fixes.

* Minor fixed.

* Minor fixes.
2020-03-23 17:45:48 +03:00
Amos Bird
0f15dd2fab
more aggregation methods 2020-03-23 21:44:21 +08:00
alesapin
048a61695c Add comment 2020-03-23 16:40:14 +03:00
alesapin
b0578d3faa Remove accident change 2020-03-23 16:35:18 +03:00
alesapin
3a1e375b8a Remove atomic from bytes_size 2020-03-23 16:32:02 +03:00
Alexey Milovidov
a331f2c616 Remove some garbage from code of system.tables, part 1 2020-03-23 16:03:15 +03:00
Alexey Milovidov
ca1bb2fbde Fix flacky test #9813 2020-03-23 15:52:20 +03:00
Nikolai Kochetov
0b9c53ac7d Added test. 2020-03-23 15:48:10 +03:00
Nikolai Kochetov
d0067afa1f Fix Expression transform for empty totals. 2020-03-23 15:23:54 +03:00
alesapin
9cd283266e Better size calculation 2020-03-23 15:19:43 +03:00
Alexey Milovidov
958b695618 Merge branch 'master' into taiyang-li-pr_add_auc 2020-03-23 15:06:23 +03:00
alesapin
fd7be934bb Remove useless method and it's usages 2020-03-23 12:50:54 +03:00
Vxider
231e679710 update code style 2020-03-23 17:42:59 +08:00
alesapin
cfb098cca9 Fix bulk of flaky tests 2020-03-23 12:28:14 +03:00
alesapin
7fc1ce6ec7 Fix flacky 00806_alter_update test 2020-03-23 12:05:51 +03:00
Alexey Milovidov
98db9ee074 Merging arrayAUC 2020-03-23 07:44:49 +03:00
Vxider
a13b10a31c Merge branch 'master' of https://github.com/yandex/ClickHouse into distributed_insert_select 2020-03-23 12:15:30 +08:00
alexey-milovidov
c7863e1ac6
Clang Tidy, part 7 (#9799)
* Attempt to enable identifier naming check

* Attempt to enable identifier naming check, continue

* Progress on identifier names

* Adopt identifier names check

* Fixed error

* Merge with master

* Fixed build

* Fixed build

* Fixed build

* Fixed build

* Fixed build

* Fixed error

* Fixed error

* Fixed error
2020-03-23 05:12:31 +03:00
Alexey Milovidov
786ecbfeb8 Merge branch 'master' into taiyang-li-pr_add_auc 2020-03-23 04:44:39 +03:00
alexey-milovidov
3550f401ec
Merge pull request #9804 from azat/optimize_skip_unused_shards_type_mismatch
Fix SIGSEGV with optimize_skip_unused_shards when type cannot be converted
2020-03-23 02:06:58 +03:00
Vitaly Baranov
73d72fd1e2
Merge pull request #9517 from vitlibar/RBAC-7
RBAC-7
2020-03-23 00:03:53 +03:00
alexey-milovidov
06a8a421a2
Merge pull request #9739 from 4ertus2/ast
Rewrite multiple JOINs v2
2020-03-22 19:54:38 +03:00
Azat Khuzhin
7caf8c006d Fix SIGSEGV with optimize_skip_unused_shards when type cannot be converted 2020-03-22 19:45:36 +03:00
Azat Khuzhin
0204c3f9c7 Cover optimize_skip_unused_shards for types mismatch 2020-03-22 19:32:16 +03:00
Azat Khuzhin
b89de69345 Evaluate constant expressions for optimize_skip_unused_shards 2020-03-22 19:30:36 +03:00
Azat Khuzhin
622131fc85 Cover constant expression evaluation for optimize_skip_unused_shards
v2: remove key=xxHash64() that is covered by #9804
2020-03-22 14:55:43 +03:00
Vitaly Baranov
6839e15b67 Add tests for settings profiles. 2020-03-22 11:08:08 +03:00
Vitaly Baranov
9ca6af32ea Implement SQL to manage settings profiles. 2020-03-22 11:08:08 +03:00
Vitaly Baranov
49bf4ae375 Introduce SettingsProfile as a new access entity type. 2020-03-22 11:08:08 +03:00
Vitaly Baranov
18d5f63b31 Mass rename: AccessRightsContext -> ContextAccess, QuotaContext -> EnabledQuota, RoleContext -> EnabledRoles, and so on. 2020-03-22 11:08:08 +03:00
Vitaly Baranov
f1e9e3dec0 Improve access rights: KILL_MUTATION deleted, rights for corresponding ALTER commands are checked instead. 2020-03-22 11:08:08 +03:00
Vitaly Baranov
c1f5f8bc89 Improve access rights: SHOW splitted into SHOW_DATABASES, SHOW_TABLES, SHOW_COLUMNS, SHOW_DICTIONARIES, EXISTS deleted. 2020-03-22 11:08:08 +03:00
Vitaly Baranov
66172cc2eb Improve access rights: CREATE TABLE now implicitly enables CREATE VIEW, the same thing for DROP TABLE, ALTER TABLE, TRUNCATE_TABLE. 2020-03-22 11:08:08 +03:00
Vitaly Baranov
c7a10665d7 Remove non-partial revoke. 2020-03-22 11:08:08 +03:00
Vitaly Baranov
4af36ee5a4 Fix updating of the access rights after changing of the readonly setting. Remove non-const function Context::getSettingsRef(). 2020-03-22 11:08:08 +03:00
Vitaly Baranov
5eb79c2303 Cast "const char *" to StringRef is now implicit and constexpr. 2020-03-22 11:05:42 +03:00
alexey-milovidov
2fd4439e5f
Merge pull request #9761 from ClickHouse/remove-unused-code-thread-pool
Remove unused (obsolete) code from ThreadPool
2020-03-22 06:34:40 +03:00
Alexey Milovidov
75bf22e1f3 Fixed style 2020-03-22 05:52:44 +03:00
alexey-milovidov
3b7dc4d378
Merge pull request #9773 from achimbab/pr_funnel_strict_order
Add 'strict_order' option to windowFunnel()
2020-03-22 04:01:46 +03:00
alexey-milovidov
939e702bc6
Merge pull request #9606 from ClickHouse/alter_on_top_of_mutations_merge_tree
Non-blocking alter for vanilla merge tree
2020-03-22 03:56:25 +03:00
alexey-milovidov
03aa8d4cfd
Update AlterCommands.cpp 2020-03-22 03:56:10 +03:00
alexey-milovidov
46829a63f3
Update StorageMergeTree.cpp 2020-03-22 03:53:40 +03:00
alexey-milovidov
7a92428046
Update MutationCommands.h 2020-03-22 03:50:06 +03:00
Alexey Milovidov
1bfe312834 Removed leftovers 2020-03-21 19:43:31 +03:00
Artem Zuikov
d3b5620ad6 multiple_joins_rewriter_version = 1 2020-03-21 19:13:06 +03:00
Alexey Milovidov
59976318e4 Remove old performance-test tool 2020-03-21 16:23:17 +03:00
alexey-milovidov
5645c202e6
Merge pull request #9790 from amosbird/cg
Better cli client
2020-03-21 16:05:20 +03:00
alexey-milovidov
7a6e70c705
Merge pull request #9765 from ClickHouse/clang-tidy-5
Clang Tidy, part 5
2020-03-21 15:50:48 +03:00
alesapin
fbf73012d2 Fix integration test 2020-03-21 11:10:44 +03:00
philip.han
bf1aa44d19 Skip AggregateFunctionWindowFunnelData::merge() if other.events_list is empty. 2020-03-21 14:47:06 +09:00
Amos Bird
6fe1839f9e
Better cli client 2020-03-21 13:17:12 +08:00
Alexey Milovidov
a13f3f6d6e Fixed build 2020-03-21 08:00:53 +03:00
Alexey Milovidov
fea3ceca05 Fixed error; added a test 2020-03-21 05:52:37 +03:00
alexey-milovidov
6520b45588
Merge pull request #9784 from zlobober/expose_process_list_for_user_info
Expose ProcessListForUserInfo structure from ProcessList.
2020-03-21 01:36:22 +03:00
Artem Zuikov
27f59c73a2 enable new setting for CI and improve test 2020-03-20 22:18:42 +03:00
alesapin
20970f0ba7 Remove files from part correctly 2020-03-20 22:07:09 +03:00
Alexey Milovidov
8255547656 Added one more check 2020-03-20 21:53:35 +03:00
Alexey Milovidov
de5f559304 Fixed strange whitespaces 2020-03-20 21:53:35 +03:00
Alexey Milovidov
a0f2940cb1 Fixed error 2020-03-20 21:53:35 +03:00
Alexey Milovidov
a5e3d4efb7 Added most of clang-static-analyzer checks 2020-03-20 21:53:35 +03:00
Alexey Milovidov
3f13464e3d clang-tidy, part 5 2020-03-20 21:53:35 +03:00
alexey-milovidov
44cb1b8305
Merge pull request #9774 from ClickHouse/better_test
Fix 01045 test
2020-03-20 21:40:04 +03:00
alexey-milovidov
f624bed408
Merge branch 'master' into patch-0320 2020-03-20 21:36:14 +03:00
Azat Khuzhin
550cfef2ba Fix max_distributed_connections w/o Processors 2020-03-20 20:51:37 +03:00
Azat Khuzhin
b40eac426f Fix max_distributed_connections w/ Processors
With Processors max_distributed_connections does not used anymore, since
it always uses not more then max_threads (see
TCPHandler::processOrdinaryQueryWithProcessors()/
QueryPipeline::execute()/PipelineExecutor::execute())

So just use QueryPipeline::getNumThreads(), that takes
max_distributed_connections into account.
2020-03-20 20:51:37 +03:00
Azat Khuzhin
977849df5a Test for max_distributed_connections via HTTP 2020-03-20 20:51:37 +03:00
Azat Khuzhin
391054039e Test for max_distributed_connections (via TCP) 2020-03-20 20:51:37 +03:00
Azat Khuzhin
62b60a09a4 Add missing space in StorageDistributed logging (sharding key) 2020-03-20 20:51:37 +03:00
Nikolai Kochetov
46f63c1dd8 Fix weakHash 2020-03-20 20:31:05 +03:00
Nikolai Kochetov
0344978634 Fix weakHash 2020-03-20 20:28:45 +03:00
Maxim Akhmedov
f1e1934390 Expose ProcessListForUserInfo structure from ProcessList. 2020-03-20 20:27:17 +03:00
Artem Zuikov
ad8b579f3a fix clang-8 warning 2020-03-20 20:16:36 +03:00
Nikolai Kochetov
75192d44aa Fix weakHash 2020-03-20 20:05:04 +03:00
alesapin
2a533264e7 Correct merge with master (try 2) 2020-03-20 19:32:16 +03:00
alesapin
62f39b6f52 Correct merge with master 2020-03-20 19:28:41 +03:00
Nikolai Kochetov
ebba6a6100 Fix weakHash 2020-03-20 18:57:05 +03:00
Nikolai Kochetov
33db7f3988 Fix weakHash 2020-03-20 18:48:09 +03:00
Nikolai Kochetov
c4e73c10c9 Fix weakHash 2020-03-20 16:54:43 +03:00
Nikolai Kochetov
c9d808e509 Fix weakHash 2020-03-20 16:03:51 +03:00
alesapin
90c436f940 Fix style 2020-03-20 15:45:05 +03:00
Artem Zuikov
61dee9ffaa fix clang-8 warning 2020-03-20 15:36:35 +03:00