Commit Graph

58 Commits

Author SHA1 Message Date
Alexey Milovidov
ab78bc1b5c Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 07:13:15 +03:00
Alexey Milovidov
66afebc498 Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 06:40:15 +03:00
Alexey Milovidov
fc27be314b Avoid temporary nullptr references [#CLICKHOUSE-2] 2018-09-02 06:00:04 +03:00
Alexey Milovidov
a3cd1ea8cb Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 21:16:32 +03:00
Alexey Milovidov
486d87ebcd Merge remote-tracking branch 'origin/master' into extra-warnings 2018-08-27 20:01:33 +03:00
Amos Bird
ea84430864 Get rid of useless std::move to get NRVO
http://eel.is/c++draft/class.copy.elision#:constructor,copy,elision

Some quote:

> Speaking of RVO, return std::move(w); prohibits it. It means "use move constructor or fail to compile", whereas return w; means "use RVO, and if you can't, use move constructor, and if you can't, use copy constructor, and if you can't, fail to compile."

There is one exception to this rule:
```cpp
Block FilterBlockInputStream::removeFilterIfNeed(Block && block)
{
    if (block && remove_filter)
        block.erase(static_cast<size_t>(filter_column));

    return std::move(block);
}
```

because references are not eligible for NRVO, which is another rule "always move rvalue references and forward universal references" that takes precedence.
2018-08-27 22:15:48 +08:00
Alexey Milovidov
6779de62d1 Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 03:44:23 +03:00
Nikolai Kochetov
f56d16769b Added pre and post serialization for IDataType BinaryBulkWithMultipleStreams. Supported dictionary serialization format with single global dictionary (limited wit max_dictionary_size) and additional keys which are stored per granule. Changed IDataType::enumerateStream interface. Added (de)serialization params for binary bulk with multiple stream (de)serialization. Changed IColumn::index interface. 2018-06-26 17:12:21 +03:00
Nikolai Kochetov
8470a091bb added IColumn::select 2018-04-23 19:59:11 +03:00
Nikolai Kochetov
4aaf56d9a2 added IColumn::select 2018-04-23 19:55:26 +03:00
Nikolai Kochetov
2119469c51 added IColumn::select 2018-04-19 00:00:47 +03:00
Nikolai Kochetov
cc2c1f5171 removed createImmutable 2018-03-23 22:24:55 +03:00
Nikolai Kochetov
476d4b339c Immutable construction for columns 2018-03-20 22:45:10 +03:00
Alexey Milovidov
c897e5ca39 Better [#CLICKHOUSE-2] 2018-03-03 18:36:20 +03:00
Alexey Milovidov
15b5c27c1c Fixed error [#CLICKHOUSE-2] 2018-01-14 04:25:35 +03:00
Alexey Milovidov
d497d010d7 Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-17 08:21:04 +03:00
Alexey Milovidov
7284a64740 Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-16 00:32:25 +03:00
Alexey Milovidov
8ce60e3af0 Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-15 22:53:11 +03:00
Alexey Milovidov
0b76b61c73 Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-15 22:46:24 +03:00
Alexey Milovidov
9c9896c1a9 Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-15 22:17:15 +03:00
Alexey Milovidov
401fd2d6d8 Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-15 05:36:40 +03:00
Alexey Milovidov
fb38ef9a8e Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-14 06:56:56 +03:00
Alexey Milovidov
bed2d644e6 Merge remote-tracking branch 'origin/master' into cow_columns 2017-12-14 04:44:35 +03:00
Alexey Milovidov
f3bb24a3bf Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-14 04:43:19 +03:00
Alexey Milovidov
f68cf599e6 Removed unused method [#CLICKHOUSE-2] 2017-12-13 22:55:16 +03:00
Alexey Milovidov
0b8688e89b Better semantic of sharing columns: development [#CLICKHOUSE-2]. 2017-12-13 22:14:12 +03:00
Alexey Milovidov
de75e40528 Clarifications [#CLICKHOUSE-2]. 2017-12-11 00:05:21 +03:00
Alexey Milovidov
ae2e250bc2 Modified comment [#CLICKHOUSE-2]. 2017-12-09 20:40:31 +03:00
Alexey Milovidov
3def5f03f5 Cleanup semantics of data types [#CLICKHOUSE-2]. 2017-12-09 19:17:37 +03:00
Alexey Milovidov
741a6e0066 Simplification of Nullable [#CLICKHOUSE-2] 2017-12-08 03:50:25 +03:00
Alexey Milovidov
d9c87bf4df Simplification of Nullable [#CLICKHOUSE-2] 2017-12-08 01:11:51 +03:00
KochetovNicolai
83925f1d5e Fix array writing (#1314)
* changed MergedBlockOutputStream [#CLICKHOUSE-3341]

* fix build [#CLICKHOUSE-3341]

* fix build [#CLICKHOUSE-3341]

* fix build [#CLICKHOUSE-3341]

* fix build [#CLICKHOUSE-3341]

* fix build [#CLICKHOUSE-3341]

* fix build [#CLICKHOUSE-3341]

* fix build [#CLICKHOUSE-3341]

* fix build [#CLICKHOUSE-3341]

* fix build [#CLICKHOUSE-3341]

* disabled checkNoMultidimensionalArrays [#CLICKHOUSE-3341]

* fix IMergedBlockOutputStream::writeDataImpl [#CLICKHOUSE-3341]

* fix IMergedBlockOutputStream::writeDataImpl [#CLICKHOUSE-3341]

* fix IMergedBlockOutputStream::writeDataImpl [#CLICKHOUSE-3341]

* fix IMergedBlockOutputStream::writeDataImpl [#CLICKHOUSE-3341]

* added test [#CLICKHOUSE-3341]

* fixed test [#CLICKHOUSE-3341]

* refactoring and comments [#CLICKHOUSE-3341]

* fix build [#CLICKHOUSE-3341]

* Update ColumnArray.h
2017-10-12 23:13:26 +03:00
Alexey Zatelepin
bfd87add7d improve getExremes(), fix for ColumnNullable [#CLICKHOUSE-2] 2017-09-26 20:40:02 +03:00
Alexey Zatelepin
ceddecbc10 implement missing getExtremes() functions [#CLICKHOUSE-3000] 2017-09-26 20:40:02 +03:00
Alexey Milovidov
2af8747164 Removed obsolete code [#CLICKHOUSE-3270]. 2017-09-01 21:21:01 +03:00
Alexey Milovidov
3502d36d7d Fixed build [#CLICKHOUSE-2]. 2017-07-28 02:23:13 +03:00
alexey-milovidov
d4d266fa18 ColumnConst unification (#1011)
* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* Fixed error in ColumnArray::replicateGeneric [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].

* ColumnConst: unification (incomplete) [#CLICKHOUSE-3150].
2017-07-21 09:35:58 +03:00
Nikolai Kochetov
75be0b81d8 removed typeid_cast from IColumn.h 2017-07-13 23:58:19 +03:00
Nikolai Kochetov
5d1f4355a1 fixed allocated size calculation for ColumnArray 2017-07-13 19:53:34 +03:00
Nikolai Kochetov
985e449bd3 added IDataType::updateAvgValueSizeHints; renamed PODArray::allocated_size to PODArray::allocated_bytes; renamed renamed IColumn::allocatedSize to IColumn::allocatedBytes; removed IColumn.h from IDataType.h 2017-07-13 19:49:09 +03:00
Alexey Zatelepin
1cd936579d introduce IColumn::gather() [#CLICKHOUSE-3118] 2017-07-09 21:57:06 +03:00
Alexey Milovidov
22e8b8029b Implemented ColumnArray::replicate for Nullable, Tuple and for generic case [#CLICKHOUSE-4]. 2017-04-18 06:03:39 +03:00
Alexey Milovidov
310736cd7e Moved headers and sources to same place [#CLICKHOUSE-3]. 2017-04-01 12:22:42 +03:00
Alexey Milovidov
137ad95929 Changed tabs to spaces in code [#CLICKHOUSE-3]. 2017-04-01 11:35:09 +03:00
f1yegor
bc0d9a2cae translate comments 2017-03-25 21:12:56 +01:00
Alexey Milovidov
7532a1d564 Added support for NULLS FIRST and LAST in ORDER BY [#CLICKHOUSE-2882]. 2017-03-12 15:56:59 +03:00
Alexey Milovidov
ef3e44e1bc Comments [#CLICKHOUSE-2881]. 2017-03-12 07:18:17 +03:00
Alexey Milovidov
f15efc4e63 Fixed error [#CLICKHOUSE-2877]. 2017-03-11 04:25:27 +03:00
Alexey Milovidov
caebb93995 Merge remote-tracking branch 'origin/master' into if-support-nulls
Conflicts:
	dbms/include/DB/Columns/ColumnArray.h
	dbms/include/DB/Columns/ColumnString.h
	dbms/include/DB/Functions/FunctionsMiscellaneous.h
2017-03-09 07:39:45 +03:00
Alexey Milovidov
f9a5902e76 Support for NULLs in function if: continued [#CLICKHOUSE-2873]. 2017-03-09 06:34:09 +03:00