Commit Graph

29 Commits

Author SHA1 Message Date
Maksim Kita
51477adf1b Updated additional cases 2021-12-20 15:55:07 +03:00
Azat Khuzhin
017dc9fa2a Remove unused ILLEGAL_AGGREGATION from AggregateFunctionIf 2021-09-11 00:48:17 +03:00
Azat Khuzhin
60df1e8800 Relax nested function for If-combinator check
Second If combinator can be useful to add condition based on another
column, when Merge combinator is applied for example (i.e.
uniqCombinedIfMergeIf(state_of_merge_that_is_stored_in_table, event_date = today())).
2021-09-10 21:03:24 +03:00
Raúl Marín
d3d8d4eae6 PVS Studio 2021-08-30 19:37:54 +02:00
Raúl Marín
92799f6cff Make gcc happy 2021-08-30 19:09:04 +02:00
Raúl Marín
11d242cf7d If: Check if work is necessary and combine flags 2021-08-30 14:28:09 +02:00
Raúl Marín
5ad8e93458 Speedup sumIf with Nullable types 2021-08-30 10:54:49 +02:00
Nickita Taranov
3b13b79d65 throw in AggregateFunctionCombinatorIf instead 2021-08-16 12:10:51 +03:00
Alexander Tokmakov
5c9f69ea17 fix parameters with combinators 2021-07-26 17:37:47 +03:00
Maksim Kita
577e69898a Compile aggregate functions perf tests fix 2021-07-05 12:17:01 +03:00
Maksim Kita
97e1ddbe94 Fix before merge 2021-07-01 22:56:36 +03:00
Maksim Kita
39ca0ceb81 Fixed tests 2021-07-01 22:56:36 +03:00
Maksim Kita
e67198c144 Compile AggregateFunctionIfNull 2021-07-01 22:56:36 +03:00
Maksim Kita
507d9405e2 Compile AggregateFunctionAvgWeighted 2021-07-01 22:56:36 +03:00
Alexey Milovidov
e275fc9c29 Fix trash 2021-06-07 03:15:11 +03:00
Vladimir
fc15cad7e0
Pass Settings to aggregate function creator 2021-05-26 14:58:31 +03:00
Vladimir
7224e25156
Revert "Pass Settings to aggregate function creator" 2021-05-26 14:46:42 +03:00
vdimir
a2f1bde5cc
Pass Settings to all aggregate function creator 2021-04-15 13:39:59 +03:00
Alexey Milovidov
349d783089 Improve performance of aggregate functions 2021-02-01 20:12:12 +03:00
Azat Khuzhin
fdcfacda60 Fix *If combinator with Nullable types
sumIf(Nullable()) and similar unary functions (unary w/o If combinator)
was working incorrectly, since it returns "sum" from the getName()
helper, and so distributed query processing fails.

The problem is in the optimization in
AggregateFunctionIfNullUnary::add() for the unary functions. It pass
only one column to write result to, instead of all passed arguments +
result columns.
While AggregateFunctionIf::add() assumes that it accepts arguments  +
result columns, and use last column as a result.

Introduced-in: #16610
Fixes: #18210
2021-01-07 03:09:13 +03:00
zhang2014
1726fb0f4e ISSUES-16574 try fix test failure 2020-11-09 12:40:28 +08:00
zhang2014
869578f072 ISSUES-16574 try fix if suffix agg function with remote query 2020-11-02 23:57:14 +08:00
zhang2014
66b852cf69 Revert "Revert "Try fix IfAggCombinator with NullAggCombinator""
This reverts commit 962a89843c.
2020-11-02 23:55:32 +08:00
Nikolai Kochetov
962a89843c
Revert "Try fix IfAggCombinator with NullAggCombinator" 2020-11-02 12:01:57 +03:00
Winter Zhang
75af61ea95
Try fix style failure 2020-08-24 18:51:54 +08:00
zhang2014
63868aaed3 Try fix CI 2020-08-24 13:05:59 +08:00
zhang2014
0e8cb96eb1 Try fix IfAggCombinator with NullAggCombinator 2020-08-22 22:57:46 +08:00
Alexey Milovidov
394fb64a9c Better way of implementation 2020-06-14 20:42:11 +03:00
Ivan Lezhankin
06446b4f08 dbms/ → src/ 2020-04-03 18:14:31 +03:00