Commit Graph

68540 Commits

Author SHA1 Message Date
Alexander Gololobov
95a36b9312
Merge pull request #72814 from ClickHouse/cancel_marks_load
Cancel async marks load task if it hasn't started
2024-12-05 18:47:10 +00:00
Vladimir Cherkasov
4b406e6dd7
Merge branch 'master' into bsearchfunction 2024-12-05 19:31:03 +01:00
vdimir
d20af6ca9a
fix stylecheck 2024-12-05 18:29:00 +00:00
Pavel Kruglov
613bbd4019
Merge branch 'master' into format-inference-load 2024-12-05 19:25:21 +01:00
avogar
ddae5dcf6c Merge branch 'master' of github.com:ClickHouse/ClickHouse into read-column-once-compact-subcolumns 2024-12-05 18:24:39 +00:00
Pavel Kruglov
03bc631cf2
Merge pull request #72454 from Avogar/fix-empty-variant
Don't allow creating empty Variant
2024-12-05 18:21:56 +00:00
avogar
10775ef3ec Merge branch 'master' of github.com:ClickHouse/ClickHouse into not-empty-json 2024-12-05 18:21:18 +00:00
Pavel Kruglov
ad66d84136
Merge pull request #72772 from Avogar/dynamic-ifnull-coalesce
Support Dynamic type in functions ifNull and coalesce
2024-12-05 18:18:56 +00:00
kssenii
13dbd31608 Fix backup/restore of empty file 2024-12-05 19:08:38 +01:00
Raúl Marín
f75cd514ab Another missing include 2024-12-05 18:53:33 +01:00
Mikhail Artemenko
55d6a7f603
Merge pull request #72593 from azat/config-zk-sync
Ensure that ClickHouse will see ZooKeeper changes on config reloads
2024-12-05 17:44:51 +00:00
Sema Checherinda
e26fb09d00
Merge pull request #72654 from ClickHouse/revert-72642-revert-72395-chesema-dtor-Finalizer
Revert "Revert "make d-tor Finalizer more obvious""
2024-12-05 16:40:14 +00:00
Anton Popov
d14b360ceb fix update of all columns in presence of _block_number column 2024-12-05 16:38:05 +00:00
Raúl Marín
f752c0b89d
Merge pull request #72836 from ClickHouse/revert-72770-more_insistent_compress_in_memory_eng
Revert "More insistent compression in `StorageMemory`"
2024-12-05 15:40:26 +00:00
Raúl Marín
a1d119e179
Merge pull request #72812 from Algunenano/siphash
Remove more nested includes
2024-12-05 15:12:50 +00:00
Anton Popov
96bb781805 devirtualize two calls and fix UB 2024-12-05 14:58:01 +00:00
vdimir
e7177a5192
Do not swap tables in join in case filter without index applied 2024-12-05 14:51:14 +00:00
Sema Checherinda
e5c424cf5f
Merge pull request #72587 from ClickHouse/chesema-fix-cancelation
fix pipeline cancelation
2024-12-05 14:11:30 +00:00
Raúl Marín
db3be9e6ec Missing includes and notes 2024-12-05 15:03:11 +01:00
Vladimir Cherkasov
d88f39c7e9
Merge pull request #67323 from kirillgarbar/ch-disks-remove
Reduce memory usage for removeSharedRecursive operation
2024-12-05 13:58:53 +00:00
avogar
1de568d72c Fix 2024-12-05 13:34:55 +00:00
avogar
dace4f705e Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-empty-variant 2024-12-05 13:26:53 +00:00
Alexander Tokmakov
d22174e3bf
Merge pull request #72685 from ClickHouse/rdb_fix_flatten_nested
Fix flatten_nested when recovering a Replicated database
2024-12-05 13:26:50 +00:00
Pavel Kruglov
41c16b71d6
Fix build 2024-12-05 14:19:57 +01:00
Pavel Kruglov
94184a3bef
Merge pull request #71784 from Avogar/object-to-json-alter
Support ALTER from Object to JSON
2024-12-05 13:18:57 +00:00
avogar
df04a39b97 Fix private 2024-12-05 13:16:48 +00:00
Igor Nikonov
077e62bd1b Merge remote-tracking branch 'origin/master' into pr-3-way-joins 2024-12-05 12:57:48 +00:00
Alexander Tokmakov
551605a46b
Merge pull request #70476 from azat/fix-possible-intersecting-parts-in-mt
Fix possible intersecting parts for MergeTree (after moving to detached failed)
2024-12-05 12:34:27 +00:00
Igor Nikonov
55b0810d67 Finding working baseline 2024-12-05 12:21:14 +00:00
Yarik Briukhovetskyi
c23182846a
Remove templates from GroupConcatData 2024-12-05 13:15:44 +01:00
Raúl Marín
ba517d6762
Revert "More insistent compression in StorageMemory" 2024-12-05 12:47:02 +01:00
Yarik Briukhovetskyi
88beb3667d
Merge branch 'ClickHouse:master' into try_fix_duplicating_aliases 2024-12-05 12:37:59 +01:00
Vitaly Baranov
2539983728
Fix segfault in CascadeWriteBuffer::getResultBuffers() 2024-12-05 12:09:36 +01:00
Vitaly Baranov
b51df5655c
Merge pull request #70597 from bigo-sg/toUnixTimestamp-fix
Add function toUnixTimestamp64Second
2024-12-05 10:59:55 +00:00
Miсhael Stetsyuk
4346ccb434
Merge pull request #72637 from ClickHouse/startup-scripts-execution-state
add `StartupScriptsExecutionState` metric
2024-12-05 10:43:04 +00:00
Alexander Gololobov
feb2edc057 Merge branch 'master' of github.com:ClickHouse/ClickHouse into cancel_marks_load 2024-12-05 11:39:16 +01:00
Raúl Marín
b7fed584fc Missing include 2024-12-05 10:26:03 +00:00
Daniil Ivanik
9f425ebe73
Merge pull request #69445 from ClickHouse/divanik/add_schema_evolution_concise
Make simple schema evolution for Iceberg data format
2024-12-05 10:22:55 +00:00
Vladimir Cherkasov
d1aec7c4a5
Merge pull request #72732 from bigo-sg/like-enum
Support string search operator for Enum data type
2024-12-05 08:35:49 +00:00
Emmanuel Dias
6c8512f126 address comments 2024-12-05 00:10:32 -03:00
zhanglistar
f5c635df35 fix clang-tidy build 2024-12-05 10:22:06 +08:00
Anton Popov
1ca206a09b
Merge pull request #72791 from primeroz/fciocchetti-fix-azure-list-trailing-slash
Make the List Blob Azure work regardless if the endpoint has a trailing slash or not
2024-12-05 00:38:06 +00:00
Anton Popov
933418c3eb improve performance of deserialization of aggregate functions 2024-12-05 00:29:01 +00:00
Sema Checherinda
7600f6031d output format do not write to the canceled buffer 2024-12-04 23:37:11 +01:00
Kseniia Sumarokova
777b016d6a
Merge pull request #72738 from ClickHouse/s3queue-avoid-no-such-key
Fix no-such-key in s3queue in certain case
2024-12-04 22:32:37 +00:00
Igor Nikonov
23767ef709 Merge remote-tracking branch 'origin/master' into pr-3-way-joins 2024-12-04 20:13:03 +00:00
Yarik Briukhovetskyi
9290e328ef
Minor changes. 2024-12-04 20:55:02 +01:00
Raúl Marín
1ba23db27c
Merge pull request #72694 from Algunenano/settings_checks
Add MergeTreeSettings to system.settings_changes
2024-12-04 19:22:26 +00:00
Raúl Marín
4e5a67b80c Fix style 2024-12-04 19:18:13 +00:00
Alexander Gololobov
d8f395c3de Cancel async marks load task if it hasn't started 2024-12-04 20:13:46 +01:00
Sema Checherinda
0a85fc6524 fix clickhouse_driver inserts 2024-12-04 20:05:46 +01:00
kssenii
cd254a6ee8 Remove useless setting 2024-12-04 19:41:32 +01:00
kssenii
c434a3f87a Support oauth_server_uri 2024-12-04 19:04:43 +01:00
Yarik Briukhovetskyi
35c0ea345f
Build fix + reviews 2024-12-04 18:15:19 +01:00
Yarik Briukhovetskyi
069f2439dc
Merge branch 'master' into try_fix_duplicating_aliases 2024-12-04 18:01:48 +01:00
Raúl Marín
89dbb42874 Remove more deps from SipHash 2024-12-04 17:51:51 +01:00
Azat Khuzhin
f1e909e309 Remove config_reload_sync_zookeeper (issue sync unconditionally)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-12-04 17:42:35 +01:00
Azat Khuzhin
86fb8f647f Read config_reload_sync_zookeeper only from the server config
Previously it had been read from each config, i.e. for users it should
be defined in users.xml/yaml.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-12-04 17:42:35 +01:00
Azat Khuzhin
ac0fb050f1 Add ability to sync ZooKeeper before reloading the config
Otherwise it is not deterministic wether ClickHouse will see this
change, i.e. if you created znode just before `SYSTEM RELOAD CONFIG` it
is not 100% that the ClickHouse will see it.

Refs: apache/zookeeper@8ee17324ce
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-12-04 17:42:35 +01:00
kssenii
03f44e8920 Merge remote-tracking branch 'origin/master' into disable-metadata-deletion-in-s3-queue 2024-12-04 17:41:26 +01:00
kssenii
7fc60d84cc Better deletion of keeper metadata in s3queue 2024-12-04 17:39:04 +01:00
Pavel Kruglov
136f5c482c
Fix style 2024-12-04 17:36:18 +01:00
Igor Nikonov
5902f3058d
Merge pull request #72706 from ClickHouse/pr-fix-setting-history
Align PR setting changes history with 24.10
2024-12-04 16:21:53 +00:00
Vitaly Baranov
2c68653d0a Add S3 request settings http_max_fields, http_max_field_name_size, http_max_field_value_size for parsing S3 API responses. 2024-12-04 16:41:12 +01:00
Raúl Marín
90a03e149a Remove deps from SipHash 2024-12-04 15:45:26 +01:00
Raúl Marín
fd4795c00f Remove some nested deps on SipHash 2024-12-04 15:45:26 +01:00
Raúl Marín
19bc382978 Remove some nested deps on SipHash 2024-12-04 15:45:26 +01:00
Alexander Gololobov
07512a0819
Merge pull request #72750 from ClickHouse/fix_pk_cache_size_calculation
More accurate PK in-memory size calculation for cache
2024-12-04 14:23:38 +00:00
Raúl Marín
e2b8186d4b Less instantiations 2024-12-04 15:00:00 +01:00
Raúl Marín
e41a018a5f Less nested includes 2024-12-04 15:00:00 +01:00
Raúl Marín
d585d2fe72 Less functions 2024-12-04 15:00:00 +01:00
Raúl Marín
f96c3e9ca8 Remove more unnecessary nested headers 2024-12-04 14:59:57 +01:00
Raúl Marín
4bdefc91ce Remove more trash 2024-12-04 14:59:09 +01:00
Raúl Marín
8c23d9ae58 More unnecessary headers 2024-12-04 14:59:09 +01:00
Raúl Marín
4f22469537 Remove heavy header 2024-12-04 14:59:09 +01:00
Raúl Marín
8ecdfb9bc2 Minor include 2024-12-04 14:59:09 +01:00
Han Fei
7bd1ab0189
Merge pull request #72734 from ClickHouse/hanfei/debug-dictionary-logical-err
add a check to debug LOGICAL ERROR of dictionary update
2024-12-04 13:36:43 +00:00
Vitaly Baranov
9ce4ac3997
Merge pull request #72723 from vitlibar/formatimpl-refactoring-reworked
Remove ostr from structure IAST::FormatSettings.
2024-12-04 12:43:26 +00:00
divanik
7dad309f47 Reduce changes in Iceberg Metadata File 2024-12-04 12:36:18 +00:00
Nikita Taranov
b0454acb14
Merge pull request #72770 from ClickHouse/more_insistent_compress_in_memory_eng
More insistent compression in `StorageMemory`
2024-12-04 12:29:09 +00:00
divanik
30ccc96c93 Resolve conflicts 2024-12-04 12:29:09 +00:00
Alexander Gololobov
b374ee67f5
Merge pull request #72747 from ClickHouse/query-plan-serialization-steps
Add serialization to some query plan steps.
2024-12-04 12:15:26 +00:00
Yarik Briukhovetskyi
3cf4cd0499
Merge pull request #71441 from bigo-sg/translate
translate support second arg longer than the third
2024-12-04 12:12:03 +00:00
Yarik Briukhovetskyi
4e51f382cb
Try to add setting into the new version 2024-12-04 12:50:24 +01:00
divanik
86602c00b6 Merge master and remove setting 2024-12-04 11:13:44 +00:00
Yarik Briukhovetskyi
d93dff37f3
Merge pull request #72185 from yariks5s/fix_bugs_storageobjectstorage
Small bugs fixes in `StorageObjectStorage`
2024-12-04 11:12:43 +00:00
Anton Popov
9172d572c6
Update src/Disks/ObjectStorages/AzureBlobStorage/AzureBlobStorageCommon.cpp 2024-12-04 11:57:43 +01:00
Francesco Ciocchetti
050bf762c2
use fs::path to simplify the statement 2024-12-04 11:35:00 +01:00
Francesco Ciocchetti
51b5f43de2
Make the List Blob Azure work regardless if the endpoint has a trailing slash or not 2024-12-04 11:25:17 +01:00
Andrey Zvonov
2bfe8ad1d8 fix throw on non-existent user in remotequeryexecutor 2024-12-04 08:37:29 +00:00
Antonio Andelic
373d6acbdd
Merge pull request #72730 from ClickHouse/fix-keeper-internal-ssl
Fix advanced SSL configuration for Keeper's internal communication
2024-12-04 08:20:57 +00:00
zhanglistar
ce6a116fdb fix vector out of range 2024-12-04 12:31:45 +08:00
Vitaly Baranov
f086cb47f3
Merge pull request #72192 from vitlibar/fix-logging-table-is-readonly
Remove log message "Table is in readonly mode" while dropping a table.
2024-12-04 01:22:26 +00:00
Raúl Marín
291db8a366
Merge pull request #72722 from Algunenano/exception_compilation
Remove some nested includes
2024-12-03 22:58:37 +00:00
Michael Kolupaev
0dfa43eb4a
Merge pull request #71178 from ClickHouse/ssett
Send settings from server to client
2024-12-03 22:10:58 +00:00
Nikita Taranov
fd9c8b1c64
Merge pull request #72746 from ClickHouse/divanik/strong_refcount_in_sos_source
Replace weak reference count to select query context with strong one in StorageObjectStorageSource
2024-12-03 22:01:29 +00:00
Nikita Taranov
ed19bf69a8
Merge pull request #72173 from JiaQiTang98/split-range-for-parallel-replicas
Split ranges in `MergeTreeReadPoolParallelReplicasInOrder` to consume less memory during reading
2024-12-03 22:01:00 +00:00
Nikita Taranov
13b48a4020
Merge pull request #72190 from filimonov/patch-12
Respect `prefer_locahost_replica` in `parallel_distributed_insert_select`
2024-12-03 21:58:30 +00:00
Azat Khuzhin
50fc0359b9 Ignore only ErrnoException/fs::filesystem_error while moving parts to detached
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-12-03 22:35:44 +01:00
Azat Khuzhin
12bb273beb Do not ignore error during moving parts to detached for MergeTree
MergeTree is fragile in this case, since the source of truth for it is
the filesystem and it will be left in an inconsistent state.

Image the following:
- during startup you got some broken part, that should be moved to
  detached
- this rename throws exception (i.e. permission error)
- but this error is ignored, server continues, and tries to merge
  something that produces intersecting parts for that broken part
- later on restart you will got intersecting parts (since at the time of
  scanning for intersecting parts, the part is not checked)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2024-12-03 22:35:43 +01:00
Azat Khuzhin
86f657ffc6 Adjust error message about intersecting parts (remove ZooKeeper note from common code)
It could happen for MergeTree as well.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-12-03 22:34:46 +01:00
Alexander Gololobov
d65dd866c6
Merge pull request #72749 from ClickHouse/fix_mark_cache_drop
Fix unneeded blocking of context while dropping mark cache
2024-12-03 20:47:07 +00:00
avogar
9e730e4206 Support Dynamic type in functions ifNull and coalesce 2024-12-03 20:41:25 +00:00
Igor Nikonov
22f5ce253d Nothing works 2024-12-03 20:30:44 +00:00
Yarik Briukhovetskyi
72e19cbbcb
Update QueryTreeBuilder.cpp 2024-12-03 21:12:23 +01:00
Yarik Briukhovetskyi
db15390ab4
Add lowercase support. 2024-12-03 20:53:39 +01:00
Igor Nikonov
678f4c02df Merge remote-tracking branch 'origin/master' into pr-fix-setting-history 2024-12-03 19:42:35 +00:00
Igor Nikonov
4df0603c58 Fix 2024-12-03 19:42:31 +00:00
Yarik Briukhovetskyi
d6480b846c
Fix run issues 2024-12-03 20:30:06 +01:00
Nikita Taranov
a71c00000b impl 2024-12-03 20:12:51 +01:00
Raúl Marín
1bea990a73 One more 2024-12-03 19:25:11 +01:00
Nikolai Kochetov
5be41d489d
Merge pull request #72735 from ClickHouse/fix-y-shaped-join-context
Fix context lifetime for Y-shaped join.
2024-12-03 17:42:35 +00:00
Yarik Briukhovetskyi
b8f1110455
Update QueryTreeBuilder.cpp 2024-12-03 18:36:08 +01:00
Yarik Briukhovetskyi
ecd6282af5
Update AggregateFunctionGroupConcat.h 2024-12-03 18:18:59 +01:00
kssenii
bd284fbb0d Add a test 2024-12-03 18:17:25 +01:00
Yarik Briukhovetskyi
525a2de94f
Add pragma once 2024-12-03 18:09:58 +01:00
Yarik Briukhovetskyi
9dc3703bce
Add missing errorCodes 2024-12-03 17:55:29 +01:00
Yarik Briukhovetskyi
c04a28d009
Change the logic to use analyzer 2024-12-03 17:31:45 +01:00
Alexander Gololobov
9ba2953472 More accurate PK size calculation 2024-12-03 17:10:43 +01:00
Alexander Gololobov
6bcdab413a Clear other caches without context lock as well 2024-12-03 17:00:57 +01:00
Alexander Gololobov
d879fcfc9e Fix unneeded blocking of context while dropping mark cache 2024-12-03 16:41:07 +01:00
divanik
f1219d3e8e Merge branch 'master' of github.com:ClickHouse/ClickHouse into divanik/add_schema_evolution_concise 2024-12-03 15:27:45 +00:00
kssenii
5144fec1b0 Fix typo 2024-12-03 16:18:29 +01:00
Nikolai Kochetov
c00a85a601 Merge branch 'master' into query-plan-serialization-steps 2024-12-03 16:16:01 +01:00
Nikolai Kochetov
6cc668bd88 Add serializetion to some query plan steps. 2024-12-03 15:00:05 +00:00
Vitaly Baranov
8c6c7f5f7d Remove the trivial copy constructor in IAST::FormatSettings. 2024-12-03 15:46:29 +01:00
divanik
1ed7ea74b2 Remove unnecessary changes 2024-12-03 14:34:16 +00:00
divanik
7e293d392b Remove unnecessary changes 2024-12-03 14:31:59 +00:00
divanik
be7a3bbf6e Fix bugs 2024-12-03 14:22:00 +00:00
Dmitry Novik
854b72ade2
Merge pull request #72608 from ClickHouse/analyzer-array-join-fix
Analyzer: Proper fix for distributed ARRAY JOINs
2024-12-03 14:07:32 +00:00
Vladimir Cherkasov
d7acd3db93
Merge pull request #69910 from ClickHouse/vdimir/residual_join_conditions
Non-experimental non-equi join conditions
2024-12-03 13:48:31 +00:00
Raúl Marín
2bdb713798 Missing include 2024-12-03 14:47:25 +01:00
Vladimir Cherkasov
902a42fead
Merge branch 'master' into ch-disks-remove 2024-12-03 14:23:17 +01:00
avogar
1a9b919869 Support JSON in notEmpty function 2024-12-03 13:15:14 +00:00
Raúl Marín
ca5a1463e2 Update setting changes with master 2024-12-03 14:05:03 +01:00
kssenii
599218849c Fix no-such-key in s3queue 2024-12-03 13:56:13 +01:00
divanik
c71519d9e9 Replace weak with strong 2024-12-03 12:49:49 +00:00
Raúl Marín
5a3ecbd231 Merge remote-tracking branch 'blessed/master' into settings_checks 2024-12-03 13:45:37 +01:00
divanik
3486baade8 Intermediate commit 2024-12-03 12:39:28 +00:00
Raúl Marín
fa7db13d0c Missing include 2024-12-03 13:19:43 +01:00
Antonio Andelic
340b0a9860 Fix style 2024-12-03 13:18:52 +01:00
Raúl Marín
0d91a9b60c Use an Enum for type in system.settings_changes 2024-12-03 13:13:05 +01:00
kssenii
eb9d5705a9 Correct merge 2024-12-03 12:22:22 +01:00
kssenii
f8696aa010 Merge remote-tracking branch 'origin/master' into rest-catalog 2024-12-03 12:21:59 +01:00
Michael Kolupaev
96a961583c Fix custom settings 2024-12-03 11:09:08 +00:00
Raúl Marín
009580edd0
Merge pull request #72715 from Algunenano/dragonbox
Remove heavy header from WriteHelpers.h
2024-12-03 10:58:37 +00:00
Nikolai Kochetov
3156209d58 Fix context lifetime for Y-shaped join. 2024-12-03 11:57:32 +01:00
Anton Popov
82a80db693
Merge pull request #65691 from CurtizJ/fix-azure-list
Fix `ListObjects` in azure blob storage
2024-12-03 10:50:38 +00:00
Han Fei
bf6708069c add a check to debug LOGICAL ERROR of dictionary update 2024-12-03 10:40:01 +00:00
zhanglistar
7d0a62e351 Support string search operator for Enum data type #72661 2024-12-03 17:43:22 +08:00
Antonio Andelic
d65f440679 Fix advanced SSL configuration for Keeper's internal communication 2024-12-03 09:44:17 +01:00
Yakov Olkhovskiy
46f5f79ab5
Merge pull request #72659 from ClickHouse/imp-safeget
Safer Field::safeGet?
2024-12-03 07:28:55 +00:00
Michael Kolupaev
bc267d4427 Merge remote-tracking branch 'origin/master' into ssett 2024-12-03 06:51:08 +00:00
zhanglistar
fc4854e284 fix style check 2024-12-03 11:30:36 +08:00
zhanglistar
2df33734de modify code as requested 2024-12-03 11:20:33 +08:00
zhanglistar
99c8d1fd61 fix failure tests 2024-12-03 11:13:19 +08:00
Yakov Olkhovskiy
617af1d3c0
Merge pull request #71297 from lzydmxy/force-connect-on-retry
Force_connected for retry resume connection establisher
2024-12-03 01:21:31 +00:00
Vitaly Baranov
d0a11071d4 Remove ostr from structure IAST::FormatSettings. 2024-12-03 01:01:24 +01:00
Raúl Marín
7afee244c5 Merge remote-tracking branch 'blessed/master' into dragonbox 2024-12-03 00:37:01 +01:00
Raúl Marín
4ce0a17a57 Fix style 2024-12-03 00:18:16 +01:00
Raúl Marín
28e09e2b81 Remove some nested inclusion of WriteHelpers.h 2024-12-02 23:49:04 +01:00
filimonov
f245a497e0
Update StorageDistributed.cpp 2024-12-02 23:27:23 +01:00
Yakov Olkhovskiy
57e77cc815 add move semantics 2024-12-02 21:46:57 +00:00
Raúl Marín
a8a3a2451d Improve includes for StoragePolicy.h 2024-12-02 22:42:51 +01:00
Raúl Marín
e50265bae5 Optimize includes of Exception.h 2024-12-02 22:26:41 +01:00
Igor Nikonov
dfe58a34ca Fix 2024-12-02 21:13:49 +00:00
Alexander Gololobov
ce87198ebe
Merge pull request #72643 from ClickHouse/measure_logger_time
Measure time consumed by logging
2024-12-02 20:43:26 +00:00
Anton Popov
e58d886b88
Merge pull request #72651 from CurtizJ/better-cache-prewarm
Better prewarm of mark and primary index caches
2024-12-02 20:01:59 +00:00
Yarik Briukhovetskyi
802f98856a
Add aliased version 2024-12-02 20:25:07 +01:00
Yarik Briukhovetskyi
deddd1db31
Change the logic 2024-12-02 20:22:04 +01:00
Igor Nikonov
7ddd916101 Fix typo 2024-12-02 18:35:47 +00:00
Igor Nikonov
8c4b73ed64
Merge branch 'master' into pr-fix-setting-history 2024-12-02 19:29:41 +01:00
Raúl Marín
6291daec72 Remove heavy header from WriteHelpers.h 2024-12-02 19:23:48 +01:00
avogar
6a31154ccd Fix tests 2024-12-02 18:17:25 +00:00
avogar
d49e22cbae Fix builds 2024-12-02 17:50:32 +00:00
Yarik Briukhovetskyi
af5ff8dcd4
Merge branch 'ClickHouse:master' into try_fix_duplicating_aliases 2024-12-02 18:40:04 +01:00
Yarik Briukhovetskyi
46dd7074c7
Merge pull request #72640 from yariks5s/fix_datetime64_in_datetime64
Fix a bug with DateTime64 in DateTime64
2024-12-02 17:39:31 +00:00
Alexander Tokmakov
9400fe820e add a comment 2024-12-02 18:05:28 +01:00
Konstantin Bogdanov
2ecc690b93
Merge pull request #72567 from ClickHouse/fix-broken-result-part-path
Fix weird `result_part_path`
2024-12-02 17:04:02 +00:00
Raúl Marín
1f0f3b41e4
Merge pull request #72425 from Algunenano/obsolete_macro
Remove obsolete usage of ABORT_ON_LOGICAL_ERROR
2024-12-02 16:16:03 +00:00
Yarik Briukhovetskyi
bd59b7bbeb
Merge branch 'ClickHouse:master' into task_cancellation 2024-12-02 17:03:22 +01:00
Igor Nikonov
4eba52e0d5 Align PR setting changes history with 24.10 2024-12-02 15:35:58 +00:00
Yarik Briukhovetskyi
9ceee0bf5e
Merge branch 'ClickHouse:master' into try_fix_duplicating_aliases 2024-12-02 16:22:43 +01:00
János Benjamin Antal
ad25899d8f
Merge branch 'master' into optimize-join-performance-by-extracting-common-exprs 2024-12-02 16:10:38 +01:00
János Benjamin Antal
d66b108513
Merge pull request #72603 from azat/mm-fix-metric
Fix inaccurate MemoryTracking metric in case of allocation failures
2024-12-02 14:00:20 +00:00
zhanglistar
0e30bd3b72 fix style fail 2024-12-02 21:57:54 +08:00
Igor Nikonov
6acad6a91e Merge remote-tracking branch 'origin/master' into pr-3-way-joins 2024-12-02 13:01:54 +00:00
Igor Nikonov
dc9c1439b0 Fix FULL JOINs queries 2024-12-02 12:59:01 +00:00
Konstantin Bogdanov
28d5d2130a
Merge pull request #72572 from ClickHouse/fix-glob-parsing
Fix parsing a glob with one element
2024-12-02 12:44:37 +00:00
Nikita Taranov
b84d0554ed
Merge pull request #72658 from ClickHouse/null_format_matching_case_insensitive
Recognise all spellings of `Null` in `FORMAT Null`
2024-12-02 12:21:39 +00:00
Raúl Marín
3df482066b Fix MergeTreeSettings history for 24.12 2024-12-02 12:47:20 +01:00
Raúl Marín
389c31f2b8 Add MergeTreeSettings to system.settings_changes 2024-12-02 12:39:51 +01:00
Yarik Briukhovetskyi
fd3723a727
Merge branch 'ClickHouse:master' into fix_datetime64_in_datetime64 2024-12-02 12:19:09 +01:00
vdimir
ceea266253
fix 2024-12-02 11:09:03 +00:00
nauu
c3c8f9d2ff Add total_bytes_with_inactive to system.tables to count the byte size of inactive parts 2024-12-02 19:08:38 +08:00
Dmitry Novik
7e00e604fa Fix test 2024-12-02 12:01:24 +01:00
Anton Popov
5ad8c8beaf Merge remote-tracking branch 'upstream/master' into HEAD 2024-12-02 10:53:48 +00:00
Raúl Marín
c6c60eb5c7 Merge remote-tracking branch 'blessed/master' into obsolete_macro 2024-12-02 11:52:19 +01:00
Vladimir Cherkasov
7b9973ef8f
Merge branch 'master' into vdimir/residual_join_conditions 2024-12-02 11:38:00 +01:00
Vladimir Cherkasov
e8dab58d2d
Merge pull request #70957 from bigo-sg/tostring-fix
Function cast support Spark text output
2024-12-02 10:28:35 +00:00
Alexander Tokmakov
12ac21f10f fix flatten_nested when recovering a Replicated db 2024-12-02 11:08:43 +01:00
zhanglistar
ca49fcfc38 fix enum (not)in exception 2024-12-02 18:00:43 +08:00
Dmitry Novik
ad5a571d7a Preserve table expression counting 2024-12-02 10:58:26 +01:00
Raúl Marín
0a5a0a2973
Merge pull request #72402 from Algunenano/keeper_fault
Better error message on bad keeper snapshots
2024-12-02 09:24:16 +00:00
Vitaly Baranov
62ed8679ad
Merge pull request #72655 from ClickHouse/vitlibar-fix-formatting-in-interpreter-create-query
Fix formatting in InterpreterCreateQuery.cpp
2024-12-02 09:04:31 +00:00
Antonio Andelic
541098d0c6
Merge pull request #72584 from ClickHouse/update-nuraft
Update NuRaft
2024-12-02 07:50:12 +00:00
Antonio Andelic
8b5e00d3f2
Merge pull request #72630 from ClickHouse/better-memory-usage-estimation
Better memory usage approx of `MarksInCompressedFile`
2024-12-02 07:49:38 +00:00
shuai-xu
f201119575 refine codes 2024-12-02 12:28:38 +08:00
shuai-xu
d2b4448fb1 some refines 2024-12-02 12:28:38 +08:00
shuai-xu
39740d2ed9 some refines 2024-12-02 12:28:38 +08:00
shuai-xu
eaa31d04c1 fix test 2024-12-02 12:28:38 +08:00
shuai-xu
be117a1da3 fix confilic 2024-12-02 12:28:37 +08:00
shuai-xu
ee152f8c53 fix tests 2024-12-02 12:28:37 +08:00
shuai-xu
098e20d9b9 translate support second arg longer than the third 2024-12-02 12:28:37 +08:00
zhanglistar
3c3f1c919d
Merge branch 'master' into tostring-fix 2024-12-02 12:21:00 +08:00
Yakov Olkhovskiy
54108d5c16 fix tidy 2024-12-02 00:08:00 +00:00
Vitaly Baranov
136c5de31c Add field query_status to the ZooKeeperRetriesInfo structure. 2024-12-01 23:22:24 +01:00
Vitaly Baranov
5c4da39259 Add retries while creating a replicated table. 2024-12-01 23:22:19 +01:00
alesapin
4f596388a2
Merge pull request #72556 from ClickHouse/devirtualize_serialize_call
Devirtualize serialize call in AggregateFunction
2024-12-01 21:18:38 +00:00
Azat Khuzhin
88a3dbe716 Fix inaccurate MemoryTracking metric in case of allocation failures
MemoryTracking metric takes into account memory allocation even in case
of this allocation will fail with MEMORY_LIMIT_EXCEEDED, which is not
good, which eventually will lead to `amount` and `MemoryTracking`
mismatch, I found one server with **43x difference**.

<details>

```sql
SELECT
    event_time_microseconds,
    message
FROM system.text_log
WHERE (event_date = (today() - 1)) AND (logger_name = 'MemoryTracker') AND (message LIKE '%total%')
ORDER BY 1 DESC
LIMIT 1

Query id: 64d60852-fa14-4ed1-adb1-d4bbd6159475

   ┌────event_time_microseconds─┬─message───────────────────────────────────┐
1. │ 2024-11-27 05:09:48.157608 │ Current memory usage (total): 471.00 GiB. │
   └────────────────────────────┴───────────────────────────────────────────┘
```

```sql
SELECT
    metric,
    formatReadableSize(value)
FROM system.metrics
WHERE (metric ILIKE '%mem%') OR (metric ILIKE '%jemalloc%')
ORDER BY value ASC

Query id: af7908a8-956a-4684-b7c5-b2e0c6fa06f4

   ┌─metric────────────────────────┬─formatReadableSize(value)─┐
1. │ MergesMutationsMemoryTracking │ 0.00 B                    │
2. │ MemoryTracking                │ 20.37 TiB                 │
   └───────────────────────────────┴───────────────────────────┘
```

</details>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-12-01 19:48:25 +01:00
Antonio Andelic
e940ceaacc Merge branch 'master' into better-memory-usage-estimation 2024-12-01 19:16:37 +01:00
Yakov Olkhovskiy
76dee30dee make Field rvalue reference safeGet to return a copy of its content instead of reference 2024-12-01 17:54:05 +00:00
Nikita Taranov
0041fdf497 impl 2024-12-01 18:50:55 +01:00
Antonio Andelic
e95c35e460 Merge branch 'master' into update-nuraft 2024-12-01 18:43:15 +01:00
“JiaQi
14d07d8dcf bug fix 2024-12-01 21:00:17 +08:00
Alexey Milovidov
e841e74d32 Add http_response_headers setting 2024-11-30 23:24:51 +01:00
Alexey Milovidov
2372e9fece Add http_response_headers setting 2024-11-30 22:53:13 +01:00
Alexey Milovidov
bdff47973a Check for duplicates 2024-11-30 22:14:42 +01:00
Alexey Milovidov
87601d461f Add http_response_headers setting 2024-11-30 22:05:03 +01:00
Alexey Milovidov
076a8f8d9e Add http_response_headers setting 2024-11-30 22:02:26 +01:00
alesapin
1d0caf1c90 Trivial change 2024-11-30 18:51:24 +01:00
alesapin
38bd543a42 Add finals 2024-11-30 18:39:26 +01:00
Vitaly Baranov
9554d355b9
Fix formatting in InterpreterCreateQuery.cpp 2024-11-30 12:43:38 +01:00
Sema Checherinda
0a9ac03671 add assert in d-tor ReplicatedMergeTreeSinkImpl 2024-11-30 12:37:18 +01:00
Sema Checherinda
a95d19806b fix chassert in d-tor MergeTreeSink 2024-11-30 12:33:42 +01:00
Sema Checherinda
049fa54c4d
Revert "Revert "make d-tor Finalizer more obvious"" 2024-11-30 12:31:24 +01:00
Sema Checherinda
dc4bbc8d73
Merge pull request #72642 from ClickHouse/revert-72395-chesema-dtor-Finalizer
Revert "make d-tor Finalizer more obvious"
2024-11-30 11:00:24 +00:00
Alexander Gololobov
a44e09a0c4 Merge branch 'master' of github.com:ClickHouse/ClickHouse into measure_logger_time 2024-11-30 11:44:57 +01:00
Yarik Briukhovetskyi
04c3208a0e
Merge branch 'ClickHouse:master' into fix_datetime64_in_datetime64 2024-11-30 10:15:37 +01:00
“JiaQi
f66f680d26 1. check has_limit_below_one_block for asc order read
2. fix tests
2024-11-30 13:57:37 +08:00
Anton Popov
d7f2f0e098 better prewarm of mark and primary index caches 2024-11-30 01:48:50 +00:00
Vladimir Cherkasov
0589253688
Merge pull request #72460 from ClickHouse/vdimir/join_select_inner_table
Resubmit #68682, att2
2024-11-30 00:59:23 +00:00
Anton Popov
6e5582f899
Merge pull request #72599 from CurtizJ/revert-65488
Revert "Merge pull request #65488 from zvonand/zvonand-ttl"
2024-11-29 23:44:00 +00:00
Anton Popov
6e760f4e45
Merge pull request #72611 from CurtizJ/fix-prewarm-caches-race
Fix data race in prewarm of mark cache
2024-11-29 22:14:24 +00:00
Miсhael Stetsyuk
6d9a45eff1
Merge branch 'master' into startup-scripts-execution-state 2024-11-29 21:57:58 +00:00
Alexander Gololobov
fc01a17c89
Fix description 2024-11-29 22:31:35 +01:00
Yarik Briukhovetskyi
bc3bc8913e
Add nullable check for data types 2024-11-29 20:59:07 +01:00
Alexander Gololobov
5e0285d38a Measure time consumed by logging 2024-11-29 20:49:55 +01:00
Sema Checherinda
043d6e7bbf
Revert "make d-tor Finalizer more obvious" 2024-11-29 20:37:03 +01:00
Yarik Briukhovetskyi
ca5faf14ca
Update Set.cpp 2024-11-29 20:18:41 +01:00