thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-13 18:02:24 +00:00
Code Issues Packages Projects Releases Wiki Activity
140,865 Commits 9,328 Branches 1,783 Tags 2.1 GiB
aea3090074
Commit Graph

17020 Commits

Author SHA1 Message Date
Alexander Gololobov
65a47801f1
Merge pull request #63274 from ClickHouse/fix_remote_data_path_fs_err 
More checks for concurrently deleted files and dirs in system.remote_data_paths
 2024-05-02 19:08:35 +00:00
vdimir
a838fb778b
Merge pull request #59163 from canhld94/rocksdb_bypass_memtable 
Introduce bulk loading to StorageEmbeddedRocksDB
 2024-05-02 14:49:03 +00:00
Alexander Gololobov
84bed102f1 More checks for concurrently deleted files and dirs 2024-05-02 14:39:59 +02:00
Sema Checherinda
083bcfc1ce distinct message for s3 error 'no key' for cases disk and storage 2024-05-02 13:08:25 +02:00
Nikita Taranov
77c5221a0e
Merge pull request #59405 from nickitat/dont_merge_just_created_aggr_projection_block 
Don't merge just created aggregating projection blocks
 2024-05-01 11:34:21 +00:00
Duc Canh Le
6a324ae67a Merge branch 'master' into rocksdb_bypass_memtable 
Try fix CI
 2024-05-01 11:21:31 +00:00
Duc Canh Le
c462d003af update comments 
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
 2024-05-01 02:11:02 +00:00
Duc Canh Le
6e235ad823 address reviews 
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
 2024-05-01 02:06:44 +00:00
Duc Canh Le
90d6c165e3
Update src/Storages/RocksDB/EmbeddedRocksDBBulkSink.cpp 
Co-authored-by: vdimir <vdimir@clickhouse.com>
 2024-05-01 10:05:49 +08:00
Alexey Milovidov
d3a0d5c7b2
Merge pull request #63215 from ClickHouse/24.5-prepare 
Update version after release
 2024-05-01 03:54:20 +02:00
Alexey Milovidov
c6ab7bd995 Update autogenerated version to 24.5.1.1 and contributors 2024-05-01 03:52:34 +02:00
Robert Schulze
0a01a92bf8
Merge pull request #62884 from rschu1ze/inverted-to-fulltext 
Rename "inverted index" to "full-text index"
 2024-04-30 20:03:35 +00:00
János Benjamin Antal
71589c25ba
Merge pull request #62498 from ClickHouse/prevent-renaming-important-columns 
Fix validation of special MergeTree columns
 2024-04-30 09:10:08 +00:00
Alexey Milovidov
006de3f94d
Merge pull request #63097 from canhld94/fix_abs_in_index 
Fix incorrect judgement of of monotonicity of function abs
 2024-04-30 04:28:16 +02:00
Alexey Milovidov
90d8e3cb97
Merge pull request #61116 from jkartseva/s3-plain-with-replace 
S3-plain based disk supporting directory rename
 2024-04-30 04:12:17 +02:00
Alexey Milovidov
989a880230
Merge pull request #62404 from Avogar/trivial-insert-select-from-files 
Improve trivial insert select from files, add separate max_parsing_threads setting
 2024-04-30 01:57:56 +02:00
Alexey Milovidov
b5a33d523b
Merge pull request #63122 from ClickHouse/fix_mongo_ssl 
Set server name for SSL handshake in MongoDB engine
 2024-04-30 01:32:21 +02:00
Alexey Milovidov
cf431a5cf5
Merge pull request #63126 from ClickHouse/fix_mongo_wire_version_check 
Use user specified db instead of "config" for MongoDB wire protocol version check
 2024-04-30 01:31:58 +02:00
Alexander Tokmakov
37950a5f4e
Merge pull request #62738 from pamarcos/pamarcos/system-unload-primary-key 
Add SYSTEM UNLOAD PRIMARY KEY
 2024-04-29 21:18:01 +00:00
Julia Kartseva
dc95558962 method rename 2024-04-29 19:48:17 +00:00
Julia Kartseva
89f28f3c18 explicitly disallow ALTERs and mutations for plain 2024-04-29 18:01:21 +00:00
Julia Kartseva
a67a8299ce Do not list prefix.path in listDirectory 2024-04-29 18:01:21 +00:00
Julia Kartseva
75147f3ac7 S3-plain based disk supporting directory rename 
Fixes: https://github.com/ClickHouse/ClickHouse/issues/58347
 2024-04-29 18:01:21 +00:00
Alexander Gololobov
39001cce0e Use user specified db instead of "config" 2024-04-29 18:05:37 +02:00
Duc Canh Le
05eab7b204
Fix style 2024-04-29 21:54:50 +08:00
Alexander Gololobov
5b2f726a71 Set server name for SSL handshake 2024-04-29 15:24:48 +02:00
Duc Canh Le
98d606298b better way to deduplicate keys while creating sst files 
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
 2024-04-29 10:53:50 +00:00
Duc Canh Le
084f917bf8 fix clang-tidy and better test 
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
 2024-04-29 10:37:45 +00:00
Duc Canh Le
4b7abbce68 fix abs monotonicity 
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
 2024-04-29 01:33:48 +00:00
Alexey Milovidov
c570316c87
Merge branch 'master' into analyzer-support-recursive-cte 2024-04-29 02:26:59 +02:00
Maksim Kita
f5cfe597f2 Fixed tests 2024-04-28 12:52:17 +03:00
Maksim Kita
bd1189de70 Fixed tests 2024-04-28 12:52:17 +03:00
Duc Canh Le
c4e0cf2e7d rocksdb: implement ALTER SETTING 
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
 2024-04-28 06:37:53 +00:00
Azat Khuzhin
478ba92ddd Improve error message on checksum mismatch during fetches 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-28 07:34:07 +02:00
Azat Khuzhin
d278866d52 Add copy_data_failpoint failpoint 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-28 07:34:07 +02:00
Alexey Milovidov
5a7e7a9f2f Merge branch 'master' into too-many-parts-in-move-partition 2024-04-27 16:02:02 +02:00
Pablo Marcos
f6b19e143a Remove unnecessary const hinted by clang-tidy 
Removing the reference for Index makes the const unnecessary.
Constness for it is still preserved correctly because Columns
are inmutable pointers to IColumn.
 2024-04-27 09:30:51 +02:00
Pablo Marcos
9002d4c751 Merge branch 'master' into pamarcos/system-unload-primary-key 2024-04-27 08:57:29 +02:00
Alexander Tokmakov
7fb78aa4d4
Merge pull request #60856 from azat/alter-select-throughtput-v2 
[RFC] Reduce overhead of the mutations for SELECTs (v2)
 2024-04-26 17:46:57 +00:00
Nikita Taranov
51a0ec9b30
Merge branch 'master' into dont_merge_just_created_aggr_projection_block 2024-04-26 19:32:14 +02:00
Duc Canh Le
41351222e7 Merge branch 'master' into rocksdb_bypass_memtable 
Resolve conflicts

Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
 2024-04-26 10:47:49 +00:00
Pablo Marcos
39deb3ee7f Convert index to a shared_ptr to allow unloading primary keys while queries use them 2024-04-25 19:56:21 +02:00
Pablo Marcos
24b84ef68a Merge branch 'master' into pamarcos/system-unload-primary-key 2024-04-25 18:26:14 +02:00
Nikolai Kochetov
0038f322e8
Merge pull request #62916 from ClickHouse/fix-prewhere-for-storage-buffer-with-different-types 
Fix PREWHERE for StorageBuffer with different source table column types.
 2024-04-25 14:40:11 +00:00
Azat Khuzhin
5d72a34561 Add some comments for getAlterMutationCommandsForPart() 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-25 14:35:21 +02:00
Azat Khuzhin
e5650f8af3 Move add_to_result() out from loop 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-25 14:35:21 +02:00
Azat Khuzhin
e0b83bde50 Consider alter_conversions_mutations as valid only if part metadata version matches 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-25 14:35:21 +02:00
Azat Khuzhin
d2a922bd44 Revert "Fix processing INSERT after metadata mutations that had not been applied yet" 
The problem is that the atomic counter (alter_conversions_mutations) is
not accounted correctly for IMergeTreeDataPart::getMetadataVersion()

This reverts commit 0124642b39f538eaf2b1c7cfab9a0a917b1b12f6.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-25 14:35:21 +02:00
Azat Khuzhin
c048ab9d6d Fix processing INSERT after metadata mutations that had not been applied yet 
The problem is that right now INSERT may write old columns even after
metadata mutation (i.e. RENAME), because it will simply write the new
block number that is bigger then metadata version, and so this part
won't be mutated.

To fix this, it should get the mutation version from metadata - this is
quite a major change!

Fixes: 2555_davengers_rename_chain
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-25 14:35:21 +02:00
Azat Khuzhin
be6777bc86 Reduce overhead of the mutations for SELECTs (v2) 
SELECTs are affected by the mutations, since it tries to apply them on
fly, and scanning over existing mutations can take significant amount of
time (for simple queries, i.e. count())

And also even after mutation had been finished, it still a problem,
because mutations are not removed instantly.

So instead introduce an atomic counter alter_conversions_mutations, that
is incremented for new mutations and decremented once mutation
finished/killed, that way once the mutation finished they will not
affect queries.

Here are some numbers for non-RENAME mutations:

    rmt vanilla w/o mutations | queries: 3693, QPS: 494.813
    rmt vanilla w/ mutations  | queries: 2190, QPS: 388.256
    rmt patched w/o mutations | queries: 3168, QPS: 620.061
    rmt patched w/ mutations  | queries: 3155, QPS: 614.424
    mt vanilla w/o mutations  | queries: 3498, QPS: 656.399
    mt vanilla w/ mutations   | queries: 3821, QPS: 600.425
    mt patched w/o mutations  | queries: 5732, QPS: 745.585
    mt patched w/ mutations   | queries: 4719, QPS: 715.034

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-25 14:35:21 +02:00