Commit Graph

17020 Commits

Author SHA1 Message Date
Nikolai Kochetov
e97443ddd1
Update StorageBuffer.cpp 2024-03-18 20:15:34 +01:00
Nikolai Kochetov
c99a874305
Update StorageValues.cpp 2024-03-18 20:13:52 +01:00
Kirill Nikiforov
ebaee8e5f6
Add support for ATTACH PARTITION ALL (#61107) 2024-03-18 15:00:27 -04:00
Nikolai Kochetov
3def01f1f6 Fixing 01083_expressions_in_engine_arguments with analyzer. 2024-03-18 18:53:01 +00:00
William Schoeffel
4f30ac72a1 fix typo in variable name legacy 2024-03-18 15:18:47 -03:00
Nikita Taranov
c1fb34da0d
Merge branch 'master' into debug_info 2024-03-18 17:54:31 +01:00
Nikita Taranov
b0131a278b impl 2024-03-18 16:48:53 +00:00
Arthur Passos
c67c04b89a fix typo 2024-03-18 13:44:36 -03:00
kssenii
b814fabcd3 Disallow s3queue sharded mode 2024-03-18 17:22:38 +01:00
Anton Popov
13b27a8d36 refactoring of reading from compact parts 2024-03-18 16:13:02 +00:00
divanik
265d91747f Remove log debug 2024-03-18 16:03:12 +00:00
Nikita Mikhaylov
15896ecaf6
Add table system.keywords [Part 1] (#51808) 2024-03-18 16:58:57 +01:00
Anton Popov
efe5373f2b refactoring of reading from compact parts 2024-03-18 15:57:58 +00:00
Kseniia Sumarokova
d4895c2e52
Merge pull request #61324 from ClickHouse/add-zk-retries
Add zookeeper retries for exists check in forcefullyRemoveBrokenOutdatedPartFromZooKeeper
2024-03-18 16:17:37 +01:00
Vitaly Baranov
08d64f9e11 Get rid of modifying a shared AbstractConfiguration (between StorageDictionary and ExternalDictionariesLoader).
Always create a new configuration when we need to modify it.
2024-03-18 14:43:38 +01:00
Dmitry Novik
15e19206b4 Merge remote-tracking branch 'origin/master' into analyzer-distr-json-copy 2024-03-18 14:24:51 +01:00
Dmitry Novik
a65f027cf7
Revert "Revert "Analyzer: Fix virtual columns in StorageMerge"" 2024-03-18 14:00:20 +01:00
Yarik Briukhovetskyi
5e5a39d039
Merge pull request #61467 from wiledusc/remove-duplicated-check-containing-part-empty
Remove duplicated check containing_part.empty()
2024-03-18 13:44:25 +01:00
divanik
c5d35bb187 Merge branch 'master' of github.com:ClickHouse/ClickHouse into divanik/generate_series_function 2024-03-18 12:26:43 +00:00
Yarik Briukhovetskyi
c85d410cda
Merge pull request #60612 from JakeBamrah/master
[59558] Add size cap to Memory tables
2024-03-18 13:21:56 +01:00
Robert Schulze
0dff126942
Merge remote-tracking branch 'rschu1ze/master' into enable-clang-tidy-in-headers 2024-03-18 11:34:13 +00:00
alesapin
b01526aeb2
Merge pull request #61267 from CurtizJ/better-memory-usage-inserts
Free memory earlier in inserts
2024-03-18 12:30:42 +01:00
vdimir
e27e6fb2f5
Analyzer: support join using column from select list 2024-03-18 11:11:00 +00:00
Kseniia Sumarokova
6d2e48d085
Merge branch 'master' into add-zk-retries 2024-03-18 11:24:36 +01:00
Antonio Andelic
6549a96ced
Revert "Analyzer: Fix virtual columns in StorageMerge" 2024-03-18 10:38:28 +01:00
János Benjamin Antal
4b4a03c0f1
Merge branch 'master' into less-header-1 2024-03-18 10:25:42 +01:00
Robert Schulze
c17536c3b3
Enable clang-tidy in headers 2024-03-18 08:00:09 +00:00
Zhuo Qiu
bf85f7f368 add docs & minor fix for lwd-aware merge settings 2024-03-18 11:02:02 +08:00
Alexey Milovidov
01136bbc3b Limit backtracking in parser 2024-03-17 19:54:45 +01:00
Kseniia Sumarokova
d4205afe82
Merge branch 'master' into add-zk-retries 2024-03-17 17:56:32 +01:00
Alexey Milovidov
994bf8765c Merge branch 'master' of github.com:ClickHouse/ClickHouse into split-cast-overload-resolver 2024-03-17 14:20:02 +01:00
Alexey Milovidov
cb8d859453
Merge branch 'master' into analyzer-distr-json 2024-03-17 15:15:06 +03:00
Alexey Milovidov
bf98386a33
Merge pull request #61298 from ClickHouse/analyzer-merge-virtual-columns
Analyzer: Fix virtual columns in StorageMerge
2024-03-17 15:05:23 +03:00
Vitaly Baranov
4fe1c9a78f Get rid of checking the "last modification time" when the configuration is generated
to allow ExternalLoader::reloadConfig() work for generated configurations too.
2024-03-17 12:10:57 +01:00
Vitaly Baranov
41d8621d97 Fix replacing dictionaries: StorageID is now updated immediately for every dictionary during CREATE OR REPLACE
even if the dictionary is not loaded yet or loading right now.
2024-03-17 12:10:52 +01:00
Alexey Milovidov
9be38c064a Merge branch 'master' into split-cast-overload-resolver 2024-03-16 14:07:59 +01:00
Dan Wu
adaf262dc0 Fix bug when reading system.parts using UUID (issue 61220).
During the predicates pushing down of system.parts table, there is a
logic to use that predicates to filter on the storages. This makes sense
if the predicate is on the `database`, `table`, `engine`. But it can be
problem if the predicate is about `uuid`, because storage UUID is
apparently different from parts UUID.

Rename the column name from `uuid` to `storage_uuid` fixed this.
2024-03-16 02:02:21 +00:00
William Schoeffel
4dbf3ee1bb fix: remove duplicated check containing part 2024-03-15 14:05:24 -03:00
Yakov Olkhovskiy
a31f551bc7
Merge pull request #58223 from jewelzqiu/existing-count
Consider lightweight deleted rows when selecting parts to merge
2024-03-15 12:42:35 -04:00
Kruglov Pavel
d045ab150e
Merge pull request #61362 from ClickHouse/revert-61359-revert-61234-Avogar-patch-2
Revert "Revert "Fix usage of session_token in S3 engine""
2024-03-15 16:00:05 +01:00
Dmitry Novik
061cd5a53d Fixup #ci_set_analyzer 2024-03-15 14:22:46 +00:00
Anton Popov
6ad2f95837 Merge remote-tracking branch 'upstream/master' into HEAD 2024-03-15 13:52:20 +00:00
Dmitry Novik
1cdd280c9f
Merge pull request #61392 from ClickHouse/analyzer-fix-context-in-merge
Analyzer: Fix planner context for subquery in StorageMerge
2024-03-15 14:05:28 +01:00
Sergei Trifonov
273d221781
Merge pull request #60558 from ClickHouse/revert-60253-revert-59032-cpu-scheduler-and-cc
Revert "Revert "Support resource request canceling""
2024-03-15 13:24:50 +01:00
divanik
e57446b6f5 Resolved conflicts 2024-03-15 11:57:59 +00:00
Antonio Andelic
0ba400d065
Merge pull request #61380 from ClickHouse/fix-heap-use-after-free-alias-merge
Fix `heap-use-after-free` for Merge table with alias
2024-03-15 11:15:02 +01:00
Zhuo Qiu
7f97b11ce6 only read _row_exists column when necessary 2024-03-15 15:48:20 +08:00
Alexey Milovidov
c9fb8ef54b Merge branch 'master' into split-cast-overload-resolver 2024-03-15 07:09:51 +01:00
Nikolai Kochetov
1cae77997a Try revert stage back 2024-03-14 21:34:25 +00:00
avogar
e08eaebc99 Add sanity check for poll_max_batch_size FileLog setting to avoid big untracked allocations 2024-03-14 20:36:18 +00:00
Anton Popov
edaf2c8023 Merge remote-tracking branch 'upstream/master' into HEAD 2024-03-14 17:06:22 +00:00
Dmitry Novik
90669ef487 Merge remote-tracking branch 'origin/master' into analyzer-distr-json 2024-03-14 17:43:26 +01:00
Dmitry Novik
0b3b734c9b Analyzer: Fix planner context for subquery in StorageMerge 2024-03-14 17:37:49 +01:00
Kseniia Sumarokova
ceeb926fa8
Merge branch 'master' into add-zk-retries 2024-03-14 17:27:40 +01:00
kssenii
b778b01408 Add settings 2024-03-14 16:39:32 +01:00
Dmitry Novik
d558c4dcb7 Cleanup 2024-03-14 16:17:58 +01:00
Dmitry Novik
e145115ef1 Fixup 2024-03-14 16:15:06 +01:00
Antonio Andelic
026ac4deb1 Fix heap-use-after-free for Merge table with alias 2024-03-14 14:20:22 +00:00
Robert Schulze
06d917fcf0
Merge pull request #61150 from rschu1ze/clang-tidy-list
Some clang-tidy fixes
2024-03-14 14:54:41 +01:00
vdimir
0b97f3ac16
Merge pull request #61320 from ClickHouse/vdimir/fix_rabbitmq_logical_error
Fix logical error in RabbitMQ storage with MATERIALIZED columns
2024-03-14 13:28:05 +01:00
Alexey Milovidov
8094dd88d9 Merge branch 'master' into split-cast-overload-resolver 2024-03-14 13:08:37 +01:00
Alexey Milovidov
1a41aa4ac7 Merge branch 'master' of github.com:ClickHouse/ClickHouse into split-cast-overload-resolver 2024-03-14 13:06:23 +01:00
divanik
9c77aa9510 Merge branch 'master' of github.com:ClickHouse/ClickHouse into divanik/generate_series_function 2024-03-14 11:41:14 +00:00
Kruglov Pavel
56220b5105
Revert "Revert "Fix usage of session_token in S3 engine"" 2024-03-14 12:23:32 +01:00
Antonio Andelic
c6f0b2a5a4
Revert "Fix usage of session_token in S3 engine" 2024-03-14 11:57:03 +01:00
Robert Schulze
3486b4a6e3
Merge remote-tracking branch 'rschu1ze/master' into clang-tidy-list 2024-03-14 10:44:20 +00:00
jsc0218
b3b46ea708 Merge remote-tracking branch 'origin/master' into TableEngineGrant_version2 2024-03-14 00:36:29 +00:00
kssenii
208a91a2f7 Add retries exists check in loadOutdatedDataParts 2024-03-13 19:03:29 +01:00
Jake Bamrah
5e66cd7154 fix settings seg-fault and expand test case coverage 2024-03-13 18:47:13 +01:00
Yarik Briukhovetskyi
4aab1170ef fix style 2024-03-13 18:47:13 +01:00
Yarik Briukhovetskyi
77223d682d reload tests 2024-03-13 18:47:13 +01:00
Jake Bamrah
c73e299820 add size cap to memory tables 2024-03-13 18:47:13 +01:00
Kruglov Pavel
843e2dc968
Merge pull request #60586 from Avogar/fix-filter-virtual-columns
Fix reading from MergeTree with non-deterministic functions in filter
2024-03-13 18:22:12 +01:00
vdimir
b2e067b3da
Fix logical error in RabbitMQ storage with MATERIALIZED columns 2024-03-13 16:41:35 +00:00
Kruglov Pavel
dd0caaf9b4
Merge pull request #61234 from ClickHouse/Avogar-patch-2
Fix usage of session_token in S3 engine
2024-03-13 17:05:39 +01:00
divanik
cf639bab44 Fix attach bug 2024-03-13 13:37:26 +00:00
Dmitry Novik
80723134d6 Fix fast test #ci_set_analyzer 2024-03-13 14:00:57 +01:00
Dmitry Novik
ffdb84b8df Fix style 2024-03-13 13:38:23 +01:00
Dmitry Novik
1a47682c12 Analyzer: Fix virtual columns in StorageMerge #ci_set_analyzer 2024-03-13 13:08:12 +01:00
Dmitry Novik
2e49140de7 Small progress 2024-03-13 11:37:42 +01:00
Dmitry Novik
5ef241cc85 WIP on virtual columns in StorageMerge 2024-03-13 11:30:11 +01:00
unashi
da06ba432e [fix] merge and resolve problems 2024-03-13 12:09:35 +08:00
Alexey Milovidov
146e401851 Merge branch 'master' into split-cast-overload-resolver 2024-03-13 04:28:24 +01:00
unashi
c78224c2ff Merge branch 'master' into feat-59377 2024-03-13 11:24:00 +08:00
divanik
3c2514bc77 Correct small issues 2024-03-12 18:33:32 +00:00
Anton Popov
f35987928b free memory earlier in inserts 2024-03-12 18:05:14 +00:00
Anton Popov
fc648439f3
Merge branch 'master' into add-virtual-columns 2024-03-12 18:00:12 +01:00
divanik
8f44201f92 Preliminary commit 2024-03-12 16:22:33 +00:00
Azat Khuzhin
fb0ad3eb15 Disable retries for replicated fetches (they are handled by the engine itself)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-12 17:08:42 +01:00
Azat Khuzhin
df44ed173c Fix missed entries in system.part_log in case of fetch preferred over merges/mutations
The NEED_PREPARE do not call part_log_writer() before.

v2:
- Add a test for missed entries in system.part_log for merge
- Fix part_log_writer
- Add a test for missed entries in system.part_log for mutate

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-12 17:08:42 +01:00
Kseniia Sumarokova
3257bfa918
Merge branch 'master' into traverse_shadow_remote_data_paths 2024-03-12 15:18:52 +01:00
Robert Schulze
1b1685e3f1
Merge remote-tracking branch 'rschu1ze/master' into clang-tidy-list 2024-03-12 13:02:59 +00:00
Kruglov Pavel
d431276045
Fix usage of session_token in S3 2024-03-12 12:43:48 +01:00
serxa
defed92331 do nothing in waitForOutdatedPartsToBeLoaded() if loading is not required 2024-03-12 11:38:27 +00:00
Kseniia Sumarokova
61543edc8b
Merge branch 'master' into fix-usage-of-plain-metadata 2024-03-12 11:53:00 +01:00
vdimir
439fe42f88
Merge pull request #61013 from ClickHouse/vdimir/fix_astrename_clone
Fix ASTRenameQuery::clone
2024-03-12 11:13:28 +01:00
Azat Khuzhin
6c74ab18c0 Do not clean mutations for MergeTree on DROP PART (to match ReplicatedMergeTree)
Even if this should be done, only related mutations should be cleaned,
not all.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-12 10:39:41 +01:00
Azat Khuzhin
f559767d22 Fix finished_mutations_to_keep=0 for MergeTree (as docs says 0 is to keep everything)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-12 10:39:41 +01:00
unashi
c1b94b2170 [debug] fast test again again 2024-03-12 15:33:43 +08:00
Zhuo Qiu
05969a39f3 resolve conflicts 2024-03-12 14:45:25 +08:00
unashi
10c7ea7a29 [debug] fast test again 2024-03-12 14:32:07 +08:00
Alexey Milovidov
5222ebc4b4 Merge branch 'master' of github.com:ClickHouse/ClickHouse into split-cast-overload-resolver 2024-03-12 06:37:38 +01:00
Alexey Milovidov
bdc884dfa5
Merge pull request #60255 from ClickHouse/dont-load-useless-index-parts-in-memory
Do not load useless columns from the index in memory
2024-03-12 08:30:53 +03:00
Zhuo Qiu
4ad8141a16 Maintain compatibility of estimateNeededDiskSpace()
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2024-03-12 13:07:46 +08:00
Zhuo Qiu
c628eaca8b Consider deleted rows when selecting parts to merge 2024-03-12 13:07:39 +08:00
Alexey Milovidov
bd4f948f12
Merge pull request #61058 from ClickHouse/rip-copier
Delete `clickhouse-copier`
2024-03-12 07:15:48 +03:00
unashi
2ae184f298 Merge branch 'feat-59377' of https://github.com/Unalian/ClickHouse into feat-59377 2024-03-12 12:12:05 +08:00
unashi
29fce4143d [fix] log level from fatal->error when hardlink and copy both fail 2024-03-12 12:07:24 +08:00
Alexey Milovidov
c3a839d595 Merge pull request #61127 from ClickHouse/remove-in-memory-data-parts-2
Remove in-memory data parts, part 3.
2024-03-12 07:07:07 +03:00
Nikita Mikhaylov
fcf8a3821d Merge branch 'master' of github.com:ClickHouse/ClickHouse into rip-copier 2024-03-11 19:12:49 +01:00
Nikita Mikhaylov
cfa042cb04 Merge branch 'master' of github.com:ClickHouse/ClickHouse into rip-copier 2024-03-11 15:45:20 +00:00
Anton Popov
db48b9749b better _part_offset column 2024-03-11 15:35:17 +00:00
avogar
ecc30448ba Fix filtering when optimize_use_implicit_projections=1 2024-03-11 15:26:29 +00:00
avogar
f6d7b39dfc Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-filter-virtual-columns 2024-03-11 15:05:52 +00:00
Anton Popov
2fabec2b9d Merge remote-tracking branch 'upstream/master' into HEAD 2024-03-11 14:42:18 +00:00
Anton Popov
2bec92c48e better _part_offset column 2024-03-11 14:41:50 +00:00
Kseniia Sumarokova
e59564a9d9
Merge branch 'master' into traverse_shadow_remote_data_paths 2024-03-11 13:19:05 +01:00
vdimir
38b8e7ac7e
Maintain list of ASTRenameQuery children 2024-03-11 11:34:10 +00:00
serxa
b1d1c8eb0c Merge branch 'master' into revert-60253-revert-59032-cpu-scheduler-and-cc 2024-03-11 11:25:53 +00:00
Robert Schulze
e5e84419af
Fix clang-tidy-s 2024-03-11 10:58:54 +00:00
Kseniia Sumarokova
3832b0e126
Merge branch 'master' into add-a-way-to-force-read-through-filesystem-cache-for-merges 2024-03-11 11:30:03 +01:00
Kseniia Sumarokova
aacfefe0fe
Merge branch 'master' into fix-usage-of-plain-metadata 2024-03-11 10:37:53 +01:00
Alexey Milovidov
4373d5ba16 Merge branch 'master' into split-cast-overload-resolver 2024-03-11 03:01:50 +01:00
Alexey Milovidov
8a484a44e3 Merge branch 'master' into dont-load-useless-index-parts-in-memory 2024-03-11 02:10:20 +01:00
Alexey Milovidov
2550f9d284
Merge branch 'master' into remove-in-memory-data-parts-2 2024-03-11 01:44:20 +03:00
serxa
5b796e1f42 Merge branch 'master' into async-loader-waiters-limit 2024-03-10 15:20:27 +00:00
alesapin
253a29d528 Merge branch 'master' into fix_max_insert_delayed_streams_for_parallel_write 2024-03-10 15:34:13 +01:00
kssenii
0b63cb237a Fix 2024-03-10 15:33:06 +01:00
Sema Checherinda
80179e50e4
Merge pull request #58845 from ClickHouse/chesema-session-pool
HTTP connections pool
2024-03-10 14:06:59 +01:00
Alexey Milovidov
2cc071e0e4 Fix error 2024-03-10 12:48:15 +01:00
Alexey Milovidov
1d8b95bdcd
Update MergeTask.cpp 2024-03-10 14:43:18 +03:00
Alexey Milovidov
6a0eb7a3cd
Update ColumnSizeEstimator.h 2024-03-10 14:42:58 +03:00
Kseniia Sumarokova
ae98d4290c
Merge branch 'master' into traverse_shadow_remote_data_paths 2024-03-10 12:16:54 +01:00
kssenii
e5e6625b0c Merge remote-tracking branch 'origin/master' into fix-usage-of-plain-metadata 2024-03-10 12:05:02 +01:00
Alexey Milovidov
d340d9cfaf Fix build 2024-03-10 10:05:07 +01:00
Alexey Milovidov
dbb6dad921 Fix style 2024-03-10 10:04:40 +01:00
Alexey Milovidov
69cab686e4 Fix build of examples 2024-03-10 10:03:31 +01:00
Kseniia Sumarokova
7e7fc4127d
Merge branch 'master' into revert-refert-of-broken-projections-handling 2024-03-10 10:01:34 +01:00
Sema Checherinda
77c5de700f fix how web disk read empty directories 2024-03-10 10:00:18 +01:00
Sema Checherinda
5c41727725 http connections pools 2024-03-10 10:00:18 +01:00
Alexey Milovidov
9ddec346a0 Miscellaneous 2024-03-10 09:02:34 +01:00
Alexey Milovidov
d337379385 Remove in-memory data parts, step 2 2024-03-10 06:44:26 +01:00
Alexey Milovidov
b07e5d9f5a
Update StorageMergeTree.cpp 2024-03-10 08:11:59 +03:00
Alexey Milovidov
c7e7f03eae Merge branch 'master' of github.com:ClickHouse/ClickHouse into dont-load-useless-index-parts-in-memory 2024-03-09 03:58:31 +01:00
Nikita Mikhaylov
f73a8f2eae
More comments for column for system tables (#59016) 2024-03-08 18:05:56 +01:00
Dmitry Novik
526af77f4a
Merge pull request #60313 from ClickHouse/analyzer-refactor-constant-name
Analyzer: Refactor execution name for ConstantNode
2024-03-08 12:08:05 +01:00
Nikita Taranov
e66ac5770c
Merge pull request #60462 from ClickHouse/davenger-patch-1
Do not check to and from files existence in metadata_storage because it does not see uncommitted changes
2024-03-08 00:26:58 +01:00
Nikita Mikhaylov
2bc4d27ac6 Bye bye 2024-03-07 19:24:39 +00:00
serxa
0f0ea422f2 separate limits on number of waiting and executing queries 2024-03-07 17:05:54 +00:00
Anton Popov
88d8880267 better virtual columns and tests added 2024-03-07 14:56:45 +00:00
Anton Popov
ec926ea6e4 Merge remote-tracking branch 'upstream/master' into HEAD 2024-03-07 13:22:20 +00:00
Dmitry Novik
23b33e5e32 Merge remote-tracking branch 'origin/master' into analyzer-refactor-constant-name 2024-03-07 14:18:44 +01:00
Anton Popov
c103b0084b
Merge pull request #60205 from CurtizJ/refactor-virtual-columns
Refactoring of virtual columns
2024-03-07 13:38:35 +01:00
Amos Bird
f2a3ffe9eb
Replace some headers with forward decl 2024-03-07 18:10:09 +08:00
Kseniia Sumarokova
8fc3581446
Merge branch 'master' into fix-usage-of-plain-metadata 2024-03-07 14:29:57 +08:00
Nikita Taranov
2b52583e06 fix style 2024-03-06 23:01:42 +01:00
Nikita Taranov
c192d0b125 impl 2024-03-06 22:29:41 +01:00
Igor Nikonov
a3c22f9ace
Merge pull request #60675 from ClickHouse/use-minmax-indices-always-first
Always apply first minmax index among available skip indices
2024-03-06 21:25:49 +01:00
Nikita Taranov
d008b4eb4f fix test 2024-03-06 20:24:38 +01:00
Dmitry Novik
d92538ced2
Merge branch 'master' into analyzer-refactor-constant-name 2024-03-06 17:55:52 +01:00
Anton Popov
c8878332ca fix StorageSystemDictionaries 2024-03-06 16:46:59 +00:00
Sema Checherinda
8ac2ef6608
Merge pull request #57575 from ClickHouse/chesema-drop-zk-table-node
drop keeper dir with zero copy locks
2024-03-06 17:43:35 +01:00
vdimir
56b6810122
Merge pull request #60641 from ClickHouse/vdimir/analyzer/comute_alias_columns
Resubmit "Analyzer: compute ALIAS columns right after reading"
2024-03-06 16:52:16 +01:00
Anton Popov
1c0aed896c fix build 2024-03-06 15:25:06 +00:00
Kruglov Pavel
5b94f9b411
Check children first 2024-03-06 15:31:19 +01:00
Anton Popov
f582797b36 Merge remote-tracking branch 'upstream/master' into HEAD 2024-03-06 14:14:42 +00:00
Dmitry Novik
016bbfe6f8 Merge remote-tracking branch 'origin/master' into analyzer-distr-json 2024-03-06 15:09:52 +01:00
Igor Nikonov
d64abe2449 Merge remote-tracking branch 'origin/master' into use-minmax-indices-always-first 2024-03-06 13:51:55 +00:00
Dmitry Novik
7065e650e1 Code cleanup 2024-03-06 14:34:03 +01:00
kssenii
6d4514c045 Fix test 2024-03-06 16:55:48 +08:00
unashi
3dbb0a12fb [fix] style 2024-03-06 16:15:37 +08:00
Nikolai Kochetov
b040eadaa1
Merge pull request #60510 from ClickHouse/refactor-system-one-block
Refactor StorageSystemOneBlock
2024-03-06 08:55:50 +01:00
Sema Checherinda
8b2bd2125b no warnings at drop 2024-03-05 19:06:09 +01:00
Anton Popov
7fe7f3a79d address review comments 2024-03-05 16:03:02 +00:00
Nikolai Kochetov
97f955fcde Fix sanitizers 2024-03-05 14:10:46 +00:00
Dmitry Novik
04370083bb Merge remote-tracking branch 'origin/master' into analyzer-refactor-constant-name 2024-03-05 14:57:00 +01:00
Nikolai Kochetov
86ad80839a Merge pull request #60515 from ClickHouse/cleanup-lazy-format-always
PullingAsyncPipelineExecutor cleanup
2024-03-05 13:12:07 +01:00
vdimir
6f3e9b6de2
Merge branch 'master' into vdimir/analyzer/comute_alias_columns 2024-03-05 13:08:58 +01:00
Antonio Andelic
0bd4c6afa0 Use while-loop 2024-03-05 11:53:51 +01:00
Nikolai Kochetov
ee3edf2589 Fix system parts _state 2024-03-05 10:40:45 +00:00
Aleksei Filatov
f7d8dd0b71
Merge branch 'master' into traverse_shadow_remote_data_paths 2024-03-05 10:11:07 +03:00
Aleksei Filatov
758a75c1b4 Fix flaky test. Fix clang-tidy warning 2024-03-05 09:53:30 +03:00
Kseniia Sumarokova
dbbe6b9f69
Merge branch 'master' into add-a-way-to-force-read-through-filesystem-cache-for-merges 2024-03-05 11:13:32 +08:00
unashi
aa43885ac8 [improve] add check the remaining disk size before copying 2024-03-05 10:57:25 +08:00
Nikolai Kochetov
819e7bfc77 Merge branch 'master' into refactor-system-one-block 2024-03-04 21:03:45 +00:00
Igor Nikonov
ee4e5b1592 Merge remote-tracking branch 'origin/master' into use-minmax-indices-always-first 2024-03-04 18:29:05 +00:00
Nikolai Kochetov
d209508753 Fixing style. 2024-03-04 18:26:42 +00:00
Kruglov Pavel
4bdafed801
Merge pull request #60420 from HowePa/format_case_insensitive
Make all format names case insensitive.
2024-03-04 19:09:10 +01:00
Nikolai Kochetov
47d8f039e5 Cleanup VirtualColumnUtils 2024-03-04 18:01:12 +00:00
Nikolai Kochetov
2d8ca99860 Refactor more system storages. 2024-03-04 17:48:47 +00:00
Alexey Milovidov
ce6dec65cf
Merge pull request #60729 from ClickHouse/remove-more-live-view
Remove more code from LIVE VIEW
2024-03-04 18:58:21 +03:00
Alexey Milovidov
de6c5d3a40
Merge pull request #60552 from ClickHouse/pc2
Userspace page cache again
2024-03-04 17:47:35 +03:00
Dmitry Novik
01829450fb Merge remote-tracking branch 'origin/master' into analyzer-refactor-constant-name 2024-03-04 14:12:15 +01:00
Igor Nikonov
815e3db6f5 Merge remote-tracking branch 'origin/master' into use-minmax-indices-always-first 2024-03-04 10:09:44 +00:00
Alexey Milovidov
fc6f3c8399 Live view's life is close to the end 2024-03-04 00:49:22 +01:00
Alexey Milovidov
cbf5443585 Remove old code 2024-03-04 00:11:55 +01:00
Azat Khuzhin
707200d2a4 Fix system.parts for non-Atomic/Ordinary database engine (i.e. Memory)
Previously the code assumes that only Ordinary do not have UUID, while
this is not true, Memory (at least) does not has it as well.

One of the major users of Memory engine is clickhouse-local.

v2: check UUID instead of database engine
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-03 10:27:06 +01:00
jsc0218
2b54c11d63
Merge branch 'ClickHouse:master' into TableEngineGrant_version2 2024-03-02 20:42:04 -05:00
Igor Nikonov
491a4e8d4b Merge remote-tracking branch 'origin/master' into use-minmax-indices-always-first 2024-03-02 21:31:28 +00:00
Alexey Milovidov
5dfe708de0
Merge pull request #60605 from ClickHouse/24.3-prepare
Update version after release
2024-03-02 04:56:21 +03:00
Anton Popov
1b9e6c936e better interfaces for virtual columns 2024-03-01 22:29:56 +00:00
Anton Popov
dd400dedf2 add virtual column _data_version 2024-03-01 19:51:14 +00:00
Anton Popov
dcff866c9f add virtual column _block_offset 2024-03-01 19:36:49 +00:00
Igor Nikonov
754ae8792d Always apply first minmax index among available skip indices 2024-03-01 19:31:15 +00:00
Anton Popov
1a1e78cf63 temporary remove virtual column 2024-03-01 18:52:14 +00:00
Anton Popov
95611889dc fix tests 2024-03-01 18:44:33 +00:00
Igor Nikonov
a28385966c
Merge pull request #60513 from ClickHouse/cleanup-random-progress-bar
Simple cleanup while fixing progress bar
2024-03-01 16:51:46 +01:00
vdimir
47aa33408b
Resubmit "Analyzer: compute ALIAS columns right after reading"
This reverts commit 8141e1c3d1, reversing
changes made to fb099bbd62.
2024-03-01 14:53:02 +00:00
Nikolai Kochetov
2811b24a47 Fixing build 2024-03-01 14:42:46 +00:00
Nikolai Kochetov
af5dae58ca Merge branch 'master' into refactor-system-one-block 2024-03-01 13:42:00 +00:00
Igor Nikonov
ae7f780ce4
Merge pull request #60491 from ClickHouse/fix-cluster-table-func-progress-bar
Fix: progress bar for *Cluster table functions
2024-03-01 14:12:59 +01:00
Nikolai Kochetov
447f0817d5 Fixing build 2024-03-01 12:08:51 +00:00
Robert Schulze
3a5c9b627b
Merge remote-tracking branch 'rschu1ze/master' into clang-tidy-src 2024-03-01 10:31:55 +00:00
Kseniia Sumarokova
5ac53c9578
Merge branch 'master' into add-a-way-to-force-read-through-filesystem-cache-for-merges 2024-03-01 11:05:47 +08:00
Alexey Milovidov
ac4cbe3d12 Update autogenerated version to 24.3.1.1 and contributors 2024-02-29 22:08:31 +01:00
Julia Kartseva
891689a415
Merge pull request #60196 from azat/preliminary-filters-fix
Fix actions execution during preliminary filtering (PK, partition pruning)
2024-02-29 10:17:05 -08:00
Anton Popov
8a4e15536b refactoring of virtual columns 2024-02-29 18:01:54 +00:00
Raúl Marín
28820dad82
Merge pull request #60498 from ZhiguoZh/20240228-andfilter-opt
Auto-vectorize DB::andFilters
2024-02-29 17:02:09 +01:00
Robert Schulze
4ee1aa8c7c
Fixing more headers 2024-02-29 15:40:30 +00:00
avogar
09a392772d Use isDeterministicInScopeOfQuery 2024-02-29 15:34:45 +00:00
Nikita Taranov
f9d1c5769e
Merge branch 'master' into express_support 2024-02-29 16:26:43 +01:00
avogar
7632c2c33f Remove non-deterministic functions in virtual columns filter 2024-02-29 15:17:12 +00:00
Aleksei Filatov
8b1a1d42da Traverse shadow directory for system.remote_data_paths 2024-02-29 18:07:00 +03:00
Michael Kolupaev
cc893ad33c Merge remote-tracking branch 'origin/master' into pc2 2024-02-29 13:30:04 +00:00
Alexander Tokmakov
2dedfd6cf9
Revert "Analyzer: compute ALIAS columns right after reading" 2024-02-29 14:22:07 +01:00
Igor Nikonov
2f4585f653 Merge remote-tracking branch 'origin/master' into fix-cluster-table-func-progress-bar 2024-02-29 13:11:11 +00:00
Igor Nikonov
a8ee493b67 Merge remote-tracking branch 'origin/master' into cleanup-random-progress-bar 2024-02-29 13:09:20 +00:00
Sergei Trifonov
f8561b2265
Revert "Revert "Support resource request canceling"" 2024-02-29 13:53:27 +01:00
Michael Kolupaev
42437a2ae1 Userspace page cache (#53770)
* Userspace page cache

* Maybe it'll build this time, who knows.

* 'auto' went out of fashion, I guess

* Documentation, tsan workaround, metric 'UnreclaimableRss', disable page cache in the test that uses DatabaseOrdinary

* Moved CachedInMemoryReadBufferFromFile to object store level, changed settings, addressed other comments.

* Fix

* Another fix

* Fix restricted seek, fix ppc64le build

* Don't allow page cache with file cache

* Adjust tests a little

* Fix clang-tidy

* Conflicts

* Comments

* Maybe unbroke AsynchronousBoundedReadBuffer

* SettingsChangesHistory.h

* Fix warning in test
2024-02-29 12:28:32 +00:00
Alexander Tokmakov
15e1191f74
Revert "Userspace page cache (#53770)"
This reverts commit 7b55c61551.
2024-02-29 13:20:17 +01:00
Michael Kolupaev
7b55c61551
Userspace page cache (#53770)
* Userspace page cache

* Maybe it'll build this time, who knows.

* 'auto' went out of fashion, I guess

* Documentation, tsan workaround, metric 'UnreclaimableRss', disable page cache in the test that uses DatabaseOrdinary

* Moved CachedInMemoryReadBufferFromFile to object store level, changed settings, addressed other comments.

* Fix

* Another fix

* Fix restricted seek, fix ppc64le build

* Don't allow page cache with file cache

* Adjust tests a little

* Fix clang-tidy

* Conflicts

* Comments

* Maybe unbroke AsynchronousBoundedReadBuffer

* SettingsChangesHistory.h

* Fix warning in test
2024-02-29 11:27:32 +00:00
vdimir
5dd81f38fb
Merge pull request #59595 from ClickHouse/vdimir/analyzer/comute_alias_columns
Analyzer: compute ALIAS columns right after reading
2024-02-29 10:28:31 +01:00
Antonio Andelic
049e46c500
Merge pull request #60477 from ClickHouse/fix-s3cluster
Correctly check keys in s3Cluster
2024-02-29 09:20:32 +01:00
Nikita Taranov
974ba7364f better 2024-02-29 00:55:17 +01:00
Alexey Milovidov
e1e66dc2b8
Merge pull request #60095 from ClickHouse/fix-inconsistent-formatting
Fix inconsistent formatting of queries
2024-02-29 00:41:40 +03:00
Alexander Tokmakov
25c82a5949
Merge pull request #57798 from kirillgarbar/modify-engine
Convert MergeTree tables to replicated on server restart if flag is set
2024-02-28 21:55:15 +01:00
Igor Nikonov
627aa62d21 Simple cleanup while fixing progress bar 2024-02-28 20:40:17 +00:00
Anton Popov
0ceeb13b7f refactoring of virtual columns 2024-02-28 19:58:55 +00:00
Nikolai Kochetov
53714e6f7a Refactor StorageSystemOneBlock 2024-02-28 19:10:00 +00:00
jsc0218
24342012ff fix 2024-02-28 18:11:33 +00:00
Raúl Marín
4023e67ac5
Merge pull request #60138 from Algunenano/max_threads_sanity
Add sanity check for number of threads and block size
2024-02-28 19:05:55 +01:00
Anton Popov
0fa22abb95 refactoring of virtual columns 2024-02-28 17:05:00 +00:00
Igor Nikonov
9bd633cdf6 Fix: *Cluster table functions progress bar 2024-02-28 16:28:28 +00:00
Alexey Milovidov
8a272ffd8f
Merge pull request #60466 from ClickHouse/HarryLeeIBM-hlee-ftsearch-test
Merge #57434
2024-02-28 19:27:54 +03:00
Igor Nikonov
ad8029d2fd Fix: progress bar for *Cluster table functions 2024-02-28 16:26:06 +00:00
Alexey Milovidov
b0ab0b37db
Merge pull request #60434 from ClickHouse/revert-60216-revert-59697-check-stack-size-in-parser
Revert "Revert "Check stack size in Parser""
2024-02-28 19:20:49 +03:00
Alexey Milovidov
1950a75bd4 Merge branch 'master' into fix-inconsistent-formatting 2024-02-28 17:10:29 +01:00
jsc0218
b4b19ae2ad
Merge branch 'master' into TableEngineGrant_version2 2024-02-28 10:56:30 -05:00
Nikolai Kochetov
8dd08e9844
Merge pull request #59710 from GrigoryPervakov/master
Support sql created named collections in Kafka Storage for librdkafka settings
2024-02-28 16:38:56 +01:00
Anton Popov
9f8ac76345 Merge remote-tracking branch 'upstream/master' into HEAD 2024-02-28 14:42:37 +00:00
Dmitry Novik
0de2d766fa WIP on different JSONs on shards 2024-02-28 15:30:06 +01:00
Zhiguo Zhou
ae06e34ea9 Auto-vectorize DB::andFilters
DB::MergeTreeRangeReader::ReadResult::optimize adds the current
filter to the final one either via DB::combineFilters when both
filters have different sizes or otherwise via DB::andFilters, which
performs the logical AND operation (&&) to two UInt8 columns.

To vectorize DB::andFilters automatically, this commit performs NOT
operation to the operands twice so that the non-zeros are converted
to bool value of true (0x01) and the zeros to false (0x00), and via
this change the logical AND (&&) could be safely replaced with the
bitwise AND (&), which could be recognized and optimized by the
compiler.
2024-02-28 20:08:24 +08:00
Vitaly Baranov
926295f763
Merge pull request #60040 from vitlibar/use-multiple-threads-while-reading-metadata-for-restore
Use multiple threads while reading the metadata of tables to restore
2024-02-28 11:07:15 +01:00
Antonio Andelic
c4ae61f6e6 Correctly check prefetch buffer 2024-02-28 09:58:47 +01:00
pufit
330a206470
Add definers for views (Attempt 2) (#60439) 2024-02-27 19:00:17 -05:00
Anton Popov
3cdd3495fd
Merge pull request #60435 from CurtizJ/return-back-58140
Revert "Revert "Add table function `mergeTreeIndex`""
2024-02-28 00:52:44 +01:00
Alexey Milovidov
8cf619bc03 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-28 00:30:44 +01:00
Alexey Milovidov
9ea7ff231b
Merge pull request #60448 from ClickHouse/clang-19
Update to clang-19
2024-02-27 23:38:08 +03:00
Alexey Milovidov
2ab722214c Merge branch 'hlee-ftsearch-test' of github.com:HarryLeeIBM/ClickHouse into HarryLeeIBM-hlee-ftsearch-test 2024-02-27 20:29:46 +01:00
Pervakov Grigorii
d3b82ab7c1 Support sql created named collections in Kafka Storage for librdkafka settings 2024-02-27 18:36:36 +00:00
Alexey Milovidov
0f3c9963d1 Merge branch 'master' of github.com:ClickHouse/ClickHouse into revert-60216-revert-59697-check-stack-size-in-parser 2024-02-27 17:30:32 +01:00
Raúl Marín
f8ff15a023
Merge pull request #60429 from Algunenano/fix_unlimited_keeper
Fix unrestricted reads from keeper
2024-02-27 17:28:15 +01:00
Dmitry Novik
33ae650e6a Merge remote-tracking branch 'origin/master' into analyzer-refactor-constant-name 2024-02-27 16:35:28 +01:00
kssenii
ffd69e0e12 Move setting to merge-tree level 2024-02-27 23:22:04 +08:00
Robert Schulze
466cf93ee2
Merge pull request #60450 from rschu1ze/starts_with
Minor: Replace `boost::algorithm::starts_with()` by `std::string::starts_with()`
2024-02-27 16:21:02 +01:00
Robert Schulze
0f6bec7842
Merge pull request #59291 from azat/dist/config-settings
Support specifying settings for Distributed engine in config (like for MergeTree)
2024-02-27 16:10:51 +01:00
kssenii
7ac453ab4c Revert "Merge pull request #60436 from nickitat/revert_56864"
This reverts commit 8719a601fa, reversing
changes made to 657857f982.
2024-02-27 23:06:14 +08:00
Alexey Milovidov
ecbae90743 Remove unused file 2024-02-27 15:36:39 +01:00
Nikita Mikhaylov
8719a601fa
Merge pull request #60436 from nickitat/revert_56864
Revert "Merge pull request #56864 from ClickHouse/broken-projections-better-handling"
2024-02-27 15:25:15 +01:00
Alexey Milovidov
c192a448d0 Update to clang-19 2024-02-27 14:37:21 +01:00
Robert Schulze
62c12cbfca
Replace boost::algorithm::starts_with() by std::string::starts_with() 2024-02-27 10:42:47 +00:00
Nikita Taranov
854f1b064b Revert "Merge pull request #56864 from ClickHouse/broken-projections-better-handling"
This reverts commit caaafbcedb, reversing
changes made to d45b248f96.
2024-02-27 00:13:28 +01:00
Anton Popov
d683977fe9 Revert "Revert "Add table function mergeTreeIndex""
This reverts commit 1e4199d704.
2024-02-26 22:47:39 +00:00
Alexey Milovidov
04fe5dc55c Merge branch 'master' into fix-inconsistent-formatting 2024-02-26 23:46:24 +01:00
Alexey Milovidov
5b1a07053e Merge branch 'master' into dont-load-useless-index-parts-in-memory 2024-02-26 23:39:53 +01:00
Alexey Milovidov
0b90076a36
Revert "Revert "Check stack size in Parser"" 2024-02-27 01:34:50 +03:00
Robert Schulze
4794dc28f0
Merge remote-tracking branch 'ClickHouse/master' into dist/config-settings 2024-02-26 21:57:33 +00:00
Kirill Nikiforov
8b314a3ac8
Implement system.dns_cache table and dns_cache_max_size server setting (#60257)
* system.dns_cache table WIP

* system.dns_cache table

* rollback unexpected contrib changes

* rollback unexpected changes

* add docs

* code style fixes

* optimize dns cache exporting

* stateful test for system.dns_cache table

* stateful test for system.dns_cache table

* cr fixes

* stateful test for system.dns_cache table

* stateful test for system.dns_cache table

* implement system.dns_cache table

* system.dns_cache test

* system.dns_cache fix docs

* system.dns_cache prettify

* dns_cache_max_size settings

* fix system.dns_cache test

* Update dns_cache.md

* fix doc

Co-authored-by: pufit <pufit@clickhouse.com>

---------

Co-authored-by: pufit <pufit@clickhouse.com>
2024-02-26 15:48:02 -05:00
Raúl Marín
8a161bdc0a Fix unrestricted reads from keeper 2024-02-26 19:38:00 +01:00
Alexander Tokmakov
1e4199d704
Revert "Add table function mergeTreeIndex" 2024-02-26 19:37:06 +01:00
Alexey Milovidov
a3f1411679 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-26 19:01:11 +01:00
HowePa
dbd8d35f01 use lower case in dict 2024-02-27 00:48:34 +08:00
vdimir
9f1a0734a1
review fix 2024-02-26 16:15:14 +00:00
vdimir
5a9026f39b
Analyzer: compute ALIAS columns right after reading 2024-02-26 16:15:05 +00:00
Anton Popov
814cd53918
Merge pull request #58140 from CurtizJ/storage-merge-tree-index
Add table function `mergeTreeIndex`
2024-02-26 16:31:56 +01:00
Dmitry Novik
42b91201a5 Merge remote-tracking branch 'origin/master' into analyzer-refactor-constant-name 2024-02-26 15:11:57 +00:00
HowePa
ea89fa0de9 replace to checkFormatName 2024-02-26 23:07:50 +08:00
Robert Schulze
1e40b63cb1
Merge remote-tracking branch 'ClickHouse/master' into dist/config-settings 2024-02-26 11:15:51 +00:00
Raúl Marín
f84209be2f Merge remote-tracking branch 'blessed/master' into max_threads_sanity 2024-02-26 11:56:29 +01:00
Alexey Milovidov
bf75d2878b Merge branch 'master' into fix-inconsistent-formatting 2024-02-26 00:09:02 +01:00
Amos Bird
38427fff35
Better name 2024-02-26 02:32:00 +08:00
Amos Bird
d577d1e4e2
Fix something 2024-02-26 02:32:00 +08:00
Amos Bird
534da3f40f
Fix more tests 2024-02-26 02:31:59 +08:00
Amos Bird
6137914604
Fix most tests 2024-02-26 02:31:58 +08:00
Amos Bird
8a1e23dcc4
Fix more tests 2024-02-26 02:31:57 +08:00
Amos Bird
7435568a0d
Fix tests 2024-02-26 02:31:57 +08:00
Amos Bird
c5e073320c
Unify prewhere optimization 2024-02-26 02:31:56 +08:00
Amos Bird
49352732cc
Fix more tests 2024-02-26 02:31:56 +08:00
Amos Bird
ffab16595e
Fix more tests 2024-02-26 02:31:55 +08:00
Amos Bird
07a0adceb9
Only use query_info.filter_actions_dag for key analysis 2024-02-26 02:31:55 +08:00
Nikita Taranov
835b47519a impl 2024-02-25 00:33:50 +01:00
Azat Khuzhin
a70a100db0 Support io_uring for StorageFile
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-24 19:36:58 +01:00
Vitaly Baranov
f944faec6f Fix using table_id in StorageKeeperMap. 2024-02-23 20:27:19 +01:00
Alexey Milovidov
da2ae34c1d Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-23 15:55:03 +01:00
Alexander Tokmakov
ef3b19167f
Merge pull request #58036 from MikhailBurdukov/backoff_for_failed_mutations
Backoff policy for failed mutation.
2024-02-23 15:27:41 +01:00
Alexey Milovidov
396402a9b6 Fix inconsistent formatting of operator function and nulls action 2024-02-23 15:22:21 +01:00
Nikita Mikhaylov
8fef0b71c4
Merge pull request #60350 from ClickHouse/revert-54901-pufit/views-sql-security
Revert "Add definers for views"
2024-02-23 15:15:36 +01:00
Dmitry Novik
d13b2a91c1 Fix virtual tables 2024-02-23 13:33:12 +00:00
Alexander Tokmakov
32607cc796
Merge pull request #60159 from ClickHouse/fix_create_replica
Skip sanity checks on secondary CREATE query
2024-02-23 13:53:47 +01:00
Sergei Trifonov
2c766cf75f
Merge pull request #59507 from ClickHouse/alter-table-forget-partition
Add `FORGET PARTITION` query to remove old partition nodes from ZooKeeper
2024-02-23 12:55:08 +01:00
Raúl Marín
464b5e0e15
Revert "Add definers for views (#54901)"
This reverts commit 57306706b3.
2024-02-23 12:44:31 +01:00
Raúl Marín
a431608dd4 Add sanity check for some settings 2024-02-23 12:32:17 +01:00
Kseniia Sumarokova
6a7fef13ba
Merge pull request #60282 from ClickHouse/s3queue-fix-bug-and-flaky-test
s3queue: fix bug (also fixes flaky test_storage_s3_queue/test.py::test_shards_distributed)
2024-02-23 11:57:34 +01:00
Dmitry Novik
81df9c5a27
Use possition to merge plans 2024-02-22 19:07:54 +01:00
Alexander Tokmakov
e56748a92c
Merge pull request #60044 from ClickHouse/fix_undead_sessions
Ability to detect undead ZooKeeper sessions
2024-02-22 18:13:15 +01:00
pufit
57306706b3
Add definers for views (#54901) 2024-02-22 17:47:50 +01:00
kssenii
f1e95fb78b Add a way to force read-through cache for merges 2024-02-22 15:40:00 +01:00
Azat Khuzhin
0cb6f205d7 Fix actions execution during preliminary filtering (PK, partition pruning)
Previously preliminary filtering works incorrectly if input columns had
been used multiple times, because:
- position initialized only for the first user
- column had been moved, so the second user will get nullptr

And this was the case when it had been required multiple times.

Consider the following example:

    select * from data final prewhere indexHint(_partition_id = 'all') or indexHint(_partition_id = 'all')

Actions for this PREWHERE is the following:

    (lldb) p actions.__ptr_->dumpActions()
    (std::string) $1 = "input:
    _partition_id LowCardinality(String)
    _partition_id LowCardinality(String)

    actions:
    INPUT : 0 -> _partition_id LowCardinality(String) : 0
    COLUMN Const(String) -> 'all' String : 1
    COLUMN Const(String) -> 'UInt8'_String String : 2
    INPUT : 1 -> _partition_id LowCardinality(String) : 3
    COLUMN Const(String) -> 'all' String : 4
    COLUMN Const(String) -> 'UInt8'_String String : 5
    FUNCTION equals(_partition_id :: 0, 'all' :: 1) -> equals(_partition_id, 'all') LowCardinality(UInt8) : 6
    FUNCTION equals(_partition_id :: 3, 'all' :: 4) -> equals(_partition_id, 'all') LowCardinality(UInt8) : 1
    FUNCTION _CAST(equals(_partition_id, 'all') :: 6, 'UInt8'_String :: 2) -> _CAST(equals(_partition_id, 'all'), 'UInt8'_String) UInt8 : 4
    FUNCTION _CAST(equals(_partition_id, 'all') :: 1, 'UInt8'_String :: 5) -> _CAST(equals(_partition_id, 'all'), 'UInt8'_String) UInt8 : 2
    FUNCTION or(_CAST(equals(_partition_id, 'all'), 'UInt8'_String) :: 4, _CAST(equals(_partition_id, 'all'), 'UInt8'_String) :: 2) -> or(indexHint(), indexHint())"...

It has _partition_id column in input multiple times.

So fix this by adding a flag (`allow_duplicates_in_input`), if set,
columns will be fully initialized.

v2: fix "Position out of bound in Block::erase()"
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-22 15:01:57 +01:00
Alexander Tokmakov
97ed2c05b0 Merge branch 'master' into fix_undead_sessions 2024-02-22 14:36:36 +01:00
Nikolai Kochetov
0e6b55ad35
Merge pull request #60220 from kitaisreal/system-backups-system-backup-log-add-query-id-and-error-stacktrace
Tables system.backups and system.backup_log add query_id and error stacktrace
2024-02-22 12:43:52 +01:00
kssenii
222323f293 Fix 2024-02-22 12:38:13 +01:00
Azat Khuzhin
a4f765cae7
Improve performance of SELECTs with active mutations (#59531)
* Configure keeper for perf tests

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Improve performance of SELECTs with active mutations

getAlterMutationCommandsForPart() can be a hot path for query execution
when there are pending mutations.

- LOG_TEST - it is not only check one bool, but actually a bunch of
  atomics as well.

- Return std::vector over std::map (map is not required there) - no
  changes in performance.

- Copy only RENAME_COLUMN (since only this mutation is required by
  AlterConversions).

And here are results:

run|result
-|-
SELECT w/o ALTER|queries: 1565, QPS: 355.259, RPS: 355.259
SELECT w/ ALTER unpatched|queries: 2099, QPS: 220.623, RPS: 220.623
SELECT w/ ALTER and w/o LOG_TEST|queries: 2730, QPS: 235.859, RPS: 235.859
SELECT w/ ALTER and w/o LOG_TEST and w/ RENAME_COLUMN only|queries: 2995, QPS: 290.982, RPS: 290.982

But there are still room for improvements, at least MergeTree engines
could implement getStorageSnapshotForQuery().

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Add AlterConversions::supportsMutationCommandType(), flatten vector<vector<MutationCommand>>

* Work around what appears to be a clang static analysis bug

---------

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Co-authored-by: Michael Kolupaev <michael.kolupaev@clickhouse.com>
2024-02-22 08:51:10 +00:00
Alexey Milovidov
e98d09c93e Do not load useless columns from the index in memory 2024-02-21 21:41:04 +01:00
Alexander Tokmakov
c5ab1893d7 Merge branch 'master' into modify-engine 2024-02-21 20:37:58 +01:00
Raúl Marín
453d4d30cf
Revert "Support resource request canceling" 2024-02-21 20:19:00 +01:00
Alexander Tokmakov
fcfea17657
Update gtest_storage_log.cpp 2024-02-21 20:16:14 +01:00
Anton Popov
c624e2fa8b fix style check 2024-02-21 18:56:28 +00:00
Anton Popov
6656cdb9fb refactoring of virtual columns 2024-02-21 17:24:12 +00:00
Anton Popov
3d57237fe8 refactoring of virtual columns 2024-02-21 16:40:27 +00:00
Sergei Trifonov
19e81c20ca
Merge pull request #59032 from ClickHouse/cpu-scheduler-and-cc
Support resource request canceling
2024-02-21 16:16:24 +01:00
serxa
69c5fae1bc review fixes 2024-02-21 15:11:50 +00:00
serxa
8b7ef7c895 assert is not needed 2024-02-21 14:53:19 +00:00
Igor Nikonov
a0105e94ba
Merge pull request #60077 from ClickHouse/cleanup-connection-pool-priority
Cleanup: less confusion between config priority and balancing priority in connection pools
2024-02-21 15:22:08 +01:00
serxa
f92ec2cd5d Merge branch 'master' into cpu-scheduler-and-cc 2024-02-21 14:05:37 +00:00
serxa
bf90da7057 Merge branch 'master' into cpu-scheduler-and-cc 2024-02-21 14:05:01 +00:00
Maksim Kita
ae91c655a0 Tables system.backups and system.backup_log add query_id and error stacktrace 2024-02-21 14:36:58 +03:00
Antonio Andelic
fee1565780
Revert "Check stack size in Parser" 2024-02-21 11:33:08 +01:00
Kseniia Sumarokova
d601534a4e
Merge pull request #60166 from ClickHouse/fix-s3-queue-system-table-uuid-column
Fix system.s3queue_log
2024-02-21 10:52:45 +01:00
Alexey Milovidov
c9686eb76c
Merge pull request #60123 from conicl/skip_log_empty_message
skip printing meaningless log
2024-02-21 09:02:26 +01:00
Anton Popov
74399253d9 refactoring of virtual columns 2024-02-21 02:28:30 +00:00
Anton Popov
23f300b581 refactoring of virtual columns 2024-02-21 00:57:35 +00:00
Alexander Tokmakov
45d407034f Merge branch 'master' into fix_undead_sessions 2024-02-20 22:21:37 +01:00
Alexander Tokmakov
ec0986af0b skip sanity checks on secondary create query 2024-02-20 21:59:28 +01:00
alesapin
392081256c
Merge pull request #60078 from kitaisreal/revert-60058-revert-59946-replicated-merge-tree-alter-update-metadata-version-in-single-transaction
Revert "Revert "ReplicatedMergeTree invalid metadata_version fix""
2024-02-20 19:24:35 +01:00
Anton Popov
533082495d fix build 2024-02-20 16:33:43 +00:00
Kseniia Sumarokova
f7de95cec3
Merge pull request #59775 from ClickHouse/rabbitmq-fix-possible-channel-ack-timeout
rabbitmq: fix possible channel error state
2024-02-20 16:08:33 +01:00
unashi
f829a97d91 [fix] rm whitespaces 2024-02-20 21:08:24 +08:00
Sergei Trifonov
d2aebe2c9a
Merge branch 'master' into alter-table-forget-partition 2024-02-20 13:56:50 +01:00
unashi
fc3ebe007b [fix] rm whitespaces 2024-02-20 20:54:32 +08:00
unashi
6437877a71 [fix] add changelog; change some feature logic 2024-02-20 20:31:59 +08:00
Antonio Andelic
34e8e673e9
Merge pull request #60144 from ClickHouse/per-user-s3-settings
Support specifying users for S3 settings
2024-02-20 13:20:07 +01:00
Igor Nikonov
b6277d5e87 Merge remote-tracking branch 'origin/master' into cleanup-connection-pool-priority 2024-02-20 12:13:10 +00:00
Robert Schulze
7e11fc79d9
Merge pull request #58023 from canhld94/materialize_non_override_past_values
Materializing an ordinary column with default expression should not override past values
2024-02-20 11:12:31 +01:00
kssenii
3dac4c9743 Fix 2024-02-20 11:10:11 +01:00
kssenii
5ef4a30d6f Fix 2024-02-20 10:24:09 +01:00
MikhailBurdukov
c2d641c658
Merge branch 'master' into backoff_for_failed_mutations 2024-02-20 11:48:59 +03:00
Maksim Kita
9e0f607608 Revert "Revert "ReplicatedMergeTree invalid metadata_version fix"" 2024-02-20 11:39:57 +03:00
MikhailBurdukov
7cdfedaedd Enable setting by default 2024-02-20 08:39:11 +00:00
Alexey Milovidov
b216223aa0
Merge pull request #60139 from ClickHouse/revert-60093-lazy-primary-key-loading
Fix data race in `IMergeTreeDataPart`
2024-02-20 06:44:28 +01:00
unashi
8de4a9dbfd [fix] delete trailing whitespaces 2024-02-20 11:42:40 +08:00
Raúl Marín
9361946d15 Fix build in master 2024-02-19 17:48:53 +01:00
alesapin
31bc327005
Merge pull request #60111 from ClickHouse/buffer_bg_flush_parallel
Flush StorageBuffer into multiple threads if num_layers > 1
2024-02-19 16:56:24 +01:00
Antonio Andelic
175a1db787 Support specifying users for s3 settings 2024-02-19 16:43:27 +01:00
Anton Popov
0aa8dafe0a Merge remote-tracking branch 'upstream/master' into HEAD 2024-02-19 14:07:55 +00:00
Vitaly Baranov
f10a8868e1
Merge pull request #60097 from vitlibar/move-thread-pool-callback-runner-to-common
Move threadPoolCallbackRunner to the "Common" folder
2024-02-19 14:10:36 +01:00
Antonio Andelic
7c2654f62e Fix data race 2024-02-19 14:09:37 +01:00
Dmitry Novik
11970ddf82
Merge branch 'master' into analyzer-fix-test_select_table_name_from_merge_over_distributed 2024-02-19 14:07:58 +01:00
Dmitry Novik
2122454576 Temporary progress 2024-02-19 12:41:29 +00:00
Igor Nikonov
f06e15ce5f Merge remote-tracking branch 'origin/master' into cleanup-connection-pool-priority 2024-02-19 11:33:55 +00:00
unashi
f62ccc75ec [merge] solve 2024-02-19 19:28:16 +08:00
Alexey Milovidov
a10eddecef
Merge pull request #59697 from ClickHouse/check-stack-size-in-parser
Check stack size in Parser
2024-02-19 11:33:04 +01:00
Alexey Milovidov
df48106cd5
Merge pull request #60015 from azat/values-quote-escape
Fix INSERT into SQLite with single quote (by escaping single quotes with a quote instead of backslash)
2024-02-19 10:37:45 +01:00
alesapin
6565423b1a Review fix 2024-02-19 10:32:36 +01:00
conicliu
b38ad8297c skip log empty message 2024-02-19 16:11:42 +08:00
Alexey Milovidov
fa1ca348a4 Miscellaneous 2024-02-19 03:19:21 +01:00
jsc0218
9fc9fa7850 client side 2024-02-19 02:17:00 +00:00
Alexey Milovidov
6fd563df52 Miscellaneous 2024-02-19 02:58:51 +01:00
MikhailBurdukov
c3ab9071fc
Merge branch 'master' into backoff_for_failed_mutations 2024-02-18 17:48:11 +03:00
MikhailBurdukov
b227e5dd3f Review changes 2024-02-18 13:37:12 +00:00
alesapin
29e3e7cb96 Better if only 1 layer 2024-02-18 13:19:35 +01:00
alesapin
8f29320a73 Flush StorageBuffer into multiple threads if num_layers > 1 2024-02-18 13:15:24 +01:00
unashi
1549725edd [feature]: allow to attach parts from a different disk 2024-02-18 19:26:12 +08:00
Alexey Milovidov
8d6e6d67ed Merge branch 'fix-inconsistent-formatting-of-explain-in-subqueries' into lazy-primary-key-loading 2024-02-18 11:04:01 +01:00
Alexey Milovidov
232fe0dd1b Fix inconsistent formatting of SELECT ... FROM (EXPLAIN ...) 2024-02-18 05:38:34 +01:00
Alexey Milovidov
c083498cf8 Apply review comments 2024-02-18 05:13:17 +01:00
Vitaly Baranov
3323d5ce81 Move threadPoolCallbackRunner to the "Common" folder. 2024-02-17 21:59:51 +01:00
Alexey Milovidov
0e944d400c
Merge pull request #60092 from ClickHouse/index-preparation
A small preparation for better handling of primary key in memory
2024-02-17 10:15:06 +01:00
Alexey Milovidov
c5107afb94
Merge branch 'master' into lazy-primary-key-loading 2024-02-17 10:14:35 +01:00
Alexey Milovidov
6cae75751b
Merge pull request #60049 from ClickHouse/less-memory-usage-primary-key
Maybe less memory usage for primary keys in memory
2024-02-17 08:58:02 +01:00
Alexey Milovidov
021e11e4fc Add a setting for lazy loading 2024-02-17 06:42:53 +01:00
Alexey Milovidov
423ff759f1 Lazy loading of primary keys in memory 2024-02-17 06:35:03 +01:00
Alexey Milovidov
e9cf92245f Move methods to .cpp 2024-02-17 06:20:44 +01:00
Alexey Milovidov
fce3a8cafc A small preparation for better handling of primary key in memory 2024-02-17 06:16:56 +01:00
Alexey Milovidov
ac5bef7c74 A small preparation for better handling of primary key in memory 2024-02-17 06:16:01 +01:00
Alexey Milovidov
46c2f85314 Merge branch 'master' into less-memory-usage-primary-key 2024-02-17 04:55:59 +01:00
Alexey Milovidov
2f315e0eb5 Style check for abbreviations 2024-02-17 02:14:15 +01:00
Alexey Milovidov
731c484b3d
Revert "Implement system.dns_cache table (#59856)"
This reverts commit b5ef034697.
2024-02-17 01:46:41 +01:00
Kirill Nikiforov
b5ef034697
Implement system.dns_cache table (#59856)
* system.dns_cache table WIP

* system.dns_cache table

* rollback unexpected contrib changes

* rollback unexpected changes

* add docs

* code style fixes

* optimize dns cache exporting

* stateful test for system.dns_cache table

* stateful test for system.dns_cache table

* cr fixes

* stateful test for system.dns_cache table

* stateful test for system.dns_cache table

* Update 02981_system_dns_cache_table.sql

* Update 02981_system_dns_cache_table.reference

---------

Co-authored-by: pufit <pufit@clickhouse.com>
2024-02-16 14:31:22 -05:00
Alexander Tokmakov
b513f1d456 fix build 2024-02-16 18:27:22 +01:00
Alexander Tokmakov
31479649fe
Merge pull request #59908 from azat/rmt-uuid-macro
[RFC] Allow uuid in replica_path if CREATE TABLE explicitly has it
2024-02-16 17:31:59 +01:00