Commit Graph

73964 Commits

Author SHA1 Message Date
Azat Khuzhin
769bfbe71f Fix server pid in fuzzer tests
Previously it was the pid of the subshell 40 while it should be the pid
of the clickhouse-server 39:

Here we see that the server pid is 39:

    2021-09-28 11:02:34	 + pgrep -f clickhouse-server
    2021-09-28 11:02:34	 39

Here we see that the 40 is the pid of subshell:

    2021-09-28 11:02:45	 ch/docker/test/fuzzer/run-fuzzer.sh: line 90:    39 Killed                  clickhouse-server --config-file db/config.xml -- --path db 2>&1
    2021-09-28 11:02:45	         40 Done                    | tail -100000 > server.log

And here we see that server_pid variable is 40:

    2021-09-28 11:02:45	 + server_exit_code=0
    2021-09-28 11:02:45	 + wait 40

v2: wait in background to call wait in foreground and ensure that the
process is alive, since w/o job control this is the only way to obtain
the exit code
2021-10-01 21:05:30 +03:00
Azat Khuzhin
9d69786a6b Increase listen_backlog by default (to match default in newer linux kernel)
It was 64 for a long time, and even linux kernel never has such a small
limit, it had 128 (net.core.somaxconn sysctl).

But recently, in 5.4, the default value had been increased even in
linux kernel, to 4096 [1].

  [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=19f92a030ca6d772ab44b22ee6a01378a8cb32d4

Let's increase it in ClickHouse too.

Also note, that I've looked through some instances with
clickhouse-server only, and TcpExtListenOverflows was non zero (`nstat
-za`), in other words backlog of the listen socket indeed overflowed
there.

So it is better to increase the default to move the problem to
clickhouse-server itself (yes you will unlikely have 4K new incomming
connections at one time, with accept thread do not accept them all, but
still seems that it is possible, maybe due to some locks or something
else).
2021-10-01 21:03:59 +03:00
Azat Khuzhin
cab0551c5b Add ability to compile using newer version fo glibc w/o using new symbols
In glibc 2.32 new version of some symbols had been added [1]:

    $ nm -D clickhouse | fgrep -e @GLIBC_2.32
                     U pthread_getattr_np@GLIBC_2.32
                     U pthread_sigmask@GLIBC_2.32

  [1]: https://www.spinics.net/lists/fedora-devel/msg273044.html

Right now ubuntu 20.04 is used as official image for building
ClickHouse, however once it will be switched someone may not be happy
with that fact that he/she cannot use official binaries anymore because
they have glibc < 2.32.

To avoid this dependency, let's force previous version of those
symbols from glibc.

Note, that I've tested this by compiling with glibc 2.32 and verifying
that output ELF does not have @GLIBC_2.32 symbols and also running that
binary inside ubuntu:20.04 image (that has glibc 2.31).

v1: -Wl,--wrap
v2: -Wl,--defsym
v3: -include
v4: fix versioning for aarch64
2021-10-01 21:01:59 +03:00
Vitaly Baranov
27f6d5864d
Merge pull request #29060 from azat/inter-server-secret-auth-fix
Do not allow to reuse previous credentials in case of inter-server secret
2021-10-01 20:44:48 +03:00
kssenii
dabab85c60 Fix 2021-10-01 17:31:00 +00:00
Anton Popov
f0363c524d Merge branch 'master' of git://github.com/mo-avatar/ClickHouse into merging-29376 2021-10-01 20:29:33 +03:00
sevirov
ec2e36c4cf
Update docs/en/operations/storing-data.md
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
2021-10-01 20:24:31 +03:00
sevirov
6617ff3da1
Update docs/en/operations/storing-data.md
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
2021-10-01 20:24:24 +03:00
Mike Kot
e8625e85a4 Fixing integration tests 2021-10-01 19:13:14 +02:00
Anton Popov
9c296e94f3 fix performance of updatePermutation 2021-10-01 19:45:17 +03:00
Maksim Kita
57666725f9
Merge pull request #29623 from kitaisreal/bloom-filter-indexes-map-support-fix-unsafe-identifier-cast
BloomFilter indexes map data type support fix unsafe identifier cast
2021-10-01 19:28:04 +03:00
Maksim Kita
94117f83ad
Merge pull request #29636 from kitaisreal/map-get-non-const-key-added-test
Map get non const key added test
2021-10-01 19:27:46 +03:00
Nikita Mikhaylov
b2f7b6fae8
Fix race between MergeTask and storage destruction (#29614) 2021-10-01 18:55:04 +03:00
kssenii
04e159b42c Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into fix-signals 2021-10-01 15:54:52 +00:00
Mike Kot
282aa6009b Merge branch 'improvement/fn-traits' of github.com:myrrc/ClickHouse into improvement/fn-traits 2021-10-01 16:56:59 +02:00
Mike Kot
38b02b121a Merge remote-tracking branch 'upstream/master' into improvement/fn-traits 2021-10-01 16:55:28 +02:00
Mike Kot
5e560ff9d7 fix 2021-10-01 16:55:01 +02:00
Maksim Kita
a58cc620e9 Map get non const key added test 2021-10-01 17:54:40 +03:00
Maksim Kita
2fd9b3e6f3
Merge pull request #29627 from den-crane/patch-29
Doc. warning about systems with small RAM
2021-10-01 17:34:11 +03:00
Maksim Kita
fe6bb1bb1e Fixed tests 2021-10-01 17:33:14 +03:00
Denny Crane
6a1f6f799f
Update tips.md
warning about system with small RAM
2021-10-01 11:24:06 -03:00
kssenii
05181c6900 Fix 2021-10-01 14:13:02 +00:00
Maksim Kita
26b8d4c480 Fixed test 2021-10-01 17:10:28 +03:00
Maksim Kita
4a480699bd Added tests 2021-10-01 16:44:09 +03:00
Vladimir C
ec966b7df5
Merge pull request #27933 from mathalex/numeric_tuple_functions 2021-10-01 16:18:52 +03:00
Maksim Kita
c793c8e7fa BloomFilter indexes map data type support fix unsafe identifier cast 2021-10-01 14:40:00 +03:00
alesapin
53fce1411c
Merge pull request #29597 from ClickHouse/fix-docker-image
Fix docker/test/util declaration
2021-10-01 13:43:17 +03:00
olgarev
1020c25830 Links repaired 2021-10-01 10:06:26 +00:00
Nikolai Kochetov
291a8332b9 Do not send many signals at server restart (integration tests). 2021-10-01 12:52:24 +03:00
Maksim Kita
30220529b7
Merge pull request #29573 from ClickHouse/fix_segfault_in_add_database_visitor
Fix nullpointer dereference in AddDefaultDatabaseVisitor
2021-10-01 12:44:15 +03:00
Maksim Kita
b8702e613d Fixed tests 2021-10-01 12:37:04 +03:00
alexey-milovidov
b29e877f26
Merge pull request #29182 from ClickHouse/yandex-to-clickhouse-in-configs
Replace `<yandex>` to `<clickhouse>` in configs and more.
2021-10-01 12:24:12 +03:00
Maksim Kita
47f14d3ea6 Fixed typo 2021-10-01 12:09:28 +03:00
Maksim Kita
3d3f0d3548
Merge pull request #29600 from ClickHouse/skip-executable-table-function-test-msan
Skip test for executable table function under MSan
2021-10-01 12:09:14 +03:00
Maksim Kita
d72e10367f
Merge pull request #29602 from NSTikhomirov/master
Added MD4 and SHA384 functions.
2021-10-01 12:08:30 +03:00
Vasily Nemkov
2f16806cd0 Implemented creating databases with comments 2021-10-01 11:51:26 +03:00
olgarev
6297bdc618 Example 2021-10-01 06:51:44 +00:00
Yatsishin Ilya
2c0071bc6d wip 2021-10-01 09:32:54 +03:00
olgarev
12dedaf961
Update docs/ru/engines/database-engines/materialized-postgresql.md
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2021-10-01 09:29:25 +03:00
olgarev
d3ab76771c Initial 2021-10-01 05:55:17 +00:00
Tatiana Kirillova
f25ec7bdf9
odd space 2021-10-01 08:48:59 +03:00
Yatsishin Ilya
ada6c50aaa Improve some tests 2021-10-01 08:44:50 +03:00
Yatsishin Ilya
05e8441b59 Merge remote-tracking branch 'origin' into improve-integration-2 2021-10-01 07:48:28 +03:00
Nikita Tikhomirov
5de80a057f Added EOL to the end of the test file 02041_openssl_hash_functions_test. 2021-10-01 07:37:59 +03:00
Nikita Tikhomirov
cb7e373bfe Disable fasttest for 02041_openssl_hash_functions_test test. 2021-10-01 07:22:20 +03:00
Nikita Tikhomirov
a49d4d3092 Added tests for OpenSSL hash functions. 2021-10-01 06:23:35 +03:00
alexey-milovidov
7a3f85cda1
Update test.py 2021-10-01 05:04:12 +03:00
Alexey Milovidov
32c0b22a6a Skip test for executable table function under MSan 2021-10-01 05:02:57 +03:00
Alexey Milovidov
f919271096 Compatibility 2021-10-01 04:46:41 +03:00
Nikita Tikhomirov
2d23f40fd2 Added documentation for MD4 and SHA384 functions. Supplementing documentation with SHA-512 where it was missing. 2021-10-01 04:38:34 +03:00