Commit Graph

71839 Commits

Author SHA1 Message Date
Azat Khuzhin
4909d3f2e0 Fix endless loop for truncated bzip2
Stress test (thread) found an issue [1]:

    elapsed:              2094.356407533
    query:                SELECT count(), max(x) FROM file
    thread_ids:           [2927,11494,7502]
    current_database:     test_19

Stacktrace for 7502:

    0  __syscall () at ../base/glibc-compatibility/musl/x86_64/syscall.s:14
    1  0x000000001ba033b8 in clock_nanosleep (clk=1, flags=1, req=0x7fbb8adaed68, rem=0x0) at ../base/glibc-compatibility/musl/clock_nanosleep.c:21
    2  0x0000000018e25b84 in sleepForNanoseconds (nanoseconds=<optimized out>) at ../base/common/sleep.cpp:48
    3  0x0000000009a47143 in DB::injection (yield_probability=0, migrate_probability=0, sleep_probability=0.10000000000000001, sleep_time_us=100000) at ../src/Common/ThreadFuzzer.cpp:193
    4  DB::ThreadFuzzer::signalHandler () at ../src/Common/ThreadFuzzer.cpp:204
    5  0x00000000098e1447 in __tsan::CallUserSignalHandler(__tsan::ThreadState*, bool, bool, bool, int, __sanitizer::__sanitizer_siginfo*, void*) ()
    6  0x00000000098d7f99 in __tsan::ProcessPendingSignals(__tsan::ThreadState*) ()
    7  0x00000000098e57de in pread ()
    8  0x00000000099fab84 in DB::ReadBufferFromFileDescriptor::nextImpl (this=0x7b38010ddb00) at ../src/IO/ReadBufferFromFileDescriptor.cpp:62
    9  0x0000000009ab0cf3 in DB::ReadBuffer::next (this=0x7b38010ddb00) at ../src/IO/ReadBuffer.h:62
    10 DB::ReadBuffer::nextIfAtEnd (this=0x7b38010ddb00) at ../src/IO/ReadBuffer.h:78
    11 DB::Bzip2ReadBuffer::nextImpl (this=0x7b20032f4800) at ../src/IO/Bzip2ReadBuffer.cpp:59

It looks like bz2 is not capable to read/fail partially written archive:

    2021.09.03 00:52:36.744818 [ 3553 ] {90419c0a-c410-42ea-ba76-7672ff5ae5ec} <Debug> executeQuery: (from [::1]:54714) (comment: '/usr/share/clickhouse-test/queries/0_stateless/01059_storage_file_compression.sh') CREATE TABLE file (x UInt64) ENGINE = File(TSV, 'test_19/bz2.tsv.bz2')
    2021.09.03 00:52:41.255409 [ 2927 ] {9c7b4e21-cc37-438d-9c13-f9dc01efd30c} <Debug> executeQuery: (from [::1]:54750) (comment: '/usr/share/clickhouse-test/queries/0_stateless/01059_storage_file_compression.sh') TRUNCATE TABLE file
    2021.09.03 00:52:43.762791 [ 2927 ] {82857e3d-f7cc-453d-82a4-e8b8fb82ae0e} <Debug> executeQuery: (from [::1]:54758) (comment: '/usr/share/clickhouse-test/queries/0_stateless/01059_storage_file_compression.sh') INSERT INTO file SELECT * FROM numbers(1000000)
    2021.09.03 00:52:54.939333 [ 2927 ] {82857e3d-f7cc-453d-82a4-e8b8fb82ae0e} <Error> executeQuery: Code: 241. DB::Exception: Memory limit (total) exceeded: would use 63.07 GiB (attempt to allocate chunk of 4194364 bytes), maximum: 62.94 GiB. (MEMORY_LIMIT_EXCEEDED) (version 21.10.1.7982) (from [::1]:54758) (comment: '/usr/share/clickhouse-test/queries/0_stateless/01059_storage_file_compression.sh') (in query: INSERT INTO file SELECT * FROM numbers(1000000)), Stack trace (when copying this message, always include the lines below):
    2021.09.03 00:53:08.505015 [ 2927 ] {2bc7444e-c0d6-462e-9d6a-567f70b01697} <Debug> executeQuery: (from [::1]:54842) (comment: '/usr/share/clickhouse-test/queries/0_stateless/01059_storage_file_compression.sh') SELECT count(), max(x) FROM file

  [1]: https://clickhouse-test-reports.s3.yandex.net/28474/6d5f01a56bb1715c47de8444bfc85b39228f3081/stress_test_(thread).html#fail1
2021-09-03 10:49:17 +03:00
Azat Khuzhin
5a4d554c15 FIx Bzip2WriteBuffer ifdef (USE_BZIP2 over USE_BROTLI) 2021-09-03 10:48:52 +03:00
alesapin
1894524438
Merge pull request #28528 from ClickHouse/fix_detach_attach_versioned_collapsing
Fix detach/attach for ReplicatedVersionedCollapsingMergeTree after alter
2021-09-03 10:13:52 +03:00
alesapin
9281c4786b Fix queue test 2021-09-03 10:10:19 +03:00
benbiti
f8e367757d fix max_server_memory_usage_to_ram_ratio default value(0.9) in docs 2021-09-03 14:24:24 +08:00
Azat Khuzhin
5bab06ed90 Bump poco to remove getpid() calls
Refs: https://github.com/ClickHouse-Extras/poco/pull/46
2021-09-03 07:45:58 +03:00
Nikita Mikhaylov
f8020a1f07 Fix build 2021-09-02 22:47:51 +00:00
Nikita Mikhaylov
0f284db1fc Done 2021-09-02 22:33:04 +00:00
alesapin
d571c84a56 Better test for flaky check 2021-09-02 23:41:00 +03:00
alesapin
a949329830 Review fixes 2021-09-02 23:37:34 +03:00
alesapin
3a3c3acd18
Update src/Coordination/SessionExpiryQueue.h
Co-authored-by: tavplubix <avtokmakov@yandex-team.ru>
2021-09-02 23:19:44 +03:00
Anton Popov
db77349957 add unit test for NestedUtils 2021-09-02 20:43:42 +03:00
Anton Popov
ee7f50396b fix nested and scalar columns with dot 2021-09-02 20:22:01 +03:00
alesapin
9bad77f806 Fix clang tidy 2021-09-02 19:16:29 +03:00
Maksim Kita
8fbef6c69d Function dictGet default implementation for nulls 2021-09-02 18:30:55 +03:00
Maksim Kita
027c531243
Merge pull request #28503 from kitaisreal/executable-multiple-pipes-added-test
Executable multiple pipes added test
2021-09-02 18:30:03 +03:00
alesapin
464b8167d1 Update comment 2021-09-02 18:29:26 +03:00
robot-clickhouse
2ecfc06fbc Update version_date.tsv after release 21.8.5.7 2021-09-02 18:18:36 +03:00
alesapin
ba78a737dc Fix detach/attach for ReplicatedVersionedCollapsingMergeTree after alter 2021-09-02 17:47:00 +03:00
robot-clickhouse
c832a41dff Update version_date.tsv after release 21.7.9.7 2021-09-02 17:37:47 +03:00
Nikolai Kochetov
af0da33147
Merge pull request #27827 from ClickHouse/more-checks-for-lv-and-native
Add more checks for LC in native protocol.
2021-09-02 17:27:42 +03:00
Maksim Kita
f9ca726bf7 PageArena updated implementation 2021-09-02 16:31:50 +03:00
alexey-milovidov
ab3e005e6a
Merge pull request #28411 from kssenii/fix-web-disk
Fix disk with static files a little
2021-09-02 16:23:35 +03:00
Alexey Milovidov
03ae73a91a Drop arcadia_skip_list.txt 2021-09-02 16:19:36 +03:00
Maksim Kita
958174192b
Merge pull request #28523 from kitaisreal/borrowed-object-pool-fix-style
BorrowedObjectPool fix style
2021-09-02 16:18:48 +03:00
Maksim Kita
e5ee3752ef BorrowedObjectPool fix style 2021-09-02 16:18:10 +03:00
alesapin
bc818dea4b Merge branch 'master' into debug_keeper_lost_logs 2021-09-02 15:07:08 +03:00
alesapin
010985ce87 Add comment 2021-09-02 14:54:32 +03:00
Maksim Kita
abda2a636e Added ExecutablePool storage 2021-09-02 14:53:20 +03:00
alesapin
c5470864e8 Fixup 2021-09-02 14:43:34 +03:00
alesapin
4c613f30b3 Simplier sessions expiration in Keeper 2021-09-02 14:40:54 +03:00
Maksim Kita
83c70a8a65
Merge pull request #28516 from kitaisreal/user-defined-function-factory-added-comments
UserDefinedFunctionFactory added comments
2021-09-02 14:37:25 +03:00
Maksim Kita
0a12592b50 UserDefinedFunctionFactory added comments 2021-09-02 14:37:06 +03:00
alesapin
b592400e54
Merge pull request #28404 from ClickHouse/remove_outdated_settings
Remove obsolete settings for replicated fetches.
2021-09-02 14:03:12 +03:00
alesapin
9b1b3ec916 Fix style check 2021-09-02 14:02:37 +03:00
Nikolai Kochetov
5f0b1bc4e3
Merge pull request #26286 from amosbird/projection-improve2
Virtual projection for min max indices.
2021-09-02 13:03:30 +03:00
alesapin
78a0cefafd
Merge pull request #28437 from ClickHouse/remove_some_tests
Remove some rename tests
2021-09-02 12:26:28 +03:00
alesapin
d681ffabf8 Comment 2021-09-02 12:22:51 +03:00
alesapin
a8003e444b Review fixes 2021-09-02 12:20:46 +03:00
Maksim Kita
3286b32499 Executable multiple pipes added test 2021-09-02 10:47:21 +03:00
Maksim Kita
befb82e441
Merge pull request #28433 from kssenii/fix-materialized-postgresql
Fix cannot use non-ordinary table names in materialized postgresql
2021-09-02 09:49:33 +03:00
Maksim Kita
be4c9102d8
Merge pull request #28438 from azat/udf-race-fix-v2
Fix race in UDF (follow up)
2021-09-01 23:57:05 +03:00
tavplubix
b5b9fd8663
Merge pull request #28446 from ClickHouse/ddlworker_fix_watch_leak
Fix watch leak in DDLWorker
2021-09-01 22:44:39 +03:00
Nikolay Degterinsky
53b6d918eb
Merge pull request #25310 from bharatnc/ncb/import-export-lz4
LZ4 compression for import/export
2021-09-01 21:12:50 +03:00
alexey-milovidov
ff0b332c24
Update custom-partitioning-key.md 2021-09-01 20:53:06 +03:00
alexey-milovidov
4699386470
Update mergetree.md 2021-09-01 20:52:05 +03:00
Kseniia Sumarokova
e7dfb0e703
Update test.py 2021-09-01 17:32:09 +03:00
Kseniia Sumarokova
a67741b626
Merge pull request #28430 from kssenii/fix-startup
Do not allow create postgres storage with bad arguments
2021-09-01 17:29:14 +03:00
mergify[bot]
9536da9319
Merge branch 'master' into debug_keeper_lost_logs 2021-09-01 14:07:53 +00:00
mergify[bot]
5d299fbdee
Merge branch 'master' into remove_outdated_settings 2021-09-01 14:07:48 +00:00