Commit Graph

1446 Commits

Author SHA1 Message Date
Azat Khuzhin
a0cc5b7e47 Merge remote-tracking branch 'u/master' into build/llvm-16 2023-05-10 16:28:36 +02:00
Azat Khuzhin
184efcb77a Get back -fno-sanitize-address-use-after-scope quirk for llvm/clang-15
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 20:35:43 +02:00
Azat Khuzhin
8cfe0eb3f2 Do not change CMAKE_EXE_LINKER_FLAGS_INIT in toolchains
Otherwise check in PreLoad.cmake will throw.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 10:33:37 +02:00
Azat Khuzhin
e278081344 Revert "Merge pull request #43195 from ClickHouse/workaround-for-llvm-bug"
With clang 16 this workaround should not be required anymore.

This reverts commit 992729f3c0, reversing
changes made to d885b3cc4c.
2023-05-08 22:54:04 +02:00
Azat Khuzhin
cf987db8f6 Disable .debug_aranges workaround under ThinLTO for clang/llvm 16
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-08 22:54:04 +02:00
Robert Schulze
e275da1d31
Remove deprecated logic for ccache 2023-05-07 15:41:56 +00:00
Alexey Milovidov
5b8b3c04bf
Merge pull request #49224 from ClickHouse/rs/cmake-gnu
CMake: Remove some GCC-specific code
2023-04-27 14:44:20 +03:00
Alexey Milovidov
7333e964bc Update autogenerated version to 23.5.1.1 and contributors 2023-04-27 01:40:57 +02:00
Robert Schulze
150ea22a12
CMake: Remove dead code paths 2023-04-26 19:40:59 +00:00
alesapin
bb21461145 Try to fix with pie 2023-04-25 15:45:23 +02:00
Robert Schulze
a1ff8a0679
Remove the obvious 2023-04-11 16:27:32 +00:00
Robert Schulze
1477887259
Initial removal of logic under COMPILER_GCC 2023-04-11 16:27:32 +00:00
Alexey Milovidov
dd79bf0a03 Update autogenerated version to 23.4.1.1 and contributors 2023-03-31 12:20:50 +02:00
Mikhail f. Shiryaev
7ff582b963
Deprecate ENABLE_CCACHE and replace it by COMPILER_CACHE 2023-03-29 23:33:31 +02:00
Mikhail f. Shiryaev
e1531688bc
Add sccache to cmake configuration 2023-03-29 23:33:24 +02:00
Robert Schulze
1845bfc644
Revert change to ld64.lld linker on Mac
This reverts PRs #42470, #47673 and #47744. The problem was that after
the switch to ld64.lld, server binaries build in Debug mode no longer
came up, see the discussion after (*). My attempt to fix it with
`-no_compact_unwind` didn't help.

I also tried
- `-keep_dwarf_unwind`,
- `-unwindlib` (to use the OS unwinder),
- the unwinder in contrib (CMake variable EXCEPTION_HANDLING_LIBRARY)
but w/o success. Just tons of wasted time.

Rolling back to lld as linker on Mac. This will bring back many linker
warnings (#42282) but I rather accept that (temporarily, maybe someone
can figure out how to fix them) than have a broken Debug binary.

(*) https://github.com/ClickHouse/ClickHouse/pull/42470#issuecomment-1312344068
2023-03-27 15:26:54 +02:00
Robert Schulze
5d5308e060
CMake cleanup: Remove configuration of CMAKE_SHARED_LINKER_FLAGS
Follow-up to #44828
2023-03-26 17:59:39 +00:00
Alexey Milovidov
4f33033b4d
Merge pull request #47673 from ClickHouse/rs/restore-mac-build
Restore native macos build
2023-03-20 04:27:22 +03:00
Robert Schulze
0e01e912fe
Preparation for libcxx(abi), llvm, clang-tidy 16 2023-03-19 17:25:41 +00:00
Robert Schulze
67ebad488f
Small refactoring of linker selection code 2023-03-19 18:16:20 +01:00
Robert Schulze
f72a337074
Remove cruft from build
No need to check compiler flags, clang >= 15 supports all of them.
2023-03-17 13:44:04 +00:00
Robert Schulze
bf99d624e7
cmake: remove support for gold linker
It's dead since 5+ years.
2023-03-16 21:16:13 +00:00
Alexey Milovidov
97c0f8a0e0
Merge pull request #47027 from amosbird/clang16
Prepare to build with clang 16
2023-03-02 02:10:03 +03:00
Robert Schulze
ac7caace8a
Update comments 2023-03-01 09:34:46 +00:00
Amos Bird
7b4f489837
Update flags 2023-02-28 22:45:33 +08:00
Robert Schulze
c78e99eb56
ARM: Activate LDAPR with -march flag instead via -XClang
The `-XClang ... -Xclang ...` flag is internal, undocumented and also
needs `-Wno-unused-command-line-argument`. Enable LDAPR instructions on
ARM via "official" -march. For more informations, see

- https://developer.arm.com/documentation/101754/0619/armclang-Reference/armclang-Command-line-Options/-march?_ga=2.24245759.493510493.1644226748-1698312558.1644226748
- https://developer.arm.com/documentation/dui0801/g/A64-Data-Transfer-Instructions/LDAPR?lang=en
2023-02-27 12:46:58 +00:00
Robert Schulze
db3fbc871c
Merge pull request #46803 from ClickHouse/rs/cmake-too-old-arm
CMake: Add best effort checks that the build machine isn't too old
2023-02-26 20:28:53 +01:00
Robert Schulze
c34b4c8ed1
Fix grammar 2023-02-24 09:43:02 +00:00
Robert Schulze
032dae5d29
Quick-n-dirty --> best effort 2023-02-24 09:41:02 +00:00
Robert Schulze
329abe28ba
Same check for x86 2023-02-24 09:38:32 +00:00
Robert Schulze
2f47046fe1
CMake: Add quick-n-dirty check that the build machine isn't too old 2023-02-23 23:05:55 +00:00
Antonio Andelic
1efba8995d Update version to 23.3.1.2537 2023-02-23 19:35:57 +00:00
Robert Schulze
16d61832fb
Bump minimum required Clang from 12 to 15
Needed due to https://github.com/ClickHouse/ClickHouse/pull/46247#discussion_r1109855435
2023-02-22 10:03:08 +00:00
bkuschel
55e9322612 Fixes for OpenSSL and s390x 2023-02-17 16:20:21 -05:00
Suzy Wang
64313d7020
Merge branch 'master' into z-build-0120 2023-02-09 14:49:22 -05:00
Suzy Wang
716d2c4ffb Update as suggested 2023-02-02 20:41:06 +00:00
Mikhail f. Shiryaev
53d89844be
Update version to 23.2.1.1 2023-01-25 23:57:29 +01:00
Dmitry Novik
94abb84d0d Fix version in autogenerated_versions.txt 2023-01-25 18:58:40 +00:00
Suzy Wang
19d26828a0 s390x build support 2023-01-20 21:16:55 +00:00
Alexey Milovidov
3a027d285f
Merge pull request #44828 from ClickHouse/remove-two-lines-of-code
What if I will remove two lines of code?
2023-01-04 04:50:52 +03:00
Robert Schulze
27f5aad49e
What happens if I remove 156 lines of code? 2023-01-03 18:51:16 +00:00
Robert Schulze
d67a3b9faa
Document usage of check_cxx_source_compiles instead of check_cxx_source_runs
Cf. #42754
2023-01-02 22:20:20 +00:00
Robert Schulze
44fa78e742
Merge pull request #44122 from azat/build/toolchain-quirks
Avoid loading toolchain files multiple times
2022-12-16 10:22:52 +01:00
Mikhail f. Shiryaev
8a145f7000
Update version to 22.13.1.1 2022-12-15 18:00:42 +01:00
Azat Khuzhin
3505b5a10b Avoid loading toolchain files multiple times
Previously, in #39387, this protection had been added only for linux x86_64.

And use include_guard() instead of manual if()+set().

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-13 10:38:23 +01:00
Alexey Milovidov
9a48cf0da8
Merge pull request #40422 from pkubaj/patch-1
Add FreeBSD/powerpc64le support
2022-12-11 09:38:04 +03:00
Robert Schulze
eba6a79afa
Merge pull request #43863 from ClickHouse/faster-clang-tidy
Temporarily disable misc-* slow clang-tidy checks
2022-12-08 13:19:03 +01:00
Robert Schulze
8eb4e22d80
Prefer recent clang-tidy over old-ish system clang-tidy 2022-12-07 11:43:42 +00:00
Nikolay Degterinsky
bfccdb130e
Small typo 2022-12-07 00:43:37 +01:00
Nikolay Degterinsky
57ca6ad60b
Make massages about GCC fatal 2022-12-07 00:40:41 +01:00
Alexey Milovidov
75dbd6828a
Merge pull request #43082 from Algunenano/werror_base
Add global flags to base/ libraries
2022-11-22 19:18:44 +01:00
Alexey Milovidov
f42be5ffd3
Merge pull request #43275 from azat/build/sanitize-targets
Sanitize thirdparty libraries for public flags
2022-11-22 19:18:26 +01:00
Mikhail f. Shiryaev
f942ab1bd2
Update version to 22.12.1.1 2022-11-17 22:15:12 +01:00
Azat Khuzhin
c3f3078884 Sanitize thirdparty libraries for public flags
Public flags, especially -Wxx (i.e. -Wno-XX) can hide some warnings,
that had been added in the main cmake rules of ClickHouse.

This patch had been tested manually with the following patch:

    ```patch
    diff --git a/contrib/jemalloc-cmake/CMakeLists.txt b/contrib/jemalloc-cmake/CMakeLists.txt
    index d5ea69d4926..7e79fba0c16 100644
    --- a/contrib/jemalloc-cmake/CMakeLists.txt
    +++ b/contrib/jemalloc-cmake/CMakeLists.txt
    @@ -158,6 +158,7 @@ target_include_directories(_jemalloc SYSTEM PRIVATE
         "${CMAKE_CURRENT_BINARY_DIR}/${JEMALLOC_INCLUDE_PREFIX}/jemalloc/internal")

     target_compile_definitions(_jemalloc PRIVATE -DJEMALLOC_NO_PRIVATE_NAMESPACE)
    +target_compile_options(_jemalloc INTERFACE -Wno-error) # also PUBLIC had been checked

     if (CMAKE_BUILD_TYPE_UC STREQUAL "DEBUG")
         target_compile_definitions(_jemalloc PRIVATE
    ```

And cmake gave:

    CMake Error at cmake/sanitize_targets.cmake:69 (message):
      _jemalloc set INTERFACE_COMPILE_OPTIONS to -Wno-error.  This is forbidden.
    Call Stack (most recent call first):
      cmake/sanitize_targets.cmake:79 (sanitize_interface_flags)
      CMakeLists.txt:595 (include)

Fixes: #12447
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-16 07:20:24 +01:00
Raúl Marín
5caba7000a Try a different approach 2022-11-15 17:53:24 +01:00
Alexey Milovidov
f5270a6ebe A workaround for LLVM bug, https://github.com/llvm/llvm-project/issues/58633 2022-11-13 04:51:46 +01:00
Robert Schulze
cb1aede694
Merge pull request #42470 from Lloyd-Pottiger/suppress-ld-warning-in-macos
Suppress ld warning in macOS
2022-11-08 19:34:10 +01:00
Lloyd-Pottiger
9ec313b05c remove generic driver lld
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
2022-11-08 18:32:53 +08:00
Mikhail f. Shiryaev
150ceb7d37
Use matus-chochlik/ctcache for clang-tidy 2022-11-03 11:53:11 +01:00
Mikhail f. Shiryaev
52a34cecda
Reformat the cmake a bit 2022-11-03 10:16:08 +01:00
Lloyd-Pottiger
7419a3bd58 fix
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
2022-10-29 18:58:11 +08:00
Mikhail f. Shiryaev
d3461abd1f
Update version to 22.11.1.1 2022-10-26 15:27:09 +02:00
Alexey Milovidov
c48127534b
Merge pull request #41753 from pkit/morton_coding
add Morton Coding (ZCurve)
2022-10-25 06:10:37 +02:00
Nikita Mikhaylov
8fcbef938b
Fix typo in cmake code related to fuzzing (#42627) 2022-10-24 23:01:06 +02:00
Alexey Milovidov
729692f862
Merge pull request #42462 from ClibMouse/power_build_fix
Fix power8+ support add power9+ support
2022-10-24 09:30:38 +02:00
Alexey Milovidov
5fd7409ce1
Merge branch 'master' into morton_coding 2022-10-22 04:39:13 +02:00
Azat Khuzhin
4eeb7337ed Merge remote-tracking branch 'upstream/master' into build/shorten-64-to-32
Conflicts:
- src/Common/intExp.h
- src/Functions/DateTimeTransforms.h
- src/Functions/FunctionsConversion.h
2022-10-21 22:51:56 +02:00
Ilya Yatsishin
6e15b20c40
Merge pull request #42430 from qoega/llvm-15-for-gcc 2022-10-21 16:54:26 +02:00
Azat Khuzhin
19715f1542 Enable -Wshorten-64-to-32
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:22:39 +02:00
Constantine Peresypkin
5b3b11b517 add Morton Coding (ZCurve) 2022-10-19 15:59:25 +02:00
Boris Kuschel
e45c800cdf Fix power8+ support add power9+ support 2022-10-18 17:14:43 -05:00
Azat Khuzhin
65cd040d15 Better workaround for emitting .debug_aranges section
Note, that this is just a syntastic change, that should not makes any
difference (well the only difference is that now it supports gold and
other links, since the option is handled by the plugin itself instead of
the linker).

Refs: https://reviews.llvm.org/D133092
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-18 21:09:07 +02:00
Ilya Yatsishin
0404c960c6 add -15 tools to cmake.tools 2022-10-18 13:19:16 +02:00
Alexey Milovidov
8e4531d135 Preparation for Musl build, part 4 2022-10-01 16:29:41 +02:00
Alexey Milovidov
7099602d5e
Merge pull request #41778 from danlark1/master
Add ldapr to AArch64 server builds
2022-09-28 14:23:33 +03:00
Robert Schulze
de3264691c
Merge pull request #41790 from ClickHouse/print-git-hash
Log git hash during startup
2022-09-28 09:43:17 +02:00
Robert Schulze
1f3f86e5bf
Cosmetics 2022-09-27 11:46:56 +00:00
Robert Schulze
823d8fb6cd
Move git calls back into git.cmake
+ renamed the file from originally "git_status.cmake" to "git.cmake"
  (because we not longer run only "git status")
2022-09-27 11:45:58 +00:00
Daniel Kutenin
9825b4d1f9
Move unused command line arguments to a proper place 2022-09-26 20:56:52 +01:00
Daniel Kutenin
46d45607c8
Disable unused command line as it does not work for assembly files 2022-09-26 15:53:03 +01:00
Robert Schulze
ec35ff9cd6
Log git hash during startup
We currently only log a compiler-generated "build id" at startup which
is different for each build. That makes it useless to determine the
exact source code state in tests (e.g. BC test) and from user log files
(e.g. if someone compiled an intermediate version of ClickHouse).

Current log message:
  Starting ClickHouse 22.10.1.1 with revision 54467, build id: 6F35820328F89C9F36E91C447FF9E61CAF0EF019, PID 42633

New log message:
  Starting ClickHouse 22.10.1.1 (revision 54467, git hash: b6b1f7f763f94ffa12133679a6f80342dd1c3afe, build id: 47B12BE61151926FBBD230DE42F3B7A6652AC482), PID 981813
2022-09-26 14:12:36 +00:00
Daniel Kutenin
cec641a71b
Add ldapr for Arm instances 2022-09-26 13:00:18 +01:00
Alexey Milovidov
62ebf397d2
Merge pull request #41610 from ClickHouse/upgrade-arm-requirement
Bump minimum required ARM ISA to v8.2 and add v8.0 compat build
2022-09-26 14:08:48 +03:00
Alexey Milovidov
93ed8e0c7b Update version to 22.10.1.1 2022-09-22 09:32:38 +02:00
Robert Schulze
49c4f1f9c6
Document flags 2022-09-21 21:18:53 +00:00
Robert Schulze
cfd8d4e1f1
Add CRC32 to compat build 2022-09-21 14:52:27 +00:00
Robert Schulze
971cef8bd2
Provide x86 SIMD flag options only on x86 2022-09-21 09:30:51 +00:00
Alexey Milovidov
84f42e0874 Fix 3/4 of trash 2022-09-19 08:50:53 +02:00
Azat Khuzhin
64bb490460 Add a note about why sentry turned off for musl
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-10 21:38:34 +02:00
Azat Khuzhin
ced30a2072 Switch to llvm/clang 15
It had been released few hours ago, and I want to check how clang-15
generates DWARF-5

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-10 21:38:34 +02:00
Robert Schulze
9d4de0cbaa
Merge pull request #40999 from ClickHouse/sse2-special-build
Add special x86-SSE2-only build
2022-09-08 09:06:29 +02:00
Robert Schulze
e1def723f8
Add special x86-SSE2-only build 2022-09-05 12:51:44 +00:00
Azat Khuzhin
26f1c1504a Do not compress debug sections (internal DWARF parser cannot handle such)
Although this increase debug symbol size from 510MB to 1.8GB, but it is
not a problem for packages, since they are compressed anyway.
Checked deb package, and size slightly increased though, 834M -> 962M.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-02 23:22:25 +02:00
Azat Khuzhin
2d3fb36a62 Fix debug symbols (Add a quirk to force clang emit .debug_aranges with ThinLTO)
Wrap a linker into a script that will add some settings (`-mllvm
-generate-arange-section`) in case of ThinLTO to emit `.debug_aranges`
symbols.

Dicussion in the LLVM can be found here [1].

  [1]: https://discourse.llvm.org/t/clang-does-not-produce-full-debug-aranges-section-with-thinlto/64898

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-02 23:22:25 +02:00
Alexey Milovidov
8ca6025833
Merge branch 'master' into riscv-in-ci 2022-08-22 01:37:53 +03:00
Alexey Milovidov
ad8a1751ac
Merge branch 'master' into riscv-in-ci 2022-08-21 16:56:11 +03:00
Alexey Milovidov
6fbff6d1f6
Revert "Avx enablement" 2022-08-21 15:47:02 +03:00
pkubaj
17f757a94c Add FreeBSD/powerpc64le support 2022-08-19 21:41:03 +02:00
Alexey Milovidov
d62d3ad461 Update version to 22.9.1.1 2022-08-18 19:39:03 +02:00
Alexey Milovidov
5ebba1af33 Merge branch 'riscv64-linker' into riscv-in-ci 2022-08-14 06:10:22 +02:00