Commit Graph

146184 Commits

Author SHA1 Message Date
Pablo Marcos
12608d2090 Improve exception text 2024-07-01 14:22:32 +00:00
Anton Popov
884af52e09 Merge remote-tracking branch 'upstream/master' into HEAD 2024-07-01 14:17:03 +00:00
kssenii
5541461b99 Fix time of writing to _log table 2024-07-01 16:04:43 +02:00
Antonio Andelic
b0bbc9c810 Fix symlinks 2024-07-01 16:01:57 +02:00
Nikita Mikhaylov
00b030be3e Better 2024-07-01 13:41:03 +00:00
kssenii
5e7a8245c4 Fix memory leak 2024-07-01 15:40:49 +02:00
Nikita Mikhaylov
63b031479c
Merge pull request #65908 from ClickHouse/alexey-milovidov-patch-8
Update CHANGELOG.md
2024-07-01 13:27:59 +00:00
Antonio Andelic
7361407ea5 Fix test 2024-07-01 15:25:00 +02:00
Azat Khuzhin
4f2a0e8eeb Fix possible issues with MySQL server protocol TLS connections
The problem here is that retries (in SecureSocketImpl.cpp::mustRetry())
relies on non-zero socket timeout, but MySQL handler does not set
timeouts for the socket (like other does), and this leads to a problem
when OpenSSL returns SSL_ERROR_WANT_READ/SSL_ERROR_WANT_WRITE, the
connection will be simply terminated.

I've played with this patch, by hacking the openssl sources:

    diff --git a/crypto/bio/bss_sock.c b/crypto/bio/bss_sock.c
    index 82f7be85ae..a399291ff4 100644
    --- a/crypto/bio/bss_sock.c
    +++ b/crypto/bio/bss_sock.c
    @@ -124,7 +125,18 @@ static int sock_read(BIO *b, char *out, int outl)
                 ret = ktls_read_record(b->num, out, outl);
             else
     # endif
    -            ret = readsocket(b->num, out, outl);
    +        {
    +            /* pthread_kill(pthread_self(), SIGUSR1); */
    +            static int i = 0;
    +            if (!(++i % 2))
    +            {
    +                fprintf(stderr, "sock_read: inject EAGAIN\n");
    +                ret = -1;
    +                errno = EAGAIN;
    +            }
    +            else
    +                ret = readsocket(b->num, out, outl);
    +        }
             BIO_clear_retry_flags(b);
             if (ret <= 0) {
                 if (BIO_sock_should_retry(ret))

And after this patch this succeed without errors:

    ch benchmark -c10 -q "SELECT * FROM mysql('127.0.0.1:9004', system, one, 'default', '', SETTINGS connection_pool_size=1, connect_timeout = 100, connection_wait_timeout = 100)"

Note, that this also fixes the timeouts for plain (non-TLS) connections

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-07-01 15:22:33 +02:00
Antonio Andelic
1a95259182 Add extra profiling helpers for Keeper 2024-07-01 15:17:41 +02:00
Pablo Marcos
d0506f0214 Fix more tests
One of tests actually uncovered a casting error :)
2024-07-01 12:23:56 +00:00
Pablo Marcos
0fed338ac2 Fix other bit shift tests after out of bounds check 2024-07-01 11:03:25 +00:00
Pablo Marcos
0b24a416b5 Also throw error if bit shift positions is greater than the bit width of value 2024-07-01 10:31:29 +00:00
Nikolai Kochetov
5a6e6d3c5d
Merge pull request #65771 from kitaisreal/postgresql-source-support-cancel-query
PostgreSQL source support cancel query
2024-07-01 10:17:01 +00:00
Anton Kozlov
b1b9aaf2ec Add support for x509 SubjectAltName identification 2024-07-01 09:47:28 +00:00
Antonio Andelic
4a9daa202d Remove Keeper standalone build 2024-07-01 11:24:45 +02:00
vdimir
632ad5156d
Merge branch 'master' into fix_rocksdb_ttl 2024-07-01 11:01:08 +02:00
robot-clickhouse
0ad049d2e5 Update version_date.tsv and changelogs after v24.6.1.4423-stable 2024-07-01 08:55:11 +00:00
Antonio Andelic
6b47171f2c Keeper binary with different entrypoint 2024-07-01 10:52:08 +02:00
Alexey Milovidov
5b50726e2b
Update CHANGELOG.md 2024-07-01 10:34:32 +02:00
taiyang-li
bb8fc59d7c update doc 2024-07-01 15:36:08 +08:00
Alexey Gerasimchuck
98293b1624 Max sessions for user tests improvements 2024-07-01 07:31:57 +00:00
taiyang-li
4fcafde610 allow empty arguments for concat 2024-07-01 15:29:32 +08:00
Antonio Andelic
50c1121c6a
Merge pull request #65735 from ClickHouse/fix-keeper-session-close-bug
Fix bug with session closing in Keeper
2024-07-01 07:12:33 +00:00
Antonio Andelic
43bd12f86b
Merge pull request #65819 from ClickHouse/keeper-respect-cgroup-cpu
Respect cgroup CPU limit in Keeper
2024-07-01 06:57:43 +00:00
Duc Canh Le
047dcfb806 fix undefined LOGICAL_ERROR
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-07-01 04:39:53 +00:00
Alexey Milovidov
7f0f0d6257
Merge pull request #65855 from kevisong/patch-1
Update mergetree.md bullet points structure
2024-07-01 04:37:35 +00:00
Alexey Milovidov
bf4c856739
Merge pull request #65874 from ClickHouse/changelog-24.6
Add changelog for release 24.6
2024-07-01 03:05:58 +00:00
Alexey Milovidov
770e637f9b Add changelog for release 24.6 2024-07-01 03:51:45 +02:00
Alexey Milovidov
1eac2abf8f Fix test 2024-06-30 20:58:00 +02:00
Alexey Milovidov
97311bd51f Merge branch 'master' of github.com:ClickHouse/ClickHouse into dont-optimize-trivial-insert-select 2024-06-30 20:56:54 +02:00
Alexey Milovidov
20f39c64ec
Merge pull request #65866 from ClickHouse/alexey-milovidov-patch-8
Update CHANGELOG.md
2024-06-30 18:55:46 +00:00
Igor Nikonov
2fcca61fe9
Merge pull request #65769 from ClickHouse/fix-progress-bar-read-in-order
Fix: progress bar for read in order queries
2024-06-30 18:07:13 +00:00
Alexey Milovidov
5a1125418b
Update CHANGELOG.md 2024-06-30 19:24:03 +02:00
Alexey Milovidov
06d0f2fd5d Merge branch 'master' into dont-optimize-trivial-insert-select 2024-06-30 18:52:28 +02:00
Alexey Milovidov
2bca1963a7
Merge pull request #65562 from ClickHouse/maybe-fix-test
Maybe fix test `00763_lock_buffer_long.sh`
2024-06-30 16:49:36 +00:00
Alexey Milovidov
8ead887bc4
Merge pull request #65865 from ClickHouse/update-easy-tasks-list
Update the list of easy tasks
2024-06-30 16:48:57 +00:00
Alexey Milovidov
586866ee3a
Merge pull request #65697 from ClickHouse/local-memory-limit
Add memory limit by default in `clickhouse-local`
2024-06-30 16:42:53 +00:00
Alexey Milovidov
d7dae3328f Update the list of easy tasks 2024-06-30 18:03:51 +02:00
Robert Schulze
32d628ac69
Merge pull request #65737 from cw5121/patch-1
Fix and prevent compatibility settings from becoming not effective
2024-06-30 13:38:34 +00:00
Robert Schulze
c72ce5be8a
Merge remote-tracking branch 'ClickHouse/master' into patch-1 2024-06-30 08:55:58 +00:00
Robert Schulze
235133aa5c
Move code from header to source file 2024-06-30 08:50:28 +00:00
Robert Schulze
8fdb3b83e0 Fix style 2024-06-30 10:33:54 +08:00
Robert Schulze
cec2aba6bb Some fixups 2024-06-30 10:33:54 +08:00
cw5121
b97158f5b6 implement with std::initializer_list 2024-06-30 10:33:44 +08:00
cw5121
10a0eb1712 fix 2024-06-30 10:33:32 +08:00
Robert Schulze
0bff61de13 Move parsedatetime_parse_without_leading_zeros to the right place 2024-06-30 10:33:28 +08:00
cw5121
b6500bcdf1 Fix and prevent compatibility settings from becoming not effective 2024-06-30 10:32:43 +08:00
jsc0218
004d913c56 change option to enum and add test 2024-06-30 02:14:28 +00:00
Alexey Milovidov
60853e3660 Fix test 2024-06-30 04:09:59 +02:00