Commit Graph

7997 Commits

Author SHA1 Message Date
alexey-milovidov
faae69f631
Merge pull request #31534 from aiven/kmichel-fix-json-colum-name-encoding
Fix invalid JSON in column names
2021-11-21 11:34:33 +03:00
alexey-milovidov
6ef001fce5
Merge pull request #31556 from azat/fix-02010_lc_native
Fix 02010_lc_native flakiness (Query with id = 123456 is already running)
2021-11-21 11:33:35 +03:00
alexey-milovidov
4cdb40e3cd
Merge pull request #31565 from azat/fix-MySQLWire
Fix MySQLWire format (this will also fix performance tests)
2021-11-21 11:32:53 +03:00
Azat Khuzhin
6aa94ae032 Fix MySQLWire format (in case of multiple writes)
In case of multiple writes File() engine will set doNotWritePrefix(),
and this will avoid serializations initilization, move this to do this
always.

Fixes: #31004
2021-11-20 15:26:21 +03:00
Kevin Michel
edbeeaf6ec
Fix invalid JSON in column names
If the column name contains invalid UTF-8 sequences
and the output data types are all considered safe,
then the output will not be sanitized and the generated
JSON will be invalid.

A minimal reproduction case is :
`SELECT length('\x80') FORMAT JSONCompact`
where we auto-generate a non-UTF-8 column name with only
integer outputs, whereas :
`SELECT '\x80' FORMAT JSONCompact`
would be sanitized because the column type is String and
will trigger UTF-8 sanitization over the entire document.
2021-11-20 12:35:41 +01:00
Azat Khuzhin
71a691e9ab Make 01114_database_atomic more stable in debug builds
By reducing number of clickhouse-client invocation, since it is pretty
heavy in debug builds.
2021-11-20 14:27:34 +03:00
Azat Khuzhin
fbaa6804c2 Fix 02010_lc_native flakiness (Query with id = 123456 is already running) 2021-11-20 10:25:12 +03:00
Azat Khuzhin
c70cc62b5f Add more checks in 02010_lc_native 2021-11-20 10:25:10 +03:00
SuperDJY
dd2972b8c3
return fake create query when executing show create table on system's tables. (#31391)
* clarify that cannot show create table of system's tables

* clarify that cannot show create table of system's tables in the document

* bypass test style-check for required `database=currentDatabase()` because `show create table` do not have condition

* rename supportsShowCreateTable to isSystemStorage

* build fake create query for show create table of system's tables

* fix tests for show create table on system's table:

1. only build fake create query when cannot get real query
2. only test rocksdb when it's enabled.

* fix test for show create table system.tables

* fix test for ASTCreateQuery set table and database

* change to LOGICAL_ERROR when cannot get in_memory metadata

Co-authored-by: tavplubix <tavplubix@gmail.com>

* implement common getCreateQueryFromStorage

Co-authored-by: tavplubix <tavplubix@gmail.com>
2021-11-19 13:25:55 +03:00
alexey-milovidov
12a471507e
Merge pull request #31169 from sundy-li/notlike-fix
ISSUES-30801: Remove not like function into RPNElement
2021-11-18 23:40:57 +03:00
alexey-milovidov
b30f9124c0
Merge pull request #31008 from kssenii/sql-json-fix-2
Improve usability of JSON_VALUE
2021-11-18 23:39:17 +03:00
kssenii
11ab1f1ae5 Fix 2021-11-18 08:46:31 +00:00
kssenii
4016530b99 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into sql-json-fix-2 2021-11-18 08:33:50 +00:00
Vladimir C
0a3a43c017
Merge pull request #30984 from qieqieplus/untuple-func-alias 2021-11-18 10:42:20 +03:00
Kruglov Pavel
f27fcf8372
Merge pull request #31004 from Avogar/output-formats
Small refactoring in formats
2021-11-17 20:44:46 +03:00
avogar
4b332aea21 Temporary test fix 2021-11-17 17:54:15 +03:00
mergify[bot]
41fa94f482
Merge branch 'master' into notlike-fix 2021-11-17 07:14:21 +00:00
alexey-milovidov
4f5745108e
Merge pull request #31456 from azat/client-editor
Fix waiting of the editor during interactive query editing
2021-11-17 10:13:04 +03:00
Kseniia Sumarokova
d1374481df
Merge pull request #31457 from azat/local-pager
Add --pager support for clickhouse-local
2021-11-17 09:29:56 +03:00
Azat Khuzhin
e26d755b9b Fix 01610_client_spawn_editor
quotes are superfluous, and after shell wrapper had been removed it had
been broken:

    24484 execve("/src/ch/clickhouse/tests/queries/0_stateless\"/01610_client_spawn_editor_open.editor\"", ["/src/ch/clickhouse/tests/queries/0_stateless\"/01610_client_spawn_editor_open.editor\"", "clickhouse_replxx_GWyu5Y.sql"], 0x7fffffffcf90 /* 100 vars */) = -1 ENOENT (No such file or directory)
    24484 write(1, "Cannot execute /src/ch/clickhouse/tests/queries/0_stateless\"/01610_client_spawn_editor_open.editor\": errno: 2, strerror: No such file or directory\n", 147) = 147
    24484 exit_group(-1)                    = ?
2021-11-16 23:40:05 +03:00
Azat Khuzhin
7a22b8f3d4 Add a test for --pager in clickhouse-local/clickhouse-client 2021-11-16 22:25:32 +03:00
Nikolay Degterinsky
2f6a565b06 Merge branch 'master' into query_parameters 2021-11-16 10:37:58 +00:00
tavplubix
710fbebafc
Merge pull request #30977 from ClickHouse/check_dependencies_on_drop
Check dependencies on DROP TABLE
2021-11-16 11:38:42 +03:00
Nikolay Degterinsky
417b12d0d8 Fix test 2021-11-15 21:02:09 +00:00
Nikolay Degterinsky
ba50e8387d Merge branch 'master' into query_parameters 2021-11-15 19:55:54 +00:00
Nikolay Degterinsky
5c5897c1cd Apply suggestions from code review
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2021-11-15 17:57:26 +00:00
Kseniia Sumarokova
b040890fcf
Merge pull request #31420 from kssenii/fix-positional-args-bug
Fix group by with positional args
2021-11-15 20:42:58 +03:00
kssenii
6fe803e31e Fix 2021-11-15 15:09:04 +03:00
Alexander Tokmakov
416a82b99a Merge branch 'master' into check_dependencies_on_drop 2021-11-15 13:35:45 +03:00
Azat Khuzhin
fa317e96e8 Do not try to resolve temporary tables from global context 2021-11-15 10:32:19 +03:00
qieqieplus
b6aa781c9b add dot separator 2021-11-15 14:47:34 +08:00
Kseniia Sumarokova
846fbd059b
Merge pull request #31403 from kssenii/fix-client-output
Fix client
2021-11-14 15:01:30 +03:00
kssenii
9ea8408d8d Add test 2021-11-14 07:58:19 +00:00
alexey-milovidov
5712f9077d
Merge pull request #31393 from azat/fix-stderr-before-reopen
Check stderr is writable before reopining it (to avoid losing errors)
2021-11-14 01:44:08 +03:00
alexey-milovidov
e323b83f6a
Merge pull request #30876 from pmed/backslash_letter_interactive_input
add aliases for `\<letter>` interactive client commands
2021-11-14 01:43:13 +03:00
Azat Khuzhin
ed4b5c7640 Check stderr is writable before reopining it (to avoid losing errors) 2021-11-13 22:26:05 +03:00
mergify[bot]
5d0306ed0c
Merge branch 'master' into notlike-fix 2021-11-12 22:35:10 +00:00
Kruglov Pavel
051a9e7c69
Merge pull request #31249 from vitlibar/fix-show-grants
Fix SHOW GRANTS when partial revokes are used.
2021-11-12 15:49:12 +03:00
tavplubix
8916d3bebf
Merge pull request #31305 from ClickHouse/rename_support_ifexists
Merging #31081
2021-11-12 15:22:43 +03:00
Anton Popov
7769ed76ce
Merge pull request #31261 from CurtizJ/tuple-element-to-subcolumn
Optimize tupleElement to reading of subcolumn
2021-11-12 15:00:53 +03:00
Anton Popov
4c6c80b9a2
Merge pull request #31044 from kssenii/fix-storage-merge-with-aliases-and-where
Fix StorageMerge with aliases and where
2021-11-11 21:46:02 +03:00
Nikolay Degterinsky
7b5954b736 Merge branch 'master' into query_parameters 2021-11-11 11:43:00 +00:00
tavplubix
dd720ec9b4
Merge pull request #31252 from ClickHouse/warning_for_obsolete_settings
Show warning if some obsolete setting changed
2021-11-11 13:41:49 +03:00
alesapin
8cb3c5cb57
Merge pull request #31248 from ClickHouse/add_flaky_check
Add flaky check to new CI
2021-11-11 12:44:36 +03:00
alesapin
2f42a5137d Trying flaky check 2021-11-11 11:44:53 +03:00
Nikolai Kochetov
b062c8ca51
Merge pull request #31031 from cmsxbc/throw-exception-offset-fetch-without-order-by
improve error message while using OFFSET FETCH clause without ORDER BY
2021-11-11 11:37:16 +03:00
Vladimir C
b85710a673
Merge pull request #31105 from abel-cheng/fix-rewrite-in-local-in 2021-11-11 10:02:52 +03:00
cmsxbc
07708e99a5
fix ErrorCode in test because of confilict 2021-11-11 08:22:57 +08:00
cmsxbc
bb0f929a39
add test for offset fetch without order by 2021-11-11 08:20:47 +08:00
alexey-milovidov
e3650b865a
Merge pull request #30965 from kssenii/intersect-except-fix
Fix cases when intersect / except is not checked
2021-11-11 01:59:59 +03:00