Alexey Milovidov
0e7d05e091
Fix UBSan
2024-04-10 01:58:30 +02:00
Alexander Tokmakov
dedc25fd34
fix
2024-04-09 23:43:40 +02:00
Robert Schulze
8167b774b5
Merge pull request #62307 from rschu1ze/cleanup-ssh
...
Cleanup SSH-based authentication code
2024-04-09 21:10:09 +00:00
Robert Schulze
4035334634
Merge remote-tracking branch 'rschu1ze/master' into static-instance2
2024-04-09 11:45:27 +00:00
Alexey Milovidov
9ebf091ae4
Documentation
2024-04-08 13:03:55 +02:00
Alexey Milovidov
537f045c1c
Miscellaneous
2024-04-08 12:39:23 +02:00
Alexey Milovidov
0ff26d2d77
A little better
2024-04-08 12:39:23 +02:00
Alexey Milovidov
fb664fa99f
Slightly better
2024-04-08 12:39:23 +02:00
Alexey Milovidov
c8d6dc47c3
Fix test
2024-04-08 12:39:23 +02:00
Alexey Milovidov
b9406f79d1
Better highlighting
2024-04-08 12:39:23 +02:00
Alexey Milovidov
b369291d47
Rich syntax highlighting in the client
2024-04-08 12:39:23 +02:00
Alexey Milovidov
f5e9a09d69
Remove support for INSERT WATCH query
2024-04-08 05:37:09 +02:00
Robert Schulze
97281203b8
Don't access static members through instance, pt. II
...
clang-tidy rightfully complains
(-readability-static-accessed-through-instance) that static member
functions are accessed through non-static members
2024-04-07 11:09:35 +00:00
Kruglov Pavel
589034c34c
Merge branch 'master' into better-stress-upgrade-checks
2024-04-05 15:27:02 +02:00
Robert Schulze
9d8f643f5b
Cleanup SSH-based authentication code
2024-04-05 08:43:23 +00:00
Alexander Tokmakov
5a897bc43e
Update Connection.cpp
2024-04-04 20:16:26 +02:00
Kruglov Pavel
3116650fa9
Merge pull request #61201 from ClickHouse/revert-61200-revert-60430-max-parallel-replicas-validate
...
Don't allow to set max_parallel_replicas to 0 as it doesn't make sense
2024-04-03 17:05:59 +02:00
avogar
d87d5a9197
Merge branch 'master' of github.com:ClickHouse/ClickHouse into better-stress-upgrade-checks
2024-04-03 12:07:22 +00:00
Azat Khuzhin
4b668d0990
Unlimited output_format_pretty_max_value_width for --pager
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-03 12:33:14 +02:00
Alexey Milovidov
9da4ce29db
Revert output Pretty in tty
2024-03-29 16:16:15 +01:00
Nikita Mikhaylov
d18aba1194
Done
2024-03-27 19:26:19 +00:00
Azat Khuzhin
469be8ee8a
Implement input() for clickhouse-local
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 13:49:53 +01:00
Igor Nikonov
972af33400
Timeout injection
2024-03-26 12:30:16 +00:00
Azat Khuzhin
c7b919b19e
Replace distributed_insert_replicas_preferences with distributed_insert_skip_read_only_replicas
...
v2: fix test
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:24:57 +01:00
Azat Khuzhin
a19b27bd7c
Revert extra changed lines
...
That was the changes that looks OK for the initial patchset version, but
not now, after all review comments.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:24:16 +01:00
Azat Khuzhin
dbdf080108
Remove insert argument for ConnectionPoolWithFailover
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:22:38 +01:00
Azat Khuzhin
d922bfb1b0
Introduce distributed_insert_prefer_non_readonly_replica setting
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:21:40 +01:00
Azat Khuzhin
0e99781686
Move insert flag from ConnectionEstablisher to TryResult
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:21:40 +01:00
Azat Khuzhin
b9469e2729
Do not try to INSERT into readonly replicas for Distributed engine
...
Sometimes replica may be readonly for a long time, and this will make
some INSERT queries fail, but it does not make sense to INSERT into
readonly replica, so let's ignore them.
But note, that this will require to extend TableStatus (not extend, but
introduce new version), that will have is_readonly field.
Also before background INSERT into Distributed does not uses
getManyChecked() which means that they do not request TableStatus
packet, while now they would, though this is minor (just a note).
v2: Add a note about max_replica_delay_for_distributed_queries for INSERT
v3: Skip read-only replicas for async INSERT into Distributed
v4: Remove extra @insert parameter for ConnectionPool*::get*
It make sense only when the table name had passed --
ConnectionPoolWithFailover::getManyChecked()
v5: rebase on top LoggerPtr
v6: rebase
v7: rebase
v8: move TryResult::is_readonly into the end
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:21:38 +01:00
Azat Khuzhin
be2767b55c
Make ClientBase::parseQuery() static
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 10:54:57 +01:00
Alexey Milovidov
9b052d059d
No "please"
2024-03-26 09:00:20 +01:00
Kruglov Pavel
de1229ba60
Merge branch 'master' into better-stress-upgrade-checks
2024-03-25 19:18:35 +01:00
Alexey Milovidov
4db69c36f9
Remove unused code
2024-03-24 17:15:47 +01:00
Alexey Milovidov
c0c8cdc185
Add modifications
2024-03-23 02:42:22 +01:00
Alexey Milovidov
7365f4e32b
Add modifications
2024-03-23 01:43:28 +01:00
Alexey Milovidov
18c016caaa
Support for --output-format in client
2024-03-22 21:06:36 +01:00
Alexey Milovidov
4d113c2190
Merge pull request #61508 from ClickHouse/generic-clickhouse-local-fuzzer
...
Generic fuzzer of query text in clickhouse-local
2024-03-21 21:17:28 +03:00
Alexey Milovidov
14f45bfa74
Merge pull request #61679 from evillique/fix-msan-issue
...
Fix use-of-uninitialized-value in HedgedConnections
2024-03-21 18:09:40 +03:00
Alexey Milovidov
784de2dca3
Merge branch 'master' into generic-clickhouse-local-fuzzer
2024-03-21 03:18:05 +01:00
Nikolay Degterinsky
93dd212f6f
Fix use-of-uninitialized-value in HedgedConnections
2024-03-20 23:55:25 +00:00
Alexey Milovidov
6f4ce33f02
Change how fuzzer arguments are parsed
2024-03-20 22:12:57 +01:00
Kruglov Pavel
e7e11d738b
Merge branch 'master' into revert-61200-revert-60430-max-parallel-replicas-validate
2024-03-20 13:59:38 +01:00
Alexey Milovidov
7b7e260585
Merge remote-tracking branch 'origin/master' into generic-clickhouse-local-fuzzer
2024-03-20 01:28:28 +01:00
Raúl Marín
de855ca917
Reduce header dependencies
2024-03-19 17:04:29 +01:00
avogar
dba72bf9c5
Fix
2024-03-19 10:02:35 +00:00
avogar
31d5049f80
Move logic of ignoring drop queries to server
2024-03-18 16:26:05 +00:00
avogar
aadc610739
Merge branch 'master' of github.com:ClickHouse/ClickHouse into better-stress-upgrade-checks
2024-03-18 15:27:58 +00:00
Robert Schulze
c17536c3b3
Enable clang-tidy in headers
2024-03-18 08:00:09 +00:00
Alexey Milovidov
2eb7de859d
Correct arguments parsing
2024-03-18 02:35:32 +01:00
Alexey Milovidov
1a61da1bae
Replace getFuzzerData with query text fuzzer in clickhouse-local
2024-03-18 02:17:24 +01:00
Alexey Milovidov
01136bbc3b
Limit backtracking in parser
2024-03-17 19:54:45 +01:00
avogar
2e9130ca1e
Better
2024-03-15 20:30:44 +00:00
avogar
aadfc37dda
Merge branch 'master' of github.com:ClickHouse/ClickHouse into better-stress-upgrade-checks
2024-03-15 20:27:16 +00:00
avogar
fa9d9ea3f7
Ignore DROP queries in stress test with 1/2 probability, use TRUNCATE instead of ignoring DROP in upgrade check for Memory/JOIN tables
2024-03-15 20:23:39 +00:00
Raúl Marín
b21a5fec7b
Fix broken list and thank clang tidy
2024-03-14 15:06:08 +01:00
Raúl Marín
617138cf48
Teach the fuzzer to use other numeric types
2024-03-13 16:54:28 +01:00
avogar
a065231ca1
Remove unused error code
2024-03-12 12:07:36 +00:00
avogar
dd6599868a
Better check for 0 setting value
2024-03-12 12:06:25 +00:00
Kruglov Pavel
5608005b34
Revert "Revert "Don't allow to set max_parallel_replicas to 0 as it doesn't make sense""
2024-03-11 21:22:45 +01:00
Kruglov Pavel
a90a6e9a27
Revert "Don't allow to set max_parallel_replicas to 0 as it doesn't make sense"
2024-03-11 21:05:44 +01:00
Kruglov Pavel
1c1336bdc0
Merge pull request #60430 from Avogar/max-parallel-replicas-validate
...
Don't allow to set max_parallel_replicas to 0 as it doesn't make sense
2024-03-11 18:04:54 +01:00
Sema Checherinda
80179e50e4
Merge pull request #58845 from ClickHouse/chesema-session-pool
...
HTTP connections pool
2024-03-10 14:06:59 +01:00
Sema Checherinda
4df406d3ad
work with review notes
2024-03-10 10:00:18 +01:00
Sema Checherinda
5c41727725
http connections pools
2024-03-10 10:00:18 +01:00
tomershafir
453eb25984
rm trailing whitespace
2024-03-10 08:42:54 +02:00
tomershafir
4af16043b8
improve randomness by erase buf elem when full
2024-03-09 21:27:28 +02:00
tomershafir
46332f334c
rm unused alias set/vector pair
2024-03-08 15:17:07 +02:00
Sema Checherinda
62f9a00da8
shuffle resolved IPs
2024-03-07 13:09:26 +01:00
avogar
595c75ec53
Merge branch 'master' of github.com:ClickHouse/ClickHouse into max-parallel-replicas-validate
2024-03-05 11:19:04 +00:00
Robert Schulze
4ee1aa8c7c
Fixing more headers
2024-02-29 15:40:30 +00:00
Alexey Milovidov
e1e66dc2b8
Merge pull request #60095 from ClickHouse/fix-inconsistent-formatting
...
Fix inconsistent formatting of queries
2024-02-29 00:41:40 +03:00
Alexey Milovidov
d93d5c2a00
Merge pull request #60470 from ClickHouse/ClibMouse-bugfix/kql-distributed-tables
...
Merging #59674 .
2024-02-28 19:24:14 +03:00
Alexey Milovidov
acbcffea13
Fix error
2024-02-27 23:33:16 +01:00
Kruglov Pavel
58a53b42ac
Set max_entries to min(max_parallel_replicas, all available reolicas)
2024-02-27 14:31:35 +01:00
Alexey Milovidov
0b90076a36
Revert "Revert "Check stack size in Parser""
2024-02-27 01:34:50 +03:00
Kruglov Pavel
f264f0a036
Fix style
2024-02-26 22:06:10 +01:00
Kruglov Pavel
8aa9f36484
Fix style
2024-02-26 22:05:54 +01:00
avogar
ac4af6a4ad
Don't allow to set max_parallel_replicas to 0 as it doesn't make sense
2024-02-26 19:58:49 +00:00
Alexey Milovidov
6c6376de0a
Fix compatibility
2024-02-26 12:58:02 -05:00
Alexey Milovidov
3613464d46
Fix the code
2024-02-26 12:58:02 -05:00
Austin Kothig
f5ba7fde9f
Only set dialect if KQL or PRQL.
2024-02-26 12:58:01 -05:00
kothiga
70248639e8
Include PRQL. Added functional test that tests both KQL and PRQL.
2024-02-26 12:58:01 -05:00
kothiga
90a18326a5
Fix KQL distributed tables queries.
2024-02-26 12:58:01 -05:00
Alexey Milovidov
979cd2937b
Fix inconsistent formatting of SET param_...
2024-02-26 02:11:51 +01:00
Igor Nikonov
a0105e94ba
Merge pull request #60077 from ClickHouse/cleanup-connection-pool-priority
...
Cleanup: less confusion between config priority and balancing priority in connection pools
2024-02-21 15:22:08 +01:00
Igor Nikonov
0ead912127
Merge pull request #60158 from ClickHouse/fix-slowdown-count-side-effect
...
Fix: custom key failover test flakiness
2024-02-21 12:55:46 +01:00
Antonio Andelic
fee1565780
Revert "Check stack size in Parser"
2024-02-21 11:33:08 +01:00
Igor Nikonov
a8e4627663
Fix: can't guarantee query distribution with enabled hedged requests
2024-02-20 12:09:54 +00:00
Igor Nikonov
bb5a6dd8d3
Fix: custom key failover test flakyness
...
slowdown_count used only by hedge connections
but it's stored inside connection pool and was used for pool shuffling
always. So, query execution which used hedged connections could affect
connection load balancing for queries w/o hedged connections by updating
slowdown_count
2024-02-19 20:44:55 +00:00
Igor Nikonov
f06e15ce5f
Merge remote-tracking branch 'origin/master' into cleanup-connection-pool-priority
2024-02-19 11:33:55 +00:00
Alexey Milovidov
ad26b6fc8d
Remove useless headers
2024-02-19 07:08:24 +01:00
Alexey Milovidov
6fd563df52
Miscellaneous
2024-02-19 02:58:51 +01:00
Alexey Milovidov
73ab7a5556
Merge branch 'master' of github.com:ClickHouse/ClickHouse into implement-todo
2024-02-18 09:24:22 +01:00
Alexey Milovidov
d10b18afeb
I found TODO in the code, that can be implemented
2024-02-17 02:21:55 +01:00
Alexey Milovidov
2f315e0eb5
Style check for abbreviations
2024-02-17 02:14:15 +01:00
Igor Nikonov
b85a68790a
Cleanup: connection pool priority -> config priority
...
- names were creating confusion between config priority and balancing priority for a reader
2024-02-16 14:39:41 +00:00
Kruglov Pavel
1dbfeafb42
Merge branch 'master' into auto-format-detection
2024-02-13 19:08:33 +01:00
Igor Nikonov
3fb30a23d9
Merge remote-tracking branch 'origin/master' into pr-better-replicas-failover-2
2024-02-08 09:09:11 +00:00
Igor Nikonov
10082399d5
Minor review fixes
2024-02-07 00:52:25 +00:00
Igor Nikonov
b9848dbd2c
Remove unused is_finished
2024-02-06 14:30:19 +00:00
