Commit Graph

141565 Commits

Author SHA1 Message Date
Antonio Andelic
3fd8b46264
Merge pull request #63538 from ClickHouse/race-distributed-sink
Fix data race in `DistributedSink`
2024-05-09 06:53:44 +00:00
Antonio Andelic
d1c20d08c3
Merge pull request #63323 from ClickHouse/use-getparentpartname
Try fix segfault in `MergeTreeReadPoolBase::createTask`
2024-05-09 06:52:12 +00:00
Antonio Andelic
bc9d50cf16
Merge pull request #63523 from ClickHouse/leftover-threads-copy
Correctly stop `asyncCopy` tasks in all cases
2024-05-09 06:50:51 +00:00
Azat Khuzhin
27b41650f8 Fix crash on exit with sentry enabled (due to openssl destroyed before sentry)
The problem is tha openssl registers OPENSSL_cleanup() as atexit
handler, which called before destroying of SentryWriter, so to avoid
this problem, let's destroy it explicitly.

<details>

<summary>stack trace example</summary>

    Thread 2 (Thread 0x7ffff54006c0 (LWP 24847) "clickhouse-serv"):
    0  ___pthread_rwlock_rdlock (rwlock=0x0) at pthread_rwlock_rdlock.c:26
    1  0x00000000164c18a9 in CRYPTO_THREAD_read_lock (lock=0x0) at threads_pthread.c:93
    2  0x000000001642e6b9 in int_err_get_item (d=0x7ffff53f74e0) at err.c:192
    ...
    7  ossl_connect_common (cf=0x7ffff7812c80, data=0x7ffff70a4c00, nonblocking=bool_true, done=0x7ffff53f834c) at openssl.c:4486
    ...
    17 curl_easy_perform (data=data@entry=0x7ffff70a4c00) at easy.c:787
    18 0x000000000b4c3854 in sentry__curl_send_task (_envelope=<optimized out>, _state=0x7ffff7074300) at sentry_transport_curl.c:225
    19 0x000000000b4ba880 in worker_thread (data=0x7ffff70e5500) at sentry_sync.c:262

    Thread 1 (Thread 0x7ffff7cb2c80 (LWP 24842) "clickhouse-serv"):
    5  0x000000000b4bb0e2 in sentry__cond_wait_timeout (cv=0x7ffff70e5540, mutex=0x7ffff70e5570, msecs=250) at sentry_sync.h:332
    6  sentry__bgworker_shutdown (bgw=0x7ffff70e5500, timeout=2000) at sentry_sync.c:412
    7  0x000000000b4b3e95 in sentry_close () at sentry_core.c:238
    8  0x000000000b4a5f1f in SentryWriter::~SentryWriter (this=0x7ffff71a1240) at SentryWriter.cpp:147
    9  std::__1::default_delete<SentryWriter>::operator()[abi:v15000](SentryWriter*) const (this=0x7ffff70e5568, __ptr=0x7ffff71a1240) at unique_ptr.h:48
    10 std::__1::unique_ptr<SentryWriter, std::__1::default_delete<SentryWriter> >::reset[abi:v15000](SentryWriter*) (this=0x7ffff70e5568, __p=0x0) at unique_ptr.h:305
    11 std::__1::unique_ptr<SentryWriter, std::__1::default_delete<SentryWriter> >::~unique_ptr[abi:v15000]() (this=0x7ffff70e5568) at unique_ptr.h:259
    12 0x00007ffff7de62e6 in __run_exit_handlers (status=0, listp=<optimized out>, run_list_atexit=run_list_atexit@entry=true, run_dtors=run_dtors@entry=true) at exit.c:108
    13 0x00007ffff7de642e in __GI_exit (status=<optimized out>) at exit.c:138
    14 0x00007ffff7dccd51 in __libc_start_call_main (main=main@entry=0x6111c20 <main(int, char**)>, argc=argc@entry=13, argv=argv@entry=0x7fffffffb718) at libc_start_call_main.h:74
    15 0x00007ffff7dcce0c in __libc_start_main_impl (main=0x6111c20 <main(int, char**)>, argc=13, argv=0x7fffffffb718, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffb708) at libc-start.c:360

    (gdb) p req.body
    $7 = 0x7ffff7816000 "{\"dsn\":\"...\"}\n{\"type\":\"session\",\"length\":190}\n{\"init\":true,\"sid\":\"...\",\"status\":\"exited\",\"errors\":0,\"started\":\"2024-05-08T20:29:23.253Z\",\"duration\":17.213,\"attrs\":{\"release\":\"24.5\",\"environment\":\"test\"}}"

</details>

P.S. Likely started happens after conversion to OpenSSL (#59870).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-09 07:39:23 +02:00
Volodyachan
c52af8c259
Merge branch 'master' into fix-tabs-in-pretty-format 2024-05-09 05:22:51 +03:00
Alexey Milovidov
c198bbcafb Useless changes 2024-05-09 04:20:54 +02:00
Alexey Milovidov
224e1940ae Useless changes 2024-05-09 03:58:34 +02:00
Alexey Milovidov
97f24f38b8 Useless changes 2024-05-09 03:14:26 +02:00
Alexey Milovidov
0d14a2c67e Useless changes 2024-05-09 03:11:02 +02:00
Konstantin Bogdanov
27551ca3c7
Add jwcrypto to integration tests runner 2024-05-09 04:08:21 +03:00
Alexey Milovidov
1d69518c4d Useless changes 2024-05-09 02:07:04 +02:00
Nikita Mikhaylov
8a7c031cf5
Merge pull request #63546 from jkartseva/no-s3-storage-tag-plain-rw
Add `no-s3-storage` tag to local_plain_rewritable ut
2024-05-09 00:05:54 +00:00
Alexey Milovidov
95f12ef274 Useless changes 2024-05-09 01:08:33 +02:00
Alexey Milovidov
536398a916
Merge pull request #63527 from ClickHouse/everything-should-work-on-aarch64-part-2
Almost everything should work on AArch64 (Part of #58061)
2024-05-08 22:46:06 +00:00
Alexey Milovidov
962d5e5bda
Merge pull request #63479 from yariks5s/add_setting_from_multiline_strings
Add setting for better rendering of multiline string for pretty format
2024-05-08 22:42:38 +00:00
Blargian
2f3231541c Make relevant changes to subtractXYZ 2024-05-08 23:58:51 +02:00
Shaun Struwig
c238ccd350
Merge branch 'master' into document_addXYZ 2024-05-08 23:54:52 +02:00
Blargian
f9965b6430 Review changes 2024-05-08 23:46:15 +02:00
Alexey Milovidov
8c4a5d3663
Merge pull request #61823 from ClickHouse/total-rows-in-system-zeros-generate-random
Set total_rows_approx for trivial queries with LIMIT from system.zeros and generateRandom
2024-05-08 21:32:35 +00:00
Alexey Milovidov
39b4411028
Merge pull request #63515 from ClickHouse/fix-rabbitmq-heap-use-after-free
Fix rabbitmq heap-use-after-free with clang18
2024-05-08 21:30:28 +00:00
Alexey Milovidov
a3e1506ee2
Merge pull request #63531 from ClickHouse/kssenii-patch-9
Update 02240_system_filesystem_cache_table.sh
2024-05-08 21:28:29 +00:00
Alexey Milovidov
e2ca4aaa09
Merge pull request #63530 from ClickHouse/tavplubix-patch-10
Update randomization of `old_parts_lifetime`
2024-05-08 23:29:22 +02:00
Alexey Milovidov
b25defe17a Fixing some clang-tidy warnings 2024-05-08 22:38:52 +02:00
Shaun Struwig
4c9cc50781
Merge branch 'ClickHouse:master' into document_isXYZ 2024-05-08 22:04:38 +02:00
Julia Kartseva
afda3c24e4 Add no-s3-storage tag to local_plain_rewritable ut
This blacklists the test in the distributed cache build.
2024-05-08 19:47:51 +00:00
Blargian
4cb64d3b68 Trigger Build 2024-05-08 21:26:02 +02:00
Alexey Milovidov
773654c46e Merge branch 'master' of github.com:ClickHouse/ClickHouse into clang-18-ci 2024-05-08 21:24:04 +02:00
Alexey Milovidov
c4fc786a46 Merge branch 'clang-18-ci' of github.com:ClickHouse/ClickHouse into clang-18-ci 2024-05-08 21:23:46 +02:00
Mikhail f. Shiryaev
47473d77ab
Find a proper commit for cumulative A Sync status 2024-05-08 20:31:02 +02:00
Alexey Milovidov
8d2fcbd91d Remove check 2024-05-08 18:50:46 +02:00
Nikolai Kochetov
ff810ceb39 Try another fix and add simplier test. 2024-05-08 16:50:42 +00:00
alesapin
dc7f515945
Merge pull request #63540 from ClickHouse/run_azure_on_master
Fix azure tests run on master
2024-05-08 16:28:09 +00:00
Alexey Milovidov
c3b0a28513
Merge pull request #63528 from kitaisreal/recursive-cte-documentation-fix
Recursive CTE documentation fix
2024-05-08 16:24:21 +00:00
Alexey Milovidov
4f73b3b4cb
Merge pull request #63532 from ClickHouse/revert-63525-revert-63443-fix-index-analysis-datetime64
Revert "Revert "Fix index analysis for `DateTime64`""
2024-05-08 18:33:59 +02:00
alesapin
bbb8cc0e93 Fix azure tests run on master 2024-05-08 18:01:50 +02:00
Kseniia Sumarokova
96dd6c03cd
Update src/Storages/MergeTree/DataPartStorageOnDiskFull.h
Co-authored-by: SmitaRKulkarni <Smita.Kulkarni@clickhouse.com>
2024-05-08 18:01:47 +02:00
Nikolai Kochetov
2e93bf92d7
Merge pull request #63415 from ClickHouse/revert-63297-revert-63047-do-not-remove-group-by-constants-for-secondary-query
Revert "Revert "Do not remove server constants from GROUP BY key for secondary query.""
2024-05-08 16:01:05 +00:00
Yarik Briukhovetskyi
767e32d566
Merge pull request #63406 from yohannj/fix_error_codes
Update ErrorCodes for functions using NUMBER_OF_ARGUMENTS_DOESNT_MATCH
2024-05-08 15:12:00 +00:00
Antonio Andelic
071ff50d20 Fix data race inside distributed sink 2024-05-08 17:08:12 +02:00
kssenii
c2b8443111 Fix for RabbitMQ 2024-05-08 16:51:28 +02:00
kssenii
3b318fb3c6 Fix for RabbitMQ 2024-05-08 16:50:22 +02:00
Raúl Marín
7eb5c9354b
Revert "Revert "Fix index analysis for DateTime64"" 2024-05-08 16:44:37 +02:00
Kseniia Sumarokova
caa1505104
Update 02240_system_filesystem_cache_table.sh 2024-05-08 16:43:05 +02:00
Alexander Tokmakov
a08a07723b
Update clickhouse-test 2024-05-08 16:26:03 +02:00
Raúl Marín
b82b19ad6a
Merge pull request #63525 from ClickHouse/revert-63443-fix-index-analysis-datetime64
Revert "Fix index analysis for `DateTime64`"
2024-05-08 14:25:36 +00:00
Maksim Kita
5885f4263b Recursive CTE documentation fix 2024-05-08 17:20:38 +03:00
Alexey Milovidov
f188866f95 Part of #58061 2024-05-08 16:17:36 +02:00
Raúl Marín
1e03649826
Revert "Fix index analysis for DateTime64" 2024-05-08 16:14:15 +02:00
Alexey Milovidov
7ff4c539f0
Merge pull request #63495 from ClickHouse/binary-symbols
Insert symbols info to the CI database
2024-05-08 14:07:01 +00:00
Nikita Mikhaylov
afdb773d17
Merge pull request #62896 from lyrixx/dx-join-get
dx: Enhance error message when non-deterministic function is used with Replicated source
2024-05-08 14:05:05 +00:00