Commit Graph

4699 Commits

Author SHA1 Message Date
Alexey Milovidov
01136bbc3b Limit backtracking in parser 2024-03-17 19:54:45 +01:00
Alexey Milovidov
bfea36877b
Merge pull request #61499 from ClickHouse/fix-fuzzers
Fix fuzzers
2024-03-17 21:15:10 +03:00
Alexey Milovidov
44e918bc67 Revive getFuzzerData 2024-03-17 16:22:33 +01:00
Alexey Milovidov
427a8b3264 Less crap 2024-03-17 13:20:49 +01:00
avogar
4ceff16787 Fix bad conflict resolution 2024-03-15 20:29:19 +00:00
avogar
fa9d9ea3f7 Ignore DROP queries in stress test with 1/2 probability, use TRUNCATE instead of ignoring DROP in upgrade check for Memory/JOIN tables 2024-03-15 20:23:39 +00:00
Han Fei
91d18649f4 update comments 2024-03-15 16:23:51 +01:00
alesapin
38cd6ef27d Merge branch 'master' into merge_config 2024-03-15 13:52:52 +01:00
Alexey Milovidov
c9fb8ef54b Merge branch 'master' into split-cast-overload-resolver 2024-03-15 07:09:51 +01:00
Alexey Milovidov
1a41aa4ac7 Merge branch 'master' of github.com:ClickHouse/ClickHouse into split-cast-overload-resolver 2024-03-14 13:06:23 +01:00
Robert Schulze
3486b4a6e3
Merge remote-tracking branch 'rschu1ze/master' into clang-tidy-list 2024-03-14 10:44:20 +00:00
jsc0218
c5dc35e5c4 try enable grant of table engine in test 2024-03-14 01:31:45 +00:00
jsc0218
b3b46ea708 Merge remote-tracking branch 'origin/master' into TableEngineGrant_version2 2024-03-14 00:36:29 +00:00
Robert Schulze
4e12b5dc91
Some fixups 2024-03-13 16:54:20 +00:00
Robert Schulze
ce665eae30
Doc fixups 2024-03-13 15:13:17 +00:00
Kruglov Pavel
14402e450a
Merge pull request #61036 from HowePa/detect_stdout
Detect output format by file exctension in clickhouse-client(local)
2024-03-13 14:57:59 +01:00
alesapin
9b1d8a2f52 fix style 2024-03-13 14:15:34 +01:00
alesapin
6203d45b96 working version with comments 2024-03-13 13:12:48 +01:00
Han Fei
c7c64636d0 add a test 2024-03-12 23:31:33 +01:00
Robert Schulze
1b1685e3f1
Merge remote-tracking branch 'rschu1ze/master' into clang-tidy-list 2024-03-12 13:02:59 +00:00
Alexey Milovidov
5222ebc4b4 Merge branch 'master' of github.com:ClickHouse/ClickHouse into split-cast-overload-resolver 2024-03-12 06:37:38 +01:00
Nikita Mikhaylov
cfa042cb04 Merge branch 'master' of github.com:ClickHouse/ClickHouse into rip-copier 2024-03-11 15:45:20 +00:00
Robert Schulze
81b2a1f621
Fix build 2024-03-11 15:34:02 +00:00
Robert Schulze
802bae9661
GCC --> clang pragmas 2024-03-11 12:55:56 +00:00
Alexey Milovidov
4373d5ba16 Merge branch 'master' into split-cast-overload-resolver 2024-03-11 03:01:50 +01:00
serxa
5b796e1f42 Merge branch 'master' into async-loader-waiters-limit 2024-03-10 15:20:27 +00:00
Sema Checherinda
80179e50e4
Merge pull request #58845 from ClickHouse/chesema-session-pool
HTTP connections pool
2024-03-10 14:06:59 +01:00
Alexey Milovidov
1179a70c21
Merge pull request #61118 from ClickHouse/simplify-bridges
Simplify bridges
2024-03-10 14:46:52 +03:00
Sema Checherinda
5c41727725 http connections pools 2024-03-10 10:00:18 +01:00
Alexey Milovidov
3b8a8c9649 Better gitignore 2024-03-10 09:28:30 +01:00
Alexey Milovidov
157adefc70 Fix error 2024-03-10 09:17:29 +01:00
Alexey Milovidov
1a2d403f7b Miscellaneae 2024-03-10 09:16:21 +01:00
Alexey Milovidov
9ddec346a0 Miscellaneous 2024-03-10 09:02:34 +01:00
Alexey Milovidov
3ac4f56cfa Fix tests 2024-03-09 18:53:31 +01:00
Alexey Milovidov
e9ab3ed2dd Even better 2024-03-09 09:27:11 +01:00
Alexey Milovidov
47b308d234 Simplify bridges 2024-03-09 08:42:33 +01:00
Alexey Milovidov
70796e497f Miscellaneous 2024-03-09 08:32:13 +01:00
Alexey Milovidov
574d486322 Something 2024-03-09 07:55:59 +01:00
Alexey Milovidov
ea54ac3cb4 Remove garbage 2024-03-09 06:12:22 +01:00
Alexey Milovidov
6d45eecdad Remove garbage 2024-03-09 06:11:34 +01:00
Alexey Milovidov
2be09581dd Split CastOverloadResolver translation unit 2024-03-09 05:48:52 +01:00
Han Fei
c01a6775d7 fix style 2024-03-09 02:28:39 +01:00
Han Fei
4997f95426 fix build 2024-03-08 17:30:58 +01:00
Han Fei
c92fb8700f Merge branch 'master' into hanfei/check-limit-periodically 2024-03-08 03:59:41 +01:00
Nikita Mikhaylov
2bc4d27ac6 Bye bye 2024-03-07 19:24:39 +00:00
serxa
0f0ea422f2 separate limits on number of waiting and executing queries 2024-03-07 17:05:54 +00:00
Han Fei
7fd13df8a5 check memory limit periodically 2024-03-07 17:21:03 +01:00
HowePa
6d5fd2857e detect output format by file extension in clickhouse-client 2024-03-07 20:29:42 +08:00
HowePa
6c69e7d4dc detect output format by file extension in clickhouse-local 2024-03-07 20:29:04 +08:00
Sema Checherinda
62f9a00da8 shuffle resolved IPs 2024-03-07 13:09:26 +01:00
豪肥肥
1cd4bcdce8
Merge branch 'ClickHouse:master' into fix_local_option 2024-03-06 06:38:28 +08:00
Robert Schulze
b5a7ef5fd3
Merge remote-tracking branch 'rschu1ze/master' into clang-tidy-hdr 2024-03-05 11:24:28 +00:00
Alexey Milovidov
a7430004b3 Fix real time query profiler on AArch64 2024-03-04 18:13:49 +01:00
Alexey Milovidov
de6c5d3a40
Merge pull request #60552 from ClickHouse/pc2
Userspace page cache again
2024-03-04 17:47:35 +03:00
Alexey Milovidov
cbf5443585 Remove old code 2024-03-04 00:11:55 +01:00
Alexey Milovidov
c7fb3014ad Merge branch 'master' into async-load-by-default 2024-03-03 19:41:31 +01:00
Alexey Milovidov
079f5af0a8 Merge branch 'master' into async-load-by-default 2024-03-03 05:40:48 +01:00
Alexey Milovidov
4b69440e58 Dashboard: sticky header 2024-03-03 04:35:15 +01:00
Alexey Milovidov
e122a47b48 Simplification 2024-03-03 04:12:31 +01:00
Alexey Milovidov
df53b0c5f8 Merge branch 'master' into slightly-better-colors-on-dashboard 2024-03-03 04:09:09 +01:00
jsc0218
2b54c11d63
Merge branch 'ClickHouse:master' into TableEngineGrant_version2 2024-03-02 20:42:04 -05:00
Alexey Milovidov
c362bbc9ca
Merge pull request #60390 from ClickHouse/redirect-handlers
Allow configuring HTTP redirect handlers for clickhouse-server
2024-03-02 05:15:31 +03:00
Alexey Milovidov
e9fd11beea
Merge pull request #60624 from bluikko/patch-1
Fix typo in config.xml #60623
2024-03-02 04:52:56 +03:00
Antonio Andelic
8607e74966
Merge pull request #60537 from ClickHouse/keeper-snapshot-detached
Keeper improvement: abort during startup if an invalid snapshot is detected
2024-03-01 13:36:09 +01:00
Robert Schulze
af6755f241
Merge remote-tracking branch 'rschu1ze/master' into clang-tidy-hdr 2024-03-01 11:45:21 +00:00
bluikko
1aea952382
Fix typo in config.xml #60623
"be Tableau" should be "by Tableau".
2024-03-01 16:13:45 +07:00
Robert Schulze
562e483df4
Merge remote-tracking branch 'rschu1ze/master' into clang-tidy-hdr 2024-02-29 12:44:51 +00:00
Michael Kolupaev
42437a2ae1 Userspace page cache (#53770)
* Userspace page cache

* Maybe it'll build this time, who knows.

* 'auto' went out of fashion, I guess

* Documentation, tsan workaround, metric 'UnreclaimableRss', disable page cache in the test that uses DatabaseOrdinary

* Moved CachedInMemoryReadBufferFromFile to object store level, changed settings, addressed other comments.

* Fix

* Another fix

* Fix restricted seek, fix ppc64le build

* Don't allow page cache with file cache

* Adjust tests a little

* Fix clang-tidy

* Conflicts

* Comments

* Maybe unbroke AsynchronousBoundedReadBuffer

* SettingsChangesHistory.h

* Fix warning in test
2024-02-29 12:28:32 +00:00
Alexander Tokmakov
15e1191f74
Revert "Userspace page cache (#53770)"
This reverts commit 7b55c61551.
2024-02-29 13:20:17 +01:00
Robert Schulze
070f9d952f
Merge remote-tracking branch 'ClickHouse/master' into feature/increase_dns_cache_size 2024-02-29 11:27:59 +00:00
Michael Kolupaev
7b55c61551
Userspace page cache (#53770)
* Userspace page cache

* Maybe it'll build this time, who knows.

* 'auto' went out of fashion, I guess

* Documentation, tsan workaround, metric 'UnreclaimableRss', disable page cache in the test that uses DatabaseOrdinary

* Moved CachedInMemoryReadBufferFromFile to object store level, changed settings, addressed other comments.

* Fix

* Another fix

* Fix restricted seek, fix ppc64le build

* Don't allow page cache with file cache

* Adjust tests a little

* Fix clang-tidy

* Conflicts

* Comments

* Maybe unbroke AsynchronousBoundedReadBuffer

* SettingsChangesHistory.h

* Fix warning in test
2024-02-29 11:27:32 +00:00
Robert Schulze
0b4622ebf6
Add more suppressions for utils 2024-02-29 09:45:20 +00:00
Antonio Andelic
0cb839af0b Merge branch 'master' into keeper-snapshot-detached 2024-02-29 09:47:32 +01:00
Kirill Nikiforov
fe247cb64d rename dns_cache_max_size to dns_cache_max_entries 2024-02-29 06:03:44 +03:00
Robert Schulze
3b18eb4f17
Fix clang-tidy in some headers 2024-02-28 22:47:34 +00:00
jsc0218
b4b19ae2ad
Merge branch 'master' into TableEngineGrant_version2 2024-02-28 10:56:30 -05:00
豪肥肥
cca154b6b9
fix option ambiguous 2024-02-28 12:16:34 +08:00
Alexey Milovidov
8cf619bc03 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-28 00:30:44 +01:00
Antonio Andelic
f6d35cf4b1 Merge branch 'master' into keeper-snapshot-detached 2024-02-27 16:44:06 +01:00
Antonio Andelic
2c8759442d Move broken Keeper snapshots to detached folder 2024-02-27 15:16:10 +01:00
Alexey Milovidov
0721f524ce Merge branch 'master' into async-load-by-default 2024-02-27 02:19:32 +01:00
Alexey Milovidov
04fe5dc55c Merge branch 'master' into fix-inconsistent-formatting 2024-02-26 23:46:24 +01:00
Alexey Milovidov
fbfc4afb46
Merge branch 'master' into redirect-handlers 2024-02-27 01:27:38 +03:00
Robert Schulze
4794dc28f0
Merge remote-tracking branch 'ClickHouse/master' into dist/config-settings 2024-02-26 21:57:33 +00:00
Kirill Nikiforov
8b314a3ac8
Implement system.dns_cache table and dns_cache_max_size server setting (#60257)
* system.dns_cache table WIP

* system.dns_cache table

* rollback unexpected contrib changes

* rollback unexpected changes

* add docs

* code style fixes

* optimize dns cache exporting

* stateful test for system.dns_cache table

* stateful test for system.dns_cache table

* cr fixes

* stateful test for system.dns_cache table

* stateful test for system.dns_cache table

* implement system.dns_cache table

* system.dns_cache test

* system.dns_cache fix docs

* system.dns_cache prettify

* dns_cache_max_size settings

* fix system.dns_cache test

* Update dns_cache.md

* fix doc

Co-authored-by: pufit <pufit@clickhouse.com>

---------

Co-authored-by: pufit <pufit@clickhouse.com>
2024-02-26 15:48:02 -05:00
Alexey Milovidov
47734fbbe2
Merge pull request #60387 from ClickHouse/dashboard-more-convenient
Minor changes for dashboard
2024-02-26 22:52:44 +03:00
Alexey Milovidov
a3f1411679 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-26 19:01:11 +01:00
Alexey Milovidov
b71ae80fa9
Merge pull request #60392 from ClickHouse/fix-duplicate-chart-rendering
Fix duplicate and dangling charts on the Dashboard
2024-02-26 19:24:52 +03:00
Robert Schulze
048f7ec3e9
Merge pull request #59516 from rschu1ze/cgroup-observing-memory-tracker
Update memory tracker periodically with cgroup memory usage
2024-02-26 15:27:19 +01:00
Robert Schulze
1751d76234
Minor doc fixups 2024-02-26 11:42:11 +00:00
Robert Schulze
1e40b63cb1
Merge remote-tracking branch 'ClickHouse/master' into dist/config-settings 2024-02-26 11:15:51 +00:00
Alexey Milovidov
f9c0089526 Fix duplicate and dangling charts on the Dashboard 2024-02-26 01:31:29 +01:00
Alexey Milovidov
9d0e1c4deb Slightly better colors for multi-line graphs on the dashboard 2024-02-26 01:02:38 +01:00
Alexey Milovidov
2edb3d5ba1 Add documentation 2024-02-25 23:58:29 +01:00
Alexey Milovidov
b916479025 Add a test 2024-02-25 23:54:55 +01:00
Alexey Milovidov
27902ee4f6 Touch-up dashboard 2024-02-25 22:36:59 +01:00
Alexey Milovidov
9e32d0f5b2 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-23 15:05:46 +01:00
Vitaly Baranov
db119eed49
Merge pull request #60002 from vitlibar/add-config-setting-remove-backup-files-after-failure
Add new config setting "backups.remove_backup_files_after_failure"
2024-02-23 12:42:55 +01:00
János Benjamin Antal
7cad0050c0
Disambiguate alter commands list (#59532)
* Add optional parentheses to TTL element and alter command

* Add some basic tests

* Extend tests with more test cases

* Add one more test case

* Add server setting to control new formatting behavior

* Automatic style fix

* Fix segfault in `clickhouse-format` related to new server setting

* Remove format_ttl_expressions_with_parentheses

* Fix unit test compilation failures

* Introduce global flag to control the new formatting behavior

* Revert "Fix segfault in `clickhouse-format` related to new server setting"

This reverts commit d7131a3145.

* Revert accidental changes

* Revert accidental include reorder

* Revert accidental changes

* Enable new format in client and local server

---------

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
2024-02-22 19:17:15 +01:00
Vitaly Baranov
b130726a0c
Merge branch 'master' into add-config-setting-remove-backup-files-after-failure 2024-02-22 18:09:12 +01:00
Alexander Tokmakov
97ed2c05b0 Merge branch 'master' into fix_undead_sessions 2024-02-22 14:36:36 +01:00
Alexey Milovidov
2d9fbaa859 Merge with master 2024-02-21 20:37:48 +01:00
Alexander Tokmakov
64a80f1011
Fix default path when path is not specified in config (#59654)
* Update Server.cpp

* Update SentryWriter.cpp

* Update Keeper.cpp

* Update SentryWriter.cpp
2024-02-21 20:33:39 +01:00
Igor Nikonov
a0105e94ba
Merge pull request #60077 from ClickHouse/cleanup-connection-pool-priority
Cleanup: less confusion between config priority and balancing priority in connection pools
2024-02-21 15:22:08 +01:00
Sergei Trifonov
6e3fddf4a3
Merge pull request #59313 from ClickHouse/abstract-concurrency-control
Split `ISlotControl` from `ConcurrencyControl`
2024-02-21 15:04:03 +01:00
Robert Schulze
6a027b3528
Merge remote-tracking branch 'rschu1ze/master' into cgroup-observing-memory-tracker 2024-02-21 11:48:34 +00:00
Alexander Tokmakov
45d407034f Merge branch 'master' into fix_undead_sessions 2024-02-20 22:21:37 +01:00
Antonio Andelic
bb0b1fa9bc Fix 2024-02-20 14:46:16 +01:00
Antonio Andelic
a0bfb47e95 Merge branch 'master' into keeper-more-resilient-disks 2024-02-20 13:51:23 +01:00
Alexey Milovidov
c753550d0b Digging into a pile of garbage 2024-02-20 10:42:20 +01:00
jsc0218
afa7a95c8c add backward compatibility 2024-02-20 02:11:31 +00:00
Igor Nikonov
f06e15ce5f Merge remote-tracking branch 'origin/master' into cleanup-connection-pool-priority 2024-02-19 11:33:55 +00:00
Robert Schulze
ba9661a5d4
Merge remote-tracking branch 'rschu1ze/master' into cgroup-observing-memory-tracker 2024-02-19 09:54:08 +00:00
Alexey Milovidov
a955ae8673
Merge pull request #60086 from ClickHouse/check-wrong-abbrs
Check wrong abbreviations
2024-02-17 05:17:11 +01:00
Alexey Milovidov
3128cf1f1b Remove the check for formatting consistency from the Fuzzer 2024-02-17 02:24:21 +01:00
Alexey Milovidov
509d8ee99c Apply review comments 2024-02-17 01:54:54 +01:00
Alexey Milovidov
ceb65bb114 Merge branch 'master' of github.com:ClickHouse/ClickHouse into print-cpu-flags-at-startup 2024-02-17 01:53:56 +01:00
Igor Nikonov
b85a68790a Cleanup: connection pool priority -> config priority
- names were creating confusion between config priority and balancing priority for a reader
2024-02-16 14:39:41 +00:00
Kruglov Pavel
4d6f167e0c
Merge pull request #59092 from Avogar/auto-format-detection
Try to detect file format automatically during schema inference if it's unknown
2024-02-16 14:32:18 +01:00
Alexey Milovidov
39f363ba6e Print CPU flags at startup 2024-02-16 13:09:07 +01:00
Alexey Milovidov
0787e9f402 Merge remote-tracking branch 'origin/master' into print-cpu-flags-at-startup 2024-02-16 13:07:03 +01:00
Alexey Milovidov
5b83e771ed Print CPU flags at startup 2024-02-16 13:06:57 +01:00
Antonio Andelic
0f489de46e
Merge pull request #59945 from ClickHouse/keeper-prometheus-filtered-events
Send only Keeper related metrics/events for Prometheus
2024-02-16 09:43:43 +01:00
Alexander Tokmakov
22c97be2a4 ability to detect undead ZooKeeper sessions 2024-02-15 22:17:31 +01:00
Konstantin Bogdanov
dbb6804a70
Merge pull request #59976 from ClickHouse/add-cloud-placement
Add `PlacementInfo`
2024-02-15 19:16:56 +03:00
Alexey Milovidov
0b58f16938
Merge pull request #59964 from ClickHouse/cleanups
Cleanups
2024-02-15 02:59:54 +01:00
Vitaly Baranov
5591d74076 Add new config setting "backups.remove_backup_files_after_failure". 2024-02-14 23:19:21 +01:00
Alexey Milovidov
7a5e152d9e
Merge pull request #59967 from ClickHouse/dashboards-to-use-merge-tables
Use merge table in the dashboard; add Cloud overview to the system table
2024-02-14 21:56:37 +01:00
Antonio Andelic
40d4fc1c24 More resilient Disk related operations 2024-02-14 14:53:22 +01:00
Antonio Andelic
0bee591a0c Fix build 2024-02-14 14:10:58 +01:00
Yarik Briukhovetskyi
4c57400664
Merge pull request #59922 from xuzifu666/Common_imporve
Commands node args should add rvalue to push_back to reduce object copy cost
2024-02-14 12:42:45 +01:00
Konstantin Bogdanov
48fcc3eeab
Fix standalone build 2024-02-14 12:41:41 +01:00
Konstantin Bogdanov
f678bdc546
Update tests 2024-02-14 10:51:42 +01:00
Konstantin Bogdanov
914fd27d5b
Add PlacementInfo 2024-02-14 10:19:36 +01:00
Robert Schulze
7b7ea6d477
Merge remote-tracking branch 'rschu1ze/master' into cgroup-observing-memory-tracker 2024-02-14 08:56:22 +00:00
Alexey Milovidov
c49651ef89 Even less conflicts 2024-02-14 03:31:31 +01:00
Alexey Milovidov
39378deac1 Less conflicts 2024-02-14 03:09:40 +01:00
Alexey Milovidov
98f7602ea1 Less conflicts 2024-02-14 03:01:03 +01:00
Alexey Milovidov
27f115f581 Use merge table in the dashboard 2024-02-14 02:17:23 +01:00
Alexey Milovidov
2b4949bd18 Cleanups 2024-02-14 00:21:13 +01:00
Alexey Milovidov
8b59977639
Merge pull request #59909 from azat/rmt-macros-cleanup
Petite cleanup around macros and ReplicatedMergeTree
2024-02-14 00:09:34 +01:00
Kruglov Pavel
1dbfeafb42
Merge branch 'master' into auto-format-detection 2024-02-13 19:08:33 +01:00
Antonio Andelic
0d151e3f0d Send only specific events/metrics for Keeper prometheus 2024-02-13 16:01:50 +01:00
xuzifu666
12599c4b8e Commands node args should add rvalue to push_back 2024-02-13 17:35:55 +08:00
Alexey Milovidov
58563ef036
Merge pull request #59857 from azat/build/components-cleanup
Remove ability to disable generic clickhouse components
2024-02-13 04:21:08 +01:00
Azat Khuzhin
c61ac1d3bc Convert default_replica_path/default_replica_name into server settings
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 21:05:58 +01:00
Azat Khuzhin
13e3877254 Add chc/chl/ch into clickhouse-bundle target
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 14:32:15 +01:00
Azat Khuzhin
11fddc8d63 Unify binary aliases
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 12:06:33 +01:00
Azat Khuzhin
3145c5d5f5 Add missing install target for ch/chc/chl
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 12:02:42 +01:00
Azat Khuzhin
7fb31fe160 Remove ability to disable generic clickhouse components
Components like client/server/... are very generic, and there is no
point in disabling them, since it does not reduce amount of compiled
code a lot anyway (just a few modules for entrypoints, everything else
is already included in the clickhouse binary), and eventually they are
just symlinks to the clickhouse binary.

But there are few, that requires extra libraries, like ODBC bridge or
keeper components (and there is also standalone keeper binary compiled
with musl), those had been kept.

Also add some descriptions for some utils and change exit code to 0 for
--help.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 11:10:00 +01:00
Antonio Andelic
36b966967b Merge branch 'master' into keeper-more-reduce 2024-02-12 10:03:07 +01:00
Alexey Milovidov
5dbcff8048
Merge pull request #58609 from azat/binary-aliases-cmake
Create ch/chc/chl symlinks by cmake as well (for develop mode)
2024-02-11 23:45:58 +01:00
Alexey Milovidov
61227acdc4 Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-02-10 19:30:22 +01:00
Robert Schulze
3a4b6a2379
Merge remote-tracking branch 'rschu1ze/master' into cgroup-observing-memory-tracker 2024-02-10 13:53:19 +00:00
Azat Khuzhin
e6d96e4325 Better warning for disabled kernel.task_delayacct
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-10 14:49:43 +01:00
Alexey Milovidov
a7c30098b6 Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-02-09 22:52:49 +01:00
Antonio Andelic
35303603b6 Merge branch 'master' into keeper-more-reduce 2024-02-09 11:28:03 +01:00
Alexey Milovidov
a585ae60a8 English (somewhat incomplete) 2024-02-09 00:30:29 +01:00
Alexey Milovidov
1b91b7b999 Better logs in CI and non-interactive install 2024-02-09 00:16:15 +01:00
Robert Schulze
f6f1fd4d26
Initial implementation 2024-02-08 16:06:44 +00:00
serxa
0130d525f4 fix dashboard params default values 2024-02-08 12:02:28 +00:00
Antonio Andelic
33f12c9f35 Merge branch 'master' into keeper-more-reduce 2024-02-08 10:54:26 +01:00
Alexey Milovidov
02c0b4c67f Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-02-07 22:45:50 +01:00
Konstantin Bogdanov
38373b989a
Merge pull request #59659 from ClickHouse/create-tables-in-threadpool-followup
Follow up for #59277
2024-02-07 21:12:43 +03:00
Antonio Andelic
15c89bdd66 Merge branch 'master' into keeper-more-reduce 2024-02-07 14:21:31 +01:00
Alexey Milovidov
d65a56d967
Merge branch 'master' into enable-coverage-for-debug-build 2024-02-07 04:58:21 +01:00
Konstantin Bogdanov
5894fa9860
0 means number of cores 2024-02-06 19:10:34 +01:00
Alexey Milovidov
8a428eb7cf Better usability for server versions in ClickHouse Cloud 2024-02-06 18:37:14 +01:00
Antonio Andelic
a0170bcbd5 Fix utils 2024-02-05 17:58:33 +01:00
Antonio Andelic
2116043e2c Merge branch 'master' into keeper-more-reduce 2024-02-05 14:58:26 +01:00
Konstantin Bogdanov
f663f13a35
Merge pull request #59277 from ClickHouse/create-tables-in-threadpool
Concurrent tables creation in `recoverLostReplica`
2024-02-05 16:04:46 +03:00
serxa
9c93a76268 Fix backward incompatibility of dashboard url hashes 2024-02-04 12:50:26 +00:00
Amos Bird
e3716b0f38
Backward compatibility of uncompressed state 2024-02-04 11:03:18 +08:00
Alexey Milovidov
667256a67d Fixes for binary.html 2024-02-01 20:36:38 +01:00
Konstantin Bogdanov
5969668503
Concurrent table creation in DatabaseReplicated 2024-02-01 09:51:52 +01:00
Alexey Milovidov
a286d500c3
Merge pull request #59124 from amosbird/dashboard-compress-state
Compress state of dashboard
2024-01-30 08:05:38 +01:00
avogar
377937d415 Merge branch 'master' of github.com:ClickHouse/ClickHouse into auto-format-detection 2024-01-29 15:45:18 +00:00
Alexey Milovidov
cb69a1b25d Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-01-29 15:35:04 +01:00
Alexey Milovidov
8085f5f142 Merge branch 'master' into async-load-by-default 2024-01-29 00:03:47 +01:00
Alexey Milovidov
aec3f28ccb Support backups for compressed in-memory tables 2024-01-28 23:06:50 +01:00
Alexey Milovidov
4a94ae5a1b Merge branch 'master' into enable-coverage-for-debug-build 2024-01-28 22:24:26 +01:00
serxa
ba85642453 split ISlotControl from ConcurrencyControl 2024-01-28 20:26:55 +00:00
Alexey Milovidov
77de2b0ebc
Merge pull request #59311 from ClickHouse/binary-allow-user-host-password
`/binary` handler: allow specifying user/password/host
2024-01-28 20:33:39 +01:00
Alexey Milovidov
45cb7094af
Merge pull request #59303 from ClickHouse/play-rendering-errors-json
Play UI: improve rendering of errors from JSON formats
2024-01-28 18:32:27 +01:00
Alexey Milovidov
4dcf27e5b2 /binary: allow specifying user/password/host 2024-01-28 18:27:15 +01:00
Alexey Milovidov
9dd6362ae7 Play UI: improve rendering of errors from JSON formats 2024-01-28 13:44:56 +01:00
Azat Khuzhin
4248ae509a Support specifying settings for Distributed engine in config (like for MergeTree)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-27 18:06:16 +01:00
Azat Khuzhin
1404b73b50 Add example of configuring ReplicatedMergeTree via config.xml
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-27 17:03:18 +01:00
Kruglov Pavel
946c4e0495
Merge branch 'master' into auto-format-detection 2024-01-26 15:51:35 +01:00
Sergei Trifonov
4fb511bfb3
Merge pull request #59137 from ClickHouse/fix-async-loader-shutdown-deadlock
Fix not started database shutdown deadlock
2024-01-26 11:21:13 +01:00
Kruglov Pavel
46a6b84a5a
Merge branch 'master' into auto-format-detection 2024-01-25 22:11:07 +01:00
Maksim Kita
2a327107b6 Updated implementation 2024-01-25 14:31:49 +03:00
serxa
a40da92761 Merge branch 'master' into fix-async-loader-shutdown-deadlock 2024-01-25 11:31:05 +00:00
Antonio Andelic
3e3ae52aca Reduce even more memory 2024-01-25 08:40:19 +00:00
Nikolay Edigaryev
c8adf35298
DisksApp.cpp: fix typo (specifiged → specified) 2024-01-24 02:34:17 +04:00
serxa
8728ab768f Fix not started database shutdown deadlock 2024-01-23 19:01:57 +00:00
avogar
48609d3c9f Fix tests 2024-01-23 18:59:40 +00:00
avogar
617cc514b7 Try to detect file format automatically during schema inference if it's unknown 2024-01-23 18:59:39 +00:00
Amos Bird
7e86c0e928
Compress state of dashboard 2024-01-23 23:04:19 +08:00
Robert Schulze
e23e7e6b73
Merge pull request #53710 from rschu1ze/system-reload-asynchronous-metrics
Add statement `SYSTEM RELOAD ASYNCHRONOUS METRICS`
2024-01-23 11:56:25 +01:00
serxa
7b99d9a176 wait for currently running jobs to finish #2 2024-01-22 23:50:53 +00:00
serxa
1d6d1182fd Fix server shutdown due to exception while loading metadata 2024-01-22 19:38:26 +00:00
Robert Schulze
90a0ea36b3
Add statement 'SYSTEM RELOAD ASYNCHRONOUS METRICS' 2024-01-22 17:14:58 +00:00
Alexander Tokmakov
b8d69ecd5f
Update Client.cpp 2024-01-22 17:00:56 +01:00
Vitaly Baranov
01aafda27b
Merge pull request #58804 from vitlibar/allow-kill-query-for-backups
Allow KILL QUERY for backups
2024-01-20 23:48:18 +01:00
Alexey Milovidov
dc1dac3ba4 Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-01-20 21:41:07 +01:00
Alexey Milovidov
735708e9bb Merge branch 'master' into enable-coverage-for-debug-build 2024-01-20 21:40:53 +01:00
robot-clickhouse
273a06856a
Merge pull request #59025 from ClickHouse/cpu-scheduler
Split resource scheduler off `IO/` into `Common/Scheduler/`
2024-01-20 15:43:50 +01:00
Kseniia Sumarokova
5d67e26fc4
Merge pull request #58869 from ClickHouse/force-check-for-cached-custom-disk
Fix for custom cached disk creation
2024-01-20 14:47:36 +01:00
serxa
824deab761 split resource scheduler off IO/ into Common/Scheduler/ 2024-01-20 12:06:26 +00:00
Kruglov Pavel
90057c6f39
Merge pull request #58907 from ClickHouse/Avogar-patch-1
Fix possible crash in clickhouse-local during loading suggestions
2024-01-19 11:20:25 +01:00
Vitaly Baranov
4c6d3e7efa Add server settings "shutdown_wait_backups_and_restores" (default=true)
to set whether shutdown should wait for running backups to finish or just cancel them.
2024-01-18 13:27:14 +01:00
Alexey Milovidov
c098f41dbc Merge branch 'master' into enable-coverage-for-debug-build 2024-01-17 22:35:51 +01:00
Kruglov Pavel
79b3e19eb1
Fix style 2024-01-17 14:54:18 +01:00
Kruglov Pavel
63ac1c784f
Fix possible crash in clickhouse-local during loading suggestions 2024-01-17 14:28:10 +01:00
kssenii
3d564c0802 Fix typo 2024-01-17 10:34:13 +01:00
Mikhail Koviazin
6e6197019c
Reintroduce commit 3067ca6
Update `query_masking_rules` when reloading the config

This reverts commit 7e55eab1c3.
2024-01-17 08:10:49 +02:00
kssenii
237146b4e2 Add to default config 2024-01-16 16:30:07 +01:00
Alexey Milovidov
1caef19143 Maybe better 2024-01-16 09:44:52 +01:00
Alexey Milovidov
779f738cb9 Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-01-16 05:07:17 +01:00
Kseniia Sumarokova
ae884760db
Merge pull request #58357 from ClickHouse/better-disks-configuration
Flexible configuration for disks
2024-01-15 21:34:36 +01:00
Alexey Milovidov
e13ca48bce Better dump on exit 2024-01-15 05:13:43 +01:00
Alexey Milovidov
30c3629090 An option to dump coverage to a file at exit 2024-01-15 00:36:44 +01:00
kssenii
341a9b3b70 Fix keeper build 2024-01-13 12:56:27 +01:00
Alexey Milovidov
d112492c56 Remove some code 2024-01-13 03:48:04 +01:00
kssenii
f4546a5eee Fix build 2024-01-12 10:53:40 +01:00
Antonio Andelic
654fee820e
Merge pull request #58665 from ClickHouse/jemalloc-system-commands
Add SYSTEM commands and Keeper 4LW for jemalloc
2024-01-12 10:08:13 +01:00
Antonio Andelic
2bfed6b8eb Add system commands and 4lw for jemalloc 2024-01-11 08:24:56 +00:00
Yakov Olkhovskiy
4fc11e189c
Merge branch 'master' into revert-58450-revert-56064-feature-server-iface-metrics 2024-01-10 12:03:47 -05:00
Yakov Olkhovskiy
2e124b19b8
Merge branch 'master' into revert-58450-revert-56064-feature-server-iface-metrics 2024-01-10 09:05:18 -05:00
Robert Schulze
499227b9cf
Merge remote-tracking branch 'rschu1ze/master' into replace-std_regexp-by-re2 2024-01-10 10:02:53 +00:00
vdimir
b4bfd01322
Merge pull request #58246 from ClickHouse/vdimir/util_format_values
clickhouse-format improvements: support VALUES, comments, max_line_length
2024-01-09 11:24:42 +01:00
Bharat Nallan
ee37f551a2
independent registration of interpreters (#58443)
* make interpreter factory an instance

* add registerInterpreter

* register interpreters individually

* try wire everything up

* fix style

* fix test
2024-01-08 22:33:48 -08:00
Alexey Milovidov
d3e73ff6e6
Merge pull request #58584 from ClickHouse/enable-all-access-control-improvements
Enable all access control improvements by default
2024-01-08 23:05:47 +01:00
Azat Khuzhin
c5bf722ee2 Create ch/chc/chl symlinks by cmake as well (for develop mode)
Before, they had been created only by install target.

Follow-up for: #56634

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-08 21:27:53 +03:00
vdimir
e68fc2df7a
Remove spaces after insert in clickhouse-format 2024-01-08 12:16:53 +00:00
vdimir
cccc24c2fd
upd 2024-01-08 12:01:34 +00:00
vdimir
621d17b16f
Better clickhouse-format: support VALUES, comments 2024-01-08 12:01:33 +00:00
Alexey Milovidov
eb8217efb0 Fix wrong message in Keeper 2024-01-08 01:22:11 +01:00
Robert Schulze
f553b55e3a
Merge remote-tracking branch 'rschu1ze/master' into regex-std-re2 2024-01-07 22:31:35 +00:00
Robert Schulze
8e804487f3
Some fixups 2024-01-07 22:28:08 +00:00
Alexey Milovidov
6bc27dfcf5 Enable all access control improvements by default 2024-01-07 20:56:16 +01:00
Yakov Olkhovskiy
feab812712 read body of HTTP POST request to prevent 'connection reset by peer' error on client side 2024-01-07 14:40:12 +00:00
Yakov Olkhovskiy
9ca4be5d91 Merge remote-tracking branch 'origin/master' into revert-58450-revert-56064-feature-server-iface-metrics 2024-01-06 00:24:31 +00:00
Michael Kolupaev
52058211e7
Fix some thread pool settings not updating at runtime (#58485) 2024-01-04 17:21:46 +01:00
Alexander Tokmakov
10e3ae9e68 Merge branch 'master' into allow-not-resolving-hostnames 2024-01-04 13:22:15 +01:00
Alexey Milovidov
be9b857d1f Merge branch 'master' into async-load-by-default 2024-01-04 00:53:20 +01:00
Yakov Olkhovskiy
85f03478ef
Revert "Revert "Use CH Buffer for HTTP out stream, add metrics for interfaces"" 2024-01-03 11:47:15 -05:00
Raúl Marín
d491758939
Revert "Use CH Buffer for HTTP out stream, add metrics for interfaces" 2024-01-03 10:42:15 +01:00
Yakov Olkhovskiy
5633fb8145
Merge pull request #56064 from ClickHouse/feature-server-iface-metrics
Use CH Buffer for HTTP out stream, add metrics for interfaces
2024-01-02 10:17:52 -05:00
Kruglov Pavel
474d7abfda
Merge pull request #57774 from Avogar/local-default-database-name
Change default database name in clickhouse-local to 'default'
2024-01-02 15:29:45 +01:00
Yakov Olkhovskiy
db97764e98 fix tests, some refactoring 2023-12-31 12:56:37 +00:00
Alexey Milovidov
7bded0a5e7
Merge pull request #58316 from ClickHouse/reintroduce_is_deleted
Re-introduce `is_deleted` column for ReplacingMergeTree
2023-12-31 00:57:19 +01:00
Alexey Milovidov
b752a1c62e
Merge pull request #58365 from bharatnc/ncb/refactor-db-factory
independent registration of database engines
2023-12-31 00:56:24 +01:00
Alexey Milovidov
68cc3eaa96 Merge branch 'master' of github.com:ClickHouse/ClickHouse into feature-server-iface-metrics 2023-12-30 18:38:45 +01:00
Bharat Nallan Chakravarthy
6c4a4991e2 few more fixes 2023-12-30 09:26:53 -08:00
Alexey Milovidov
063463b0a8
Merge pull request #58359 from ClickHouse/all-system-tables-local
Attach all system tables in `clickhouse-local`
2023-12-30 17:51:27 +01:00
Alexey Milovidov
aad63c8273 Merge branch 'master' into feature-server-iface-metrics 2023-12-30 15:44:42 +01:00
Bharat Nallan Chakravarthy
906745feaa validation and left over fixes 2023-12-29 20:06:07 -08:00
Bharat Nallan Chakravarthy
ab28da85d3 try wire everything up 2023-12-29 16:38:17 -08:00
Alexey Milovidov
aa462fa7cd
Merge branch 'master' into feature-server-iface-metrics 2023-12-29 22:37:52 +01:00
Alexey Milovidov
39b239683c Attach all system tables in clickhouse-local 2023-12-29 21:25:22 +01:00
Azat Khuzhin
d899384ea1 Interpret binary without name as clickhouse-local
By "without name" I mean either of this:
- without arguments (except for the argv[0])
- or with arguments starts with dash

This should improve usability, and better ad of the clickhouse-local.

v2: clarify with comment
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-29 13:23:19 +01:00
Azat Khuzhin
9e6cfaf7d1 Interpret ch as clickhouse (instead of clickhouse-local)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-29 12:38:52 +01:00
Azat Khuzhin
9c8b5edc33 Add bash completion for ch/chl/chc
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-29 12:38:52 +01:00
Alexander Tokmakov
bdada351c8 Revert "Merge pull request #58274 from ClickHouse/revert-58267"
This reverts commit 583b9637c2, reversing
changes made to 224e937620.
2023-12-28 14:07:59 +01:00
Alexey Milovidov
c7efd2afea Revert #58267 2023-12-28 04:09:33 +01:00
Alexey Milovidov
dcbd3b9c26
Merge pull request #58267 from ClickHouse/fix_is_deleted_compatibility
Re-introduce `is_deleted` column for ReplacingMergeTree
2023-12-28 00:13:01 +01:00
Raúl Marín
e1b353d19e Merge remote-tracking branch 'blessed/master' into local-default-database-name 2023-12-27 15:27:42 +01:00
Alexander Tokmakov
01d042c490 Revert "Merge pull request #57932 from ClickHouse/remove-shit-cleanup"
This reverts commit 2d58dc512c, reversing
changes made to 41873dc4a3.
2023-12-27 13:46:06 +01:00
Alexey Milovidov
5f6318e51b
Merge pull request #58151 from ClickHouse/fix-legend
Fix dashboard legend sorting and rows number
2023-12-27 13:33:00 +01:00
Alexey Milovidov
005023a16d
Merge pull request #58210 from chhetripradeep/pchhetri/param-query-clickhouse-local
Add support for specifying query parameters in the command line in clickhouse-local
2023-12-25 13:34:04 +01:00
Alexey Milovidov
0e89d01b94 Binary (symbols) viewer 2023-12-24 12:14:45 +01:00
Pradeep Chhetri
5899ee99bd Add support for specifying query parameters in the command line in clickhouse-local 2023-12-24 18:07:26 +08:00
Alexey Milovidov
6bb181ce55 Looking at strange code 2023-12-23 13:06:34 +01:00
Alexey Milovidov
dc4b9a1013 Obfuscator: keep settings and timezones 2023-12-23 04:55:55 +01:00
serxa
8693e1535a Fix dashboard legend sorting and rows number 2023-12-22 14:39:44 +00:00
Yakov Olkhovskiy
5dc88542cb
Merge branch 'master' into feature-server-iface-metrics 2023-12-20 16:46:29 -05:00
Raúl Marín
b840022d5a Merge remote-tracking branch 'blessed/master' into local-default-database-name 2023-12-19 13:28:31 +01:00
Nikita Mikhaylov
6360b76792 Merge branch 'master' of github.com:ClickHouse/ClickHouse into remove-the-limit-for-connections-per-endpoint 2023-12-18 21:49:31 +00:00
pufit
36d1905881
Merge pull request #57752 from chizhonkova/refactor_sql_udf_loader
Refactoring for UserDefinedSQLObjectsLoader
2023-12-18 16:08:46 -05:00
Yakov Olkhovskiy
f99b36143f Merge remote-tracking branch 'origin/master' into feature-server-iface-metrics 2023-12-18 14:14:03 +00:00
Raúl Marín
2639d0715f Merge remote-tracking branch 'blessed/master' into log_message_string 2023-12-18 10:40:18 +01:00
Alexey Milovidov
61e5db9cd0 Merge branch 'master' into dashboard-small-fix 2023-12-17 02:45:48 +01:00
Alexey Milovidov
ac44557e3a A small fix for dashboard 2023-12-17 02:43:50 +01:00
serxa
fc0f30352e better error messages 2023-12-16 14:02:20 +00:00
serxa
4bc93792db Fix /dashboard work with passwords 2023-12-16 13:49:14 +00:00
Alexey Milovidov
2ce4f543d6 Update tests 2023-12-15 23:36:01 +01:00
Yakov Olkhovskiy
001a38048f use ProfileEvents instead of CurrentMetrics 2023-12-15 19:17:42 +00:00
Alexey Milovidov
7e55eab1c3 Revert "Merge pull request #56573 from mkmkme/mkmkme/reload-config"
This reverts commit 3067ca64df, reversing
changes made to 1e46460910.
2023-12-15 19:28:25 +01:00
Raúl Marín
b269f87f4c Better text_log with ErrnoException 2023-12-15 19:27:56 +01:00
Sema Checherinda
0dfe530a7f
Merge pull request #56744 from MikhailBurdukov/native_copy_for_s3_disks
Enabled s3 `copyObject` for copy between s3 disks.
2023-12-15 16:05:16 +01:00
Kseniia Sumarokova
06438cc17b
Merge pull request #57578 from ClickHouse/allow-to-change-some-cache-settings-without-restart
Allow to apply some fs cache config settings changes without server restart
2023-12-15 11:18:19 +01:00
Yakov Olkhovskiy
febdd542f8 Merge remote-tracking branch 'origin/master' into feature-server-iface-metrics 2023-12-14 18:59:44 +00:00
Azat Khuzhin
0e86e16a01
Revert "Replace --no-system-tables with loading virtual tables of system database lazily" 2023-12-14 09:07:47 +01:00
Kseniia Sumarokova
79db3c66df
Merge branch 'master' into allow-to-change-some-cache-settings-without-restart 2023-12-13 23:33:59 +01:00
Nikita Mikhaylov
8372c70958 Merge branch 'master' of github.com:ClickHouse/ClickHouse into remove-the-limit-for-connections-per-endpoint 2023-12-13 18:29:56 +00:00
Alexey Milovidov
54698cd2de
Merge pull request #55876 from ClickHouse/keeper-http-readiness-endpoint
Keeper HTTP readiness endpoint
2023-12-13 17:07:57 +01:00
Alexander Tokmakov
3482224f83 Merge branch 'master' into keeper-http-readiness-endpoint 2023-12-12 21:19:57 +01:00
Han Fei
a96593c8b1 Merge branch 'master' into feature/more_warnings 2023-12-12 15:25:01 +01:00
Natalya Chizhonkova
3d51192bad Refactoring for UserDefinedSQLObjectsLoader 2023-12-12 17:03:49 +03:00
avogar
6088536f3c Remove outdated comment 2023-12-12 13:31:12 +00:00
avogar
6405bb4086 Change default database name in clickhouse-local to 'default' 2023-12-12 13:30:26 +00:00
alesapin
cbae29d26a
Merge pull request #57699 from hanfei1991/hanfei/keeper_soft_limit_ratio
support keeper memory soft limit ratio
2023-12-11 21:43:24 +01:00
Konstantin Bogdanov
771d5c58ea
Fix Keeper standalone build 2023-12-11 10:19:49 +01:00
Konstantin Bogdanov
89ba4a8452
Add HTTP readiness endpoint 2023-12-11 10:19:42 +01:00
MikhailBurdukov
119e451967 Merge branch 'master' into native_copy_for_s3_disks 2023-12-11 07:25:20 +00:00
Alexey Milovidov
e443567c0e
Merge pull request #52717 from azat/wait-threadpool
[RFC] Correctly wait background threads
2023-12-11 01:06:23 +01:00
Azat Khuzhin
8f5a60eb5a More descriptive comment for destroying context prio global thread pool
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-10 15:39:43 +01:00
Azat Khuzhin
fcdead023c Proper server termination in case of intermediate failures during initialization
For instance on CI it fails because KeeperDispatch::initialize() failed,
but there is already proper KeeperDispatch::shutdown() in dtor, the
problem is that you first need to shutdown global context, that will
terminate all thread pools, and only after you can join global thread
pool.

CI: https://s3.amazonaws.com/clickhouse-test-reports/52717/6ccbc2ea75c39234dff748cfb147bd44d65d3e75/integration_tests__asan__[3_4].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-10 08:01:40 +01:00
Azat Khuzhin
4f9d90761b Attach tables lazily only for clickhouse-local
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-09 23:08:29 +01:00
Azat Khuzhin
cc9afe6f6e Replace --no-system-tables with loading virtual tables of system database lazily
First of all the problem is that that simple 'SELECT 1' cannot be runned
without system.one, which makes --no-system-tables almost useless:

    $ ./clickhouse-debug local --no-system-tables -q "select 1"
    Code: 81. DB::Exception: Database system does not exist. (UNKNOWN_DATABASE)

Secondly there are just too much flags, and this one
(--no-system-tables) is too damn specific.

This patch should improve startup time of the clickhouse-local almost
3x in debug builds.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-09 23:08:29 +01:00
Azat Khuzhin
b7edde3621 Shutdown embedded keeper even if it was not started successfully
Since even when it does not, there are still few threads left that
should be joined (request, response, snapshot, snapshot s3):

There are some problems with keeper and invalid config, that got stuck in:

    libc.so.6`___lldb_unnamed_symbol3457 + 231
    libc.so.6`pthread_cond_timedwait + 571
    clickhouse`std::__1::__libcpp_condvar_timedwait[abi:v15000](__cv=0x00007f475c41a708, __m=0x00007f475c41a6b0, __ts=0x00007f45a99f1440) at __threading_support:341:10
    clickhouse`std::__1::condition_variable::__do_timed_wait(this=0x00007f475c41a708, lk=0x00007f45a99f1738, tp=time_point<std::__1::chrono::system_clock, std::__1::chrono::duration<long long, std::__1::ratio<1L, 1000000000L> > > @ 0x00007f45a99f1488) at condition_variable.cpp:76:14
    clickhouse`std::__1::cv_status std::__1::condition_variable::wait_for<long long, std::__1::ratio<1l, 1000000000l> >(this=0x00007f475c41a708, __lk=0x00007f45a99f1738, __d=0x00007f45a99f1590) at __mutex_base:457:9
    clickhouse`void std::__1::condition_variable::__do_timed_wait<std::__1::chrono::steady_clock>(this=0x00007f475c41a708, __lk=0x00007f45a99f1738, __tp=time_point<std::__1::chrono::steady_clock, std::__1::chrono::duration<long long, std::__1::ratio<1L, 1000000000L> > > @ 0x00007f45a99f15a8) at __mutex_base:512:5
    clickhouse`std::__1::cv_status std::__1::condition_variable::wait_until<std::__1::chrono::steady_clock, std::__1::chrono::duration<long long, std::__1::ratio<1l, 1000000000l> > >(this=0x00007f475c41a708, __lk=0x00007f45a99f1738, __t=0x00007f45a99f1698) at __mutex_base:415:5
    clickhouse`bool std::__1::condition_variable::wait_until<std::__1::chrono::steady_clock, std::__1::chrono::duration<long long, std::__1::ratio<1l, 1000000000l> >, bool ConcurrentBoundedQueue<DB::KeeperStorage::RequestForSession>::popImpl<true>(DB::KeeperStorage::RequestForSession&, std::__1::optional<unsigned long>)::'lambda'()>(this=0x00007f475c41a708, __lk=0x00007f45a99f1738, __t=0x00007f45a99f1698, __pred=(unnamed class) @ 0x00007f45a99f1650)::'lambda'()) at __mutex_base:427:13
    clickhouse`bool std::__1::condition_variable::wait_for[abi:v15000]<long long, std::__1::ratio<1l, 1000l>, bool ConcurrentBoundedQueue<DB::KeeperStorage::RequestForSession>::popImpl<true>(DB::KeeperStorage::RequestForSession&, std::__1::optional<unsigned long>)::'lambda'()>(this=0x00007f475c41a708, __lk=0x00007f45a99f1738, __d=0x00007f45a99f1720, __pred=(unnamed class) @ 0x00007f45a99f16b8)::'lambda'()) at __mutex_base:471:12
    clickhouse`bool ConcurrentBoundedQueue<DB::KeeperStorage::RequestForSession>::popImpl<true>(this=0x00007f475c41a680, x=0x00007f45a99f1ba0, timeout_milliseconds= Has Value=true ) at ConcurrentBoundedQueue.h:75:50
    clickhouse`ConcurrentBoundedQueue<DB::KeeperStorage::RequestForSession>::tryPop(this=0x00007f475c41a680, x=0x00007f45a99f1ba0, milliseconds=5000) at ConcurrentBoundedQueue.h:161:16
    clickhouse`DB::KeeperDispatcher::requestThread(this=0x00007f475c8fac18) at KeeperDispatcher.cpp:88:33
    clickhouse`DB::KeeperDispatcher::initialize(this=0x00007f45a99f2020)::$_0::operator()() const at KeeperDispatcher.cpp:349:52
    clickhouse`decltype(__f=0x00007f45a99f2020)::$_0&>()()) std::__1::__invoke[abi:v15000]<DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&) at invoke.h:394:23
    clickhouse`decltype(__f=0x00007f45a99f2020, __t=size=0, (null)=__tuple_indices<> @ 0x00007f45a99f1d28) std::__1::__apply_tuple_impl[abi:v15000]<DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&, std::__1::tuple<>&>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&, std::__1::tuple<>&, std::__1::__tuple_indices<>) at tuple:1789:1
    clickhouse`decltype(__f=0x00007f45a99f2020, __t=size=0) std::__1::apply[abi:v15000]<DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&, std::__1::tuple<>&>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&, std::__1::tuple<>&) at tuple:1798:1
    clickhouse`ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::KeeperDispatcher::initialize(this=0x00007f475c9703c0)::$_0>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&&)::'lambda'()::operator()() at ThreadPool.h:245:13
    clickhouse`decltype(__f=0x00007f475c9703c0)::$_0>()()) std::__1::__invoke[abi:v15000]<ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&&)::'lambda'()&>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&&) at invoke.h:394:23
    clickhouse`void std::__1::__invoke_void_return_wrapper<void, true>::__call<ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::KeeperDispatcher::initialize(__args=0x00007f475c9703c0)::$_0>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&&)::'lambda'()&>(ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&&)::'lambda'()&) at invoke.h:479:9
    clickhouse`std::__1::__function::__default_alloc_func<ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&&)::'lambda'(), void ()>::operator(this=0x00007f475c9703c0)[abi:v15000]() at function.h:235:12
    clickhouse`void std::__1::__function::__policy_invoker<void ()>::__call_impl<std::__1::__function::__default_alloc_func<ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::KeeperDispatcher::initialize(__buf=0x00007f45a99f22d8)::$_0>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&&)::'lambda'(), void ()> >(std::__1::__function::__policy_storage const*) at function.h:716:16
    clickhouse`std::__1::__function::__policy_func<void ()>::operator(this=0x00007f45a99f22d8)[abi:v15000]() const at function.h:848:16
    clickhouse`std::__1::function<void ()>::operator(this=0x00007f45a99f22d8)() const at function.h:1187:12
    clickhouse`ThreadPoolImpl<std::__1::thread>::worker(this=0x00007f475c8229c0, thread_it=std::__1::list<std::__1::thread, std::__1::allocator<std::__1::thread> >::iterator @ 0x00007f45a99f23a8) at ThreadPool.cpp:427:13
    clickhouse`void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(this=0x00007f45cea0c8a8)>, Priority, std::__1::optional<unsigned long>, bool)::'lambda0'()::operator()() const at ThreadPool.cpp:180:73
    clickhouse`decltype(__f=0x00007f45cea0c8a8)()) std::__1::__invoke[abi:v15000]<void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, Priority, std::__1::optional<unsigned long>, bool)::'lambda0'()>(void&&) at invoke.h:394:23
    clickhouse`void std::__1::__thread_execute[abi:v15000]<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, Priority, std::__1::optional<unsigned long>, bool)::'lambda0'()>(__t=size=2, (null)=__tuple_indices<> @ 0x00007f45a99f2408)>, Priority, std::__1::optional<unsigned long>, bool)::'lambda0'()>&, std::__1::__tuple_indices<>) at thread:284:5
    clickhouse`void* std::__1::__thread_proxy[abi:v15000]<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, Priority, std::__1::optional<unsigned long>, bool)::'lambda0'()> >(__vp=0x00007f45cea0c8a0) at thread:295:5
    libc.so.6`___lldb_unnamed_symbol3481 + 755
    libc.so.6`___lldb_unnamed_symbol3865 + 11

This should fix the problem with
test_keeper_incorrect_config/test.py::test_invalid_configs test.

CI: https://s3.amazonaws.com/clickhouse-test-reports/52717/72b1052f7c2d453308262924e767ab8dc2206933/integration_tests__asan__[1_6].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-09 17:54:16 +01:00
Azat Khuzhin
55d5a3affa Correctly wait background threads
There are some places that make it possible to trigger use-after-free
from threads because some global variable had been destroyed before, for
example some logger.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-09 17:54:16 +01:00
Han Fei
881e58dfcb support soft limit ratio 2023-12-08 21:48:27 +01:00
Alexey Milovidov
ee1b304284 Asynchronous load of tables by default 2023-12-08 20:56:10 +01:00
Nikita Mikhaylov
c979124cfe Merge branch 'master' of github.com:ClickHouse/ClickHouse into remove-the-limit-for-connections-per-endpoint 2023-12-08 16:25:02 +00:00
kssenii
199015576c Add a file which I forgot to commit 2023-12-07 18:30:43 +01:00
Nikolay Degterinsky
995b51ef73 Allow avoiding resolving hostnames in DDLWorker 2023-12-07 03:43:26 +00:00
Alexey Milovidov
0b597eadf8 Clarify the usage of prefer_not_to_merge option 2023-12-06 12:11:03 +01:00
jsc0218
cdd5280272
Merge pull request #57387 from evillique/better-disks
Initialize only required disks in clickhouse-disks
2023-12-05 13:59:04 -05:00
Nikita Mikhaylov
04d167c6d9 Better 2023-12-05 13:34:37 +01:00
Alexey Milovidov
cbea3545aa
Revert "add function getClientHTTPHeader" 2023-12-05 13:34:34 +03:00
凌涛
9e05e79d66
Merge branch 'master' into feature/more_warnings 2023-12-05 11:50:05 +08:00
凌涛
6794bbe196 rebase master 2023-12-05 11:42:25 +08:00
Sergei Trifonov
c073d03a20
Merge pull request #57236 from ClickHouse/multiline-charts
Support multiple lines on dashboard charts
2023-12-04 17:35:31 +01:00
serxa
1c650f380a remove debug print 2023-12-04 16:26:39 +00:00
Alexey Milovidov
02439eee58
Merge pull request #49351 from ClickHouse/async-loader-integration
Asynchronous loading of tables
2023-12-04 17:16:12 +01:00
Nikolay Degterinsky
93995f6c06 Fix test 2023-12-02 23:59:46 +00:00
Nikita Taranov
a32c5e976a
Don't print server revision in client on connect (#57435) 2023-12-02 16:32:34 +01:00
Yakov Olkhovskiy
416d28687e Merge remote-tracking branch 'origin/master' into feature-server-iface-metrics 2023-11-30 23:00:04 +00:00
Nikolay Degterinsky
e8203f8a76 Initialize only required disks 2023-11-30 03:09:55 +00:00
凌涛
d9f4b4d2c0 support parts, tables, databases 2023-11-30 10:56:31 +08:00
Antonio Andelic
93360e4e2c
Merge pull request #57299 from ClickHouse/keeper-changelog-snapshot-fix
Keeper fix for changelog and snapshots
2023-11-29 08:31:48 +01:00
János Benjamin Antal
4c2451f837
Merge pull request #56741 from ClickHouse/well-known-protos 2023-11-28 15:21:15 +01:00
Antonio Andelic
a61f32867e
Merge pull request #56488 from lingtaolf/feature/getHTTPHeader
add function getClientHTTPHeader
2023-11-28 11:41:56 +01:00
Antonio Andelic
889c53eca0 Correctly handle unknown changelog versions and snapshot deleting 2023-11-28 09:47:49 +00:00
serxa
0d39de9ee9 indicate that legend is not full by "..." 2023-11-28 01:18:41 +00:00
serxa
4979925095 fix legend + add string-labeled format 2023-11-28 00:36:38 +00:00
Yakov Olkhovskiy
b92030b485
Merge branch 'master' into feature-server-iface-metrics 2023-11-27 15:44:25 -05:00
János Benjamin Antal
adf21e37c4 Make tests use the installed protobuf files 2023-11-27 13:39:28 +00:00
János Benjamin Antal
4bfbbfbd75 Fix proto file installation 2023-11-27 13:39:01 +00:00
MikhailBurdukov
6f19e8ebd1
Merge branch 'master' into native_copy_for_s3_disks 2023-11-27 14:25:36 +03:00
serxa
62831d235f support multiple lines on dashboard charts 2023-11-26 23:28:11 +00:00
Vitaly Baranov
5769a88b92
Merge pull request #57133 from vitlibar/change-default-for-wait_dictionaries_load_at_startup
Change the default for wait_dictionaries_load_at_startup to true
2023-11-24 17:09:05 +01:00
alesapin
a3c2896e9d
Merge pull request #56846 from aalexfvk/add_cancellation_point_for_moving_background_operation
Add cancellation hook for moving background operation
2023-11-24 12:12:47 +01:00
Kseniia Sumarokova
650c1e959d
Merge pull request #57141 from ClickHouse/remove-test-case
Follow up to #56541
2023-11-24 11:45:29 +01:00
Alexey Milovidov
98cddf5312
Merge pull request #57153 from ClickHouse/better-server-exit-code
Better server exit code
2023-11-23 23:55:28 +01:00
Igor Nikonov
0434044a7e
Merge pull request #57054 from ClickHouse/pr-cleanup-narrow-dependency
Parallel replicas: cleanup, narrow dependency
2023-11-23 20:12:37 +01:00
Sergei Trifonov
9436ae6d7d
Merge pull request #56771 from ClickHouse/dashboards-table
Load queries for dashboard page from new `system.dashboards` table
2023-11-23 19:07:52 +01:00