6 Commits

Author	SHA1	Message	Date
Robert Schulze	777b5bc15b	Don't let storages inherit from boost::noncopyable ... ... IStorage has deleted copy ctor / assignment already	2022-05-03 09:07:08 +02:00
Robert Schulze	330212e0f4	Remove inherited create() method + disallow copying ... The original motivation for this commit was that shared_ptr_helper used std::shared_ptr<>() which does two heap allocations instead of make_shared<>() which does a single allocation. Turned out that 1. the affected code (--> Storages/) is not on a hot path (rendering the performance argument moot ...) 2. yet copying Storage objects is potentially dangerous and was previously allowed. Hence, this change - removes shared_ptr_helper and as a result all inherited create() methods, - instead, Storage objects are now created using make_shared<>() by the caller (for that to work, many constructors had to be made public), and - all Storage classes were marked as noncopyable using boost::noncopyable. In sum, we are (likely) not making things faster but the code becomes cleaner and harder to misuse.	2022-05-02 08:46:52 +02:00
Alexey Milovidov	fe6b7c77c7	Rename "common" to "base"	2021-10-02 10:13:14 +03:00
Maksim Kita	67e9b85951	Merge ext into common	2021-06-16 23:28:41 +03:00
Nicolae Vartolomei	1fa5871ff7	Fix bad rebase and introduce part_moves_between_shards_enable setting	2021-04-27 14:20:13 +01:00
Nicolae Vartolomei	53d57ffb52	Part movement between shards ... Integrate query deduplication from #17348	2021-04-27 14:20:12 +01:00