Azat Khuzhin
211cea5e7c
Fix uncaught exception in case of parallel loader for hashed dictionaries
...
Since ThreadPool::wait() rethrows the first exception (if any):
<details>
<summary>stacktrace</summary>
2023.04.09 12:53:33.629333 [ 22361 ] {} <Fatal> BaseDaemon: (version 22.13.1.1, build id: 5FB01DCAAFFF19F0A9A61E253567F90685989D2F) (from thread 23032) Terminate called for uncaught exception:
2023.04.09 12:53:33.630179 [ 23645 ] {} <Fatal> BaseDaemon:
2023.04.09 12:53:33.630213 [ 23645 ] {} <Fatal> BaseDaemon: Stack trace: 0x7f68b00baccc 0x7f68b006bef2 0x7f68b0056472 0x112a42fe 0x1c17f2a3 0x1c17f238 0xbf4bc3b 0x13961c6d 0x138ee529 0x138ed6bc 0x138dd2f0 0x138dd9c6 0x1571d0dd 0x16197c1f 0x161a231e 0x1619fc93 0x161a51b9 0x11151759 0x1115454e 0x7f68b00b8fd4 0x7f68b013966c
2023.04.09 12:53:33.630247 [ 23645 ] {} <Fatal> BaseDaemon: 3. ? @ 0x7f68b00baccc in ?
2023.04.09 12:53:33.630263 [ 23645 ] {} <Fatal> BaseDaemon: 4. gsignal @ 0x7f68b006bef2 in ?
2023.04.09 12:53:33.630273 [ 23645 ] {} <Fatal> BaseDaemon: 5. abort @ 0x7f68b0056472 in ?
2023.04.09 12:53:33.648815 [ 23645 ] {} <Fatal> BaseDaemon: 6. ./.build/./src/Daemon/BaseDaemon.cpp:456: terminate_handler() @ 0x112a42fe in /usr/lib/debug/usr/bin/clickhouse.debug
2023.04.09 12:53:33.651484 [ 23645 ] {} <Fatal> BaseDaemon: 7. ./.build/./contrib/llvm-project/libcxxabi/src/cxa_handlers.cpp:61: std::__terminate(void (*)()) @ 0x1c17f2a3 in /usr/lib/debug/usr/bin/clickhouse.debug
2023.04.09 12:53:33.654080 [ 23645 ] {} <Fatal> BaseDaemon: 8. ./.build/./contrib/llvm-project/libcxxabi/src/cxa_handlers.cpp:79: std::terminate() @ 0x1c17f238 in /usr/lib/debug/usr/bin/clickhouse.debug
2023.04.09 12:53:35.025565 [ 23645 ] {} <Fatal> BaseDaemon: 9. ? @ 0xbf4bc3b in /usr/lib/debug/usr/bin/clickhouse.debug
2023.04.09 12:53:36.495557 [ 23645 ] {} <Fatal> BaseDaemon: 10. DB::ParallelDictionaryLoader<(DB::DictionaryKeyType)0, true, true>::~ParallelDictionaryLoader() @ 0x13961c6d in /usr/lib/debug/usr/bin/clickhouse.debug
2023.04.09 12:53:37.833142 [ 23645 ] {} <Fatal> BaseDaemon: 11. DB::HashedDictionary<(DB::DictionaryKeyType)0, true, true>::loadData() @ 0x138ee529 in /usr/lib/debug/usr/bin/clickhouse.debug
2023.04.09 12:53:39.124989 [ 23645 ] {} <Fatal> BaseDaemon: 12. DB::HashedDictionary<(DB::DictionaryKeyType)0, true, true>::HashedDictionary(DB::StorageID const&, DB::DictionaryStructure const&, std::__1::shared_ptr<DB::IDictionarySource>, DB::HashedDictionaryStorageConfiguration const&, std::__1::shared_ptr<DB::Block>) @ 0x138ed6bc in /usr/lib/debug/usr/bin/clickhouse.debug
</details>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-09 22:52:51 +02:00
Igor Nikonov
6fe6e1fea5
Adopt tests to run in parallel or mark as no-parallel (for flaky check)
2023-04-09 19:55:45 +00:00
Alexey Milovidov
94b9a9d7a6
Merge pull request #48566 from ClickHouse/alexey-milovidov-patch-6
...
Update 02207_allow_plaintext_and_no_password.sh
2023-04-09 22:27:47 +03:00
Alexey Milovidov
eda4a021a6
Merge branch 'master' into server-uuid-macro
2023-04-09 22:26:58 +03:00
Alexey Milovidov
44e418987c
Update tests/queries/0_stateless/02711_server_uuid_macro.sql
...
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
2023-04-09 22:26:49 +03:00
serxa
e0ac396057
Merge branch 'lost-part-count' of github.com:ClickHouse/ClickHouse into lost-part-count
2023-04-09 15:13:58 +00:00
serxa
553326c999
add test
2023-04-09 15:13:40 +00:00
caipengxiang
286424be05
bugfix: compare Bits and sizeof(Arithmetic) * 8
2023-04-09 22:59:17 +08:00
Sergei Trifonov
3bc5c6423b
Update formats.md
2023-04-09 16:54:21 +02:00
Alexey Milovidov
c3c07c05ea
Update 02207_allow_plaintext_and_no_password.sh
2023-04-09 09:36:20 +03:00
Alexey Milovidov
d23cd018ec
Update test
2023-04-09 07:46:27 +02:00
Alexey Milovidov
90ebdedfdd
Merge pull request #48562 from ClickHouse/serxa-patch-3
...
Remove misleading comment and block
2023-04-09 08:40:00 +03:00
Alexey Milovidov
6292a08c9c
Add a test
2023-04-09 03:25:38 +02:00
Alexey Milovidov
09ea79aaf7
Add support for {server_uuid} macro
2023-04-09 03:04:26 +02:00
Igor Nikonov
d80364ffa0
Fix tests: truncate output file on insert
2023-04-08 22:51:12 +00:00
Sergei Trifonov
b319271d59
Remove misleading comment
...
It is no longer "significant" after `NOEXCEPT_SCOPE` macro rework #39229
2023-04-08 22:50:24 +02:00
Igor Nikonov
bcb913e7b3
A try to prevent possible tests flakyness due to file() parallelization
2023-04-08 20:16:36 +00:00
robot-clickhouse-ci-1
3302f1ff90
Merge pull request #48299 from CurtizJ/do-not-build-unnecessary-sets
...
Do not build sets for skip indexes if they are not used
2023-04-08 21:25:06 +02:00
Alexey Milovidov
5495cb2935
Merge pull request #48521 from ClibMouse/feature/tiny-improvement
...
Use std::string::starts_with instead of a roll your own variant
2023-04-08 22:19:48 +03:00
Alexey Milovidov
16fe18a7b6
Merge pull request #48520 from ClibMouse/feature/use-string-view-instead-of-strlen
...
Use std::string_view instead of strlen
2023-04-08 22:19:28 +03:00
Alexey Milovidov
c77acace86
Merge pull request #48528 from ClickHouse/bracketed
...
Fix bracketed-paste mode messing up password input in client reconnect
2023-04-08 22:16:02 +03:00
Igor Nikonov
0fbb05bf55
Fix 02286_mysql_dump_input_format
2023-04-08 19:15:18 +00:00
Alexey Milovidov
83dd5e0294
Merge pull request #48552 from ClickHouse/better-exception-message-zstd
...
Better exception message for ZSTD
2023-04-08 22:15:14 +03:00
Igor Nikonov
32ac23803f
Fix test which can become flaky due to file() parallelization
2023-04-08 19:02:18 +00:00
Igor Nikonov
0dc3193e6b
Fix 02293_formats_json_columns
2023-04-08 17:29:08 +00:00
Alexey Milovidov
c2f9a072c1
Merge pull request #48559 from artem-pershin/fix_typo_in_comment_storage_lock_for_alter
...
Fix typo in word acquired, in comment for lockForAlter method
2023-04-08 19:58:12 +03:00
Artem Pershin
2b00c8cb9b
Fix typo in word acquired, in comment for lockForAlter method
2023-04-08 18:39:04 +03:00
Alexander Tokmakov
bf20e6bfc6
Merge pull request #48550 from ClickHouse/fix_sync_replica
...
Fix some tests
2023-04-08 14:41:10 +03:00
Alexey Milovidov
ec60a10694
Better exception message for ZSTD
2023-04-08 00:54:05 +02:00
Vitaly Baranov
62e9c419de
Merge pull request #48519 from azat/build/fwd-decl-threadpool
...
Use forward declaration of ThreadPool
2023-04-08 00:44:01 +02:00
Azat Khuzhin
bf3a08dc98
Fix 02477_projection_materialize_and_zero_copy flakienss (due to index granularity randomization)
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-07 22:59:14 +02:00
Alexander Tokmakov
e39ee3f0af
suppress a bug in filesystem cache
2023-04-07 22:54:49 +02:00
Nikolay Degterinsky
41891839a0
Merge pull request #48185 from evillique/add-kafka-murmur-hash-function
...
Add kafkaMurmurHash function
2023-04-07 22:06:56 +02:00
Igor Nikonov
8fdc2b3326
Perf test
2023-04-07 20:06:11 +00:00
Alexander Tokmakov
9929185eab
fix REPLACE_RANGE
2023-04-07 20:31:03 +02:00
Michael Kolupaev
6609004ca6
Merge branch 'master' into bracketed
2023-04-07 11:22:56 -07:00
Alexander Tokmakov
18a2eb355e
fix a bug in sync replica
2023-04-07 20:16:25 +02:00
Michael Kolupaev
b6261104e7
Fix bracketed-paste mode messing up password input in client reconnect
2023-04-07 18:10:33 +00:00
Antonio Andelic
2fd207955c
Merge pull request #48532 from ClickHouse/fix-topk-ubsan
...
Avoid sending `nullptr` to `memcpy` in `copyStringInArena`
2023-04-07 20:06:21 +02:00
Antonio Andelic
55a999d6a3
Merge branch 'master' into fix-topk-ubsan
2023-04-07 20:05:36 +02:00
Antonio Andelic
6a23c7028a
Merge pull request #48533 from ClickHouse/less-flaky-test-test_alternative_keeper_config
...
Fix flaky `test_alternative_keeper_config`
2023-04-07 20:04:53 +02:00
lzydmxy
d0a37f8798
fix test test_multiple_disks
2023-04-08 01:44:43 +08:00
Alexey Milovidov
e09e80b493
Merge pull request #48500 from CurtizJ/fix-sparse-column-query-cache
...
Fix query cache with sparse columns
2023-04-07 19:34:10 +03:00
Sergei Trifonov
396f6a6421
Update src/Storages/StorageReplicatedMergeTree.cpp
...
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-04-07 17:07:36 +02:00
Azat Khuzhin
44ae8485f1
Use one ThreadGroup while pushing to materialized views
...
Before this patch only the case when ThreadStatus (current_thread)
already has ThreadGroup works that way, after they will be identical in
this aspect.
But this should not affect anything, but it just make sense.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-07 15:37:35 +02:00
Azat Khuzhin
aacf2a0838
Move ThreadGroupSwitcher to ThreadStatus.h (out from MergeTree code)
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-07 15:32:08 +02:00
Azat Khuzhin
5b2b20a0b0
Rename ThreadGroupStatus to ThreadGroup
...
There are methods like getThreadGroup() and ThreadGroupSwitcher class,
so seems that this is logical.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-07 15:31:48 +02:00
Sema Checherinda
0503ed6fb8
Merge pull request #46668 from azat/fix-query_views_log-from-bg
...
Fix system.query_views_log for MVs that are pushed from background threads
2023-04-07 14:47:05 +02:00
Igor Nikonov
78038a3c2c
Fix: do not resize pipeline when there is no files to process (globs expands to empty set)
2023-04-07 11:34:04 +00:00
Igor Nikonov
bea9468285
Fix 01548_parallel_parsing_max_memory.sh
2023-04-07 10:47:52 +00:00