Commit Graph

21 Commits

Author SHA1 Message Date
alesapin
230e1fe6c7
Merge pull request #57809 from ClickHouse/fix-flaky-test_parallel_replicas_over_distributed
Fix flaky test_parallel_replicas_over_distributed
2023-12-13 17:11:41 +01:00
Igor Nikonov
c165be76ab
Parallel replicas: friendly settings (#57542) 2023-12-13 14:42:06 +01:00
robot-clickhouse
7d9e9fd42e Automatic style fix 2023-12-13 11:38:41 +00:00
Igor Nikonov
7762beaf6c Fix: w/o replicas sync query result can vary 2023-12-13 11:23:53 +00:00
Azat Khuzhin
c25d6cd624
Rename directory monitor concept into background INSERT (#55978)
* Limit log frequence for "Skipping send data over distributed table" message

After SYSTEM STOP DISTRIBUTED SENDS it will constantly print this
message.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Rename directory monitor concept into async INSERT

Rename the following query settings (with preserving backward
compatiblity, by keeping old name as an alias):
- distributed_directory_monitor_sleep_time_ms -> distributed_async_insert_sleep_time_ms
- distributed_directory_monitor_max_sleep_time_ms -> distributed_async_insert_max_sleep_time_ms
- distributed_directory_monitor_batch -> distributed_async_insert_batch_inserts
- distributed_directory_monitor_split_batch_on_failure -> distributed_async_insert_split_batch_on_failure

Rename the following table settings (with preserving backward
compatiblity, by keeping old name as an alias):
- monitor_batch_inserts -> async_insert_batch
- monitor_split_batch_on_failure -> async_insert_split_batch_on_failure
- directory_monitor_sleep_time_ms -> async_insert_sleep_time_ms
- directory_monitor_max_sleep_time_ms -> async_insert_max_sleep_time_ms

And also update all the references:

    $ gg -e directory_monitor_ -e monitor_ tests docs | cut -d: -f1 | sort -u | xargs sed -e 's/distributed_directory_monitor_sleep_time_ms/distributed_async_insert_sleep_time_ms/g' -e 's/distributed_directory_monitor_max_sleep_time_ms/distributed_async_insert_max_sleep_time_ms/g' -e 's/distributed_directory_monitor_batch_inserts/distributed_async_insert_batch/g' -e 's/distributed_directory_monitor_split_batch_on_failure/distributed_async_insert_split_batch_on_failure/g' -e 's/monitor_batch_inserts/async_insert_batch/g' -e 's/monitor_split_batch_on_failure/async_insert_split_batch_on_failure/g' -e 's/monitor_sleep_time_ms/async_insert_sleep_time_ms/g' -e 's/monitor_max_sleep_time_ms/async_insert_max_sleep_time_ms/g' -i

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Rename async_insert for Distributed into background_insert

This will avoid amigibuity between general async INSERT's and INSERT
into Distributed, which are indeed background, so new term express it
even better.

Mostly done with:

    $ git di HEAD^ --name-only | xargs sed -i -e 's/distributed_async_insert/distributed_background_insert/g' -e 's/async_insert_batch/background_insert_batch/g' -e 's/async_insert_split_batch_on_failure/background_insert_split_batch_on_failure/g' -e 's/async_insert_sleep_time_ms/background_insert_sleep_time_ms/g' -e 's/async_insert_max_sleep_time_ms/background_insert_max_sleep_time_ms/g'

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Mark 02417_opentelemetry_insert_on_distributed_table as long

CI: https://s3.amazonaws.com/clickhouse-test-reports/55978/7a6abb03a0b507e29e999cb7e04f246a119c6f28/stateless_tests_flaky_check__asan_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

---------

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-11-01 15:09:39 +01:00
Igor Nikonov
9a788c3cac Fix: sync replicas to get consisten result 2023-09-25 12:21:12 +00:00
Igor Nikonov
3a78ba6de4 Fix, enable tests, make cluster_for_parallel_replicas empty by default 2023-09-09 21:36:39 +00:00
Igor Nikonov
2c85c28113 Cleanup 2023-09-07 07:15:42 +00:00
robot-clickhouse
6404768aa4 Automatic style fix 2023-09-06 22:45:17 +00:00
Igor Nikonov
724e2ee4f7 Disable prefer_localhost_replica in tests 2023-09-06 22:27:41 +00:00
robot-clickhouse
c36f828f9f Automatic style fix 2023-08-17 11:42:56 +00:00
Igor Nikonov
df4ca32210 Fix: select correct number of replicas for shard on coordinator
+ more tests
2023-08-17 11:31:51 +00:00
Igor Nikonov
f1e040447f Tests: there is no need for cluster_for_parallel_replicas setting in queries over distributed anymore 2023-08-15 17:14:36 +00:00
Igor Nikonov
c85986a5da Update test 2023-08-14 23:06:48 +00:00
Igor Nikonov
c94994afcf Propagate setting cluster_for_parallel_replicas to shards 2023-08-14 22:50:46 +00:00
Igor Nikonov
5e7a438631 Fix cluster configs
correct internal replication flag
2023-08-09 19:33:45 +00:00
robot-clickhouse
6dc1772781 Automatic style fix 2023-08-07 21:28:44 +00:00
Igor Nikonov
8ba67f10bb Update test name 2023-08-07 21:13:08 +00:00
Igor Nikonov
50b0db598e Update test: use ReplicatedMergeTree 2023-08-07 21:06:12 +00:00
robot-clickhouse
9b631e2cef Automatic style fix 2023-08-07 19:23:31 +00:00
Igor Nikonov
cb49b7b9ad Integration test 2023-08-07 19:12:53 +00:00