Commit Graph

127225 Commits

Author SHA1 Message Date
AN
f8348681aa
Update architecture.md
Russian language fixes (hyphens in compounds, tautologies etc.), term unification («column» → «столбец», а было то «столбец», то «колонка», «строка/столбец» is traditional translation for ‘row/column‘ in translations (see translations of Date)
2023-10-24 19:47:27 +03:00
Maksim Kita
0e176fa0ed Fixed code review issues 2023-10-24 19:39:25 +03:00
Sergei Trifonov
8f3eb23f3c
Merge pull request #55956 from bigo-sg/json_seder_skip_null
Allow skip null values when serailize tuple to json objects
2023-10-24 18:32:01 +02:00
Robert Schulze
f94c33586c
Fix issue #42966 2023-10-24 15:14:20 +00:00
xuzifu666
010cc6918a
Add get_direct_children_number command to keeper-client (#55898) 2023-10-24 17:02:54 +02:00
Robert Schulze
1375733643
Merge pull request #55955 from rschu1ze/test-bug-43644
Test for Bug 43644
2023-10-24 16:16:52 +02:00
Robert Schulze
0955107e8e
Merge pull request #55948 from rschu1ze/arrayFold-switch-args
arrayFold: Switch accumulator and array arguments
2023-10-24 16:16:02 +02:00
Salvatore Mesoraca
2d2eaceb77
formatQuery: move doc 2023-10-24 16:13:15 +02:00
Salvatore Mesoraca
3e0b6eb77b
formatQuery: validate args using helper function 2023-10-24 16:10:43 +02:00
Azat Khuzhin
66c4a3bdbc tests: more robust 02903_rmt_retriable_merge_exception
- separate uuid extraction
- add preliminary exit
- disable for ordinary database
- less number of attempts
- add optimize_throw_if_noop and missing sync replica, to fix:

  2023.10.24 15:18:35.925533 [ 640 ] {da7418c6-3d51-45bc-a0d0-4970bb0cdd51} <Debug> test_3kgjgry1.rmt1 (d18afb81-3a4b-4c02-b281-5575dce2f440): Cannot select parts for optimization: Entry for part all_1_1_0 hasn't been read from the replication log yet (in partition all)

- fix in case of ZooKeeper retries

  2023.10.24 11:50:24.792511 [ 1437 ] {c39fd15b-e2e6-4291-9912-39fda75ebcd5} <Trace> test_qxkzmigq.rmt1 (1c086c74-9ebe-495c-bbd2-87ab2d8ec43d): Renaming temporary part tmp_insert_all_1_1_0 to all_1_1_0 with tid (1, 1, 00000000-0000-0000-0000-000000000000).
  2023.10.24 11:50:24.797320 [ 1437 ] {c39fd15b-e2e6-4291-9912-39fda75ebcd5} <Trace> test_qxkzmigq.rmt1 (1c086c74-9ebe-495c-bbd2-87ab2d8ec43d) (Replicated OutputStream): ZooKeeperWithFaultInjection call FAILED: seed=17644626169032325693 func=tryMulti path=/clickhouse/zero_copy code=Session expired message=Fault injection before operation
  2023.10.24 11:50:24.797536 [ 1437 ] {c39fd15b-e2e6-4291-9912-39fda75ebcd5} <Debug> test_qxkzmigq.rmt1 (1c086c74-9ebe-495c-bbd2-87ab2d8ec43d): Undoing transaction. Rollbacking parts state to temporary and removing from working set: all_1_1_0.
  ...
  2023.10.24 11:50:25.000349 [ 1437 ] {c39fd15b-e2e6-4291-9912-39fda75ebcd5} <Trace> test_qxkzmigq.rmt1 (1c086c74-9ebe-495c-bbd2-87ab2d8ec43d): Renaming temporary part tmp_insert_all_1_1_0 to all_2_2_0 with tid (1, 1, 00000000-0000-0000-0000-000000000000).
  2023.10.24 11:50:25.007477 [ 760 ] {} <Trace> test_qxkzmigq.rmt1 (ReplicatedMergeTreeQueue): Insert entry queue-0000000000 to queue with type GET_PART with virtual parts [all_2_2_0]

CI:
- https://s3.amazonaws.com/clickhouse-test-reports/55944/da408df4a7296835897d7cef80d63f252df79b75/stateless_tests__tsan__s3_storage__[2_5].html
- https://s3.amazonaws.com/clickhouse-test-reports/55944/da408df4a7296835897d7cef80d63f252df79b75/stateless_tests_flaky_check__asan_.html
- https://s3.amazonaws.com/clickhouse-test-reports/55944/02fdd0513f7d413ce4ac39a70566855327ebfade/stateless_tests__aarch64_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-24 16:03:57 +02:00
Andrey Zvonov
b5e7955298
Merge branch 'ClickHouse:master' into zvonand-parsing-dt64-fix 2023-10-24 16:02:38 +02:00
Salvatore Mesoraca
457e7ba7bd
formatQuery: improve doc 2023-10-24 15:38:24 +02:00
Salvatore Mesoraca
6be7fd0fa1
Ignore formatQuery word during spell check 2023-10-24 15:38:24 +02:00
Salvatore Mesoraca
1380dc942e
Add formatQuery function 2023-10-24 15:38:24 +02:00
Salvatore Mesoraca
7e8dac6064
Fix logic 2023-10-24 15:36:17 +02:00
Salvatore Mesoraca
fdabea6158
clickhouse-client: don't show "0 rows in set" if it is zero and if exception was thrown 2023-10-24 15:36:14 +02:00
Alexander Gololobov
40062ca210
Fix test 2023-10-24 15:30:32 +02:00
MeenaRenganathan22
2ec9433b4e S390x by default uses openssl. So, the error message is different from boringSSL. Update the tets to match the error message 2023-10-24 06:10:11 -07:00
Alexander Tokmakov
2619eecd2f
Merge pull request #55890 from ClickHouse/tavplubix-patch-9
Update stress.py
2023-10-24 14:58:22 +02:00
Kruglov Pavel
62b154930a
Merge pull request #53504 from filimonov/ignore_max_distributed_connections_for_async_remote
Disable logic max_threads=max_distributed_connections when async_socket_for_remote=1
2023-10-24 14:15:21 +02:00
Kruglov Pavel
cb63b07e89
Merge pull request #55912 from wxybear/fix/storage_null_supports_subcolumns
fix: StorageNull supports subcolumns
2023-10-24 14:03:46 +02:00
Alexander Gololobov
04b82d6463
Merge pull request #55935 from ClickHouse/set_has_lwd
Set storage.has_lightweight_delete_parts flag when a part has been loaded
2023-10-24 14:01:11 +02:00
Kruglov Pavel
9a56ec4d63
Merge pull request #55891 from Avogar/try-fix-orc
Try to fix possible segfault in Native ORC input format
2023-10-24 13:57:43 +02:00
Azat Khuzhin
ff7e9e16d5 Fix possible performance test error
CI [1]:

    2023-10-24 12:18:27	 ++ rg -c array_fill.xml changed-test-definitions.txt
    2023-10-24 12:18:27	 + '[' '' -gt 0 ']'
    2023-10-24 12:18:27	 right/scripts/compare.sh: line 288: [: : integer expression expected

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/55944/da408df4a7296835897d7cef80d63f252df79b75/performance_comparison_[2_4]/compare.log

v1: use --include-zero
v2: revert to grep
v3: check exit code
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-24 13:51:57 +02:00
Kruglov Pavel
9f4f851505
Merge pull request #55899 from srikanthccv/issue-55023
Introduce setting `create_table_empty_primary_key_by_default`
2023-10-24 13:47:23 +02:00
Alexander Gololobov
ab8fe68571
Update tests/queries/0_stateless/02902_diable_apply_deleted_mask.sql
Co-authored-by: SmitaRKulkarni <Smita.Kulkarni@clickhouse.com>
2023-10-24 13:45:27 +02:00
Alexander Gololobov
247722d44e
Update tests/queries/0_stateless/02902_diable_apply_deleted_mask.sql
Co-authored-by: SmitaRKulkarni <Smita.Kulkarni@clickhouse.com>
2023-10-24 13:45:19 +02:00
Alexander Gololobov
837637caa6
Fix typo
Co-authored-by: SmitaRKulkarni <Smita.Kulkarni@clickhouse.com>
2023-10-24 13:45:01 +02:00
Salvatore Mesoraca
4cf17dc50a
Add other fuzzer tests 2023-10-24 13:36:56 +02:00
Salvatore Mesoraca
6b7b3a641f
Fix more fuzzying issues 2023-10-24 13:36:56 +02:00
Salvatore Mesoraca
471fe28165
Improve tests 2023-10-24 13:36:56 +02:00
Salvatore Mesoraca
22ae8731f2
Handle the case when bool serialization generates incorrect values on failure
Fix issue found by fuzzer
2023-10-24 13:36:55 +02:00
Salvatore Mesoraca
36da379b93
Revert "Add stronger exception guarantees to bool serialization"
This reverts commit 62d06a0a4cd39344b41b90300b772299f9719924.
2023-10-24 13:36:55 +02:00
Salvatore Mesoraca
f417de4820
Add tests for issue found fuzzing 2023-10-24 13:36:55 +02:00
Salvatore Mesoraca
f29a618d7e
Add stronger exception guarantees to bool serialization
before this change the output column may or may not
contain an invalid value when an exception was thrown.
We now make sure that, in case of error, we either don't
make changes or we revert them.
2023-10-24 13:36:55 +02:00
Salvatore Mesoraca
fa76a88c4f
Revert "Revert "Fix issues in accurateCastOrNull""
This reverts commit 71d37d64ab.
2023-10-24 13:36:52 +02:00
Sergei Trifonov
e2846d4c58
Merge pull request #55922 from joclement/patch-2
docs: state limitations of `USING` clause.
2023-10-24 12:57:58 +02:00
vdimir
f7c1e8f69e
Set tag use-rocksdb for 02892_rocksdb_trivial_count 2023-10-24 12:45:11 +02:00
vdimir
72f2288ee4
Add optimize_trivial_approximate_count_query to stress tests 2023-10-24 12:44:18 +02:00
Robert Schulze
a962161832
Bump to 3.19.6 2023-10-24 10:22:58 +00:00
Robert Schulze
aa977acf6b
Merge pull request #55916 from rschu1ze/grpc-1.42.0
Bump gRPC to v1.42.0
2023-10-24 12:12:17 +02:00
Robert Schulze
666f854b27
Bump protobuf to 3.19.3 2023-10-24 10:00:02 +00:00
Robert Schulze
38a2ba5769
Cosmetics 2023-10-24 09:53:20 +00:00
Raúl Marín
70adb4ca17 Fix SHOW DATABASES LIMIT <N> 2023-10-24 11:42:20 +02:00
vdimir
da6f3346fe
Merge pull request #55839 from ClickHouse/vdimir/async_executor_for_dictionary_load
Use AsyncPipelineExecutor all dictionaries
2023-10-24 11:31:36 +02:00
Robert Schulze
430559c328
Merge remote-tracking branch 'rschu1ze/master' into grpc-1.42.0 2023-10-24 09:16:31 +00:00
Robert Schulze
f2b65aafac
Merge pull request #55869 from rschu1ze/string-addinterval
Support string-encoded date arguments in `add|subtract*()`
2023-10-24 10:58:53 +02:00
Robert Schulze
68c3f41b71
Fix performance tests 2023-10-24 08:56:09 +00:00
Robert Schulze
b361b8e3e3
Merge remote-tracking branch 'rschu1ze/master' into test-bug-43644 2023-10-24 08:53:10 +00:00
Azat Khuzhin
da408df4a7 Proper ignoring of retriable errors during merge/mutate
The exception cannot be simply suppressed, since sanity checks in the
WriteBuffer dtor relies on the std::uncaught_exceptions(), and if the
exception will be suppressed, then if the buffer was not finalized, it
may abort (even though it is only in debug/sanitizers build).

So instead, IExecutableTask::printExecutionException() had been
introduced to distinguish when exception should be printed and when not.
2023-10-24 10:19:18 +02:00