Commit Graph

66 Commits

Author SHA1 Message Date
CurtizJ
db47ef923c fix prewhere 2020-02-05 19:42:27 +03:00
Baudouin Giard
9216c5761c Fix crash in corner case of MergeTreeRangeReader::ReadResult::shrink
It looks like most times the original number of rows per granule is
pretty much consistent across all granules, except for the last one,
however there seems to be cases (Issue #7713) where that's not the case.

The only way I have to reproduce the crash involves using proprietary
data, and unfortunately I haven't been able to come up with a test case
that would highlight the problem - just like the person who opened issue
7713. I can't share my dataset.

Reading the code, it looks pretty obvious to me here - unless I'm
missing something, that the intention here is to copy the corresponding
granules to one another so it makes sense to index
rows_per_granule_original with the same variable as rows_per_granule.

Signed-off-by: Baudouin Giard <bgiard@bloomberg.net>
2020-01-30 15:40:48 +00:00
Amos Bird
05a420ab20
Add prewhere test 2019-12-31 16:09:37 +08:00
Amos Bird
9af0c00053
Optimize PREWHERE
So that it's never worse than WHERE.
2019-11-18 22:59:03 +08:00
Nikolai Kochetov
a38124c68e Review fixes. 2019-10-31 14:32:24 +03:00
Nikolai Kochetov
e48f7faebc Fix MergeTreeRangeReader.
Fix MergeTreeReader.

Fix MergeTreeBaseSelectProcessor.

Better exception message for TreeExecutor.

Added header_without_virtual_columns to MergeTreeBaseSelectProcessor.

Fix MergeTreeReverseSelectProcessor.

Fix MergeTreeDataSelectExecutor.
2019-10-04 20:49:29 +03:00
Nikolai Kochetov
b65fe57319 Update MergeTreeRangeReader. 2019-09-26 20:29:41 +03:00
Nikolai Kochetov
5108ebeece Remove Block from RangeReader. 2019-09-23 22:22:02 +03:00
Alexey Milovidov
b42f85e16b Added a check for double whitespaces 2019-08-23 21:30:04 +03:00
kreuzerkrieg
112fc71276 adding -Wshadow for GCC 2019-08-09 23:58:16 +03:00
CurtizJ
a3d25790bd basic implementation of reading in pk order and 'order by' optimization 2019-07-18 17:41:11 +03:00
alesapin
69b623c47c Return logic for cache 2019-04-01 14:09:30 +03:00
alesapin
37427077b8 Remove average granularity logic from code 2019-04-01 13:34:22 +03:00
alesapin
78e09a221a Remove debug prints, little refactoring 2019-03-30 17:43:43 +03:00
alesapin
18d19aa346 More precise estimation of rows 2019-03-28 18:03:49 +03:00
alesapin
5332642fee CI Fails fixes and little performance improvement 2019-03-28 11:52:09 +03:00
alesapin
ad16c7c931 Slightly better performance on index granularity 2019-03-27 20:33:55 +03:00
alesapin
e449760fde Remove debug print 2019-03-27 19:50:01 +03:00
alesapin
22a75196ab Slightly more faster 2019-03-27 18:57:14 +03:00
alesapin
c0e29d3fb4 Fix first time read from mark 2019-03-25 19:55:48 +03:00
alesapin
aba51a11ba Large refactoring (only compilable) 2019-03-25 16:55:24 +03:00
alesapin
2f037bad58 Fix bug in merging algorithm 2019-03-19 16:10:24 +03:00
alesapin
d8aa5c7c49 Slightly clearer debug and fix alter 2019-03-19 12:57:29 +03:00
alesapin
ce03636f05 Merge master 2019-03-18 15:02:33 +03:00
Alexey Milovidov
1d4701b0bc Added some warnings from clang's -Weverything 2019-01-04 15:10:00 +03:00
alesapin
7925abcd74 Deep debugging 2018-12-04 17:44:42 +03:00
alesapin
8c34386310 Some debug 2018-12-04 11:05:58 +03:00
alesapin
497a09c41b Return to adaptive granularity 2018-11-29 16:12:20 +03:00
proller
160ffb2283
Build fixes (clang 7.0.0+) (#3582) 2018-11-16 15:22:51 +03:00
alesapin
6123993ec0 Load granularity to memroy 2018-11-15 17:06:54 +03:00
alesapin
6b33008758 More fixed 2018-11-14 14:26:44 +03:00
Amos Bird
3cf2177268 Flexible fields assignment
Field f;

before:

f = Int64(-42);

after:

f = -42;
2018-10-24 08:47:33 +08:00
Nikolai Kochetov
b1fa3fab9d Fix prewhere whith final. #2827 2018-10-04 21:18:54 +03:00
Nikolai Kochetov
a6d0094835 Fix readnig missing column with prewhere. #2827 2018-10-04 10:51:06 +03:00
Nikolai Kochetov
2ea009bddc Fix columns ordering. 2018-09-10 18:28:03 +03:00
Nikolai Kochetov
3c6db8ebc1 Fix prewhere with aliased columns. [#CLICKHOUSE-3944] 2018-09-04 21:28:01 +03:00
Nikolai Kochetov
081f0feb56 fix test [#CLICKHOUSE-3694] #2156 2018-04-16 22:49:14 +03:00
Nikolai Kochetov
325f16f8a5 fix perf 2018-04-13 23:09:13 +03:00
Nikolai Kochetov
c9abeed3f5 remove unused columns from prewhere actions [#CLICKHOUSE-3694] #2156 2018-04-11 22:08:53 +03:00
Nikolai Kochetov
532b57aef8 perf. fixes 2018-03-07 01:05:36 +03:00
Nikolai Kochetov
b2b1588d5f added FilterWithZerosCounter 2018-03-05 17:25:20 +03:00
Nikolai Kochetov
7851e71a2a fix continueReadingChain from several mark ranges 2018-03-02 16:05:33 +03:00
Nikolai Kochetov
733156438a fix continueReadingChain from several mark ranges 2018-02-22 14:35:06 +03:00
Nikolai Kochetov
39f16b66b5 fix continueReadingChain from several mark ranges 2018-02-22 14:31:15 +03:00
Nikolai Kochetov
ba81835e58 fixed progress stats 2018-02-20 17:26:22 +03:00
Nikolai Kochetov
2bf1931d86 updated MergeTreePrewhereRangeReader; renamed MergeTreePrewhereRangeReader to MergeTreeRangeReader 2018-02-20 16:37:04 +03:00
Nikolai Kochetov
dcd99860fe updated MergeTreePrewhereRangeReader; renamed MergeTreePrewhereRangeReader to MergeTreeRangeReader 2018-02-20 16:30:47 +03:00
Nikolai Kochetov
d8b5f14dd7 updated MergeTreePrewhereRangeReader; renamed MergeTreePrewhereRangeReader to MergeTreeRangeReader 2018-02-20 15:26:09 +03:00
Nikolai Kochetov
d2d0d570d8 updated MergeTreePrewhereRangeReader; renamed MergeTreePrewhereRangeReader to MergeTreeRangeReader 2018-02-20 15:09:32 +03:00
Nikolai Kochetov
77a3989558 updated MergeTreePrewhereRangeReader; renamed MergeTreePrewhereRangeReader to MergeTreeRangeReader 2018-02-20 15:02:25 +03:00