Commit Graph

5983 Commits

Author SHA1 Message Date
Alexey Milovidov
eb89ab471f
Merge pull request #45911 from ClickHouse/mutations_rename_hang
Fix several `RENAME COLUMN` bugs.
2023-02-26 01:56:40 +03:00
Alexey Milovidov
656af55831
Merge pull request #46384 from ClickHouse/fixes_for_993
Fixes for 993
2023-02-26 01:55:20 +03:00
Vitaly Baranov
2d38c89e2a Fix test test_async_backups_to_same_destination. 2023-02-25 23:38:40 +01:00
Alexey Milovidov
88704c4d9f Fix flaky test_concurrent_queries_restriction_by_query_kind 2023-02-25 22:23:29 +01:00
Robert Schulze
fbba9e319d
Merge branch 'master' into rs/periods-in-kafka-topics 2023-02-25 21:45:20 +01:00
SmitaRKulkarni
4109fbd7cf
Merge pull request #46517 from azat/tests/fix-backup-restore-flakiness
Fix flakiness of test_backup_restore_on_cluster/test_disallow_concurrency
2023-02-25 19:54:21 +01:00
Alexander Tokmakov
cad1e0b768 fix 2023-02-25 01:18:34 +01:00
avogar
c6a30d23aa Add separate test 2023-02-24 12:31:09 +00:00
Kruglov Pavel
2150b836b1
Merge branch 'master' into fix-kafka-protobuf 2023-02-24 12:48:07 +01:00
Robert Schulze
6906cafa99
Change to S3 cfg syntax 2023-02-23 20:04:41 +00:00
Alexander Tokmakov
f76c42348b
Merge pull request #46402 from lzydmxy/apply_move_partition_to_all_replicas
Apply `ALTER TABLE ON CLUSTER MOVE PARTITION TO DISK|VOLUME` to all replicas.
2023-02-23 19:42:54 +03:00
Kruglov Pavel
bda1ce7367
Update test.py 2023-02-23 14:47:29 +01:00
Kseniia Sumarokova
7e064ccbd4
Merge pull request #46667 from kssenii/hide-named-collections-under-setting
Allow to hide only values from system.named_collections while making collection visible
2023-02-23 11:44:50 +01:00
Kseniia Sumarokova
30a8eb0c2f
Merge pull request #46670 from kssenii/hide-disk-setting
Hide arguments of custom disk merge tree setting
2023-02-23 11:42:53 +01:00
Alexey Milovidov
0db943e596
Merge pull request #46687 from ClickHouse/tavplubix-patch-5
Disable flaky test_ttl_move_memory_usage.py
2023-02-23 10:27:25 +03:00
Robert Schulze
81bf43157f
Allow configuration of Kafka topics with periods
The Kafka table engine allows global configuration and per-Kafka-topic
configuration. The latter uses syntax <kafka_TOPIC>, e.g. for topic
"football":

  <kafka_football>
      <retry_backoff_ms>250</retry_backoff_ms>
      <fetch_min_bytes>100000</fetch_min_bytes>
  </kafka_football>

Some users had to find out the hard way that such configuration doesn't
take effect if the topic name contains a period, e.g. "sports.football".
The reason is that ClickHouse configuration framework already uses
periods as level separators to descend the configuration hierarchy.
(Besides that, per-topic configuration at the same level as global
configuration could be considered ugly.)

Note that Kafka topics may contain characters "a-zA-Z0-9._-" (*) and
a tree-like topic organization using periods is quite common in
practice.

This PR deprecates the existing per-topic configuration syntax (but
continues to support it for backward compat) and introduces a new
per-topic configuration syntax below the global Kafka configuration of
the form:

<kafka>
   <topic name="football">
       <retry_backoff_ms>250</retry_backoff_ms>
       <fetch_min_bytes>100000</fetch_min_bytes>
   </topic>
</kafka>

The period restriction doesn't apply to XML attributes, so <topic
name="sports.football"> will work. Also, everything Kafka-related is
below <kafka>.

Considered but rejected alternatives:
- Extending Poco ConfigurationView with custom separators (e.g."/"
  instead of "."). Won't work easily because ConfigurationView only
  builds a path but defers descending the configuration tree to the
  normal configuration classes.
- Reloading the configuration file in StorageKafka (instead of reading
  the loaded file) but with a custom separator. This mode is supported
  by XML configuration. Too ugly and error-prone since the true
  configuration is composed from multiple configuration files.

(*) https://stackoverflow.com/a/37067544
2023-02-22 20:35:09 +00:00
Alexander Gololobov
b0427c2e3c
Merge pull request #46660 from ClickHouse/fix_backup_test
Fix integration test: terminate old version without wait
2023-02-22 15:20:26 +01:00
Antonio Andelic
7f5fb77ed5
Increase table retries in cluster copier tests (#46590) 2023-02-22 15:09:48 +01:00
kssenii
c4761d6cc6 Fix checks 2023-02-22 14:27:43 +01:00
Alexander Tokmakov
fba2ec30a2 fix style check 2023-02-22 13:53:43 +01:00
lzydmxy
ec8b6c5590 add __init__.py for integration test test_move_partition_to_disk_on_cluster 2023-02-22 19:57:56 +08:00
kssenii
ceff5f41d1 Fix tests 2023-02-22 12:27:07 +01:00
Dmitry Novik
67469ad46b
Merge pull request #46622 from ClickHouse/async-insert-memory-fix
Fix MemoryTracker counters for async inserts
2023-02-22 12:27:05 +01:00
Kseniia Sumarokova
3f0d93d6e6
Merge pull request #46656 from ClickHouse/kssenii-patch-6
Update postgres_utility.py
2023-02-22 11:35:03 +01:00
Alexander Tokmakov
c009c2f4cb
Update test_ttl_move_memory_usage.py 2023-02-22 00:50:21 +03:00
kssenii
08b0e3c630 Fix style check 2023-02-21 18:27:37 +01:00
kssenii
9a7c71b78e Allow to hide only values from system.named_collections 2023-02-21 18:07:57 +01:00
Igor Nikonov
bf05082984
Merge branch 'master' into keeper-retries-by-default 2023-02-21 17:59:55 +01:00
robot-clickhouse
af677c7dcd Automatic style fix 2023-02-21 16:08:13 +00:00
alesapin
1d4352d82a Fix integration test: terminate old version without wait 2023-02-21 17:01:19 +01:00
Kruglov Pavel
341a776617
Disable test 2023-02-21 16:41:05 +01:00
Kseniia Sumarokova
3df7a10ac7
Update postgres_utility.py 2023-02-21 16:25:11 +01:00
Kseniia Sumarokova
655e7f29f7
Merge pull request #46595 from kssenii/update-rabbit-producer
Fix rabbitmq test
2023-02-21 16:18:55 +01:00
Kseniia Sumarokova
a45480c11e
Merge pull request #46596 from ClickHouse/kssenii-patch-7
Fix meilisearch test flakyness
2023-02-21 14:23:07 +01:00
Kseniia Sumarokova
09a979f106
Merge branch 'master' into update-rabbit-producer 2023-02-21 11:50:30 +01:00
robot-clickhouse
93aabf8c66 Automatic style fix 2023-02-21 02:06:16 +00:00
Dmitry Novik
573ce50403 Fix test 2023-02-21 01:44:10 +00:00
Dmitry Novik
16a9ac9118 Try to add test 2023-02-21 00:52:54 +00:00
robot-clickhouse
abeb1c5ba8 Automatic style fix 2023-02-20 23:49:25 +00:00
Alexey Milovidov
4a2bd6e0aa Adapt a test 2023-02-21 00:43:10 +01:00
Alexey Milovidov
dc4b52e54e Adapt a test 2023-02-21 00:41:40 +01:00
Alexey Milovidov
40d11ce422 Adapt a test 2023-02-21 00:39:32 +01:00
Kruglov Pavel
828a06b511
Merge branch 'master' into fix-kafka-protobuf 2023-02-20 21:45:43 +01:00
Kseniia Sumarokova
47604ad77e
Merge pull request #46106 from kssenii/return-materialized-postrgesql-tests-back
Enable disabled MaterializedPostgreSQL tests back in CI
2023-02-20 19:04:58 +01:00
kssenii
0a36398847 Update test 2023-02-20 16:53:06 +01:00
Kseniia Sumarokova
0d9a541441
Update test.py 2023-02-20 16:43:10 +01:00
kssenii
80a0aa1327 Merge remote-tracking branch 'upstream/master' into return-materialized-postrgesql-tests-back 2023-02-20 14:37:39 +01:00
kssenii
591510c20e Uodate test 2023-02-20 14:36:53 +01:00
Kseniia Sumarokova
514e3cbf90
Update test.py 2023-02-20 14:29:04 +01:00
kssenii
361678ad73 rabbitmq-test-fix 2023-02-20 14:16:40 +01:00
lzydmxy
ccf87a6afd add integration test for move partition to disk on cluster 2023-02-20 16:52:55 +08:00
Azat Khuzhin
0859bbb08b Compress tar archives with zstd in intergration tests
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-18 21:54:38 +01:00
pufit
5b10fafbb0 Additional tests 2023-02-18 13:45:33 -05:00
Alexey Milovidov
f073cd470f
Merge pull request #46478 from ClickHouse/fix_test_store_cleanup
Fix some flaky integration tests
2023-02-18 17:33:02 +03:00
Kseniia Sumarokova
b0ea047e76
Merge pull request #46533 from kssenii/fix-disk-setting
Allow `disk` merge tree setting in query to override config merge tree setting `storage_policy`
2023-02-18 12:36:54 +01:00
kssenii
ee7eb8a7dc Fix test 2023-02-18 12:28:55 +01:00
Azat Khuzhin
fb35a6852e More flakiness fiexes for test_backup_restore_on_cluster/test_disallow_concurrency
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-18 11:13:32 +01:00
kssenii
30748eace8 Fix black check 2023-02-17 21:02:16 +01:00
kssenii
afb36dd120 Allow disk setting to override storage_policy from config merge tree settings insteaf of exception 2023-02-17 17:11:29 +01:00
Antonio Andelic
ab51c1d975
Merge branch 'master' into custom-key-parallel-replicas 2023-02-17 15:06:41 +01:00
flynn
ebd88aab41
Merge branch 'master' into iceberg 2023-02-17 21:53:29 +08:00
Alexander Tokmakov
fb3574d2cf Merge branch 'master' into fix_test_store_cleanup 2023-02-17 13:59:22 +01:00
kssenii
729c4b74d1 Fix black check 2023-02-17 13:47:45 +01:00
Mikhail f. Shiryaev
3edfb62066
Rollback unnecessary sync because of checking exit code 2023-02-17 12:28:04 +01:00
Alexander Tokmakov
9a664efeb6
Merge branch 'master' into fixes_for_993 2023-02-17 14:17:08 +03:00
Azat Khuzhin
1a352b9021 Fix flakiness of test_backup_restore_on_cluster/test_disallow_concurrency
The problem is that if you will run first
test_concurrent_restores_on_different_node and after
test_concurrent_restores_on_same_node, like in [1], the first one will
leave the RESTORE and the second will fail.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/45282/5af2967f65c3293b277872a002cb5d570200c008/integration_tests__asan__[3/6].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-17 10:21:52 +01:00
Antonio Andelic
4e6587b34b
Merge pull request #46488 from ClickHouse/Avogar-patch-1
Try fix flaky test test_parallel_distributed_insert_select_with_schema_inference
2023-02-17 10:19:18 +01:00
Alexey Milovidov
993a39e2a1
Merge pull request #46360 from genzgd/http_client_version
Allow to provide the protocol version by HTTP clients to tune the compatibility of the Native output format.
2023-02-16 22:17:04 +03:00
kssenii
417052e4b2 Fix remaining tests 2023-02-16 18:56:19 +01:00
kssenii
75d62ee24a Remove support of feature which does not work reliably 2023-02-16 16:41:31 +01:00
Kruglov Pavel
0ed6ddd7ab
Try fix flaky test test_parallel_distributed_insert_select_with_schema_inference 2023-02-16 16:28:47 +01:00
Alexander Tokmakov
cc4932aa35 disable flaky test with cassandra dictionaries 2023-02-16 15:11:34 +01:00
robot-clickhouse
a96d6af17e Automatic style fix 2023-02-16 13:37:40 +00:00
Alexander Tokmakov
86d177e0ee fix flaky test 2023-02-16 14:19:55 +01:00
kssenii
0954a57a6a Enable back 2023-02-16 13:27:58 +01:00
Alexander Tokmakov
ac62356477 fix 2023-02-16 13:05:13 +01:00
Kseniia Sumarokova
4303ee9114
Merge pull request #46404 from kssenii/fix-rabbit-test-4
Fix test test_rabbitmq_overloaded_insert
2023-02-16 11:28:18 +01:00
Vitaly Baranov
7dabd18e8d
Merge pull request #46449 from vitlibar/fix-backup-tests
Fix a backup test
2023-02-16 10:55:01 +01:00
flynn
ecc39978d7 fix conflict 2023-02-16 02:23:55 +00:00
Vitaly Baranov
4a3ad7da85 Fix test test_backup_restore_new/test.py::test_async_backups_to_same_destination[http]. 2023-02-15 17:27:05 +01:00
robot-clickhouse
69463f852e Automatic style fix 2023-02-15 15:44:19 +00:00
Alexander Tokmakov
885f14311c fix 2023-02-15 16:37:44 +01:00
Kruglov Pavel
4f380370a9
Fix s3Cluster schema inference in parallel distributed insert select (#46381)
* Fix s3Cluster schema inference in parallel distributed insert select
* Try fix flaky test
* Try SYSTEM SYNC REPLICA to avoid test flakiness
2023-02-15 15:30:43 +01:00
Geoff Genz
33037334a5 Add raw content option to http helper methods 2023-02-15 07:17:28 -07:00
Kruglov Pavel
e56dead5aa
Merge branch 'master' into fix-kafka-protobuf 2023-02-15 15:16:25 +01:00
Antonio Andelic
4dd4aac125
Merge branch 'master' into custom-key-parallel-replicas 2023-02-15 11:02:37 +01:00
Geoff Genz
fb90c57918 Fix black quotes 2023-02-14 18:44:41 -07:00
Geoff Genz
143806d8ed Fix black quotes 2023-02-14 18:36:17 -07:00
Alexander Tokmakov
ff5023049b
Update test.py 2023-02-15 02:17:02 +03:00
Geoff Genz
f3bcf26959
Merge branch 'ClickHouse:master' into http_client_version 2023-02-14 09:31:29 -07:00
Geoff Genz
5652625ef3 Add http client_protocol_version test 2023-02-14 09:30:13 -07:00
Vladimir C
726fb4bebc
Merge pull request #46368 from ClickHouse/vdimir/bugfix-validate-fix 2023-02-14 14:54:07 +01:00
flynn
e05b4e9745 fix conflict 2023-02-14 13:49:28 +00:00
Antonio Andelic
adde580756
Merge branch 'master' into custom-key-parallel-replicas 2023-02-14 14:09:12 +01:00
kssenii
bead024ecb Fix test 2023-02-14 12:45:57 +01:00
vdimir
19b5d21e8b
Minor fix in files locating for Bugfix validate check 2023-02-14 12:31:10 +01:00
Kseniia Sumarokova
1ed4d20e1c
Update test.py 2023-02-14 12:25:27 +01:00
Kseniia Sumarokova
810348a613
Merge pull request #46340 from ClickHouse/kssenii-patch-6
Update cluster.py
2023-02-14 11:43:58 +01:00
robot-clickhouse
dce8dca4e5 Automatic style fix 2023-02-13 23:53:15 +00:00
Alexander Tokmakov
e712fbecb2 fix race between drop and create 2023-02-14 00:45:28 +01:00
Nikolai Kochetov
1c0c662fe1
Merge pull request #46275 from ClickHouse/less-mem-usage-for-vertical-merge
Less memory usage for vertical merge (non-remote disk)
2023-02-13 21:10:43 +01:00
Kseniia Sumarokova
3977643b52
Update cluster.py 2023-02-13 13:42:21 +01:00
Kruglov Pavel
e139070043
Merge branch 'master' into fix-kafka-protobuf 2023-02-13 12:38:18 +01:00
Antonio Andelic
8d16fe5793
Merge branch 'master' into add-support-for-settings-alias 2023-02-13 08:46:00 +01:00
Dan Roscigno
5dd6f25d5d
Merge pull request #46276 from ClickHouse/document-log-compression
docs for logger stream_compression
2023-02-12 21:55:33 -05:00
alesapin
1683cd5d6f
Merge branch 'master' into mutations_rename_hang 2023-02-12 13:06:48 +01:00
Alexey Milovidov
395d6b6bd5
Merge pull request #46282 from CurtizJ/return-back-vertical-merges
Allow vertical merges from compact to wide parts [2]
2023-02-12 05:51:12 +03:00
Alexey Milovidov
732a030036
Merge pull request #46288 from azat/tests/simplify-attach-from-s3
Simplify ATTACH MergeTree table FROM S3 in tests
2023-02-12 05:31:24 +03:00
Kseniia Sumarokova
ed6f623f3a
Merge pull request #46168 from kssenii/resubmit-prefetches
Allow to increase prefetching of data for reads
2023-02-11 16:22:47 +01:00
Kruglov Pavel
e84baa9106
Merge pull request #43179 from tonickkozlov/tonickkozlov/add-interserver-dns-retries
CLICKHOUSE-2375 Add interserver DNS retries
2023-02-11 14:35:40 +01:00
alesapin
5c83ddabf9 Merge branch 'master' into mutations_rename_hang 2023-02-11 12:18:58 +01:00
kssenii
3067c1d723 Merge remote-tracking branch 'upstream/master' into resubmit-prefetches 2023-02-11 11:36:23 +01:00
Azat Khuzhin
67b47fe871 Simplify ATTACH MergeTree table FROM S3 in tests
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-11 08:46:05 +01:00
Kruglov Pavel
cf14282d79
Fix style 2023-02-11 01:45:28 +01:00
Kruglov Pavel
825a5dd806
Try prevent flaky test 2023-02-10 23:12:32 +01:00
Kseniia Sumarokova
3be36c7979
Merge pull request #41976 from kssenii/allow-single-disk-instead-of-storage-policy
Allow configuring storage as `SETTINGS disk='<disk_name>'` (instead of `storage_policy`) and explicit disk creation `SETTINGS disk=disk(<disk_configuration>)`
2023-02-10 21:38:50 +01:00
Kruglov Pavel
8bbf62508f
Merge branch 'master' into fix-kafka-protobuf 2023-02-10 18:32:25 +01:00
Anton Popov
1205932a19 add setting to disable vertical merges from compact parts 2023-02-10 16:33:46 +00:00
Antonio Andelic
9e11f06e79
Merge pull request #46191 from ClickHouse/s3-reorder-creds
Prefer explicitly defined credentials for S3
2023-02-10 16:35:54 +01:00
Sema Checherinda
4827c70b5e
Merge pull request #46233 from ClickHouse/CheSema-patch-1
increase a time gap between insert and ttl move
2023-02-10 15:36:56 +01:00
DanRoscigno
043c1b7d8d docs for logger stream_compression 2023-02-10 09:02:54 -05:00
robot-clickhouse
fa424ae8eb Automatic style fix 2023-02-10 14:01:19 +00:00
Nikolai Kochetov
367136697d Added tests. 2023-02-10 13:51:02 +00:00
flynn
37a850bd36 Merge branch 'master' of github.com:ClickHouse/ClickHouse into iceberg 2023-02-10 08:47:14 +00:00
flynn
db15634a01 fix conflict 2023-02-10 08:41:04 +00:00
Alexander Tokmakov
e5f8a44b87
Merge pull request #46243 from ClickHouse/tavplubix-patch-7
Fix test_distributed_ddl_parallel
2023-02-09 22:15:08 +03:00
Alexander Tokmakov
f7c7c9be31
Update test.py 2023-02-09 20:37:47 +03:00
Alexander Tokmakov
e2be729aea
Update test.py 2023-02-09 20:27:24 +03:00
Antonio Andelic
f96d480563
Merge branch 'master' into add-support-for-settings-alias 2023-02-09 16:07:45 +01:00
Sema Checherinda
ffc97908ef
increase a time gap between insert and ttl move 2023-02-09 15:12:21 +01:00
Kruglov Pavel
947923321c
Fix style 2023-02-09 14:55:21 +01:00
Kruglov Pavel
59c52c503d
Fix style 2023-02-09 14:09:46 +01:00
Kruglov Pavel
8821074f83
Fix style 2023-02-09 14:08:24 +01:00
Vitaly Baranov
39bacfb9dc
Merge branch 'master' into allow-single-disk-instead-of-storage-policy 2023-02-09 13:16:55 +01:00
Kruglov Pavel
c3c0356fdd
Merge branch 'master' into fix-kafka-protobuf 2023-02-09 13:04:55 +01:00
alesapin
0a82385413 Blind fix for trash test 2023-02-09 12:23:18 +01:00
robot-clickhouse
2f9ad860bd Automatic style fix 2023-02-09 08:26:36 +00:00
Antonio Andelic
ae731b739a Prefer explicitly defined creds for S3 2023-02-09 08:13:16 +00:00
pufit
7cf71d1f82
Merge pull request #46144 from ClickHouse/46131-fix-config-attributes-merge
Fix config merge for XML attributes.
2023-02-08 23:28:13 -05:00
Alexander Tokmakov
4fd4058259
Merge pull request #45629 from arthurpassos/fix_cares_crash
Cancel c-ares failed requests and retry on system interrupts to prevent callbacks with dangling references and premature resolution failures
2023-02-09 02:29:29 +03:00
Alexander Tokmakov
65cbb0fcfc
Merge pull request #46138 from vitlibar/fix-dependency-checks
Fix dependency checks
2023-02-09 00:54:40 +03:00
alesapin
00686ae03b Fix tests again 2023-02-08 22:34:09 +01:00
kssenii
b0b865c32e Resubmit prefetches 2023-02-08 21:26:24 +01:00
alesapin
5f33aaf59b Fix three leftovers 2023-02-08 16:31:37 +01:00
robot-clickhouse
f81f0b351f Automatic style fix 2023-02-08 13:58:55 +00:00
alesapin
a28d10a810 Fxi 2023-02-08 14:50:30 +01:00
Kseniia Sumarokova
f6ebe11350
Merge pull request #46108 from azat/azure-fix
Fix test_merge_tree_azure_blob_storage::test_zero_copy_replication test
2023-02-08 12:04:46 +01:00
Alexey Milovidov
5145beb033
Merge branch 'master' into 46131-fix-config-attributes-merge 2023-02-08 10:42:54 +03:00
Alexey Milovidov
da22a770a0
Merge pull request #46107 from kssenii/rabbit-test-overloaded-insert-fix
Fix flaky rabbitmq test
2023-02-08 04:14:03 +03:00
robot-clickhouse
6fda4902d8 Automatic style fix 2023-02-07 23:57:14 +00:00