Commit Graph

2981 Commits

Author SHA1 Message Date
Alexey Zatelepin
116ed0a59e add RestartingThread wakeup for faster session recovery 2018-07-05 19:30:52 +03:00
Alexey Zatelepin
fe83c8dab1 stricter validation of mutation commands #2588 2018-07-05 17:19:33 +03:00
Alexey Milovidov
c99e717632 Fixed bad code #2571 2018-07-04 20:28:52 +03:00
Alexey Milovidov
e86f73e465 Fixed half of bad code #2571 2018-07-04 20:28:52 +03:00
Alexey Zatelepin
2447755700 BackgroundSchedulePool: remove task from delayed even it it is currently executing
If the task was left in the delayed_tasks set, it could lead to a nasty bug:
delayExecutionThreadFunction() would schedule the task, then it would immediately
go on a next iteration and schedule the same task again. Thus this task would be
continually executing, and other delayed tasks would have no chance to run.
2018-06-27 13:47:58 +03:00
Alexey Zatelepin
971fddb299 add comments [#CLICKHOUSE-3747] 2018-06-22 13:43:35 +03:00
zhang2014
f4e72792a5 ISSUES-2553 add offset parameter to numbers 2018-06-22 12:55:36 +03:00
Alexey Zatelepin
e78dc8142c factor out common code [#CLICKHOUSE-3747] 2018-06-21 22:47:44 +03:00
Alexey Zatelepin
a6c61848f1 mutations finalizing task [#CLICKHOUSE-3747] 2018-06-21 22:47:44 +03:00
Alexey Zatelepin
36982b967d use single mutex in ReplicatedMergeTreeQueue for simplicity 2018-06-21 22:47:44 +03:00
Alexey Zatelepin
b2cdfcbaca calculate and update parts_to_do for mutations [#CLICKHOUSE-3747] 2018-06-21 22:47:44 +03:00
proller
e1ae5233df Add // Y_IGNORE tags 2018-06-21 18:24:36 +03:00
proller
fbe7df73a2
CLICKHOUSE-3762 Build fixes (#2488)
CONTRIB-254
2018-06-19 21:09:09 +03:00
Alexey Milovidov
2298f1c68b Fixed strange code #2501 2018-06-16 08:54:06 +03:00
Alexey Milovidov
b108882e2e Merge branch 'master' of https://github.com/alesapin/ClickHouse into alesapin-master 2018-06-16 08:29:00 +03:00
Alexey Milovidov
4e8082a699 Fixed build [#CLICKHOUSE-2] 2018-06-16 05:16:19 +03:00
Alexey Milovidov
0272fc996a Fixed build [#CLICKHOUSE-2] 2018-06-16 05:13:54 +03:00
alesapin
6e07b17632 Added WriteBufferFromHTTP and used it in StorageURL. Also small refactoring. 2018-06-15 00:22:56 +03:00
alesapin
148cbe8058 Added WriteBufferFromHTTP and used it in StorageURL. Also small refactoring. 2018-06-15 00:20:39 +03:00
alesapin
4125b0c7f3 Merge remote-tracking branch 'upstream/master' 2018-06-14 21:06:24 +03:00
Alexey Milovidov
1e60b733f4 Fixed warning #2504 2018-06-13 23:02:27 +03:00
alexey-milovidov
08ec751a8c
Merge pull request #2504 from yandex/system-mutations-table
[WIP] system.mutations table skeleton
2018-06-13 23:00:30 +03:00
alexey-milovidov
ca883a699d
Update StorageURL.cpp 2018-06-13 21:54:32 +03:00
alexey-milovidov
f546169a4d
Update StorageURL.cpp 2018-06-13 21:51:56 +03:00
Alexey Zatelepin
a3bf3e6d20 add missing columns to system.parts [#CLICKHOUSE-3747] 2018-06-13 18:47:40 +03:00
Alexey Zatelepin
b60a2a90fa rename method for clarity 2018-06-13 17:15:36 +03:00
Alexey Zatelepin
4ee581117b system.mutations table skeleton [#CLICKHOUSE-3747] 2018-06-13 17:15:36 +03:00
Alexey Zatelepin
2c61a5940c store mutation entries in shared_ptr 2018-06-13 17:14:12 +03:00
Alexey Zatelepin
c5c601f662 save serialized commands in ReplicatedMergeTreeMutationEntry; split InterpreterAlterQuery::parseAlter() [#CLICKHOUSE-3747] 2018-06-13 17:14:08 +03:00
alesapin
567bbb2bbb Fix header path and small fixes in tests 2018-06-13 10:36:47 +03:00
alesapin
b42351d36c Fix format in storage url 2018-06-13 10:00:07 +03:00
alesapin
df4f8bea35 Merge remote-tracking branch 'upstream/master' 2018-06-11 16:31:58 +03:00
alesapin
0f529dbc6e Add table fuction url and storage URL 2018-06-11 15:13:00 +03:00
alexey-milovidov
fafecb3c25
Better modularity of formats. (#2492)
* Formats: better modularity (development) #2447

* Formats: better modularity (development) #2447

* Formats: better modularity (development) #2447

* Formats: better modularity (development) #2447

* Formats: better modularity (development) #2447

* Formats: better modularity (development): removed very old tests #2447

* Formats: better modularity (development) #2447

* Formats: better modularity (development) #2447

* Formats: better modularity (development) #2447

* Formats: better modularity (development) #2447

* Formats: better modularity (development) #2447

* Formats: better modularity (development) #2447

* Formats: better modularity (development) #2447

* Formats: better modularity (development) #2447
2018-06-10 22:22:49 +03:00
Alexey Milovidov
72af2b7b0f Removed wrong modification #2260 2018-06-10 21:26:02 +03:00
Alexey Milovidov
641076de51 Reverted unclear modification #2260 2018-06-09 21:39:29 +03:00
Alexey Milovidov
ebe5e3f9b6 Reverted unclear modification #2260 2018-06-09 21:35:51 +03:00
Alexey Milovidov
6475ea98c7 Merging: Fixed most of problems, actualized test #2260 2018-06-09 21:17:27 +03:00
Alexey Milovidov
d864f39ec7 Merge branch 'master' into zhang2014-feature/support_truncate 2018-06-09 19:10:06 +03:00
Alexey Milovidov
cfacdf1457 Merging: Fixed most of problems #2260 2018-06-09 19:09:37 +03:00
Alexey Milovidov
d56c199f07 Merging: Fixed half of problems #2260 2018-06-09 18:48:22 +03:00
Alexey Milovidov
0bc678474e Merge branch 'feature/support_truncate' of https://github.com/zhang2014/ClickHouse into zhang2014-feature/support_truncate 2018-06-09 17:24:50 +03:00
Alexey Milovidov
9940b4f8ff Passing settings to ser/de of data types: development #1710 2018-06-08 05:26:44 +03:00
Alexey Milovidov
29bd48fc7a Passing settings to ser/de of data types: development #1710 2018-06-08 05:24:27 +03:00
Alexey Milovidov
26d448baad Passing settings to ser/de of data types: development #1710 2018-06-08 04:51:55 +03:00
Alexey Milovidov
8901414ad2 Fixed error; added test [#CLICKHOUSE-3764] 2018-06-07 23:49:59 +03:00
proller
347579ce46 Cmake: mark system includes as SYSTEM (#1449)
* contrib: cctz as submodule. update cctz.

* pbuilder: add ubuntu bionic, devel

* Cmake: mark system includes as SYSTEM

* Build fixes

* fix

* Fix package without compiler

* Better

* fix

* fix

* fix

* Build fix

* fix

* fix

* fix

* Cmake: Add SYSTEM to includes for external libs
2018-06-06 23:21:58 +03:00
Alexey Milovidov
267a69fe7e Better type for number of rows [#CLICKHOUSE-2] 2018-06-06 20:16:05 +03:00
Alexey Zatelepin
863c1c6ed5 add fields related to part mutations to system.replicas table [#CLICKHOUSE-3747] 2018-06-06 16:22:30 +03:00
Alexey Zatelepin
dbfee942af escape serialized AST in MutationCommands (just in case) [#CLICKHOUSE-3747] 2018-06-06 14:30:58 +03:00
Alexey Milovidov
b9b89a5590 Less dependencies [#CLICKHOUSE-2] 2018-06-05 22:46:49 +03:00
Alexey Zatelepin
3947f25365 add general comment about the mutation algorithm [#CLICKHOUSE-3747] 2018-06-05 17:55:35 +03:00
alexey-milovidov
39e69b421a
Merge pull request #2468 from yandex/fix-partition-key-parts-pruning
Fix pruning of parts by conditions on partition key columns
2018-06-05 15:52:47 +03:00
alexey-milovidov
f69ecf7a9d
Merge pull request #2448 from LiuYangkuan/fix-issue-2439
fix Exception in issue#2439
2018-06-04 23:17:44 +03:00
alexey-milovidov
3af746aab1
Merge pull request #2462 from proller/fix19
Build fixes
2018-06-04 23:17:21 +03:00
alexey-milovidov
88efe5ad56
Merge pull request #2463 from yandex/pvs-studio
Fixes according to PVS-Studio report.
2018-06-04 22:59:47 +03:00
Alexey Milovidov
0f96a5c1c5 Suppressions for PVS-Studio [#CLICKHOUSE-3] 2018-06-04 22:46:47 +03:00
proller
9907388766 32bit Compile fix 2018-06-04 20:04:31 +03:00
Alexey Milovidov
e5682e81f7 Slightly better (preparation) [#CLICKHOUSE-3] 2018-06-04 20:01:00 +03:00
Alexey Zatelepin
a9b348fe5e check if partition key condition can be true in parallelogram instead of range [#CLICKHOUSE-3757] 2018-06-04 19:20:02 +03:00
Alexey Zatelepin
ec7446e541 calculate primary key when mutating a part [#CLICKHOUSE-3747] 2018-06-04 18:45:34 +03:00
Alexey Milovidov
fa3a01f942 Fixed bug found by PVS-Studio [#CLICKHOUSE-3] 2018-06-04 18:03:21 +03:00
Alexey Milovidov
de72b4adde Fixed bug found by PVS-Studio [#CLICKHOUSE-3] 2018-06-04 18:01:18 +03:00
Alexey Zatelepin
2e77c508ad add comments [#CLICKHOUSE-3747] 2018-06-04 14:43:09 +03:00
Alexey Zatelepin
e55097b866 introduce constants for max level and max block number 2018-06-04 14:23:47 +03:00
Alexey Milovidov
7c60adbebb Non significant changes according to clang's -Weverything, part 4 [#CLICKHOUSE-2] 2018-06-03 23:48:36 +03:00
Alexey Milovidov
f5adbceed2 Non significant changes according to clang's -Weverything, part 3 [#CLICKHOUSE-2] 2018-06-03 23:39:06 +03:00
Alexey Milovidov
1c2b024c39 Non significant changes according to clang's -Weverything, part 2 [#CLICKHOUSE-2] 2018-06-03 20:43:56 +03:00
alexey-milovidov
02f7277dc7
Update ReplicatedMergeTreeQueue.h 2018-06-01 21:06:43 +03:00
Alexey Zatelepin
af06ca5d3c Merge branch 'master' into replicated-mergetree-mutations 2018-06-01 16:21:14 +03:00
Alexey Milovidov
f45c479a8b Removed wrong query optimization [#CLICKHOUSE-3726] 2018-05-31 21:28:04 +03:00
Alexey Zatelepin
f63d2dc3c8 cannot take a number of unlocked abandonable lock 2018-05-31 20:28:17 +03:00
Alexey Zatelepin
c9bb986330 Merge branch 'master' into replicated-mergetree-mutations
Conflicts:
	dbms/src/Storages/MergeTree/AbandonableLockInZooKeeper.h
	dbms/src/Storages/MergeTree/ReplicatedMergeTreePartCheckThread.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeQueue.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeQueue.h
	dbms/src/Storages/StorageReplicatedMergeTree.cpp
2018-05-31 18:52:42 +03:00
Alexey Zatelepin
dbf6949e0b support skipping mutations (just in case) [#CLICKHOUSE-3747] 2018-05-31 18:21:00 +03:00
Babacar Diassé
3d518e48b9 NULL check to allow insertion in distributed tables with Materialized views 2018-05-31 17:21:35 +03:00
Vitaliy Lyudvichenko
dc5de3bbec More optimal conflicts check in future_parts. [#CLICKHOUSE-2] 2018-05-31 17:14:50 +03:00
Vitaliy Lyudvichenko
888f5f4a24 Allow merges after CLEAR COLUMN. [#CLICKHOUSE-3]
Resolves #2315
2018-05-31 17:14:50 +03:00
Alexey Zatelepin
d89221c458 easier init and deactivation of BackgroundSchedulePool tasks 2018-05-31 16:18:52 +03:00
LiuYangkuan
7eb25ef55b fix Exception in issue#2439 2018-05-30 11:11:53 -04:00
Alexey Zatelepin
f6c72f8e56 Merge branch 'master' into replicated-mergetree-mutations
Conflicts:
	dbms/src/Common/ActionBlocker.h
	dbms/src/Storages/MergeTree/ActiveDataPartSet.cpp
	dbms/src/Storages/MergeTree/ActiveDataPartSet.h
	dbms/src/Storages/MergeTree/MergeTreeData.h
	dbms/src/Storages/MergeTree/MergeTreeDataPart.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeAlterThread.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeLogEntry.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeLogEntry.h
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeQueue.cpp
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeQueue.h
	dbms/src/Storages/MergeTree/ReplicatedMergeTreeRestartingThread.cpp
	dbms/src/Storages/StorageMergeTree.cpp
	dbms/src/Storages/StorageReplicatedMergeTree.cpp
	dbms/src/Storages/StorageReplicatedMergeTree.h
2018-05-28 18:37:30 +03:00
Alexey Zatelepin
59fe12ed15 part log and metrics [#CLICKHOUSE-3747] 2018-05-25 23:13:00 +03:00
Alexey Zatelepin
aff6ad42ed support empty parts [#CLICKHOUSE-3747] 2018-05-25 23:13:00 +03:00
Alexey Zatelepin
2b80fbf972 DROP PARTITION now works with mutated parts [#CLICKHOUSE-3747] 2018-05-25 23:13:00 +03:00
Alexey Zatelepin
fdb33d8f3c execute mutation log entries [#CLICKHOUSE-3747] 2018-05-25 23:13:00 +03:00
Alexey Zatelepin
fd81cc7f66 mutation executor for MergeTree [#CLICKHOUSE-3747] 2018-05-25 23:13:00 +03:00
Alexey Zatelepin
1147e052e8 select and write part mutations to queue [#CLICKHOUSE-3747] 2018-05-25 23:13:00 +03:00
Alexey Zatelepin
41b7e533cd more honest constness in ActionBlocker 2018-05-25 23:06:36 +03:00
Alexey Zatelepin
2721daf782 don't select merges of parts with different mutation versions [#CLICKHOUSE-3747] 2018-05-25 23:06:28 +03:00
Alexey Zatelepin
4c661df146 notify relevant events directly from queue [#CLICKHOUSE-3747] 2018-05-25 23:06:23 +03:00
Alexey Zatelepin
42850f09b7 load mutations from ZK [#CLICKHOUSE-3747] 2018-05-25 23:06:15 +03:00
Alexey Zatelepin
49439aa2d2 write mutations to ZK [#CLICKHOUSE-3747] 2018-05-25 23:06:08 +03:00
Alexey Zatelepin
4ca3bf65f3 test getting abandonable lock in all partitions [#CLICKHOUSE-3747] 2018-05-25 23:05:10 +03:00
Alexey Zatelepin
9a32c76e76 parts versioning [#CLICKHOUSE-3687] 2018-05-25 23:04:07 +03:00
Alexey Zatelepin
17437a95bf merge selection based on checking current inserts [#CLICKHOUSE-3732] 2018-05-25 23:03:56 +03:00
alexey-milovidov
dcebf08620
Merge pull request #2400 from bocharov/master
Fix DateTime vs DateTime('UTC') inconsistency on data read.
2018-05-25 21:44:11 +03:00
Alexey Milovidov
13762471da Changed DayNum_t to DayNum as Amos Bird suggested [#CLICKHOUSE-3] 2018-05-25 16:29:15 +03:00
Vitaliy Lyudvichenko
87ad1df259 More atomic insert to MATERIALIZED VIEW. [#CLICKHOUSE-3743] 2018-05-23 19:18:04 +03:00
Alex Bocharov
3618842579 Fix DateTime vs DateTime('UTC') inconsistency on data read.
Original problem was described in PR #1650 and partially fixed by
b5af4c95, however one place was forgotten and it was causing query
exceptions when trying to read DateTime column across parts with
different DateTime and DateTime('UTC') data type.
2018-05-22 12:23:07 +01:00
alexey-milovidov
55cfebc36b
Merge pull request #2395 from yandex/string_range-pointers-comparsion
Renamed StringRangeHash to StringRangePointersHash and added StringRa…
2018-05-21 22:42:42 +03:00
Vitaliy Lyudvichenko
8349d2b9a0 Fixed gcc7 compilation. [#CLICKHOUSE-2] 2018-05-21 18:10:50 +03:00