thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-30 19:42:00 +00:00
Code Issues Packages Projects Releases Wiki Activity
118,055 Commits 9,190 Branches 1,782 Tags 2.2 GiB
bd88a2195a
Commit Graph

43194 Commits

Author SHA1 Message Date
Nikolai Kochetov
22e49748b5 Cleanup. 2023-06-22 14:23:04 +00:00
Smita Kulkarni
3c7d749d2c Added check of StorageView before checking parameterized view to fix seg fault when materialized view is used with brackets 2023-06-22 14:47:04 +02:00
Sema Checherinda
d0bb985061 fix other classes based on SinkToStorage 2023-06-22 14:33:25 +02:00
Anton Popov
ee68e85d31 better reporting of broken parts 2023-06-22 12:25:45 +00:00
Alexander Tokmakov
0ffeecde6a
Merge branch 'master' into tavplubix-patch-6 2023-06-22 14:59:06 +03:00
Alexander Tokmakov
35c5483ad2
Update WriteBufferFromOStream.cpp 2023-06-22 14:56:20 +03:00
Robert Schulze
a9f1393862
Make the fix more minimal 2023-06-22 11:46:27 +00:00
Robert Schulze
a1c131c0da
Query Cache: Try to fix bad cast from ColumnConst to ColumnVector<char8_t> 
Resolves #49445

The query cache buffers query result chunks and eventually squashes
them before insertion into the cache. Here, squashing failed because not
all chunks were of the same type. Looks like chunks of the same
underlying type (e.g. UInt8) in a query result be of mixed const, sparse
or low-cardinality type. Fix this by always materializing the data
regardless of the compression. Strange thing is that the failing query
in the stress test (*) isn't able to reproduce the bug, and I haven't
managed to trigger the issue otherwise, so no test case is added.

(*) SELECT 1 UNION ALL SELECT 1 INTERSECT SELECT 1
    E.g. here: https://s3.amazonaws.com/clickhouse-test-reports/0/18817517ed6f8849e3d979e10fbb273e0edf0eaa/stress_test__debug_/fatal_messages.txt
 2023-06-22 11:46:22 +00:00
kssenii
8ff8125ebd Better 2023-06-22 13:25:47 +02:00
kssenii
4fbf52f2de Less loggers 2023-06-22 13:08:53 +02:00
Alexander Tokmakov
6929a9b852
Update WriteBufferFromOStream.cpp 2023-06-22 14:01:28 +03:00
Sema Checherinda
95349a405b release buffers with exception context 2023-06-22 13:00:13 +02:00
Kseniia Sumarokova
b7ef782335
Merge pull request #51242 from kssenii/fix-possible-incorrect-elements-limit 
Fix sometimes incorrect current_elements count in fs cache
 2023-06-22 12:51:43 +02:00
Igor Nikonov
9d9c9ccaff
Merge pull request #51259 from ClickHouse/cache-eviction-improve-hot-path 
FileCache: tryReserve() slight improvement
 2023-06-22 12:41:01 +02:00
Anton Kozlov
0c440b9d6f Report loading status for executable dictionaries correctly 2023-06-22 10:28:13 +00:00
Nikolai Kochetov
a940031878 Merge branch 'master' into refactor-subqueries-for-in 2023-06-22 12:18:48 +02:00
Mikhail f. Shiryaev
02776b8a15
Merge pull request #51163 from ClickHouse/fasttest-ignore-chown-fail 
Ignore errors for `chown` in fasttests
 2023-06-22 09:51:57 +02:00
Alexander Gololobov
a604a1de0b
Merge pull request #51238 from ClickHouse/zookeeper_fail_on_get_api_version_error 
Drop session if we fail to get Keeper API version
 2023-06-22 08:06:50 +02:00
LiuNeng
bcdf5f37ee
Merge branch 'master' into fix_core_dump_when_compile_expression 2023-06-22 12:13:55 +08:00
Michael Kolupaev
c96a3a8b15 Unforget to pass callback to readBigAt() in ParallelReadBuffer 2023-06-21 17:14:19 -07:00
Alexey Milovidov
a050b9e9d9
Update FileCache.cpp 2023-06-22 01:28:52 +03:00
Igor Nikonov
e3b43c2b88 Move instead of copy 2023-06-21 21:54:44 +00:00
Igor Nikonov
ad0677147f Trying slightly improve eviction path 
+ less copying of shared pointers
+ less indirection in overflow check
 2023-06-21 21:48:58 +00:00
Nikolai Kochetov
0af028ab3f Refactor a bit more. 2023-06-21 20:55:27 +00:00
Sema Checherinda
23120c4467 fix build 2023-06-21 22:32:33 +02:00
Sema Checherinda
679f2c4aa4
Merge branch 'master' into memory-leak 2023-06-21 22:22:11 +02:00
Alexander Gololobov
333483bdce
Merge pull request #49181 from ClickHouse/get_rid_of_delete_on_destroy_marker 
Deprecate delete-on-destroy.txt
 2023-06-21 22:20:57 +02:00
Smita Kulkarni
5229544b55 Added function getCurrrentBatchAndScheduleNext to IObjectStorageIteratorAsync 2023-06-21 22:17:39 +02:00
Sema Checherinda
c2fa7a1030
Merge branch 'master' into memory-leak 2023-06-21 21:15:01 +02:00
Sema Checherinda
01de36f1fa
Merge pull request #50395 from CheSema/better-log 
require `finalize()` call before d-tor for all writes buffers
 2023-06-21 21:12:02 +02:00
Alexander Tokmakov
50ee424148 do not update digest during recovery 2023-06-21 21:07:59 +02:00
kssenii
78ea4feca0 Merge remote-tracking branch 'upstream/master' into delete-non-evictable-feature 2023-06-21 20:52:08 +02:00
Alexander Tokmakov
9240a82c64
Update DatabaseReplicated.cpp 2023-06-21 21:49:00 +03:00
kssenii
9aa4647f4f Delete feature 2023-06-21 20:48:12 +02:00
Sergei Trifonov
99c6bdca24
Merge branch 'master' into fix-flaky-asyncloader-stop 2023-06-21 20:43:42 +02:00
Kseniia Sumarokova
45d7f39566
Merge pull request #51222 from ClickHouse/kssenii-patch-7 
Disable cache setting do_not_evict_index_and_mark_files
 2023-06-21 20:17:33 +02:00
Anton Popov
022b85ba0b
Merge pull request #51164 from CurtizJ/better-check-part-with-cache 
Better checking of data parts on disks with filesystem cache
 2023-06-21 20:08:53 +02:00
kssenii
38466169c7 Better 2023-06-21 20:07:45 +02:00
Alexey Milovidov
c54433a1ac
Merge pull request #51131 from ClickHouse/nickitat-patch-11 
Small fix in `MergeTreePrefetchedReadPool`
 2023-06-21 20:31:49 +03:00
Alexey Milovidov
f0d93d5b60
Merge pull request #51199 from ClickHouse/empty_array_get_name 
Avoid initializing DateLUT from emptyArray function registration
 2023-06-21 20:29:28 +03:00
Alexey Milovidov
e87b9ee846
Update AsyncLoader.cpp 2023-06-21 20:25:10 +03:00
kssenii
3ce17fd570 Fix log message 2023-06-21 18:30:46 +02:00
kssenii
509a50f651 Merge remote-tracking branch 'origin/fix-possible-incorrect-elements-limit' into fix-possible-incorrect-elements-limit 2023-06-21 18:29:16 +02:00
kssenii
b007c9f194 Review comments 2023-06-21 18:28:14 +02:00
Dmitry Novik
bb97332599
Merge pull request #50441 from Algunenano/parallel_replicas_analyzer 
Support parallel replicas with the analyzer
 2023-06-21 17:28:06 +02:00
Kseniia Sumarokova
d18da7098a
Update LRUFileCachePriority.cpp 2023-06-21 17:25:09 +02:00
serxa
1f901f4ec4 fix 2023-06-21 15:18:49 +00:00
serxa
c5ade1c8fc fix flaky AsyncLoader destructor 2023-06-21 15:16:18 +00:00
Alexander Gololobov
17a95a54e1
Merge pull request #51118 from ClickHouse/sys_zookeep_more_parallel_get 
Make more parallel get requests to ZooKeeper in system.zookeeper
 2023-06-21 17:07:21 +02:00
Sergei Trifonov
dfa39e2e7b
Merge branch 'master' into refactor-settings-enums 2023-06-21 16:48:14 +02:00
serxa
89f19fc912 fix values indexing 2023-06-21 14:47:47 +00:00
liuneng
3224e49757 fix 2023-06-21 22:46:41 +08:00
kssenii
b723f9e7bf Fix sometimes not correct current_elements_num 2023-06-21 16:45:52 +02:00
Alexander Tokmakov
76e3d1e7b6
Revert "Fix a crash in s3 and s3Cluster functions" 2023-06-21 17:10:20 +03:00
Alexander Gololobov
6ebeb93a1a Drop session if we fail to get API version 2023-06-21 16:05:48 +02:00
serxa
3157f29a46 introduce settings enum field with auto-generated values list 2023-06-21 13:25:10 +00:00
Kseniia Sumarokova
5c38231a14
One more profile event for fs cache (#51223) 2023-06-21 15:18:25 +02:00
liuneng
e650a6094a fix core dump when compile expression 2023-06-21 20:28:27 +08:00
Alexander Gololobov
a708adecee Pass element type as param to ctor 2023-06-21 14:04:45 +02:00
Andrey Zvonov
b4f2e4020d
Merge branch 'master' into zvonand-implicit-tz 2023-06-21 13:41:35 +02:00
Mikhail f. Shiryaev
4fb2dc8384
Decrease default settings for http headers name and value to 128K 2023-06-21 12:59:27 +02:00
Kruglov Pavel
bbd70932e2
Merge pull request #51158 from Avogar/extend-progress-protocol 
Add total_bytes_to_read to Progress packet in TCP protocol for better progress bar
 2023-06-21 12:43:45 +02:00
Kruglov Pavel
8f8cd97fd8
Merge pull request #51088 from Avogar/better-progress-bar 
Improve progress bar for file/s3/hdfs/url table functions. Step 1
 2023-06-21 12:42:25 +02:00
Sema Checherinda
4d08df8d29 fix finalization of cascade write buffer 2023-06-21 12:27:39 +02:00
Alexander Gololobov
a23caab98c
Merge branch 'master' into sys_zookeep_more_parallel_get 2023-06-21 12:16:57 +02:00
Nikolay Degterinsky
50c114f081
Merge pull request #51209 from evillique/fix-s3-function 
Fix a crash in s3 and s3Cluster functions
 2023-06-21 11:59:42 +02:00
Nikolai Kochetov
0149f905de
Update MergeTreeIndexSet.cpp 2023-06-21 11:26:54 +02:00
Alexander Tokmakov
8896e90ad6
Merge pull request #51207 from ClickHouse/fix_lost_forever_check 
Suppress check for covered parts in ZooKeeper
 2023-06-21 12:26:09 +03:00
Robert Schulze
dcfcbd8345
Merge remote-tracking branch 'rschu1ze/master' into inefficient-query-cache 2023-06-21 09:23:31 +00:00
Kseniia Sumarokova
b60520ec55
Disable cache setting do_not_evict_index_and_mark_files 2023-06-21 11:15:55 +02:00
Robert Schulze
9b959eb1fb
Merge pull request #49577 from tpanetti/mysql_compatible_types 
Change SHOW COLUMNS query to display MySQL types in MySQL Compatibility mode
 2023-06-21 11:04:22 +02:00
Robert Schulze
06e8590c8e
Merge pull request #50775 from rschu1ze/non-experimental-qpl-deflate 
Mark QPL_DEFLATE non-experimental but default: off-by-default
 2023-06-21 10:43:16 +02:00
alekar
c88c57d599
Merge branch 'master' into improve-outfile 2023-06-21 01:17:54 -07:00
Manas Alekar
44798971f9 Fix a test, add APPEND to suggest. 2023-06-20 22:10:39 -07:00
Nikolay Degterinsky
150007bfc5
Merge branch 'master' into fix-s3-function 2023-06-21 03:04:59 +02:00
Nikolay Degterinsky
75b266e179 Fix crash in s3 and s3Cluster functions 2023-06-21 00:04:11 +00:00
Kseniia Sumarokova
9329cab0ca
Merge branch 'master' into add-logging-for-logical-error 2023-06-21 00:16:15 +02:00
Alexander Tokmakov
f973bd7516 suppress check for covered parts in zk 2023-06-20 23:53:32 +02:00
Alexey Milovidov
0349315143
Merge pull request #50797 from jrdi/fix-summing-mt-dt64 
SummingMergeTree support for DateTime64
 2023-06-20 23:02:21 +03:00
Nikolai Kochetov
266e81702a Fixing clang-tidy 2023-06-20 19:48:39 +00:00
Nikolai Kochetov
5bda0b535d Fixing build. 2023-06-20 19:45:03 +00:00
Nikolai Kochetov
e4f057e304 Fix Set index with constant nullable comparison. 2023-06-20 19:40:37 +00:00
Nikolai Kochetov
c0b1d7f4f2 Fixing 01774_tuple_null_in 2023-06-20 19:12:22 +00:00
Sema Checherinda
9b0c3359cf
Merge branch 'master' into better-log 2023-06-20 20:37:36 +02:00
Alexey Milovidov
ced1ae7287
Update emptyArray.cpp 2023-06-20 21:20:25 +03:00
Alexey Milovidov
c097e6e53d
Merge pull request #50531 from kitaisreal/jit-infrastructure-refactoring 
JIT infrastructure refactoring
 2023-06-20 21:13:44 +03:00
Robert Schulze
bc7df2baca
Merge branch 'master' into non-experimental-qpl-deflate 2023-06-20 20:06:01 +02:00
Sema Checherinda
fd292dc730 work with comment on the PR 2023-06-20 20:02:04 +02:00
Nikolai Kochetov
5a1f819e7b Fix more tests. 2023-06-20 17:33:09 +00:00
Alexander Gololobov
29f6ce871d Avoid initializing DateLUT from emptyArray function registration 2023-06-20 19:00:41 +02:00
Nikolai Kochetov
518ba6cbf6 Fix more tests. 2023-06-20 16:43:22 +00:00
Alexander Gololobov
7a1f8547f3 Simplify the code 2023-06-20 17:18:05 +02:00
Alexander Gololobov
816c6cdeb1 Simplify the code by using tryGetChildren 2023-06-20 16:56:50 +02:00
Nikolai Kochetov
b4273a1963 Fixing some tests. 2023-06-20 14:53:13 +00:00
Kruglov Pavel
0edfbb45ad
Merge pull request #50873 from Avogar/parquet-big-integers 
Fallback to parsing big integer from String instead of exception in Parquet format
 2023-06-20 16:10:46 +02:00
郭小龙
154d19ce72
The time format (connected_time field) is incorrect (#51026) 
* The time format (connected_time field) is incorrect

* Change the description and increase the field list display

* Update 02735_system_zookeeper_connection.reference

* Update 02735_system_zookeeper_connection.sql

* Update 02735_system_zookeeper_connection.sql

* Update 02735_system_zookeeper_connection.reference

* fix test

---------

Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
 2023-06-20 16:57:55 +03:00
Anton Popov
31ece0c512 add test for check part with cache 2023-06-20 13:28:01 +00:00
Alexander Tokmakov
bca0d76cbf
Merge pull request #50107 from ClickHouse/rmt_better_background_tasks_scheduling 
Improve scheduling of background tasks in ReplicatedMergeTree
 2023-06-20 16:25:19 +03:00
avogar
1d80072c21 Fix tests and builds 2023-06-20 13:01:47 +00:00
kssenii
fcb793dc02 Update exception 2023-06-20 14:26:09 +02:00
Kseniia Sumarokova
c3227fd44f
Merge pull request #51161 from kssenii/more-metrics-in-cache 
More profile events for fs cache
 2023-06-20 12:44:00 +02:00
Maksim Kita
7e5017dd31 Fixed tests 2023-06-20 11:42:22 +03:00
Maksim Kita
aa28a1f259 Fixed tests 2023-06-20 11:42:22 +03:00
Maksim Kita
6e26fde707 Updated tests 2023-06-20 11:42:22 +03:00
Maksim Kita
129b97c727 JIT infrastructure refactoring 2023-06-20 11:42:22 +03:00
zvonand
4754d7863c small 2023-06-20 03:21:03 +02:00
Andrey Zvonov
07191ce10d
Merge branch 'master' into zvonand-implicit-tz 2023-06-20 00:24:53 +02:00
Jordi Villar
6182a71c4d
Merge branch 'master' into fix-summing-mt-dt64 2023-06-19 21:15:23 +02:00
Nikolai Kochetov
7280078bc6 Refactoring a bit more. 2023-06-19 19:01:56 +00:00
kssenii
7f9cd56f61 One more 2023-06-19 19:22:45 +02:00
Han Fei
959f66eb8a
Merge pull request #50697 from kitaisreal/sort-block-improvements 
Sort block improvements
 2023-06-19 19:02:03 +02:00
Anton Popov
1ef19dbe4d drop cache on check of broken part 2023-06-19 16:32:51 +00:00
kssenii
ec86028fd8 Change to microseconds 2023-06-19 17:48:56 +02:00
kssenii
0ca2916163 More metrics in cache 2023-06-19 17:22:41 +02:00
Sergei Trifonov
5867f39fc7
Merge pull request #50675 from ClickHouse/unify-priorities-pools 
Unify priorities for connection pools
 2023-06-19 17:16:15 +02:00
Alexander Gololobov
44f1f036e8 Use multi-read requests for list and get 2023-06-19 16:47:17 +02:00
avogar
cf8f277c32 Add total_bytes_to_read to TCP protocol for better Progress bar 2023-06-19 13:58:08 +00:00
avogar
d492acbcd2 Fix tests 2023-06-19 13:36:29 +00:00
Nikolai Kochetov
8e7d06e0a4 Remove isReady from FutureSet iface. 2023-06-19 12:56:24 +00:00
Alexey Milovidov
f9558345e8
Merge pull request #51138 from ClickHouse/print-changed-settings 
Print changed settings on fatal errors
 2023-06-19 15:50:44 +03:00
Nikolai Kochetov
f3398f9908 Try to make more consisten type check for sets. 2023-06-19 12:17:52 +00:00
Raúl Marín
8fdcca4326
Merge branch 'master' into parallel_replicas_analyzer 2023-06-19 13:54:59 +02:00
Nikita Taranov
90ced1aebc use int64 2023-06-19 13:48:52 +02:00
Sema Checherinda
a2d5c91a28 cancel temp part with exception context when deduplication triggered 2023-06-19 12:52:20 +02:00
Nikolai Kochetov
880c9aea09 Fixing style. 2023-06-19 10:47:43 +00:00
Alexander Tokmakov
a00842498e Merge branch 'master' into rmt_better_background_tasks_scheduling 2023-06-19 12:37:17 +02:00
Alexander Tokmakov
caceb7c862
Revert "Added ability to implicitly use file/hdfs/s3 table functions in clickhouse-local" 2023-06-19 13:21:09 +03:00
Maksim Kita
4c72995537 Fixed build 2023-06-19 13:02:35 +03:00
Jordi Villar
5e77fa6c87
Merge branch 'master' into fix-summing-mt-dt64 2023-06-19 08:26:36 +02:00
Alexey Milovidov
dcd4cfa5c2 Fix build 2023-06-19 03:28:59 +02:00
jinjunzh
004755914e change to use generic MSan API to bypass uninitialized memory check 2023-06-18 20:55:10 -04:00
Sema Checherinda
e3f892f84a fix gtest with MemoryWriteBuffer, do not mute exception in ReplicatedMergeMutateTaskBase 2023-06-19 00:10:42 +02:00
Alexey Milovidov
9ae4915655 Code simplification 2023-06-18 21:08:37 +02:00
Sema Checherinda
2bbfa279ec fix gtest_lru_file_cache, fix remove from pending 2023-06-18 21:05:00 +02:00
Alexey Milovidov
b19b87a3e5 Whitespaces 2023-06-18 20:42:27 +02:00
Alexey Milovidov
a6dde6ab62 Print changed settings on fatal errors 2023-06-18 20:38:25 +02:00
Sema Checherinda
ce7cd67981 finalize CascadeWriteBuffer 2023-06-18 17:35:12 +02:00
Maksim Kita
977cd65cfb Fixed build 2023-06-18 12:52:08 +03:00
Maksim Kita
2f3dce5fe6 Fixed tests 2023-06-18 12:52:08 +03:00
Maksim Kita
7d17a70d17 Fixed tests 2023-06-18 12:52:08 +03:00
Maksim Kita
8d3212363e Fixed tests 2023-06-18 12:52:08 +03:00
Maksim Kita
ca298d66cb Sort block improvements 2023-06-18 12:52:08 +03:00
Alexander Gololobov
59c11cb150 Make more parallel get requests to ZooKeeper 2023-06-18 08:26:37 +02:00
Alexey Milovidov
ce38d64c5a
Merge pull request #50856 from ClickHouse/relax-too-many-parts 
Relax "too many parts" further
 2023-06-18 01:49:46 +03:00
Sema Checherinda
642734e512 fix shell commands source 2023-06-17 23:48:09 +02:00
Robert Schulze
5311ebe1d2
Make query cache work effective with nested queries. 2023-06-17 20:27:25 +00:00
Alexander Tokmakov
b4e455430c
Merge branch 'master' into rmt_better_background_tasks_scheduling 2023-06-17 22:19:21 +03:00
Robert Schulze
24717ed908
Factorize check if query cache exists 2023-06-17 18:24:20 +00:00
Robert Schulze
69e7c1cc82
Introduce convenience ctor for Key construction during read 2023-06-17 18:22:15 +00:00
Alexey Milovidov
c7a18c640e Slightly better diagnostics 2023-06-17 17:20:44 +02:00