Commit Graph

2023 Commits

Author SHA1 Message Date
Han Fei
171bf4f201 Merge branch 'master' into hanfei/fix-intersection 2024-05-15 13:59:52 +02:00
Sergei Trifonov
e8d43fa572
Merge pull request #63404 from ClickHouse/fix-oklch-for-firefox
Workaround for `oklch()` inside canvas bug for firefox
2024-05-10 12:05:35 +00:00
Han Fei
116055b532 refine load part logic 2024-05-08 15:04:16 +02:00
serxa
48d6c3760d workaround for oklch() inside canvas bug for firefox 2024-05-06 12:05:37 +00:00
Alexey Milovidov
ed1bbd0bd0 Merge branch 'master' into local-less-directories 2024-05-03 02:35:44 +02:00
alesapin
eacbf5fe10 Fix premature server listen for connections 2024-04-30 14:32:03 +02:00
Alexey Milovidov
39118ef461 Hopefully better 2024-04-27 18:47:03 +02:00
Konstantin Bogdanov
38e8b4991e
Undo breaking change 2024-04-22 00:01:33 +02:00
Anton Popov
f09d0b6536
Merge pull request #62608 from CurtizJ/azure-retries
Better retries in azure sdk
2024-04-19 12:01:42 +00:00
jsc0218
7525b2acf4
Merge pull request #60117 from jsc0218/TableEngineGrant_version2
TableEngineGrant_version2
2024-04-18 14:30:34 +00:00
Anton Popov
b50117780c Merge remote-tracking branch 'upstream/master' into HEAD 2024-04-17 13:05:46 +00:00
János Benjamin Antal
599e928e1f
Merge pull request #61997 from azat/sentry-logical-error
[RFC] Send LOGICAL_ERRORs to sentry
2024-04-16 12:26:42 +00:00
Robert Schulze
7dc05d092b
Merge remote-tracking branch 'rschu1ze/master' into be-less-boring-32 2024-04-15 16:35:10 +00:00
Robert Schulze
2a3b5bd74d
Merge pull request #58956 from AVMusorin/kafka-settings
Separate consumer/producer settings for Kafka
2024-04-15 15:11:19 +00:00
Anton Popov
9e54a833ed fix build 2024-04-12 18:41:40 +00:00
Anton Popov
47c653f87c better retries in azure sdk 2024-04-12 15:39:14 +00:00
Azat Khuzhin
f1cb1f80b6 Make sending LOGICAL_ERRORs to sentry configurable
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-11 15:56:26 +02:00
Alexander Tokmakov
d8e97b51bf Merge branch 'master' into cannot_allocate_thread 2024-04-10 21:21:42 +02:00
Nikita Taranov
a2147b8ded
Merge branch 'master' into keep_alive_max_reqs 2024-04-09 21:32:36 +02:00
Robert Schulze
dca6e0abbd
Fix the build (after boringssl submodule removal) 2024-04-08 11:02:41 +00:00
alesapin
e514a8b49d Merge remote-tracking branch 'origin/master' into try_global_trace_collector 2024-04-05 12:40:25 +02:00
Alexander Tokmakov
c53b20a770 fix 2024-04-03 20:57:12 +02:00
Alexander Tokmakov
98ac8031e0 add fault injection 2024-04-03 19:49:23 +02:00
jsc0218
ee589f8a8b Merge remote-tracking branch 'origin/master' into TableEngineGrant_version2 2024-04-03 17:17:33 +00:00
yariks5s
ca27cf3fde fix mapper for gcs 2024-04-03 16:38:41 +00:00
alesapin
f5c5146153 [RFC] Try to add global Real and CPU trace collector 2024-04-02 18:04:53 +02:00
Aleksandr Musorin
f9d81bc774 refactore: improve reading several configurations for kafka
Simplify and do some refactoring for kafka client settings.

Allows to set up separate
settings for consumer and producer like:

```
<consumer>
    ...
</consumer>

<producer>
    <kafka_topic>
        <name>topic_name</name>
        ...
    </kafka_topic>
</producer>
```

Moreover, this fixes warnings from kafka client like:
`Configuration property session.timeout.ms is a consumer property and
will be ignored by this producer instance`
2024-03-27 14:53:33 +01:00
Nikita Taranov
d7b34a80bb stash 2024-03-22 16:09:14 +00:00
serxa
c31b958f88 Merge branch 'master' into async-loader-waiters-limit 2024-03-21 10:58:22 +00:00
Raúl Marín
de855ca917 Reduce header dependencies 2024-03-19 17:04:29 +01:00
Han Fei
8a54c85f3c
Merge pull request #61049 from hanfei1991/hanfei/check-limit-periodically
Check cgroups memory limit update periodically
2024-03-18 15:15:46 +01:00
Robert Schulze
fe86741059
Some fixups 2024-03-18 10:44:56 +00:00
jsc0218
c5dc35e5c4 try enable grant of table engine in test 2024-03-14 01:31:45 +00:00
jsc0218
b3b46ea708 Merge remote-tracking branch 'origin/master' into TableEngineGrant_version2 2024-03-14 00:36:29 +00:00
Robert Schulze
4e12b5dc91
Some fixups 2024-03-13 16:54:20 +00:00
Robert Schulze
ce665eae30
Doc fixups 2024-03-13 15:13:17 +00:00
alesapin
9b1d8a2f52 fix style 2024-03-13 14:15:34 +01:00
alesapin
6203d45b96 working version with comments 2024-03-13 13:12:48 +01:00
Han Fei
c7c64636d0 add a test 2024-03-12 23:31:33 +01:00
Nikita Mikhaylov
cfa042cb04 Merge branch 'master' of github.com:ClickHouse/ClickHouse into rip-copier 2024-03-11 15:45:20 +00:00
serxa
5b796e1f42 Merge branch 'master' into async-loader-waiters-limit 2024-03-10 15:20:27 +00:00
Sema Checherinda
80179e50e4
Merge pull request #58845 from ClickHouse/chesema-session-pool
HTTP connections pool
2024-03-10 14:06:59 +01:00
Sema Checherinda
5c41727725 http connections pools 2024-03-10 10:00:18 +01:00
Alexey Milovidov
3b8a8c9649 Better gitignore 2024-03-10 09:28:30 +01:00
Han Fei
c01a6775d7 fix style 2024-03-09 02:28:39 +01:00
Han Fei
4997f95426 fix build 2024-03-08 17:30:58 +01:00
Han Fei
c92fb8700f Merge branch 'master' into hanfei/check-limit-periodically 2024-03-08 03:59:41 +01:00
Nikita Mikhaylov
2bc4d27ac6 Bye bye 2024-03-07 19:24:39 +00:00
serxa
0f0ea422f2 separate limits on number of waiting and executing queries 2024-03-07 17:05:54 +00:00
Han Fei
7fd13df8a5 check memory limit periodically 2024-03-07 17:21:03 +01:00
Robert Schulze
b5a7ef5fd3
Merge remote-tracking branch 'rschu1ze/master' into clang-tidy-hdr 2024-03-05 11:24:28 +00:00
Alexey Milovidov
a7430004b3 Fix real time query profiler on AArch64 2024-03-04 18:13:49 +01:00
Alexey Milovidov
de6c5d3a40
Merge pull request #60552 from ClickHouse/pc2
Userspace page cache again
2024-03-04 17:47:35 +03:00
Alexey Milovidov
c7fb3014ad Merge branch 'master' into async-load-by-default 2024-03-03 19:41:31 +01:00
Alexey Milovidov
079f5af0a8 Merge branch 'master' into async-load-by-default 2024-03-03 05:40:48 +01:00
Alexey Milovidov
4b69440e58 Dashboard: sticky header 2024-03-03 04:35:15 +01:00
Alexey Milovidov
e122a47b48 Simplification 2024-03-03 04:12:31 +01:00
Alexey Milovidov
df53b0c5f8 Merge branch 'master' into slightly-better-colors-on-dashboard 2024-03-03 04:09:09 +01:00
jsc0218
2b54c11d63
Merge branch 'ClickHouse:master' into TableEngineGrant_version2 2024-03-02 20:42:04 -05:00
Alexey Milovidov
c362bbc9ca
Merge pull request #60390 from ClickHouse/redirect-handlers
Allow configuring HTTP redirect handlers for clickhouse-server
2024-03-02 05:15:31 +03:00
Alexey Milovidov
e9fd11beea
Merge pull request #60624 from bluikko/patch-1
Fix typo in config.xml #60623
2024-03-02 04:52:56 +03:00
Robert Schulze
af6755f241
Merge remote-tracking branch 'rschu1ze/master' into clang-tidy-hdr 2024-03-01 11:45:21 +00:00
bluikko
1aea952382
Fix typo in config.xml #60623
"be Tableau" should be "by Tableau".
2024-03-01 16:13:45 +07:00
Robert Schulze
562e483df4
Merge remote-tracking branch 'rschu1ze/master' into clang-tidy-hdr 2024-02-29 12:44:51 +00:00
Michael Kolupaev
42437a2ae1 Userspace page cache (#53770)
* Userspace page cache

* Maybe it'll build this time, who knows.

* 'auto' went out of fashion, I guess

* Documentation, tsan workaround, metric 'UnreclaimableRss', disable page cache in the test that uses DatabaseOrdinary

* Moved CachedInMemoryReadBufferFromFile to object store level, changed settings, addressed other comments.

* Fix

* Another fix

* Fix restricted seek, fix ppc64le build

* Don't allow page cache with file cache

* Adjust tests a little

* Fix clang-tidy

* Conflicts

* Comments

* Maybe unbroke AsynchronousBoundedReadBuffer

* SettingsChangesHistory.h

* Fix warning in test
2024-02-29 12:28:32 +00:00
Alexander Tokmakov
15e1191f74
Revert "Userspace page cache (#53770)"
This reverts commit 7b55c61551.
2024-02-29 13:20:17 +01:00
Robert Schulze
070f9d952f
Merge remote-tracking branch 'ClickHouse/master' into feature/increase_dns_cache_size 2024-02-29 11:27:59 +00:00
Michael Kolupaev
7b55c61551
Userspace page cache (#53770)
* Userspace page cache

* Maybe it'll build this time, who knows.

* 'auto' went out of fashion, I guess

* Documentation, tsan workaround, metric 'UnreclaimableRss', disable page cache in the test that uses DatabaseOrdinary

* Moved CachedInMemoryReadBufferFromFile to object store level, changed settings, addressed other comments.

* Fix

* Another fix

* Fix restricted seek, fix ppc64le build

* Don't allow page cache with file cache

* Adjust tests a little

* Fix clang-tidy

* Conflicts

* Comments

* Maybe unbroke AsynchronousBoundedReadBuffer

* SettingsChangesHistory.h

* Fix warning in test
2024-02-29 11:27:32 +00:00
Kirill Nikiforov
fe247cb64d rename dns_cache_max_size to dns_cache_max_entries 2024-02-29 06:03:44 +03:00
Robert Schulze
3b18eb4f17
Fix clang-tidy in some headers 2024-02-28 22:47:34 +00:00
jsc0218
b4b19ae2ad
Merge branch 'master' into TableEngineGrant_version2 2024-02-28 10:56:30 -05:00
Alexey Milovidov
8cf619bc03 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-28 00:30:44 +01:00
Alexey Milovidov
0721f524ce Merge branch 'master' into async-load-by-default 2024-02-27 02:19:32 +01:00
Alexey Milovidov
04fe5dc55c Merge branch 'master' into fix-inconsistent-formatting 2024-02-26 23:46:24 +01:00
Alexey Milovidov
fbfc4afb46
Merge branch 'master' into redirect-handlers 2024-02-27 01:27:38 +03:00
Robert Schulze
4794dc28f0
Merge remote-tracking branch 'ClickHouse/master' into dist/config-settings 2024-02-26 21:57:33 +00:00
Kirill Nikiforov
8b314a3ac8
Implement system.dns_cache table and dns_cache_max_size server setting (#60257)
* system.dns_cache table WIP

* system.dns_cache table

* rollback unexpected contrib changes

* rollback unexpected changes

* add docs

* code style fixes

* optimize dns cache exporting

* stateful test for system.dns_cache table

* stateful test for system.dns_cache table

* cr fixes

* stateful test for system.dns_cache table

* stateful test for system.dns_cache table

* implement system.dns_cache table

* system.dns_cache test

* system.dns_cache fix docs

* system.dns_cache prettify

* dns_cache_max_size settings

* fix system.dns_cache test

* Update dns_cache.md

* fix doc

Co-authored-by: pufit <pufit@clickhouse.com>

---------

Co-authored-by: pufit <pufit@clickhouse.com>
2024-02-26 15:48:02 -05:00
Alexey Milovidov
47734fbbe2
Merge pull request #60387 from ClickHouse/dashboard-more-convenient
Minor changes for dashboard
2024-02-26 22:52:44 +03:00
Alexey Milovidov
a3f1411679 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-26 19:01:11 +01:00
Alexey Milovidov
b71ae80fa9
Merge pull request #60392 from ClickHouse/fix-duplicate-chart-rendering
Fix duplicate and dangling charts on the Dashboard
2024-02-26 19:24:52 +03:00
Robert Schulze
048f7ec3e9
Merge pull request #59516 from rschu1ze/cgroup-observing-memory-tracker
Update memory tracker periodically with cgroup memory usage
2024-02-26 15:27:19 +01:00
Robert Schulze
1751d76234
Minor doc fixups 2024-02-26 11:42:11 +00:00
Robert Schulze
1e40b63cb1
Merge remote-tracking branch 'ClickHouse/master' into dist/config-settings 2024-02-26 11:15:51 +00:00
Alexey Milovidov
f9c0089526 Fix duplicate and dangling charts on the Dashboard 2024-02-26 01:31:29 +01:00
Alexey Milovidov
9d0e1c4deb Slightly better colors for multi-line graphs on the dashboard 2024-02-26 01:02:38 +01:00
Alexey Milovidov
2edb3d5ba1 Add documentation 2024-02-25 23:58:29 +01:00
Alexey Milovidov
b916479025 Add a test 2024-02-25 23:54:55 +01:00
Alexey Milovidov
27902ee4f6 Touch-up dashboard 2024-02-25 22:36:59 +01:00
Alexey Milovidov
9e32d0f5b2 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-23 15:05:46 +01:00
Vitaly Baranov
db119eed49
Merge pull request #60002 from vitlibar/add-config-setting-remove-backup-files-after-failure
Add new config setting "backups.remove_backup_files_after_failure"
2024-02-23 12:42:55 +01:00
János Benjamin Antal
7cad0050c0
Disambiguate alter commands list (#59532)
* Add optional parentheses to TTL element and alter command

* Add some basic tests

* Extend tests with more test cases

* Add one more test case

* Add server setting to control new formatting behavior

* Automatic style fix

* Fix segfault in `clickhouse-format` related to new server setting

* Remove format_ttl_expressions_with_parentheses

* Fix unit test compilation failures

* Introduce global flag to control the new formatting behavior

* Revert "Fix segfault in `clickhouse-format` related to new server setting"

This reverts commit d7131a3145.

* Revert accidental changes

* Revert accidental include reorder

* Revert accidental changes

* Enable new format in client and local server

---------

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
2024-02-22 19:17:15 +01:00
Vitaly Baranov
b130726a0c
Merge branch 'master' into add-config-setting-remove-backup-files-after-failure 2024-02-22 18:09:12 +01:00
Alexey Milovidov
2d9fbaa859 Merge with master 2024-02-21 20:37:48 +01:00
Alexander Tokmakov
64a80f1011
Fix default path when path is not specified in config (#59654)
* Update Server.cpp

* Update SentryWriter.cpp

* Update Keeper.cpp

* Update SentryWriter.cpp
2024-02-21 20:33:39 +01:00
Sergei Trifonov
6e3fddf4a3
Merge pull request #59313 from ClickHouse/abstract-concurrency-control
Split `ISlotControl` from `ConcurrencyControl`
2024-02-21 15:04:03 +01:00
Alexey Milovidov
c753550d0b Digging into a pile of garbage 2024-02-20 10:42:20 +01:00
jsc0218
afa7a95c8c add backward compatibility 2024-02-20 02:11:31 +00:00
Robert Schulze
ba9661a5d4
Merge remote-tracking branch 'rschu1ze/master' into cgroup-observing-memory-tracker 2024-02-19 09:54:08 +00:00
Alexey Milovidov
509d8ee99c Apply review comments 2024-02-17 01:54:54 +01:00
Alexey Milovidov
39f363ba6e Print CPU flags at startup 2024-02-16 13:09:07 +01:00
Alexey Milovidov
5b83e771ed Print CPU flags at startup 2024-02-16 13:06:57 +01:00
Konstantin Bogdanov
dbb6804a70
Merge pull request #59976 from ClickHouse/add-cloud-placement
Add `PlacementInfo`
2024-02-15 19:16:56 +03:00
Vitaly Baranov
5591d74076 Add new config setting "backups.remove_backup_files_after_failure". 2024-02-14 23:19:21 +01:00
Konstantin Bogdanov
914fd27d5b
Add PlacementInfo 2024-02-14 10:19:36 +01:00
Robert Schulze
7b7ea6d477
Merge remote-tracking branch 'rschu1ze/master' into cgroup-observing-memory-tracker 2024-02-14 08:56:22 +00:00
Alexey Milovidov
27f115f581 Use merge table in the dashboard 2024-02-14 02:17:23 +01:00
Azat Khuzhin
c61ac1d3bc Convert default_replica_path/default_replica_name into server settings
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 21:05:58 +01:00
Robert Schulze
3a4b6a2379
Merge remote-tracking branch 'rschu1ze/master' into cgroup-observing-memory-tracker 2024-02-10 13:53:19 +00:00
Azat Khuzhin
e6d96e4325 Better warning for disabled kernel.task_delayacct
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-10 14:49:43 +01:00
Robert Schulze
f6f1fd4d26
Initial implementation 2024-02-08 16:06:44 +00:00
serxa
0130d525f4 fix dashboard params default values 2024-02-08 12:02:28 +00:00
Konstantin Bogdanov
5894fa9860
0 means number of cores 2024-02-06 19:10:34 +01:00
Konstantin Bogdanov
f663f13a35
Merge pull request #59277 from ClickHouse/create-tables-in-threadpool
Concurrent tables creation in `recoverLostReplica`
2024-02-05 16:04:46 +03:00
serxa
9c93a76268 Fix backward incompatibility of dashboard url hashes 2024-02-04 12:50:26 +00:00
Amos Bird
e3716b0f38
Backward compatibility of uncompressed state 2024-02-04 11:03:18 +08:00
Alexey Milovidov
667256a67d Fixes for binary.html 2024-02-01 20:36:38 +01:00
Konstantin Bogdanov
5969668503
Concurrent table creation in DatabaseReplicated 2024-02-01 09:51:52 +01:00
Alexey Milovidov
a286d500c3
Merge pull request #59124 from amosbird/dashboard-compress-state
Compress state of dashboard
2024-01-30 08:05:38 +01:00
Alexey Milovidov
8085f5f142 Merge branch 'master' into async-load-by-default 2024-01-29 00:03:47 +01:00
Alexey Milovidov
aec3f28ccb Support backups for compressed in-memory tables 2024-01-28 23:06:50 +01:00
serxa
ba85642453 split ISlotControl from ConcurrencyControl 2024-01-28 20:26:55 +00:00
Alexey Milovidov
77de2b0ebc
Merge pull request #59311 from ClickHouse/binary-allow-user-host-password
`/binary` handler: allow specifying user/password/host
2024-01-28 20:33:39 +01:00
Alexey Milovidov
45cb7094af
Merge pull request #59303 from ClickHouse/play-rendering-errors-json
Play UI: improve rendering of errors from JSON formats
2024-01-28 18:32:27 +01:00
Alexey Milovidov
4dcf27e5b2 /binary: allow specifying user/password/host 2024-01-28 18:27:15 +01:00
Alexey Milovidov
9dd6362ae7 Play UI: improve rendering of errors from JSON formats 2024-01-28 13:44:56 +01:00
Azat Khuzhin
4248ae509a Support specifying settings for Distributed engine in config (like for MergeTree)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-27 18:06:16 +01:00
Azat Khuzhin
1404b73b50 Add example of configuring ReplicatedMergeTree via config.xml
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-27 17:03:18 +01:00
Sergei Trifonov
4fb511bfb3
Merge pull request #59137 from ClickHouse/fix-async-loader-shutdown-deadlock
Fix not started database shutdown deadlock
2024-01-26 11:21:13 +01:00
Maksim Kita
2a327107b6 Updated implementation 2024-01-25 14:31:49 +03:00
serxa
8728ab768f Fix not started database shutdown deadlock 2024-01-23 19:01:57 +00:00
Amos Bird
7e86c0e928
Compress state of dashboard 2024-01-23 23:04:19 +08:00
Robert Schulze
e23e7e6b73
Merge pull request #53710 from rschu1ze/system-reload-asynchronous-metrics
Add statement `SYSTEM RELOAD ASYNCHRONOUS METRICS`
2024-01-23 11:56:25 +01:00
serxa
7b99d9a176 wait for currently running jobs to finish #2 2024-01-22 23:50:53 +00:00
serxa
1d6d1182fd Fix server shutdown due to exception while loading metadata 2024-01-22 19:38:26 +00:00
Robert Schulze
90a0ea36b3
Add statement 'SYSTEM RELOAD ASYNCHRONOUS METRICS' 2024-01-22 17:14:58 +00:00
Vitaly Baranov
01aafda27b
Merge pull request #58804 from vitlibar/allow-kill-query-for-backups
Allow KILL QUERY for backups
2024-01-20 23:48:18 +01:00
robot-clickhouse
273a06856a
Merge pull request #59025 from ClickHouse/cpu-scheduler
Split resource scheduler off `IO/` into `Common/Scheduler/`
2024-01-20 15:43:50 +01:00
Kseniia Sumarokova
5d67e26fc4
Merge pull request #58869 from ClickHouse/force-check-for-cached-custom-disk
Fix for custom cached disk creation
2024-01-20 14:47:36 +01:00
serxa
824deab761 split resource scheduler off IO/ into Common/Scheduler/ 2024-01-20 12:06:26 +00:00
Vitaly Baranov
4c6d3e7efa Add server settings "shutdown_wait_backups_and_restores" (default=true)
to set whether shutdown should wait for running backups to finish or just cancel them.
2024-01-18 13:27:14 +01:00
kssenii
3d564c0802 Fix typo 2024-01-17 10:34:13 +01:00
Mikhail Koviazin
6e6197019c
Reintroduce commit 3067ca6
Update `query_masking_rules` when reloading the config

This reverts commit 7e55eab1c3.
2024-01-17 08:10:49 +02:00
kssenii
237146b4e2 Add to default config 2024-01-16 16:30:07 +01:00
Yakov Olkhovskiy
2e124b19b8
Merge branch 'master' into revert-58450-revert-56064-feature-server-iface-metrics 2024-01-10 09:05:18 -05:00
Bharat Nallan
ee37f551a2
independent registration of interpreters (#58443)
* make interpreter factory an instance

* add registerInterpreter

* register interpreters individually

* try wire everything up

* fix style

* fix test
2024-01-08 22:33:48 -08:00
Alexey Milovidov
6bc27dfcf5 Enable all access control improvements by default 2024-01-07 20:56:16 +01:00
Yakov Olkhovskiy
9ca4be5d91 Merge remote-tracking branch 'origin/master' into revert-58450-revert-56064-feature-server-iface-metrics 2024-01-06 00:24:31 +00:00
Michael Kolupaev
52058211e7
Fix some thread pool settings not updating at runtime (#58485) 2024-01-04 17:21:46 +01:00
Alexander Tokmakov
10e3ae9e68 Merge branch 'master' into allow-not-resolving-hostnames 2024-01-04 13:22:15 +01:00
Alexey Milovidov
be9b857d1f Merge branch 'master' into async-load-by-default 2024-01-04 00:53:20 +01:00
Yakov Olkhovskiy
85f03478ef
Revert "Revert "Use CH Buffer for HTTP out stream, add metrics for interfaces"" 2024-01-03 11:47:15 -05:00
Raúl Marín
d491758939
Revert "Use CH Buffer for HTTP out stream, add metrics for interfaces" 2024-01-03 10:42:15 +01:00
Yakov Olkhovskiy
5633fb8145
Merge pull request #56064 from ClickHouse/feature-server-iface-metrics
Use CH Buffer for HTTP out stream, add metrics for interfaces
2024-01-02 10:17:52 -05:00
Alexey Milovidov
7bded0a5e7
Merge pull request #58316 from ClickHouse/reintroduce_is_deleted
Re-introduce `is_deleted` column for ReplacingMergeTree
2023-12-31 00:57:19 +01:00
Bharat Nallan Chakravarthy
ab28da85d3 try wire everything up 2023-12-29 16:38:17 -08:00
Alexey Milovidov
aa462fa7cd
Merge branch 'master' into feature-server-iface-metrics 2023-12-29 22:37:52 +01:00
Alexander Tokmakov
bdada351c8 Revert "Merge pull request #58274 from ClickHouse/revert-58267"
This reverts commit 583b9637c2, reversing
changes made to 224e937620.
2023-12-28 14:07:59 +01:00
Alexey Milovidov
c7efd2afea Revert #58267 2023-12-28 04:09:33 +01:00
Alexey Milovidov
dcbd3b9c26
Merge pull request #58267 from ClickHouse/fix_is_deleted_compatibility
Re-introduce `is_deleted` column for ReplacingMergeTree
2023-12-28 00:13:01 +01:00
Alexander Tokmakov
01d042c490 Revert "Merge pull request #57932 from ClickHouse/remove-shit-cleanup"
This reverts commit 2d58dc512c, reversing
changes made to 41873dc4a3.
2023-12-27 13:46:06 +01:00
Alexey Milovidov
5f6318e51b
Merge pull request #58151 from ClickHouse/fix-legend
Fix dashboard legend sorting and rows number
2023-12-27 13:33:00 +01:00
Alexey Milovidov
0e89d01b94 Binary (symbols) viewer 2023-12-24 12:14:45 +01:00
serxa
8693e1535a Fix dashboard legend sorting and rows number 2023-12-22 14:39:44 +00:00
Yakov Olkhovskiy
5dc88542cb
Merge branch 'master' into feature-server-iface-metrics 2023-12-20 16:46:29 -05:00
Nikita Mikhaylov
6360b76792 Merge branch 'master' of github.com:ClickHouse/ClickHouse into remove-the-limit-for-connections-per-endpoint 2023-12-18 21:49:31 +00:00
pufit
36d1905881
Merge pull request #57752 from chizhonkova/refactor_sql_udf_loader
Refactoring for UserDefinedSQLObjectsLoader
2023-12-18 16:08:46 -05:00
Yakov Olkhovskiy
f99b36143f Merge remote-tracking branch 'origin/master' into feature-server-iface-metrics 2023-12-18 14:14:03 +00:00
Alexey Milovidov
61e5db9cd0 Merge branch 'master' into dashboard-small-fix 2023-12-17 02:45:48 +01:00
Alexey Milovidov
ac44557e3a A small fix for dashboard 2023-12-17 02:43:50 +01:00
serxa
fc0f30352e better error messages 2023-12-16 14:02:20 +00:00
serxa
4bc93792db Fix /dashboard work with passwords 2023-12-16 13:49:14 +00:00
Alexey Milovidov
2ce4f543d6 Update tests 2023-12-15 23:36:01 +01:00
Yakov Olkhovskiy
001a38048f use ProfileEvents instead of CurrentMetrics 2023-12-15 19:17:42 +00:00
Alexey Milovidov
7e55eab1c3 Revert "Merge pull request #56573 from mkmkme/mkmkme/reload-config"
This reverts commit 3067ca64df, reversing
changes made to 1e46460910.
2023-12-15 19:28:25 +01:00
Yakov Olkhovskiy
febdd542f8 Merge remote-tracking branch 'origin/master' into feature-server-iface-metrics 2023-12-14 18:59:44 +00:00
Kseniia Sumarokova
79db3c66df
Merge branch 'master' into allow-to-change-some-cache-settings-without-restart 2023-12-13 23:33:59 +01:00
Nikita Mikhaylov
8372c70958 Merge branch 'master' of github.com:ClickHouse/ClickHouse into remove-the-limit-for-connections-per-endpoint 2023-12-13 18:29:56 +00:00
Alexey Milovidov
54698cd2de
Merge pull request #55876 from ClickHouse/keeper-http-readiness-endpoint
Keeper HTTP readiness endpoint
2023-12-13 17:07:57 +01:00
Han Fei
a96593c8b1 Merge branch 'master' into feature/more_warnings 2023-12-12 15:25:01 +01:00
Natalya Chizhonkova
3d51192bad Refactoring for UserDefinedSQLObjectsLoader 2023-12-12 17:03:49 +03:00
Konstantin Bogdanov
771d5c58ea
Fix Keeper standalone build 2023-12-11 10:19:49 +01:00
Konstantin Bogdanov
89ba4a8452
Add HTTP readiness endpoint 2023-12-11 10:19:42 +01:00
Azat Khuzhin
8f5a60eb5a More descriptive comment for destroying context prio global thread pool
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-10 15:39:43 +01:00
Azat Khuzhin
fcdead023c Proper server termination in case of intermediate failures during initialization
For instance on CI it fails because KeeperDispatch::initialize() failed,
but there is already proper KeeperDispatch::shutdown() in dtor, the
problem is that you first need to shutdown global context, that will
terminate all thread pools, and only after you can join global thread
pool.

CI: https://s3.amazonaws.com/clickhouse-test-reports/52717/6ccbc2ea75c39234dff748cfb147bd44d65d3e75/integration_tests__asan__[3_4].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-10 08:01:40 +01:00
Azat Khuzhin
b7edde3621 Shutdown embedded keeper even if it was not started successfully
Since even when it does not, there are still few threads left that
should be joined (request, response, snapshot, snapshot s3):

There are some problems with keeper and invalid config, that got stuck in:

    libc.so.6`___lldb_unnamed_symbol3457 + 231
    libc.so.6`pthread_cond_timedwait + 571
    clickhouse`std::__1::__libcpp_condvar_timedwait[abi:v15000](__cv=0x00007f475c41a708, __m=0x00007f475c41a6b0, __ts=0x00007f45a99f1440) at __threading_support:341:10
    clickhouse`std::__1::condition_variable::__do_timed_wait(this=0x00007f475c41a708, lk=0x00007f45a99f1738, tp=time_point<std::__1::chrono::system_clock, std::__1::chrono::duration<long long, std::__1::ratio<1L, 1000000000L> > > @ 0x00007f45a99f1488) at condition_variable.cpp:76:14
    clickhouse`std::__1::cv_status std::__1::condition_variable::wait_for<long long, std::__1::ratio<1l, 1000000000l> >(this=0x00007f475c41a708, __lk=0x00007f45a99f1738, __d=0x00007f45a99f1590) at __mutex_base:457:9
    clickhouse`void std::__1::condition_variable::__do_timed_wait<std::__1::chrono::steady_clock>(this=0x00007f475c41a708, __lk=0x00007f45a99f1738, __tp=time_point<std::__1::chrono::steady_clock, std::__1::chrono::duration<long long, std::__1::ratio<1L, 1000000000L> > > @ 0x00007f45a99f15a8) at __mutex_base:512:5
    clickhouse`std::__1::cv_status std::__1::condition_variable::wait_until<std::__1::chrono::steady_clock, std::__1::chrono::duration<long long, std::__1::ratio<1l, 1000000000l> > >(this=0x00007f475c41a708, __lk=0x00007f45a99f1738, __t=0x00007f45a99f1698) at __mutex_base:415:5
    clickhouse`bool std::__1::condition_variable::wait_until<std::__1::chrono::steady_clock, std::__1::chrono::duration<long long, std::__1::ratio<1l, 1000000000l> >, bool ConcurrentBoundedQueue<DB::KeeperStorage::RequestForSession>::popImpl<true>(DB::KeeperStorage::RequestForSession&, std::__1::optional<unsigned long>)::'lambda'()>(this=0x00007f475c41a708, __lk=0x00007f45a99f1738, __t=0x00007f45a99f1698, __pred=(unnamed class) @ 0x00007f45a99f1650)::'lambda'()) at __mutex_base:427:13
    clickhouse`bool std::__1::condition_variable::wait_for[abi:v15000]<long long, std::__1::ratio<1l, 1000l>, bool ConcurrentBoundedQueue<DB::KeeperStorage::RequestForSession>::popImpl<true>(DB::KeeperStorage::RequestForSession&, std::__1::optional<unsigned long>)::'lambda'()>(this=0x00007f475c41a708, __lk=0x00007f45a99f1738, __d=0x00007f45a99f1720, __pred=(unnamed class) @ 0x00007f45a99f16b8)::'lambda'()) at __mutex_base:471:12
    clickhouse`bool ConcurrentBoundedQueue<DB::KeeperStorage::RequestForSession>::popImpl<true>(this=0x00007f475c41a680, x=0x00007f45a99f1ba0, timeout_milliseconds= Has Value=true ) at ConcurrentBoundedQueue.h:75:50
    clickhouse`ConcurrentBoundedQueue<DB::KeeperStorage::RequestForSession>::tryPop(this=0x00007f475c41a680, x=0x00007f45a99f1ba0, milliseconds=5000) at ConcurrentBoundedQueue.h:161:16
    clickhouse`DB::KeeperDispatcher::requestThread(this=0x00007f475c8fac18) at KeeperDispatcher.cpp:88:33
    clickhouse`DB::KeeperDispatcher::initialize(this=0x00007f45a99f2020)::$_0::operator()() const at KeeperDispatcher.cpp:349:52
    clickhouse`decltype(__f=0x00007f45a99f2020)::$_0&>()()) std::__1::__invoke[abi:v15000]<DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&) at invoke.h:394:23
    clickhouse`decltype(__f=0x00007f45a99f2020, __t=size=0, (null)=__tuple_indices<> @ 0x00007f45a99f1d28) std::__1::__apply_tuple_impl[abi:v15000]<DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&, std::__1::tuple<>&>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&, std::__1::tuple<>&, std::__1::__tuple_indices<>) at tuple:1789:1
    clickhouse`decltype(__f=0x00007f45a99f2020, __t=size=0) std::__1::apply[abi:v15000]<DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&, std::__1::tuple<>&>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&, std::__1::tuple<>&) at tuple:1798:1
    clickhouse`ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::KeeperDispatcher::initialize(this=0x00007f475c9703c0)::$_0>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&&)::'lambda'()::operator()() at ThreadPool.h:245:13
    clickhouse`decltype(__f=0x00007f475c9703c0)::$_0>()()) std::__1::__invoke[abi:v15000]<ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&&)::'lambda'()&>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&&) at invoke.h:394:23
    clickhouse`void std::__1::__invoke_void_return_wrapper<void, true>::__call<ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::KeeperDispatcher::initialize(__args=0x00007f475c9703c0)::$_0>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&&)::'lambda'()&>(ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&&)::'lambda'()&) at invoke.h:479:9
    clickhouse`std::__1::__function::__default_alloc_func<ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&&)::'lambda'(), void ()>::operator(this=0x00007f475c9703c0)[abi:v15000]() at function.h:235:12
    clickhouse`void std::__1::__function::__policy_invoker<void ()>::__call_impl<std::__1::__function::__default_alloc_func<ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::KeeperDispatcher::initialize(__buf=0x00007f45a99f22d8)::$_0>(DB::KeeperDispatcher::initialize(Poco::Util::AbstractConfiguration const&, bool, bool, std::__1::shared_ptr<DB::Macros const> const&)::$_0&&)::'lambda'(), void ()> >(std::__1::__function::__policy_storage const*) at function.h:716:16
    clickhouse`std::__1::__function::__policy_func<void ()>::operator(this=0x00007f45a99f22d8)[abi:v15000]() const at function.h:848:16
    clickhouse`std::__1::function<void ()>::operator(this=0x00007f45a99f22d8)() const at function.h:1187:12
    clickhouse`ThreadPoolImpl<std::__1::thread>::worker(this=0x00007f475c8229c0, thread_it=std::__1::list<std::__1::thread, std::__1::allocator<std::__1::thread> >::iterator @ 0x00007f45a99f23a8) at ThreadPool.cpp:427:13
    clickhouse`void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(this=0x00007f45cea0c8a8)>, Priority, std::__1::optional<unsigned long>, bool)::'lambda0'()::operator()() const at ThreadPool.cpp:180:73
    clickhouse`decltype(__f=0x00007f45cea0c8a8)()) std::__1::__invoke[abi:v15000]<void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, Priority, std::__1::optional<unsigned long>, bool)::'lambda0'()>(void&&) at invoke.h:394:23
    clickhouse`void std::__1::__thread_execute[abi:v15000]<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, Priority, std::__1::optional<unsigned long>, bool)::'lambda0'()>(__t=size=2, (null)=__tuple_indices<> @ 0x00007f45a99f2408)>, Priority, std::__1::optional<unsigned long>, bool)::'lambda0'()>&, std::__1::__tuple_indices<>) at thread:284:5
    clickhouse`void* std::__1::__thread_proxy[abi:v15000]<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, Priority, std::__1::optional<unsigned long>, bool)::'lambda0'()> >(__vp=0x00007f45cea0c8a0) at thread:295:5
    libc.so.6`___lldb_unnamed_symbol3481 + 755
    libc.so.6`___lldb_unnamed_symbol3865 + 11

This should fix the problem with
test_keeper_incorrect_config/test.py::test_invalid_configs test.

CI: https://s3.amazonaws.com/clickhouse-test-reports/52717/72b1052f7c2d453308262924e767ab8dc2206933/integration_tests__asan__[1_6].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-09 17:54:16 +01:00
Azat Khuzhin
55d5a3affa Correctly wait background threads
There are some places that make it possible to trigger use-after-free
from threads because some global variable had been destroyed before, for
example some logger.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-09 17:54:16 +01:00
Alexey Milovidov
ee1b304284 Asynchronous load of tables by default 2023-12-08 20:56:10 +01:00
Nikita Mikhaylov
c979124cfe Merge branch 'master' of github.com:ClickHouse/ClickHouse into remove-the-limit-for-connections-per-endpoint 2023-12-08 16:25:02 +00:00
kssenii
199015576c Add a file which I forgot to commit 2023-12-07 18:30:43 +01:00
Nikolay Degterinsky
995b51ef73 Allow avoiding resolving hostnames in DDLWorker 2023-12-07 03:43:26 +00:00
Alexey Milovidov
0b597eadf8 Clarify the usage of prefer_not_to_merge option 2023-12-06 12:11:03 +01:00
Nikita Mikhaylov
04d167c6d9 Better 2023-12-05 13:34:37 +01:00
Alexey Milovidov
cbea3545aa
Revert "add function getClientHTTPHeader" 2023-12-05 13:34:34 +03:00
凌涛
9e05e79d66
Merge branch 'master' into feature/more_warnings 2023-12-05 11:50:05 +08:00
凌涛
6794bbe196 rebase master 2023-12-05 11:42:25 +08:00
Sergei Trifonov
c073d03a20
Merge pull request #57236 from ClickHouse/multiline-charts
Support multiple lines on dashboard charts
2023-12-04 17:35:31 +01:00
serxa
1c650f380a remove debug print 2023-12-04 16:26:39 +00:00
Alexey Milovidov
02439eee58
Merge pull request #49351 from ClickHouse/async-loader-integration
Asynchronous loading of tables
2023-12-04 17:16:12 +01:00
Yakov Olkhovskiy
416d28687e Merge remote-tracking branch 'origin/master' into feature-server-iface-metrics 2023-11-30 23:00:04 +00:00
凌涛
d9f4b4d2c0 support parts, tables, databases 2023-11-30 10:56:31 +08:00