Commit Graph

4164 Commits

Author SHA1 Message Date
Nikolai Kochetov
34eaa48294 Part 1. 2021-05-25 19:34:43 +03:00
mergify[bot]
400b74d186
Merge branch 'master' into merging-s3-backoff 2021-05-25 14:02:38 +00:00
alesapin
6e29404a75 Add max_parts_to_merge_at_once setting 2021-05-25 16:21:17 +03:00
Alexander Tokmakov
4849ea2e03 fix unexpected behavior in mutation finalization 2021-05-25 14:10:45 +03:00
Anton Popov
3acbd12c54 enable reading of subcolumn for distributed tables 2021-05-25 03:49:24 +03:00
kssenii
70469429c1 Fixes 2021-05-24 23:39:56 +00:00
kssenii
c3fc2ff04b Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into modulo-partition-key 2021-05-24 22:08:49 +00:00
kssenii
cef509e5b5 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into hdfs-idisk 2021-05-24 17:39:34 +00:00
kssenii
31107816bb fs::absolute to fs::canonical 2021-05-24 20:37:54 +03:00
Anton Ivashkin
c936dab6d5 Fix part type in Fetcher::downloadPartToS3 2021-05-24 19:37:37 +03:00
Anton Ivashkin
a98286b4c4 Merge master 2021-05-24 17:46:29 +03:00
Dmitrii Kovalkov
a4d1b9b07d Fix 2021-05-24 16:55:05 +03:00
tavplubix
6b228f2630
Update StorageReplicatedMergeTree.cpp 2021-05-24 15:13:42 +03:00
tavplubix
e0f214d0e9
Update StorageReplicatedMergeTree.cpp 2021-05-24 14:23:23 +03:00
Alexey Milovidov
d32819f068 Mark false positives for PVS-Studio 2021-05-24 06:59:12 +03:00
Alexey Milovidov
273226de32 Remove string parameter for Density 2021-05-24 06:43:25 +03:00
Alexey Milovidov
6f70feed2f Merge branch 'master' into issue-16775 2021-05-24 05:56:57 +03:00
Alexey Milovidov
ff7b5d34bb Mark false positives for PVS-Studio 2021-05-24 02:56:03 +03:00
kssenii
659e57e60f Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into modulo-partition-key 2021-05-23 22:46:00 +00:00
kssenii
1ffaf1d793 Better check 2021-05-23 21:53:32 +00:00
Kseniia Sumarokova
3dac785fa6
Merge pull request #24415 from kssenii/rabbit-fixes
Add exponential backoff to reschedule read attempt in case RabbitMQ queues are empty (CPU load issue)
2021-05-23 21:55:32 +03:00
kssenii
bbf56e35ac Merge branch 'master' of github.com:ClickHouse/ClickHouse into poco-file-to-std-fs 2021-05-23 10:54:48 +03:00
alesapin
6c0b683d3a
Merge pull request #17871 from nvartolomei/nv/parts-uuid-move-shard
Part movement between shards
2021-05-23 10:20:57 +03:00
mergify[bot]
3c6e6464a7
Merge branch 'master' into s3_zero_copy_replication 2021-05-23 07:09:17 +00:00
Alexey Milovidov
40d4f0678f Remove overload (harmful) 2021-05-23 04:25:06 +03:00
Alexey Milovidov
77414b50e6 Remove copy-paste 2021-05-23 03:55:16 +03:00
kssenii
1c43b333ea Merge branch 'master' of github.com:ClickHouse/ClickHouse into poco-file-to-std-fs 2021-05-22 21:26:48 +03:00
kssenii
5606e248a7 Fix 2021-05-22 16:19:56 +00:00
kssenii
b72f6ea78e Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into modulo-partition-key 2021-05-22 16:15:15 +00:00
alexey-milovidov
1ed30f7246
Merge branch 'master' into issue-16775 2021-05-22 17:14:23 +03:00
kssenii
53ce22ae65 Exponencial backoff if queues are empty 2021-05-22 09:44:57 +00:00
alexey-milovidov
a25f1910cc
Merge pull request #24320 from ClickHouse/remove-auto-array
Remove AutoArray
2021-05-22 02:19:59 +03:00
kssenii
096d117f68 Review fixes 2021-05-22 00:12:46 +03:00
kssenii
fcfec83875 Fix comparisons with modulo key (version 2) 2021-05-21 16:40:47 +00:00
kssenii
94b5763dbd Revert "Different approach to fix modulo"
This reverts commit 665f1aa0f6.
2021-05-21 16:14:01 +00:00
kssenii
30845a383f Fix comparisons with modulo key 2021-05-21 15:01:41 +00:00
kssenii
665f1aa0f6 Different approach to fix modulo 2021-05-21 14:30:08 +00:00
Anton Ivashkin
29336a4a34 Use keep_s3_on_delet flag instead of DeleteOnDestroyKeepS3 state 2021-05-21 15:29:10 +03:00
kssenii
bd0bc8e3e7 Revert "Adjust minMax index"
This reverts commit c69f587f8a.
2021-05-21 12:01:08 +00:00
alesapin
20a34e951a Split fetch part into two stages, don't use replicated block output stream 2021-05-21 12:30:49 +03:00
kssenii
074428264f Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into hdfs-idisk 2021-05-21 08:26:54 +00:00
Alexey Milovidov
ea30bb7abf Improve implementation 2021-05-21 04:17:18 +03:00
Azat Khuzhin
4f41ebcae3 Add settings (for connections) for MySQL storage engine
Default settings are not very efficient, since they do not even reuse
connections.
And when each query requires connection you can have only ~80 QPS, while
by simply enabling connection reuse (connection_auto_close=false) you
can have ~500 QPS (and by increasing connection_pool_size you can have
better QPS throughput).

So this patch allows to pass through some connection related settings
for the StorageMySQL engine, like:
- connection_pool_size=16
- connection_max_tries=3
- connection_auto_close=true

v2: remove connection_pool_default_size
v3: remove num_tries_on_connection_loss
2021-05-20 22:44:52 +03:00
robot-clickhouse
471142043f Auto version update to [21.7.1.1] [54452] 2021-05-20 22:23:34 +03:00
alesapin
deb784a321 Merge branch 'master' into nvartolomei-parts-move 2021-05-20 21:24:55 +03:00
kssenii
3dee003f9b Merge branch 'master' of github.com:ClickHouse/ClickHouse into poco-file-to-std-fs 2021-05-20 19:20:09 +03:00
kssenii
c69f587f8a Adjust minMax index 2021-05-20 15:32:18 +00:00
tavplubix
acd952d701
Merge pull request #24309 from ClickHouse/fix_rename_matview
Fix rename MaterializedView
2021-05-20 18:20:38 +03:00
Maksim Kita
b0476c1fa2
Merge pull request #24273 from kitaisreal/expression-actions-compile-only-necessary-places
ExpressionActions compile only necessary places
2021-05-20 10:53:30 +03:00
Nikolai Kochetov
818d081292
Merge pull request #24296 from amosbird/projection-fix5
Skip data finalization when doing projection materialization.
2021-05-20 10:50:42 +03:00
alesapin
b9c3601083
Merge pull request #24275 from ucasFL/fix-mutation
Fix mutation fail of StorageMemory
2021-05-20 10:09:48 +03:00
Amos Bird
81dd60fdc2
Fix drop partition in rare case 2021-05-20 14:55:28 +08:00
Alexey Milovidov
1006a970f7 Remove AutoArray 2021-05-20 09:30:13 +03:00
mergify[bot]
29b3ed4551
Merge branch 'master' into modulo-partition-key 2021-05-20 05:45:11 +00:00
mergify[bot]
e762039db7
Merge branch 'master' into merging-s3-backoff 2021-05-19 21:57:10 +00:00
Nikita Mikhaylov
f33b70c54a better 2021-05-20 00:42:25 +03:00
kssenii
56b388addf Add check for nullptr 2021-05-19 19:32:04 +00:00
Alexander Tokmakov
2996e7c072 fix rename matview 2021-05-19 21:53:31 +03:00
Maksim Kita
8e68d007f3 Fixed tests 2021-05-19 20:57:07 +03:00
kssenii
477214a57f Fix partitionPrunner with modulo 2021-05-19 17:36:32 +00:00
Amos Bird
c68ef31065
Skip data finalization when doing projection materialization. 2021-05-20 00:28:50 +08:00
Nikolai Kochetov
e8f8b2ba18
Merge pull request #24162 from amosbird/projection-fix2
Fix add projection to replicated mergetree
2021-05-19 18:07:52 +03:00
Maksim Kita
c50909468f Updated ExpressionActionSettings 2021-05-19 17:32:07 +03:00
alesapin
301dc848f5 Merge branch 'master' into nvartolomei-parts-move 2021-05-19 17:17:01 +03:00
feng lv
d92b1f0e9a Fix mutation of StorageMemory
fix

fix
2021-05-19 14:15:50 +00:00
Alexander Kuzmenkov
e9b69bbd70
Merge pull request #23906 from azat/fix-distributed_group_by_no_merge
distributed_group_by_no_merge fixes
2021-05-19 16:16:08 +03:00
Alexander Kuzmenkov
09cb467812
Update StorageDistributed.cpp 2021-05-19 16:14:33 +03:00
kssenii
ba41d01b78 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into hdfs-idisk 2021-05-19 11:47:05 +00:00
mergify[bot]
230bec70fb
Merge branch 'master' into modulo-partition-key 2021-05-19 10:08:41 +00:00
alesapin
4d6c71801c
Merge branch 'master' into nv/parts-uuid-move-shard 2021-05-19 13:03:14 +03:00
Maksim Kita
150a88d647 ExpressionActions compile only necessary places 2021-05-19 11:43:16 +03:00
tavplubix
8b13e73ac2
Merge pull request #24208 from ClickHouse/fix_intersecting_parts_again
Addition to #23997
2021-05-18 21:13:25 +03:00
Kseniia Sumarokova
0ab15d0bc4
Merge branch 'master' into modulo-partition-key 2021-05-18 17:45:32 +03:00
Anton Ivashkin
d256cf4edf Fix PVS check (Two or more case-branches perform the same actions) 2021-05-18 17:41:09 +03:00
alesapin
c1c6a0d8e3
Merge pull request #24248 from ucasFL/remove
remove useless code
2021-05-18 16:09:00 +03:00
feng lv
403d0a305b remove useless code 2021-05-18 12:19:04 +00:00
tavplubix
3a98e7f427
Merge pull request #24124 from abel-cheng/feature/thread_name_in_stack_trace
Add thread_name in system.stack_trace
2021-05-18 14:48:49 +03:00
kssenii
5f083b779d A little better, fix checks 2021-05-18 14:25:19 +03:00
Alexander Tokmakov
2dac182df3 fix 2021-05-18 13:00:34 +03:00
alesapin
36aeb59705 Fix lazy test 2021-05-18 11:03:38 +03:00
Kruglov Pavel
cee8e280c7
Merge pull request #24193 from plugine/fix-mutation-for-storagememory
Fix wrong typo at StorageMemory
2021-05-18 10:57:52 +03:00
alesapin
22cc1c953f Revert "PVS Studio fixes"
This reverts commit 87c6e39a29.
2021-05-18 10:34:16 +03:00
alesapin
64baa524b8
Merge pull request #24191 from kssenii/hdfs-fixes
Fix abnormal termination when hdfs is unreachable
2021-05-18 10:12:05 +03:00
Maksim Kita
40d8d95fd2
Merge pull request #24067 from azat/buffer-destroy-first
Flush Buffer tables before shutting down tables (within one database)
2021-05-18 09:07:28 +03:00
Alexander Tokmakov
20b9af7b26 do not allow concurrent alter partition 2021-05-18 00:20:58 +03:00
alesapin
87c6e39a29 PVS Studio fixes 2021-05-17 23:23:32 +03:00
kssenii
9b8df78fdd Merge branch 'master' of github.com:ClickHouse/ClickHouse into poco-file-to-std-fs 2021-05-17 17:42:05 +03:00
kssenii
71fcbefdc7 Add final to class 2021-05-17 14:38:48 +00:00
kssenii
8c955680ad Add comments and remove adjusted deserializarion 2021-05-17 14:33:04 +00:00
Anton Popov
e27acc26be better dropPart and dropPartition 2021-05-17 17:26:36 +03:00
Anton Popov
e043cc45bf Merge remote-tracking branch 'upstream/master' into HEAD 2021-05-17 16:11:12 +03:00
Anton Ivashkin
8ed4a5de62 Fix Zero Copy after merge master 2021-05-17 16:01:08 +03:00
kssenii
26fa920ad5 Fix clang tidy, slightly improve writeSuffix 2021-05-17 12:32:48 +00:00
alesapin
5563a0d7f3 Fix style 2021-05-17 14:44:47 +03:00
alesapin
023b592f97 Fix style 2021-05-17 14:42:14 +03:00
alesapin
d8994350c1 Useful comments 2021-05-17 14:39:37 +03:00
Ilya Yatsishin
8ede5c736a
Merge pull request #23992 from MaxWk/enable-datatime64-version-column
enable DateTime64 to be version column
2021-05-17 14:34:15 +03:00
alesapin
77b1aeaac2 Use same zookeeper object to have an exception if something went wrong 2021-05-17 14:30:23 +03:00
alesapin
67d34c0136 merge with master 2021-05-17 14:13:18 +03:00
alesapin
17f229857c Merge branch 'master' into nvartolomei-parts-move 2021-05-17 13:52:48 +03:00
张中南
3d1992ea50 fix wrong typo at StorageMemory 2021-05-17 18:24:01 +08:00
kssenii
a8748a55df Fix abnormal termination when hdfs goes away 2021-05-17 09:55:23 +00:00
tavplubix
42d5400e36
Update StorageSystemStackTrace.cpp 2021-05-17 12:07:50 +03:00
Kruglov Pavel
64e7994987
Merge pull request #23887 from kssenii/rabbitmq-fixes
RabbitMQ: allow user to define specific queue settings, its own exchange, user-managed queues; add cleanup on drop table
2021-05-17 12:01:12 +03:00
Anton Ivashkin
39a30b77fe Merge master 2021-05-17 11:47:48 +03:00
alesapin
eae2df6478
Merge pull request #23997 from ClickHouse/fix_intersecting_parts
Try fix intersecting parts
2021-05-17 10:46:58 +03:00
Vladimir Chebotarev
bdf03387ab Better S3 read retries. Renamed s3_max_single_read_retries -> s3_single_read_retry_attempts, added sleeps before next attempts. 2021-05-17 10:38:32 +03:00
Nikolai Kochetov
98e6c27a95
Merge pull request #24168 from amosbird/projection-fix3
Fix distributed processing when using projection
2021-05-17 09:45:39 +03:00
Maksim Kita
20cced0a4c
Merge pull request #24155 from kitaisreal/function-refactoring
IFunction refactoring
2021-05-17 09:26:57 +03:00
abel-wang
4edd5fbb35 Add thread_name in system.stack_trace 2021-05-17 12:44:57 +08:00
kssenii
3b1bf2bae6 Poco::Path substitution 2021-05-16 23:38:23 +03:00
kssenii
e524d11222 Remove setting 2021-05-16 20:16:10 +00:00
kssenii
57da32472b Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into rabbitmq-fixes 2021-05-16 18:39:51 +00:00
kssenii
807684812e Fix clang tidy 2021-05-16 18:18:11 +00:00
kssenii
d44f1680da Use unsigned type for (de)serialization 2021-05-16 18:09:55 +00:00
Amos Bird
07b1be5a76
Fix distributed processing when using projection 2021-05-16 22:40:06 +08:00
alesapin
29726b5510
Merge pull request #24122 from ClickHouse/fix_table_startup
Set readonly mode if restarting thread failed to activate replica
2021-05-16 16:45:51 +03:00
Azat Khuzhin
23981ffd0e Introduce IStorage::flushAndShutdown() 2021-05-16 13:23:53 +03:00
Azat Khuzhin
f20799f683 Destroy Buffer() tables before others (within one database)
This will reduce amount of data that may be lost at shutdown.

v2: replace dynamic_cast with IStorage::isBuffer (@kitaisreal)
v3: replace IStorage::isBuffer with IStorage::flush (@alexey-milovidov)
v4: flush() for StorageProxy/StorageTableFunction
2021-05-16 13:23:53 +03:00
kssenii
22b6d0eb25 Adjust modulo recursively 2021-05-16 09:20:59 +00:00
Amos Bird
e5cd597111
Fix add projection to replicated mergetree 2021-05-16 16:49:38 +08:00
Nikolai Kochetov
093b7e120a
Merge pull request #24062 from amosbird/projection-fix1
Fix empty key projection query analysis
2021-05-16 07:37:03 +03:00
kssenii
add5970b5f fs::absolute 2021-05-16 03:12:13 +03:00
kssenii
c7f51fe60e Modulo adjustment for partition key 2021-05-15 19:51:02 +00:00
Maksim Kita
947f28d430 IFunction refactoring 2021-05-15 20:33:15 +03:00
Kseniia Sumarokova
99e2f83c69
Merge pull request #23548 from ucasFL/table-comment
Implement table comments
2021-05-15 19:56:16 +03:00
Kseniia Sumarokova
6bcc99e5e6
Whitespace 2021-05-15 10:56:46 +03:00
Kseniia Sumarokova
9e65f376cc
Fix PVS check 2021-05-15 10:05:31 +03:00
Kseniia Sumarokova
1d73cd6406
Fix PVS check 2021-05-15 09:05:27 +03:00
Alexander Tokmakov
df5f3fbc9d review suggestions 2021-05-14 19:11:40 +03:00
feng lv
8c82e3f1b9 fix style
fix
2021-05-14 15:50:05 +00:00
Amos Bird
a113acc40c
Fix empty key 2021-05-14 22:54:14 +08:00
Amos Bird
8de016d33a
Fix empty key projection query analysis 2021-05-14 22:26:26 +08:00
Alexander Tokmakov
41776ba5d9 fix 2021-05-14 15:55:30 +03:00
Alexander Tokmakov
970ad94851 Merge branch 'master' into fix_intersecting_parts 2021-05-14 13:17:02 +03:00
alesapin
d4c6a5a05e Better logging 2021-05-14 11:38:53 +03:00
alesapin
67e4393769 If table was not active set readonly mode 2021-05-14 11:32:41 +03:00
kssenii
55c573f920 Fix 2021-05-14 07:11:32 +00:00
kssenii
f33a517d33 Merge branch 'master' of github.com:ClickHouse/ClickHouse into poco-file-to-std-fs 2021-05-14 02:58:26 +03:00
tavplubix
780b7cc8e1
Merge pull request #23863 from Algunenano/mutation_logs
Reduce the amount of logs that StorageMergeTree::selectPartsToMutate outputs in busy systems.
2021-05-13 19:02:23 +03:00
Alexander Tokmakov
eaffe6848b fix 2021-05-13 17:24:07 +03:00
Alexander Tokmakov
2da12f0b59 fix intersection of drop range and merge 2021-05-13 17:04:36 +03:00
Alexander Tokmakov
e114c7eb8b fix virtual parts in REPLACE_RANGE 2021-05-13 14:29:59 +03:00
kssenii
7115045317 Tiny changes 2021-05-13 09:39:57 +00:00
Maksim Kita
f3ee14d24a
Merge pull request #24066 from azat/buffer-total-lock-contention
Do not acquire lock for total_bytes/total_rows for Buffer engine
2021-05-13 11:15:06 +03:00
kssenii
0cb0bd48f7 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into rabbitmq-fixes 2021-05-13 06:36:51 +00:00
feng lv
c6f8ab9826 fix 2021-05-13 02:05:53 +00:00
Azat Khuzhin
074b57fe82 Do not acquire lock for total_bytes/total_rows for Buffer engine
When Buffer() is under preassure, acquiring per-layer lock may take
significant time. And so the following query may take significant amount of time:

    SELECT total_bytes, total_rows FROM system.tables WHERE engine='Buffer'
2021-05-12 23:38:00 +03:00
Azat Khuzhin
26a1277609 Fix typo for IStorage::totalRows() comment 2021-05-12 23:38:00 +03:00
Nikolai Kochetov
690410009c Restor is_temporary flag for fetched part. 2021-05-12 19:17:01 +03:00