thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-18 13:42:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
49,381 Commits 9,138 Branches 1,774 Tags 2 GiB
c19d2efd88
Commit Graph

5964 Commits

Author SHA1 Message Date
Artem Zuikov
eb1cb506c9
minor code improvement (#15668) 2020-10-07 20:20:07 +03:00
Nikolai Kochetov
54e77e906e
Merge pull request #15717 from ClickHouse/fix-array-join-optimisation-for-mv 
Fix array join optimisation for MV
 2020-10-07 20:19:35 +03:00
Anton Popov
cc451e41f5 fix assertion with transform_null_in 2020-10-07 18:36:34 +03:00
Latysheva Alexandra
f43ad338ed
Merge pull request #12 from alexelex/quorum_inserts_2 
style check
 2020-10-07 18:56:14 +06:00
Alexandra Latysheva
8f8872dc42 style check 2020-10-07 12:24:46 +00:00
Latysheva Alexandra
6c26f77380
Merge pull request #11 from alexelex/quorum_inserts_2 
changing the condition for updateQuorum, specialized it and reduced t…
 2020-10-07 17:49:20 +06:00
Artem Zuikov
403a5320f5
enable bigint float division (#15691) 2020-10-07 14:32:57 +03:00
Alexandra Latysheva
a43cac2c1a changing the condition for updateQuorum, specialized it and reduced the number of calls to the zk 2020-10-07 11:28:48 +00:00
tavplubix
041015545c
Merge pull request #15537 from ClickHouse/mutation_hangs_after_replace_partition 
Fix mutation may hang after REPLACE/DROP PARTITION
 2020-10-07 14:25:29 +03:00
Nikolai Kochetov
df02573c92 Fix ARRAY JOIN optimisation when reading from MV. 2020-10-07 13:11:58 +03:00
Nikolai Kochetov
5f7aeddfe5
Merge pull request #15682 from ClickHouse/akz/storage_memory_less_locks 
Less locking in StorageMemory: totalRows + totalBytes
 2020-10-07 12:59:20 +03:00
alexey-milovidov
e00961f882
Merge pull request #15657 from Jokser/disk-s3-write-error-handling 
Proper error handling during insert into MergeTree with S3
 2020-10-07 11:17:32 +03:00
Alexander Tokmakov
47e9fe9ff1 fix 2020-10-07 03:05:48 +03:00
Alexander Tokmakov
ea16370024 improvements in lost replica recovery 2020-10-07 02:29:33 +03:00
Azat Khuzhin
75e612fc16 Use full featured parser for force_data_skipping_indices 2020-10-07 01:44:14 +03:00
Azat Khuzhin
ef6d12967f Implement force_data_skipping_indices setting 2020-10-07 01:42:31 +03:00
Latysheva Alexandra
991e51a80e
Merge pull request #10 from alexelex/quorum_inserts_2 
style check fix
 2020-10-07 04:38:30 +06:00
Alexandra Latysheva
9077c92862 style check fix 2020-10-06 22:36:42 +00:00
Latysheva Alexandra
85bcc07c0b
Merge pull request #9 from alexelex/quorum_inserts_2 
Quorum inserts [version 3]
 2020-10-07 04:04:41 +06:00
Alexandra Latysheva
644091459f style fixes and remove small changes 2020-10-06 22:01:30 +00:00
Azat Khuzhin
675c70acbc Remove obsolete settings 
Came to this when looking at allow_experimental_data_skipping_indices,
for implementing force_data_skipping_indices
 2020-10-07 00:56:22 +03:00
Alexandra Latysheva
f549ecf9d1 insert_quorum_parallel: status nodes in /quorum/parallel and allow merges 2020-10-06 21:49:48 +00:00
Nikolai Kochetov
1f2e867ce6
Merge pull request #15645 from ClickHouse/read-from-storage-step-field-order 
Ensure resource destruction order in ReadFromStorageStep.
 2020-10-06 19:17:38 +03:00
Alexander Kazakov
cabab90ab2 Get back to moving args 2020-10-06 17:54:22 +03:00
Alexander Kazakov
ae2c106f94 Minor fixes 2020-10-06 17:04:08 +03:00
Alexander Kazakov
e54ff6e60a Lock-less totalRows/totalBytes + more clear postponed init 2020-10-06 16:45:17 +03:00
alesapin
00f29e400f Fix race condition in hdfs 2020-10-06 16:29:08 +03:00
Azat Khuzhin
9594e463b4
Cancel other processors on query exception (#15578) 
* Add a test for canceling distributed queries on error

* Cancel other processors on exception in PipelineExecutor

Fixes: 01514_distributed_cancel_query_on_error
 2020-10-06 14:24:55 +03:00
Nikolai Kochetov
3564ba1c63 Remove moves. 2020-10-06 13:02:07 +03:00
Pavel Kovalenko
69b4bc6f33 Proper error handling during insert into MergeTree with S3. 2020-10-06 12:38:00 +03:00
Nikolai Kochetov
8320efc189 Fix read from Buffer table with empty nested table with different types. 2020-10-06 11:24:12 +03:00
Artem Zuikov
bad8171f24
Fix distributed IN without database on initiator (#15538) 2020-10-06 11:18:25 +03:00
Nikolai Kochetov
28e12c559c Ensure resource desrtuction order in ReadFromStorageStep. 2020-10-06 09:35:35 +03:00
Latysheva Alexandra
d495a2fb2d
Merge pull request #7 from alexelex/quorum_inserts_2 
build checker fix (style) and change comments
 2020-10-06 02:33:29 +06:00
Alexandra Latysheva
41e0148d72 build checker fix (style) and change comments 2020-10-05 20:30:50 +00:00
Alexander Tokmakov
418766e92b fix another bug in mutations 2020-10-05 22:16:28 +03:00
Latysheva Alexandra
3b952aff7d
Merge pull request #6 from alexelex/quorum_inserts_2 
fix test_00814
 2020-10-05 23:01:18 +06:00
Alexandra Latysheva
2be62bbd1b fix test_00814 2020-10-05 16:58:26 +00:00
alesapin
8ec58c17f3 More consistent metadata usage 2020-10-05 19:41:46 +03:00
Alexander Tokmakov
30a18f7567 make it better 2020-10-05 16:52:03 +03:00
Anton Popov
a49591b250
Merge pull request #15543 from azat/optimize_aggregation_in_order-fix-memory-usage 
[RFC] Significantly reduce memory usage in AggregatingInOrderTransform
 2020-10-05 16:34:12 +03:00
Latysheva Alexandra
18007622a1
Merge pull request #5 from alexelex/quorum_inserts_2 
style check fix
 2020-10-05 19:00:39 +06:00
Alexandra Latysheva
aa391a47eb style check fix 2020-10-05 12:59:07 +00:00
Latysheva Alexandra
7e7cedd73f
Merge pull request #4 from alexelex/quorum_inserts_2 
style check fix
 2020-10-05 16:43:14 +06:00
Alexandra Latysheva
0662432c5c style check 2020-10-05 10:41:49 +00:00
alexey-milovidov
2fcf2e0fbe
Merge pull request #15443 from ucasFL/pretty_row_numbers 
Add setting `output_format_pretty_row_numbers`
 2020-10-05 11:49:55 +03:00
Latysheva Alexandra
a63084adaf
Merge pull request #3 from alexelex/quorum_inserts_2 
Quorum inserts 2
 2020-10-05 03:28:58 +06:00
Alexandra Latysheva
d54b6c9542 add question in comments 2020-10-04 20:32:08 +00:00
Alexandra Latysheva
ff8cbe6745 remove debug things 2020-10-04 20:19:05 +00:00
Alexandra Latysheva
8263e62298 working copy (with some debug info) 2020-10-04 19:55:39 +00:00
alexey-milovidov
a005ec4c89
Merge pull request #15589 from ClickHouse/tavplubix-patch-1 
Use default implemetation for constants in JSON* functions
 2020-10-04 16:02:08 +03:00
alexey-milovidov
6b39d248a0
Merge pull request #15542 from Avogar/quantile_t_digest 
Improve quantileTDigest performance
 2020-10-04 15:53:36 +03:00
alexey-milovidov
53ce5e3892
Merge pull request #15551 from azat/for-user-limits-over-distributed 
Pass through *_for_user settings via Distributed with cluster-secure
 2020-10-04 04:18:20 +03:00
tavplubix
e219162b82
Update FunctionsJSON.h 2020-10-03 21:09:22 +03:00
alexey-milovidov
6f3aab8f09
Merge pull request #15319 from bharatnc/ncb/fix-14509 
Fix bug in queries like SELECT toStartOfDay(today())
 2020-10-03 17:02:57 +03:00
alexey-milovidov
f7b390465b
Merge branch 'master' into realfix 2020-10-03 16:54:23 +03:00
alexey-milovidov
97d97f6b2e
Merge pull request #15513 from ClickHouse/aku/error-context 
Add some context to an error message
 2020-10-03 16:24:19 +03:00
alexey-milovidov
ca05425a87
Merge pull request #15535 from nvartolomei/patch-2 
Add missing entry to client packet stringify
 2020-10-03 16:22:04 +03:00
alexey-milovidov
46fa5ff53e
Merge pull request #15557 from ClickHouse/statvfs-eintr 
Handle EINTR in statvfs
 2020-10-03 15:57:56 +03:00
alexey-milovidov
ae61f8f7a6
Update filesystemHelpers.cpp 2020-10-03 15:57:35 +03:00
alexey-milovidov
4d6402525a
Update filesystemHelpers.h 2020-10-03 15:57:12 +03:00
alexey-milovidov
9551562889
Merge pull request #15442 from ClickHouse/add_alter_version 
Add ability to alter version column in VersionedCollapsingMergeTree.
 2020-10-03 05:40:15 +03:00
alexey-milovidov
75fb73956e
Merge pull request #15238 from ianton-ru/multi_delete_in_s3 
Use S3 multi object delete
 2020-10-03 03:48:06 +03:00
alexey-milovidov
5e37ba4335
Update DiskS3.cpp 2020-10-03 03:47:45 +03:00
alexey-milovidov
3ca7fca48a
Update DiskS3.cpp 2020-10-03 03:42:33 +03:00
Alexey Milovidov
d426ba3074 Step 4: cleanup 2020-10-03 03:07:55 +03:00
Alexey Milovidov
b6ca8a0676 Step 3: check other usages, add a comment 2020-10-03 03:05:54 +03:00
Alexey Milovidov
2441be4b66 Step 2: move code to .cpp 2020-10-03 03:02:47 +03:00
Alexey Milovidov
6608de470d Step 1: handle EINTR in statvfs 2020-10-03 03:01:32 +03:00
alexey-milovidov
cb708212a8
Merge pull request #15536 from ClickHouse/fix_ilike 
Separate cache for ilike after like
 2020-10-03 02:07:40 +03:00
Azat Khuzhin
f25c1742b8 Pass through *_for_user settings via Distributed with cluster-secure 
In cluster-secure case the user on shards (remote) is equal to the user
on the initiator, so those settings can be safely applied.
 2020-10-03 02:04:47 +03:00
Azat Khuzhin
2a2f858365 Significantly reduce memory usage in AggregatingInOrderTransform 
Clean the aggregates pools (Arena's objects) between flushes, this will
reduce memory usage significantly (since Arena is not intended for
memory reuse in the already full Chunk's)

Before this patch you cannot run SELECT FROM huge_table GROUP BY
primary_key SETTINGS optimize_aggregation_in_order=1 (and the whole
point of optimize_aggregation_in_order got lost), while after, this
should be possible.
 2020-10-03 00:56:58 +03:00
Pavel Kruglov
7acd85d2b1 Fix style error 2020-10-02 22:20:35 +03:00
alesapin
77c9f7af79
Merge pull request #15532 from ClickHouse/substitute_defaults_recursively 
Fix defaults substitution for absent columns which depend on other defaults
 2020-10-02 21:42:01 +03:00
Alexander Tokmakov
6b2da861dc Merge branch 'master' into write_structure_of_table_functions 2020-10-02 20:46:58 +03:00
Pavel Kruglov
f6f4285348 Improve quantileTDigest performance 2020-10-02 20:13:55 +03:00
Azat Khuzhin
9cb3c743bd
Convert to python3 (#15007) 2020-10-02 19:54:07 +03:00
feng lv
d2f75f8508 fix 2020-10-02 23:13:28 +08:00
Nikolai Kochetov
404c199448
Merge pull request #15509 from markpapadakis/patch-6 
Update ActionsVisitor.cpp
 2020-10-02 18:07:46 +03:00
alesapin
8c0581c503 Fix ilike cache 2020-10-02 17:27:47 +03:00
nvartolomei
d35ac3c3fb
Add missing entry to client packet stringify 
(noticed while reading the code)
 2020-10-02 15:10:19 +01:00
Azat Khuzhin
21deb6812c
Drop unused code for numeric_limits<int128> in MergeTreeDataSelectExecutor (#15519) 2020-10-02 16:46:20 +03:00
alesapin
ef9728da79 Fix comment 2020-10-02 15:54:51 +03:00
alesapin
17b86dec96 Recursive defaults 2020-10-02 15:38:50 +03:00
Alexander Kuzmenkov
3be7c7745e Use a separate overload for formatting with fmt 2020-10-02 14:06:38 +03:00
Nikolai Kochetov
56141a1e6b
Update ActionsVisitor.cpp 2020-10-02 12:13:26 +03:00
alesapin
c0d1416bbd
Merge pull request #15516 from nvartolomei/nv/error-out-for-wrong-parameters-replicatedmergetree 
Throw an error when a single parameter is passed to ReplicatedMergeTree instead of ignoring it
 2020-10-02 10:18:28 +03:00
Nicolae Vartolomei
eb1d253355 Throw an error when a single parameter is passed to ReplicatedMergeTree instead of ignoring it 2020-10-01 17:59:50 +01:00
Alexander Kuzmenkov
6e07bfe7bc return the comment 2020-10-01 17:29:22 +03:00
Alexander Kuzmenkov
c20053351c Make the test throw more comprehensive errors 2020-10-01 17:23:48 +03:00
alesapin
0f92f60ab2
Update ActionsVisitor.cpp 2020-10-01 14:35:56 +03:00
Alexander Kuzmenkov
c5d6e2e67c Add context to error messages 2020-10-01 14:02:53 +03:00
Alexander Kuzmenkov
99915fa444 remove unrelated changes 2020-10-01 14:00:58 +03:00
Alexander Kuzmenkov
608b6e3a25 Merge remote-tracking branch 'origin/master' into HEAD 2020-10-01 14:00:22 +03:00
Nikolai Kochetov
3792d688c0
Merge pull request #14741 from ClickHouse/expression-dag 
ActionsDAG
 2020-10-01 12:50:32 +03:00
Alexander Kuzmenkov
bc66dc99d1 Merge remote-tracking branch 'origin/master' into HEAD 2020-10-01 12:28:30 +03:00
Mark Papadakis
b642bd494d
Update ActionsVisitor.cpp 
Refactoring: eliminated a local, throws if it matches the column name as opposed to iterating to the end of the container.
 2020-10-01 12:03:19 +03:00
alesapin
8bc9ede711 Fix clang tidy 2020-10-01 09:53:47 +03:00
alesapin
5622a0769f
Merge pull request #15477 from ClickHouse/fix_ddl_worker_wait 
Fix wait event subscription in DDLWorker
 2020-10-01 09:51:47 +03:00
alexey-milovidov
9808d0be81
Merge pull request #15376 from excitoon-favorites/fixs3storage 
Fixed compression in S3 storage
 2020-10-01 04:30:32 +03:00
Alexandra Latysheva
e89a56969f first part 2020-09-30 23:16:27 +00:00
tavplubix
2f95609f98
Merge pull request #15448 from ClickHouse/allow_synchronous_drop_for_atomic_db 
Allow synchronous DROP/DETACH TABLE for Atomic
 2020-10-01 01:14:31 +03:00
Artem Zuikov
0f6a6453fe
Remove multiple_joins_rewriter v1 (#15472) 2020-09-30 23:11:49 +03:00
Artem Zuikov
0ac18a382f
Fix JOIN with GROUP BY over StorageMerge (#15242) 2020-09-30 23:11:27 +03:00
alesapin
97c2579fb9 Use separate function 2020-09-30 22:50:23 +03:00
alesapin
ac9f0ff4da More strict check for version column 2020-09-30 22:44:35 +03:00
Alexander Kuzmenkov
e45edd57f2 Add reinterpretAsUUID function 2020-09-30 20:19:32 +03:00
Vladimir Chebotarev
0497ce4f9c Possibly better fix. 2020-09-30 18:29:10 +03:00
alesapin
cfe9a0c4a1 Fix event subscription in DDLWorker 2020-09-30 17:58:27 +03:00
Nikolai Kochetov
45618c9d4c
Merge pull request #15437 from ClickHouse/azat-ThreadPool-UAF-fixes 
Destroy resources captured by lambda after `ThreadFromGlobalPool::join()`
 2020-09-30 16:50:30 +03:00
Nikolai Kochetov
0b1fe69ad7 Fix build. 2020-09-30 16:31:06 +03:00
Vladimir Chebotarev
b460024356 Fixed bug in GZIP compression in S3 storage. 2020-09-30 16:09:55 +03:00
Nikolai Kochetov
a1aca04711 Fix build. 2020-09-30 15:32:37 +03:00
Vladimir Chebotarev
a38c7ff2a8 Somehow uncompressed PUT works and gzipped PUT doesn't, in S3 storage. 2020-09-30 15:04:42 +03:00
Nikolai Kochetov
782823de4d Fix build. 2020-09-30 14:45:47 +03:00
Vladimir Chebotarev
698768add0 Fixed format argument in S3 storage when compression method is selected. 2020-09-30 13:55:44 +03:00
alesapin
01d8a36cd6
Merge pull request #15456 from ClickHouse/more-exception-safety-in-shellcommand 
Fix exception safety in ShellCommand
 2020-09-30 12:56:55 +03:00
tavplubix
c9eeb149fd
Merge pull request #15384 from zhang2014/fix/ISSUES-15365 
ISSUES-15365 fix attach mysql database database
 2020-09-30 11:27:15 +03:00
Nikolai Kochetov
0e412686bc Better comments. 2020-09-30 11:25:22 +03:00
alexey-milovidov
0c07c2d3a3
Merge pull request #15089 from ClickHouse/codecs_for_nested_types 
Codecs for nested types
 2020-09-30 07:18:19 +03:00
feng lv
c857b5dd5d fix 2020-09-30 09:50:23 +08:00
alexey-milovidov
412a54e356
Merge pull request #14693 from hustnn/zk_exist_fix2 
Fix potential memory leak caused by zookeeper exist calling
 2020-09-30 04:48:11 +03:00
alexey-milovidov
b6bccfc4f4
Merge pull request #14776 from Vxider/disable_set_and_join_persistency 
Support memory only mode for StorageJoin and StorageSet.
 2020-09-30 04:35:43 +03:00
alexey-milovidov
ac989f3a8f
Merge pull request #15285 from ucasFL/now-with-timezone 
function `now` allow an argument with timezone
 2020-09-30 04:32:36 +03:00
Alexey Milovidov
78dbf10c7b Fix exception safety in ShellCommand 2020-09-30 03:00:45 +03:00
Alexander Tokmakov
e156e6115e add setting 2020-09-30 01:30:34 +03:00
alexey-milovidov
b658f348a7
Update MergeTreeDataPartWriterWide.cpp 2020-09-30 01:23:42 +03:00
alexey-milovidov
9f944424cf
Merge pull request #15364 from ClickHouse/format-raw-blob 
Add format RawBLOB
 2020-09-30 01:14:40 +03:00
alexey-milovidov
3e99ca797b
Merge pull request #15426 from ClickHouse/format-regexp-escaping-rule-change-default-to-raw 
Format Regexp: change default escaping rule to Raw
 2020-09-30 01:14:08 +03:00
Nikolai Kochetov
727289cb09 Destroy resurces captured by lambda after ThreadFromGlobalPool::join(). 2020-09-29 23:43:02 +03:00
Nikolai Kochetov
a2c70c4611 Destroy resurces captured by lambda after ThreadFromGlobalPool::join(). 2020-09-29 22:11:40 +03:00
Artem Zuikov
86cfc6f914
change error code (#15452) 2020-09-29 20:36:14 +03:00
alesapin
4ab39d2bee
Fix style 2020-09-29 18:19:30 +03:00
Alexander Tokmakov
cf86e19f38 fix build 2020-09-29 17:15:05 +03:00
Alexander Tokmakov
8692c10495 add alias 2020-09-29 17:12:40 +03:00
Alexander Tokmakov
5d19ed04f6 allow synchronous drop/detach table for Atomic 2020-09-29 16:47:08 +03:00
Nikolai Kochetov
33487c0e4a
Merge pull request #15422 from ClickHouse/query-plan-header-remove-columns 
Remove column from header descriotion for EXPLAIN PLAN
 2020-09-29 15:51:09 +03:00
feng lv
4f000388a7 add setting output_format_pretty_row_numbers 2020-09-29 20:30:36 +08:00
alesapin
65a05a970d Better message on error 2020-09-29 15:07:01 +03:00
Alexander Kuzmenkov
2d456e2cd6
Merge pull request #15407 from detailyang/master 
bugfix:aggregate:fix boundingratio args check
 2020-09-29 14:12:54 +03:00
Nikolai Kochetov
a7e7fd084f Destroy resurces captured by lambda after ThreadFromGlobalPool::join(). 2020-09-29 13:48:11 +03:00
Nikolai Kochetov
de56c02525 Merge branch 'master' into expression-dag 2020-09-29 12:18:29 +03:00
Nikolai Kochetov
53d4e5d195 Merge branch 'master' into expression-dag 2020-09-29 12:15:50 +03:00
Azat Khuzhin
1fcc36ef80 Use ThreadPool to ensure that everything has been finished in PipelineExecutor 
This will fix possible UAF, since ThreadFromGlobalPool cannot wait until
the job will be reseted, for this you need to call ThreadPool::wait()
(that waits until scheduled_jobs will be zero), and this guarantee that
the job was reseted, otherwise some variables that job is referencing
may be already destroyed, while job hasn't been destoyed yet (example
that I found PipelineExecutor -> ThreadGroupStatusPtr -> MemoryTracker
-> ~MemoryTracker -> log, while log had been destroyed already, here is
TSAN report --
https://gist.github.com/azat/d480dc3af5a0a44de4b038e20807c4b9, copied
from
https://clickhouse-test-reports.s3.yandex.net/15035/79133a426fdf042e383ea0cdccc4dc8273baa3a7/functional_stateless_tests_(thread)/test_run.txt.out.log)
 2020-09-29 11:00:03 +03:00
Azat Khuzhin
789434994a Reset job on failure too in ThreadPool::worker() 
job should be reseted before decrementing scheduled_jobs to
ensure that the Job destroyed before wait() returns.
 2020-09-29 10:56:36 +03:00
zhang2014
9e94c077e7 IESSUES-15365 try fix integration test 2020-09-29 10:39:30 +08:00
Alexey Milovidov
dee57d7976 Format Regexp: change default escaping rule to Raw 2020-09-29 00:19:13 +03:00
Alexey Milovidov
e4800e7b35 Fix comment 2020-09-29 00:10:36 +03:00
Nikolai Kochetov
347080ff9a Remove column from header descriotion for EXPLAIN PLAN and EXPLAIN PIPELINE 2020-09-28 20:37:11 +03:00
Alexander Kuzmenkov
51b9aaf4d8
Merge pull request #15363 from ClickHouse/format-regexp-raw 
Add support for "Raw" column format for Regexp format
 2020-09-28 20:03:32 +03:00