Commit Graph

10038 Commits

Author SHA1 Message Date
Nikolai Kochetov
3c6db8ebc1 Fix prewhere with aliased columns. [#CLICKHOUSE-3944] 2018-09-04 21:28:01 +03:00
chertus
1ea6bc9691 decimal_check_overflow [CLICKHOUSE-3765] 2018-09-04 18:04:23 +03:00
Alexey Zatelepin
4f91833e67 Merge branch 'master' into alter-update
Conflicts:
	dbms/src/Parsers/ASTIdentifier.cpp
2018-09-04 17:39:08 +03:00
Alexey Zatelepin
816b91e2e3 additional checks for UPDATEs of key columns [#CLICKHOUSE-13] 2018-09-04 17:34:50 +03:00
Alexey Zatelepin
b6a5bbc4e9 move validation to MutationsInterpreter [#CLICKHOUSE-13] 2018-09-04 17:33:48 +03:00
CurtizJ
8d8aeb51e5 fix and optimize multiplying aggregate states 2018-09-04 17:08:35 +03:00
proller
e687693df8 Merge remote-tracking branch 'upstream/master' into fix8 2018-09-04 15:12:34 +03:00
Alexey Zatelepin
dc0c731c10 later mutation stages now work with IN (SELECT ...) [#CLICKHOUSE-13] 2018-09-04 14:39:10 +03:00
Vadim
2dd0c4c594
Merge pull request #3032 from yandex/amosbird_window_funnel
[FIX TESTS] Support events qualified for multiple conditions in Window Funnel
2018-09-04 14:32:58 +03:00
Nicolae Vartolomei
e28753061f Tidy up thread locals usage across translation units
Fixes #3015.
2018-09-03 22:36:16 +01:00
proller
b9e4c69dd2 fix 2018-09-03 23:09:51 +03:00
Alexey Zatelepin
d4d1020798 execute UPDATEs and DELETEs in stages [#CLICKHOUSE-13] 2018-09-03 22:34:49 +03:00
proller
bcfcd257be Better odbc-bridge executable select 2018-09-03 21:27:56 +03:00
alexey-milovidov
604c64f40d
Merge pull request #3024 from 4ertus2/nan
hotfix for NaN comparison [CLICKHOUSE-3760]
2018-09-03 21:11:20 +03:00
Alexey Milovidov
8fae37f5c7 Removed wrong code from StorageSystemColumns #2447 2018-09-03 21:04:29 +03:00
chertus
60a39c28d1 better NaN comparison fix [CLICKHOUSE-3760] 2018-09-03 18:57:39 +03:00
alesapin
3719558bf7 CLICKHOUSE-3894: Some improvements in flapping tests. Bug fix of ATTACH TABLE xxx ON CLUSTER (previously doesn't work). 2018-09-03 17:06:00 +03:00
chertus
522674d37f fix for NaN comparison [CLICKHOUSE-3760] 2018-09-03 16:34:16 +03:00
alesapin
69df618397 Merge remote-tracking branch 'upstream/master' 2018-09-03 14:57:11 +03:00
VadimPE
3b38879b11 fix bug with CumSum and fix style 2018-09-03 13:52:44 +03:00
chertus
c03291ce60 extract callOnTypeIndex.h from FunctionHelpers.h [CLICKHOUSE-3765] 2018-09-03 13:46:58 +03:00
alesapin
a7bd2b42e8 CLICKHOUSE-3800: Review fixes 2018-09-03 13:14:05 +03:00
alesapin
83574eed7c Merge remote-tracking branch 'upstream/master' 2018-09-03 13:11:33 +03:00
alesapin
11d248ba10 Resolve conflict 2018-09-03 13:11:10 +03:00
CurtizJ
3bc743c50d do not merge blocks into one 2018-09-03 12:49:04 +03:00
chertus
79c91bb23b minor fix: better code locality [CLICKHOUSE-3765] 2018-09-03 12:15:44 +03:00
Alexey Milovidov
eb8f06821d Fixed build [#CLICKHOUSE-2] 2018-09-03 09:31:19 +03:00
Alexey Milovidov
226a7f491e Whitespaces [#CLICKHOUSE-3944] 2018-09-03 08:06:19 +03:00
Alexey Milovidov
d2a127ffa9 Less dependencies [#CLICKHOUSE-2] 2018-09-03 07:57:01 +03:00
Alexey Milovidov
6831b6c0f9 Fixed build; fixed possibly suboptimal code #3008 2018-09-03 07:29:36 +03:00
alexey-milovidov
72c799ad76
Merge pull request #3008 from 4ertus2/decimal
even more Decimal
2018-09-03 07:19:33 +03:00
alexey-milovidov
7d8f0a6140
Merge pull request #3022 from yandex/padded-arena
Padded Arena
2018-09-03 05:39:42 +03:00
Alexey Milovidov
3873ab1adb Fixed tests in Sandbox [#CLICKHOUSE-2] 2018-09-03 05:32:29 +03:00
Alexey Milovidov
aa5d919f33 Miscellaneous [#CLICKHOUSE-2] 2018-09-03 03:39:22 +03:00
Alexey Milovidov
cb0af7c3af Removed unused aggregation method [#CLICKHOUSE-2] 2018-09-03 03:33:29 +03:00
Alexey Milovidov
8e17652f0d Removed AggregationMethodConcat, because AggregationMethodSerialized appeared to be far superior [#CLICKHOUSE-2] 2018-09-03 03:07:05 +03:00
Alexey Milovidov
0b2ec39f11 Miscellaneous [#CLICKHOUSE-2] 2018-09-03 03:00:56 +03:00
Alexey Milovidov
13aac718a3 Reverted wrong change [#CLICKHOUSE-2] 2018-09-03 01:24:46 +03:00
Alexey Milovidov
1de3f144f6 Padding chunks in Arena in attempt to improve performance [#CLICKHOUSE-2] 2018-09-03 00:28:25 +03:00
Alexey Milovidov
6acd58ee60 Respect alignment in groupArray function [#CLICKHOUSE-2] 2018-09-02 22:53:35 +03:00
Alexey Milovidov
4b01c2d9ba Added comment [#CLICKHOUSE-2] 2018-09-02 22:49:12 +03:00
VadimPE
003ce833d1 Merge branch 'master' of https://github.com/amosbird/ClickHouse into amosbird_window_funnel 2018-09-02 17:49:59 +03:00
Alexey Milovidov
9af71bb733 Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 08:25:32 +03:00
Alexey Milovidov
26587dd2bb Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 08:23:20 +03:00
Alexey Milovidov
03038c75c4 Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 08:07:49 +03:00
Alexey Milovidov
24675aed1a Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 08:01:21 +03:00
Alexey Milovidov
77ccc8c65c Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 07:58:55 +03:00
Alexey Milovidov
8d76be1dfd Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 07:41:40 +03:00
Alexey Milovidov
5f7825a91c Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 07:36:32 +03:00
Alexey Milovidov
f93ede0182 Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 07:33:15 +03:00
Alexey Milovidov
bf443fcfa0 Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 07:30:55 +03:00
Alexey Milovidov
ab78bc1b5c Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 07:13:15 +03:00
Alexey Milovidov
a903a5a755 Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 06:58:31 +03:00
Alexey Milovidov
b9c4820bdd Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 06:52:04 +03:00
Alexey Milovidov
ff13752d01 Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 06:47:14 +03:00
Alexey Milovidov
afe3973325 Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 06:43:31 +03:00
Alexey Milovidov
66afebc498 Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 06:40:15 +03:00
Alexey Milovidov
538edbb8e2 Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 06:33:48 +03:00
Alexey Milovidov
6c61dbde26 Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 06:14:00 +03:00
Alexey Milovidov
d27c7ed08a Addition to prev. revision [#CLICKHOUSE-2] 2018-09-02 06:10:21 +03:00
Alexey Milovidov
fc27be314b Avoid temporary nullptr references [#CLICKHOUSE-2] 2018-09-02 06:00:04 +03:00
Alexey Milovidov
684d3f6162 Fixed bug #2830 2018-09-02 05:27:56 +03:00
Alexey Milovidov
c3ca20c25c Rectification of FunctionsComparison [#CLICKHOUSE-2] 2018-09-02 05:09:15 +03:00
Alexey Milovidov
9e5778134d Miscellaneous #3018 2018-09-02 04:54:24 +03:00
Alexey Milovidov
c306bca055 Rectification of FunctionsComparison [#CLICKHOUSE-2] 2018-09-02 04:42:18 +03:00
Alexey Milovidov
3a24e636db Rectification of FunctionsComparison [#CLICKHOUSE-2] 2018-09-02 04:40:47 +03:00
Alexey Milovidov
f47c30c85b Rectification of FunctionsComparison [#CLICKHOUSE-2] 2018-09-02 04:26:08 +03:00
Alexey Milovidov
e97d1bb63f Rectification of FunctionsComparison [#CLICKHOUSE-2] 2018-09-02 04:12:32 +03:00
Alexey Milovidov
f97d9e8f3f Fixed build #2957 2018-09-02 03:25:33 +03:00
Alexey Milovidov
f7107f12b4 Merge branch 'master' into extra-warnings 2018-09-02 03:13:36 +03:00
alexey-milovidov
16dc142a05
Merge pull request #3017 from yandex/ubsan-fixes
Fixes for UBSan.
2018-09-02 03:12:20 +03:00
Alexey Milovidov
1c2e4c3654 Documentation for ProfileEvents (more) #3010 2018-09-02 03:11:17 +03:00
Alexey Milovidov
63767c3c4e Documentation for ProfileEvents (more) #3010 2018-09-02 03:06:42 +03:00
Alexey Milovidov
ed6b5fe9eb Documentation for ProfileEvents (more) #3010 2018-09-02 03:05:09 +03:00
Alexey Milovidov
788a97dca1 Documentation for ProfileEvents (draft) #3010 2018-09-02 02:43:43 +03:00
Alexey Milovidov
c8fc8e8cbe Documentation for ProfileEvents (draft) #3010 2018-09-02 02:14:48 +03:00
Alexey Milovidov
8eb746b216 Documentation for ProfileEvents (draft) #3010 2018-09-02 02:13:17 +03:00
Alexey Milovidov
e78dbcbb88 Merge branch 'master' of github.com:yandex/ClickHouse 2018-09-02 02:11:28 +03:00
Alexey Milovidov
35b573e4d2 Documentation for ProfileEvents (draft) #3010 2018-09-02 02:11:11 +03:00
Alexey Milovidov
45a4a95959 Fixed error in UBSan [#CLICKHOUSE-2] 2018-09-02 00:18:33 +03:00
Alexey Milovidov
c75cc14703 Fixed error in UBSan [#CLICKHOUSE-2] 2018-09-01 23:28:46 +03:00
Alexey Milovidov
751cf62262 Added documentation for CurrentMetrics #3010 2018-09-01 22:51:38 +03:00
Alexey Milovidov
f5d03f6ac2 Miscellaneous [#CLICKHOUSE-2] 2018-09-01 22:14:04 +03:00
alexey-milovidov
64b48b5fcf
Merge pull request #2907 from zhang2014/feature/support_join_for_table_function
ISSUES-2906 support join for table function
2018-09-01 20:49:49 +03:00
alexey-milovidov
087570e6ac
Merge pull request #2974 from zhang2014/fix/nested_json_for_visitRaw
ISSUES-2973 support nested json struct for visitParamExtractRaw
2018-09-01 20:47:42 +03:00
alexey-milovidov
889e060993
Merge pull request #3006 from VadimPE/CLICKHOUSE-1660
CLICKHOUSE-1660 Added duplicated columns removal in USING(...)
2018-09-01 20:43:54 +03:00
Alexey Milovidov
ce032470b3 Full support for alignment of aggregate states #2808 2018-09-01 07:39:46 +03:00
Alexey Milovidov
338437baf7 Full support for alignment of aggregate states #2808 2018-09-01 07:28:12 +03:00
Alexey Milovidov
146f3f0a14 Full support for alignment of aggregate states #2808 2018-09-01 07:25:43 +03:00
Alexey Milovidov
7d77d001f5 Full support for alignment of aggregate states #2808 2018-09-01 07:25:03 +03:00
Alexey Milovidov
8f54125884 Minor modifications #2808 2018-09-01 06:17:43 +03:00
alexey-milovidov
6d5092518f
Merge pull request #2808 from chenxing-xc/master
Aligned aggregate state  #2754
2018-09-01 05:38:11 +03:00
Alexey Milovidov
652ecc42c6 Fixed alignment issues with AutoArray [#CLICKHOUSE-2] 2018-09-01 04:03:34 +03:00
chertus
fe1e3300b7 remove dirty code [CLICKHOUSE-3765] 2018-08-31 20:36:27 +03:00
VadimPE
f8f71f7327 add tests 2018-08-31 16:28:35 +03:00
alesapin
66eb5402b0 Fix style 2018-08-31 16:25:33 +03:00
alesapin
a3ebbea3a0 Fix style 2018-08-31 16:23:56 +03:00
VadimPE
b30167576d change return type in arrayDifference 2018-08-31 15:55:10 +03:00
alesapin
650d15696f CLICKHOUSE-3800: Add memory comsumption profile_event of compiled expression cache 2018-08-31 15:39:27 +03:00
VadimPE
21a5f745ac Merge branch 'cum_sum_limit2' of https://github.com/astudnev/ClickHouse-1 into astudnev-cum_sum_limit2 2018-08-31 15:14:49 +03:00
chertus
ca91c93adf disable Nullable(Decimal) [CLICKHOUSE-3905] 2018-08-31 14:59:33 +03:00
alesapin
ac6ab62c6f CLICKHOUSE-3800: Remove use after free of context 2018-08-31 13:27:08 +03:00
VadimPE
db8e63ff67 CLICKHOUSE-1660 Added duplicated columns removal in USING(...) 2018-08-31 13:00:46 +03:00
chertus
845db9b46e CAST for decimal [CLICKHOUSE-3905] 2018-08-31 11:59:21 +03:00
zhang2014
a1f2b9ae0c ISSUES-2973 support nested json struct for visitParamExtractRaw 2018-08-31 15:25:28 +08:00
alesapin
711b228a30 Merge remote-tracking branch 'upstream/master' 2018-08-31 10:15:33 +03:00
Alexey Milovidov
9966e4405b Merge branch 'master' of github.com:yandex/ClickHouse 2018-08-31 04:46:51 +03:00
Alexey Milovidov
8aecbc6df6 Data streams: better [#CLICKHOUSE-3944] 2018-08-31 04:46:39 +03:00
alexey-milovidov
a05cdfbb45
Merge branch 'master' into extra-warnings 2018-08-31 03:03:44 +03:00
Alexey Milovidov
0c6c1e83a3 Avoid excessive padding in Pretty formats [#CLICKHOUSE-2] 2018-08-31 02:34:12 +03:00
Alexey Milovidov
5df5df8971 utils/check-style/check-style -n 2018-08-31 00:13:34 +03:00
alexey-milovidov
918d17ffeb
Update FunctionsVisitParam.h 2018-08-30 23:57:00 +03:00
alexey-milovidov
46a38b72b9
Merge pull request #2975 from amosbird/dense
Extending arrayEnumerateUniq.
2018-08-30 23:26:31 +03:00
alexey-milovidov
c9838fdf34
Update FunctionsArray.cpp 2018-08-30 23:22:14 +03:00
Alexey Milovidov
06053d9c1f Added comments #2980 2018-08-30 23:12:15 +03:00
alexey-milovidov
e0b1b5ff78
Merge pull request #2980 from amosbird/memcpySmall
Padding for IO buffers.
2018-08-30 22:53:47 +03:00
alexey-milovidov
3b8e3c854c
Merge pull request #3000 from proller/fix3
CLICKHOUSE-3940 Fix crash on join
2018-08-30 22:52:59 +03:00
alexey-milovidov
f22b12b698
Update Join.cpp 2018-08-30 22:52:28 +03:00
alesapin
81a333ee87
Return to odbc-bridge argument. 2018-08-30 22:35:59 +03:00
Alexey Milovidov
76eaacf1be Fixed tests in Sandbox [#CLICKHOUSE-2] 2018-08-30 22:27:36 +03:00
alesapin
d192c8a2f3 Fix again 2018-08-30 22:23:55 +03:00
alesapin
6bfde2825e Fix conflict 2018-08-30 22:23:00 +03:00
alexey-milovidov
72a2405e09
Merge pull request #3002 from proller/fix13
USE_INTERNAL_CONSISTENT_HASHING_LIBRARY
2018-08-30 22:11:55 +03:00
proller
de2b740db7 USE_INTERNAL_CONSISTENT_HASHING_LIBRARY 2018-08-30 22:07:24 +03:00
Alexey Milovidov
6ccd74aeeb Attempt to fix performance regression due to usage of taskstats #2482 2018-08-30 21:48:41 +03:00
proller
48766c1c2d split libconsistent-hashing 2018-08-30 21:44:46 +03:00
Alexey Milovidov
c06d6b7ae6 Moved file (preparation) #2482 2018-08-30 21:40:46 +03:00
Alexey Milovidov
fd5c419f17 Miscellaneous #2482 2018-08-30 21:36:24 +03:00
alesapin
ed34ffc94e
Merge branch 'master' into master 2018-08-30 19:34:29 +03:00
alesapin
6e64067a70 CLICKHOUSE-3800: Move cache to context, change hashing algorithm, add drop instruction for compiled expressions cache 2018-08-30 19:31:20 +03:00
proller
81960a2690 CLICKHOUSE-3940 Fix crash on join 2018-08-30 18:44:30 +03:00
Alexey Zatelepin
e9493b3a5f use hard links to copy columns that didn't change [#CLICKHOUSE-13] 2018-08-30 16:56:43 +03:00
Alexey Zatelepin
dc2a4c21e9 execute ALTER UPDATE [#CLICKHOUSE-13] 2018-08-30 16:56:43 +03:00
Alexey Zatelepin
8e7c58dd75 parse ALTER UPDATE command [#CLICKHOUSE-13] 2018-08-30 16:56:43 +03:00
VadimPE
5551f2902c CLICKHOUSE-1660 2018-08-30 15:32:11 +03:00
alexey-milovidov
b05c62be9f
Merge pull request #2994 from CurtizJ/CLICKHOUSE-3935
ClickHouse-3935  Fix bug with qualified columns in where clause
2018-08-30 15:01:47 +03:00
alexey-milovidov
2e22a14c5c
Merge pull request #2997 from VadimPE/fix_exception_message
Fix error message in exception message for DROP TABLE/PARTITION
2018-08-30 14:19:58 +03:00
VadimPE
81893ae577 Fix error message 2018-08-30 12:33:31 +03:00
CurtizJ
764aa70d04 fix bug with quailified columns in where clause 2018-08-30 01:09:04 +03:00
CurtizJ
b43d403815 Revert "fix bug with quailified columns in where clause"
This reverts commit e007fd2b9e.
2018-08-30 01:04:45 +03:00
proller
56e571f18d odbc-bridge fixes (#2993)
* start clickhouse odbc-bridge as clickhouse-odbc-bridge

* fix

* prepare to odbc bridge tests
2018-08-30 00:32:46 +03:00
Alexey Milovidov
c94e0f0161 Fixed tests in Sandbox [#CLICKHOUSE-2] 2018-08-30 00:30:39 +03:00
alesapin
647446c45e CLICKHOUSE-3800: More correct compilated function call counter 2018-08-29 23:05:31 +03:00
CurtizJ
e007fd2b9e fix bug with quailified columns in where clause 2018-08-29 22:45:29 +03:00
Alexey Milovidov
c34d36bf35 Fixed tests in Sandbox [#CLICKHOUSE-2] 2018-08-29 22:01:01 +03:00
chertus
29d8d07975 decimal improvements [CLICKHOUSE-3765] 2018-08-29 21:47:19 +03:00
alexey-milovidov
794b4d30a8
Merge pull request #2989 from yandex/fix-context-lifetime-try-2-quick
Fix lifetime of Context reference in functions (first quick variant) …
2018-08-29 21:32:48 +03:00
alexey-milovidov
07408490b6
Merge pull request #2982 from VadimPE/CLICKHOUSE-3934
CLICKHOUSE-3934 add join_default_strictness
2018-08-29 21:32:03 +03:00
alexey-milovidov
b99bf0c558
Update Settings.h 2018-08-29 21:27:41 +03:00
alesapin
06adf19053 CLICKHOUSE-3800: Remove tab 2018-08-29 20:51:23 +03:00
alesapin
d2a5efb11b CLICKHOUSE-3800: Add perf test 2018-08-29 20:49:43 +03:00
Alexey Milovidov
3361247126 Fix lifetime of Context reference in functions (first quick variant) [#CLICKHOUSE-2] 2018-08-29 18:36:24 +03:00
Alexey Milovidov
4ebfaa768e Miscellaneous [#CLICKHOUSE-2] 2018-08-29 18:16:34 +03:00
VadimPE
f253719eac CLICKHOUSE-3934 add SettingsJoinStrictness 2018-08-29 18:15:42 +03:00
alesapin
7498105b67 CLICKHOUSE-3800: Fix hash and equals functions 2018-08-29 18:14:44 +03:00
Alexey Milovidov
697067f207 Fix lifetime of Context reference in functions (first quick variant) [#CLICKHOUSE-2] 2018-08-29 17:59:08 +03:00
Alexey Milovidov
87dfd8e47e Removed useless field #2447 2018-08-29 17:55:28 +03:00
VadimPE
d626ae11a7 CLICKHOUSE-3934 2018-08-29 16:54:43 +03:00
Vadim Plakhtinskiy
f0c16900aa CLICKHOUSE-3934 fix bug with CROSS JOIN 2018-08-29 16:51:07 +03:00
chertus
7bac9698f6 fix build 2018-08-29 16:24:33 +03:00
chertus
9becb21e52 better comments for IColumn [CLICKHOUSE-2] 2018-08-29 15:10:18 +03:00
chertus
a69c936b44 improve field visitors for UUID CLICKHOUSE-3249 2018-08-29 14:58:40 +03:00
alesapin
a8db29c714 Merge remote-tracking branch 'upstream/master' 2018-08-29 11:42:50 +03:00
zhang2014
f921c9c169 ISSUES-863 support optimize predicate for view 2018-08-29 13:29:03 +08:00
Amos Bird
8851fbcab2 Padding for IO buffers.
Testing data

```
select 'aaaaaaaa','bbbbbbbb','cccccccc','dddddddd','eeeeeeee','ffffffff','gggg','hhh' from numbers(3000000) into outfile '/tmp/test.tsv'
```

Testing command
```
echo "select count() from file('/tmp/test.tsv', CSV, 'a String, b String, c String, d String, e String, f String, g String, h String') where not ignore(e)" | clickhouse-benchmark
```

TSV parser has less overhead than CSV, using it would better unveil the benefits of memcpySmall.

Before
```
QPS: 1.662, RPS: 4985463.906, MiB/s: 603.823, result RPS: 1.662, result MiB/s: 0.000.
0.000%  0.559 sec.
10.000% 0.564 sec.
20.000% 0.568 sec.
30.000% 0.572 sec.
40.000% 0.575 sec.
50.000% 0.581 sec.
60.000% 0.592 sec.
70.000% 0.624 sec.
80.000% 0.639 sec.
90.000% 0.664 sec.
95.000% 0.686 sec.
99.000% 0.711 sec.
99.900% 0.715 sec.
99.990% 0.716 sec.
```

After
```
QPS: 1.861, RPS: 5582303.107, MiB/s: 676.110, result RPS: 1.861, result MiB/s: 0.000.
0.000%  0.510 sec.
10.000% 0.514 sec.
20.000% 0.517 sec.
30.000% 0.521 sec.
40.000% 0.523 sec.
50.000% 0.527 sec.
60.000% 0.530 sec.
70.000% 0.539 sec.
80.000% 0.558 sec.
90.000% 0.584 sec.
95.000% 0.589 sec.
99.000% 0.608 sec.
99.900% 0.655 sec.
99.990% 0.663 sec.
```
2018-08-29 09:39:44 +08:00
alexey-milovidov
a5d7097c08
Merge pull request #2977 from amosbird/sse2csv
Enable sse2 for CSV parsing.
2018-08-29 03:04:17 +03:00
alexey-milovidov
f3b2cf6c11
Merge pull request #2985 from 4ertus2/uuid
field visitors for UUID CLICKHOUSE-3249
2018-08-29 03:02:25 +03:00
Alexey Milovidov
783fc4de27 Merge branch 'master' of github.com:yandex/ClickHouse 2018-08-28 23:39:28 +03:00
Alexey Milovidov
2581d88f0e Better error message: avoid confusion when column is named a [#CLICKHOUSE-3] 2018-08-28 23:39:18 +03:00
proller
18044995ba Fix includes 2018-08-28 22:36:27 +03:00
chertus
6a02b18b93 field visitors for UUID CLICKHOUSE-3249 2018-08-28 21:36:41 +03:00
Alexey Milovidov
f45afa37a8 Miscellaneous [#CLICKHOUSE-3] 2018-08-28 21:25:40 +03:00
alesapin
1a85271702 CLICKHOUSE-3800: Add expression cache 2018-08-28 20:06:42 +03:00
Vadim
9a0802f5bd
fix documentation 2018-08-28 17:52:27 +03:00
Vadim
98abde8480
Update ExpressionAnalyzer.cpp 2018-08-28 17:41:15 +03:00
Vadim
096b5e6a9d
Update ExpressionAnalyzer.cpp 2018-08-28 17:40:07 +03:00
Vadim
564ddbf8d8
Update ExpressionAnalyzer.cpp 2018-08-28 17:33:57 +03:00
Vadim
a8c1199ad4
Merge branch 'master' into CLICKHOUSE-3934 2018-08-28 17:06:17 +03:00
chertus
86dd83d012 fix use of broken context in decimal arithm/comparison 2018-08-28 16:59:52 +03:00
VadimPE
398d38eead CLICKHOUSE-3934 add join_default_strictness 2018-08-28 16:57:31 +03:00
Amos Bird
8d6a26b8df Enable sse2 for CSV parsing.
Testing data

```
select 'aaaaaaaa,bbbbbbbb,cccccccc,dddddddd,eeeeeeee,ffffffff,gggg,hhh' from numbers(3000000) into outfile '/tmp/test.csv'
```

Testing command
```
echo "select count() from file('/tmp/test.csv', CSV, 'a String, b String, c String, d String, e String, f String, g String, h String') where not ignore(e)" | clickhouse-benchmark

```

Before
```
QPS: 1.317, RPS: 3949749.687, MiB/s: 478.380, result RPS: 1.317, result MiB/s: 0.000.
0.000%  0.704 sec.
10.000% 0.712 sec.
20.000% 0.718 sec.
30.000% 0.726 sec.
40.000% 0.739 sec.
50.000% 0.754 sec.
60.000% 0.770 sec.
70.000% 0.788 sec.
80.000% 0.798 sec.
90.000% 0.815 sec.
95.000% 0.826 sec.
99.000% 0.850 sec.
99.900% 0.857 sec.
99.990% 0.858 sec.
```

After
```
QPS: 1.533, RPS: 4598308.336, MiB/s: 556.932, result RPS: 1.533, result MiB/s: 0.000.
0.000%  0.626 sec.
10.000% 0.635 sec.
20.000% 0.639 sec.
30.000% 0.642 sec.
40.000% 0.643 sec.
50.000% 0.645 sec.
60.000% 0.649 sec.
70.000% 0.652 sec.
80.000% 0.658 sec.
90.000% 0.682 sec.
95.000% 0.710 sec.
99.000% 0.727 sec.
99.900% 0.733 sec.
99.990% 0.734 sec.
```
2018-08-28 19:46:11 +08:00
alexey-milovidov
9ff0edc203
Merge pull request #2971 from urykhy/zk-operation-timeout
Make ZK operation timeout configurable
2018-08-28 14:23:09 +03:00
CurtizJ
a603595120 remove redundant code 2018-08-28 12:27:17 +03:00
Amos Bird
a4dfe0ae38 Extending arrayEnumerateUniq.
https://github.com/yandex/ClickHouse/issues/2934
2018-08-28 15:31:25 +08:00
zhang2014
16404c8e7b ISSUES-2973 support nested json struct for visitParamExtractRaw 2018-08-28 13:45:21 +08:00
Alexey Milovidov
3e216f055c Miscellaneous #2758 2018-08-28 03:44:42 +03:00
Alexey Milovidov
9a4b4fbccd Miscellaneous #2758 2018-08-28 03:23:52 +03:00
Alexey Milovidov
236c3872b8 Miscellaneous #2758 2018-08-28 03:23:38 +03:00
Alexey Milovidov
32286484cd Miscellaneous #2758 2018-08-28 03:22:32 +03:00
Alexey Milovidov
52379be265 Miscellaneous #2758 2018-08-28 03:21:02 +03:00
Alexey Milovidov
4f8d324fa7 Miscellaneous #2758 2018-08-28 03:18:32 +03:00
Alexey Milovidov
fa0ffcf8dc Miscellaneous #2758 2018-08-28 03:17:27 +03:00
Alexey Milovidov
2a4b4eefd6 Miscellaneous #2758 2018-08-28 03:10:05 +03:00
Alexey Milovidov
ea643eeff9 Miscellaneous #2758 2018-08-28 03:03:10 +03:00
Alexey Milovidov
7c777c48d7 Miscellaneous #2758 2018-08-28 03:01:03 +03:00
Alexey Milovidov
0a7e288d70 Miscellaneous #2758 2018-08-28 02:59:49 +03:00
Alexey Milovidov
bab6cd504d Miscellaneous #2758 2018-08-27 22:16:38 +03:00
Alexey Milovidov
24bd803c07 Whitespaces #2758 2018-08-27 22:06:32 +03:00
Alexey Milovidov
f5cc5ef877 Merge branch 'CLICKHOUSE-3847' of https://github.com/VadimPE/ClickHouse into VadimPE-CLICKHOUSE-3847 2018-08-27 22:04:14 +03:00
Alexey Milovidov
74fee0dc98 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 21:20:58 +03:00
Alexey Milovidov
a3cd1ea8cb Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 21:16:32 +03:00
Alexey Milovidov
0d02315778 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 21:07:17 +03:00
Alexey Milovidov
3efffba44e Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 21:05:28 +03:00
Alexey Milovidov
956f76e000 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 20:58:43 +03:00
Alexey Milovidov
5b257c588f Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 20:42:13 +03:00
Yury Stankevich
f3024d2fba Make ZK operation timeout configurable 2018-08-27 20:26:19 +03:00
Alexey Milovidov
d4ea8bdb88 Merge remote-tracking branch 'origin/master' into extra-warnings 2018-08-27 20:18:39 +03:00
Alexey Milovidov
6e18af7ed3 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 20:18:14 +03:00
chertus
d6a85d9d63 Merge branch 'master' of github.com:yandex/ClickHouse 2018-08-27 20:17:26 +03:00
chertus
220909eb39 minor fix CLICKHOUSE-3765 2018-08-27 20:17:12 +03:00
alexey-milovidov
98148d914c
Merge pull request #2958 from blahgeek/skip-json-object
Skip object fields on json input
2018-08-27 20:07:32 +03:00
Alexey Milovidov
486d87ebcd Merge remote-tracking branch 'origin/master' into extra-warnings 2018-08-27 20:01:33 +03:00
alexey-milovidov
95b2bcbc6b
Merge pull request #2970 from 4ertus2/decimal
Some more Decimal
2018-08-27 19:59:26 +03:00
alexey-milovidov
3328fb456a
Merge pull request #2966 from amosbird/nrvo
Get rid of useless std::move to get NRVO
2018-08-27 19:56:03 +03:00
chertus
9dbaa5f4a9 remove strange code CLICKHOUSE-3765 2018-08-27 19:46:42 +03:00
CurtizJ
0e28195e7a update syntax and test 2018-08-27 19:43:29 +03:00
Vadim
2d8bffafa3
Update MergeTreeSettings.h 2018-08-27 19:38:54 +03:00
Vadim
4d9d80b271
Update MergeTreeSettings.h 2018-08-27 19:38:36 +03:00
Alexey Milovidov
076e1fb2e1 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 19:31:45 +03:00
VadimPE
418375aa1d Merge branch 'CLICKHOUSE-3847' of https://github.com/VadimPE/ClickHouse into CLICKHOUSE-3847 2018-08-27 19:23:08 +03:00
VadimPE
70ebb6a47d CLICKHOUSE-3847 fix code-style 2018-08-27 19:22:39 +03:00
Alexey Milovidov
e5a2dd8624 Merge branch 'master' into extra-warnings 2018-08-27 19:19:04 +03:00
chertus
ee873c8e9f Merge branch 'master' into decimal 2018-08-27 19:18:48 +03:00
chertus
c86f2878ff add special ColumnDecimal instead of ColumnVector<DecimalNN> CLICKHOUSE-3765 2018-08-27 19:16:16 +03:00
Vadim
64a27e592b
Update ReplicatedMergeTreeCleanupThread.cpp 2018-08-27 19:00:40 +03:00
VadimPE
4d198f2bfe CLICKHOUSE-3847 fix build 2018-08-27 18:54:07 +03:00
VadimPE
0281678c3e CLICKHOUSE-3847 fix code style 2018-08-27 18:44:51 +03:00
Alexey Milovidov
303cc7242f Addition to prev. revision #2956 2018-08-27 18:01:33 +03:00
Alexey Milovidov
6e57168030 Removed code with duplicate semantics [#CLICKHOUSE-2] 2018-08-27 18:01:33 +03:00
alexey-milovidov
7de0549879
Update ReadHelpers.h 2018-08-27 18:00:08 +03:00
alexey-milovidov
01f01b1ee1
Update ReadHelpers.cpp 2018-08-27 17:54:58 +03:00
proller
3acce3bff9 Build fix (#2944)
* Build fix

* Better sample build scripts

* zlib apple fix

* fix

* fix

* better so version

* SPLIT_SHARED -> LINK_MODE

* clean
2018-08-27 17:39:20 +03:00
Amos Bird
ea84430864 Get rid of useless std::move to get NRVO
http://eel.is/c++draft/class.copy.elision#:constructor,copy,elision

Some quote:

> Speaking of RVO, return std::move(w); prohibits it. It means "use move constructor or fail to compile", whereas return w; means "use RVO, and if you can't, use move constructor, and if you can't, use copy constructor, and if you can't, fail to compile."

There is one exception to this rule:
```cpp
Block FilterBlockInputStream::removeFilterIfNeed(Block && block)
{
    if (block && remove_filter)
        block.erase(static_cast<size_t>(filter_column));

    return std::move(block);
}
```

because references are not eligible for NRVO, which is another rule "always move rvalue references and forward universal references" that takes precedence.
2018-08-27 22:15:48 +08:00
VadimPE
a8974f8786 CLICKHOUSE-3847 add Coordinator 2018-08-27 16:51:22 +03:00
alexey-milovidov
806316511f
Merge pull request #2960 from zhang2014/fix/on_cluster_crash
ISSUES-2482 fix crash when on cluster
2018-08-27 16:25:26 +03:00
Vadim
be2d821669
Merge branch 'master' into CLICKHOUSE-3847 2018-08-27 15:26:41 +03:00
Alexey Milovidov
eb165a0616 Tweak error code in ZooKeeper library for correct expectations from the calling code [#CLICKHOUSE-3916] 2018-08-27 15:19:29 +03:00
Vadim
c4e90d89f0
Update ReplicatedMergeTreeCleanupThread.cpp 2018-08-27 15:16:52 +03:00
VadimPE
22aa521884 CLICKHOUSE-3847 fix bug when replica recover and it's log_pointer will be deleted 2018-08-27 15:14:48 +03:00
VadimPE
cf0a7c1529 CLICKHOUSE-3847 fix bug when replica recover and it's log_pointer will be deleted 2018-08-27 15:09:22 +03:00
zhang2014
f8d7cf17a7 ISSUES-2482 fix crash when on cluster 2018-08-27 19:03:22 +08:00
CurtizJ
b48a144d78 add mysql like rollup syntax 2018-08-27 12:50:30 +03:00
CurtizJ
a04c37251b remove redundant code 2018-08-27 12:09:47 +03:00
Alexey Milovidov
252a00e25b Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 10:57:42 +03:00
BlahGeek
739119d355 skip object fields on json input 2018-08-27 12:01:47 +08:00
Alexey Milovidov
eed804ba94 Enabling extra warnings [#CLICKHOUSE-2] 2018-08-26 15:38:45 +03:00
Alexey Milovidov
050a080be3 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:29:42 +03:00
Alexey Milovidov
f7796df158 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:26:55 +03:00
Alexey Milovidov
5f21f1ba7d Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:25:45 +03:00
Alexey Milovidov
167d8ec529 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:19:18 +03:00
Alexey Milovidov
042d84e1e3 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:17:18 +03:00
Alexey Milovidov
281faa1686 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:13:41 +03:00
Alexey Milovidov
8a0239b6ad Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:08:35 +03:00
Alexey Milovidov
a1a70d4a65 Enabling -Wzero-as-null-pointer-constant [#CLICKHOUSE-2] 2018-08-26 04:56:34 +03:00
Alexey Milovidov
625f3fea08 Enabling -Wunused-exception-parameter [#CLICKHOUSE-2] 2018-08-26 04:36:41 +03:00
Alexey Milovidov
44e848856e Enabling -Wunused-exception-parameter [#CLICKHOUSE-2] 2018-08-26 04:33:20 +03:00
Alexey Milovidov
d4ef5d05f2 Enabling -Winconsistent-missing-destructor-override [#CLICKHOUSE-2] 2018-08-26 04:26:25 +03:00
Alexey Milovidov
ac7673db29 Enabling -Wcomma [#CLICKHOUSE-2] 2018-08-26 04:24:21 +03:00
Alexey Milovidov
a70d0b79e4 Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 04:13:02 +03:00
Alexey Milovidov
0fd919fdc5 Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 04:11:58 +03:00
Alexey Milovidov
0ae34550db Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 03:52:58 +03:00
Alexey Milovidov
fa6e364f68 Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 03:51:37 +03:00
Alexey Milovidov
6605098439 Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 03:50:48 +03:00
Alexey Milovidov
52eb8fda3c Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 03:48:38 +03:00
Alexey Milovidov
6779de62d1 Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 03:44:23 +03:00
Alexey Milovidov
c193d15ef2 Merge branch 'master' into generalize-zookeeper 2018-08-26 03:32:15 +03:00
alexey-milovidov
f92bae33f8
Merge pull request #2949 from yandex/distinguish-between-definitely-lost-and-unknown-requests-in-zookeeper
ZooKeeperImpl: allow to distinguish cases when request was definitely not been processed.
2018-08-26 03:12:20 +03:00
Alexey Milovidov
2ce783e016 Merge branch 'read' of https://github.com/amosbird/ClickHouse into amosbird-read 2018-08-26 02:55:22 +03:00
alexey-milovidov
35806a4d27
Merge pull request #2955 from amosbird/varint
Fast path for varint read.
2018-08-26 02:47:04 +03:00
alexey-milovidov
00404a911c
Update VarInt.h 2018-08-26 02:46:18 +03:00
Amos Bird
a589230249 Faster path for varint read.
clickhouse-benchmark <<< 'select count() from s where not ignore(s);'

before this patch:

```

QPS: 0.732, RPS: 2346562049.608, MiB/s: 22378.560, result RPS: 0.732, result MiB/s: 0.000.
0.000%  1.310 sec.
10.000% 1.321 sec.
20.000% 1.327 sec.
30.000% 1.337 sec.
40.000% 1.343 sec.
50.000% 1.359 sec.
60.000% 1.366 sec.
70.000% 1.381 sec.
80.000% 1.400 sec.
90.000% 1.434 sec.
95.000% 1.448 sec.
99.000% 1.489 sec.
99.900% 1.499 sec.
99.990% 1.500 sec.

```

after this patch:

```
QPS: 0.787, RPS: 2524560389.064, MiB/s: 24076.084, result RPS: 0.787, result MiB/s: 0.000.
0.000%  1.228 sec.
10.000% 1.232 sec.
20.000% 1.235 sec.
30.000% 1.241 sec.
40.000% 1.246 sec.
50.000% 1.256 sec.
60.000% 1.265 sec.
70.000% 1.278 sec.
80.000% 1.296 sec.
90.000% 1.321 sec.
95.000% 1.354 sec.
99.000% 1.421 sec.
99.900% 1.453 sec.
99.990% 1.456 sec.
```

I also tried a SSE2 implementation and it's much slower (50%)
2018-08-26 02:23:26 +08:00
alexey-milovidov
732afd27cf
Merge pull request #2953 from yandex/max-block-size-in-system-tables-columns
Support for max_block_size in system.tables and system.columns tables
2018-08-25 20:36:54 +03:00
Amos Bird
9623e59870 Simplify read helpers.
Use similar APIs like https://en.cppreference.com/w/cpp/string/byte/strstr
2018-08-26 01:27:28 +08:00
Alexey Milovidov
aa936b09f9 Added check for max_block_size = 0 #2447 2018-08-25 19:32:44 +03:00
Alexey Milovidov
068e50329e Support for max_block_size in system.tables and system.columns tables #2447 2018-08-25 19:07:48 +03:00
Amos Bird
5f03082af9 Make sure BufferBase is fully swapped. 2018-08-25 19:58:16 +08:00
alexey-milovidov
046137f9c5
Merge pull request #2946 from amosbird/locking
Better locking for StorageBuffer
2018-08-25 13:47:29 +03:00
Amos Bird
2602177525 Better locking for StorageBuffer 2018-08-25 13:52:06 +08:00
Alexey Milovidov
8cc3501c04 Attempt to generalize ZooKeeper interface [#CLICKHOUSE-2] 2018-08-25 05:00:36 +03:00
Alexey Milovidov
3475ef5304 Attempt to generalize ZooKeeper interface [#CLICKHOUSE-2] 2018-08-25 04:58:14 +03:00
Alexey Milovidov
4d343a441c Attempt to generalize ZooKeeper interface [#CLICKHOUSE-2] 2018-08-25 04:14:02 +03:00
Alexey Milovidov
01082d03d2 Adopted logic in ReplicatedMergeTreeBlockOutputStream #2949 2018-08-25 01:55:02 +03:00
Alexey Milovidov
cc56235ad9 Merge remote-tracking branch 'origin/master' into distinguish-between-definitely-lost-and-unknown-requests-in-zookeeper 2018-08-25 01:53:58 +03:00
Alexey Milovidov
2530561086 ZooKeeperImpl: allow to distinguish cases when request was definitely not been processed #2939 2018-08-25 01:50:20 +03:00
alexey-milovidov
7ba62c2e25
Merge pull request #2939 from yandex/fix-potential-data-loss-in-case-of-zk-errors
Fixed potential data loss in case of ZK errors [#CLICKHOUSE-3916]
2018-08-25 01:08:31 +03:00
CurtizJ
cf3fbb8c51 minor changes 2018-08-24 20:37:08 +03:00
chertus
53ec40eeee some decimal field improvements CLICKHOUSE-3765 2018-08-24 19:35:00 +03:00
CurtizJ
e0b3283ed3 Merge remote-tracking branch 'upstream/master' into CLICKHOUSE-3893 2018-08-24 18:09:53 +03:00
CurtizJ
c18ad18d96 Add rollup modificator 2018-08-24 18:00:00 +03:00
chertus
2e65f4922f extract overflow funcs to arithmeticOverflow.h CLICKHOUSE-3906 2018-08-24 17:20:23 +03:00
chertus
d61614a3d9 fix enums getTypeId() CLICKHOUSE-3765 2018-08-24 15:55:31 +03:00
alexey-milovidov
3466277b0a
Merge pull request #2940 from yandex/better-exception-message-in-case-of-wrong-number-of-arguments-for-function-if
Better exception message in case of wrong number of arguments for function "if" [#CLICKHOUSE-3932]
2018-08-24 15:31:22 +03:00
chertus
54a3c028c5 Merge branch 'master' into decimal 2018-08-24 14:19:41 +03:00
alexey-milovidov
eab95e43d1
Merge pull request #2938 from yandex/speed-up-fuzz-tests-2
Speed up fuzz tests, part 2 #2924
2018-08-24 14:07:35 +03:00
Alexey Milovidov
eee6644a22 Better exception message in case of wrong number of arguments for function "if" [#CLICKHOUSE-3932] 2018-08-24 12:57:42 +03:00
Alexey Milovidov
eec8af52f3 Fixed potential data loss [#CLICKHOUSE-3916] 2018-08-24 11:57:24 +03:00
daoready
605626e389 unused x 2018-08-24 11:56:32 +03:00
Alexey Milovidov
86ede3d38c Removed "_dl_addr" from profile when high amount of queries are instantly rejected with exception as in case when "Too many simultaneous queries" [#CLICKHOUSE-3923] 2018-08-24 11:32:33 +03:00
Amos Bird
26903d6e8f Add schema argument to ODBC table func.
Useful for datbases like postgres and greenplum.
2018-08-24 16:18:17 +08:00
zhang2014
cdc4c65adc ISSUES-2906 support join for table function 2018-08-24 15:40:09 +08:00