Commit Graph

173 Commits

Author SHA1 Message Date
Martijn Bakker
f96a7e401e remove the list lookup and prevent the global lock 2019-04-05 18:59:48 +01:00
chertus
d5ffbd9b6d fix multithreaded ASOF JOIN crash 2019-04-02 21:50:35 +03:00
chertus
04efcf2bdc asof refactoring (searching for the crash reason) 2019-04-02 19:22:14 +03:00
chertus
9ed4ac7e82 get rid of macro in AsofRowRefs 2019-04-01 19:44:15 +03:00
Martijn Bakker
d4ec3bbf70 fix style 2019-04-01 11:35:37 +01:00
Martijn Bakker
a64b8afc7e cleanup 2019-04-01 00:09:00 +01:00
Martijn Bakker
27776ca929 fix up wrong assumption that the sample_block_with_keys has same ordering as key_names_right 2019-03-31 22:56:37 +01:00
Martijn Bakker
7ea03f6fa7 appears to work and get the correct timestamps 2019-03-31 22:14:43 +01:00
Martijn Bakker
4a7393cfc6 include the asof column in the block stored. overall not working yet but at least doesnt crash anymore 2019-03-31 20:03:57 +01:00
Martijn Bakker
4709b744bb address the code review issues 2019-03-30 21:30:21 +00:00
Martijn Bakker
4a94545882 add test for multiple supported asof types 2019-03-30 12:52:48 +00:00
Martijn Bakker
7c5febb6aa Merge branch 'master' into martijn-asof-nomap 2019-03-30 02:02:48 +00:00
Martijn Bakker
389f108807 working multi type asof join columns 2019-03-30 01:32:08 +00:00
Martijn Bakker
89515861df asof join without using std::map, but still only on u32 2019-03-29 21:20:23 +00:00
chertus
6bdbf75e30 fix crash when joining nulluble vs not nullable 2019-03-29 21:07:22 +03:00
Martijn Bakker
9ac52b9368 fix master merge 2019-03-28 21:06:49 +00:00
Martijn Bakker
46f4557944 Merge branch 'master' into martijn-asof-join 2019-03-28 20:20:17 +00:00
Martijn Bakker
e7a10b8a3e add inner asof join with tests 2019-03-28 19:31:11 +00:00
Martijn Bakker
817a9244c0 fix up code style 2019-03-28 19:03:57 +00:00
Martijn Bakker
b0fd915724 remove the ASOFSplit struct 2019-03-28 18:35:50 +00:00
chertus
2a5b4b3b31 fix ANY JOIN nulls in right key (ALL JOIN is still affected) 2019-03-27 16:37:11 +03:00
chertus
e92dcd4774 fix clang release build 2019-03-27 01:47:38 +03:00
Martijn Bakker
ac68fc8088 pass the half-enforced style checks such that they cannot be run on a whole file automatically :( 2019-03-26 22:05:51 +00:00
Martijn Bakker
84f40ddf02 fix build as cpp does not do partial function specialization 2019-03-26 20:13:15 +00:00
chertus
0a0e986f75 fix crash on join not nullable with nullable 2019-03-26 22:46:03 +03:00
Martijn Bakker
f6987cfa52 have the parser recognize asof joins and feed them through to the executor
insert the time series into a struct ready for joining

working version that inserts the data into the hash table using the existing dispatching machinery for various types

working asof left join in clickhouse

add a test for the asof join

do some asof join cleanup

revisit the logic in case the values match between left and right side
2019-03-26 19:17:21 +00:00
chertus
b1f4cc6ed2 fix left join with const column 2019-03-20 20:20:14 +03:00
chertus
2ea11f8528 more Joins.cpp refactoring (constexpr if) 2019-03-20 18:52:41 +03:00
chertus
efa4a2bb18 minor changes 2019-03-20 18:15:44 +03:00
chertus
2713d36ce8 syntax: remove tab 2019-03-20 17:49:05 +03:00
chertus
1bb05eb089 more Join.cpp refactoring (hide some logic into AddedColumns) 2019-03-20 17:41:35 +03:00
chertus
2a4da2f687 more refactoring (rename misleading variable) 2019-03-20 16:38:17 +03:00
chertus
e1f015295b rename functions & add comment 2019-03-20 15:28:45 +03:00
chertus
ef2d77f946 some more refactoring 2019-03-20 15:08:38 +03:00
chertus
e5a9633132 Join.cpp refactoring 2019-03-19 19:53:36 +03:00
chertus
09a3b24cbc join kind helpers 2019-03-11 14:14:09 +03:00
alexey-milovidov
695a2dc35f
Merge pull request #4552 from 4ertus2/bugs
Fix crash on JOIN with array or tuple
2019-03-01 18:49:22 +03:00
chertus
83503df56a fix crach on JOIN with array or tuple 2019-03-01 18:32:32 +03:00
Amos Bird
26ab5dd7a7 A Proper lookup table that uses HashTable's API
This is the first step of allowing heterogeneous cells in hash tables.

performance test results are

```

1. HashMap<UInt16, UInt8, TrivialHash, HashTableFixedGrower<16>>;
2. NewLookupMap<UInt16, UInt8>

ResolutionWidth 30000 1 .................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................223550276.46
ResolutionWidth 30000 2 .................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................248772721.24
Best: 2 - 24877272124

ResolutionWidth 100000 1 ..........................................................................................................................................................................................................................................................238498413.99
ResolutionWidth 100000 2 ..........................................................................................................................................................................................................................................................261808889.98
Best: 2 - 26180888998

ResolutionWidth 300000 1 ...................................................................................239307348.81
ResolutionWidth 300000 2 ...................................................................................257592761.30
Best: 2 - 25759276130

ResolutionWidth 1000000 1 .........................240144759.26
ResolutionWidth 1000000 2 .........................257093531.91
Best: 2 - 25709353191

ResolutionWidth 5000000 1 .....241573260.35
ResolutionWidth 5000000 2 .....259314162.79
Best: 2 - 25931416279

ResolutionDepth 30000 1 .................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................217108119.84
ResolutionDepth 30000 2 .................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................249459504.41
Best: 2 - 24945950441

ResolutionDepth 100000 1 ..........................................................................................................................................................................................................................................................229065162.17
ResolutionDepth 100000 2 ..........................................................................................................................................................................................................................................................253769105.64
Best: 2 - 25376910564

ResolutionDepth 300000 1 ...................................................................................233079225.18
ResolutionDepth 300000 2 ...................................................................................256316273.78
Best: 2 - 25631627378

ResolutionDepth 1000000 1 .........................234184633.51
ResolutionDepth 1000000 2 .........................261100491.57
Best: 2 - 26110049157

ResolutionDepth 5000000 1 .....233118795.66
ResolutionDepth 5000000 2 .....252436160.41
Best: 2 - 25243616041

```
2019-03-01 16:47:13 +08:00
chertus
3218f5003f fix full/right join different number of columns 2019-02-12 15:11:45 +03:00
Alexey Milovidov
58a6accee5 Updated test #4246 2019-02-10 19:55:12 +03:00
alexey-milovidov
2686f64233
Merge pull request #4128 from yandex/unified-sets
Unified sets
2019-02-06 20:40:11 +03:00
chertus
396d4fb921 hotfix for duplicates in JOIN ON #4271 2019-02-05 19:58:57 +03:00
Nikolai Kochetov
a249fc7788 Do nut use Arena in ColumnsHashing for string in functions arrayUniq and arrayEnumerate. 2019-02-05 14:14:09 +03:00
Nikolai Kochetov
8db4116464 Update HashMethodHashed. 2019-02-05 13:55:08 +03:00
Nikolai Kochetov
6a729e59ba Merged with master. 2019-02-01 11:36:57 +03:00
alexey-milovidov
bd62e2d85d
Merge pull request #4184 from 4ertus2/joins
Fix JOIN with duplicates [issue-4108]
2019-02-01 01:35:37 +03:00
chertus
26b2526a3b fix right & full join with dups (complex join on still affected) 2019-01-31 21:10:16 +03:00
chertus
866c2b2e78 move required right keys calculation to Join.cpp 2019-01-30 18:51:39 +03:00
alexey-milovidov
fd5ab9ed2e
Merge pull request #4055 from yandex/fix-group-by-array-low-cardibality-arguments
Fix group by array low cardinality arguments
2019-01-29 21:32:45 +03:00