Commit Graph

63390 Commits

Author SHA1 Message Date
Alexander Gololobov
c3416859d5 Merge branch 'master' of github.com:ClickHouse/ClickHouse into tmp_files_lookup 2024-09-11 17:22:08 +02:00
Alexander Gololobov
f69cb73df0
Merge pull request #69167 from ClickHouse/query_plan_for_merge
Use QueryPlan for merge
2024-09-11 14:41:25 +00:00
Antonio Andelic
9b42af7263
Merge pull request #66648 from ClickHouse/read-cgroup-memory-usage-async-metrics
Simplify some memory tracking parts
2024-09-11 13:24:38 +00:00
Yarik Briukhovetskyi
ccfb7ad38c
Merge pull request #69455 from yariks5s/group_concat_return_string
`groupConcat` consistency with `arrayStringConcat`
2024-09-11 08:59:48 +00:00
Robert Schulze
7a3d69b626
Merge pull request #69451 from rschu1ze/sqid-crash
Fix crash in `sqidDecode`
2024-09-11 08:56:05 +00:00
Kseniia Sumarokova
cb1b7dc43c
Merge pull request #69454 from ClickHouse/revert-s3queue-problem
Quick fix for s3queue problem
2024-09-10 21:13:16 +00:00
Alexander Tokmakov
629d27fec8
Merge pull request #69422 from ClickHouse/add_a_setting
Add a setting to disallow DETACH PERMANENTLY in Replicated database
2024-09-10 19:56:10 +00:00
Alexander Gololobov
d4aa06524b Add materialization when building indices in vertical merge 2024-09-10 20:57:55 +02:00
Nikita Taranov
8534aa07fc
Merge pull request #69400 from ClickHouse/support_more_oss_endpoints
Support more oss endpoints
2024-09-10 17:01:02 +00:00
Nikita Taranov
8fa31c0750
Merge pull request #69385 from ClickHouse/fix
Fix type mismatch
2024-09-10 16:52:57 +00:00
Alexander Gololobov
bb82465a5f Merge branch 'master' of github.com:ClickHouse/ClickHouse into query_plan_for_merge 2024-09-10 18:27:59 +02:00
Kseniia Sumarokova
6a6d26aeed
Update StorageObjectStorageQueue.cpp 2024-09-10 18:16:27 +02:00
Alexander Gololobov
e4761d40ba
Merge pull request #69429 from ClickHouse/materialize_sparse
Make `materialize()` function return full column when parameter is a sparse column
2024-09-10 15:49:29 +00:00
Robert Schulze
080193cfc3
14% more aesthetic code 2024-09-10 15:46:21 +00:00
Yarik Briukhovetskyi
d8e670297b
groupConcat consistency 2024-09-10 17:42:27 +02:00
kssenii
d43264c44e Quick fix for s3queue problem 2024-09-10 17:41:52 +02:00
Robert Schulze
04dcf73e8f
Fix crash in sqidDecode 2024-09-10 15:35:59 +00:00
Kruglov Pavel
d226b13fd4
Merge pull request #69272 from Avogar/json-memory-usage
Reduce memory usage of inserts to JSON by using adaptive write buffer size
2024-09-10 15:23:18 +00:00
Pablo Marcos
a34a544f4a
Merge pull request #67938 from mwoenker/incomplete-utf8-sequence
Handle incomplete sequences at end of input
2024-09-10 14:04:58 +00:00
Alexander Gololobov
a01229bba2 Convert sparse columns to full in materialize() 2024-09-10 14:23:31 +02:00
Antonio Andelic
bdf8c859b1 Merge branch 'master' into read-cgroup-memory-usage-async-metrics 2024-09-10 14:13:48 +02:00
Alexander Tokmakov
89dd3188bb add a setting to disallow DETACH PERMANENTLY in Replicated 2024-09-10 13:35:18 +02:00
Nikita Fomichev
24d81fe00b
Merge pull request #69394 from ClickHouse/rows-before-aggregation-compatibility
Fix 24.8 setting compatibility `rows_before_aggregation`
2024-09-10 11:33:33 +00:00
Pablo Marcos
ac3cfef8c1
Merge pull request #69390 from pamarcos/fix-invalid-connection-logical-error
Fix undefined behavior if all connection tries fail
2024-09-10 09:45:37 +00:00
Nikita Taranov
47589d4898 impl 2024-09-09 19:53:58 +01:00
Alexander Tokmakov
9ab3ee1b13
Merge pull request #66104 from ClickHouse/break_compatibility
Don't allow explicit UUIDs and ReplicatedMergeTree arguments in Replicated databases
2024-09-09 18:29:16 +00:00
Robert Schulze
2b2cd8e3e0
Merge pull request #69377 from JackyWoo/rename_statistics_count_min
Rename `count_min` statistics to `countmin`
2024-09-09 18:25:11 +00:00
Alexander Tokmakov
7fe8775361
Merge pull request #69306 from ClickHouse/tavplubix-patch-14
Update StackTrace.cpp
2024-09-09 17:55:07 +00:00
Alexander Gololobov
38b8edae97 Fix the case with empty temp file 2024-09-09 19:34:59 +02:00
Kseniia Sumarokova
ef94d3422c
Merge pull request #69305 from ClickHouse/fix-segfault-deltalake
Add checks against segfault in DeltaLakeMetadata
2024-09-09 16:23:29 +00:00
Kruglov Pavel
804012b2e4
Merge pull request #69311 from Avogar/dynamic-primary-key
Mark Dynamic type as not safe primary key type to avoid issues with Fields
2024-09-09 15:33:48 +00:00
avogar
72dbc8205b Fix unit tests 2024-09-09 15:12:17 +00:00
Pablo Marcos
f7dee10030 Make a more assertive exception text 2024-09-09 14:38:06 +00:00
Robert Schulze
d749869f00
Merge pull request #67707 from bigo-sg/opt_array_map
Optimize function `array()` and `map()`
2024-09-09 14:37:50 +00:00
Alexander Gololobov
4da1e10ac6 Move sorting key calculation step outside the loop 2024-09-09 16:01:00 +02:00
Pablo Marcos
67b57eb89f Fix undefined behavior if all connection tries fail
For some reason, getManyCheckedForInsert was calling getManyImpl with
skip_unavailable_endpoints=nullptr, which resulted in getManyImpl using
the `skip_unavailable_shards` settings. Since this is true by default,
min_entries was set to 0.

Having min_entries set to 0 while using PoolMode::GET_ONE was strange,
to say the least. There was an edge case where if all connection
attempts failed and min_entries was 0, it was returning an empty vector.
That was not considered to be possible by the caller and it was getting
the front entry of an empty vector, causing undefined behavior.

Conclusion: set `skip_unavailable_endpoints=false` explicitly in
getManyCheckedForInsert so that min_entries=1. In case all connections
fail, an exception will be thrown. Also, add some defensive programming
to ensure we never ever try to get the front element of an empty vector.
2024-09-09 14:00:35 +00:00
Pablo Marcos
e6e79c3c4a Fix minor typos 2024-09-09 13:35:45 +00:00
Alexander Gololobov
8c1f434b1a Do column materialization using ActionsDAG::addMaterializingOutputActions instead of a special step 2024-09-09 15:31:43 +02:00
Alexander Gololobov
1bcc4ba823 Renamed ApplyMergeStep into MergePartsStep 2024-09-09 15:30:19 +02:00
Nikita Fomichev
66572aa029 Fix 24.8 setting compatibility rows_before_aggregation
https://github.com/ClickHouse/ClickHouse/pull/66084
2024-09-09 15:25:14 +02:00
Nikita Taranov
43d057ed0f impl 2024-09-09 13:04:45 +01:00
Alexander Gololobov
5a8bd5b4f5 Encapsulte and cleanup "rows_sources" temp file usage 2024-09-09 13:22:38 +02:00
Alexander Gololobov
7d042be8eb A simple interface to find temporary files by their logical names when building pipeline from query plan 2024-09-09 13:21:00 +02:00
Miсhael Stetsyuk
2364949c95
Merge pull request #69102 from ClickHouse/make-replicated-database-creation-operations-idempotent
Make `Replicated` database creation operations idempotent
2024-09-09 11:19:15 +00:00
Kruglov Pavel
7bf6bdf639
Merge pull request #69149 from Avogar/values-respect-settings
Respect format settings in Values format during conversion from expression to the destination type
2024-09-09 11:02:39 +00:00
Nikita Taranov
57e3812087
Merge pull request #68441 from jiebinn/parallelMergeWithKey
Add thread pool and cancellation to support parallel merge with key
2024-09-09 10:41:45 +00:00
Raúl Marín
d968de6d26
Merge pull request #66205 from alexkorep/output-format-json-compact-with-progress
JSONCompactWithProgress query output format
2024-09-09 09:30:42 +00:00
Yarik Briukhovetskyi
2c35d53bf6
Merge pull request #56738 from yariks5s/time_buckets_impl
Add time-bucket overload to function `toStartOfInterval()`
2024-09-09 09:18:35 +00:00
JackyWoo
eb800d9e39 Rename statistics of type count_min to countmin 2024-09-09 11:45:39 +08:00
taiyang-li
774ec08faf fix style 2024-09-09 11:37:27 +08:00