Alexey Milovidov
62bfdb349a
Merge branch 'master' into fix-trash-query-kind
2023-02-02 04:26:49 +01:00
Sema Checherinda
7c416477ac
do not run wal on remote disks
2023-02-01 20:03:45 +01:00
kssenii
bbf060bf89
Fix test
2023-02-01 18:22:05 +01:00
Sema Checherinda
3e1b17e4cf
fix build
2023-02-01 17:09:43 +01:00
Anton Popov
9f26e16963
loose the assertion
2023-02-01 15:31:06 +00:00
Anton Popov
8dd6dbc452
Merge pull request #45857 from CurtizJ/fix-minor-mistake
...
Fix minor mistake after refactoring
2023-02-01 15:33:19 +01:00
Sema Checherinda
41a1dddc7a
Merge branch 'master' into better_postpone_reason
2023-02-01 15:16:34 +01:00
Sema Checherinda
db2aa48c91
do not block merges when old parts are droping in drop queries
2023-02-01 13:30:56 +01:00
Vladimir C
0d48eed68f
Merge pull request #45848 from Algunenano/fix_connection_timeouts_context_include
2023-02-01 12:53:50 +01:00
Robert Schulze
b512316586
Merge pull request #45682 from ClickHouse/rename-qrc-to-qc
...
Rename "Query Result Cache" to "Query Cache"
2023-02-01 11:23:29 +01:00
Alexander Gololobov
e705f11ad1
Merge pull request #45786 from ClickHouse/delete_on_cluster
...
Support DELETE ON CLUSTER
2023-02-01 10:52:01 +01:00
Alexey Milovidov
9b908a0be0
Fix trash around query kind, part 2
2023-02-01 03:31:31 +01:00
Alexey Milovidov
5c4db119fa
Fix trash around query kind, part 1
2023-02-01 03:11:54 +01:00
Vitaly Baranov
96b140cc95
Rename columns in system.backups: num_files, num_processed_files, processed_files_size
...
num_processed_files -> num_files (BACKUP) / files_read (RESTORE)
processed_files_size -> total_size (BACKUP) / bytes_read (RESTORE)
2023-01-31 22:45:41 +01:00
kssenii
4a1bdcf24c
Merge remote-tracking branch 'upstream/master' into storage-rabbitmq-fix-flush
2023-01-31 18:11:26 +01:00
Anton Popov
1c4174750d
fix mistake after refactoring
2023-01-31 15:48:14 +00:00
Raúl Marín
7c31cb7adc
Proper includes for ConnectionTimeoutsContext.h
2023-01-31 16:11:32 +01:00
Alexander Tokmakov
51b0f66e6b
Merge pull request #45793 from ClickHouse/fix_part_check_cancellation
...
Fix race condition on a part check cancellation
2023-01-31 14:15:17 +03:00
Kseniia Sumarokova
7d53f8bbf6
Merge pull request #45591 from bharatnc/ncb/odbc-connection-pool-fixes
...
fixes to use the odbc_bridge_use_connection_pooling setting correctly
2023-01-31 11:31:59 +01:00
Robert Schulze
325c6bdf3d
Renaming: "Query Result Cache" --> "Query Cache"
...
Reasons:
- The cache will at some point store intermediate results as opposed to
only query results. We should change the terminology now without
having to worry about backward compat.
- Equivalent caches in MySQL (1) and Starrocks (2) are called "query
cache".
- The new name is ca. 13.8% more catchy.
(1) https://dev.mysql.com/doc/refman/5.6/en/query-cache.html
(2) https://docs.starrocks.io/en-us/2.5/using_starrocks/query_cache
2023-01-31 09:54:34 +00:00
Alexander Gololobov
f9133f3d85
Merge pull request #45791 from ClickHouse/fix_drop_hung
...
Fix bug in tables drop which can lead to potential query hung
2023-01-31 10:11:11 +01:00
Bharat Nallan
f1d6e3b908
Merge branch 'master' into ncb/odbc-connection-pool-fixes
2023-01-30 15:49:04 -08:00
Ilya Yatsishin
8d6df7ed58
Merge pull request #45785 from Algunenano/generate_random_types
2023-01-30 23:03:12 +01:00
Alexander Gololobov
4eea3de654
Do not restrict count() query to 1 thread in isStorageTouchedByMutations()
2023-01-30 22:29:28 +01:00
Alexander Tokmakov
e42cd3163f
fix race condition on a part check cancellation
2023-01-30 18:48:20 +01:00
Alexander Gololobov
863548114d
force_wait flag is no longer needed
2023-01-30 18:38:28 +01:00
Vitaly Baranov
2e3a3cc4dc
Merge pull request #45701 from vitlibar/add-setting-allow-head-object-request
...
Add new S3 setting allow_head_object_request
2023-01-30 17:41:09 +01:00
Bharat Nallan Chakravarthy
0d2e4fcc15
set use_connection_pooling from settings everywhere
2023-01-30 08:22:48 -08:00
alesapin
be58d5d1af
Fix bug in tables drop which can lead to potential query hung
2023-01-30 17:00:28 +01:00
Raúl Marín
997fad4e8d
GenerateRandom: Add support for maps
2023-01-30 15:23:22 +01:00
Raúl Marín
05d8cfc714
GenerateRandom: Add support to IPv4 and IPv6 types
2023-01-30 14:18:25 +01:00
Vitaly Baranov
38910412c4
Merge pull request #42244 from AVMusorin/fix_backup_restore_num_files
...
Added num_processed_files and processed_files_size for backup and restore processes
2023-01-30 09:24:49 +01:00
alesapin
631c8fb155
Merge branch 'master' into add-setting-allow-head-object-request
2023-01-29 14:58:27 +01:00
Alexey Milovidov
49a59ff9bd
Fix bad comment
2023-01-29 03:57:59 +01:00
Vitaly Baranov
af74c008c4
Use one request to implement S3ObjectStorage::getObjectMetadata instead of two ones.
2023-01-27 18:42:37 +01:00
kssenii
9c4a97bbd1
Merge remote-tracking branch 'upstream/master' into storage-rabbitmq-fix-flush
2023-01-27 17:17:09 +01:00
Anton Popov
d8fe2bcbaa
Merge branch 'master' into randomize-mt-settings
2023-01-27 16:03:00 +01:00
Anton Popov
3f1db52d51
Merge remote-tracking branch 'upstream/master' into compact-parts-vertical-merge
2023-01-27 14:38:37 +00:00
Vitaly Baranov
d02b255b55
Add new setting "allow_head_object_request" to S3::RequestSettings.
2023-01-27 15:10:34 +01:00
Vitaly Baranov
aea9ccdb60
Pass request settings to S3::getObjectInfo().
2023-01-27 15:10:09 +01:00
Vitaly Baranov
a8304525ed
Move getObjectInfo() to a separate header.
2023-01-27 15:09:38 +01:00
Nikolai Kochetov
313947e0b0
Merge branch 'master' into issue_45590
2023-01-27 15:08:28 +01:00
Anton Popov
f10e82355e
Merge pull request #45630 from CurtizJ/fix-performance-columns-description
...
Fix performance of short queries with `Array` columns
2023-01-27 14:59:55 +01:00
Alexander Tokmakov
ec0738ef31
Merge pull request #45692 from ClickHouse/tavplubix-patch-3
...
Fix build
2023-01-27 16:39:56 +03:00
Anton Popov
9c1717b42d
fix computation of granularity in vertical merges
2023-01-27 13:35:04 +00:00
Alexander Tokmakov
f375b1246f
Merge pull request #45363 from ClickHouse/fix_hang_during_drop_in_zero_copy_replication
...
Fix no shared id during drop for the fourth time
2023-01-27 15:59:27 +03:00
Nikolai Kochetov
f6ad6296ba
Restore.
2023-01-27 12:45:41 +00:00
Alexander Tokmakov
1494262a38
Update DataPartStorageOnDiskFull.cpp
2023-01-27 15:42:41 +03:00
Nikolai Kochetov
b716e2d754
A bit cleaner fix.
2023-01-27 12:37:23 +00:00
alesapin
716d25c33f
Merge pull request #45619 from CurtizJ/refactoring-merge-tree-parts
...
Refactoring of code near merge tree parts
2023-01-27 13:36:33 +01:00
Alexander Tokmakov
c366806c3e
Merge pull request #45527 from ClickHouse/exception_message_patterns4
...
Better formatting for exception messages 2
2023-01-27 15:31:52 +03:00
Amos Bird
716516f84a
Fix test
2023-01-27 16:58:41 +08:00
Amos Bird
fd60954081
Fix key description on duplicate primary keys
...
This can happen in projections. See
https://github.com/ClickHouse/ClickHouse/issues/45590 for details.
2023-01-27 13:01:36 +08:00
Anton Popov
fb3f7409fa
allow vertical merges from compact to wide parts
2023-01-26 22:18:04 +00:00
Alexander Tokmakov
061026c307
fix
2023-01-26 19:01:29 +01:00
Alexey Milovidov
d942a4ddef
Allow LowCardinality in GenerateRandom
2023-01-26 15:35:20 +01:00
Alexander Tokmakov
067b1f5f13
Merge branch 'master' into exception_message_patterns4
2023-01-26 15:20:58 +01:00
Alexander Tokmakov
f676e9eaff
Merge pull request #45613 from azat/replicated-improve-log
...
Improve "at least part X is missing" error message
2023-01-26 16:48:18 +03:00
Anton Popov
92fa39798b
Merge remote-tracking branch 'upstream/master' into HEAD
2023-01-26 13:29:23 +00:00
Anton Popov
b58b73b0e7
Merge pull request #45529 from CurtizJ/fix-storage-s3-race
...
Try to fix test `test_storage_s3/test.py::test_wrong_s3_syntax` (race in `StorageS3`)
2023-01-26 14:21:32 +01:00
Anton Popov
87af86e9a3
fix projections
2023-01-26 13:11:31 +00:00
Alexander Tokmakov
14db798191
fix
2023-01-26 13:56:16 +01:00
Anton Popov
b52cf17fa6
Merge pull request #45612 from ClickHouse/CurtizJ-patch-7
...
Remove useless code
2023-01-26 12:38:52 +01:00
alesapin
84af5eb58b
Fxi
2023-01-26 11:42:53 +01:00
alesapin
d5036f2ebc
Merge branch 'fix_hang_during_drop_in_zero_copy_replication' of github.com:ClickHouse/ClickHouse into fix_hang_during_drop_in_zero_copy_replication
2023-01-26 11:42:30 +01:00
alesapin
1f61abce46
One useful logging line
2023-01-26 11:41:43 +01:00
Alexander Tokmakov
a584ad0eb1
forbid runtime strings
2023-01-26 10:52:47 +01:00
Antonio Andelic
6fe9e9a67f
Merge pull request #45617 from ClickHouse/fix-bfngram-index
...
Correctly check types when using N-gram bloom filter index
2023-01-26 09:05:56 +01:00
Alexander Tokmakov
9b670946db
Merge branch 'master' into exception_message_patterns5
2023-01-26 00:41:32 +01:00
Mikhail f. Shiryaev
120c31d57f
Merge pull request #45634 from ClickHouse/23.2-prepare
...
Update version after release
2023-01-26 00:10:53 +01:00
Mikhail f. Shiryaev
53d89844be
Update version to 23.2.1.1
2023-01-25 23:57:29 +01:00
Anton Popov
79ea6a1c9c
fix performance of short queries
2023-01-25 22:20:01 +00:00
Alexander Tokmakov
92c62e2de2
Update src/Storages/StorageReplicatedMergeTree.cpp
2023-01-26 00:28:46 +03:00
Han Fei
0221b50028
Merge pull request #45601 from hanfei1991/hanfei/async-cache-conflict
...
fix race of async-insert-blockids-cache
2023-01-25 22:28:42 +01:00
Alexander Tokmakov
3744fa2c63
format more messages
2023-01-25 21:16:42 +01:00
Anton Popov
0f46c1ecc6
fix build
2023-01-25 20:13:54 +00:00
alesapin
d0428a9b42
Fxi
2023-01-25 20:30:19 +01:00
Kruglov Pavel
cd3d3fdd68
Merge pull request #45483 from Avogar/fix-hdfs-cluster
...
Fix schema inference from insertion table in hdfsCluster
2023-01-25 20:24:51 +01:00
Azat Khuzhin
00c341850f
Improve "at least part X is missing" error message
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-25 19:53:45 +01:00
Anton Popov
a455083b87
Merge remote-tracking branch 'upstream/master' into refactoring-merge-tree-parts
2023-01-25 18:01:12 +00:00
Kruglov Pavel
83a212a128
Merge branch 'master' into more-fsync-fixes
2023-01-25 18:40:41 +01:00
Anton Popov
8e3698c91f
refactoring of code near merge tree parts
2023-01-25 17:34:09 +00:00
Antonio Andelic
7fa906487c
Fix ngram index with null
2023-01-25 16:40:04 +00:00
Anton Popov
d9aabb48c3
remove useless code
2023-01-25 16:11:15 +00:00
alesapin
55af44ca2f
Better fix
2023-01-25 14:40:39 +01:00
Alexander Tokmakov
b9e5c586e6
Merge pull request #45566 from ClickHouse/resubmit_45493
...
Resubmit "Fix possible in-use table after DETACH"
2023-01-25 16:39:55 +03:00
Alexander Tokmakov
6eb557b2ba
Merge branch 'master' into exception_message_patterns4
2023-01-25 13:49:17 +01:00
Robert Schulze
59528cfca0
Merge pull request #45460 from ClickHouse/inv-index-cleanup
...
Cleanup of inverted index
2023-01-25 13:23:38 +01:00
alesapin
96d8546b1c
Merge branch 'master' into fix_hang_during_drop_in_zero_copy_replication
2023-01-25 13:07:14 +01:00
Han Fei
8c4bbcd0fc
fix race of async-insert-blockids-cache
2023-01-25 12:41:01 +01:00
Sergei Trifonov
0d1ea05ff6
Merge pull request #45007 from ClickHouse/cancellable-mutex-integration
...
Fast shared mutex integration
2023-01-25 11:15:46 +01:00
Kseniia Sumarokova
2b8b1ad5d4
Additional check in MergeTreeReadPool ( #45515 )
...
* Check ranges
* Check equality just in case
* Check under ndebug
2023-01-24 23:56:26 +01:00
Alexander Tokmakov
6621834e37
fix
2023-01-24 17:10:54 +01:00
avogar
07ad750366
Fix tests
2023-01-24 15:08:19 +00:00
Alexander Tokmakov
6ecae8388e
Merge branch 'master' into exception_message_patterns4
2023-01-24 14:42:36 +01:00
Alexander Tokmakov
42a976fe3d
Revert "Revert "Merge pull request #45493 from azat/fix-detach""
...
This reverts commit 9dc4f02d15
.
2023-01-24 14:15:51 +01:00
Azat Khuzhin
54ef885a61
Fsync all small files at once after mutation
...
Everything else is handled in MergedBlockOutputStream::finalizePart()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-24 14:08:37 +01:00
Azat Khuzhin
4b775ccdd5
Do fsync all files at once for fetched parts to decrease latency
...
For filessystems like ext4, fsync of one file will handle all operations
before, so this can be pretty time consuming.
And in case of you write multiple files in a loop, and at the end of
each iteration sync each file, then during writing of this file there
can be other operations in journal, and hence more work for fsync.
Let's call fsync for all files at once instead, like
MergedBlockOutputStream does.
Hope that keeping all file buffers till the end, will not cause troubles
(buffering and so forth).
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-24 14:08:37 +01:00
Azat Khuzhin
b370e3faa5
Move fsync inside transaction callback in DataPartStorageOnDisk::rename()
...
Otherwise, it is useless.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-24 14:08:37 +01:00
Anton Popov
5c0307bc6a
fix race in StorageURL and StorageHDFS
2023-01-24 12:34:43 +00:00