Commit Graph

17982 Commits

Author SHA1 Message Date
alesapin
09ad1732b3
Update test.py 2019-05-21 11:15:47 +03:00
hcz
f7bad8c87b
Fix NaN 2019-05-21 16:10:49 +08:00
Mikhail Filimonov
8a1d773ced more dockerfile fixes 2019-05-21 08:17:46 +02:00
Danila Kutenin
3536184ba8
Merge pull request #5357 from yandex/concat_optimization
Optimize concat function with recent format function.
2019-05-21 08:11:35 +03:00
Guillaume Tassery
938d6d7f24 coding style 2019-05-21 11:06:36 +07:00
Guillaume Tassery
d94ce121e2 update test 2019-05-21 10:53:53 +07:00
Andy Yang
a62f7e2fea Fixed bitmap functions produce wrong result 2019-05-21 10:58:38 +08:00
sundy-li
afcd60a0a4 add NO_SANITIZE_UNDEFINED 2019-05-21 10:16:46 +08:00
sundy-li
b55bf7cf83 whitespaces 2019-05-21 09:56:48 +08:00
alexey-milovidov
418a86f338
Merge pull request #5355 from yandex/checksum-mismatch-more-verbose-error-message
Better error message on checksum mismatch #5347
2019-05-21 01:46:52 +03:00
Danila Kutenin
cf014b704a Check for number of arguments 2019-05-21 00:12:25 +03:00
Danila Kutenin
daaebf5ab0 optimized concat function with format, make format a bit more generic 2019-05-21 00:06:43 +03:00
Oleg Favstov
896e995fe8 Fix test that doesn't assert anything 2019-05-20 23:59:07 +03:00
Alexey Milovidov
4b604e4656 Better error message on checksum mismatch #5347 2019-05-20 23:46:52 +03:00
Alexey Milovidov
da142a5d5d Better error message on checksum mismatch #5347 2019-05-20 23:35:43 +03:00
alexey-milovidov
1b86f28f08
Merge pull request #5350 from 4ertus2/bugs
Fix decimal conversion in IN
2019-05-20 22:01:56 +03:00
proller
50b74deeb4 CLICKHOUSE-4509 Fix error codes in DataPartsExchange 2019-05-20 20:04:36 +03:00
chertus
187311add0 add decimal to decimal convertion in IN 2019-05-20 18:51:54 +03:00
Guillaume Tassery
6fada68fe5 forget client.cpp 2019-05-20 20:24:53 +07:00
Guillaume Tassery
77b7158cd8 Progress rename for total_rows and write_[rows|bytes] 2019-05-20 18:37:41 +07:00
Mikhail Filimonov
8fe7633b62 Fixing "the input device is not a TTY" for test runner 2019-05-20 11:48:36 +02:00
Mikhail Filimonov
464cff4665 Sereval improvements in integration tests runner 2019-05-20 10:11:53 +02:00
sundy-li
66c60c2985 better tests 2019-05-20 12:31:52 +08:00
sundy-li
6843254ce4 Make sequenceMatch support other unsigned integer types 2019-05-20 12:02:54 +08:00
alexey-milovidov
02937294ce
Merge pull request #5311 from azat-archive/SimpleAggregateFunction-Arena-fix
Fix SimpleAggregateFunction for String longer MAX_SMALL_STRING_SIZE
2019-05-19 13:12:38 +03:00
Danila Kutenin
295a4a8684
Merge pull request #5330 from yandex/format_function
Format function added
2019-05-19 12:07:57 +03:00
Danila Kutenin
ed588bf727 style 2019-05-19 03:39:44 +03:00
Azat Khuzhin
db274bf516
Allocates arena for SimpleAggregateFunction only if IAggregateFunction requires 2019-05-19 03:33:04 +03:00
Azat Khuzhin
2f471d6ea3
Set allocatesMemoryInArena for SingleValueDataString to true
This includes next aggregate functions for String() type:
- *min*
- *max*
- *any*
2019-05-19 03:33:04 +03:00
Azat Khuzhin
4e8370b0b0
Fix SimpleAggregateFunction for String longer MAX_SMALL_STRING_SIZE
SimpleAggregateFunction do not pass arena to the
add_function -> getAddressOfAddFunction(), hence next crash happens:
  (gdb) bt
  #0  DB::Arena::alloc (size=64, this=0x0) at ../dbms/src/Common/Arena.h:124
  #1  DB::SingleValueDataString::changeImpl (this=0x7f97424a27d8, value=..., arena=0x0) at ../dbms/src/AggregateFunctions/AggregateFunctionMinMaxAny.h:274
  #2  0x0000000005ea5319 in DB::AggregateFunctionNullUnary<true>::add (arena=<optimized out>, row_num=<optimized out>, columns=<optimized out>, place=<optimized out>, this=<optimized out>) at ../dbms/src/AggregateFunctions/AggregateFunctionNull.h:43
  #3  DB::IAggregateFunctionHelper<DB::AggregateFunctionNullUnary<true> >::addFree (that=<optimized out>, place=<optimized out>, columns=<optimized out>, row_num=<optimized out>, arena=<optimized out>) at ../dbms/src/AggregateFunctions/IAggregateFunction.h:131
  #4  0x000000000679772f in DB::AggregatingSortedBlockInputStream::addRow (this=this@entry=0x7f982de19c00, cursor=...) at ../dbms/src/Common/AlignedBuffer.h:31
  #5  0x0000000006797faa in DB::AggregatingSortedBlockInputStream::merge (this=this@entry=0x7f982de19c00, merged_columns=..., queue=...) at ../dbms/src/DataStreams/AggregatingSortedBlockInputStream.cpp:140
  #6  0x0000000006798979 in DB::AggregatingSortedBlockInputStream::readImpl (this=0x7f982de19c00) at ../dbms/src/DataStreams/AggregatingSortedBlockInputStream.cpp:78
  #7  0x000000000622db55 in DB::IBlockInputStream::read (this=0x7f982de19c00) at ../dbms/src/DataStreams/IBlockInputStream.cpp:56
  #8  0x0000000006613bee in DB::MergeTreeDataMergerMutator::mergePartsToTemporaryPart (this=this@entry=0x7f97ec65e1a0, future_part=..., merge_entry=..., time_of_merge=<optimized out>, disk_reservation=<optimized out>, deduplicate=<optimized out>) at /usr/include/c++/8/bits/shared_ptr_base.h:1018
  #9  0x000000000658f7a4 in DB::StorageReplicatedMergeTree::tryExecuteMerge (this=0x7f97ec65b810, entry=...) at /usr/include/c++/8/bits/unique_ptr.h:342
  #10 0x00000000065940ab in DB::StorageReplicatedMergeTree::executeLogEntry (this=0x7f97ec65b810, entry=...) at ../dbms/src/Storages/StorageReplicatedMergeTree.cpp:910
  <snip>

  (gdb) f 1
  (gdb) p MAX_SMALL_STRING_SIZE
  $1 = 48
  (gdb) p capacity
  $2 = 64
  (gdb) p value
  $3 = {data = 0x7f97242fcbd0 "HHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH", size = 61}

v2: avoid leaking of allocated by Arena memory on the intermediate step

Fixes: 8f8d2c048e ("Merge pull request #4629 from bgranvea/simple_aggregate_function")
2019-05-19 03:32:55 +03:00
alexey-milovidov
2254b171a7
Merge pull request #5313 from yandex/fix-external-query-in-with-single-element
Fix external queries with IN operator.
2019-05-19 03:12:57 +03:00
Danila Kutenin
876b5c3bbb style 2019-05-19 02:21:29 +03:00
Alexey Milovidov
648d2bdb25 Fixed test 2019-05-19 01:19:24 +03:00
alexey-milovidov
e73fc1bd0f
Merge pull request #5320 from sundy-li/feature/funnel64
Make windowFunnel support other Unsigned Integer Types
2019-05-18 23:47:12 +03:00
Danila Kutenin
fca6e4fd38 constant string handling 2019-05-18 18:09:52 +03:00
Danila Kutenin
95cd3e5bb8 style 2019-05-18 16:38:03 +03:00
Danila Kutenin
1c6707526a style 2019-05-18 16:21:48 +03:00
Danila Kutenin
59f26b7569 some optimizations 2019-05-18 15:56:26 +03:00
Danila Kutenin
a49ee5efd6 some optimizations 2019-05-18 15:52:33 +03:00
Danila Kutenin
84b04dc8ea format function added 2019-05-18 15:29:10 +03:00
Danila Kutenin
a48cf9abe5 format function added 2019-05-18 14:30:50 +03:00
Danila Kutenin
4e3a607267 format function added 2019-05-18 14:30:36 +03:00
alexey-milovidov
dc5232d40d
Update Server.cpp 2019-05-18 13:17:26 +03:00
alexey-milovidov
24b16da9fd
Merge pull request #5235 from vitlibar/improve-new-json-functions
Improve new json functions
2019-05-18 12:51:41 +03:00
alexey-milovidov
c2132880f6
Update WriteBufferFromVector.h 2019-05-18 12:43:43 +03:00
alexey-milovidov
7985ad10ef
Update IStorage.h 2019-05-18 12:31:51 +03:00
sundy-li
dcfdc09003 fix style 2019-05-18 09:34:55 +08:00
alexey-milovidov
fa4a7eb3d1
Merge branch 'master' into merge-itable-istorage 2019-05-18 00:37:12 +03:00
alexey-milovidov
8bf48de9c9
Merge pull request #5308 from abyss7/issue-5100
Add setting to regulate Kafka committing policy
2019-05-18 00:27:19 +03:00
alexey-milovidov
8b9b305a5f
Merge pull request #5325 from abyss7/issue-5286
Allow to shadow virtual column '_table' in Merge engine
2019-05-18 00:17:34 +03:00
alexey-milovidov
34f36e2891
Merge pull request #5304 from 4ertus2/funcs
Support quantile(s) and median for Decimal
2019-05-17 23:03:27 +03:00
Danila Kutenin
e0b90de474
Merge pull request #5322 from yandex/to_valid_utf8
toValidUTF8 function added
2019-05-17 22:48:32 +03:00
Ivan Lezhankin
dcff73c8d4 Fix build 2019-05-17 21:45:42 +03:00
Ivan Lezhankin
7b6c78402d Allow to shadow virtual column '_table' in Merge engine 2019-05-17 20:40:51 +03:00
Ivan Lezhankin
7f762aee88 Move some code from header to source file. 2019-05-17 17:48:03 +03:00
Ivan Lezhankin
0821d62516 Merge ITableDeclaration into IStorage.
Also a couple of massive include-refactorings with better forwarding
2019-05-17 17:34:25 +03:00
Vitaly Baranov
095fc7b454 Optimization by using implementation-specific JSONParser::sizeOfArray(), JSONParser::sizeOfObject(). 2019-05-17 17:24:13 +03:00
Danila Kutenin
64913c4778 better names 2019-05-17 16:00:29 +03:00
Yuriy
4a14eac00b fixed memory leak and changed logging levels 2019-05-17 16:00:09 +03:00
Danila Kutenin
0d3422fa8a toValidUTF8 function added 2019-05-17 15:55:21 +03:00
alesapin
7a9dfbbb53 More stable perf tests 2019-05-17 14:42:41 +03:00
sundy-li
cbaca96926 remove spaces 2019-05-17 19:41:18 +08:00
sundy-li
4c95b9d007 modify createAggregateFunctionWindowFunnel 2019-05-17 19:31:29 +08:00
sundy-li
d3c4c1c255 modify createAggregateFunctionWindowFunnel 2019-05-17 19:30:09 +08:00
sundy-li
760bc5708d support unsigned integer type in windowFunnel Aggregate function 2019-05-17 19:17:52 +08:00
Artem Zuikov
4eee10d788
Merge pull request #5271 from 4ertus2/some
Cache ExpressionBlockInputStream header
2019-05-17 13:14:22 +03:00
alexey-milovidov
1707cd79c8
Merge pull request #5297 from github1youlc/xid_equal_to_close_xid_deadlock_fix
fix deadlock when xid equal to close_xid
2019-05-17 11:45:35 +03:00
Alexey Milovidov
48f921120c Fixed linking in "splitted" mode 2019-05-17 01:58:29 +03:00
Alexey Milovidov
09073e1229 More tests 2019-05-17 01:55:29 +03:00
Alexey Milovidov
b075de45d6 Fixed test 2019-05-17 01:51:26 +03:00
Alexey Milovidov
dd9e993a87 Fixed issue #3540 (in progress) 2019-05-17 00:09:06 +03:00
Alexey Milovidov
5352b53671 Added missing file 2019-05-16 22:57:20 +03:00
Alexey Milovidov
efd882aa29 Better logic 2019-05-16 22:55:18 +03:00
Vitaly Baranov
823d862ceb Add a setting to disable simdjson. 2019-05-16 22:39:49 +03:00
Alexey Milovidov
842d62463b Added more tests 2019-05-16 22:26:32 +03:00
Alexey Milovidov
c9343c81b3 Miscellaneous 2019-05-16 22:19:30 +03:00
Alexey Milovidov
1ae7a8d313 Force formatting of IN with single element in parentheses 2019-05-16 22:12:58 +03:00
Alexey Milovidov
d2bb2a9892 Added failing test 2019-05-16 22:00:46 +03:00
Vitaly Baranov
b90a3a4222 Add UInt64 support to JSON functions. 2019-05-16 21:22:59 +03:00
Vitaly Baranov
cb459c79aa Add a test case with incorrect JSON. 2019-05-16 20:43:01 +03:00
Vitaly Baranov
8ab4e4dcfe Use rapidjson when AVX2 instructions are not available. 2019-05-16 20:40:24 +03:00
chertus
927557b0f8 move caching to ctor 2019-05-16 20:16:25 +03:00
Yuriy
0cd3094240 fixed stack buffer overflow 2019-05-16 20:15:43 +03:00
chertus
21cf553f16 extract readDecimalText.h from readFloatText.h 2019-05-16 19:41:10 +03:00
Artem Zuikov
c3588fd5da
Merge pull request #5291 from 4ertus2/nulls
Add toDecimalOrZero and toDecimalOrNull fuctions
2019-05-16 18:53:17 +03:00
Ivan Lezhankin
a14013dff7 Add setting to regulate Kafka committing policy. 2019-05-16 18:20:30 +03:00
Artem Zuikov
1e1418652b
Merge pull request #5282 from 4ertus2/decimal
Throw Decimal overflow for Inf and NaN
2019-05-16 17:48:09 +03:00
chertus
fdcbf509bb support quantile(s)ExactWeighted for Decimal 2019-05-16 17:33:13 +03:00
Vitaly Baranov
ae4f472bc7 Add tests cases and fix documentation for JSON functions. 2019-05-16 16:48:19 +03:00
stavrolia
7b34c1c418 Merge branch 'master' of https://github.com/yandex/ClickHouse 2019-05-16 16:43:40 +03:00
chertus
50c35a70db support quanitle, quantiles, median for Decimal 2019-05-16 15:53:33 +03:00
Vitaly Baranov
263fc16bd5 Fix handling wrong JSONs. 2019-05-16 15:16:21 +03:00
chertus
ab517cdf4d Merge branch 'master' into decimal 2019-05-16 14:22:52 +03:00
Yuriy
a51c293ec6 merged 'origin/master' into mysql 2019-05-16 14:19:05 +03:00
Vitaly Baranov
f4942007e1 Add function JSONExtractKeysAndValues(). 2019-05-16 14:09:22 +03:00
Vitaly Baranov
99ab74acc6 Use CpuFlagsCache instead of __builtin_cpu_supports. 2019-05-16 14:09:22 +03:00
Vitaly Baranov
edf1c42c7b Add comments to the class template FunctionJSON. 2019-05-16 14:09:22 +03:00
Vitaly Baranov
c93bd31695 Simplify template implementation. 2019-05-16 14:09:22 +03:00
Vitaly Baranov
76bda0342b Move ExtraArg to the end of arguments of JSONExtract(). 2019-05-16 14:09:22 +03:00
Vitaly Baranov
d003682626 Implement function JSONExtractRaw(). 2019-05-16 14:09:22 +03:00
Vitaly Baranov
900f5cac81 Return Enum8 instead of string from JSONType(). 2019-05-16 14:09:22 +03:00
Vitaly Baranov
8be2e728c0 Use capital letters in the names of json functions: jsonHas => JSONHas 2019-05-16 14:09:22 +03:00
Vitaly Baranov
0d26ac8583 Reimplement indices in objects in more straightforward way 2019-05-16 14:09:22 +03:00
chertus
2739a3f6d0 Merge branch 'master' into nulls 2019-05-16 14:02:12 +03:00
stavrolia
ff4d989918 Fixed help instruction of usage 2019-05-16 13:52:41 +03:00
linceyou
c6108eec73 fix possible deadlock 2019-05-16 14:42:56 +08:00
Yuriy
4ee84810b0 including information about query execution in response 2019-05-16 08:36:08 +03:00
Yuriy
459ec05828 fixed style 2019-05-16 06:45:17 +03:00
Yuriy
ff4937859e added MySQL wire protocol presentational format 2019-05-16 06:34:04 +03:00
alexey-milovidov
dcc88f3a0c
Merge pull request #5284 from 4ertus2/bugs
fix decimal quoted csv input
2019-05-16 00:07:23 +03:00
alexey-milovidov
2affb3ca82
Update DataTypesDecimal.h 2019-05-16 00:01:14 +03:00
alexey-milovidov
8e2bdde93b
Update StorageKafka.cpp 2019-05-15 23:57:24 +03:00
alexey-milovidov
34c7886b52
Merge pull request #5288 from yandex/perf_test_fixes
Fix incorrect performance tests
2019-05-15 23:55:57 +03:00
chertus
5f19c0981d add toDecimalOrZero and toDecimalOrNull fuctions 2019-05-15 21:50:35 +03:00
proller
51ca4cbaa4
Build fixes (#5278) 2019-05-15 20:19:39 +03:00
alesapin
d477cc0df4 Fix incorrect performance tests 2019-05-15 19:44:25 +03:00
proller
0dd29e7c5b clang-format of AggregateFunctions/AggregateFunctionTSGroupSum.* 2019-05-15 19:27:44 +03:00
Yangkuan Liu
0760a3436f add AggregateFunction TSgroup{Rate}Sum (#4542) 2019-05-15 19:16:25 +03:00
Ivan
1ea9e3019d
Freeze the Kafka buffer after first empty response (#5283)
* Check inside inferior streams for cancellation while reading.
* Stop reading from Kafka buffer after first empty read.
2019-05-15 19:11:50 +03:00
Ivan Lezhankin
337ddf5047 Catch cppkafka exceptions about consumer creation failures 2019-05-15 17:23:52 +03:00
chertus
720f8667e4 fix decimal quoted csv input 2019-05-15 16:51:17 +03:00
chertus
02f01a5104 throw Decimal overflow for Inf and NaN 2019-05-15 15:28:44 +03:00
svladykin
2ca74ec259 minor tests fix 2019-05-15 13:54:58 +03:00
Artem Zuikov
98359a6a09
Merge pull request #5267 from 4ertus2/row_ref_list
RowRefList improvements
2019-05-15 13:38:48 +03:00
proller
0da7463a6b
CLICKHOUSE-4519 Support dictionaries in clickhouse-copier (#5270) 2019-05-15 12:16:09 +03:00
proller
8814e0cda5
server: informative listen error messages (#5268) 2019-05-14 22:55:10 +03:00
proller
7cb8d46338
Fix build (move code from AggregateFunctionMLMethod.h) (#5266) 2019-05-14 22:52:29 +03:00
alexey-milovidov
2cbbbba7c8
Merge pull request #5269 from vitlibar/fix-postfix-increment-in-settings
Fix postfix increment operator in Settings::iterator
2019-05-14 22:24:03 +03:00
alexey-milovidov
88b34999fe
Merge pull request #5247 from zhang2014/fix/rename_data_race
fix data race in rename query
2019-05-14 22:07:52 +03:00
chertus
4a5e2dfd3c cache ExpressionBlockInputStream header 2019-05-14 21:26:19 +03:00
Vitaly Baranov
9620e2e223
Merge pull request #5003 from Enmk/geohash_support
Implementation of geohashEncode and geohashDecode functions;
2019-05-14 20:01:22 +03:00
Ivan
4a5832b18a
Check the time limit every (flush_interval / poll_timeout) number of rows from Kafka (#5249) 2019-05-14 18:52:03 +03:00
Vitaly Baranov
4674ac2091 Fix postfix increment operator of Settings::iterator 2019-05-14 18:46:01 +03:00
chertus
b166791176 batched version of RowRefList 2019-05-14 17:40:43 +03:00
chertus
6200d20dc2 RowRefList refactoring 2019-05-14 17:39:03 +03:00
Artem Zuikov
aba710a70e
Merge pull request #5260 from 4ertus2/joins
Fix perf regression: do not add right join key to result if possible
2019-05-14 15:33:54 +03:00
proller
cc3de4115f
Build fixes (#5261) 2019-05-14 12:58:33 +03:00
chertus
ba202c2b06 fix whitespaces 2019-05-14 12:47:21 +03:00
Nikolai Kochetov
6165be54fc
Merge pull request #4943 from Quid37/master
Regression methods
2019-05-14 11:47:33 +03:00
chertus
20e7de7cce fix perf regression: do not add right join key to result if possible 2019-05-13 21:58:15 +03:00
Alexander Kozhikhov
332a8a97ab style 2019-05-13 20:08:58 +03:00
Alexander Kozhikhov
003a0fbadf conflict fix 2019-05-13 17:43:47 +03:00
alesapin
5aec6dd011 Fix banch of flapping perf tests. Improve average speed calculation 2019-05-13 17:09:11 +03:00
Alexander Kozhikhov
9b4f322fd8 Merge branch 'master' of https://github.com/yandex/ClickHouse 2019-05-13 16:50:56 +03:00
Alexander Kozhikhov
79010b7c3c some review fixes 2019-05-13 16:49:53 +03:00
zhang2014
2206ba464f fix data race in rename query 2019-05-13 15:54:38 +08:00
Guillaume Tassery
9c295fa524 Don't ask client to send write info byte if the version cannot handle it 2019-05-13 14:18:02 +07:00
Guillaume Tassery
1ae8948177 Merge branch 'master' of https://github.com/yandex/ClickHouse into send_header 2019-05-13 13:35:12 +07:00
Guillaume Tassery
a1ed3f8f6b Add checks for header progress 2019-05-13 12:55:53 +07:00
Guillaume Tassery
e2f70714a1 update tests 2019-05-13 12:07:18 +07:00