Raúl Marín
f52f6df0f4
Remove unused boost includes
2024-10-04 18:47:13 +02:00
Pablo Marcos
e1e2d07341
Refactor to allow TSA annotations
...
There doen't seem to be any way to make safeLock() or unsafeLock()
work with TSA annotations because the analyzer always thinks that
the mutex is hold and never released in the temporary var of the
body implementation.
Thus, I had to refactor to construct directly the proper locks
wherever they where needed:
safeLock() -> LockAndBlock
unsafeLock() -> Lock
Lastly, in those places where a std::unique_lock was needed because
it's the interface used for conditional_variables and others,
we use that instead of the annotated LockGuard.
2024-10-04 15:46:32 +00:00
alsu
0ad512c6e3
fix typos
2024-10-04 17:10:03 +02:00
Pablo Marcos
1219adc3ba
Merge pull request #70176 from ClickHouse/simplify-test-03246_range_literal_replacement_works
...
Simplify test 03246_range_literal_replacement_works
2024-10-04 15:03:16 +00:00
alsu
d680e52d00
fix some typos
2024-10-04 16:10:06 +02:00
Mikhail Filimonov
48e4092d98
move the injectFault back into critical section
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
7ff6bab6c2
addressing review comments
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
01ae6f9a2c
avoid unique_ptr for ScopedDecrement
2024-10-04 16:08:34 +02:00
Sergei Trifonov
c221e12be6
Update src/Common/ThreadPool.cpp
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
68dd4c273a
Addressing @ilejn comments
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
975a061896
whitespaces
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
5c0a14b78c
Revert "fix2"
...
This reverts commit 0d8dce9e7629848ea0705cdf54c093f17c3e8089.
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
dc9d09d741
fix2
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
86f222a9c0
fix
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
bf665a17b9
fix the datarace, joining the threads before modifing the threads list is crucial
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
d7fede84d8
bit better exception message and comment
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
c772f8fa46
add some assert, and explicit keyword for constructor
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
0f8ef5fb20
fix types
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
c14195c381
further improvements
2024-10-04 16:08:34 +02:00
Mikhail Filimonov
7652188ef4
grammar
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
e9dffc7897
whitespaces, unneeded method
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
9b1bc5ec77
some fixes
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
e0d8634f47
now works. it seem like the issue was caused by zero in max_free_threads in some scenarios
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
3eaf17603d
non-working, debug
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
ebd3306a67
fix
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
fbc3df5ebf
better atomics
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
34521ec662
fixes, tmp
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
dec4f59876
fixes
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
bd40b6775e
another approach
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
b31a3ac6d5
safer new_job queueing, use iterator
2024-10-04 16:08:33 +02:00
Mikhail Filimonov
6d0dd0cf9d
ThreadPool refactorings to move thread creation out of critical section.
...
Encapsulate thread management in the new subclass ThreadFromThreadPool
2024-10-04 16:08:33 +02:00
Max K.
c196d930bf
Merge pull request #70329 from ClickHouse/ci_enable_release_integration_tests_for_prs
...
CI: Enable Integration Tests for backport PRs
2024-10-04 13:22:47 +00:00
János Benjamin Antal
c07f2b70d3
Merge pull request #70352 from filimonov/maybe_fix_kafka
...
fix Kafka test
2024-10-04 13:17:27 +00:00
avogar
07868f91b0
Revert unneded changes
2024-10-04 13:12:44 +00:00
avogar
31c1720086
Fix crash during GROUP BY JSON sub-object subcolumn
2024-10-04 13:12:04 +00:00
Pavel Kruglov
9c7cf57dd1
Fix build
2024-10-04 14:37:13 +02:00
Raúl Marín
bb57261f5d
Merge pull request #70338 from Algunenano/with_fill_analyzer
...
Fix crash when using WITH FILL incorrectly
2024-10-04 12:24:09 +00:00
Pavel Kruglov
a4cd3b326a
Merge branch 'master' into native-json-as-string
2024-10-04 14:14:39 +02:00
Anton Popov
af989353e4
Merge pull request #70273 from ucasfl/fix-use-of-uninitialized-vaue
...
Fix use-of-uinitialized-value
2024-10-04 12:06:21 +00:00
Nikolai Kochetov
c6d5d616fe
Fix typo.
2024-10-04 11:38:58 +00:00
Nikolai Kochetov
cccdd22f95
Add comments. Set proper setting.
2024-10-04 11:24:10 +00:00
Daniil Ivanik
2fdf802c93
Merge pull request #70101 from rschu1ze/vec-search-adaptive-granularity
...
Make vector similarity indexes work with adaptive granularity
2024-10-04 11:05:45 +00:00
Nikolai Kochetov
28bf90d6c1
Merge branch 'master' into add-compatibility-for-merge-tree-settings
2024-10-04 10:44:30 +00:00
Nikolai Kochetov
0cc5940fba
Merge pull request #70327 from jsc0218/IgnoreInDeduplicateMergeProjectionMode
...
Add Ignore Option In DeduplicateMergeProjectionMode
2024-10-04 10:25:43 +00:00
Christoph Wurm
dab614ee4b
Align other sources paragraph
2024-10-04 10:59:28 +01:00
Kseniia Sumarokova
cbd1212a41
Merge pull request #70336 from filimonov/maybe_fix_rabbitmq
...
Maybe fix RabbitMQ
2024-10-04 09:43:00 +00:00
Antonio Andelic
8d0b021268
Fix
2024-10-04 11:24:51 +02:00
Antonio Andelic
ffe9aa1af6
Merge branch 'master' into use-json-for-minio-logs
2024-10-04 11:24:14 +02:00
Azat Khuzhin
b74c8c60ac
Update comments in VectorSimilarityCondition (WHERE is not supported)
...
Follow-up for: 40bed3e20f
2024-10-04 11:14:00 +02:00
Christoph Wurm
17c124fa71
Update grant.md: Complete list of SOURCES grants
...
Align with the current list of sources grants in the source code here: af1a0f12aa/src/Access/Common/AccessType.h (L226-L240)
2024-10-04 10:13:35 +01:00
