Azat Khuzhin
8a209a78d7
Set query_id for mutations/merges
...
This will allow to distinguish allocations in trace_log.
2021-10-15 01:43:28 +03:00
Azat Khuzhin
3477ab52a7
Add StorageID::getShortName()
2021-10-15 01:43:28 +03:00
Azat Khuzhin
8cc45bea7b
Avoid accounting memory from another mutation/merge
...
Before this path it was possible that one merge/mutation may account
memory from another, due to ThreadStatus::untracked_memory.
And this cause flakiness of 01200_mutations_memory_consumption.
2021-10-15 01:43:28 +03:00
Azat Khuzhin
fd38cbb0df
Fix memory tracking for merges and mutations (by destroying earlier)
...
It fixes only some tiny allocations, and so it should not affect any
huge mutations/merges.
And plus, this should not be a real fix, since peak_memory_usage is
obtained before even destrying this objects, and destroing objects will
unlikely update peak memory usage (although it is possible).
v0: do this in dtors
v2: do this earlier
2021-10-15 01:43:27 +03:00
Azat Khuzhin
e4b39ca99c
Remove unused Block member from MutateTask
...
v0: Fix excessive memory usage in MutateTask
This is relevant only for 01200_mutations_memory_consumption test, since
this is just a block.
v2: just remove unused Block member, since other part had been fixed in #29768
2021-10-15 01:43:27 +03:00
Azat Khuzhin
ae980fcd62
Move 01200_mutations_memory_consumption out from bugs
2021-10-15 01:43:27 +03:00
Azat Khuzhin
5d5f94f456
Mark 01200_mutations_memory_consumption as long and allow run in fasttest
2021-10-15 01:43:27 +03:00
Azat Khuzhin
a063097fdf
Fix INSERT SELECT incorrectly fills MATERIALIZED column based of Nullable column
...
Required columns of the default expression should not be converted to NULL,
since this map value to default and MATERIALIZED values will not work.
Consider the following structure:
- A Nullable(Int64)
- X Int64 materialized coalesce(A, -1)
With recursive_null_as_default=true you will get:
_CAST(coalesce(A, -1), 'Int64') AS X, NULL AS A
And this will ignore default expression.
Fixes : #23524 (Cc: @kssenii)
Fixes : #29729 (Cc: @tavplubix)
Backport: 21.7+
2021-10-15 01:36:09 +03:00
alexey-milovidov
bc1662b9fe
Merge pull request #29946 from azat/log-fix-data-race
...
Fix data-race between LogSink::writeMarks() and LogSource in StorageLog
2021-10-15 01:30:58 +03:00
alexey-milovidov
8d694cbcdc
Merge pull request #29959 from azat/log-data-race-file-checker-fix
...
Fix possible data-race between FileChecker and StorageLog/StorageStripeLog
2021-10-15 01:30:23 +03:00
alexey-milovidov
9a57fbc9e8
Merge pull request #30150 from azat/test_MemoryTracking-flap
...
Make test_MemoryTracking::test_http not flaky
2021-10-15 01:28:59 +03:00
karnevil13
8ec43b7c70
fixed type-conversion-functions en-ru
2021-10-15 00:56:21 +03:00
Azat Khuzhin
bb8105951f
Disable fsync_metadata on CI
...
Sometimes we see that pretty simple queries like CREATE DATABASE can
take > 30 seconds, let's try to disable fsync.
CI: https://clickhouse-test-reports.s3.yandex.net/30065/e5bc573250d3d6938937739b05d6f8cf618722db/functional_stateless_tests_(address).html#fail1
CI: https://clickhouse-test-reports.s3.yandex.net/30065/e5bc573250d3d6938937739b05d6f8cf618722db/functional_stateless_tests_(release).html#fail1
2021-10-15 00:53:34 +03:00
Maksim Kita
5b5ba5fbc8
Merge pull request #30179 from kitaisreal/clickhouse-local-support-sql-user-defined-functions
...
Support SQL user defined functions for clickhouse-local
2021-10-14 23:14:18 +03:00
Maksim Kita
a51ab78c68
Fixed style check
2021-10-14 23:13:41 +03:00
Maksim Kita
888c619472
Merge pull request #30145 from kitaisreal/functions-json-avoid-copying-object-element-during-iteration
...
FunctionsJSON avoid copying object element during iteration
2021-10-14 23:11:16 +03:00
Maksim Kita
5568461acf
FunctionsJSON move to cpp file
2021-10-14 23:10:53 +03:00
Artur Filatenkov
74e3978110
commit assert to fix build
2021-10-14 22:55:17 +03:00
Maksim Kita
913a8f3640
Fixed style check
2021-10-14 22:15:21 +03:00
Maksim Kita
83879415b4
Fixed tests
2021-10-14 22:12:06 +03:00
Nikolai Kochetov
6b251ddd97
Merge pull request #30193 from ClickHouse/try-to-fix-01288_shard_max_network_bandwidth
...
Smaller smoothing window in throttler.
2021-10-14 22:10:37 +03:00
Nikolai Kochetov
700504e7d6
Update Internals.cpp
2021-10-14 22:09:44 +03:00
avogar
2da8180613
Add space after comma
2021-10-14 21:39:09 +03:00
avogar
8729201208
Remove redundant move
2021-10-14 21:36:57 +03:00
avogar
89c1a04ef4
Fix comments
2021-10-14 21:35:56 +03:00
Nikolai Kochetov
aa56fd1592
Fix style.
2021-10-14 21:29:02 +03:00
Nikolai Kochetov
e9cab3aaad
Smaller smoothing window in throttler.
2021-10-14 21:20:19 +03:00
Azat Khuzhin
d030e08d05
Make test_MemoryTracking::test_http not flaky
...
By comparing only megabytes in the memory changes, instead of bytes as
before, since it may be tricky at least due to max_untracked_memory and
how thread pool handle it.
It should be safe, since originally it was written in #16121 which fixes
issue #15932 , which has ~4MB consumption of memory per request.
2021-10-14 21:06:39 +03:00
Azat Khuzhin
56ab0e31e6
Add description for test_MemoryTracking
2021-10-14 21:06:22 +03:00
Cody Baker
4dd1a4fe5c
Update release date
2021-10-14 10:41:41 -06:00
Cody Baker
7b1eb7cb54
Add 21-10 release blog post
2021-10-14 10:16:10 -06:00
Amos Bird
4800749d32
make Ctrl-J to commit
2021-10-14 23:56:28 +08:00
Sébastien
693060552a
add support of window function in antlr grammar
2021-10-14 17:40:14 +02:00
Kruglov Pavel
8d1c51c422
Update Client.cpp
2021-10-14 18:18:04 +03:00
Dmitry Novik
2f6d771d94
Remove trailing whitespace
2021-10-14 18:15:30 +03:00
Dmitry Novik
4ebb2455d8
Delete 01939_network_send_bytes_metrics test
2021-10-14 17:56:34 +03:00
mergify[bot]
92dd528c78
Merge branch 'master' into remove_trash
2021-10-14 14:14:07 +00:00
mergify[bot]
c3b559786e
Merge branch 'master' into debug_keeper
2021-10-14 14:11:49 +00:00
avogar
5daed60eae
Skip test in case of replicated database
2021-10-14 16:43:23 +03:00
avogar
f754881e1f
Fix output String data into Text CapnProto type
2021-10-14 16:43:23 +03:00
Kruglov Pavel
9b909f3f30
Try to fix test
2021-10-14 16:43:23 +03:00
Kruglov Pavel
9ec6930c15
Better exception handling
2021-10-14 16:43:23 +03:00
Kruglov Pavel
95790b8a1c
Update CapnProtoUtils.cpp
2021-10-14 16:43:23 +03:00
Kruglov Pavel
dd4421d4b1
Fix build
2021-10-14 16:43:23 +03:00
avogar
5d16dc7f9a
Try to fix tests, update capnp lib to eliminate problem with UB sanitizer
2021-10-14 16:43:23 +03:00
Kruglov Pavel
9ddcdbba39
Add INCORRECT_DATA error code
2021-10-14 16:43:23 +03:00
avogar
f88a2ad653
Handle exception when cannot extract value from struct, add test for it
2021-10-14 16:43:23 +03:00
Kruglov Pavel
17ed293470
Fix test
2021-10-14 16:43:22 +03:00
avogar
ed8818a773
Fix style, better check in enum comparison
2021-10-14 16:43:22 +03:00
Kruglov Pavel
c97f375728
Fix style
2021-10-14 16:43:22 +03:00