Commit Graph

156003 Commits

Author SHA1 Message Date
Robert Schulze
63ea58d774
Incorporate review feedback 2024-10-15 17:19:50 +00:00
Robert Schulze
a197f19396
Some unrelated minor fixes 2024-10-15 16:59:15 +00:00
Kseniia Sumarokova
b2fd0a905a
Merge pull request #70590 from aalexfvk/ignore_shadow_frozen_metadata
Ignore frozen_metadata.txt while traversing shadow directory from system.remote_data_paths
2024-10-15 16:12:56 +00:00
Alexey Milovidov
dfbd356295
Merge pull request #69481 from bigo-sg/poc_orc_lc_read
Allow reading LowCardinality(String/FixedString) data from orc dictionary encoded columns
2024-10-15 15:45:16 +00:00
Alexey Milovidov
1dfc68aefc
Merge pull request #70503 from cwurm/patch-5
Update settings.md: Clarify throw_if_no_data_to_insert
2024-10-15 15:44:13 +00:00
Alexey Milovidov
1c4d188974
Merge pull request #70660 from ClickHouse/fix-incorrect-formatting-of-check-query
Fix incorrect formatting of CHECK query
2024-10-15 15:42:17 +00:00
Nikolai Kochetov
96b9f4aa32
Merge pull request #70158 from ClickHouse/remove-plan-streams
Remove QueryPlan DataStream.
2024-10-15 15:40:02 +00:00
Alexey Milovidov
d7482835fb
Merge pull request #70677 from ClickHouse/sqltest-report
Add report file to the test results
2024-10-15 15:38:50 +00:00
Anton Popov
d7db8d0093 fix test 2024-10-15 15:27:23 +00:00
Nikita Mikhaylov
7c5374d7d7
Update contrib/grpc-cmake/CMakeLists.txt
Co-authored-by: Aris Tritas <113912678+aris-aiven@users.noreply.github.com>
2024-10-15 17:26:05 +02:00
Vladimir Cherkasov
bdc186d5da
Merge pull request #69738 from ClickHouse/vdimir/window-funnel-fix-dedup2
Fix windowFunnel counting same event several times
2024-10-15 15:12:15 +00:00
Shichao Jin
f29900d735
Merge pull request #70612 from AlekseyKanaev/settings-users_docs_fix
Fixed docs typo in settings-users.md
2024-10-15 15:08:20 +00:00
Raúl Marín
94c6fab3a0 Fix infinite recursion when infering a proto schema with skip unsupported fields enabled 2024-10-15 17:06:35 +02:00
Anton Popov
8738f57d4d Merge remote-tracking branch 'upstream/master' into HEAD 2024-10-15 14:56:23 +00:00
Anton Popov
143683aedf fix filling of missed arrays 2024-10-15 14:52:55 +00:00
vdimir
4812159545
Insert into table function s3 respect query settings 2024-10-15 14:46:10 +00:00
Alexey Milovidov
cf3e9e26f1
Merge pull request #70662 from ClickHouse/remove-strange-file
Remove strange file
2024-10-15 14:26:32 +00:00
Robert Schulze
b9b7a1091b
(Re)-enable libcxx debug mode
- We previously compiled libcxx with _LIBCPP_DEBUG=0. In old libcxx
  versions, this (surprisingly) enabled the basic debug mode [1].

- In libcxx 15 (the version we are currently using), _LIBCPP_DEBUG=0
  does nothing [2], the replacement is _LIBCPP_ENABLE_DEBUG_MODE=1.

- The debug mode is only enabled in Debug builds. Their docs say the
  extra check change complexity guarantees + the asserts crash which we
  don't want in Release builds. The debug mode detects issues like in
  [3]. Crashes look like this (for example)

  ```
  /data/ch/contrib/llvm-project/libcxx/include/__iterator/wrap_iter.h:99: assertion ::std::__libcpp_is_constant_evaluated() || (__get_const_db()->__dereferenceable(this)) failed: Attempted to increment a non-incrementable iteratorAborted (core dumped)
  ```

- I had to mute some new clang-tidy warnings in places that deal with
  container iterators. They got heavier and copy-by-value now yields a
  warning, e.g.

     for (auto it : iterators) /// <-- warning
         [...]

[1] https://releases.llvm.org/12.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html
[2] https://releases.llvm.org/15.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html
[3] https://github.com/llvm/llvm-project/blob/main/libcxx/test/support/container_debug_tests.h
2024-10-15 13:46:07 +00:00
Antonio Andelic
d8af90be5c Merge branch 'master' into fix-preadv2-with-nowait 2024-10-15 15:31:23 +02:00
Alexey Milovidov
6f170b0948 Empty commit 2024-10-15 15:15:15 +02:00
Arthur Passos
1e7f5b0705 docs change 2024-10-15 10:02:40 -03:00
Nikita Mikhaylov
fac2302d6d CXX version for GRPC 2024-10-15 14:41:07 +02:00
Arthur Passos
fd78ef62b4 fix in with invalid conversion 2024-10-15 09:30:41 -03:00
kssenii
26f9631e8f Fix test 2024-10-15 14:01:15 +02:00
Alexey Milovidov
f8346c8563 Merge branch 'master' into remove-strange-file 2024-10-15 13:59:20 +02:00
Mikhail f. Shiryaev
6d7091c224
Add report file to the test results 2024-10-15 13:41:22 +02:00
Nikita Taranov
5fbf184c08 fix 2024-10-15 12:17:34 +01:00
Vladimir Cherkasov
befc98ad5b
Merge branch 'master' into vdimir/window-funnel-fix-dedup2 2024-10-15 13:09:21 +02:00
Yarik Briukhovetskyi
4f3c9c3ee8
Merge pull request #70358 from azat/fix-protobuf-schema-cache-drop
Fix possible use-after-free in SYSTEM DROP FORMAT SCHEMA CACHE FOR Protobuf
2024-10-15 10:39:56 +00:00
alesapin
963d5e11e9 Fix clang tidy 2024-10-15 11:35:45 +02:00
Aleksei Filatov
a67b0af276
Update src/Core/Settings.cpp
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2024-10-15 12:30:14 +03:00
Aleksei Filatov
2843ef9feb
Update docs/en/operations/settings/settings.md
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2024-10-15 12:29:51 +03:00
Kseniia Sumarokova
ba0b7f5689
Merge pull request #70011 from sharathks118/setting-opentelemetry
Enhance OpenTelemetry span logging to include query settings
2024-10-15 09:18:45 +00:00
Nikita Mikhaylov
09acc12ca9 Fix native MacOS build 2024-10-15 11:03:51 +02:00
李扬
8cbaec96db
Merge branch 'master' into poc_orc_lc_read 2024-10-15 16:11:08 +08:00
taiyang-li
cdceb99469 fix flaky tests 2024-10-15 16:10:13 +08:00
Robert Schulze
f23cf21ac5
Disable test in slow builds 2024-10-15 07:07:14 +00:00
liuneng
be79e34e81 support write page index 2024-10-15 14:47:02 +08:00
Alexey Milovidov
e9c6fd3300
Merge pull request #70644 from Algunenano/validation_user_directories
Don't do validation when synchronizing user_directories from keeper
2024-10-14 23:01:05 +00:00
Alexey Milovidov
80bd0cd58d Even more files are removed 2024-10-15 00:56:27 +02:00
Alexey Milovidov
13d74479b9 Remove more files 2024-10-15 00:54:26 +02:00
Alexey Milovidov
d6e546bd54 Remove more files 2024-10-15 00:53:31 +02:00
Alexey Milovidov
a906883919 Remove strange file 2024-10-15 00:51:17 +02:00
Alexey Milovidov
7591628553 Add a test 2024-10-14 23:52:28 +02:00
Alexey Milovidov
09dae8c5e8 Fix incorrect formatting of CHECK query 2024-10-14 23:49:21 +02:00
Alexey Milovidov
332671085a
Merge pull request #70604 from Blargian/patch-9
[Docs] Fix example
2024-10-14 21:38:03 +00:00
Alexey Milovidov
11e53d5de7
Merge pull request #70634 from Algunenano/private_public_sync
Reduce sync efforts with private
2024-10-14 21:30:05 +00:00
Alexey Milovidov
d957aa1c57
Merge pull request #70646 from ClickHouse/fix-drop-pg-db-timeout
Fix timeout in materialized pg tests
2024-10-14 21:28:36 +00:00
Alexey Milovidov
85ff1c0fc2
Merge pull request #70656 from ClickHouse/docs-mysql-remove-badge
[Docs] Remove cloud only badge
2024-10-14 21:28:22 +00:00
Alexey Milovidov
5c09cf5049
Merge pull request #70640 from ClickHouse/try-fix-cache-test
Try fix 00180_no_seek_avoiding_when_reading_from_cache
2024-10-14 21:13:57 +00:00