Commit Graph

120408 Commits

Author SHA1 Message Date
Igor Nikonov
687cbc57bb Fix typo 2023-07-21 22:15:02 +00:00
Alexey Milovidov
d0cb6596e1
Merge pull request #52259 from Chen768959/fix-50582
fix issue#50582 Not found column NULL in block
2023-07-22 01:05:59 +03:00
robot-clickhouse
9280f4a9fd
Merge pull request #51958 from ClickHouse/prewhere_and_pk_columns
Move conditions with columns from PK to the end of PREWHERE chain
2023-07-22 00:05:41 +02:00
Alexey Milovidov
c6ffc9f266
Update 02815_fix_not_found_constants_col_in_block.sql 2023-07-22 01:05:39 +03:00
robot-ch-test-poll2
69b897d726
Merge pull request #52113 from arenadata/ADQM-996
Collect logs for the system.text_log table even before it is initialized, to record the server startup
2023-07-22 00:01:45 +02:00
Alexey Milovidov
de949b6844
Merge pull request #52306 from ClickHouse/backuptestfix
Add missing replica syncs in test_backup_restore_on_cluster
2023-07-22 00:57:24 +03:00
Igor Nikonov
6c8d5ca0a5 Fix: remove redundant distinct with views 2023-07-21 21:33:51 +00:00
Igor Nikonov
8c8e097b72
Merge pull request #51013 from bigo-sg/grace_hash_join_full_right_202306
Grace hash join support full & right join
2023-07-21 22:22:06 +02:00
Nikolai Kochetov
01cb502af3
Merge pull request #52151 from amosbird/fix_52075
Fix incorrect projection analysis when aggregation expression contains monotonic functions
2023-07-21 18:30:27 +02:00
Raúl Marín
3acb6005f0 Reduce the number of syscalls in FileCache::loadMetadata 2023-07-21 17:08:01 +02:00
Amos Bird
b459da7d8a
Merge branch 'master' into fix_52055 2023-07-21 22:02:04 +08:00
Antonio Andelic
6ed97a944f
Merge pull request #49450 from myrrc/feature/keeper-dyn-reconf
`reconfig` support for CH Keeper
2023-07-21 15:59:25 +02:00
robot-clickhouse
2a6b96f9e3 Automatic style fix 2023-07-21 13:51:40 +00:00
Amos Bird
c080e9b450
Fix normal projection with merge table 2023-07-21 21:48:49 +08:00
Alexander Sapin
abd8bfed2b Remove comment 2023-07-21 15:44:49 +02:00
Yarik Briukhovetskyi
e7b9b42326
Merge branch 'master' into rewrite_uniq_to_count 2023-07-21 15:30:03 +02:00
Alexander Gololobov
cb53d762ea Fix one more case 2023-07-21 15:23:24 +02:00
Nikolai Kochetov
b5cf644668
Check projection metadata the same way we check ordinary metadata. (#52361)
* Check projection metadata the same way we check ordinary metadata.

* Allow aggregate projection to have empty PK

---------

Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-07-21 16:23:04 +03:00
Alexander Gololobov
8d4c840e2d Some more cases 2023-07-21 15:15:35 +02:00
Alexander Sapin
4695ec6802 Add an ability to specify allocations size for sampling memory profiler 2023-07-21 14:56:29 +02:00
Kseniia Sumarokova
8ec8388a9e
Update gtest_lru_file_cache.cpp 2023-07-21 14:53:02 +02:00
robot-clickhouse-ci-2
0db9c79886
Merge pull request #52332 from rschu1ze/better-formatsettings
Minor: Less awkward IAST::FormatSettings
2023-07-21 14:49:58 +02:00
robot-ch-test-poll4
62e01df545
Merge pull request #52104 from filimonov/last_removal_attempt_time_typo
Fix typo last_removal_attemp_time
2023-07-21 14:49:36 +02:00
Alexey Milovidov
dc0abd38a9
Merge pull request #52376 from Algunenano/hot_cold_zero_copy
[RFC] Wait for zero copy replication lock even if some disks don't support it
2023-07-21 15:28:41 +03:00
Krzysztof Góralski
c9ffbcbe9d
Merge branch 'master' into filesystemCacheSizeLimitMetric 2023-07-21 14:17:26 +02:00
Alexander Tokmakov
b45c2c939b
disable expression templates for time intervals (#52335) 2023-07-21 15:17:07 +03:00
Nikita Mikhaylov
5ea0971921
Merge pull request #52379 from ClickHouse/fix-test-with-encrypted-disks
Fix `test_replicated_merge_tree_encrypted_disk `
2023-07-21 14:12:51 +02:00
Antonio Andelic
59ad2d9acc
Merge branch 'master' into feature/keeper-dyn-reconf 2023-07-21 14:08:26 +02:00
Alexander Tokmakov
d9161c7276
Merge pull request #52382 from ClickHouse/tavplubix-patch-8
Less replication errors
2023-07-21 14:58:25 +03:00
Azat Khuzhin
1fe8076b94 Fix capabilities installed via systemd service (fixes netlink/IO priorities)
CapabilityBoundingSet that contained in systemd unit before is about
allowing to set some capabilities, not about granting them.

To grant them you need to use AmbientCapabilities.

And if you do not use 'clickhouse install' then:
- IO priorities was unavailable (since they requires CAP_SYS_NICE)
- For taskstats the procfs was used instead of netlink

Not a big deal, but still.

Here how it had been tested:

    $ systemd-run -p CapabilityBoundingSet=CAP_NET_ADMIN --shell
    root:/etc (master)# capsh --print
    Current: cap_net_admin=ep
    Bounding set =cap_net_admin
    Ambient set =

    $ systemd-run -p User=azat -p CapabilityBoundingSet=CAP_NET_ADMIN --shell
    azat:/etc$ capsh --print
    Current: =
    Bounding set =cap_net_admin
    Ambient set =

    $ systemd-run -p User=azat -p AmbientCapabilities=CAP_NET_ADMIN -p CapabilityBoundingSet=CAP_NET_ADMIN --shell
    azat:/etc$ capsh --print
    Current: cap_net_admin=eip
    Bounding set =cap_net_admin
    Ambient set =cap_net_admin

Note, if you are running it under root (without changing user) you don't
need to specify AmbientCapabilities additionally, because root has all
capabilities by default and they had been inherited.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-21 13:57:31 +02:00
Kseniia Sumarokova
1c2fea4980
Merge pull request #52381 from ClickHouse/kssenii-patch-7
Follow up to #49698
2023-07-21 13:51:33 +02:00
Azat Khuzhin
0f96992322 Fix possible EADDRINUSE ("Address already in use") in integration tests
Here is one example [1]:

    minio1_1    | WARNING: Console endpoint is listening on a dynamic port (32911), please use --console-address ":PORT" to choose a static port.
    minio1_1    | ERROR Unable to initialize console server: Specified port is already in use
    minio1_1    |       > Please ensure no other program uses the same address/port

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/52103/7d510eac7c5f0dfb3361e269be30972e6022fada/integration_tests__tsan__[1_6].html

And here is second [2]:

    java.net.BindException: Problem binding to [0.0.0.0:50020] java.net.BindException: Address already in use; For more details see:  http://wiki.apache.org/hadoop/BindException

  [2]: https://s3.amazonaws.com/clickhouse-test-reports/51493/63e88b725d3d255a6534adce4d434ce5f95d2874/integration_tests__asan__[1_6].html

v2: increase the limit from 5K to 10K
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-21 13:47:42 +02:00
serxa
66c8066cd5 add test 2023-07-21 11:45:44 +00:00
Nikolai Kochetov
e02a7c7382
Merge pull request #52375 from ClickHouse/disable-analyzer-bc-tests
Disable analyzer setting in backward_compatibility integration tests.
2023-07-21 13:39:06 +02:00
serxa
8970a53145 Fix countSubstrings() hang with empty needle and a column haystack 2023-07-21 11:38:46 +00:00
Kruglov Pavel
f749b52f24
Merge pull request #51582 from azat/hedged-requests-timeouts
Fix timeout for hedged requests
2023-07-21 13:28:49 +02:00
Antonio Andelic
10c2d5dade
Merge branch 'master' into feature/keeper-dyn-reconf 2023-07-21 13:24:18 +02:00
Kruglov Pavel
921d25e4e4
Merge branch 'master' into hedged-requests-timeouts 2023-07-21 13:23:49 +02:00
Antonio Andelic
3815a6aa62 Make test_keeper_force_recovery more stable 2023-07-21 11:16:02 +00:00
Antonio Andelic
4a47040763
Merge pull request #52358 from ClickHouse/fix-keeper-apply-snapshot
Fix `apply_snapshot` in Keeper
2023-07-21 12:52:12 +02:00
robot-ch-test-poll2
65136ca64c
Merge pull request #52380 from ClickHouse/fix-test-for-parallel-formatting
Fix `02122_parallel_formatting_XML `
2023-07-21 12:50:42 +02:00
alesapin
8ff54591dd
Merge pull request #52283 from ClickHouse/fix-01111_create_drop_replicated_db_stress
Fix test `01111_create_drop_replicated_db_stress`
2023-07-21 12:34:10 +02:00
Kseniia Sumarokova
e638a9ecd3
Fix style check 2023-07-21 12:24:36 +02:00
Krzysztof Góralski
3412dd2259
removed unnecessary whitespace 2023-07-21 12:14:30 +02:00
Krzysztof Góralski
930d45303c
removing the metric set from LRUFileCachePriority.cpp 2023-07-21 12:13:38 +02:00
Krzysztof Góralski
5fa45bdbea
Setting the metric FilesystemCacheSizeLimit in LRUFileCachePriority.h 2023-07-21 12:12:34 +02:00
Amos Bird
2cad81731b
Try to fix style issues 2023-07-21 16:47:23 +08:00
Amos Bird
8187118232
Better code 2023-07-21 16:47:23 +08:00
Amos Bird
53d77e6b13
Add back missing projection QueryAccessInfo. 2023-07-21 16:47:22 +08:00
Krzysztof Góralski
f9d310c77e
Merge branch 'master' into filesystemCacheSizeLimitMetric 2023-07-21 10:29:34 +02:00