Commit Graph

2635 Commits

Author SHA1 Message Date
alesapin
a2e7e9f232 Remove unused constructor and rename method 2020-06-19 18:21:48 +03:00
alesapin
3c47faa9da Move partition key initialization into registerMergeTree 2020-06-19 18:14:08 +03:00
Nikolai Kochetov
f6cd3f43bb Fix Context leak in InterpreterSelectQuery 2020-06-19 17:42:01 +03:00
Alexey Milovidov
468eaa8d93 Remove unused method 2020-06-19 17:21:26 +03:00
Alexey Milovidov
5211a42c04 Remove leader election, step 3 2020-06-19 17:18:58 +03:00
Nikolai Kochetov
6c9c33f870 Fix Context leak in InterpreterSelectQuery 2020-06-19 17:00:11 +03:00
Nikolai Kochetov
ec892775a5 Fix Context leak in InterpreterSelectQuery 2020-06-19 16:34:40 +03:00
Maxim Babenko
5895f25166 Styling 2020-06-19 16:30:00 +03:00
Maxim Babenko
8436688437 Add unittests for push_back_raw_many 2020-06-19 16:21:54 +03:00
alesapin
016ee6316f Add missed check 2020-06-19 15:05:29 +03:00
alexey-milovidov
3e06182079
Update InterpreterSelectQuery.cpp 2020-06-19 14:28:48 +03:00
Nikolai Kochetov
b85b6a6cc2 Fix MergingAggregatedStep 2020-06-19 14:27:07 +03:00
alexey-milovidov
397f0aa721
Merge pull request #11746 from azat/build-fix
Fix usage/linking of static dbms library (add clickhouse_aggregate_functions)
2020-06-19 14:26:52 +03:00
alesapin
ce0c5faf9e Merge branch 'fix_alter_with_materialized' into atomic_metadata5 2020-06-19 14:00:32 +03:00
Nikolai Kochetov
0335c698e0 Limit the number of threads. 2020-06-19 13:57:44 +03:00
alesapin
4b6db63fff Fix alter key when materialized column passed 2020-06-19 13:53:20 +03:00
Nikolai Kochetov
cac365689f Fix mx_threads in query_plan. 2020-06-19 13:45:48 +03:00
Ivan Lezhankin
747a3bb0e8 Support H3 in Arcadia 2020-06-19 13:06:42 +03:00
Nikolai Kochetov
690b88d331
Merge pull request #11291 from Provet/master
Partial sorting optimization fix
2020-06-19 12:58:44 +03:00
Nikolai Kochetov
9ddd7b98cc Fix tests. 2020-06-19 12:47:15 +03:00
Mikhail Filimonov
9609bd9dee Kafka better states, formats based on PeekableReadBuffer, and other minor fixes.
Add formats tests, fixes for JSONCompactEachRowWithNamesAndTypes, TSVWithNamesAndTypes. Some CR fixes
Add sanitizing for kafka_max_block_size and kafka_poll_max_batch_size
2020-06-19 10:49:05 +02:00
Nikolai Kochetov
6708ae75f3 Fix build. 2020-06-19 11:30:21 +03:00
Nikolai Kochetov
cda4de40d7 Merge branch 'master' into query-plan 2020-06-19 11:29:15 +03:00
alesapin
67062f45be Merge branch 'master' into atomic_metadata5 2020-06-19 11:09:03 +03:00
Anton Popov
36b9847d9a
Merge pull request #11768 from CurtizJ/any-input-optimize
Sligtly better code after #11529.
2020-06-19 03:36:49 +03:00
tavplubix
bed1f37790
Merge pull request #11214 from Potya/multiword_data_type
Add some multiword data types
2020-06-18 23:47:37 +03:00
Nikolai Kochetov
1f013208db Fix style. 2020-06-18 23:11:42 +03:00
alesapin
009977c20c Fix locks 2020-06-18 22:45:37 +03:00
Nikolai Kochetov
de6ef17d27 Fix QueryPipeline::unitePipelines 2020-06-18 22:42:28 +03:00
Ruslan
f44dbcd2ab
Fix crash in min(multiply(1)) with optimize_arithmetic_operations_in_aggregate_functions (#11756) 2020-06-18 22:25:28 +03:00
Nikolai Kochetov
26161aac8a Fix ReadFromStorageStep 2020-06-18 22:17:21 +03:00
Nikolai Kochetov
6cbdb6da00 Fix build. 2020-06-18 22:03:21 +03:00
Nikolai Kochetov
0ba7ff85e1 Fix build. 2020-06-18 21:45:27 +03:00
Nikolai Kochetov
7bfb5c9a47 Fix build. 2020-06-18 21:40:02 +03:00
Nikolai Kochetov
a99d9f7712 Fix build. 2020-06-18 21:36:37 +03:00
Nikolai Kochetov
b7bed87a7f Use QueryPlan in InterpreterSelectQuery [part 3]. 2020-06-18 21:29:33 +03:00
Nikolai Kochetov
45adacf0bc Use QueryPlan in InterpreterSelectQuery [part 2]. 2020-06-18 20:45:00 +03:00
alesapin
2ca9cfa753 Merge branch 'master' into atomic_metadata5 2020-06-18 20:28:01 +03:00
alesapin
8b131e2079 Remove int contention 2020-06-18 20:19:11 +03:00
alesapin
c666763cc0 Remove unused method better 2020-06-18 20:09:06 +03:00
Anton Popov
bd28b7e1c2 better code 2020-06-18 20:05:26 +03:00
alesapin
e888dafdc2 Remove unused method 2020-06-18 20:03:42 +03:00
Ruslan
23cd919681
Any input optimize (#11529)
* workig commit №1

* working commit №2

* first version of ArithmeticOperationsInAgrFuncOptimize (min, max, sum)

* fix conflicts

* fix №2

* attempt №3

* Description + little mistake

* fix style + expanded optimization + add performance test

* style + merge with new version

* one more branch

* bug fix + merge

* just merge

* some code style and logic fixes

* little changes

* tests

* test(2)

* style

* seems to have fixed everything that was required

* bug fix

* style

* build fix

* fix typo

* fix clang-10 warning

* fix clang-10 warning

* nolint

* add new files to ya.make

* extract all functions from Any

* add last new lines.

* extract all functions from Any

* add last new lines.

* build + requested changes

* code style

* build + little perf test + anyLast

* minor changes

* bug fix

* minor changes

* another minor changes

* fix + experement

* experement 2.0

* experement 3.0

* experement 3.1

* experement 4.0

* last experement(think so)

* just another attempt to fix UB

* minor changes

* I think I won

* ya.make

* fix requested changes

Co-authored-by: Artem Zuikov <chertus@gmail.com>
2020-06-18 19:34:29 +03:00
alesapin
b3ee8967dc Fix style 2020-06-18 19:28:20 +03:00
alesapin
54e5fe7dbc Less locks 2020-06-18 19:19:40 +03:00
Amos Bird
d524301038
add scalars in time 2020-06-19 00:14:19 +08:00
alesapin
d79982f497 Better locks in Storages 2020-06-18 19:10:47 +03:00
Alexander Tokmakov
e42c07954d fix 2020-06-18 19:01:49 +03:00
Alexander Tokmakov
5a6b70f5c1 Merge branch 'master' into multiword_data_type 2020-06-18 17:10:19 +03:00
Alexander Tokmakov
acd0d3c528 separate parser for data type 2020-06-18 17:09:24 +03:00
Nikolai Kochetov
4ec8012e27 Fix msan test. 2020-06-18 16:43:29 +03:00
Nikolai Kochetov
e0841360db Use QueryPlan in InterpreterSelectQuery [part 1]. 2020-06-18 16:38:45 +03:00
Nikolai Kochetov
35ab9ad051 Merge branch 'master' into fix-parallel-final-stuck 2020-06-18 16:04:14 +03:00
Nikolai Kochetov
5bb2ddc6f9 Add DISTINCT trait for QueryPlanStep. 2020-06-18 16:00:16 +03:00
Alexander Kuzmenkov
730c22f767
Merge pull request #11748 from ClickHouse/aku/unbreak-jemalloc-metrics
Unbreak jemalloc stats + add more of them
2020-06-18 15:24:30 +03:00
alesapin
c8a58299ac Fix storage buffer metadata 2020-06-18 14:42:48 +03:00
alesapin
1a69c3234a Fix style 2020-06-18 14:09:55 +03:00
alesapin
d4c49816ab Really atomic metadata 2020-06-18 14:02:31 +03:00
alesapin
4de5331b0d Fix SystemTables 2020-06-18 13:39:33 +03:00
alesapin
aab4ce6394 Truncate with metadata 2020-06-18 13:29:13 +03:00
Artem Zuikov
6af36cb703
CAST keep nullable (#11733) 2020-06-18 13:18:28 +03:00
alesapin
35ce47951d Fix storage merge 2020-06-18 12:22:54 +03:00
Nikolai Kochetov
21d9c7fcc8 Fix build. 2020-06-18 12:22:29 +03:00
Nikolai Kochetov
c111836ada Update PartialSortingTransform. 2020-06-18 12:08:25 +03:00
alesapin
760e9a8488 Fix crash 2020-06-18 12:08:24 +03:00
alesapin
f4037b8f54 Fix build 2020-06-18 12:00:43 +03:00
alesapin
ebb36bec8a Merge branch 'master' into atomic_metadata5 2020-06-18 11:57:16 +03:00
alesapin
d0beeaf7c4
Merge pull request #11744 from ClickHouse/stop_fetches_before_metadata_alter
Cancel fetches before metadata alter
2020-06-18 11:32:16 +03:00
Azat Khuzhin
2bd05baa7a Move AggregateFunctionCount out from clickhouse_aggregate_functions to dbms
As suggested by @alexey-milovidov
2020-06-18 11:22:40 +03:00
alexey-milovidov
c9924b8aa1
Merge pull request #11697 from CurtizJ/fix-with-fill
Fix 'ORDER BY ... WITH FILL' over const columns.
2020-06-18 06:38:24 +03:00
Alexander Kuzmenkov
07ead3c815 Use hours instead of days.
std::chrono::days is C++20 which the barbarian Arcadia build is unable
to appreciate.
2020-06-18 05:03:59 +03:00
Alexander Kuzmenkov
4e42903eac Unbreak jemalloc stats + add more of them
We didn't call the `epoch` mallctl, so all the statistics were stale.
Fix that, and also add some more statistics for arenas.
2020-06-18 04:54:10 +03:00
alexey-milovidov
b42f622a77
Merge pull request #11739 from azat/replicated-parse-zk-metadata
[RFC] Parse metadata stored in zookeeper before checking for equality
2020-06-18 03:26:48 +03:00
Azat Khuzhin
65c17f0c2c Fix usage of static dbms library (add clickhouse_aggregate_functions)
The following error reported:

    FAILED: src/Interpreters/tests/hash_map
    ...
    ld.lld: error: undefined symbol: typeinfo for DB::AggregateFunctionCount
    >>> referenced by typeinfo:308 (../contrib/libcxx/include/typeinfo:308)
    >>>               InterpreterSelectQuery.cpp.o:(std::__1::enable_if<is_pointer_v<DB::AggregateFunctionCount*>, DB::AggregateFunctionCount*>::type typeid_cast<DB::AggregateFunctionCount*, DB::IAggregateFunction>(DB::IAggregateFunction*)) in archive src/libdbms.a
    collect2: error: ld returned 1 exit status

And also this one with gold linker:

  FAILED: programs/clickhouse-odbc-bridge
  ...  src/AggregateFunctions/libclickhouse_aggregate_functions.a ... src/libdbms.a ...
  ../contrib/libcxx/include/typeinfo:308: error: undefined reference to 'typeinfo for DB::AggregateFunctionCount'

Due to order?

Introduced by 394fb64a9cda376ca8dfa8bac08a4fbcfa9bf3bf/#11661 I guess.
2020-06-18 01:53:14 +03:00
tavplubix
bb16544bee
Merge pull request #11732 from ClickHouse/fix_type_duduction_in_values_format
Fix type duduction in Values format
2020-06-18 00:21:03 +03:00
alesapin
870d891257 Cancel fetches before metadata alter 2020-06-17 23:25:43 +03:00
Nikolai Kochetov
9ad00187e3 Update InterpreterSelectQuery.. 2020-06-17 23:19:55 +03:00
Nikolai Kochetov
169ad5e805 Add FinishSortingStep. 2020-06-17 22:57:13 +03:00
Nikolai Kochetov
e8049d34c5 Add OffsetsStep. 2020-06-17 22:38:45 +03:00
Nikolai Kochetov
69ff3a8f7d Add ExtremesStep. 2020-06-17 22:30:36 +03:00
Nikolai Kochetov
d795b2b037 Add FillingStep 2020-06-17 22:20:30 +03:00
Nikolai Kochetov
7fcea660de Fix ya.make/ 2020-06-17 22:08:30 +03:00
Nikolai Kochetov
38bebfb20d Merge remote-tracking branch 'origin' into provert-master 2020-06-17 22:05:45 +03:00
Nikolai Kochetov
84fd7fe51c Update having. 2020-06-17 22:02:46 +03:00
Azat Khuzhin
caa88777be Parse metadata stored in zookeeper before checking for equality
After #11325 trailing whitespaces has been removed for data skipping
indicies, and it may be different, if you have multiple skip indices,
and in this case new server will not load such tables, because metadata
will be different.

Fix this by re-parse metadata in zookeeper.
2020-06-17 21:03:22 +03:00
Nikolai Kochetov
2cffa56914 Add RollupStep and CubeStep. 2020-06-17 20:20:09 +03:00
Nikolai Kochetov
d41db3622f Add RollupStep and CubeStep. 2020-06-17 20:15:24 +03:00
alesapin
51a47560e0 Fix segmentation fault 2020-06-17 19:59:26 +03:00
Nikolai Kochetov
c5d9379df0 Add TotalsHavingStep. 2020-06-17 19:54:51 +03:00
alesapin
dffdece350 getColumns in StorageInMemoryMetadta (only compilable) 2020-06-17 19:39:58 +03:00
maxim-babenko
c3dbf7d6bf
Fix PODArrayBase::push_back_raw_many
1) capacity check must be ready for overflow during memcpy
2) reserve must be called with the new size, not just delta
2020-06-17 19:38:23 +03:00
Nikolai Kochetov
ce7c8782e2
Update PartialSortingTransform.cpp 2020-06-17 19:13:44 +03:00
Nikolai Kochetov
1ad4f2c0fd Add CreatingSets step. 2020-06-17 18:50:21 +03:00
alesapin
ef8781cce7 Better getVirtuals method 2020-06-17 17:37:21 +03:00
alesapin
33c27de54d Check methods in metadata 2020-06-17 17:32:25 +03:00
Nikolai Kochetov
f279df6015 Added AggregatingStep. 2020-06-17 17:21:48 +03:00
alesapin
31abbe5dbd Select query in metadata 2020-06-17 17:06:22 +03:00
alesapin
eaaef83742 Settings changes in StorageInMemoryMetadata 2020-06-17 16:46:01 +03:00
alesapin
ed8f3b2fc4 TTL in storage in memory metadata 2020-06-17 16:39:26 +03:00
Nikolai Kochetov
582ea24469 Added AddingDelayedStreamStep 2020-06-17 16:38:17 +03:00
Vitaly Baranov
7011401cd4
Merge pull request #11670 from vitlibar/rbac-improve-parser-multiple-entities
RBAC: improve syntax
2020-06-17 16:26:02 +03:00
Alexander Tokmakov
3938b051c2 fix type duduction in values format 2020-06-17 16:21:06 +03:00
Alexander Tokmakov
eebfc9d2da fix build with clang-9 2020-06-17 16:19:15 +03:00
alesapin
7064a366e2 Missed change for primary key 2020-06-17 15:40:27 +03:00
alesapin
1afdebeebd Primary key in storage metadata 2020-06-17 15:39:20 +03:00
alesapin
1da393b218 Sampling key in StorageInMemoryMetadata 2020-06-17 15:07:09 +03:00
Nikolai Kochetov
8c78ae0cd9 Fix style. 2020-06-17 15:03:33 +03:00
alesapin
eca6e9087e Fix race condition 2020-06-17 14:52:19 +03:00
Nikolai Kochetov
6c477d06ad Review fixes. 2020-06-17 14:43:55 +03:00
alexey-milovidov
f55fb33731
Merge pull request #11726 from ClickHouse/remove-old-tests
Remove old non-automated tests (examples)
2020-06-17 14:25:20 +03:00
alesapin
ba04d02f1e Compilable sorting key in metadata 2020-06-17 14:05:11 +03:00
Nikita Mikhaylov
d2be6c036b
Merge pull request #11602 from ClickHouse/fix-buffer-sample
Fix buffer sample
2020-06-17 14:44:48 +04:00
Nikita Mikhaylov
ff0262626a
Merge pull request #11645 from azat/load-balancing-round-robin
Add round_robin load_balancing
2020-06-17 14:34:59 +04:00
alesapin
ab61abccc1 Partition key in StorageInMemoryMetadata 2020-06-17 13:34:23 +03:00
Nikita Mikhaylov
9b88065e77
add small comment 2020-06-17 13:33:35 +03:00
alesapin
62f2c17a66 Secondary indices in StorageInMemoryMetadata 2020-06-17 12:38:47 +03:00
xPoSx
2d8110ce45
Eliminate min/max/any aggregators of GROUP BY keys in SELECT section (#11667) 2020-06-17 12:32:43 +03:00
Nikolai Kochetov
0829d1d16d Fix ya.make 2020-06-17 12:16:01 +03:00
Nikita Mikhaylov
edec79cf69
Merge pull request #11703 from nikitamikhaylov/merging-alter-query
Merging #11508
2020-06-17 12:47:34 +04:00
Nikita Mikhaylov
edff6eac6e comment 2020-06-17 11:44:52 +03:00
alesapin
2fac3290f0 Merge branch 'master' into atomic_metadata5 2020-06-17 11:14:03 +03:00
Alexey Milovidov
3c023fe8b8 Remove old non-automated tests 2020-06-17 10:45:51 +03:00
Nikita Mikhaylov
ab04a6bb62
Merge pull request #11615 from azat/SYSTEM-FLUSH-LOGS-force-table-creation-v2
Force table creation on SYSTEM FLUSH LOGS (v2)
2020-06-17 11:09:19 +04:00
alexey-milovidov
e07d02015c
Merge pull request #11661 from ClickHouse/return-not-nullable-from-count-distinct-2
Return non-Nullable results from COUNT(DISTINCT), more complete.
2020-06-17 09:25:45 +03:00
alexey-milovidov
598fd75caf
Merge pull request #11639 from ClickHouse/remove-leader-election-2
Remove leader election, step 2: allow multiple leaders
2020-06-17 09:25:23 +03:00
alexey-milovidov
6e61f708d7
Merge pull request #11690 from ClickHouse/odbc-bridge-timeouts
Pass proper timeouts when communicating with XDBC bridge.
2020-06-17 03:18:29 +03:00
Alexey Milovidov
e720d78f23 Fix tests 2020-06-17 03:08:01 +03:00
Alexey Milovidov
a655765040 Merge branch 'master' into return-not-nullable-from-count-distinct-2 2020-06-17 01:15:57 +03:00
Alexander Kuzmenkov
9cab822718
Merge pull request #11683 from ClickHouse/aku/merge-minmap-11603
Merge minMap, maxMap (#11603)
2020-06-17 00:02:33 +03:00
Artem Zuikov
857d84bf7c
Buffer left blocks optimisation for MergeJoin (#10601) 2020-06-16 23:13:18 +03:00
alexey-milovidov
f387752cf1
Merge pull request #11702 from ClickHouse/fix-mv-header
Fix mv header
2020-06-16 22:43:38 +03:00
Alexey Milovidov
0a6054eece Merge branch 'master' into return-not-nullable-from-count-distinct-2 2020-06-16 22:31:33 +03:00
alexey-milovidov
ad53ef2c14
Merge pull request #11686 from ClickHouse/proper-query-formatting-in-log
Don't break multiline queries when they are printed in server log
2020-06-16 22:17:30 +03:00
Alexey Milovidov
6c93016c91 Add suggestion from @alesap 2020-06-16 22:16:01 +03:00
Alexey Milovidov
b7ec5f94f2 Merge branch 'master' into odbc-bridge-timeouts 2020-06-16 22:14:43 +03:00
alexey-milovidov
47bd8df9de
Merge pull request #11692 from ClickHouse/fix-flaky-test-incremental-streaming
Fix flaky test 01064_incremental_streaming_from_2_src_with_feedback
2020-06-16 22:12:46 +03:00
alexey-milovidov
6f2d9999be
Merge pull request #11693 from ClickHouse/fix-flaky-unit-tests
More robust unit tests if ZooKeeper is unavailable for some time.
2020-06-16 22:12:30 +03:00
Nikolai Kochetov
fdacc9f90e Add MergingAggregatedStep. 2020-06-16 21:57:21 +03:00
alesapin
fa60903620 Fix race condition 2020-06-16 21:41:11 +03:00
alesapin
d214a504d7
Merge pull request #11681 from ClickHouse/fix_mutations_premature_finish
Fix mutations premature "finish"
2020-06-16 21:26:14 +03:00
Nikolai Kochetov
148257abb5 Add LimitStep. 2020-06-16 21:23:01 +03:00
Azat Khuzhin
8fbf93012d Fix data race between reading/writing is_force_prepare_tables 2020-06-16 21:08:44 +03:00
Nikita Mikhaylov
fc06f99476 build and test fixes 2020-06-16 21:07:41 +03:00
alesapin
ccc2bda666 getConstraints() in StorageInMemoryMetadata (suspicious commit, but pretend to work) 2020-06-16 19:55:04 +03:00
Nikolai Kochetov
5bb1d5cc43 Add LimitByStep. 2020-06-16 19:49:49 +03:00
Artem Zuikov
a3d6e047fe
Fix lambdas with multiple_joins_rewriter v2 (#11587) 2020-06-16 19:32:32 +03:00
Nikolai Kochetov
603bcdde2d Add DistinctStep. 2020-06-16 19:13:07 +03:00
alesapin
1ddeb3d149 Buildable getSampleBlock in StorageInMemoryMetadata 2020-06-16 18:51:29 +03:00
Nikolai Kochetov
cfe87a77ea Add MergingSortedStep. 2020-06-16 18:49:09 +03:00
Nikolai Kochetov
08e9ce8661 Add MergingSortedStep. 2020-06-16 18:47:40 +03:00