Commit Graph

19577 Commits

Author SHA1 Message Date
chertus
aeefb78157 add comments to JoinSwitcher 2020-02-20 22:13:12 +03:00
Alexey Milovidov
d87e25aeab Merge branch 'master' of github.com:yandex/ClickHouse into match-zero-byte-fix 2020-02-20 21:52:50 +03:00
alexey-milovidov
d4381d7976
Merge pull request #9217 from ClickHouse/fix_mutations_finalization_one_more_time
Fix remove parts from mutations
2020-02-20 21:47:27 +03:00
alexey-milovidov
4433947670
Merge pull request #9227 from ClickHouse/simplier_alter_prepare
Simplier alter prepare
2020-02-20 21:45:27 +03:00
alexey-milovidov
5c097f842f
Merge pull request #9247 from ClickHouse/aku/logical-error-message
Log error message before aborting on LOGICAL_ERROR.
2020-02-20 21:45:01 +03:00
alexey-milovidov
f4124d3522
Merge pull request #9251 from 4ertus2/ast
Fix bug with comma JOIN and IN
2020-02-20 21:41:08 +03:00
alexey-milovidov
81f52614fd
Merge pull request #9255 from abyss7/log-alias
Don't use refs on vanishing objects
2020-02-20 21:16:32 +03:00
alexey-milovidov
79d194119b
Merge pull request #9254 from ClickHouse/fix-ndebuf-in-pipeline-executor
Fix NDEBUG in PipelineExecutor.
2020-02-20 21:16:11 +03:00
chertus
f683437a8c remove dangerous optimisation 2020-02-20 20:19:16 +03:00
Pavel Kovalenko
e593003be7 Formatting issues. 2020-02-20 19:48:52 +03:00
Pavel Kovalenko
e5b81aefe3 WriteBufferFromFileBase interface refactoring.
Disk->writeFile() returns WriteBufferFromFileBase.
DiskMemory read/write buffers refactoring.
2020-02-20 19:39:32 +03:00
millb
cf53160221 fixed bug 2020-02-20 19:21:28 +03:00
alexey-milovidov
a1193cbbf8
Merge pull request #9128 from Jokser/storage-stripe-log-s3
Storage Stripe Log S3 support.
2020-02-20 19:01:36 +03:00
Ivan Lezhankin
d211b1a482 Don't use refs on vanishing objects 2020-02-20 18:40:23 +03:00
Nikolai Kochetov
9191e5f17f Fix NDEBUG in PipelineExecutor. 2020-02-20 18:26:20 +03:00
Nikolai Kochetov
cca4d4e296 More comments and remove spaces. 2020-02-20 17:40:58 +03:00
Alexander Tokmakov
c492ee93d9 fold constant expressions in storage engine arguments 2020-02-20 17:13:43 +03:00
chertus
9748f8dcf6 fix bug with comma join and in 2020-02-20 16:33:14 +03:00
alexey-milovidov
5d4a85488e
Merge pull request #9231 from abyss7/log-alias
Get marks from first non-alias column in Log storage
2020-02-20 16:20:21 +03:00
Ivan Lezhankin
ee2cb00aa1 Use getAllPhysical() 2020-02-20 15:46:27 +03:00
CurtizJ
3f7f13ce05 Merge remote-tracking branch 'upstream/master' into polymorphic-parts 2020-02-20 15:36:55 +03:00
Alexander Kuzmenkov
642e21e8e1 Log error message before aborting on LOGICAL_ERROR. 2020-02-20 15:29:53 +03:00
Nikolai Kochetov
84af9677be Try fix external tables for RemoteBlockInputStream 2020-02-20 14:29:12 +03:00
chertus
56fa3cc1eb correct fallback for PREFER_PARTIAL_MERGE: HashJoin -> MergeJoin instead of HashJoin -> JoinSwitcher 2020-02-20 14:26:00 +03:00
alesapin
cbd8b697c4 Better error codes and exception messages, remove duplicated headers 2020-02-20 13:04:15 +03:00
alexey-milovidov
64fe250eff
Merge pull request #9211 from ClickHouse/remove-useless-code-in-compression
Remove useless code
2020-02-20 13:02:20 +03:00
alexey-milovidov
eceabbfc3f
Merge pull request #9221 from nvartolomei/nv/advertise-a-stack-trace-will-follow
Improve stack trace formatting for Poco and std exceptions
2020-02-20 12:59:58 +03:00
alexey-milovidov
63aa168a8c
Merge pull request #9229 from 4ertus2/ast
Fix CROSS to INNER JOIN rewrite with [NOT] LIKE
2020-02-20 12:54:57 +03:00
Alexander Kazakov
5a67c02a5d
In KeyCondition: Fixed execution of inversed predicates for non-strictly monotinic functional index (#9223)
* Tests for functional index

* Fixed execution of inversed predicates in functional index

When non-strictly monotonic functional index is used inverted predicated
may be executed incorrectly, which leads to multiple problems: #8821,
#9034
2020-02-20 12:53:02 +03:00
alesapin
5282f8b59c Fix tests and small bug 2020-02-20 12:22:17 +03:00
zhang2014
130e76d5c0 ISSUES-9230 pushed SelectQueryOption into join expression 2020-02-20 11:15:59 +08:00
CurtizJ
2f30a1350b pass proper time for TTL 2020-02-20 03:24:05 +03:00
alexey-milovidov
1f42d03bf8
Update SeekableReadBuffer.h 2020-02-19 22:26:33 +03:00
chertus
3d7959d2e8 fix join_algorithm and partial_merge_join settings check 2020-02-19 22:11:23 +03:00
Ivan Lezhankin
894c451cf0 Get marks from first non-alias column in Log storage 2020-02-19 21:06:18 +03:00
chertus
fa8f07374b fix CROSS to INNER JOIN rewrite with [NOT] LIKE 2020-02-19 20:22:16 +03:00
CurtizJ
803d9da496 add test for mutations with TTL 2020-02-19 20:18:12 +03:00
Nikolai Kochetov
39916dd01a Remove readWithProcessors from IStorage. 2020-02-19 19:09:31 +03:00
Nikolai Kochetov
a3c4b2e922 Remove readWithProcessors from IStorage. 2020-02-19 19:07:28 +03:00
Nikolai Kochetov
e0c30259fb Remove readWithProcessors from IStorage. 2020-02-19 19:02:37 +03:00
Nikolai Kochetov
bf18eeda95 Use processors for sending external tables. 2020-02-19 18:09:32 +03:00
alesapin
c4972b3799 Better 2020-02-19 18:07:02 +03:00
alesapin
1914b1dab7 Add missed headers 2020-02-19 17:58:06 +03:00
Pavel Kovalenko
d4fa60f52d Rename disk_name -> disk. 2020-02-19 17:50:39 +03:00
alesapin
6020f2fd4a Remove redundant function 2020-02-19 17:50:11 +03:00
alesapin
d5b4ddf6d8 Simplier alter modify logic 2020-02-19 17:49:59 +03:00
alesapin
28b2a03b08 First version 2020-02-19 17:49:45 +03:00
chertus
9f43fa87c3 make switched flag atomic 2020-02-19 17:23:21 +03:00
CurtizJ
23592991e6 comments and refactoring 2020-02-19 17:07:36 +03:00
Nikolai Kochetov
3bfbd26901 Use processors for sending external tables. 2020-02-19 17:00:49 +03:00
Nicolae Vartolomei
811197558c Improve stack trace formatting for Poco and std exceptions
Before:

```
<Error> Application: Caught exception while loading metadata: Poco::Exception. Code: 1000, e.code() = 0, e.displayText() = Access to file denied: boo0. /home/nv/clickhouse-master-clion/contrib/poco/Foundation/src/Exception.cpp:27: Poco::FileAccessDeniedException::FileAccessDeniedException(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0xbb598cc in /state/home/nv/clickhouse-builds/clickhouse-master-clion-gcc/dbms/programs/clickhous
```

After:

```
<Error> Application: Caught exception while loading metadata: Poco::Exception. Code: 1000, e.code() = 0, e.displayText() = Access to file denied: boo, Stack trace (when copying this message, always include the lines below):

0. /home/nv/clickhouse-master-clion/contrib/poco/Foundation/src/Exception.cpp:27: Poco::FileAccessDeniedException::FileAccessDeniedException(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0xbb5987c in /state/home/nv/clickhouse-builds/clickhouse-master-clion-gcc/dbms/programs/clickhous
```
2020-02-19 13:33:31 +00:00
alesapin
3b4c27b0de Fix remove parts from mutations 2020-02-19 15:55:23 +03:00
chertus
3348697128 fix storage join 2020-02-19 15:37:56 +03:00
Nikolai Kochetov
75af5414d9 Try fix test_delayed_replica_failover 2020-02-19 15:30:56 +03:00
chertus
48ac7d35ae Merge branch 'master' into joins 2020-02-19 14:21:40 +03:00
chertus
f748427ffd minor fix (remove logic dependent on partial_merge_join setting) 2020-02-19 14:20:35 +03:00
Pavel Kovalenko
d662c1e006 Merge branch 'master' into storage-stripe-log-s3 2020-02-19 13:24:23 +03:00
Nikolai Kochetov
4fa6c86114 Fix StorageHDFS. 2020-02-19 13:22:44 +03:00
Nikolai Kochetov
70a7ddc172 Fix StorageURL 2020-02-19 13:17:49 +03:00
alexey-milovidov
b063dbeaf2
Merge pull request #8598 from excitoon-favorites/passttlsoverhttp
Pass TTL rule info with block to other replicas
2020-02-19 12:09:25 +03:00
alexey-milovidov
c5d5c9c11e
Merge pull request #9192 from nvartolomei/nv/format-version-file-typo
Fix typo in file name when reporting version file duplicates
2020-02-19 11:59:22 +03:00
alexey-milovidov
1c66c2f383
Merge pull request #9201 from CurtizJ/fix-range-reader
Fix mistake introduced in #9050.
2020-02-19 11:58:21 +03:00
alexey-milovidov
77f9a358ff
Update ProfileEvents.cpp 2020-02-19 11:55:29 +03:00
alexey-milovidov
e90124dc24
Update ProfileEvents.cpp 2020-02-19 11:54:23 +03:00
Mikhail f. Shiryaev
fdc00e3562
Add description for some profiling events 2020-02-19 09:50:58 +01:00
Alexey Milovidov
b2a52a2d69 Remove useless code #9210 2020-02-19 11:49:26 +03:00
CurtizJ
dea444b69c fix mistake in MergeTreeDataSelectExecutor 2020-02-19 00:00:51 +03:00
Pavel Kovalenko
ff50a51757 Formatting issues. 2020-02-18 22:13:37 +03:00
CurtizJ
b0f7905567 better TTL calculations with mutations 2020-02-18 22:03:40 +03:00
chertus
74a5227ac4 add join_algorithm setting 2020-02-18 20:31:22 +03:00
Nikolai Kochetov
69a38958b4 fix PVS warning. 2020-02-18 19:23:29 +03:00
Pavel Kovalenko
05ceef4ef8 Log family storages disk support via 'SETTINGS' clause. 2020-02-18 17:41:30 +03:00
Nikolai Kochetov
3f55e6a499 Processors support for StorageFromMergeTreeDataPart reading. 2020-02-18 17:24:33 +03:00
chertus
fbecd0c155 use default_max_bytes_in_join in JoinSwitcher if no join limits 2020-02-18 17:19:13 +03:00
Nikolai Kochetov
5d0d2b25e1 Update MergingSortedTransform 2020-02-18 17:15:50 +03:00
Nikolai Kochetov
41851b62e9 Fix TreeExecutorBlockInputStream 2020-02-18 16:29:40 +03:00
Nikolai Kochetov
49926098d3 Update BlockStreamProfileInfo 2020-02-18 16:16:30 +03:00
chertus
f1673e1344 fix JoinSwitcher logic 2020-02-18 15:41:23 +03:00
Pavel Kovalenko
0040ad3289 Fixed includes. 2020-02-18 15:24:20 +03:00
Nicolae Vartolomei
b612cbf7d8 Fix typo in file name when reporting version file duplicates 2020-02-18 11:44:16 +00:00
Nikolai Kochetov
145cb6e12f Update TreeExecutorBlockInputStream. 2020-02-18 13:39:08 +03:00
Nikolai Kochetov
b6b4a87206 Update TreeExecutorBlockInputStream. 2020-02-18 13:37:57 +03:00
Pavel Kovalenko
a8cffd55aa Formatting issues. 2020-02-18 12:51:22 +03:00
alexey-milovidov
b688fc5895
Merge pull request #9174 from azat/O_CLOEXEC
[RFC] Set O_CLOEXEC
2020-02-18 12:50:19 +03:00
Nikolai Kochetov
9b8fa9f306 Update TreeExecutor. 2020-02-18 12:05:49 +03:00
Nikolai Kochetov
426a8fd6a2 Update TreeExecutor. 2020-02-18 12:03:17 +03:00
CurtizJ
49c80c88ef Merge remote-tracking branch 'upstream/master' into alter-ttl 2020-02-18 10:58:07 +03:00
Nikolai Kochetov
e6a30feed0 Fix build. 2020-02-18 10:53:16 +03:00
Pavel Kovalenko
33443c4bea Merge branch 'master' into storage-stripe-log-s3
# Conflicts:
#	dbms/src/Compression/CompressedReadBufferFromFile.h
#	dbms/src/IO/ReadBufferFromFileBase.h
2020-02-18 00:29:09 +03:00
Azat Khuzhin
aa252e48b8 Set O_CLOEXEC
Since clickhouse allows to execute user-specified command (i.e.
for dictionary loading), it is better not to expose them.

But there is something left for now:
- 10 -> socket:[14422712]
- 11 -> socket:[14422714]
- 12 -> anon_inode:[eventpoll]
- 13 -> anon_inode:[eventpoll]
- 14 -> anon_inode:[eventpoll]
- 15 -> socket:[14426310]
- 16 -> anon_inode:[eventpoll]
- 3 -> /proc/2739071/fd
- 6 -> socket:[14422708]
- 9 -> socket:[14422710]

And most of these (eventpoll) went from poco, for which O_CLOEXEC cannot
be passed.
2020-02-18 00:28:11 +03:00
CurtizJ
7022376a2a remove debug prints 2020-02-17 23:45:16 +03:00
CurtizJ
2ff030be35 recalculate TTL expressions during mutations 2020-02-17 23:39:24 +03:00
Pavel Kovalenko
e849654628 Reworked ReadIndirectBuffer for DiskMemory. 2020-02-17 23:08:35 +03:00
alexey-milovidov
146109fe27
Merge pull request #9161 from abyss7/arcadia
Reorganize layout of repository (part 1)
2020-02-17 21:58:20 +03:00
Alexey Milovidov
a1ccd14032 Fixed error with zero bytes in haystack for constant case #9160 2020-02-17 21:53:59 +03:00
chertus
a9e743d8bd minor JoinSwitcher optimisation 2020-02-17 20:41:38 +03:00
chertus
5717d48333 better includes 2020-02-17 20:21:03 +03:00
alexey-milovidov
35f1a8ed51
Fixed awful translation 2020-02-17 20:12:22 +03:00
chertus
4a658f4325 swtich HashJoin to MergeJoin if JOIN limit exceeded 2020-02-17 20:08:31 +03:00
Nikolai Kochetov
bdaeafffc1 Processors support for StorageLiveView reading. 2020-02-17 19:37:18 +03:00
Nikolai Kochetov
fbfaac6391 Processors support for StorageLiveView reading. 2020-02-17 19:35:23 +03:00
Nikolai Kochetov
34d7873524 Processors support for StorageKafka reading. 2020-02-17 19:08:22 +03:00
Nikolai Kochetov
98b6ad4eff Processors support for StorageXDBC reading. 2020-02-17 18:33:16 +03:00
Nikolai Kochetov
dda0bcb9ba Processors support for StorageXDBC reading. 2020-02-17 18:32:27 +03:00
Nikolai Kochetov
728ece09f1 Processors support for StorageView reading. 2020-02-17 18:27:51 +03:00
Nikolai Kochetov
4cc3eaa9ce Processors support for StorageValues reading. 2020-02-17 18:07:42 +03:00
Nikolai Kochetov
5372942aef Processors support for StorageURL reading. 2020-02-17 18:01:03 +03:00
Pavel Kovalenko
cf474e1f09 Fixed DiskMemory->readFile() test. 2020-02-17 18:00:39 +03:00
Nikolai Kochetov
df76f1fe56 Processors support for StorageTinyLog reading. 2020-02-17 17:45:10 +03:00
Ivan Lezhankin
102dad0ca0 Merge branch 'master' into arcadia 2020-02-17 17:37:10 +03:00
Nikolai Kochetov
9eda64fcf7 Update SelectStreamFactory. 2020-02-17 17:28:44 +03:00
Ivan Lezhankin
39ea079034 More clean-up 2020-02-17 17:27:09 +03:00
Alexey Milovidov
809b409426 Read the code 2020-02-17 15:44:58 +03:00
Nikolai Kochetov
34e32db810 Fix build. 2020-02-17 14:55:32 +03:00
Nikolai Kochetov
bbdac39d2d Fix build. 2020-02-17 14:50:53 +03:00
Nikolai Kochetov
f4d5175a12 Fix build. 2020-02-17 14:26:09 +03:00
Pavel Kovalenko
f3bec50d22 Fixed getPositionInFile() method usages. 2020-02-17 13:49:36 +03:00
Pavel Kovalenko
f9965a7d29 Merge branch 'master' into storage-stripe-log-s3
# Conflicts:
#	dbms/tests/config/disks.xml
2020-02-17 13:46:06 +03:00
Nikolai Kochetov
4599fbd798 Added force_tree_shaped_pipeline flag to SelectQueryInfo. 2020-02-17 13:42:14 +03:00
chertus
c2d6167f2a Merge branch 'master' into joins 2020-02-17 13:19:15 +03:00
Nikolai Kochetov
9b2d03f58c Fix StorageMerge. 2020-02-17 12:26:15 +03:00
Alexey Milovidov
09e18f05ce Fixed error, added a test #9143 2020-02-17 09:54:24 +03:00
Alexey Milovidov
35e7197c8f Merge branch 'master' into bit-test-many-fuzz 2020-02-17 08:43:44 +03:00
Alexey Milovidov
b88238dffc Added 9th reason why parts can appear to be non byte-identical after download 2020-02-17 08:16:48 +03:00
alexey-milovidov
ca00c9c4cd
Merge pull request #9150 from ClickHouse/fix-bug-demangle
Fix bug in "demangle" function
2020-02-17 07:22:11 +03:00
alexey-milovidov
e0b6019878
Merge pull request #9014 from amosbird/joingetfix2
Fix joinGet with nullable return types.
2020-02-17 06:59:40 +03:00
alexey-milovidov
930cb5c3c3
Merge pull request #9152 from azat/poco-1.7.6-fix
Drop unused ALL_ADDRESSES const (fixes poco 1.7.6+dfsg1-5+deb9u1)
2020-02-17 06:58:35 +03:00
Amos Bird
0dee987831
Fix joinGet with nullable return types. 2020-02-17 07:32:32 +08:00
Azat Khuzhin
c2d7922413 Drop unused ALL_ADDRESSES const (fixes poco 1.7.6+dfsg1-5+deb9u1)
With poco 1.7.6+dfsg1-5+deb9u1:
  5  0x00007f9921e48085 in __cxa_throw ()
  6  0x00007f9918dfca88 in Poco::Net::IPAddress::IPAddress(void const*, unsigned int, unsigned int) () from /usr/lib/libPocoNet.so.46
  7  0x00007f9918dfcf91 in Poco::Net::IPAddress::operator&(Poco::Net::IPAddress const&) const () from /usr/lib/libPocoNet.so.46
  8  0x00007f991737a623 in DB::AllowedClientHosts::IPSubnet::set (this=0x7f991742afa0 <DB::(anonymous namespace)::ALL_ADDRESSES>, prefix_=..., mask_=...) at AllowedClientHosts.h:146
  9  0x00007f991737a2da in DB::AllowedClientHosts::IPSubnet::IPSubnet (this=0x7f991742afa0 <DB::(anonymous namespace)::ALL_ADDRESSES>, prefix_=..., mask_=...) at AllowedClientHosts.h:24
  10 0x00007f991737a0a2 in __static_initialization_and_destruction_0 (__initialize_p=1, __priority=65535) at AllowedClientHosts.cpp:25

Fixes: 2e4174a54c
2020-02-16 21:24:38 +03:00
Alexey Milovidov
01d4805989 Merge branch 'master' into bit-test-many-fuzz 2020-02-16 15:05:20 +03:00
Alexey Milovidov
9cd79c8a38 Fixed bug in "demangle" #8985 2020-02-16 14:55:45 +03:00
Alexey Milovidov
2e8d42a188 Additions to prev. revision 2020-02-16 13:44:24 +03:00
alexey-milovidov
355ff00c2e
Revert "Build fixes" 2020-02-16 11:48:01 +03:00
Ivan Lezhankin
4cedd4619d Code clean-up 2020-02-16 11:04:03 +03:00
Alexey Milovidov
724be6d08f Fixed fuzz test and incorrect behaviour of bitTestAll/Any functions 2020-02-16 09:46:29 +03:00
alexey-milovidov
41c883ace3
Merge pull request #8911 from millb/secure_password
Changed format for path in replicas
2020-02-16 07:17:12 +03:00
alexey-milovidov
4ebb240be6
Update Cluster.h 2020-02-16 07:13:54 +03:00
alexey-milovidov
5ebabe519f
Update Cluster.cpp 2020-02-16 07:12:48 +03:00
alexey-milovidov
480881563a
Slightly more readable. 2020-02-16 07:11:19 +03:00
alexey-milovidov
6f51f089ec
Merge pull request #9138 from ClickHouse/system-replicas-add-zookeeper-exception-column
Add zookeeper_exception column to system.replicas table.
2020-02-16 06:14:22 +03:00
alexey-milovidov
76f09ec883
Merge pull request #9052 from oandrew/reinterpret-fixedstring-bugfix
Use correct implementation for reinterpretAsFixedString
2020-02-16 06:11:13 +03:00
Alexey Milovidov
4ae404f794 Implement #9137 2020-02-15 03:13:00 +03:00
Alexey Milovidov
07479236d7 Implement #9137 2020-02-15 03:11:09 +03:00
alexey-milovidov
38c4f3ed84
Merge pull request #9131 from ClickHouse/better_temporary_live_view_syntax
Better CREATE syntax for temporary LIVE VIEW
2020-02-15 02:55:37 +03:00
alexey-milovidov
f836987f31
Merge pull request #9041 from proller/fix27
Build fixes
2020-02-15 02:51:18 +03:00
alexey-milovidov
4d0d32da23
Merge pull request #9091 from PerformanceVision/bit_on_bitset
Implement bit operations for FixedString datatype for doing bits operation on a bitset
2020-02-15 02:43:29 +03:00
alexey-milovidov
db1c67e3e3
Merge pull request #9100 from ClickHouse/issue-9094
Prevent abort on shutdown if the fs is readonly
2020-02-15 02:38:37 +03:00
CurtizJ
cb9936cbc4 better checking if we can use polymorphic parts 2020-02-15 00:33:02 +03:00
Alexander Kuzmenkov
51815044c5
Merge pull request #8943 from ClickHouse/aku/flush-perf
[wip] Improve flush performance in SystemLog
2020-02-14 22:41:44 +03:00
proller
cf39e9d64a Merge remote-tracking branch 'upstream/master' into fix27 2020-02-14 21:28:09 +03:00