Commit Graph

59532 Commits

Author SHA1 Message Date
Azat Khuzhin
65f90f2ce9 Fix distributed requests cancellation with async_socket_for_remote=1
Before this patch for distributed queries, that requires cancellation
(simple select from multiple shards with limit, i.e. `select * from
remote('127.{2,3}', system.numbers) limit 100`) it is very easy to
trigger the situation when remote shard is in the middle of sending Data
block while the initiator already send Cancel and expecting some new
packet, but it will receive not new packet, but part of the Data block
that was in the middle of sending before cancellation, and this will
lead to some various errors, like:
- Unknown packet X from server Y
- Unexpected packet from server Y
- and a lot more...

Fix this, by correctly waiting for the pending packet before
cancellation.

It is not very easy to write a test, since localhost is too fast.

Also note, that it is not possible to get these errors with hedged
requests (use_hedged_requests=1) since handle fibers correctly.

But it had been disabled by default for 21.3 in #21534, while
async_socket_for_remote is enabled by default.
2021-03-11 21:55:21 +03:00
Azat Khuzhin
69b2b2a159 Fix fsync_part_directory for horizontal merge 2021-03-11 21:41:27 +03:00
Alexander Kuzmenkov
ae8585a183
Merge pull request #21580 from azat/git--arcadia_skip_list-union-merge
[RFC] Union merge for arcadia_skip_list.txt to avoid frequent conflicts
2021-03-11 21:10:38 +03:00
Alexander Kuzmenkov
4d7f418916 cleanup 2021-03-11 19:57:28 +03:00
Alexander Kuzmenkov
2e2257e261
Update fuzzing-clickhouse.md 2021-03-11 19:26:01 +03:00
Nikolai Kochetov
cc60059b50
Merge pull request #21196 from ClickHouse/improve-performance-group-by-multiple-fixed-keys-2
Save packed keys for GROUP BY with multiple fixed size keys
2021-03-11 18:28:14 +03:00
Nikita Mikhaylov
8e68edebea better test 2021-03-11 18:22:24 +03:00
Nikita Mikhaylov
87eb2592de add input_format_skip_unknown_fields 2021-03-11 18:22:24 +03:00
Nikita Mikhaylov
b434a2f0bd disable parallel parsing for grpc tests 2021-03-11 18:22:24 +03:00
Nikita Mikhaylov
761b369fa2 move to poco::event 2021-03-11 18:22:24 +03:00
Nikita Mikhaylov
f3ee129074 fix grpc 2021-03-11 18:22:24 +03:00
Nikita Mikhaylov
e7a1398def try fix tests 2021-03-11 18:22:24 +03:00
Nikita Mikhaylov
3372dd7b6a fix stupid bug 2021-03-11 18:22:24 +03:00
Nikita Mikhailov
3a7d48f3a4 style and tsan fix 2021-03-11 18:22:24 +03:00
Nikita Mikhailov
369c9da161 better 2021-03-11 18:22:24 +03:00
alexey-milovidov
eab35bfc7f Update ParallelParsingInputFormat.h 2021-03-11 18:22:24 +03:00
Nikita Mikhailov
91a418b3a9 better 2021-03-11 18:22:24 +03:00
Nikita Mikhailov
8b30bb0fb5 style 2021-03-11 18:22:24 +03:00
Nikita Mikhailov
61fdeb5897 better 2021-03-11 18:22:24 +03:00
Nikita Mikhailov
138dedf2df done 2021-03-11 18:22:24 +03:00
Alexander Kuzmenkov
a2bedd592e
Merge pull request #21436 from azat/optimize_aggregation_in_order-log-fix
Fix logging for optimize_aggregation_in_order=1 (with small max_block_size)
2021-03-11 17:46:48 +03:00
Alexander Kuzmenkov
3303371b64
Merge pull request #21526 from azat/optimize_skip_unused_shards-once
Avoid processing optimize_skip_unused_shards twice
2021-03-11 17:31:37 +03:00
Nikita Mikhaylov
6928f2a409
Update pointInPolygon.cpp 2021-03-11 17:20:06 +03:00
Nikita Mikhaylov
b0577282eb
Update CMakeLists.txt 2021-03-11 17:19:03 +03:00
Alexander Kuzmenkov
3e5447ccec
Merge pull request #21480 from Avogar/slowdown_count
Add slowdown_count and show actual errors_count in system.clusters
2021-03-11 17:18:05 +03:00
Nikita Mikhaylov
38e1cb41cc done 2021-03-11 17:04:59 +03:00
feng lv
083299e549 redefine some errorcode 2021-03-11 13:54:11 +00:00
Nikita Mikhaylov
5ac5ae3b27
Merge pull request #21157 from CurtizJ/fix-type-map
Improve support of integer keys in data type Map
2021-03-11 15:49:57 +03:00
Vasily Nemkov
03bff5c3b5 Fixed test flakkiness 2021-03-11 14:47:20 +02:00
vdimir
1194d50e48
Try to fix test_storage_s3: crash in WriteBufferFromS3 2021-03-11 15:21:13 +03:00
Nikita Mikhaylov
b219b7626e better 2021-03-11 15:19:15 +03:00
Vladimir
08f312b1c4
Merge pull request #21457 from GrigoryPervakov/master
recreate S3 client if credentials changed
2021-03-11 15:18:39 +03:00
Nikita Mikhaylov
934b5bc487 Update 01700_point_in_polygon_ubsan.sql 2021-03-11 15:09:03 +03:00
Nikita Mikhaylov
eecc12ff6a suppress warnings and skip tests in arcadia 2021-03-11 15:09:03 +03:00
Nikita Mikhaylov
35d0b3d3ec better 2021-03-11 15:08:20 +03:00
Nikita Mikhaylov
7ecc78e014 fix tests after revert 2021-03-11 15:08:20 +03:00
Nikita Mikhaylov
0612d9ed09 Revert "mercator"
This reverts commit 27756c21d3691f270bcb36d0de271eed26f4c69a.
2021-03-11 15:08:20 +03:00
Nikita Mikhaylov
c81c742877 Revert "more mercator"
This reverts commit d4258922d1543211cf8b62f7c827a927712dca42.
2021-03-11 15:08:20 +03:00
Nikita Mikhaylov
a6779df0ae more tests 2021-03-11 15:08:20 +03:00
Nikita Mikhaylov
7e6d1d43fe more mercator 2021-03-11 15:08:20 +03:00
Nikita Mikhailov
9f3e0874e5 mercator 2021-03-11 15:08:20 +03:00
Nikita Mikhailov
803c3e3d2c better 2021-03-11 15:08:19 +03:00
Nikita Mikhailov
a6c8d50cc2 review fix 2021-03-11 15:08:19 +03:00
Nikita Mikhailov
0e1b2d8fcf geographic -> spherical 2021-03-11 15:08:19 +03:00
Nikita Mikhailov
ac03ba31bf move to spherical point 2021-03-11 15:08:19 +03:00
Nikita Mikhailov
94b6cadb77 better 2021-03-11 15:08:19 +03:00
Nikita Mikhailov
44f0edacb2 another try 2021-03-11 15:08:19 +03:00
Nikita Mikhailov
c87d7de8b9 fix unit test 2021-03-11 15:08:19 +03:00
Nikita Mikhailov
ec7d930980 better 2021-03-11 15:08:19 +03:00
Nikita Mikhailov
053a95674d unit test 2021-03-11 15:08:19 +03:00